capybara 3.16.1 → 3.33.0

data/lib/capybara/spec/session/first_spec.rb

@@ -24,7 +24,7 @@ Capybara::SpecHelper.spec '#first' do
 
   it 'should accept an XPath instance' do
     @session.visit('/form')
-    @xpath = Capybara::Selector[:fillable_field].call('First Name')
+    @xpath = Capybara::Selector.new(:fillable_field, config: {}, format: :xpath).call('First Name')
     expect(@xpath).to be_a(::XPath::Union)
     expect(@session.first(@xpath).value).to eq('John')
   end

data/lib/capybara/spec/session/frame/switch_to_frame_spec.rb

@@ -53,7 +53,20 @@ Capybara::SpecHelper.spec '#switch_to_frame', requires: [:frames] do
     @session.switch_to_frame frame
     frame = @session.find(:frame, 'childFrame')
     @session.switch_to_frame frame
-    @session.click_link 'Close Window'
+    @session.click_link 'Close Window Now'
+    @session.switch_to_frame :parent # Go back to parentFrame
+    expect(@session).to have_selector(:css, 'body#parentBody')
+    expect(@session).not_to have_selector(:css, '#childFrame')
+    @session.switch_to_frame :parent # Go back to top
+  end
+
+  it 'works if the frame is closed with a slight delay', requires: %i[frames js] do
+    frame = @session.find(:frame, 'parentFrame')
+    @session.switch_to_frame frame
+    frame = @session.find(:frame, 'childFrame')
+    @session.switch_to_frame frame
+    @session.click_link 'Close Window Soon'
+    sleep 1
     @session.switch_to_frame :parent # Go back to parentFrame
     expect(@session).to have_selector(:css, 'body#parentBody')
     expect(@session).not_to have_selector(:css, '#childFrame')

data/lib/capybara/spec/session/frame/within_frame_spec.rb

@@ -92,7 +92,18 @@ Capybara::SpecHelper.spec '#within_frame', requires: [:frames] do
   it 'works if the frame is closed', requires: %i[frames js] do
     @session.within_frame 'parentFrame' do
       @session.within_frame 'childFrame' do
-        @session.click_link 'Close Window'
+        @session.click_link 'Close Window Now'
+      end
+      expect(@session).to have_selector(:css, 'body#parentBody')
+      expect(@session).not_to have_selector(:css, '#childFrame')
+    end
+  end
+
+  it 'works if the frame is closed with a slight delay', requires: %i[frames js] do
+    @session.within_frame 'parentFrame' do
+      @session.within_frame 'childFrame' do
+        @session.click_link 'Close Window Soon'
+        sleep 1
       end
       expect(@session).to have_selector(:css, 'body#parentBody')
       expect(@session).not_to have_selector(:css, '#childFrame')

data/lib/capybara/spec/session/has_ancestor_spec.rb

@@ -0,0 +1,46 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#have_ancestor' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should assert an ancestor using the given locator' do
+    el = @session.find(:css, '#ancestor1')
+    expect(el).to have_ancestor(:css, '#ancestor2')
+  end
+
+  it 'should assert an ancestor even if not parent' do
+    el = @session.find(:css, '#child')
+    expect(el).to have_ancestor(:css, '#ancestor3')
+  end
+
+  it 'should not raise an error if there are multiple matches' do
+    el = @session.find(:css, '#child')
+    expect(el).to have_ancestor(:css, 'div')
+  end
+
+  it 'should allow counts to be specified' do
+    el = @session.find(:css, '#child')
+
+    expect do
+      expect(el).to have_ancestor(:css, 'div').once
+    end.to raise_error(RSpec::Expectations::ExpectationNotMetError)
+
+    expect(el).to have_ancestor(:css, 'div').exactly(3).times
+  end
+end
+
+Capybara::SpecHelper.spec '#have_no_ancestor' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should assert no matching ancestor' do
+    el = @session.find(:css, '#ancestor1')
+    expect(el).to have_no_ancestor(:css, '#child')
+    expect(el).to have_no_ancestor(:css, '#ancestor1_sibiling')
+    expect(el).not_to have_ancestor(:css, '#child')
+    expect(el).not_to have_ancestor(:css, '#ancestor1_sibiling')
+  end
+end

data/lib/capybara/spec/session/has_button_spec.rb

@@ -39,6 +39,14 @@ Capybara::SpecHelper.spec '#has_button?' do
     expect(@session).to have_button('awe123', type: 'submit')
     expect(@session).not_to have_button('awe123', type: 'reset')
   end
+
+  it 'should be true for role=button when enable_aria_role: true' do
+    expect(@session).to have_button('ARIA button', enable_aria_role: true)
+  end
+
+  it 'should be false for role=button when enable_aria_role: false' do
+    expect(@session).not_to have_button('ARIA button', enable_aria_role: false)
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_button?' do
@@ -66,4 +74,12 @@ Capybara::SpecHelper.spec '#has_no_button?' do
   it 'should be false for disabled buttons if disabled: false' do
     expect(@session).to have_no_button('Disabled button', disabled: false)
   end
+
+  it 'should be true for role=button when enable_aria_role: false' do
+    expect(@session).to have_no_button('ARIA button', enable_aria_role: false)
+  end
+
+  it 'should be false for role=button when enable_aria_role: true' do
+    expect(@session).not_to have_no_button('ARIA button', enable_aria_role: true)
+  end
 end

data/lib/capybara/spec/session/has_css_spec.rb

@@ -10,10 +10,11 @@ Capybara::SpecHelper.spec '#has_css?' do
     expect(@session).to have_css('p a#foo')
   end
 
-  it 'should take a symbol as the selector' do
+  it 'should warn when passed a symbol' do
     # This was never a specifically accepted format but it has worked for a
-    # lot of versions. Probably should keep it until at least 4.0
-    # TODO: consider not supporting symbol for the CSS selector.
+    # lot of versions.
+    # TODO: Remove in 4.0
+    expect_any_instance_of(Kernel).to receive(:warn) # rubocop:disable RSpec/AnyInstance
     expect(@session).to have_css(:p)
   end
 
@@ -146,7 +147,9 @@ Capybara::SpecHelper.spec '#has_css?' do
   context 'with count' do
     it 'should be true if the content occurs the given number of times' do
       expect(@session).to have_css('p', count: 3)
+      expect(@session).to have_css('p').exactly(3).times
       expect(@session).to have_css('p a#foo', count: 1)
+      expect(@session).to have_css('p a#foo').once
       expect(@session).to have_css('p a.doesnotexist', count: 0)
       expect(@session).to have_css('li', class: /guitar|drummer/, count: 4)
       expect(@session).to have_css('li', id: /john|paul/, class: /guitar|drummer/, count: 2)
@@ -161,6 +164,7 @@ Capybara::SpecHelper.spec '#has_css?' do
 
     it 'should be false if the content occurs a different number of times than the given' do
       expect(@session).not_to have_css('p', count: 6)
+      expect(@session).not_to have_css('p').exactly(5).times
       expect(@session).not_to have_css('p a#foo', count: 2)
       expect(@session).not_to have_css('p a.doesnotexist', count: 1)
     end
@@ -175,14 +179,16 @@ Capybara::SpecHelper.spec '#has_css?' do
     it 'should be true when content occurs same or fewer times than given' do
       expect(@session).to have_css('h2.head', maximum: 5) # edge case
       expect(@session).to have_css('h2', maximum: 10)
+      expect(@session).to have_css('h2').at_most(10).times
       expect(@session).to have_css('p a.doesnotexist', maximum: 1)
       expect(@session).to have_css('p a.doesnotexist', maximum: 0)
     end
 
     it 'should be false when content occurs more times than given' do
-      expect(@session).not_to have_css('h2.head', maximum: 4) # edge case
-      expect(@session).not_to have_css('h2', maximum: 3)
-      expect(@session).not_to have_css('p', maximum: 1)
+      # expect(@session).not_to have_css('h2.head', maximum: 4) # edge case
+      # expect(@session).not_to have_css('h2', maximum: 3)
+      expect(@session).not_to have_css('h2').at_most(3).times
+      # expect(@session).not_to have_css('p', maximum: 1)
     end
 
     it 'should coerce maximum to an integer' do
@@ -195,12 +201,14 @@ Capybara::SpecHelper.spec '#has_css?' do
     it 'should be true when content occurs same or more times than given' do
       expect(@session).to have_css('h2.head', minimum: 5) # edge case
       expect(@session).to have_css('h2', minimum: 3)
+      expect(@session).to have_css('h2').at_least(2).times
       expect(@session).to have_css('p a.doesnotexist', minimum: 0)
     end
 
     it 'should be false when content occurs fewer times than given' do
       expect(@session).not_to have_css('h2.head', minimum: 6) # edge case
       expect(@session).not_to have_css('h2', minimum: 8)
+      expect(@session).not_to have_css('h2').at_least(8).times
       expect(@session).not_to have_css('p', minimum: 10)
       expect(@session).not_to have_css('p a.doesnotexist', minimum: 1)
     end
@@ -223,6 +231,27 @@ Capybara::SpecHelper.spec '#has_css?' do
     end
   end
 
+  context 'with spatial requirements', requires: [:spatial] do
+    before do
+      @session.visit('/spatial')
+    end
+
+    let :center do
+      @session.find(:css, '.center')
+    end
+
+    it 'accepts spatial options' do
+      expect(@session).to have_css('div', above: center).thrice
+      expect(@session).to have_css('div', above: center, right_of: center).once
+    end
+
+    it 'supports spatial sugar' do
+      expect(@session).to have_css('div').left_of(center).thrice
+      expect(@session).to have_css('div').below(center).right_of(center).once
+      expect(@session).to have_css('div').near(center).exactly(8).times
+    end
+  end
+
   it 'should allow escapes in the CSS selector' do
     expect(@session).to have_css('p[data-random="abc\\\\def"]')
     expect(@session).to have_css("p[data-random='#{Capybara::Selector::CSS.escape('abc\def')}']")

data/lib/capybara/spec/session/has_current_path_spec.rb

@@ -81,7 +81,8 @@ Capybara::SpecHelper.spec '#has_current_path?' do
   end
 
   it 'should not raise an exception if the current_url is nil' do
-    allow_any_instance_of(Capybara::Session).to receive(:current_url).and_return(nil)
+    allow(@session).to receive(:current_url).and_return(nil)
+    allow(@session.page).to receive(:current_url).and_return(nil) if @session.respond_to? :page
 
     # Without ignore_query option
     expect do
@@ -121,16 +122,17 @@ Capybara::SpecHelper.spec '#has_no_current_path?' do
   end
 
   it 'should not raise an exception if the current_url is nil' do
-    allow_any_instance_of(Capybara::Session).to receive(:current_url).and_return(nil)
+    allow(@session).to receive(:current_url).and_return(nil)
+    allow(@session.page).to receive(:current_url).and_return(nil) if @session.respond_to? :page
 
     # Without ignore_query option
     expect do
       expect(@session).not_to have_current_path('/with_js')
-    end. not_to raise_exception
+    end.not_to raise_exception
 
     # With ignore_query option
     expect do
       expect(@session).not_to have_current_path('/with_js', ignore_query: true)
-    end. not_to raise_exception
+    end.not_to raise_exception
   end
 end

data/lib/capybara/spec/session/has_field_spec.rb

@@ -60,6 +60,22 @@ Capybara::SpecHelper.spec '#has_field' do
     end
   end
 
+  context 'with validation message', requires: [:html_validation] do
+    it 'should accept a regexp' do
+      @session.fill_in('form_zipcode', with: '1234')
+      expect(@session).to have_field('form_zipcode', validation_message: /match the requested format/)
+      expect(@session).not_to have_field('form_zipcode', validation_message: /random/)
+    end
+
+    it 'should accept a string' do
+      @session.fill_in('form_zipcode', with: '1234')
+      expect(@session).to have_field('form_zipcode', validation_message: 'Please match the requested format.')
+      expect(@session).not_to have_field('form_zipcode', validation_message: 'match the requested format.')
+      @session.fill_in('form_zipcode', with: '12345')
+      expect(@session).to have_field('form_zipcode', validation_message: '')
+    end
+  end
+
   context 'with type' do
     it 'should be true if a field with the given type is on the page' do
       expect(@session).to have_field('First Name', type: 'text')
@@ -93,6 +109,24 @@ Capybara::SpecHelper.spec '#has_field' do
       expect(@session).not_to have_field('Html5 Multiple Email', multiple: false)
     end
   end
+
+  context 'with valid', requires: [:js] do
+    it 'should be true if field is valid' do
+      @session.fill_in 'required', with: 'something'
+      @session.fill_in 'length', with: 'abcd'
+
+      expect(@session).to have_field('required', valid: true)
+      expect(@session).to have_field('length', valid: true)
+    end
+
+    it 'should be false if field is invalid' do
+      expect(@session).not_to have_field('required', valid: true)
+      expect(@session).to have_field('required', valid: false)
+
+      @session.fill_in 'length', with: 'abc'
+      expect(@session).not_to have_field('length', valid: true)
+    end
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_field' do

data/lib/capybara/spec/session/has_select_spec.rb

@@ -63,7 +63,7 @@ Capybara::SpecHelper.spec '#has_select?' do
     end
 
     it "should be true even when the selected option invisible, regardless of the select's visibility" do
-      expect(@session).to have_select('Icecream', visible: false, selected: 'Chocolate')
+      expect(@session).to have_select('Icecream', visible: :hidden, selected: 'Chocolate')
       expect(@session).to have_select('Sorbet', selected: 'Vanilla')
     end
   end
@@ -88,7 +88,7 @@ Capybara::SpecHelper.spec '#has_select?' do
     end
 
     it "should be true even when the selected values are invisible, regardless of the select's visibility" do
-      expect(@session).to have_select('Dessert', visible: false, with_options: %w[Pudding Tiramisu])
+      expect(@session).to have_select('Dessert', visible: :hidden, with_options: %w[Pudding Tiramisu])
       expect(@session).to have_select('Cake', with_selected: ['Chocolate Cake', 'Sponge Cake'])
     end
 
@@ -113,7 +113,35 @@ Capybara::SpecHelper.spec '#has_select?' do
     end
 
     it 'should be true even when the options are invisible, if the select itself is invisible' do
-      expect(@session).to have_select('Icecream', visible: false, options: %w[Chocolate Vanilla Strawberry])
+      expect(@session).to have_select('Icecream', visible: :hidden, options: %w[Chocolate Vanilla Strawberry])
+    end
+  end
+
+  context 'with enabled options' do
+    it 'should be true if the listed options exist and are enabled' do
+      expect(@session).to have_select('form_title', enabled_options: %w[Mr Mrs Miss])
+    end
+
+    it 'should be false if the listed options do not exist' do
+      expect(@session).not_to have_select('form_title', enabled_options: ['Not there'])
+    end
+
+    it 'should be false if the listed option exists but is not enabled' do
+      expect(@session).not_to have_select('form_title', enabled_options: %w[Mr Mrs Miss Other])
+    end
+  end
+
+  context 'with disabled options' do
+    it 'should be true if the listed options exist and are disabled' do
+      expect(@session).to have_select('form_title', disabled_options: ['Other'])
+    end
+
+    it 'should be false if the listed options do not exist' do
+      expect(@session).not_to have_select('form_title', disabled_options: ['Not there'])
+    end
+
+    it 'should be false if the listed option exists but is not disabled' do
+      expect(@session).not_to have_select('form_title', disabled_options: %w[Other Mrs])
     end
   end
 
@@ -130,7 +158,7 @@ Capybara::SpecHelper.spec '#has_select?' do
     end
 
     it 'should be true even when the options are invisible, if the select itself is invisible' do
-      expect(@session).to have_select('Icecream', visible: false, with_options: %w[Vanilla Strawberry])
+      expect(@session).to have_select('Icecream', visible: :hidden, with_options: %w[Vanilla Strawberry])
     end
   end
 

data/lib/capybara/spec/session/has_selector_spec.rb

@@ -61,12 +61,12 @@ Capybara::SpecHelper.spec '#has_selector?' do
     end
 
     it 'should respect visibility setting' do
-      expect(@session).to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: false)
-      expect(@session).not_to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: true)
+      expect(@session).to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :all)
+      expect(@session).not_to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :visible)
       Capybara.ignore_hidden_elements = false
-      expect(@session).to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: false)
+      expect(@session).to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :all)
       Capybara.visible_text_only = true
-      expect(@session).not_to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: true)
+      expect(@session).not_to have_selector(:id, 'hidden-text', text: 'Some of this text is hidden!', visible: :visible)
     end
 
     it 'should discard all matches where the given regexp is not matched' do

data/lib/capybara/spec/session/has_sibling_spec.rb

@@ -0,0 +1,50 @@
+# frozen_string_literal: true
+
+Capybara::SpecHelper.spec '#have_sibling' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should assert a prior sibling element using the given locator' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_sibling(:css, '#pre_sibling')
+  end
+
+  it 'should assert a following sibling element using the given locator' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_sibling(:css, '#post_sibling')
+  end
+
+  it 'should not raise an error if there are multiple matches' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_sibling(:css, 'div')
+  end
+
+  it 'should allow counts to be specified' do
+    el = @session.find(:css, '#mid_sibling')
+
+    expect(el).to have_sibling(:css, 'div').exactly(2).times
+    expect do
+      expect(el).to have_sibling(:css, 'div').once
+    end.to raise_error(RSpec::Expectations::ExpectationNotMetError)
+  end
+end
+
+Capybara::SpecHelper.spec '#have_no_sibling' do
+  before do
+    @session.visit('/with_html')
+  end
+
+  it 'should assert no matching sibling' do
+    el = @session.find(:css, '#mid_sibling')
+    expect(el).to have_no_sibling(:css, '#not_a_sibling')
+    expect(el).not_to have_sibling(:css, '#not_a_sibling')
+  end
+
+  it 'should raise if there are matching siblings' do
+    el = @session.find(:css, '#mid_sibling')
+    expect do
+      expect(el).to have_no_sibling(:css, '#pre_sibling')
+    end.to raise_error(RSpec::Expectations::ExpectationNotMetError)
+  end
+end

data/lib/capybara/spec/session/has_table_spec.rb

@@ -143,10 +143,56 @@ Capybara::SpecHelper.spec '#has_no_table?' do
      ])
   end
 
-  it 'should consider columns' do
-    expect(@session).to have_no_table('Vertical Headers', with_cols:
-      [
-        { 'First Name' => 'Joe' }
-      ])
+  context 'using :with_cols' do
+    it 'should consider a single column' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          { 'First Name' => 'Joe' }
+        ])
+    end
+
+    it 'should be true even if the last column does exist' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'What?',
+            'What?' => 'Walpole',
+            'City' => 'Oceanside' # This line makes the example fail
+          }
+        ])
+    end
+
+    it 'should be true if none of the columns exist' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'What?',
+            'What?' => 'Walpole',
+            'City' => 'What?'
+          }
+        ])
+    end
+
+    it 'should be true if the first column does match' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'Thomas',
+            'Last Name' => 'What',
+            'City' => 'What'
+          }
+        ])
+    end
+
+    it 'should be true if none of the columns match' do
+      expect(@session).to have_no_table('Vertical Headers', with_cols:
+        [
+          {
+            'First Name' => 'What',
+            'Last Name' => 'What',
+            'City' => 'What'
+          }
+        ])
+    end
   end
 end