capybara 2.5.0 → 2.18.0

data/spec/fixtures/selenium_driver_rspec_failure.rb

@@ -1,8 +1,12 @@
+# frozen_string_literal: true
 require 'spec_helper'
+require 'selenium-webdriver'
 
 RSpec.describe Capybara::Selenium::Driver do
   it "should exit with a non-zero exit status" do
-    browser = Capybara::Selenium::Driver.new(TestApp).browser
+    options = { browser: (ENV['SELENIUM_BROWSER'] || :firefox).to_sym }
+    options[:desired_capabilities] = Selenium::WebDriver::Remote::Capabilities.firefox(marionette: false) if ENV['LEGACY_FIREFOX']
+    browser = Capybara::Selenium::Driver.new(TestApp, options).browser
     expect(true).to eq(false)
   end
 end

data/spec/fixtures/selenium_driver_rspec_success.rb

@@ -1,8 +1,12 @@
+# frozen_string_literal: true
 require 'spec_helper'
+require 'selenium-webdriver'
 
 RSpec.describe Capybara::Selenium::Driver do
   it "should exit with a zero exit status" do
-    browser = Capybara::Selenium::Driver.new(TestApp).browser
+    options = { browser: (ENV['SELENIUM_BROWSER'] || :firefox).to_sym }
+    options[:desired_capabilities] = Selenium::WebDriver::Remote::Capabilities.firefox(marionette: false) if ENV['LEGACY_FIREFOX']
+    browser = Capybara::Selenium::Driver.new(TestApp, options ).browser
     expect(true).to eq(true)
   end
 end

data/spec/minitest_spec.rb

@@ -0,0 +1,130 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'capybara/minitest'
+
+class MinitestTest < Minitest::Test
+  include Capybara::DSL
+  include Capybara::Minitest::Assertions
+
+  def setup
+    visit('/form')
+  end
+
+  def teardown
+    Capybara.reset_sessions!
+  end
+
+  def test_assert_text
+    assert_text('Form')
+    assert_no_text('Not on the page')
+    refute_text('Also Not on the page')
+  end
+
+  def test_assert_title
+    visit('/with_title')
+    assert_title('Test Title')
+    assert_no_title('Not the title')
+    refute_title('Not the title')
+  end
+
+  def test_assert_current_path
+    assert_current_path('/form')
+    assert_no_current_path('/not_form')
+    refute_current_path('/not_form')
+  end
+
+  def test_assert_xpath
+    assert_xpath('.//select[@id="form_title"]')
+    assert_xpath('.//select', count: 1) { |el| el[:id] == "form_title" }
+    assert_no_xpath('.//select[@id="not_form_title"]')
+    assert_no_xpath('.//select') { |el| el[:id] == "not_form_title"}
+    refute_xpath('.//select[@id="not_form_title"]')
+  end
+
+  def test_assert_css
+    assert_css('select#form_title')
+    assert_no_css('select#not_form_title')
+  end
+
+  def test_assert_link
+    visit('/with_html')
+    assert_link('A link')
+    assert_link(count: 1){ |el| el.text == 'A link'}
+    assert_no_link('Not on page')
+  end
+
+  def test_assert_button
+    assert_button('fresh_btn')
+    assert_button(count: 1){ |el| el[:id] == 'fresh_btn' }
+    assert_no_button('not_btn')
+  end
+
+  def test_assert_field
+    assert_field('customer_email')
+    assert_no_field('not_on_the_form')
+  end
+
+  def test_assert_select
+    assert_select('form_title')
+    assert_no_select('not_form_title')
+  end
+
+  def test_assert_checked_field
+    assert_checked_field('form_pets_dog')
+    assert_no_checked_field('form_pets_cat')
+    refute_checked_field('form_pets_snake')
+  end
+
+  def test_assert_unchecked_field
+    assert_unchecked_field('form_pets_cat')
+    assert_no_unchecked_field('form_pets_dog')
+    refute_unchecked_field('form_pets_snake')
+  end
+
+  def test_assert_table
+    visit('/tables')
+    assert_table('agent_table')
+    assert_no_table('not_on_form')
+    refute_table('not_on_form')
+  end
+
+  def test_assert_all_of_selectors
+    assert_all_of_selectors(:css, 'select#form_other_title', 'input#form_last_name')
+  end
+
+  def test_assert_none_of_selectors
+    assert_none_of_selectors(:css, 'input#not_on_page', 'input#also_not_on_page')
+  end
+
+  def test_assert_matches_selector
+    assert_matches_selector(find(:field, 'customer_email'), :field, 'customer_email')
+    assert_not_matches_selector(find(:select, 'form_title'), :field, 'customer_email')
+    refute_matches_selector(find(:select, 'form_title'), :field, 'customer_email')
+  end
+
+  def test_assert_matches_css
+    assert_matches_css(find(:select, 'form_title'), 'select#form_title')
+    refute_matches_css(find(:select, 'form_title'), 'select#form_other_title')
+  end
+
+  def test_assert_matches_xpath
+    assert_matches_xpath(find(:select, 'form_title'), './/select[@id="form_title"]')
+    refute_matches_xpath(find(:select, 'form_title'), './/select[@id="form_other_title"]')
+  end
+end
+
+RSpec.describe 'capybara/minitest' do
+  before do
+    Capybara.current_driver = :rack_test
+    Capybara.app = TestApp
+  end
+
+  it "should support minitest" do
+    output = StringIO.new
+    reporter = Minitest::SummaryReporter.new(output)
+    reporter.start
+    MinitestTest.run reporter, {}
+    reporter.report
+    expect(output.string).to include("17 runs, 44 assertions, 0 failures, 0 errors, 0 skips")
+  end
+end

data/spec/minitest_spec_spec.rb

@@ -0,0 +1,135 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'capybara/minitest'
+require 'capybara/minitest/spec'
+
+class MinitestSpecTest < Minitest::Spec
+  include ::Capybara::DSL
+  include ::Capybara::Minitest::Assertions
+
+  before do
+    visit('/form')
+  end
+  after do
+    Capybara.reset_sessions!
+  end
+
+  it "supports text expectations" do
+    page.must_have_text('Form', minimum: 1)
+    page.wont_have_text('Not a form')
+    form = find(:css, 'form', text: 'Title')
+    form.must_have_text('Customer Email')
+    form.wont_have_text('Some other email')
+  end
+
+  it "supports current_path expectations" do
+    page.must_have_current_path('/form')
+    page.wont_have_current_path('/form2')
+  end
+
+  it "supports title expectations" do
+    visit('/with_title')
+    page.must_have_title('Test Title')
+    page.wont_have_title('Not the title')
+  end
+
+  it "supports xpath expectations" do
+    page.must_have_xpath('.//input[@id="customer_email"]')
+    page.wont_have_xpath('.//select[@id="not_form_title"]')
+    page.wont_have_xpath('.//input[@id="customer_email"]') { |el| el[:id] == "not_customer_email" }
+    select = find(:select, 'form_title')
+    select.must_have_xpath('.//option[@class="title"]')
+    select.must_have_xpath('.//option', count: 1) { |option| option[:class] != 'title' && !option.disabled?}
+    select.wont_have_xpath('.//input[@id="customer_email"]')
+  end
+
+  it "support css expectations" do
+    page.must_have_css('input#customer_email')
+    page.wont_have_css('select#not_form_title')
+    el = find(:select, 'form_title')
+    el.must_have_css('option.title')
+    el.wont_have_css('input#customer_email')
+  end
+
+  it "supports link expectations" do
+    visit('/with_html')
+    page.must_have_link('A link')
+    page.wont_have_link('Not on page')
+  end
+
+  it "supports button expectations" do
+    page.must_have_button('fresh_btn')
+    page.wont_have_button('not_btn')
+  end
+
+  it "supports field expectations" do
+    page.must_have_field('customer_email')
+    page.wont_have_field('not_on_the_form')
+  end
+
+  it "supports select expectations" do
+    page.must_have_select('form_title')
+    page.wont_have_select('not_form_title')
+  end
+
+  it "supports checked_field expectations" do
+    page.must_have_checked_field('form_pets_dog')
+    page.wont_have_checked_field('form_pets_cat')
+  end
+
+  it "supports unchecked_field expectations" do
+    page.must_have_unchecked_field('form_pets_cat')
+    page.wont_have_unchecked_field('form_pets_dog')
+  end
+
+  it "supports table expectations" do
+    visit('/tables')
+    page.must_have_table('agent_table')
+    page.wont_have_table('not_on_form')
+  end
+
+  it "supports all_of_selectors expectations" do
+    page.must_have_all_of_selectors(:css, 'select#form_other_title', 'input#form_last_name')
+  end
+
+  it "supports none_of_selectors expectations" do
+    page.must_have_none_of_selectors(:css, 'input#not_on_page', 'input#also_not_on_page')
+  end
+
+  it "supports match_selector expectations" do
+    find(:field, 'customer_email').must_match_selector(:field, 'customer_email')
+    find(:select, 'form_title').wont_match_selector(:field, 'customer_email')
+  end
+
+  it "supports match_css expectations" do
+    find(:select, 'form_title').must_match_css('select#form_title')
+    find(:select, 'form_title').wont_match_css('select#form_other_title')
+  end
+
+  it "supports match_xpath expectations" do
+    find(:select, 'form_title').must_match_xpath('.//select[@id="form_title"]')
+    find(:select, 'form_title').wont_match_xpath('.//select[@id="not_on_page"]')
+  end
+
+  it "handles failures" do
+    page.must_have_select('non_existing_form_title')
+  end
+end
+
+RSpec.describe 'capybara/minitest/spec' do
+  before do
+    Capybara.current_driver = :rack_test
+    Capybara.app = TestApp
+  end
+
+  it "should support minitest spec" do
+    output = StringIO.new
+    reporter = Minitest::SummaryReporter.new(output)
+    reporter.start
+    MinitestSpecTest.run reporter, {}
+    reporter.report
+    expect(output.string).to include("18 runs, 41 assertions, 1 failures, 0 errors, 0 skips")
+    #Make sure error messages are displayed
+    expect(output.string).to include('expected to find visible select box "non_existing_form_title" that is not disabled but there were no matches')
+  end
+end

data/spec/per_session_config_spec.rb

@@ -0,0 +1,67 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'capybara/dsl'
+
+RSpec.describe Capybara::SessionConfig do
+  describe "threadsafe" do
+    it "defaults to global session options" do
+      Capybara.threadsafe = true
+      session = Capybara::Session.new(:rack_test, TestApp)
+      [:default_host, :app_host, :save_and_open_page_path,
+       :always_include_port, :run_server, :default_selector, :default_max_wait_time, :ignore_hidden_elements,
+       :automatic_reload, :match, :exact, :raise_server_errors, :visible_text_only, :wait_on_first_by_default,
+       :automatic_label_click, :enable_aria_label,
+       :save_path, :exact_options, :asset_host].each do |m|
+         expect(session.config.public_send(m)).to eq Capybara.public_send(m)
+       end
+    end
+
+    it "doesn't change global session when changed" do
+      Capybara.threadsafe = true
+      host = "http://my.example.com"
+      session = Capybara::Session.new(:rack_test, TestApp) do |config|
+        config.default_host = host
+        config.automatic_label_click = !config.automatic_label_click
+        config.server_errors << ArgumentError
+      end
+      expect(Capybara.default_host).not_to eq host
+      expect(session.config.default_host).to eq host
+      expect(Capybara.automatic_label_click).not_to eq session.config.automatic_label_click
+      expect(Capybara.server_errors).not_to eq session.config.server_errors
+    end
+
+    it "doesn't allow session configuration block when false" do
+      Capybara.threadsafe = false
+      expect do
+        Capybara::Session.new(:rack_test, TestApp) { |config| }
+      end.to raise_error "A configuration block is only accepted when Capybara.threadsafe == true"
+    end
+
+    it "doesn't allow session config when false" do
+      Capybara.threadsafe = false
+      session = Capybara::Session.new(:rack_test, TestApp)
+      expect { session.config.default_selector = :title }.to raise_error(/Per session settings are only supported when Capybara.threadsafe == true/)
+      expect do
+        session.configure do |config|
+          config.exact = true
+        end
+      end.to raise_error(/Session configuration is only supported when Capybara.threadsafe == true/)
+    end
+
+    it "uses the config from the session" do
+      Capybara.threadsafe = true
+      session = Capybara::Session.new(:rack_test, TestApp) do |config|
+        config.default_selector = :link
+      end
+      session.visit('/with_html')
+      expect(session.find('foo').tag_name).to eq 'a'
+    end
+
+    it "won't change threadsafe once a session is created" do
+      Capybara.threadsafe = true
+      Capybara.threadsafe = false
+      Capybara::Session.new(:rack_test, TestApp)
+      expect { Capybara.threadsafe = true }.to raise_error(/Threadsafe setting cannot be changed once a session is created/)
+    end
+  end
+end

data/spec/rack_test_spec.rb

@@ -1,10 +1,11 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 module TestSessions
   RackTest = Capybara::Session.new(:rack_test, TestApp)
 end
 
-Capybara::SpecHelper.run_specs TestSessions::RackTest, "RackTest", :capybara_skip => [
+Capybara::SpecHelper.run_specs TestSessions::RackTest, "RackTest", capybara_skip: [
   :js,
   :modals,
   :screenshot,
@@ -78,6 +79,48 @@ RSpec.describe Capybara::Session do
           expect(@session.html).to include('Successfully ignored empty file field.')
         end
       end
+
+      it "should not submit an obsolete mime type" do
+        @test_jpg_file_path = File.expand_path('fixtures/capybara.csv', File.dirname(__FILE__))
+        @session.visit("/form")
+        @session.attach_file "form_document", @test_jpg_file_path
+        @session.click_button('Upload Single')
+        expect(@session).to have_content("Content-type: text/csv")
+      end
+    end
+
+    describe "#click" do
+      context "on a label" do
+        it "should toggle the associated checkbox" do
+          @session.visit("/form")
+          expect(@session).to have_unchecked_field('form_pets_cat')
+          @session.find(:label, 'Cat').click
+          expect(@session).to have_checked_field('form_pets_cat')
+          @session.find(:label, 'Cat').click
+          expect(@session).to have_unchecked_field('form_pets_cat')
+          @session.find(:label, 'McLaren').click
+          expect(@session).to have_checked_field('form_cars_mclaren', visible: :hidden)
+        end
+
+        it "should toggle the associated radio" do
+          @session.visit("/form")
+          expect(@session).to have_unchecked_field('gender_male')
+          @session.find(:label, 'Male').click
+          expect(@session).to have_checked_field('gender_male')
+          @session.find(:label, 'Female').click
+          expect(@session).to have_unchecked_field('gender_male')
+        end
+      end
+    end
+
+    describe '#text' do
+      it "should return original text content for textareas" do
+        @session.visit('/with_html')
+        @session.find_field('normal', type: 'textarea', with: 'banana').set('hello')
+        normal = @session.find(:css, '#normal')
+        expect(normal.value).to eq 'hello'
+        expect(normal.text).to eq 'banana'
+      end
     end
   end
 end
@@ -89,27 +132,27 @@ RSpec.describe Capybara::RackTest::Driver do
 
   describe ':headers option' do
     it 'should always set headers' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, :headers => {'HTTP_FOO' => 'foobar'})
+      @driver = Capybara::RackTest::Driver.new(TestApp, headers: {'HTTP_FOO' => 'foobar'})
       @driver.visit('/get_header')
       expect(@driver.html).to include('foobar')
     end
 
     it 'should keep headers on link clicks' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, :headers => {'HTTP_FOO' => 'foobar'})
+      @driver = Capybara::RackTest::Driver.new(TestApp, headers: {'HTTP_FOO' => 'foobar'})
       @driver.visit('/header_links')
       @driver.find_xpath('.//a').first.click
       expect(@driver.html).to include('foobar')
     end
 
     it 'should keep headers on form submit' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, :headers => {'HTTP_FOO' => 'foobar'})
+      @driver = Capybara::RackTest::Driver.new(TestApp, headers: {'HTTP_FOO' => 'foobar'})
       @driver.visit('/header_links')
       @driver.find_xpath('.//input').first.click
       expect(@driver.html).to include('foobar')
     end
 
     it 'should keep headers on redirects' do
-      @driver = Capybara::RackTest::Driver.new(TestApp, :headers => {'HTTP_FOO' => 'foobar'})
+      @driver = Capybara::RackTest::Driver.new(TestApp, headers: {'HTTP_FOO' => 'foobar'})
       @driver.visit('/get_header_via_redirect')
       expect(@driver.html).to include('foobar')
     end
@@ -125,7 +168,7 @@ RSpec.describe Capybara::RackTest::Driver do
     end
 
     it "is possible to not follow redirects" do
-      @driver = Capybara::RackTest::Driver.new(TestApp, :follow_redirects => false)
+      @driver = Capybara::RackTest::Driver.new(TestApp, follow_redirects: false)
 
       @driver.visit('/redirect')
       expect(@driver.response.header['Location']).to match %r{/redirect_again$}
@@ -153,7 +196,7 @@ RSpec.describe Capybara::RackTest::Driver do
 
     context "with 21 redirect limit" do
       before do
-        @driver = Capybara::RackTest::Driver.new(TestApp, :redirect_limit => 21)
+        @driver = Capybara::RackTest::Driver.new(TestApp, redirect_limit: 21)
       end
 
       it "should follow 21 redirects" do

data/spec/result_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 
 RSpec.describe Capybara::Result do
@@ -62,4 +63,79 @@ RSpec.describe Capybara::Result do
       el.text == 'Gamma'
     end).to eq(2)
   end
+
+  it 'supports all modes of []' do
+    expect(result[1].text).to eq 'Beta'
+    expect(result[0,2].map(&:text)).to eq ['Alpha', 'Beta']
+    expect(result[1..3].map(&:text)).to eq ['Beta', 'Gamma', 'Delta']
+    expect(result[-1].text).to eq 'Delta'
+  end
+
+  it 'works with filter blocks' do
+    result = string.all('//li') { |node| node.text == 'Alpha' }
+    expect(result.size).to eq 1
+  end
+
+  it 'should catch invalid element errors during filtering' do
+    allow_any_instance_of(Capybara::Node::Simple).to receive(:text).and_raise(StandardError)
+    allow_any_instance_of(Capybara::Node::Simple).to receive(:session).and_return(double("session", driver: double("driver", invalid_element_errors: [StandardError] )))
+    result = string.all('//li', text: 'Alpha')
+    expect(result.size).to eq 0
+  end
+
+  it 'should return non-invalid element errors during filtering' do
+    allow_any_instance_of(Capybara::Node::Simple).to receive(:text).and_raise(StandardError)
+    allow_any_instance_of(Capybara::Node::Simple).to receive(:session).and_return(double("session", driver: double("driver", invalid_element_errors: [ArgumentError] )))
+    expect do
+      string.all('//li', text: 'Alpha').to_a
+    end.to raise_error(StandardError)
+  end
+
+  #Not a great test but it indirectly tests what is needed
+  it "should evaluate filters lazily" do
+    skip 'JRuby has an issue with lazy enumerator evaluation' if RUBY_PLATFORM == 'java'
+    #Not processed until accessed
+    expect(result.instance_variable_get('@result_cache').size).to be 0
+
+    #Only one retrieved when needed
+    result.first
+    expect(result.instance_variable_get('@result_cache').size).to be 1
+
+    #works for indexed access
+    result[0]
+    expect(result.instance_variable_get('@result_cache').size).to be 1
+
+    result[2]
+    expect(result.instance_variable_get('@result_cache').size).to be 3
+
+    #All cached when converted to array
+    result.to_a
+    expect(result.instance_variable_get('@result_cache').size).to eq 4
+  end
+
+  context '#each' do
+    it 'lazily evaluates' do
+      skip 'JRuby has an issue with lazy enumerator evaluation' if RUBY_PLATFORM == 'java'
+      results=[]
+      result.each do |el|
+        results << el
+        expect(result.instance_variable_get('@result_cache').size).to eq results.size
+      end
+
+      expect(results.size).to eq 4
+    end
+
+    context 'without a block' do
+      it 'returns an iterator' do
+        expect(result.each).to be_a(Enumerator)
+      end
+
+      it 'lazily evaluates' do
+        skip 'JRuby has an issue with lazy enumerator evaluation' if RUBY_PLATFORM == 'java'
+        result.each.with_index do |el, idx|
+          expect(result.instance_variable_get('@result_cache').size).to eq(idx+1)  # 0 indexing
+        end
+      end
+    end
+  end
 end

data/spec/rspec/features_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'spec_helper'
 require 'capybara/rspec'
 
@@ -5,11 +6,11 @@ RSpec.configuration.before(:each, { file_path: "./spec/rspec/features_spec.rb" }
   @in_filtered_hook = true
 end
 
-feature "Capybara's feature DSL" do    
+feature "Capybara's feature DSL" do
   background do
     @in_background = true
   end
-  
+
   def current_example(context)
     RSpec.respond_to?(:current_example) ? RSpec.current_example : context.example
   end
@@ -19,7 +20,7 @@ feature "Capybara's feature DSL" do
     expect(page).to have_content('Hello world!')
   end
 
-  scenario "preserves description" do 
+  scenario "preserves description" do
     expect(current_example(self).metadata[:full_description])
       .to eq("Capybara's feature DSL preserves description")
   end
@@ -70,13 +71,25 @@ feature "given and given! aliases to let and let!" do
   end
 end
 
-feature "if xscenario aliases to pending then" do
-  xscenario "this test should be 'temporarily disabled with xscenario'" do
-  end
-end
-
 feature "Capybara's feature DSL with driver", :driver => :culerity do
   scenario "switches driver" do
     expect(Capybara.current_driver).to eq(:culerity)
   end
 end
+
+if RSpec::Core::Version::STRING.to_f >= 3.0
+  xfeature "if xfeature aliases to pending then" do
+    scenario "this should be 'temporarily disabled with xfeature'" do; end
+    scenario "this also should be 'temporarily disabled with xfeature'" do; end
+  end
+
+  ffeature "if ffeature aliases focused tag then" do
+    scenario "scenario inside this feature has metatag focus tag" do |example|
+      expect(example.metadata[:focus]).to eq true
+    end
+
+    scenario "other scenarios also has metatag focus tag " do |example|
+      expect(example.metadata[:focus]).to eq true
+    end
+  end
+end

data/spec/rspec/scenarios_spec.rb

@@ -0,0 +1,21 @@
+# frozen_string_literal: true
+require 'spec_helper'
+require 'capybara/rspec'
+
+RSpec.configuration.before(:each, { file_path: "./spec/rspec/scenarios_spec.rb" } ) do
+  @in_filtered_hook = true
+end
+
+if RSpec::Core::Version::STRING.to_f >= 3.0
+  feature "if fscenario aliases focused tag then" do
+    fscenario "scenario should have focused meta tag" do |example|
+      expect(example.metadata[:focus]).to eq true
+    end
+  end
+end
+
+feature "if xscenario aliases to pending then" do
+  xscenario "this test should be 'temporarily disabled with xscenario'" do
+  end
+end
+