capybara 2.5.0 → 2.18.0

data/lib/capybara/spec/session/evaluate_async_script_spec.rb

@@ -0,0 +1,22 @@
+# frozen_string_literal: true
+Capybara::SpecHelper.spec "#evaluate_async_script", requires: [:js] do
+  it "should evaluate the given script and return whatever it produces" do
+    @session.visit('/with_js')
+    expect(@session.evaluate_async_script("arguments[0](4)")).to eq(4)
+  end
+
+  it "should support passing elements as arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    el = @session.find(:css, '#drag p')
+    result = @session.evaluate_async_script("arguments[2]([arguments[0].innerText, arguments[1]])", el, "Doodle Funk")
+    expect(result).to eq ["This is a draggable element.", "Doodle Funk"]
+  end
+
+  it "should support returning elements after asynchronous operation", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    @session.find(:css, '#change') # ensure page has loaded and element is available
+    el = @session.evaluate_async_script("var cb = arguments[0]; setTimeout(function(){ cb(document.getElementById('change')) }, 100)")
+    expect(el).to be_instance_of(Capybara::Node::Element)
+    expect(el).to eq(@session.find(:css, '#change'))
+  end
+end

data/lib/capybara/spec/session/evaluate_script_spec.rb

@@ -1,6 +1,28 @@
-Capybara::SpecHelper.spec "#evaluate_script", :requires => [:js] do
+# frozen_string_literal: true
+Capybara::SpecHelper.spec "#evaluate_script", requires: [:js] do
   it "should evaluate the given script and return whatever it produces" do
     @session.visit('/with_js')
     expect(@session.evaluate_script("1+3")).to eq(4)
   end
+
+  it "should pass arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    @session.evaluate_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
+
+  it "should support passing elements as arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    el = @session.find(:css, '#change')
+    @session.evaluate_script("arguments[0].textContent = arguments[1]", el, "Doodle Funk")
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
+
+  it "should support returning elements", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    @session.find(:css, '#change') # ensure page has loaded and element is available
+    el = @session.evaluate_script("document.getElementById('change')")
+    expect(el).to be_instance_of(Capybara::Node::Element)
+    expect(el).to eq(@session.find(:css, '#change'))
+  end
 end

data/lib/capybara/spec/session/execute_script_spec.rb

@@ -1,7 +1,26 @@
-Capybara::SpecHelper.spec "#execute_script", :requires => [:js] do
+# frozen_string_literal: true
+Capybara::SpecHelper.spec "#execute_script", requires: [:js] do
   it "should execute the given script and return nothing" do
     @session.visit('/with_js')
-    expect(@session.execute_script("$('#change').text('Funky Doodle')")).to be_nil
-    expect(@session).to have_css('#change', :text => 'Funky Doodle')
+    expect(@session.execute_script("document.getElementById('change').textContent = 'Funky Doodle'")).to be_nil
+    expect(@session).to have_css('#change', text: 'Funky Doodle')
+  end
+
+  it "should be able to call functions defined in the page" do
+    @session.visit('/with_js')
+    expect{ @session.execute_script("$('#change').text('Funky Doodle')") }.not_to raise_error
+  end
+
+  it "should pass arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    @session.execute_script("document.getElementById('change').textContent = arguments[0]", "Doodle Funk")
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
+  end
+
+  it "should support passing elements as arguments to the script", requires: [:js, :es_args] do
+    @session.visit('/with_js')
+    el = @session.find(:css, '#change')
+    @session.execute_script("arguments[1].textContent = arguments[0]", "Doodle Funk", el)
+    expect(@session).to have_css('#change', text: 'Doodle Funk')
   end
 end

data/lib/capybara/spec/session/fill_in_spec.rb

@@ -1,141 +1,154 @@
+# frozen_string_literal: true
 Capybara::SpecHelper.spec "#fill_in" do
   before do
     @session.visit('/form')
   end
 
   it "should fill in a text field by id" do
-    @session.fill_in('form_first_name', :with => 'Harry')
+    @session.fill_in('form_first_name', with: 'Harry')
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Harry')
   end
 
   it "should fill in a text field by name" do
-    @session.fill_in('form[last_name]', :with => 'Green')
+    @session.fill_in('form[last_name]', with: 'Green')
     @session.click_button('awesome')
     expect(extract_results(@session)['last_name']).to eq('Green')
   end
 
   it "should fill in a text field by label without for" do
-    @session.fill_in('First Name', :with => 'Harry')
+    @session.fill_in('First Name', with: 'Harry')
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Harry')
   end
 
   it "should fill in a url field by label without for" do
-    @session.fill_in('Html5 Url', :with => 'http://www.avenueq.com')
+    @session.fill_in('Html5 Url', with: 'http://www.avenueq.com')
     @session.click_button('html5_submit')
     expect(extract_results(@session)['html5_url']).to eq('http://www.avenueq.com')
   end
 
   it "should fill in a textarea by id" do
-    @session.fill_in('form_description', :with => 'Texty text')
+    @session.fill_in('form_description', with: 'Texty text')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('Texty text')
   end
 
   it "should fill in a textarea by label" do
-    @session.fill_in('Description', :with => 'Texty text')
+    @session.fill_in('Description', with: 'Texty text')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('Texty text')
   end
 
   it "should fill in a textarea by name" do
-    @session.fill_in('form[description]', :with => 'Texty text')
+    @session.fill_in('form[description]', with: 'Texty text')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('Texty text')
   end
 
   it "should fill in a password field by id" do
-    @session.fill_in('form_password', :with => 'supasikrit')
+    @session.fill_in('form_password', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
   it "should handle HTML in a textarea" do
-    @session.fill_in('form_description', :with => 'is <strong>very</strong> secret!')
+    @session.fill_in('form_description', with: 'is <strong>very</strong> secret!')
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq('is <strong>very</strong> secret!')
   end
 
   it "should handle newlines in a textarea" do
-    @session.fill_in('form_description', :with => "\nSome text\n")
+    @session.fill_in('form_description', with: "\nSome text\n")
     @session.click_button('awesome')
     expect(extract_results(@session)['description']).to eq("\r\nSome text\r\n")
   end
 
   it "should fill in a field with a custom type" do
-    @session.fill_in('Schmooo', :with => 'Schmooo is the game')
+    @session.fill_in('Schmooo', with: 'Schmooo is the game')
     @session.click_button('awesome')
     expect(extract_results(@session)['schmooo']).to eq('Schmooo is the game')
   end
 
   it "should fill in a field without a type" do
-    @session.fill_in('Phone', :with => '+1 555 7022')
+    @session.fill_in('Phone', with: '+1 555 7022')
     @session.click_button('awesome')
     expect(extract_results(@session)['phone']).to eq('+1 555 7022')
   end
 
   it "should fill in a text field respecting its maxlength attribute" do
-    @session.fill_in('Zipcode', :with => '52071350')
+    @session.fill_in('Zipcode', with: '52071350')
     @session.click_button('awesome')
     expect(extract_results(@session)['zipcode']).to eq('52071')
   end
 
   it "should fill in a password field by name" do
-    @session.fill_in('form[password]', :with => 'supasikrit')
+    @session.fill_in('form[password]', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
   it "should fill in a password field by label" do
-    @session.fill_in('Password', :with => 'supasikrit')
+    @session.fill_in('Password', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
   it "should fill in a password field by name" do
-    @session.fill_in('form[password]', :with => 'supasikrit')
+    @session.fill_in('form[password]', with: 'supasikrit')
     @session.click_button('awesome')
     expect(extract_results(@session)['password']).to eq('supasikrit')
   end
 
+  it "should fill in a field based on current value" do
+    @session.fill_in(currently_with: 'John', with: 'Thomas')
+    @session.click_button('awesome')
+    expect(extract_results(@session)['first_name']).to eq('Thomas')
+  end
+
+  it "should fill in a field based on type" do
+    @session.fill_in(type: 'schmooo', with: 'Schmooo for all')
+    @session.click_button('awesome')
+    expect(extract_results(@session)['schmooo']).to eq('Schmooo for all')
+  end
+
   it "should throw an exception if a hash containing 'with' is not provided" do
     expect {@session.fill_in 'Name', 'ignu'}.to raise_error(RuntimeError, /with/)
   end
 
-  it "should wait for asynchronous load", :requires => [:js] do
+  it "should wait for asynchronous load", requires: [:js] do
     @session.visit('/with_js')
     @session.click_link('Click me')
-    @session.fill_in('new_field', :with => 'Testing...')
+    @session.fill_in('new_field', with: 'Testing...')
   end
 
   it "casts to string" do
-    @session.fill_in(:'form_first_name', :with => :'Harry')
+    @session.fill_in(:'form_first_name', with: :'Harry')
     @session.click_button('awesome')
     expect(extract_results(@session)['first_name']).to eq('Harry')
   end
 
   it "casts to string if field has maxlength" do
-    @session.fill_in(:'form_zipcode', :with => 1234567)
+    @session.fill_in(:'form_zipcode', with: 1234567)
     @session.click_button('awesome')
     expect(extract_results(@session)['zipcode']).to eq('12345')
   end
 
-  context 'on a pre-populated textfield with a reformatting onchange', :requires => [:js] do
+  context 'on a pre-populated textfield with a reformatting onchange', requires: [:js] do
     it 'should only trigger onchange once' do
       @session.visit('/with_js')
-      @session.fill_in('with_change_event', :with => 'some value')
+      @session.fill_in('with_change_event', with: 'some value')
       # click outside the field to trigger the change event
       @session.find(:css, 'body').click
-      expect(@session.find(:css, '.change_event_triggered', :match => :one)).to have_text 'some value'
+      expect(@session.find(:css, '.change_event_triggered', match: :one)).to have_text 'some value'
     end
 
     it 'should trigger change when clearing field' do
       @session.visit('/with_js')
-      @session.fill_in('with_change_event', :with => '')
+      @session.fill_in('with_change_event', with: '')
       # click outside the field to trigger the change event
       @session.find(:css, 'body').click
-      expect(@session).to have_selector(:css, '.change_event_triggered', :match => :one)
+      expect(@session).to have_selector(:css, '.change_event_triggered', match: :one)
     end
   end
 
@@ -143,18 +156,18 @@ Capybara::SpecHelper.spec "#fill_in" do
     before { Capybara.ignore_hidden_elements = true }
     after  { Capybara.ignore_hidden_elements = false }
     it "should not find a hidden field" do
-      msg = "Unable to find field \"Super Secret\""
+      msg = "Unable to find visible field \"Super Secret\" that is not disabled"
       expect do
-        @session.fill_in('Super Secret', :with => '777')
+        @session.fill_in('Super Secret', with: '777')
       end.to raise_error(Capybara::ElementNotFound, msg)
     end
   end
 
   context "with a locator that doesn't exist" do
     it "should raise an error" do
-      msg = "Unable to find field \"does not exist\""
+      msg = "Unable to find visible field \"does not exist\" that is not disabled"
       expect do
-        @session.fill_in('does not exist', :with => 'Blah blah')
+        @session.fill_in('does not exist', with: 'Blah blah')
       end.to raise_error(Capybara::ElementNotFound, msg)
     end
   end
@@ -162,22 +175,27 @@ Capybara::SpecHelper.spec "#fill_in" do
   context "on a disabled field" do
     it "should raise an error" do
       expect do
-        @session.fill_in('Disabled Text Field', :with => 'Blah blah')
+        @session.fill_in('Disabled Text Field', with: 'Blah blah')
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      @session.fill_in("Explanation", :with => "Dude", :exact => false)
+      @session.fill_in("Explanation", with: "Dude", exact:  false)
       @session.click_button("awesome")
       expect(extract_results(@session)["name_explanation"]).to eq("Dude")
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.fill_in("Explanation", :with => "Dude", :exact => true)
+        @session.fill_in("Explanation", with: "Dude", exact:  true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  it "should return the element filled in" do
+    el = @session.find(:fillable_field, 'form_first_name')
+    expect(@session.fill_in('form_first_name', with: 'Harry')).to eq el
+  end
 end

data/lib/capybara/spec/session/find_button_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Capybara::SpecHelper.spec '#find_button' do
   before do
     @session.visit('/form')
@@ -8,6 +9,18 @@ Capybara::SpecHelper.spec '#find_button' do
     expect(@session.find_button('crap321').value).to eq("crappy")
   end
 
+  context "aria_label attribute with Capybara.enable_aria_label" do
+    it "should find when true" do
+      Capybara.enable_aria_label = true
+      expect(@session.find_button('Mediocre Button')[:id]).to eq("mediocre")
+    end
+
+    it "should not find when false" do
+      Capybara.enable_aria_label = false
+      expect { @session.find_button('Mediocre Button') }.to raise_error(Capybara::ElementNotFound)
+    end
+  end
+
   it "casts to string" do
     expect(@session.find_button(:'med')[:id]).to eq("mediocre")
   end
@@ -20,13 +33,41 @@ Capybara::SpecHelper.spec '#find_button' do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      expect(@session.find_button('What an Awesome', :exact => false)[:value]).to eq("awesome")
+      expect(@session.find_button('What an Awesome', exact:  false).value).to eq("awesome")
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.find_button('What an Awesome', :exact => true)
+        @session.find_button('What an Awesome', exact:  true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "with :disabled option" do
+    it "should find disabled buttons when true" do
+      expect(@session.find_button('Disabled button', disabled: true).value).to eq("Disabled button")
+    end
+
+    it "should not find disabled buttons when false" do
+      expect do
+        @session.find_button('Disabled button', disabled: false)
+      end.to raise_error(Capybara::ElementNotFound)
+    end
+
+    it "should default to not finding disabled buttons" do
+      expect do
+        @session.find_button('Disabled button')
+      end.to raise_error(Capybara::ElementNotFound)
+    end
+
+    it "should find disabled buttons when :all" do
+      expect(@session.find_button('Disabled button', disabled: :all).value).to eq("Disabled button")
+    end
+  end
+
+  context "without locator" do
+    it "should use options" do
+      expect(@session.find_button(disabled: true).value).to eq("Disabled button")
+    end
+  end
 end

data/lib/capybara/spec/session/find_by_id_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Capybara::SpecHelper.spec '#find_by_id' do
   before do
     @session.visit('/with_html')
@@ -19,12 +20,12 @@ Capybara::SpecHelper.spec '#find_by_id' do
 
   context "with :visible option" do
     it "finds invisible elements when `false`" do
-      expect(@session.find_by_id("hidden_via_ancestor", :visible => false).text(:all)).to match(/with hidden ancestor/)
+      expect(@session.find_by_id("hidden_via_ancestor", visible: false).text(:all)).to match(/with hidden ancestor/)
     end
 
     it "finds invisible elements when `false`" do
       expect do
-        @session.find_by_id("hidden_via_ancestor", :visible => true)
+        @session.find_by_id("hidden_via_ancestor", visible: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end

data/lib/capybara/spec/session/find_field_spec.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 Capybara::SpecHelper.spec '#find_field' do
   before do
     @session.visit('/form')
@@ -7,6 +8,21 @@ Capybara::SpecHelper.spec '#find_field' do
     expect(@session.find_field('Dog').value).to eq('dog')
     expect(@session.find_field('form_description').text).to eq('Descriptive text goes here')
     expect(@session.find_field('Region')[:name]).to eq('form[region]')
+    expect(@session.find_field('With Asterisk*')).to be
+  end
+
+  context "aria_label attribute with Capybara.enable_aria_label" do
+    it "should find when true" do
+      Capybara.enable_aria_label = true
+      expect(@session.find_field('Unlabelled Input')[:name]).to eq('form[which_form]')
+      # expect(@session.find_field('Emergency Number')[:id]).to eq('html5_tel')
+    end
+
+    it "should not find when false" do
+      Capybara.enable_aria_label = false
+      expect { @session.find_field('Unlabelled Input') }.to raise_error(Capybara::ElementNotFound)
+      # expect { @session.find_field('Emergency Number') }.to raise_error(Capybara::ElementNotFound)
+    end
   end
 
   it "casts to string" do
@@ -21,7 +37,7 @@ Capybara::SpecHelper.spec '#find_field' do
 
   it "should warn if filter option is invalid" do
     expect_any_instance_of(Kernel).to receive(:warn).
-      with('Invalid value nil passed to filter disabled')
+      with('Invalid value nil passed to filter disabled - defaulting to false')
     @session.find_field('Dog', disabled: nil)
   end
 
@@ -34,24 +50,26 @@ Capybara::SpecHelper.spec '#find_field' do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      expect(@session.find_field("Explanation", :exact => false)[:name]).to eq("form[name_explanation]")
+      expect(@session.find_field("Explanation", exact:  false)[:name]).to eq("form[name_explanation]")
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.find_field("Explanation", :exact => true)
+        @session.find_field("Explanation", exact:  true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
   context "with :disabled option" do
     it "should find disabled fields when true" do
-      expect(@session.find_field("Disabled Checkbox", :disabled => true)[:name]).to eq("form[disabled_checkbox]")
+      expect(@session.find_field("Disabled Checkbox", disabled: true)[:name]).to eq("form[disabled_checkbox]")
+      expect(@session.find_field("form_disabled_fieldset_child", disabled: true)[:name]).to eq("form[disabled_fieldset_child]")
+      expect(@session.find_field("form_disabled_fieldset_descendant", disabled: true)[:name]).to eq("form[disabled_fieldset_descendant]")
     end
 
     it "should not find disabled fields when false" do
       expect do
-        @session.find_field("Disabled Checkbox", :disabled => false)
+        @session.find_field("Disabled Checkbox", disabled: false)
       end.to raise_error(Capybara::ElementNotFound)
     end
 
@@ -60,8 +78,15 @@ Capybara::SpecHelper.spec '#find_field' do
         @session.find_field("Disabled Checkbox")
       end.to raise_error(Capybara::ElementNotFound)
     end
-  end
 
+    it "should find disabled fields when :all" do
+      expect(@session.find_field("Disabled Checkbox", disabled: :all)[:name]).to eq("form[disabled_checkbox]")
+    end
+
+    it "should find enabled fields when :all" do
+      expect(@session.find_field('Dog', disabled: :all).value).to eq('dog')
+    end
+  end
 
   context 'with :readonly option' do
     it "should find readonly fields when true" do
@@ -78,4 +103,15 @@ Capybara::SpecHelper.spec '#find_field' do
       end.to raise_error(Capybara::Ambiguous, /found 2 elements/)
     end
   end
+
+  context 'with no locator' do
+    it 'should use options to find the field' do
+      expect(@session.find_field(with: 'dog')['id']).to eq "form_pets_dog"
+    end
+  end
+
+  it "should accept an optional filter block" do
+    # this would be better done with the :with option but this is just a test
+    expect(@session.find_field('form[pets][]'){ |node| node.value == 'dog' }[:id]).to eq "form_pets_dog"
+  end
 end

data/lib/capybara/spec/session/find_link_spec.rb

@@ -1,13 +1,26 @@
+# frozen_string_literal: true
 Capybara::SpecHelper.spec '#find_link' do
   before do
     @session.visit('/with_html')
   end
 
-  it "should find any field" do
+  it "should find any link" do
     expect(@session.find_link('foo').text).to eq("ullamco")
     expect(@session.find_link('labore')[:href]).to match %r(/with_simple_html$)
   end
 
+  context "aria_label attribute with Capybara.enable_aria_label" do
+    it "should find when true" do
+      Capybara.enable_aria_label = true
+      expect(@session.find_link('Go to simple')[:href]).to match %r(/with_simple_html$)
+    end
+
+    it "should not find when false" do
+      Capybara.enable_aria_label = false
+      expect { @session.find_link('Go to simple') }.to raise_error(Capybara::ElementNotFound)
+    end
+  end
+
   it "casts to string" do
     expect(@session.find_link(:'foo').text).to eq("ullamco")
   end
@@ -20,13 +33,19 @@ Capybara::SpecHelper.spec '#find_link' do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      expect(@session.find_link('abo', :exact => false).text).to eq("labore")
+      expect(@session.find_link('abo', exact:  false).text).to eq("labore")
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.find_link('abo', :exact => true)
+        @session.find_link('abo', exact:  true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
+
+  context "without locator" do
+    it "should use options" do
+      expect(@session.find_link(href: '#anchor').text).to eq "Normal Anchor"
+    end
+  end
 end