capybara 2.15.0 → 3.0.0

data/lib/capybara/spec/session/attach_file_spec.rb

@@ -1,27 +1,29 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#attach_file" do
   before do
     @test_file_path = File.expand_path('../fixtures/test_file.txt', File.dirname(__FILE__))
     @another_test_file_path = File.expand_path('../fixtures/another_test_file.txt', File.dirname(__FILE__))
     @test_jpg_file_path = File.expand_path('../fixtures/capybara.jpg', File.dirname(__FILE__))
+    @no_extension_file_path = File.expand_path('../fixtures/no_extension', File.dirname(__FILE__))
     @session.visit('/form')
   end
 
   context "with normal form" do
     it "should set a file path by id" do
-      @session.attach_file "form_image", __FILE__
+      @session.attach_file "form_image", with_os_path_separators(__FILE__)
       @session.click_button('awesome')
       expect(extract_results(@session)['image']).to eq(File.basename(__FILE__))
     end
 
     it "should set a file path by label" do
-      @session.attach_file "Image", __FILE__
+      @session.attach_file "Image", with_os_path_separators(__FILE__)
       @session.click_button('awesome')
       expect(extract_results(@session)['image']).to eq(File.basename(__FILE__))
     end
 
     it "casts to string" do
-      @session.attach_file :"form_image", __FILE__
+      @session.attach_file :form_image, with_os_path_separators(__FILE__)
       @session.click_button('awesome')
       expect(extract_results(@session)['image']).to eq(File.basename(__FILE__))
     end
@@ -29,13 +31,13 @@ Capybara::SpecHelper.spec "#attach_file" do
 
   context "with multipart form" do
     it "should set a file path by id" do
-      @session.attach_file "form_document", @test_file_path
+      @session.attach_file "form_document", with_os_path_separators(@test_file_path)
       @session.click_button('Upload Single')
       expect(@session).to have_content(File.read(@test_file_path))
     end
 
     it "should set a file path by label" do
-      @session.attach_file "Single Document", @test_file_path
+      @session.attach_file "Single Document", with_os_path_separators(@test_file_path)
       @session.click_button('Upload Single')
       expect(@session).to have_content(File.read(@test_file_path))
     end
@@ -46,29 +48,35 @@ Capybara::SpecHelper.spec "#attach_file" do
     end
 
     it "should send content type text/plain when uploading a text file" do
-      @session.attach_file "Single Document", @test_file_path
+      @session.attach_file "Single Document", with_os_path_separators(@test_file_path)
       @session.click_button 'Upload Single'
       expect(@session).to have_content('text/plain')
     end
 
     it "should send content type image/jpeg when uploading an image" do
-      @session.attach_file "Single Document", @test_jpg_file_path
+      @session.attach_file "Single Document", with_os_path_separators(@test_jpg_file_path)
       @session.click_button 'Upload Single'
       expect(@session).to have_content('image/jpeg')
     end
 
+    it "should not break when uploading a file without extension" do
+      @session.attach_file "Single Document", with_os_path_separators(@no_extension_file_path)
+      @session.click_button 'Upload Single'
+      expect(@session).to have_content(File.read(@no_extension_file_path))
+    end
+
     it "should not break when using HTML5 multiple file input" do
-      @session.attach_file "Multiple Documents", @test_file_path
+      @session.attach_file "Multiple Documents", with_os_path_separators(@test_file_path)
       @session.click_button('Upload Multiple')
       expect(@session).to have_content(File.read(@test_file_path))
-      expect(@session.body).to include("1 | ")#number of files
+      expect(@session.body).to include("1 | ") # number of files
     end
 
-    it  "should not break when using HTML5 multiple file input uploading multiple files" do
-      pending "Selenium is buggy on this, see http://code.google.com/p/selenium/issues/detail?id=2239" if @session.respond_to?(:mode) && @session.mode.to_s =~ /^selenium_(firefox|marionette)/
-      @session.attach_file "Multiple Documents", [@test_file_path, @another_test_file_path]
+    it "should not break when using HTML5 multiple file input uploading multiple files" do
+      @session.attach_file("Multiple Documents",
+                           [@test_file_path, @another_test_file_path].map { |f| with_os_path_separators(f) })
       @session.click_button('Upload Multiple')
-      expect(@session.body).to include("2 | ")#number of files
+      expect(@session.body).to include("2 | ") # number of files
       expect(@session.body).to include(File.read(@test_file_path))
       expect(@session.body).to include(File.read(@another_test_file_path))
     end
@@ -77,13 +85,23 @@ Capybara::SpecHelper.spec "#attach_file" do
       @session.click_button('Upload Empty Multiple')
       expect(@session).to have_content("Successfully ignored empty file field")
     end
+
+    it "should not append files to already attached" do
+      @session.attach_file "Multiple Documents", with_os_path_separators(@test_file_path)
+      @session.attach_file("Multiple Documents",
+                           [@test_file_path, @another_test_file_path].map { |f| with_os_path_separators(f) })
+      @session.click_button('Upload Multiple')
+      expect(@session.body).to include("2 | ") # number of files
+      expect(@session.body).to include(File.read(@test_file_path))
+      expect(@session.body).to include(File.read(@another_test_file_path))
+    end
   end
 
   context "with a locator that doesn't exist" do
     it "should raise an error" do
       msg = "Unable to find visible file field \"does not exist\" that is not disabled"
       expect do
-        @session.attach_file('does not exist', @test_file_path)
+        @session.attach_file('does not exist', with_os_path_separators(@test_file_path))
       end.to raise_error(Capybara::ElementNotFound, msg)
     end
   end
@@ -96,45 +114,55 @@ Capybara::SpecHelper.spec "#attach_file" do
 
   context "with :exact option" do
     it "should set a file path by partial label when false" do
-      @session.attach_file "Imag", __FILE__, exact:  false
+      @session.attach_file "Imag", with_os_path_separators(__FILE__), exact: false
       @session.click_button('awesome')
       expect(extract_results(@session)['image']).to eq(File.basename(__FILE__))
     end
 
-    it "not allow partial matches when true" do
+    it "should not allow partial matches when true" do
       expect do
-        @session.attach_file "Imag", __FILE__, exact:  true
+        @session.attach_file "Imag", with_os_path_separators(__FILE__), exact: true
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
 
-  context "with :make_visible option", requires: [:js, :es_args] do
+  context "with :make_visible option", requires: %i[js es_args] do
     it "applies a default style change when true" do
       @session.visit('/with_js')
-      expect { @session.attach_file("hidden_file", __FILE__) }.to raise_error Capybara::ElementNotFound
-      expect {
-        @session.attach_file("hidden_file", __FILE__, make_visible: true)
-      }.not_to raise_error
+      expect do
+        @session.attach_file("hidden_file", with_os_path_separators(__FILE__))
+      end.to raise_error Capybara::ElementNotFound
+      expect do
+        @session.attach_file("hidden_file", with_os_path_separators(__FILE__), make_visible: true)
+      end.not_to raise_error
     end
 
     it "accepts a hash of styles to be applied" do
       @session.visit('/with_js')
-      expect {
-        @session.attach_file("hidden_file", __FILE__, make_visible: { opacity: 1, display: 'block' })
-      }.not_to raise_error
+      expect do
+        @session.attach_file("hidden_file",
+                             with_os_path_separators(__FILE__),
+                             make_visible: { opacity: 1, display: 'block' })
+      end.not_to raise_error
     end
 
     it "raises an error when the file input is not made visible" do
       @session.visit('/with_js')
-      expect {
-        @session.attach_file("hidden_file", __FILE__, make_visible: { color: 'red' })
-      }.to raise_error(Capybara::ExpectationNotMet)
+      expect do
+        @session.attach_file("hidden_file", with_os_path_separators(__FILE__), make_visible: { color: 'red' })
+      end.to raise_error(Capybara::ExpectationNotMet)
     end
 
     it "resets the style when done" do
       @session.visit('/with_js')
-      @session.attach_file("hidden_file", __FILE__, make_visible: true)
+      @session.attach_file("hidden_file", with_os_path_separators(__FILE__), make_visible: true)
       expect(@session.evaluate_script("arguments[0].style.display", @session.find(:css, '#hidden_file', visible: :all))).to eq 'none'
     end
   end
+
+  private
+
+  def with_os_path_separators(path)
+    Gem.win_platform? ? path.to_s.tr('/', '\\') : path.to_s
+  end
 end

data/lib/capybara/spec/session/body_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#body' do
   it "should return the unmodified page body" do
     @session.visit('/')

data/lib/capybara/spec/session/check_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#check" do
   before do
     @session.visit('/form')
@@ -18,7 +19,7 @@ Capybara::SpecHelper.spec "#check" do
   it "should trigger associated events", requires: [:js] do
     @session.visit('/with_js')
     @session.check('checkbox_with_event')
-    expect(@session).to have_css('#checkbox_event_triggered');
+    expect(@session).to have_css('#checkbox_event_triggered')
   end
 
   describe "checking" do
@@ -62,7 +63,7 @@ Capybara::SpecHelper.spec "#check" do
   end
 
   it "casts to string" do
-    @session.check(:"form_pets_cat")
+    @session.check(:form_pets_cat)
     @session.click_button('awesome')
     expect(extract_results(@session)['pets']).to include('dog', 'cat', 'hamster')
   end
@@ -86,14 +87,14 @@ Capybara::SpecHelper.spec "#check" do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      @session.check('Ham', exact:  false)
+      @session.check('Ham', exact: false)
       @session.click_button('awesome')
       expect(extract_results(@session)['pets']).to include('hamster')
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.check('Ham', exact:  true)
+        @session.check('Ham', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
@@ -146,7 +147,7 @@ Capybara::SpecHelper.spec "#check" do
       end
 
       it "should raise error if not allowed to click label" do
-        expect{@session.check('form_cars_mclaren', allow_label_click: false)}.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_mclaren" that is not disabled')
+        expect { @session.check('form_cars_mclaren', allow_label_click: false) }.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_mclaren" that is not disabled')
       end
     end
 
@@ -158,7 +159,7 @@ Capybara::SpecHelper.spec "#check" do
       end
 
       it "should raise error if checkbox not visible" do
-        expect{@session.check('form_cars_mclaren')}.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_mclaren" that is not disabled')
+        expect { @session.check('form_cars_mclaren') }.to raise_error(Capybara::ElementNotFound, 'Unable to find visible checkbox "form_cars_mclaren" that is not disabled')
       end
 
       context "with allow_label_click == true" do

data/lib/capybara/spec/session/choose_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#choose" do
   before do
     @session.visit('/form')
@@ -18,7 +19,7 @@ Capybara::SpecHelper.spec "#choose" do
 
   it "casts to string" do
     @session.choose("Both")
-    @session.click_button(:'awesome')
+    @session.click_button(:awesome)
     expect(extract_results(@session)['gender']).to eq('both')
   end
 
@@ -41,14 +42,14 @@ Capybara::SpecHelper.spec "#choose" do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      @session.choose("Mal", exact:  false)
+      @session.choose("Mal", exact: false)
       @session.click_button('awesome')
       expect(extract_results(@session)['gender']).to eq('male')
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.choose("Mal", exact:  true)
+        @session.choose("Mal", exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end
@@ -82,7 +83,7 @@ Capybara::SpecHelper.spec "#choose" do
       end
 
       it "should raise error if not allowed to click label" do
-        expect{@session.choose("party_democrat", allow_label_click: false)}.to raise_error(Capybara::ElementNotFound, 'Unable to find visible radio button "party_democrat" that is not disabled')
+        expect { @session.choose("party_democrat", allow_label_click: false) }.to raise_error(Capybara::ElementNotFound, 'Unable to find visible radio button "party_democrat" that is not disabled')
       end
     end
   end

data/lib/capybara/spec/session/click_button_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#click_button' do
   before do
     @session.visit('/form')
@@ -151,31 +152,24 @@ Capybara::SpecHelper.spec '#click_button' do
     end
   end
 
-  context "with id given on a submit button" do
-    it "should submit the associated form" do
+  context "input type=submit button" do
+    it "should submit by button id" do
       @session.click_button('awe123')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
-      @session.click_button('Go')
-      expect(@session).to have_content('You landed')
-    end
-  end
-
-  context "with title given on a submit button" do
-    it "should submit the associated form" do
+    it "should submit by button title" do
       @session.click_button('What an Awesome Button')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should submit by partial title", :exact_false do
       @session.click_button('What an Awesome')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
   end
 
-  context "with fields associated with the form using the form attribute" do
+  context "with fields associated with the form using the form attribute", requires: [:form_attribute] do
     before do
       @session.click_button('submit_form1')
       @results = extract_results(@session)
@@ -198,8 +192,7 @@ Capybara::SpecHelper.spec '#click_button' do
     end
   end
 
-
-  context "with submit button outside the form defined by <button> tag" do
+  context "with submit button outside the form defined by <button> tag", requires: [:form_attribute] do
     before do
       @session.click_button('outside_button')
       @results = extract_results(@session)
@@ -215,7 +208,7 @@ Capybara::SpecHelper.spec '#click_button' do
     end
   end
 
-  context "with submit button outside the form defined by <input type='submit'> tag" do
+  context "with submit button outside the form defined by <input type='submit'> tag", requires: [:form_attribute] do
     before do
       @session.click_button('outside_submit')
       @results = extract_results(@session)
@@ -231,7 +224,7 @@ Capybara::SpecHelper.spec '#click_button' do
     end
   end
 
-  context "with submit button for form1 located within form2" do
+  context "with submit button for form1 located within form2", requires: [:form_attribute] do
     it "should submit the form associated with the button" do
       @session.click_button('other_form_button')
       expect(extract_results(@session)['which_form']).to eq("form1")
@@ -250,20 +243,19 @@ Capybara::SpecHelper.spec '#click_button' do
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('hai')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
   end
 
-
   context "with value given on an image button" do
     it "should submit the associated form" do
       @session.click_button('okay')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('kay')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
@@ -282,7 +274,7 @@ Capybara::SpecHelper.spec '#click_button' do
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('Okay 556')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
@@ -290,17 +282,17 @@ Capybara::SpecHelper.spec '#click_button' do
 
   context "with text given on a button defined by <button> tag" do
     it "should submit the associated form" do
-      @session.click_button('Click me')
+      @session.click_button('Click me!')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('Click')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
   end
 
- context "with id given on a button defined by <button> tag" do
+  context "with id given on a button defined by <button> tag" do
     it "should submit the associated form" do
       @session.click_button('click_me_123')
       expect(extract_results(@session)['first_name']).to eq('John')
@@ -315,13 +307,13 @@ Capybara::SpecHelper.spec '#click_button' do
     end
   end
 
- context "with value given on a button defined by <button> tag" do
+  context "with value given on a button defined by <button> tag" do
     it "should submit the associated form" do
       @session.click_button('click_me')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('ck_me')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
@@ -333,7 +325,7 @@ Capybara::SpecHelper.spec '#click_button' do
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('Click Title')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
@@ -345,7 +337,7 @@ Capybara::SpecHelper.spec '#click_button' do
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
-    it "should work with partial matches" do
+    it "should work with partial matches", :exact_false do
       @session.click_button('se eating h')
       expect(extract_results(@session)['first_name']).to eq('John')
     end
@@ -424,15 +416,15 @@ Capybara::SpecHelper.spec '#click_button' do
 
   it "should encode complex field names, like array[][value]" do
     @session.visit('/form')
-    @session.fill_in('address1_city', :with =>'Paris')
-    @session.fill_in('address1_street', :with =>'CDG')
+    @session.fill_in('address1_city', with: 'Paris')
+    @session.fill_in('address1_street', with: 'CDG')
 
     @session.fill_in('address2_city', with: 'Mikolaiv')
     @session.fill_in('address2_street', with: 'PGS')
 
     @session.click_button "awesome"
 
-    addresses=extract_results(@session)["addresses"]
+    addresses = extract_results(@session)["addresses"]
     expect(addresses.size).to eq(2)
 
     expect(addresses[0]["street"]).to eq('CDG')
@@ -446,13 +438,13 @@ Capybara::SpecHelper.spec '#click_button' do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      @session.click_button('What an Awesome', exact:  false)
+      @session.click_button('What an Awesome', exact: false)
       expect(extract_results(@session)['first_name']).to eq('John')
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.click_button('What an Awesome', exact:  true)
+        @session.click_button('What an Awesome', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end

data/lib/capybara/spec/session/click_link_or_button_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#click_link_or_button' do
   it "should click on a link" do
     @session.visit('/with_html')
@@ -32,31 +33,31 @@ Capybara::SpecHelper.spec '#click_link_or_button' do
 
   it "casts to string" do
     @session.visit('/form')
-    @session.click_link_or_button(:'awe123')
+    @session.click_link_or_button(:awe123)
     expect(extract_results(@session)['first_name']).to eq('John')
   end
 
   context "with :exact option" do
-    context "when `true`" do
+    context "when `false`" do
       it "clicks on approximately matching link" do
         @session.visit('/with_html')
-        @session.click_link_or_button('abore', exact:  false)
+        @session.click_link_or_button('abore', exact: false)
         expect(@session).to have_content('Bar')
       end
 
       it "clicks on approximately matching button" do
         @session.visit('/form')
-        @session.click_link_or_button('awe')
+        @session.click_link_or_button('awe', exact: false)
         expect(extract_results(@session)['first_name']).to eq('John')
       end
     end
 
-    context "when `false`" do
+    context "when `true`" do
       it "does not click on link which matches approximately" do
         @session.visit('/with_html')
         msg = "Unable to find visible link or button \"abore\""
         expect do
-          @session.click_link_or_button('abore', exact:  true)
+          @session.click_link_or_button('abore', exact: true)
         end.to raise_error(Capybara::ElementNotFound, msg)
       end
 
@@ -65,7 +66,7 @@ Capybara::SpecHelper.spec '#click_link_or_button' do
         msg = "Unable to find visible link or button \"awe\""
 
         expect do
-          @session.click_link_or_button('awe', exact:  true)
+          @session.click_link_or_button('awe', exact: true)
         end.to raise_error(Capybara::ElementNotFound, msg)
       end
     end

data/lib/capybara/spec/session/click_link_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#click_link' do
   before do
     @session.visit('/with_html')
@@ -11,7 +12,7 @@ Capybara::SpecHelper.spec '#click_link' do
   end
 
   it "casts to string" do
-    @session.click_link(:'foo')
+    @session.click_link(:foo)
     expect(@session).to have_content('Another World')
   end
 
@@ -35,7 +36,7 @@ Capybara::SpecHelper.spec '#click_link' do
       expect(@session).to have_content('Bar')
     end
 
-    it "should accept partial matches" do
+    it "should accept partial matches", :exact_false do
       @session.click_link('abo')
       expect(@session).to have_content('Bar')
     end
@@ -47,7 +48,7 @@ Capybara::SpecHelper.spec '#click_link' do
       expect(@session).to have_content('Bar')
     end
 
-    it "should accept partial matches" do
+    it "should accept partial matches", :exact_false do
       @session.click_link('some titl')
       expect(@session).to have_content('Bar')
     end
@@ -59,7 +60,7 @@ Capybara::SpecHelper.spec '#click_link' do
       expect(@session).to have_content('Bar')
     end
 
-    it "should accept partial matches" do
+    it "should accept partial matches", :exact_false do
       @session.click_link('some imag')
       expect(@session).to have_content('Bar')
     end
@@ -85,7 +86,7 @@ Capybara::SpecHelper.spec '#click_link' do
     end
   end
 
-  context "with a regex :href option given"  do
+  context "with a regex :href option given" do
     it "should find a link matching an all-matching regex pattern" do
       @session.click_link('labore', href: /.+/)
       expect(@session).to have_content('Bar')
@@ -180,13 +181,13 @@ Capybara::SpecHelper.spec '#click_link' do
 
   context "with :exact option" do
     it "should accept partial matches when false" do
-      @session.click_link('abo', exact:  false)
+      @session.click_link('abo', exact: false)
       expect(@session).to have_content('Bar')
     end
 
     it "should not accept partial matches when true" do
       expect do
-        @session.click_link('abo', exact:  true)
+        @session.click_link('abo', exact: true)
       end.to raise_error(Capybara::ElementNotFound)
     end
   end

data/lib/capybara/spec/session/current_scope_spec.rb

@@ -1,15 +1,16 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#current_scope' do
   before do
     @session.visit('/with_scope')
   end
-  
+
   context "when not in a #within block" do
     it "should return the document" do
       expect(@session.current_scope).to be_kind_of Capybara::Node::Document
     end
   end
-  
+
   context "when in a #within block" do
     it "should return the element in scope" do
       @session.within(:css, "#simple_first_name") do
@@ -17,7 +18,7 @@ Capybara::SpecHelper.spec '#current_scope' do
       end
     end
   end
-  
+
   context "when in a nested #within block" do
     it "should return the element in scope" do
       @session.within("//div[@id='for_bar']") do