capybara 2.15.0 → 3.0.0

data/lib/capybara/spec/fixtures/no_extension

@@ -0,0 +1 @@
+ThisFileHAsNoExtension

data/lib/capybara/spec/public/test.js

@@ -1,14 +1,14 @@
 var activeRequests = 0;
 $(function() {
   $('#change').text('I changed it');
-  $('#drag').draggable();
-  $('#drop').droppable({
+  $('#drag, #drag_scroll').draggable();
+  $('#drop, #drop_scroll').droppable({
     drop: function(event, ui) {
       ui.draggable.remove();
       $(this).html('Dropped!');
     }
   });
-  $('#clickable').click(function() {
+  $('#clickable').click(function(e) {
     var link = $(this);
     setTimeout(function() {
       $(link).after('<a id="has-been-clicked" href="#">Has been clicked</a>');
@@ -37,6 +37,9 @@ $(function() {
   $('#with_change_event').change(function() {
     $('body').append($('<p class="change_event_triggered"></p>').text(this.value));
   });
+  $('#with_change_event').on('input', function() {
+    $('body').append($('<p class="input_event_triggered"></p>').text(this.value));
+  });
   $('#checkbox_with_event').click(function() {
     $('body').append('<p id="checkbox_event_triggered">Checkbox event triggered</p>');
   });
@@ -61,12 +64,33 @@ $(function() {
     }, 400)
   });
   $('#click-test').on({
-    dblclick: function() {
-      $(this).after('<a id="has-been-double-clicked" href="#">Has been double clicked</a>');
+    click: function(e) {
+      var desc = "";
+      if (e.altKey) desc += 'alt ';
+      if (e.ctrlKey) desc += 'control ';
+      if (e.metaKey) desc += 'meta ';
+      if (e.shiftKey) desc += 'shift ';
+      var pos = this.getBoundingClientRect();
+      $(this).after('<a id="has-been-clicked" href="#">Has been ' + desc + 'clicked at ' + (e.clientX - pos.left) + ',' + (e.clientY - pos.top) + '</a>');
+    },
+    dblclick: function(e) {
+      var desc = "";
+      if (e.altKey) desc += 'alt ';
+      if (e.ctrlKey) desc += 'control ';
+      if (e.metaKey) desc += 'meta ';
+      if (e.shiftKey) desc += 'shift ';
+      var pos = this.getBoundingClientRect();
+      $(this).after('<a id="has-been-double-clicked" href="#">Has been ' + desc + 'double clicked at ' + (e.clientX - pos.left) + ',' + (e.clientY - pos.top) + '</a>');
     },
     contextmenu: function(e) {
       e.preventDefault();
-      $(this).after('<a id="has-been-right-clicked" href="#">Has been right clicked</a>');
+      var desc = "";
+      if (e.altKey) desc += 'alt ';
+      if (e.ctrlKey) desc += 'control ';
+      if (e.metaKey) desc += 'meta ';
+      if (e.shiftKey) desc += 'shift ';
+      var pos = this.getBoundingClientRect();
+      $(this).after('<a id="has-been-right-clicked" href="#">Has been ' + desc + 'right clicked at ' + (e.clientX - pos.left) + ',' + (e.clientY - pos.top) + '</a>');
     }
   });
   $('#open-alert').click(function() {
@@ -106,6 +130,14 @@ $(function() {
       $(this).attr('response', response);
     }
   });
+  $('#open-prompt-with-default').click(function() {
+    var response = prompt('Prompt opened', 'Default value!');
+    if(response === null) {
+      $(this).attr('response', 'dismissed');
+    } else {
+      $(this).attr('response', response);
+    }
+  });
   $('#open-twice').click(function() {
     if (confirm('Are you sure?')) {
       if (!confirm('Are you really sure?')) {

data/lib/capybara/spec/session/accept_alert_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#accept_alert', requires: [:modals] do
   before do
     @session.visit('/with_js')

data/lib/capybara/spec/session/accept_confirm_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#accept_confirm', requires: [:modals] do
   before do
     @session.visit('/with_js')
@@ -19,13 +20,13 @@ Capybara::SpecHelper.spec '#accept_confirm', requires: [:modals] do
   end
 
   it "should work with nested modals" do
-    expect {
+    expect do
       @session.dismiss_confirm 'Are you really sure?' do
         @session.accept_confirm 'Are you sure?' do
           @session.click_link('Open check twice')
         end
       end
-    }.not_to raise_error
+    end.not_to raise_error
     expect(@session).to have_xpath("//a[@id='open-twice' and @confirmed='false']")
   end
 end

data/lib/capybara/spec/session/accept_prompt_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#accept_prompt', requires: [:modals] do
   before do
     @session.visit('/with_js')
@@ -11,6 +12,13 @@ Capybara::SpecHelper.spec '#accept_prompt', requires: [:modals] do
     expect(@session).to have_xpath("//a[@id='open-prompt' and @response='']")
   end
 
+  it "should accept the prompt with no message when there is a default" do
+    @session.accept_prompt do
+      @session.click_link('Open defaulted prompt')
+    end
+    expect(@session).to have_xpath("//a[@id='open-prompt-with-default' and @response='Default value!']")
+  end
+
   it "should return the message presented" do
     message = @session.accept_prompt do
       @session.click_link('Open prompt')
@@ -25,6 +33,28 @@ Capybara::SpecHelper.spec '#accept_prompt', requires: [:modals] do
     expect(@session).to have_xpath("//a[@id='open-prompt' and @response='the response']")
   end
 
+  it "should accept the prompt with a response when there is a default" do
+    @session.accept_prompt with: 'the response' do
+      @session.click_link('Open defaulted prompt')
+    end
+    expect(@session).to have_xpath("//a[@id='open-prompt-with-default' and @response='the response']")
+  end
+
+  it "should accept the prompt with a blank response when there is a default" do
+    pending "Geckodriver doesn't set a blank response currently" if marionette?(@session)
+    @session.accept_prompt with: '' do
+      @session.click_link('Open defaulted prompt')
+    end
+    expect(@session).to have_xpath("//a[@id='open-prompt-with-default' and @response='']")
+  end
+
+  it "should allow special characters in the reponse" do
+    @session.accept_prompt with: '\'the\' \b "response"' do
+      @session.click_link('Open prompt')
+    end
+    expect(@session).to have_xpath(%{//a[@id='open-prompt' and @response=concat("'the' ", '\\b "response"')]})
+  end
+
   it "should accept the prompt if the message matches" do
     @session.accept_prompt 'Prompt opened', with: 'matched' do
       @session.click_link('Open prompt')
@@ -40,7 +70,6 @@ Capybara::SpecHelper.spec '#accept_prompt', requires: [:modals] do
     end.to raise_error(Capybara::ModalNotFound)
   end
 
-
   it "should return the message presented" do
     message = @session.accept_prompt with: 'the response' do
       @session.click_link('Open prompt')

data/lib/capybara/spec/session/all_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec "#all" do
   before do
     @session.visit('/with_html')
@@ -14,11 +15,23 @@ Capybara::SpecHelper.spec "#all" do
     expect(@session.all('//div[@id="nosuchthing"]')).to be_empty
   end
 
-  it "should accept an XPath instance" do
+  it "should wait for matching elements to appear", requires: [:js] do
+    @session.visit('/with_js')
+    @session.click_link('Click me')
+    expect(@session.all(:css, "a#has-been-clicked")).not_to be_empty
+  end
+
+  it "should not wait if `minimum: 0` option is specified", requires: [:js] do
+    @session.visit('/with_js')
+    @session.click_link('Click me')
+    expect(@session.all(:css, "a#has-been-clicked", minimum: 0)).to be_empty
+  end
+
+  it "should accept an XPath instance", :exact_false do
     @session.visit('/form')
     @xpath = Capybara::Selector.all[:fillable_field].call('Name')
     expect(@xpath).to be_a(::XPath::Union)
-    @result = @session.all(@xpath).map { |r| r.value }
+    @result = @session.all(@xpath).map(&:value)
     expect(@result).to include('Smith', 'John', 'John Smith')
   end
 
@@ -116,35 +129,35 @@ Capybara::SpecHelper.spec "#all" do
 
     context 'with multiple count filters' do
       it 'ignores other filters when :count is specified' do
-        o = {count: 4,
-             minimum: 5,
-             maximum: 0,
-             between: 0..3}
+        o = { count: 4,
+              minimum: 5,
+              maximum: 0,
+              between: 0..3 }
         expect { @session.all(:css, 'h1, p', o) }.to_not raise_error
       end
       context 'with no :count expectation' do
         it 'fails if :minimum is not met' do
-          o = {minimum: 5,
-               maximum: 4,
-               between: 2..7}
+          o = { minimum: 5,
+                maximum: 4,
+                between: 2..7 }
           expect { @session.all(:css, 'h1, p', o) }.to raise_error(Capybara::ExpectationNotMet)
         end
         it 'fails if :maximum is not met' do
-          o = {minimum: 0,
-               maximum: 0,
-               between: 2..7}
+          o = { minimum: 0,
+                maximum: 0,
+                between: 2..7 }
           expect { @session.all(:css, 'h1, p', o) }.to raise_error(Capybara::ExpectationNotMet)
         end
         it 'fails if :between is not met' do
-          o = {minimum: 0,
-               maximum: 4,
-               between: 0..3}
+          o = { minimum: 0,
+                maximum: 4,
+                between: 0..3 }
           expect { @session.all(:css, 'h1, p', o) }.to raise_error(Capybara::ExpectationNotMet)
         end
         it 'succeeds if all combineable expectations are met' do
-          o = {minimum: 0,
-               maximum: 4,
-               between: 2..7}
+          o = { minimum: 0,
+                maximum: 4,
+                between: 2..7 }
           expect { @session.all(:css, 'h1, p', o) }.to_not raise_error
         end
       end

data/lib/capybara/spec/session/ancestor_spec.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#ancestor' do
   before do
     @session.visit('/with_html')
@@ -16,7 +17,7 @@ Capybara::SpecHelper.spec '#ancestor' do
 
   it "should find the ancestor element using the given locator and options" do
     el = @session.find(:css, '#child')
-    expect(el.ancestor('//div', text: 'Ancestor Ancestor Ancestor')[:id]).to eq('ancestor3')
+    expect(el.ancestor('//div', text: "Ancestor\nAncestor\nAncestor")[:id]).to eq('ancestor3')
   end
 
   it "should raise an error if there are multiple matches" do
@@ -52,26 +53,23 @@ Capybara::SpecHelper.spec '#ancestor' do
         xpath { |num| ".//*[@id='ancestor#{num}']" }
       end
       el = @session.find(:css, '#child')
-      expect(el.ancestor(:level, 1).text).to eq('Ancestor Child')
-      expect(el.ancestor(:level, 3).text).to eq('Ancestor Ancestor Ancestor Child')
+      expect(el.ancestor(:level, 1)[:id]).to eq "ancestor1"
+      expect(el.ancestor(:level, 3)[:id]).to eq "ancestor3"
     end
   end
 
-
   it "should raise ElementNotFound with a useful default message if nothing was found" do
     el = @session.find(:css, '#child')
     expect do
       el.ancestor(:xpath, '//div[@id="nosuchthing"]')
-    end.to raise_error(Capybara::ElementNotFound, "Unable to find xpath \"//div[@id=\\\"nosuchthing\\\"]\" that is an ancestor of visible css \"#child\"")
+    end.to raise_error(Capybara::ElementNotFound, "Unable to find visible xpath \"//div[@id=\\\"nosuchthing\\\"]\" that is an ancestor of visible css \"#child\"")
   end
 
-
-
   context "within a scope" do
     it "should limit the ancestors to inside the scope" do
       @session.within(:css, '#ancestor2') do
         el = @session.find(:css, '#child')
-        expect(el.ancestor(:css,'div', text: 'Ancestor')[:id]).to eq('ancestor1')
+        expect(el.ancestor(:css, 'div', text: 'Ancestor')[:id]).to eq('ancestor1')
       end
     end
   end

data/lib/capybara/spec/session/assert_all_of_selectors_spec.rb

@@ -1,21 +1,22 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_all_of_selectors' do
   before do
     @session.visit('/with_html')
   end
 
   it "should be true if the given selectors are on the page" do
-    @session.assert_all_of_selectors(:css, "p a#foo", "h2#h2one", "h2#h2two" )
+    @session.assert_all_of_selectors(:css, "p a#foo", "h2#h2one", "h2#h2two")
   end
 
   it "should be false if any of the given selectors are not on the page" do
-    expect { @session.assert_all_of_selectors(:css, "p a#foo", "h2#h2three", "h2#h2one")}.to raise_error(Capybara::ElementNotFound)
+    expect { @session.assert_all_of_selectors(:css, "p a#foo", "h2#h2three", "h2#h2one") }.to raise_error(Capybara::ElementNotFound)
   end
 
   it "should use default selector" do
     Capybara.default_selector = :css
-    expect { @session.assert_all_of_selectors("p a#foo", "h2#h2three", "h2#h2one")}.to raise_error(Capybara::ElementNotFound)
-    @session.assert_all_of_selectors("p a#foo", "h2#h2two", "h2#h2one" )
+    expect { @session.assert_all_of_selectors("p a#foo", "h2#h2three", "h2#h2one") }.to raise_error(Capybara::ElementNotFound)
+    @session.assert_all_of_selectors("p a#foo", "h2#h2two", "h2#h2one")
   end
 
   context "should respect scopes" do
@@ -63,7 +64,7 @@ Capybara::SpecHelper.spec '#assert_none_of_selectors' do
   end
 
   it "should be true if none of the given locators are on the page" do
-    @session.assert_none_of_selectors(:xpath, "//abbr", "//td" )
+    @session.assert_none_of_selectors(:xpath, "//abbr", "//td")
     @session.assert_none_of_selectors(:css, "p a#doesnotexist", "abbr")
   end
 

data/lib/capybara/spec/session/assert_current_path.rb

@@ -1,11 +1,12 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_current_path' do
   before do
     @session.visit('/with_js')
   end
 
   it "should not raise if the page has the given current path" do
-    expect {@session.assert_current_path('/with_js')}.not_to raise_error
+    expect { @session.assert_current_path('/with_js') }.not_to raise_error
   end
 
   it "should allow regexp matches" do
@@ -18,27 +19,27 @@ Capybara::SpecHelper.spec '#assert_current_path' do
   end
 
   it "should raise if the page has not the given current_path" do
-    expect{@session.assert_current_path('/with_html')}.to raise_error(Capybara::ExpectationNotMet, 'expected "/with_js" to equal "/with_html"')
+    expect { @session.assert_current_path('/with_html') }.to raise_error(Capybara::ExpectationNotMet, 'expected "/with_js" to equal "/with_html"')
   end
 
   it "should check query options" do
     @session.visit('/with_js?test=test')
-    expect{@session.assert_current_path('/with_js?test=test')}.not_to raise_error
+    expect { @session.assert_current_path('/with_js?test=test') }.not_to raise_error
   end
 
   it "should compare the full url" do
-    expect{@session.assert_current_path(%r{\Ahttp://[^/]*/with_js\Z}, url: true)}.not_to raise_error
+    expect { @session.assert_current_path(%r{\Ahttp://[^/]*/with_js\Z}, url: true) }.not_to raise_error
   end
 
   it "should ignore the query" do
     @session.visit('/with_js?test=test')
-    expect{@session.assert_current_path('/with_js', only_path: true)}.not_to raise_error
+    expect { @session.assert_current_path('/with_js', ignore_query: true) }.not_to raise_error
   end
 
   it "should not cause an exception when current_url is nil" do
     allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
 
-    expect{@session.assert_current_path(nil)}.not_to raise_error
+    expect { @session.assert_current_path(nil) }.not_to raise_error
   end
 end
 
@@ -48,25 +49,25 @@ Capybara::SpecHelper.spec '#assert_no_current_path?' do
   end
 
   it "should raise if the page has the given current_path" do
-    expect{@session.assert_no_current_path('/with_js')}.to raise_error(Capybara::ExpectationNotMet)
+    expect { @session.assert_no_current_path('/with_js') }.to raise_error(Capybara::ExpectationNotMet)
   end
 
   it "should allow regexp matches" do
-    expect{@session.assert_no_current_path(/monkey/)}.not_to raise_error
+    expect { @session.assert_no_current_path(/monkey/) }.not_to raise_error
   end
 
   it "should wait for current_path to disappear", requires: [:js] do
     @session.click_link("Change page")
-    expect{@session.assert_no_current_path('/with_js')}.not_to raise_error
+    expect { @session.assert_no_current_path('/with_js') }.not_to raise_error
   end
 
   it "should not raise if the page has not the given current_path" do
-    expect{@session.assert_no_current_path('/with_html')}.not_to raise_error
+    expect { @session.assert_no_current_path('/with_html') }.not_to raise_error
   end
 
   it "should not cause an exception when current_url is nil" do
     allow_any_instance_of(Capybara::Session).to receive(:current_url) { nil }
 
-    expect{@session.assert_no_current_path('/with_html')}.not_to raise_error
+    expect { @session.assert_no_current_path('/with_html') }.not_to raise_error
   end
 end

data/lib/capybara/spec/session/assert_selector.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_selector' do
   before do
     @session.visit('/with_html')

data/lib/capybara/spec/session/assert_text.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_text' do
   it "should be true if the given text is on the page" do
     @session.visit('/with_html')
     expect(@session.assert_text('est')).to eq(true)
     expect(@session.assert_text('Lorem')).to eq(true)
     expect(@session.assert_text('Redirect')).to eq(true)
-    expect(@session.assert_text(:'Redirect')).to eq(true)
-    expect(@session.assert_text('text with whitespace')).to eq(true)
-    expect(@session.assert_text("text     with \n\n whitespace")).to eq(true)
+    expect(@session.assert_text(:Redirect)).to eq(true)
+    expect(@session.assert_text('text with   whitespace')).to eq(true)
   end
 
   it "should take scopes into account" do
@@ -48,10 +48,18 @@ Capybara::SpecHelper.spec '#assert_text' do
   it "should raise error with a helpful message if the requested text is present but with incorrect case" do
     @session.visit('/with_html')
     expect do
-      @session.assert_text('Text With Whitespace')
+      @session.assert_text('Text With   Whitespace')
     end.to raise_error(Capybara::ExpectationNotMet, /it was found 1 time using a case insensitive search/)
   end
 
+  it "should raise error with helpful message if requested text is present but invisible and with incorrect case", requires: [:js] do
+    @session.visit('/with_html')
+    el = @session.find(:css, '#uppercase')
+    expect do
+      el.assert_text('text here')
+    end.to raise_error(Capybara::ExpectationNotMet, /it was found 1 time using a case insensitive search and it was found 1 time including non-visible text/)
+  end
+
   it "should raise the correct error if requested text is missing but contains regex special characters" do
     @session.visit('/with_html')
     expect do
@@ -68,7 +76,7 @@ Capybara::SpecHelper.spec '#assert_text' do
     @session.visit('/with_html')
     expect do
       @session.assert_text(/xxxxyzzz/)
-    end.to raise_error(Capybara::ExpectationNotMet, /\Aexpected to find text matching \/xxxxyzzz\/ in "This is a test Header Class(.+)"\Z/)
+    end.to raise_error(Capybara::ExpectationNotMet, /\Aexpected to find text matching \/xxxxyzzz\/ in "This is a test\\nHeader Class(.+)"\Z/)
   end
 
   it "should escape any characters that would have special meaning in a regexp" do
@@ -103,7 +111,7 @@ Capybara::SpecHelper.spec '#assert_text' do
       Capybara.using_wait_time(0) do
         @session.visit('/with_js')
         @session.find(:css, '#reload-list').click
-        @session.find(:css, '#the-list').assert_text('Foo Bar', wait: 0.9)
+        @session.find(:css, '#the-list').assert_text("Foo\nBar", wait: 0.9)
       end
     end
 
@@ -125,35 +133,35 @@ Capybara::SpecHelper.spec '#assert_text' do
     end
 
     it 'ignores other filters when :count is specified' do
-      o = {count: 5,
-           minimum: 6,
-           maximum: 0,
-           between: 0..4}
+      o = { count: 5,
+            minimum: 6,
+            maximum: 0,
+            between: 0..4 }
       expect { @session.assert_text('Header', o) }.not_to raise_error
     end
     context 'with no :count expectation' do
       it 'fails if :minimum is not met' do
-        o = {minimum: 6,
-             maximum: 5,
-             between: 2..7}
+        o = { minimum: 6,
+              maximum: 5,
+              between: 2..7 }
         expect { @session.assert_text('Header', o) }.to raise_error(Capybara::ExpectationNotMet)
       end
       it 'fails if :maximum is not met' do
-        o = {minimum: 0,
-             maximum: 0,
-             between: 2..7}
+        o = { minimum: 0,
+              maximum: 0,
+              between: 2..7 }
         expect { @session.assert_text('Header', o) }.to raise_error(Capybara::ExpectationNotMet)
       end
       it 'fails if :between is not met' do
-        o = {minimum: 0,
-             maximum: 5,
-             between: 0..4}
+        o = { minimum: 0,
+              maximum: 5,
+              between: 0..4 }
         expect { @session.assert_text('Header', o) }.to raise_error(Capybara::ExpectationNotMet)
       end
       it 'succeeds if all combineable expectations are met' do
-        o = {minimum: 0,
-             maximum: 5,
-             between: 2..7}
+        o = { minimum: 0,
+              maximum: 5,
+              between: 2..7 }
         expect { @session.assert_text('Header', o) }.not_to raise_error
       end
     end
@@ -165,7 +173,7 @@ Capybara::SpecHelper.spec '#assert_no_text' do
     @session.visit('/with_html')
     expect do
       @session.assert_no_text('Lorem')
-    end.to raise_error(Capybara::ExpectationNotMet, /\Aexpected not to find text "Lorem" in "This is a test Header Class.+"\Z/)
+    end.to raise_error(Capybara::ExpectationNotMet, /\Aexpected not to find text "Lorem" in "This is a test.*"\z/)
   end
 
   it "should be true if scoped to an element which does not have the text" do

data/lib/capybara/spec/session/assert_title.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 Capybara::SpecHelper.spec '#assert_title' do
   before do
     @session.visit('/with_js')
@@ -39,11 +40,20 @@ Capybara::SpecHelper.spec '#assert_title' do
     end.to raise_error(Capybara::ExpectationNotMet, 'expected "with_js" to include "monkey"')
   end
 
-  it "should normalize given title" do
-    @session.assert_title('  with_js  ')
+  it "should not normalize given title" do
+    @session.visit('/with_js')
+    expect { @session.assert_title('  with_js  ') }.to raise_error(Capybara::ExpectationNotMet)
+  end
+
+  it "should match correctly normalized title" do
+    uri = Addressable::URI.parse('/with_title')
+    uri.query_values = { title: '   with space  title   ' }
+    @session.visit(uri.to_s)
+    @session.assert_title('  with space  title')
+    expect { @session.assert_title('with space title') }.to raise_error(Capybara::ExpectationNotMet)
   end
 
-  it "should normalize given title in error message" do
+  it "should not normalize given title in error message" do
     expect do
       @session.assert_title(2)
     end.to raise_error(Capybara::ExpectationNotMet, 'expected "with_js" to include "2"')