candy_check 0.4.0 → 0.6.0

data/spec/fixtures/vcr_cassettes/play_store/product_purchases/permission_denied.yml

@@ -55,7 +55,7 @@ http_interactions:
   recorded_at: Fri, 04 Oct 2019 13:11:23 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''
@@ -125,7 +125,7 @@ http_interactions:
   recorded_at: Fri, 04 Oct 2019 13:11:24 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''

data/spec/fixtures/vcr_cassettes/play_store/product_purchases/response_with_empty_body.yml

@@ -55,7 +55,7 @@ http_interactions:
   recorded_at: Fri, 04 Oct 2019 13:11:23 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''
@@ -125,7 +125,7 @@ http_interactions:
   recorded_at: Fri, 04 Oct 2019 13:11:24 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''

data/spec/fixtures/vcr_cassettes/play_store/product_purchases/valid_but_not_consumed.yml

@@ -55,7 +55,7 @@ http_interactions:
   recorded_at: Fri, 04 Oct 2019 09:25:53 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/products/my_product_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''

data/spec/fixtures/vcr_cassettes/play_store/subscription_purchases/permission_denied.yml

@@ -55,7 +55,7 @@ http_interactions:
   recorded_at: Thu, 10 Oct 2019 14:07:52 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/subscriptions/my_subscription_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/subscriptions/my_subscription_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''
@@ -125,7 +125,7 @@ http_interactions:
   recorded_at: Thu, 10 Oct 2019 14:07:52 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/subscriptions/my_subscription_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/subscriptions/my_subscription_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''

data/spec/fixtures/vcr_cassettes/play_store/subscription_purchases/valid_but_expired.yml

@@ -55,7 +55,7 @@ http_interactions:
   recorded_at: Thu, 24 Oct 2019 10:43:13 GMT
 - request:
     method: get
-    uri: https://www.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/subscriptions/my_subscription_id/tokens/my_token
+    uri: https://androidpublisher.googleapis.com/androidpublisher/v3/applications/my_package_name/purchases/subscriptions/my_subscription_id/tokens/my_token
     body:
       encoding: UTF-8
       string: ''

data/spec/play_store/acknowledger_spec.rb

@@ -21,7 +21,9 @@ describe CandyCheck::PlayStore::Acknowledger do
       end
     end
     it "when already acknowledged" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n    \"errors\": [\n      {\n        \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"invalidPurchaseState\",\n        \"location\": \"token\",\n        \"locationType\": \"parameter\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/already_acknowledged") do
         result = subject.acknowledge_product_purchase(package_name: package_name, product_id: product_id, token: token)
@@ -33,7 +35,9 @@ describe CandyCheck::PlayStore::Acknowledger do
       end
     end
     it "when it has been refunded" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The product purchase is not owned by the user.\",\n    \"errors\": [\n      {\n        \"message\": \"The product purchase is not owned by the user.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"productNotOwnedByUser\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/refunded") do
         result = subject.acknowledge_product_purchase(package_name: package_name, product_id: product_id, token: token)

data/spec/play_store/product_acknowledgements/acknowledgement_spec.rb

@@ -27,7 +27,9 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Acknowledgement do
       end
     end
     it "when already acknowledged" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n    \"errors\": [\n      {\n        \"message\": \"The purchase is not in a valid state to perform the desired operation.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"invalidPurchaseState\",\n        \"location\": \"token\",\n        \"locationType\": \"parameter\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/already_acknowledged") do
         result = subject.call!
@@ -39,7 +41,9 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Acknowledgement do
       end
     end
     it "when it has been refunded" do
+      # rubocop:disable Layout/LineLength
       error_body = "{\n  \"error\": {\n    \"code\": 400,\n    \"message\": \"The product purchase is not owned by the user.\",\n    \"errors\": [\n      {\n        \"message\": \"The product purchase is not owned by the user.\",\n        \"domain\": \"androidpublisher\",\n        \"reason\": \"productNotOwnedByUser\"\n      }\n    ]\n  }\n}\n"
+      # rubocop:enable Layout/LineLength
 
       VCR.use_cassette("play_store/product_acknowledgements/refunded") do
         result = subject.call!

data/spec/play_store/product_acknowledgements/response_spec.rb

@@ -5,23 +5,23 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Response do
     CandyCheck::PlayStore::ProductAcknowledgements::Response.new(result: result, error_data: error_data)
   end
 
-  describe '#acknowledged?' do
-    context 'when result present' do
-      let(:result) { '' }
+  describe "#acknowledged?" do
+    context "when result present" do
+      let(:result) { "" }
       let(:error_data)  { nil }
 
-      it 'returns true' do
+      it "returns true" do
         result = subject.acknowledged?
 
         _(result).must_be_true
       end
     end
 
-    context 'when result is not present' do
+    context "when result is not present" do
       let(:result) { nil }
-      let(:error_data)  { nil }
+      let(:error_data) { nil }
 
-      it 'returns false' do
+      it "returns false" do
         result = subject.acknowledged?
 
         _(result).must_be_false
@@ -29,34 +29,35 @@ describe CandyCheck::PlayStore::ProductAcknowledgements::Response do
     end
   end
 
-  describe '#error' do
-    context 'when error present' do
+  describe "#error" do
+    context "when error present" do
       let(:result) { nil }
       let(:error_data) do
         Module.new do
           def status_code
             400
           end
+
           def body
-            'A String describing the issue'
+            "A String describing the issue"
           end
           module_function :status_code, :body
         end
       end
 
-      it 'returns the expected data' do
+      it "returns the expected data" do
         result = subject.error
 
         _(result[:status_code]).must_equal(400)
-        _(result[:body]).must_equal('A String describing the issue')
+        _(result[:body]).must_equal("A String describing the issue")
       end
     end
 
-    context 'when error is not present' do
-      let(:result) { '' }
+    context "when error is not present" do
+      let(:result) { "" }
       let(:error_data)  { nil }
 
-      it 'returns false' do
+      it "returns false" do
         result = subject.error
 
         _(result).must_be_nil

data/spec/play_store/product_purchases/product_purchase_spec.rb

@@ -5,13 +5,13 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
 
   describe "valid and non-consumed product" do
     let(:fake_product_purchase) do
-      FakeProductPurchase.new(
+      OpenStruct.new(
         consumption_state: 0,
         developer_payload: "payload that gets stored and returned",
         kind: "androidpublisher#productPurchase",
         order_id: "ABC123",
         purchase_state: 0,
-        purchase_time_millis: 1421676237413,
+        purchase_time_millis: 1_421_676_237_413,
       )
     end
 
@@ -51,13 +51,13 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
 
   describe "valid and consumed product" do
     let(:fake_product_purchase) do
-      FakeProductPurchase.new(
+      OpenStruct.new(
         consumption_state: 1,
         developer_payload: "payload that gets stored and returned",
         kind: "androidpublisher#productPurchase",
         order_id: "ABC123",
         purchase_state: 0,
-        purchase_time_millis: 1421676237413,
+        purchase_time_millis: 1_421_676_237_413,
       )
     end
 
@@ -72,13 +72,13 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
 
   describe "non-valid product" do
     let(:fake_product_purchase) do
-      FakeProductPurchase.new(
+      OpenStruct.new(
         consumption_state: 0,
         developer_payload: "payload that gets stored and returned",
         kind: "androidpublisher#productPurchase",
         order_id: "ABC123",
         purchase_state: 1,
-        purchase_time_millis: 1421676237413,
+        purchase_time_millis: 1_421_676_237_413,
       )
     end
 
@@ -86,25 +86,4 @@ describe CandyCheck::PlayStore::ProductPurchases::ProductPurchase do
       _(subject.valid?).must_be_false
     end
   end
-
-  private
-
-  class FakeProductPurchase
-    FIELDS = [
-      :consumption_state,
-      :developer_payload,
-      :kind,
-      :order_id,
-      :purchase_state,
-      :purchase_time_millis,
-    ].freeze
-
-    attr_accessor *FIELDS
-
-    def initialize(hash)
-      FIELDS.each do |key|
-        self.public_send("#{key}=", hash[key])
-      end
-    end
-  end
 end

data/spec/play_store/subscription_purchases/subscription_purchase_spec.rb

@@ -5,10 +5,10 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
 
   describe "expired and canceled subscription" do
     let(:fake_subscription_purchase) do
-      FakeSubscriptionPurchase.new(
+      OpenStruct.new(
         kind: "androidpublisher#subscriptionPurchase",
-        start_time_millis: 1459540113244,
-        expiry_time_millis: 1462132088610,
+        start_time_millis: 1_459_540_113_244,
+        expiry_time_millis: 1_462_132_088_610,
         auto_renewing: false,
         developer_payload: "payload that gets stored and returned",
         cancel_reason: 0,
@@ -66,10 +66,11 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
 
   describe "unexpired and renewing subscription" do
     two_days_from_now = DateTime.now + 2
+
     let(:fake_subscription_purchase) do
-      FakeSubscriptionPurchase.new(
+      OpenStruct.new(
         kind: "androidpublisher#subscriptionPurchase",
-        start_time_millis: 1459540113244,
+        start_time_millis: 1_459_540_113_244,
         expiry_time_millis: (two_days_from_now.to_time.to_i * 1000),
         auto_renewing: true,
         developer_payload: "payload that gets stored and returned",
@@ -89,10 +90,10 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
 
   describe "expired due to payment failure" do
     let(:fake_subscription_purchase) do
-      FakeSubscriptionPurchase.new(
+      OpenStruct.new(
         kind: "androidpublisher#subscriptionPurchase",
-        start_time_millis: 1459540113244,
-        expiry_time_millis: 1462132088610,
+        start_time_millis: 1_459_540_113_244,
+        expiry_time_millis: 1_462_132_088_610,
         auto_renewing: true,
         developer_payload: "payload that gets stored and returned",
         cancel_reason: 1,
@@ -112,10 +113,10 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
   describe "subscription cancelation by user" do
     describe "when subscription is not canceled" do
       let(:fake_subscription_purchase) do
-        FakeSubscriptionPurchase.new(
+        OpenStruct.new(
           kind: "androidpublisher#subscriptionPurchase",
-          start_time_millis: 1459540113244,
-          expiry_time_millis: 1462132088610,
+          start_time_millis: 1_459_540_113_244,
+          expiry_time_millis: 1_462_132_088_610,
           auto_renewing: true,
           developer_payload: "payload that gets stored and returned",
           payment_state: 1,
@@ -137,11 +138,11 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
 
     describe "when subscription is canceled" do
       let(:fake_subscription_purchase) do
-        FakeSubscriptionPurchase.new(
+        OpenStruct.new(
           kind: "androidpublisher#subscriptionPurchase",
-          start_time_millis: 1459540113244,
-          expiry_time_millis: 1462132088610,
-          user_cancellation_time_millis: 1461872888000,
+          start_time_millis: 1_459_540_113_244,
+          expiry_time_millis: 1_462_132_088_610,
+          user_cancellation_time_millis: 1_461_872_888_000,
           auto_renewing: true,
           developer_payload: "payload that gets stored and returned",
           cancel_reason: 0,
@@ -166,10 +167,10 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
 
   describe "expired with pending payment" do
     let(:fake_subscription_purchase) do
-      FakeSubscriptionPurchase.new(
+      OpenStruct.new(
         kind: "androidpublisher#subscriptionPurchase",
-        start_time_millis: 1459540113244,
-        expiry_time_millis: 1462132088610,
+        start_time_millis: 1_459_540_113_244,
+        expiry_time_millis: 1_462_132_088_610,
         auto_renewing: true,
         developer_payload: "payload that gets stored and returned",
         cancel_reason: 0,
@@ -188,10 +189,10 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
 
   describe "trial" do
     let(:fake_subscription_purchase) do
-      FakeSubscriptionPurchase.new(
+      OpenStruct.new(
         kind: "androidpublisher#subscriptionPurchase",
-        start_time_millis: 1459540113244,
-        expiry_time_millis: 1462132088610,
+        start_time_millis: 1_459_540_113_244,
+        expiry_time_millis: 1_462_132_088_610,
         auto_renewing: false,
         developer_payload: "payload that gets stored and returned",
         cancel_reason: 0,
@@ -209,29 +210,4 @@ describe CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase do
       _(subject.price_currency_code).must_equal "SOMECODE"
     end
   end
-
-  private
-
-  class FakeSubscriptionPurchase
-    FIELDS = [
-      :kind,
-      :start_time_millis,
-      :expiry_time_millis,
-      :user_cancellation_time_millis,
-      :auto_renewing,
-      :developer_payload,
-      :cancel_reason,
-      :payment_state,
-      :price_amount_micros,
-      :price_currency_code,
-    ].freeze
-
-    attr_accessor *FIELDS
-
-    def initialize(hash)
-      FIELDS.each do |key|
-        self.public_send("#{key}=", hash[key])
-      end
-    end
-  end
 end

data/spec/play_store/verification_failure_spec.rb

@@ -3,9 +3,13 @@ require "spec_helper"
 describe CandyCheck::PlayStore::VerificationFailure do
   subject { CandyCheck::PlayStore::VerificationFailure.new(fake_error) }
 
+  let(:fake_error_class) do
+    Struct.new(:status_code, :message)
+  end
+
   describe "denied" do
     let(:fake_error) do
-      FakeError.new("401", "The current user has insufficient permissions")
+      fake_error_class.new("401", "The current user has insufficient permissions")
     end
 
     it "returns the code" do
@@ -19,7 +23,7 @@ describe CandyCheck::PlayStore::VerificationFailure do
 
   describe "empty" do
     let(:fake_error) do
-      FakeError.new(nil, nil)
+      fake_error_class.new(nil, nil)
     end
 
     it "returns an unknown code" do
@@ -30,6 +34,4 @@ describe CandyCheck::PlayStore::VerificationFailure do
       _(subject.message).must_equal "Unknown error"
     end
   end
-
-  FakeError = Struct.new(:status_code, :message)
 end

data/spec/play_store/verifier_spec.rb

@@ -32,14 +32,16 @@ describe CandyCheck::PlayStore::Verifier do
   describe "subscription purchases" do
     it "verifies a subscription purchase" do
       VCR.use_cassette("play_store/subscription_purchases/valid_but_expired") do
-        result = subject.verify_subscription_purchase(package_name: package_name, subscription_id: subscription_id, token: token)
+        result = subject.verify_subscription_purchase(package_name: package_name, subscription_id: subscription_id,
+                                                      token: token)
         _(result).must_be_instance_of CandyCheck::PlayStore::SubscriptionPurchases::SubscriptionPurchase
       end
     end
 
     it "can return a subscription purchase verification failure" do
       VCR.use_cassette("play_store/subscription_purchases/permission_denied") do
-        result = subject.verify_subscription_purchase(package_name: package_name, subscription_id: subscription_id, token: token)
+        result = subject.verify_subscription_purchase(package_name: package_name, subscription_id: subscription_id,
+                                                      token: token)
         _(result).must_be_instance_of CandyCheck::PlayStore::VerificationFailure
       end
     end

data/spec/spec_helper.rb

@@ -1,6 +1,3 @@
-require "coveralls"
-Coveralls.wear!
-
 require "candy_check"
 require "candy_check/cli"
 
@@ -8,6 +5,21 @@ def in_continuous_integration_environment?
   ENV["CI"] || ENV["TRAVIS"] || ENV["CONTINUOUS_INTEGRATION"]
 end
 
+require "simplecov"
+
+SimpleCov.start do
+  if in_continuous_integration_environment?
+    require "simplecov-lcov"
+
+    SimpleCov::Formatter::LcovFormatter.config do |c|
+      c.report_with_single_file = true
+      c.single_report_path = "coverage/lcov.info"
+    end
+
+    formatter SimpleCov::Formatter::LcovFormatter
+  end
+end
+
 require "minitest/autorun"
 require "minitest/around/spec"
 require "minitest/focus" unless in_continuous_integration_environment?
@@ -25,14 +37,13 @@ require_relative "support/with_command"
 
 ENV["DEBUG"] && Google::APIClient.logger.level = Logger::DEBUG
 
-class MiniTest::Spec
-  class << self
-    alias :context :describe
+module MiniTest
+  class Spec
+    class << self
+      alias context describe
+    end
   end
-end
-
 
-module MiniTest
   module Assertions
     # The first parameter must be ```true```, not coercible to true.
     def assert_true(obj, msg = nil)