candy_check 0.4.0 → 0.6.0

data/lib/candy_check/play_store/product_purchases/product_purchase.rb

@@ -26,7 +26,7 @@ module CandyCheck
         # The purchase state of the order. Possible values are:
         #   * 0: Purchased
         #   * 1: Cancelled
-        # @return [Fixnum]
+        # @return [Integer]
         def purchase_state
           @product_purchase.purchase_state
         end
@@ -34,7 +34,7 @@ module CandyCheck
         # The consumption state of the inapp product. Possible values are:
         #   * 0: Yet to be consumed
         #   * 1: Consumed
-        # @return [Fixnum]
+        # @return [Integer]
         def consumption_state
           @product_purchase.consumption_state
         end
@@ -60,7 +60,7 @@ module CandyCheck
 
         # The time the product was purchased, in milliseconds since the
         # epoch (Jan 1, 1970)
-        # @return [Fixnum]
+        # @return [Integer]
         def purchase_time_millis
           @product_purchase.purchase_time_millis
         end

data/lib/candy_check/play_store/product_purchases/product_verification.rb

@@ -37,7 +37,7 @@ module CandyCheck
         private
 
         def valid?
-          @response[:result] && @response[:result].purchase_state && @response[:result].consumption_state
+          @response[:result]&.purchase_state && @response[:result]&.consumption_state
         end
 
         def verify!

data/lib/candy_check/play_store/subscription_purchases/subscription_purchase.rb

@@ -5,7 +5,8 @@ module CandyCheck
       class SubscriptionPurchase
         include Utils::AttributeReader
 
-        # @return [Google::Apis::AndroidpublisherV3::SubscriptionPurchase] the raw subscription purchase from google-api-client
+        # @return [Google::Apis::AndroidpublisherV3::SubscriptionPurchase] the raw subscription purchase
+        #   from google-api-client
         attr_reader :subscription_purchase
 
         # The payment of the subscription is pending (paymentState)

data/lib/candy_check/play_store/subscription_purchases/subscription_verification.rb

@@ -38,6 +38,7 @@ module CandyCheck
 
         def valid?
           return false unless @response[:result]
+
           ok_kind = @response[:result].kind == "androidpublisher#subscriptionPurchase"
           @response && @response[:result].expiry_time_millis && ok_kind
         end

data/lib/candy_check/play_store/verification_failure.rb

@@ -15,10 +15,10 @@ module CandyCheck
       end
 
       # The code of the failure
-      # @return [Fixnum]
+      # @return [Integer]
       def code
         Integer(error.status_code)
-      rescue
+      rescue StandardError
         -1
       end
 

data/lib/candy_check/play_store.rb

@@ -1,4 +1,5 @@
-require "google/apis/androidpublisher_v3"
+require "google-apis-androidpublisher_v3"
+require "googleauth"
 
 require "candy_check/play_store/android_publisher_service"
 require "candy_check/play_store/product_purchases/product_purchase"

data/lib/candy_check/utils/attribute_reader.rb

@@ -1,4 +1,4 @@
-require 'date'
+require "date"
 
 module CandyCheck
   module Utils
@@ -23,7 +23,8 @@ module CandyCheck
       def read_bool(field)
         val = read(field).to_s
         return nil unless %w(false true).include?(val)
-        val == 'true'
+
+        val == "true"
       end
 
       def read_datetime_from_string(field)

data/lib/candy_check/utils/config.rb

@@ -26,6 +26,7 @@ module CandyCheck
       # @raise [ArgumentError] if attribute is missing
       def validates_presence(name)
         return if send(name)
+
         raise ArgumentError, "Configuration field #{name} is missing"
       end
 
@@ -34,6 +35,7 @@ module CandyCheck
       # @param values [Array] of possible values
       def validates_inclusion(name, *values)
         return if values.include?(send(name))
+
         raise ArgumentError, "Configuration field #{name} should be "\
                             "one of: #{values.join(', ')}"
       end

data/lib/candy_check/utils.rb

@@ -1,2 +1,2 @@
-require 'candy_check/utils/attribute_reader'
-require 'candy_check/utils/config'
+require "candy_check/utils/attribute_reader"
+require "candy_check/utils/config"

data/lib/candy_check/version.rb

@@ -1,4 +1,4 @@
 module CandyCheck
   # The current gem's version
-  VERSION = "0.4.0".freeze
+  VERSION = "0.6.0".freeze
 end

data/lib/candy_check.rb

@@ -1,7 +1,7 @@
-require 'candy_check/version'
-require 'candy_check/utils'
-require 'candy_check/app_store'
-require 'candy_check/play_store'
+require "candy_check/version"
+require "candy_check/utils"
+require "candy_check/app_store"
+require "candy_check/play_store"
 
 # Module to check and verify in-app receipts
 module CandyCheck

data/spec/app_store/client_spec.rb

@@ -1,12 +1,12 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::AppStore::Client do
-  let(:endpoint_url) { 'https://some.endpoint.com/verify' }
+  let(:endpoint_url) { "https://some.endpoint.com/verify" }
   let(:receipt_data) do
-    'some_very_long_receipt_information_which_is_normaly_base64_encoded'
+    "some_very_long_receipt_information_which_is_normaly_base64_encoded"
   end
   let(:password) do
-    'some_secret_password'
+    "some_secret_password"
   end
   let(:response) do
     '{
@@ -18,40 +18,40 @@ describe CandyCheck::AppStore::Client do
   end
   let(:expected) do
     {
-      'status' => 0,
-      'receipt' => {
-        'item_id' => '521129812'
-      }
+      "status" => 0,
+      "receipt" => {
+        "item_id" => "521129812",
+      },
     }
   end
 
   subject { CandyCheck::AppStore::Client.new(endpoint_url) }
 
-  describe 'valid response' do
-    it 'sends JSON and parses the JSON response without a secret' do
+  describe "valid response" do
+    it "sends JSON and parses the JSON response without a secret" do
       stub_endpoint
         .with(
           body: {
-            'receipt-data' => receipt_data
-          }
+            "receipt-data" => receipt_data,
+          },
         )
         .to_return(
-          body: response
+          body: response,
         )
       result = subject.verify(receipt_data)
       _(result).must_equal expected
     end
 
-    it 'sends JSON and parses the JSON response with a secret' do
+    it "sends JSON and parses the JSON response with a secret" do
       stub_endpoint
         .with(
           body: {
-            'receipt-data' => receipt_data,
-            'password'     => password
-          }
+            "receipt-data" => receipt_data,
+            "password" => password,
+          },
         )
         .to_return(
-          body: response
+          body: response,
         )
       result = subject.verify(receipt_data, password)
       _(result).must_equal expected

data/spec/app_store/config_spec.rb

@@ -1,39 +1,39 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::AppStore::Config do
   subject { CandyCheck::AppStore::Config.new(attributes) }
 
-  describe 'valid' do
+  describe "valid" do
     let(:attributes) do
       {
-        environment: :sandbox
+        environment: :sandbox,
       }
     end
 
-    it 'returns environment' do
+    it "returns environment" do
       _(subject.environment).must_equal :sandbox
     end
 
-    it 'checks for production?' do
+    it "checks for production?" do
       _(subject.production?).must_be_false
 
       other = CandyCheck::AppStore::Config.new(
-        environment: :production
+        environment: :production,
       )
       _(other.production?).must_be_true
     end
   end
 
-  describe 'invalid' do
+  describe "invalid" do
     let(:attributes) do
       {}
     end
 
-    it 'needs an environment' do
+    it "needs an environment" do
       _(proc { subject }).must_raise ArgumentError
     end
 
-    it 'needs an included environment' do
+    it "needs an included environment" do
       attributes[:environment] = :invalid
       _(proc { subject }).must_raise ArgumentError
     end

data/spec/app_store/receipt_collection_spec.rb

@@ -1,98 +1,96 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::AppStore::ReceiptCollection do
   subject { CandyCheck::AppStore::ReceiptCollection.new(attributes) }
 
-  describe 'overdue subscription' do
+  describe "overdue subscription" do
     let(:attributes) do
       [{
-        'expires_date' => '2014-04-15 12:52:40 Etc/GMT',
-        'expires_date_pst' => '2014-04-15 05:52:40 America/Los_Angeles',
-        'purchase_date' => '2014-04-14 12:52:40 Etc/GMT',
-        'is_trial_period' => 'false'
+        "expires_date" => "2014-04-15 12:52:40 Etc/GMT",
+        "expires_date_pst" => "2014-04-15 05:52:40 America/Los_Angeles",
+        "purchase_date" => "2014-04-14 12:52:40 Etc/GMT",
+        "is_trial_period" => "false",
       }, {
-        'expires_date' => '2015-04-15 12:52:40 Etc/GMT',
-        'expires_date_pst' => '2015-04-15 05:52:40 America/Los_Angeles',
-        'purchase_date' => '2015-04-14 12:52:40 Etc/GMT',
-        'is_trial_period' => 'false'
+        "expires_date" => "2015-04-15 12:52:40 Etc/GMT",
+        "expires_date_pst" => "2015-04-15 05:52:40 America/Los_Angeles",
+        "purchase_date" => "2015-04-14 12:52:40 Etc/GMT",
+        "is_trial_period" => "false",
       }]
     end
 
-    it 'is expired' do
+    it "is expired" do
       _(subject.expired?).must_be_true
     end
 
-    it 'is not a trial' do
+    it "is not a trial" do
       _(subject.trial?).must_be_false
     end
 
-    it 'has positive overdue days' do
+    it "has positive overdue days" do
       overdue = subject.overdue_days
-      _(overdue).must_be_instance_of Fixnum
+      _(overdue).must_be_instance_of Integer
       assert overdue > 0
     end
 
-    it 'has a last expires date' do
+    it "has a last expires date" do
       expected = DateTime.new(2015, 4, 15, 12, 52, 40)
       _(subject.expires_at).must_equal expected
     end
 
-    it 'is expired? at same pointin time' do
+    it "is expired? at same pointin time" do
       Timecop.freeze(Time.utc(2015, 4, 15, 12, 52, 40)) do
         _(subject.expired?).must_be_true
       end
     end
   end
 
-  describe 'unordered receipts' do
+  describe "unordered receipts" do
     let(:attributes) do
       [{
-           'expires_date' => '2015-04-15 12:52:40 Etc/GMT',
-           'expires_date_pst' => '2015-04-15 05:52:40 America/Los_Angeles',
-           'purchase_date' => '2015-04-14 12:52:40 Etc/GMT',
-           'is_trial_period' => 'false'
-       }, {
-           'expires_date' => '2014-04-15 12:52:40 Etc/GMT',
-           'expires_date_pst' => '2014-04-15 05:52:40 America/Los_Angeles',
-           'purchase_date' => '2014-04-14 12:52:40 Etc/GMT',
-           'is_trial_period' => 'false'
-       }]
+        "expires_date" => "2015-04-15 12:52:40 Etc/GMT",
+        "expires_date_pst" => "2015-04-15 05:52:40 America/Los_Angeles",
+        "purchase_date" => "2015-04-14 12:52:40 Etc/GMT",
+        "is_trial_period" => "false",
+      }, {
+        "expires_date" => "2014-04-15 12:52:40 Etc/GMT",
+        "expires_date_pst" => "2014-04-15 05:52:40 America/Los_Angeles",
+        "purchase_date" => "2014-04-14 12:52:40 Etc/GMT",
+        "is_trial_period" => "false",
+      }]
     end
 
-    it 'the expires date is the latest one in time' do
+    it "the expires date is the latest one in time" do
       expected = DateTime.new(2015, 4, 15, 12, 52, 40)
       _(subject.expires_at).must_equal expected
     end
-
   end
 
-  describe 'unexpired trial subscription' do
+  describe "unexpired trial subscription" do
     two_days_from_now = DateTime.now + 2
 
     let(:attributes) do
       [{
-        'expires_date' => '2016-04-15 12:52:40 Etc/GMT',
-        'purchase_date' => '2016-04-15 12:52:40 Etc/GMT',
-        'is_trial_period' => 'true'
+        "expires_date" => "2016-04-15 12:52:40 Etc/GMT",
+        "purchase_date" => "2016-04-15 12:52:40 Etc/GMT",
+        "is_trial_period" => "true",
       }, {
-        'expires_date' =>
-          two_days_from_now.strftime('%Y-%m-%d %H:%M:%S Etc/GMT'),
-        'purchase_date' => '2016-04-15 12:52:40 Etc/GMT',
-        'is_trial_period' => 'true'
+        "expires_date" =>
+          two_days_from_now.strftime("%Y-%m-%d %H:%M:%S Etc/GMT"),
+        "purchase_date" => "2016-04-15 12:52:40 Etc/GMT",
+        "is_trial_period" => "true",
       }]
     end
 
-    it 'has not expired' do
+    it "has not expired" do
       _(subject.expired?).must_be_false
     end
 
-    it 'it is a trial' do
+    it "it is a trial" do
       _(subject.trial?).must_be_true
     end
 
-    it 'expires in two days' do
+    it "expires in two days" do
       _(subject.overdue_days).must_equal(-2)
     end
   end
-
 end

data/spec/app_store/receipt_spec.rb

@@ -1,105 +1,105 @@
-require 'spec_helper'
+require "spec_helper"
 
 describe CandyCheck::AppStore::Receipt do
   subject { CandyCheck::AppStore::Receipt.new(attributes) }
 
   let(:attributes) do
     {
-      'original_purchase_date_pst' => '2015-01-08 03:40:46' \
-                                      ' America/Los_Angeles',
-      'purchase_date_ms'           => '1420803646868',
-      'unique_identifier'          => 'some_uniq_identifier_from_apple' \
-                                      '_for_this',
-      'original_transaction_id'    => 'some_original_transaction_id',
-      'bvrs'                       => '2.0',
-      'transaction_id'             => 'some_transaction_id',
-      'quantity'                   => '1',
-      'unique_vendor_identifier'   => '00000000-1111-2222-3333-' \
-                                      '444444444444',
-      'item_id'                    => 'some_item_id',
-      'product_id'                 => 'some_product',
-      'purchase_date'              => '2015-01-09 11:40:46 Etc/GMT',
-      'original_purchase_date'     => '2015-01-08 11:40:46 Etc/GMT',
-      'purchase_date_pst'          => '2015-01-09 03:40:46' \
-                                      ' America/Los_Angeles',
-      'bid'                        => 'some.test.app',
-      'original_purchase_date_ms'  => '1420717246868',
-      'expires_date'               => '2016-06-09 13:59:40 Etc/GMT',
-      'is_trial_period'            => 'false'
+      "original_purchase_date_pst" => "2015-01-08 03:40:46" \
+                                      " America/Los_Angeles",
+      "purchase_date_ms" => "1420803646868",
+      "unique_identifier" => "some_uniq_identifier_from_apple" \
+                                      "_for_this",
+      "original_transaction_id" => "some_original_transaction_id",
+      "bvrs" => "2.0",
+      "transaction_id" => "some_transaction_id",
+      "quantity" => "1",
+      "unique_vendor_identifier" => "00000000-1111-2222-3333-" \
+                                      "444444444444",
+      "item_id" => "some_item_id",
+      "product_id" => "some_product",
+      "purchase_date" => "2015-01-09 11:40:46 Etc/GMT",
+      "original_purchase_date" => "2015-01-08 11:40:46 Etc/GMT",
+      "purchase_date_pst" => "2015-01-09 03:40:46" \
+                                      " America/Los_Angeles",
+      "bid" => "some.test.app",
+      "original_purchase_date_ms" => "1420717246868",
+      "expires_date" => "2016-06-09 13:59:40 Etc/GMT",
+      "is_trial_period" => "false",
     }
   end
 
-  describe 'valid transaction' do
-    it 'is valid' do
+  describe "valid transaction" do
+    it "is valid" do
       _(subject.valid?).must_be_true
     end
 
-    it 'returns the item\'s id' do
-      _(subject.item_id).must_equal 'some_item_id'
+    it "returns the item's id" do
+      _(subject.item_id).must_equal "some_item_id"
     end
 
-    it 'returns the item\'s product_id' do
-      _(subject.product_id).must_equal 'some_product'
+    it "returns the item's product_id" do
+      _(subject.product_id).must_equal "some_product"
     end
 
-    it 'returns the quantity' do
+    it "returns the quantity" do
       _(subject.quantity).must_equal 1
     end
 
-    it 'returns the app version' do
-      _(subject.app_version).must_equal '2.0'
+    it "returns the app version" do
+      _(subject.app_version).must_equal "2.0"
     end
 
-    it 'returns the bundle identifier' do
-      _(subject.bundle_identifier).must_equal 'some.test.app'
+    it "returns the bundle identifier" do
+      _(subject.bundle_identifier).must_equal "some.test.app"
     end
 
-    it 'returns the purchase date' do
+    it "returns the purchase date" do
       expected = DateTime.new(2015, 1, 9, 11, 40, 46)
       _(subject.purchase_date).must_equal expected
     end
 
-    it 'returns the original purchase date' do
+    it "returns the original purchase date" do
       expected = DateTime.new(2015, 1, 8, 11, 40, 46)
       _(subject.original_purchase_date).must_equal expected
     end
 
-    it 'returns the transaction id' do
-      _(subject.transaction_id).must_equal 'some_transaction_id'
+    it "returns the transaction id" do
+      _(subject.transaction_id).must_equal "some_transaction_id"
     end
 
-    it 'returns the original transaction id' do
-      _(subject.original_transaction_id).must_equal 'some_original_transaction_id'
+    it "returns the original transaction id" do
+      _(subject.original_transaction_id).must_equal "some_original_transaction_id"
     end
 
-    it 'return nil for cancellation date' do
+    it "return nil for cancellation date" do
       _(subject.cancellation_date).must_be_nil
     end
 
-    it 'returns raw attributes' do
+    it "returns raw attributes" do
       _(subject.attributes).must_be_same_as attributes
     end
 
-    it 'returns the subscription expiration date' do
+    it "returns the subscription expiration date" do
       expected = DateTime.new(2016, 6, 9, 13, 59, 40)
       _(subject.expires_date).must_equal expected
     end
 
-    it 'returns the trial status' do
+    it "returns the trial status" do
       _(subject.is_trial_period).must_be_false
     end
   end
 
-  describe 'valid transaction' do
+  describe "valid transaction" do
     before do
-      attributes['cancellation_date'] = '2015-01-12 11:40:46 Etc/GMT'
+      attributes["cancellation_date"] = "2015-01-12 11:40:46 Etc/GMT"
     end
 
-    it 'isn\'t valid' do
+    it "isn't valid" do
       _(subject.valid?).must_be_false
     end
 
-    it 'return nil for cancellation date' do
+    it "return nil for cancellation date" do
       expected = DateTime.new(2015, 1, 12, 11, 40, 46)
       _(subject.cancellation_date).must_equal expected
     end