byebug 1.0.3 → 1.1.0

data/test/info_test.rb

@@ -1,90 +1,88 @@
 require_relative 'test_helper'
 
-describe "Info Command" do
+describe 'Info Command' do
   include TestDsl
   include Columnize
 
-   describe "Args info" do
-     before { Byebug::InfoCommand.settings[:width] = 15 }
-
-     it "must show info about all args" do
-       enter 'break 3', 'cont', 'info args'
+   describe 'Args info' do
+     it 'must show info about all args' do
+       enter 'set width 15', 'break 3', 'cont', 'info args'
        debug_file 'info'
        check_output_includes 'a = "aaaaaaa...', 'b = "b"'
      end
    end
 
-  describe "Breakpoints info" do
-    it "must show info about all breakpoints" do
+  describe 'Breakpoints info' do
+    it 'must show info about all breakpoints' do
       enter 'break 7', 'break 9 if a == b', 'info breakpoints'
       debug_file 'info'
-      check_output_includes "Num Enb What",
+      check_output_includes 'Num Enb What',
                             /\d+ +y   at #{fullpath('info')}:7/,
                             /\d+ +y   at #{fullpath('info')}:9 if a == b/
     end
 
-    it "must show info about specific breakpoint" do
+    it 'must show info about specific breakpoint' do
       enter 'break 7', 'break 9',
-            ->{"info breakpoints #{Byebug.breakpoints.first.id}"}
+            ->{ "info breakpoints #{Byebug.breakpoints.first.id}" }
       debug_file 'info'
-      check_output_includes "Num Enb What", /\d+ +y   at #{fullpath('info')}:7/
+      check_output_includes 'Num Enb What', /\d+ +y   at #{fullpath('info')}:7/
       check_output_doesnt_include  /\d+ +y   at #{fullpath('info')}:9/
     end
 
-    it "must show an error if no breakpoints are found" do
+    it 'must show an error if no breakpoints are found' do
       enter 'info breakpoints'
       debug_file 'info'
-      check_output_includes "No breakpoints."
+      check_output_includes 'No breakpoints.'
     end
 
-    it "must show an error if no breakpoints are found" do
+    it 'must show an error if no breakpoints are found' do
       enter 'break 7', 'info breakpoints 123'
       debug_file 'info'
-      check_output_includes "No breakpoints found among list given.",
-                            interface.error_queue
+      check_output_includes \
+        'No breakpoints found among list given.', interface.error_queue
     end
 
-    it "must show hit count" do
+    it 'must show hit count' do
       enter 'break 9', 'cont', 'info breakpoints'
       debug_file 'info'
-      check_output_includes /\d+ +y   at #{fullpath('info')}:9/
-      check_output_includes /\d+ +y   at #{fullpath('info')}:9/,
-                            "breakpoint already hit 1 time"
+      check_output_includes \
+        /\d+ +y   at #{fullpath('info')}:9/, 'breakpoint already hit 1 time'
     end
   end
 
-  describe "Display info" do
-    it "must show all display expressions" do
+  describe 'Display info' do
+    it 'must show all display expressions' do
       enter 'display 3 + 3', 'display a + b', 'info display'
       debug_file 'info'
-      check_output_includes "Auto-display expressions now in effect:",
-                            "Num Enb Expression",
-                            "1: y  3 + 3",
-                            "2: y  a + b"
+      check_output_includes 'Auto-display expressions now in effect:',
+                            'Num Enb Expression',
+                            '1: y  3 + 3',
+                            '2: y  a + b'
     end
 
-    it "must show a message if there are no display expressions created" do
+    it 'must show a message if there are no display expressions created' do
       enter 'info display'
       debug_file 'info'
-      check_output_includes "There are no auto-display expressions now."
+      check_output_includes 'There are no auto-display expressions now.'
     end
   end
 
-  describe "Files info" do
+  describe 'Files info' do
     let(:files) { (LineCache.cached_files + SCRIPT_LINES__.keys).uniq.sort }
-    it "must show all files read in" do
+
+    it 'must show all files read in' do
       enter 'info files'
       debug_file 'info'
       check_output_includes files.map { |f| "File #{f}" }
     end
 
-    it "must show all files read in using 'info file' too" do
+    it 'must show all files read in using "info file" too' do
       enter 'info file'
       debug_file 'info'
       check_output_includes files.map { |f| "File #{f}" }
     end
 
-    it "must show explicitly loaded files" do
+    it 'must show explicitly loaded files' do
       enter 'info files stat'
       debug_file 'info'
       check_output_includes "File #{fullpath('info')}",
@@ -92,199 +90,199 @@ describe "Info Command" do
     end
   end
 
-  describe "File info" do
+  describe 'File info' do
     let(:file) { fullpath('info') }
     let(:filename) { "File #{file}" }
     let(:lines) { "#{LineCache.size(file)} lines" }
     let(:mtime) { LineCache.stat(file).mtime.to_s }
     let(:sha1) { LineCache.sha1(file) }
-    let(:breakpoint_line_numbers) do
+    let(:breakpoint_line_numbers) {
       columnize(LineCache.trace_line_numbers(file).to_a.sort,
-                Byebug::InfoCommand.settings[:width])
-    end
+                Byebug::InfoCommand.settings[:width]) }
 
-    it "must show basic info about the file" do
+    it 'must show basic info about the file' do
       enter "info file #{file} basic"
       debug_file 'info'
       check_output_includes filename, lines
       check_output_doesnt_include breakpoint_line_numbers, mtime, sha1
     end
 
-    it "must show number of lines" do
+    it 'must show number of lines' do
       enter "info file #{file} lines"
       debug_file 'info'
       check_output_includes filename, lines
       check_output_doesnt_include breakpoint_line_numbers, mtime, sha1
     end
 
-    it "must show mtime of the file" do
+    it 'must show mtime of the file' do
       enter "info file #{file} mtime"
       debug_file 'info'
       check_output_includes filename, mtime
       check_output_doesnt_include lines, breakpoint_line_numbers, sha1
     end
 
-    it "must show sha1 of the file" do
+    it 'must show sha1 of the file' do
       enter "info file #{file} sha1"
       debug_file 'info'
       check_output_includes filename, sha1
       check_output_doesnt_include lines, breakpoint_line_numbers, mtime
     end
 
-    it "must show breakpoints in the file" do
+    it 'must show breakpoints in the file' do
       enter 'break 5', 'break 7', "info file #{file} breakpoints"
       debug_file 'info'
       check_output_includes /Created breakpoint \d+ at #{file}:5/,
                             /Created breakpoint \d+ at #{file}:7/,
                             filename,
-                            "breakpoint line numbers:", breakpoint_line_numbers
+                            'breakpoint line numbers:', breakpoint_line_numbers
       check_output_doesnt_include lines, mtime, sha1
     end
 
-    it "must show all info about the file" do
+    it 'must show all info about the file' do
       enter "info file #{file} all"
       debug_file 'info'
       check_output_includes \
         filename, lines, breakpoint_line_numbers, mtime, sha1
     end
 
-    it "must not show info about the file if the file is not loaded" do
+    it 'must not show info about the file if the file is not loaded' do
       enter "info file #{fullpath('info2')} basic"
       debug_file 'info'
       check_output_includes "File #{fullpath('info2')} is not cached"
     end
 
-    it "must not show any info if the parameter is invalid" do
+    it 'must not show any info if the parameter is invalid' do
       enter "info file #{file} blabla"
       debug_file 'info'
-      check_output_includes "Invalid parameter blabla", interface.error_queue
+      check_output_includes 'Invalid parameter blabla', interface.error_queue
     end
   end
 
-  describe "Instance variables info" do
-    it "must show instance variables" do
+  describe 'Instance variables info' do
+    it 'must show instance variables' do
       enter 'break 21', 'cont', 'info instance_variables'
       debug_file 'info'
       check_output_includes '@bla = "blabla"', '@foo = "bar"'
     end
   end
 
-  describe "Line info" do
-    it "must show the current line" do
+  describe 'Line info' do
+    it 'must show the current line' do
       enter 'break 21', 'cont', 'info line'
       debug_file 'info'
       check_output_includes "Line 21 of \"#{fullpath('info')}\""
     end
   end
 
-  describe "Locals info" do
-
-    it "must show the current local variables" do
-      Byebug::InfoCommand.settings[:width] = 12
-      enter 'break 21', 'cont', 'info locals'
+  describe 'Locals info' do
+    it 'must show the current local variables' do
+      enter 'set width 12', 'break 21', 'cont', 'info locals'
       debug_file 'info'
       check_output_includes 'a = "1111...', 'b = 2'
     end
 
-    it "must fail if the local variable doesn't respond to #to_s or to #inspect" do
-      Byebug::InfoCommand.settings[:width] = 21
-      enter 'break 26', 'cont', 'info locals'
+    it 'must fail if local variable doesn\'t respond to #to_s or to #inspect' do
+      enter 'set width 21', 'break 26', 'cont', 'info locals'
       debug_file 'info'
-      check_output_includes "*Error in evaluation*"
+      check_output_includes '*Error in evaluation*'
     end
   end
 
-  describe "Program info" do
-    it "must show the initial stop reason" do
+  describe 'Program info' do
+    it 'must show the initial stop reason' do
       enter 'info program'
       debug_file 'info'
       check_output_includes \
-        "It stopped after stepping, next'ing or initial start."
+        'It stopped after stepping, next\'ing or initial start.'
     end
 
-    it "must show the step stop reason" do
+    it 'must show the step stop reason' do
       enter 'step', 'info program'
       debug_file 'info'
       check_output_includes \
-        "Program stopped.",
-        "It stopped after stepping, next'ing or initial start."
+        'Program stopped.',
+        'It stopped after stepping, next\'ing or initial start.'
     end
 
-    it "must show the breakpoint stop reason" do
+    it 'must show the breakpoint stop reason' do
       enter 'break 7', 'cont', 'info program'
       debug_file 'info'
-      check_output_includes "Program stopped.", "It stopped at a breakpoint."
+      check_output_includes 'Program stopped.', 'It stopped at a breakpoint.'
     end
 
-    it "must show the catchpoint stop reason"
+    it 'must show the catchpoint stop reason' do
+      skip('TODO')
+    end
 
-    it "must show the unknown stop reason" do
+    it 'must show the unknown stop reason' do
       enter 'break 7', 'cont',
-             ->{context.stubs(:stop_reason).returns("blabla"); 'info program'}
+             ->{ context.stubs(:stop_reason).returns('blabla'); 'info program' }
       debug_file 'info'
-      check_output_includes "Program stopped.", "unknown reason: blabla"
+      check_output_includes 'Program stopped.', 'unknown reason: blabla'
     end
 
-    it "must show an error if the program is crashed"
+    it 'must show an error if the program is crashed' do
+      skip('TODO')
+    end
   end
 
-  describe "Stack info" do
-    before { Byebug::InfoCommand.settings[:full_path] = true }
+  describe 'Stack info' do
+    let(:width) { "    #2  <main> at #{fullpath('info')}:36".size }
 
-    it "must show stack info" do
-      enter 'break 20', 'cont', 'info stack'
+    it 'must show stack info' do
+      enter 'set fullpath', ->{ "set width #{width}"}, 'break 20', 'cont',
+            'info stack'
       debug_file 'info'
-      check_output_includes \
-        "-->", "#0", "A.a", "at #{fullpath('info')}:20",
-               "#1", "A.b", "at #{fullpath('info')}:30",
-               "#2",        "at #{fullpath('info')}:36"
+      check_output_includes "--> #0  A.a at #{fullpath('info')}:20",
+                            "    #1  A.b at #{fullpath('info')}:30",
+                            "    #2  <main> at #{fullpath('info')}:36"
     end
   end
 
-   describe "Thread info" do
-     it "must show threads info when without args" do
+   describe 'Thread info' do
+     it 'must show threads info when without args' do
        enter 'break 48', 'cont', 'info threads'
        debug_file 'info_threads'
        check_output_includes /#<Thread:\S+ run>/
      end
 
-     it "must show thread info" do
-       skip("XXX: Unreliable due to race conditions, needs fix to be reliable")
+     it 'must show thread info' do
+       skip('XXX: Unreliable due to race conditions, needs fix to be reliable')
        thread_number = nil
-       enter ->{thread_number = context.thnum; "info thread #{context.thnum}"}
+       enter ->{ thread_number = context.thnum; "info thread #{context.thnum}" }
        debug_file 'info'
-       check_output_includes "+", thread_number.to_s, /#<Thread:\S+ run>/
+       check_output_includes '+', thread_number.to_s, /#<Thread:\S+ run>/
      end
 
-     it "must show verbose thread info" do
-       skip("XXX: Unreliable due to race conditions, needs fix to be reliable")
-       enter 'break 20', 'cont', ->{"info thread #{context.thnum} verbose"}
+     it 'must show verbose thread info' do
+       skip('XXX: Unreliable due to race conditions, needs fix to be reliable')
+       enter 'break 20', 'cont', ->{ "info thread #{context.thnum} verbose" }
        debug_file 'info'
-       check_output_includes /#<Thread:\S+ run>/, "#0", "A.a",
-                             "at #{fullpath('info')}:20"
+       check_output_includes \
+         /#<Thread:\S+ run>/, '#0', 'A.a', "at #{fullpath('info')}:20"
      end
 
-     it "must show error when unknown parameter is used" do
-       skip("No thread support")
-       enter ->{"info thread #{context.thnum} blabla"}
+     it 'must show error when unknown parameter is used' do
+       skip('No thread support')
+       enter ->{'info thread #{context.thnum} blabla'}
        debug_file 'info'
-       check_output_includes "'terse' or 'verbose' expected. Got 'blabla'",
-                             interface.error_queue
+       check_output_includes \
+         '"terse" or "verbose" expected. Got "blabla"', interface.error_queue
      end
    end
 
-  describe "Global Variables info" do
-    it "must show global variables" do
+  describe 'Global Variables info' do
+    it 'must show global variables' do
       enter 'info global_variables'
       debug_file 'info'
       check_output_includes "$$ = #{Process.pid}"
     end
   end
 
-  describe "Variables info" do
-    before { Byebug::InfoCommand.settings[:width] = 30 }
+  describe 'Variables info' do
+    before { Byebug::Command.settings[:width] = 30 }
 
-    it "must show all variables" do
+    it 'must show all variables' do
       enter 'break 21', 'cont', 'info variables'
       debug_file 'info'
       check_output_includes 'a = "1111111111111111111111...',
@@ -294,7 +292,7 @@ describe "Info Command" do
                             '@foo = "bar"'
     end
 
-    it "must fail if the variable doesn't respond to #to_s or to #inspect" do
+    it 'must fail if the variable doesn\'t respond to #to_s or to #inspect' do
       enter 'break 26', 'cont', 'info variables'
       debug_file 'info'
       check_output_includes 'a = *Error in evaluation*',
@@ -303,18 +301,17 @@ describe "Info Command" do
                             '@foo = "bar"'
     end
 
-    it "must handle printf strings correctly" do
+    it 'must handle printf strings correctly' do
       enter 'break 32', 'cont', 'info variables'
       debug_file 'info'
       check_output_includes 'e = "%%.2f"'
     end
   end
 
-  describe "Post Mortem" do
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
+  describe 'Post Mortem' do
+    it 'must work in post-mortem mode' do
       enter 'cont', 'info line'
-      debug_file "post_mortem"
+      debug_file 'post_mortem'
       check_output_includes "Line 8 of \"#{fullpath('post_mortem')}\""
     end
   end

data/test/irb_test.rb

@@ -1,62 +1,64 @@
 require_relative 'test_helper'
 
-describe "Irb Command" do
+describe 'Irb Command' do
   include TestDsl
 
   def after_setup
     interface.stubs(:kind_of?).with(Byebug::LocalInterface).returns(true)
     IRB::Irb.stubs(:new).returns(irb)
-    Signal.trap("SIGINT", "IGNORE")
+    Signal.trap('SIGINT', 'IGNORE')
   end
 
   def after_teardown
-    Signal.trap("SIGINT", "DEFAULT")
+    Signal.trap('SIGINT', 'DEFAULT')
   end
 
   let(:irb) { stub(context: ->{}) }
 
-  it "must support next command" do
+  it 'must support next command' do
     irb.stubs(:eval_input).throws(:IRB_EXIT, :next)
     enter 'irb'
     debug_file('irb') { state.line.must_equal 3 }
   end
 
-  it "must support step command" do
+  it 'must support step command' do
     irb.stubs(:eval_input).throws(:IRB_EXIT, :step)
     enter 'irb'
     debug_file('irb') { state.line.must_equal 3 }
   end
 
-  it "must support cont command" do
+  it 'must support cont command' do
     irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
     enter 'break 4', 'irb'
     debug_file('irb') { state.line.must_equal 4 }
   end
 
-  #describe "autoirb" do
-  #  it "must call irb automatically after breakpoint" do
-  #    irb.expects(:eval_input)
-  #    enter 'set autoirb', 'break 4', 'cont'
-  #    debug_file 'irb'
-  #  end
-  #end
+  describe 'autoirb' do
+    it 'must call irb automatically after breakpoint' do
+      skip('Segfaulting... skip until fixed')
+      irb.expects(:eval_input)
+      enter 'set autoirb', 'break 4', 'cont'
+      debug_file 'irb'
+    end
+  end
 
-  # TODO: Can't reliably test the signal, from time to time Signal.trap, which
-  # is defined in IRBCommand, misses the SIGINT signal, which makes the test
-  # suite exit. Not sure how to fix that...
-  it "must translate SIGINT into 'cont' command" do
-    irb.stubs(:eval_input).calls { Process.kill("SIGINT", Process.pid) }
+  it 'must translate SIGINT into "cont" command' do
+    skip 'TODO: Can\'t reliably test the signal, from time to time '       \
+         'Signal.trap, which is defined in IRBCommand, misses the SIGINT ' \
+         'signal, which makes the test suite exit. Not sure how to fix '   \
+         'that...'
+    irb.stubs(:eval_input).calls { Process.kill('SIGINT', Process.pid) }
     enter 'break 4', 'irb'
     debug_file('irb') { state.line.must_equal 4 }
   end
 
-  describe "setting context to $byebug_state" do
+  describe 'setting context to $byebug_state' do
     before do
       $byebug_state = nil
       Byebug::Command.settings[:byebugtesting] = false
     end
 
-    it "must set $byebug_state if irb is in the debug mode" do
+    it 'must set $byebug_state if irb is in the debug mode' do
       byebug_state = nil
       irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
       enter 'irb -d'
@@ -64,7 +66,7 @@ describe "Irb Command" do
       byebug_state.must_be_kind_of Byebug::CommandProcessor::State
     end
 
-    it "must not set $byebug_state if irb is not in the debug mode" do
+    it 'must not set $byebug_state if irb is not in the debug mode' do
       byebug_state = nil
       irb.stubs(:eval_input).calls { byebug_state = $byebug_state }
       enter 'irb'
@@ -73,12 +75,11 @@ describe "Irb Command" do
     end
   end
 
-  describe "Post Mortem" do
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
+  describe 'Post Mortem' do
+    it 'must work in post-mortem mode' do
       irb.stubs(:eval_input).throws(:IRB_EXIT, :cont)
       enter 'cont', 'break 12', 'irb'
-      debug_file("post_mortem") { state.line.must_equal 12 }
+      debug_file('post_mortem') { state.line.must_equal 12 }
     end
   end