byebug 1.0.3 → 1.1.0

data/test/breakpoints_test.rb

@@ -369,7 +369,6 @@ describe 'Breakpoints' do
 
   describe 'Post Mortem' do
     it 'must be able to set breakpoints in post-mortem mode' do
-      skip('No post morten mode for now')
       enter 'cont', 'break 12', 'cont'
       debug_file('post_mortem') { state.line.must_equal 12 }
     end

data/test/conditions_test.rb

@@ -1,79 +1,81 @@
 require_relative 'test_helper'
 
-describe "Conditions" do
+describe 'Conditions' do
   include TestDsl
 
-  describe "setting condition" do
+  describe 'setting condition' do
     before { enter 'break 3' }
 
-    describe "successfully" do
-      it "must assign the expression to breakpoint" do
-        enter ->{"cond #{Byebug.breakpoints.first.id} b == 5"}, "cont"
+    describe 'successfully' do
+      it 'must assign the expression to breakpoint' do
+        enter ->{ "cond #{Byebug.breakpoints.first.id} b == 5" }, 'cont'
         debug_file('conditions') {
-          Byebug.breakpoints.first.expr.must_equal "b == 5" }
+          Byebug.breakpoints.first.expr.must_equal 'b == 5' }
       end
 
-      it "must stop at the breakpoint if condition is true" do
-        enter ->{"cond #{Byebug.breakpoints.first.id} b == 5"}, "cont"
+      it 'must stop at the breakpoint if condition is true' do
+        enter ->{ "cond #{Byebug.breakpoints.first.id} b == 5" }, 'cont'
         debug_file('conditions') { state.line.must_equal 3 }
       end
 
-      it "must work with full command name too" do
-        enter ->{"condition #{Byebug.breakpoints.first.id} b == 5"}, "cont"
+      it 'must work with full command name too' do
+        enter ->{ "condition #{Byebug.breakpoints.first.id} b == 5" }, 'cont'
         debug_file('conditions') { state.line.must_equal 3 }
       end
     end
 
-    describe "unsucessfully" do
-      before { enter "break 4" }
+    describe 'unsucessfully' do
+      before { enter 'break 4' }
 
-      it "must not stop at the breakpoint if condition is false" do
-        enter ->{"cond #{Byebug.breakpoints.first.id} b == 3"}, "cont"
+      it 'must not stop at the breakpoint if condition is false' do
+        enter ->{ "cond #{Byebug.breakpoints.first.id} b == 3" }, 'cont'
         debug_file('conditions') { state.line.must_equal 4 }
       end
-      it "must assign the expression to breakpoint in spite of incorrect syntax" do
-        enter ->{"cond #{Byebug.breakpoints.first.id} b =="}, "cont"
+
+      it 'must assign expression to breakpoint in spite of incorrect syntax' do
+        enter ->{ "cond #{Byebug.breakpoints.first.id} b =="}, 'cont'
         debug_file('conditions') {
-          Byebug.breakpoints.first.expr.must_equal "b ==" }
+          Byebug.breakpoints.first.expr.must_equal 'b ==' }
       end
-      it "must ignore the condition if when incorrect syntax" do
-        enter ->{"cond #{Byebug.breakpoints.first.id} b =="},  "cont"
+
+      it 'must ignore the condition if when incorrect syntax' do
+        enter ->{ "cond #{Byebug.breakpoints.first.id} b ==" },  'cont'
         debug_file('conditions') { state.line.must_equal 4 }
       end
     end
   end
 
-  describe "removing conditions" do
-    before { enter "break 3 if b == 3", "break 4",
-                   ->{"cond #{Byebug.breakpoints.first.id}"}, "cont" }
+  describe 'removing conditions' do
+    before { enter 'break 3 if b == 3', 'break 4',
+                   ->{"cond #{Byebug.breakpoints.first.id}"}, 'cont' }
 
-    it "must remove the condition from the breakpoint" do
+    it 'must remove the condition from the breakpoint' do
       debug_file('conditions') { Byebug.breakpoints.first.expr.must_be_nil }
     end
 
-    it "must not stop on the breakpoint" do
+    it 'must not stop on the breakpoint' do
       debug_file('conditions') { state.line.must_equal 3 }
     end
   end
 
-  describe "errors" do
-    it "must show error if there are no breakpoints" do
+  describe 'errors' do
+    it 'must show error if there are no breakpoints' do
       enter 'cond 1 true'
       debug_file('conditions')
-      check_output_includes "No breakpoints have been set."
+      check_output_includes 'No breakpoints have been set.'
     end
 
-    it "must not set breakpoint condition if breakpoint id is incorrect" do
+    it 'must not set breakpoint condition if breakpoint id is incorrect' do
       enter 'break 3', 'cond 8 b == 3', 'cont'
       debug_file('conditions') { state.line.must_equal 3 }
     end
   end
 
-  describe "Post Mortem" do
-    it "must be able to set conditions in post-mortem mode" do
-      skip("No post morten mode for now")
-      enter 'cont', 'break 12', ->{"cond #{breakpoint.id} true"}, 'cont'
-      debug_file("post_mortem") { state.line.must_equal 12 }
+  describe 'Post Mortem' do
+    it 'must be able to set conditions in post-mortem mode' do
+      enter 'cont', 'break 12', ->{ "cond #{Byebug.breakpoints.first.id} true" },
+            'cont'
+      debug_file('post_mortem') { state.line.must_equal 12 }
     end
   end
 

data/test/display_test.rb

@@ -5,13 +5,13 @@ describe 'Display Command' do
 
   it 'must show expressions' do
     enter 'break 3', 'cont', 'display d + 1'
-    debug_file('display')
+    debug_file 'display'
     check_output_includes '1: ', 'd + 1 = 5'
   end
 
   it 'must work with shortcut' do
     enter 'break 3', 'cont', 'disp d + 1'
-    debug_file('display')
+    debug_file 'display'
     check_output_includes '1: ', 'd + 1 = 5'
   end
 
@@ -24,7 +24,7 @@ describe 'Display Command' do
     enter 'break 3', 'cont', -> do
       Byebug.handler.display.concat([[true, 'abc'], [true, 'd']]); 'display'
     end
-    debug_file('display')
+    debug_file 'display'
     check_output_includes '1: ', 'abc = ', '2: ', 'd = 4'
   end
 
@@ -41,7 +41,7 @@ describe 'Display Command' do
         let(:confirm_response) { 'y' }
 
         it 'must ask about confirmation' do
-          debug_file('display')
+          debug_file 'display'
           check_output_includes \
             'Clear all expressions? (y/n)', interface.confirm_queue
         end
@@ -52,7 +52,7 @@ describe 'Display Command' do
         end
 
         it 'must not show any output' do
-          debug_file('display')
+          debug_file 'display'
           check_output_doesnt_include '1: ', 'abc = ', '2: ', 'd = 4'
         end
       end
@@ -66,7 +66,7 @@ describe 'Display Command' do
         end
 
         it 'must not show any output' do
-          debug_file('display')
+          debug_file 'display'
           check_output_includes '1: ', 'abc = ', '2: ', 'd = 4'
         end
       end
@@ -86,12 +86,12 @@ describe 'Display Command' do
       end
 
       it 'must display only the active position' do
-        debug_file('display')
+        debug_file 'display'
         check_output_includes '2: ', 'd = 4'
       end
 
       it 'must not display the disabled position' do
-        debug_file('display')
+        debug_file 'display'
         check_output_doesnt_include '1: ', 'abc'
       end
     end
@@ -105,14 +105,14 @@ describe 'Display Command' do
 
     it 'must show an error if no displays are set' do
       enter 'disable display 1'
-      debug_file('display')
+      debug_file 'display'
       check_output_includes \
         'No display expressions have been set.', interface.error_queue
     end
 
     it 'must show an error if there is no such display position' do
       enter 'display d', 'disable display 4'
-      debug_file('display')
+      debug_file 'display'
       check_output_includes \
         'Disable display argument "4" needs to be at most 1.'
     end
@@ -136,10 +136,11 @@ describe 'Display Command' do
   end
 
   describe 'Post Mortem' do
+    before { Byebug::Command.settings[:autoeval] = false }
+
     it 'must be able to set display expressions in post-mortem mode' do
-      skip('No post morten mode for now')
-      enter 'cont', 'display 2 + 2', 'cont'
-      debug_file('post_mortem')
+      enter 'cont', 'display 2 + 2'
+      debug_file 'post_mortem'
       check_output_includes '1:', '2 + 2 = 4'
     end
   end

data/test/edit_test.rb

@@ -1,55 +1,58 @@
 require_relative 'test_helper'
 
-describe "Edit Command" do
+describe 'Edit Command' do
   include TestDsl
 
-  it "must open an editor with current file and line" do
-    temporary_change_hash_value(ENV, "EDITOR", 'editr') do
-      Byebug::Edit.any_instance.expects(:system).with("editr +2 #{fullpath('edit')}")
+  it 'must open an editor with current file and line' do
+    temporary_change_hash_value(ENV, 'EDITOR', 'editr') do
+      Byebug::Edit.any_instance.expects(:system).
+                                with("editr +2 #{fullpath('edit')}")
       enter 'edit'
       debug_file 'edit'
     end
   end
 
-  it "must open a default editor with current file and line" do
-    temporary_change_hash_value(ENV, "EDITOR", nil) do
-      Byebug::Edit.any_instance.expects(:system).with("ex +2 #{fullpath('edit')}")
+  it 'must open a default editor with current file and line' do
+    temporary_change_hash_value(ENV, 'EDITOR', nil) do
+      Byebug::Edit.any_instance.expects(:system).
+                                with("ex +2 #{fullpath('edit')}")
       enter 'edit'
       debug_file 'edit'
     end
   end
 
-  it "must open an editor with specified file and line" do
-    temporary_change_hash_value(ENV, "EDITOR", 'editr') do
-      Byebug::Edit.any_instance.expects(:system).with("editr +3 #{fullpath('edit2')}")
+  it 'must open an editor with specified file and line' do
+    temporary_change_hash_value(ENV, 'EDITOR', 'editr') do
+      Byebug::Edit.any_instance.expects(:system).
+                                with("editr +3 #{fullpath('edit2')}")
       enter "edit #{fullpath('edit2')}:3"
       debug_file 'edit'
     end
   end
 
-  it "must show an error if there is no such line" do
+  it 'must show an error if there is no such line' do
     enter "edit #{fullpath('edit3')}:6"
     debug_file 'edit'
-    check_output_includes "File \"#{fullpath('edit3')}\" is not readable.", interface.error_queue
+    check_output_includes \
+      "File \"#{fullpath('edit3')}\" is not readable.", interface.error_queue
   end
 
-  it "must show an error if there is incorrect syntax" do
-    enter "edit blabla"
+  it 'must show an error if there is incorrect syntax' do
+    enter 'edit blabla'
     debug_file 'edit'
-    check_output_includes "Invalid file/line number specification: blabla", interface.error_queue
+    check_output_includes \
+      'Invalid file/line number specification: blabla', interface.error_queue
   end
 
 
-  describe "Post Mortem" do
-    # TODO: This test fails with "Segmentation fault". Probably need to fix it somehow, or forbid this
-    # command in the post mortem mode
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
-      #temporary_change_hash_value(ENV, "EDITOR", 'editr') do
-      #  Byebug::Edit.any_instance.expects(:system).with("editr +2 #{fullpath('edit')}")
-      #  enter 'cont', "edit #{fullpath('edit')}:2", 'cont'
-      #  debug_file "post_mortem"
-      #end
+  describe 'Post Mortem' do
+    it 'must work in post-mortem mode' do
+      temporary_change_hash_value(ENV, 'EDITOR', 'editr') do
+        Byebug::Edit.any_instance.expects(:system).
+                                  with("editr +2 #{fullpath('edit')}")
+        enter 'cont', "edit #{fullpath('edit')}:2", 'cont'
+        debug_file 'post_mortem'
+      end
     end
   end
 

data/test/eval_test.rb

@@ -53,7 +53,6 @@ describe 'Eval Command' do
     end
   end
 
-
   it 'must pretty print the expression result' do
     enter 'pp {a: \'3\' * 40, b: \'4\' * 30}'
     debug_file 'eval'
@@ -86,7 +85,6 @@ describe 'Eval Command' do
 
   describe 'Post Mortem' do
     it 'must work in post-mortem mode' do
-      skip('No post morten mode for now')
       enter 'cont', 'eval 2 + 2'
       debug_file 'post_mortem'
       check_output_includes '4'

data/test/finish_test.rb

@@ -37,12 +37,13 @@ describe 'Finish Command' do
   end
 
   describe 'Post Mortem' do
+    before { Byebug::Command.settings[:autoeval] = false }
+
     it 'must not work in post-mortem mode' do
-      skip('No post morten mode for now')
       enter 'cont', 'finish'
       debug_file 'post_mortem'
-      check_output_includes 'Unknown command: "finish".  Try "help".',
-                            interface.error_queue
+      check_output_includes \
+        'Unknown command: "finish".  Try "help".', interface.error_queue
     end
   end
 

data/test/frame_test.rb

@@ -3,6 +3,11 @@ require_relative 'test_helper'
 describe 'Frame Command' do
   include TestDsl
 
+  def after_setup
+    Byebug::Command.settings[:width] =
+      "--> #0  A.d(e#String) at #{fullpath('frame')}:16".size
+  end
+
   it 'must go up' do
     enter 'break 16', 'cont', 'up'
     debug_file('frame') { state.line.must_equal 12 }
@@ -35,7 +40,7 @@ describe 'Frame Command' do
 
   it 'must print current stack frame when without arguments' do
     enter 'break A.d', 'cont', 'up', 'frame'
-    debug_file('frame') { check_output_includes '#0', 'A.d(e#String)' }
+    debug_file('frame') { check_output_includes "#0  A.d(e#String) at #{fullpath('frame')}:15" }
   end
 
   it 'must set frame to the first one' do
@@ -78,17 +83,16 @@ describe 'Frame Command' do
     it 'must display current backtrace with full path = true' do
       enter 'set fullpath', 'break 16', 'cont', 'where'
       debug_file 'frame'
-      check_output_includes \
-        '-->', '#0', 'A.d(e#String)', "at #{fullpath('frame')}:16",
-               '#1', 'A.c'          , "at #{fullpath('frame')}:12"
+      check_output_includes "--> #0  A.d(e#String) at #{fullpath('frame')}:16",
+                            "    #1  A.c at #{fullpath('frame')}:12"
     end
 
     it 'must display current backtrace with full path = false' do
       enter 'set nofullpath', 'break 16', 'cont', 'where'
       debug_file 'frame'
       check_output_includes \
-        '-->', '#0', 'A.d(e#String)', "at #{short_path(fullpath('frame'))}:16",
-               '#1', 'A.c'          , "at #{short_path(fullpath('frame'))}:12"
+        "--> #0  A.d(e#String) at #{short_path(fullpath('frame'))}:16",
+        "    #1  A.c at #{short_path(fullpath('frame'))}:12"
     end
   end
 
@@ -96,21 +100,19 @@ describe 'Frame Command' do
     it 'displays current backtrace with callstyle "last"' do
       enter 'set callstyle last', 'break 16', 'cont', 'where'
       debug_file 'frame'
-      check_output_includes \
-        '-->', '#0', 'A.d(e#String)', "at #{fullpath('frame')}:16",
-               '#1', 'A.c'          , "at #{fullpath('frame')}:12",
-               '#2', 'A.b'          , "at #{fullpath('frame')}:8" ,
-               '#3', 'A.a'          , "at #{fullpath('frame')}:5"
+      check_output_includes "--> #0  A.d(e#String) at #{fullpath('frame')}:16",
+                            "    #1  A.c at #{fullpath('frame')}:12"          ,
+                            "    #2  A.b at #{fullpath('frame')}:8"           ,
+                            "    #3  A.a at #{fullpath('frame')}:5"
     end
 
     it 'displays current backtrace with callstyle "short"' do
       enter 'set callstyle short', 'break 16', 'cont', 'where'
       debug_file 'frame'
-      check_output_includes \
-        '-->', '#0', 'd(e)', "at #{fullpath('frame')}:16",
-               '#1', 'c'   , "at #{fullpath('frame')}:12",
-               '#2', 'b'   , "at #{fullpath('frame')}:8" ,
-               '#3', 'a'   , "at #{fullpath('frame')}:5"
+      check_output_includes "--> #0  d(e) at #{fullpath('frame')}:16",
+                            "    #1  c at #{fullpath('frame')}:12"   ,
+                            "    #2  b at #{fullpath('frame')}:8"    ,
+                            "    #3  a at #{fullpath('frame')}:5"
     end
 
     it 'displays current backtrace with callstyle "tracked"' do
@@ -132,13 +134,10 @@ describe 'Frame Command' do
   end
 
   describe 'Post Mortem' do
-    # TODO: This test fails with 'Segmentation fault'. Probably need to fix it
-    # somehow, or forbid this command in the post mortem mode. Seems like
-    # state.context.frame_file and state.context.frame_line cause that.
     it 'must work in post-mortem mode' do
-      skip('No post morten mode for now')
+      #skip 'TODO: This test fails with \'Segmentation fault\'.'
       enter 'cont', 'frame'
-      debug_file 'post_mortem'
+      debug_file('post_mortem') { state.line.must_equal 8 }
     end
   end
 

data/test/help_test.rb

@@ -1,49 +1,52 @@
 require_relative 'test_helper'
 
-describe "Help Command" do
+describe 'Help Command' do
   include TestDsl
   include Columnize
 
   let(:available_commands) do
-    Byebug::Command.commands.select(&:event).map(&:help_command).flatten.uniq.sort
+    Byebug::Command.commands.select(&:event).
+                             map(&:help_command).flatten.uniq.sort
   end
 
-  it "must show help how to use 'help'" do
+  it 'must show help how to use "help"' do
     temporary_change_hash_value(Byebug::HelpCommand.settings, :width, 50) do
       enter 'help'
-      debug_file('help')
-      check_output_includes(
-        "Type 'help <command-name>' for help on a specific command",
-        "Available commands:",
+      debug_file 'help'
+      check_output_includes \
+        'Type \'help <command-name>\' for help on a specific command',
+        'Available commands:',
         columnize(available_commands, 50)
-      )
     end
   end
 
-  it "must show help when use shortcut" do
+  it 'must show help when use shortcut' do
     enter 'h'
-    debug_file('help')
-    check_output_includes "Type 'help <command-name>' for help on a specific command"
+    debug_file 'help'
+    check_output_includes \
+      'Type \'help <command-name>\' for help on a specific command'
   end
 
-  it "must show an error if undefined command is specified" do
+  it 'must show an error if undefined command is specified' do
     enter 'help foobar'
-    debug_file('help')
-    check_output_includes 'Undefined command: "foobar".  Try "help".', interface.error_queue
+    debug_file 'help'
+    check_output_includes \
+      'Undefined command: "foobar".  Try "help".', interface.error_queue
   end
 
-  it "must show a command's help" do
+  it 'must show a command\'s help' do
     enter 'help break'
-    debug_file('help')
-    check_output_includes Byebug::AddBreakpoint.help(nil).split("\n").map { |l| l.gsub(/^ +/, '') }.join("\n")
+    debug_file 'help'
+    check_output_includes \
+      Byebug::AddBreakpoint.help(nil).split('\n').
+                            map { |l| l.gsub(/^ +/, '') }.join('\n')
   end
 
-  describe "Post Mortem" do
-    it "must work in post-mortem mode" do
-      skip("No post morten mode for now")
-      #enter 'cont', 'help'
-      #debug_file "post_mortem"
-      #check_output_includes "Available commands:"
+  describe 'Post Mortem' do
+    it 'must work in post-mortem mode' do
+      enter 'cont', 'help'
+      debug_file 'post_mortem'
+      check_output_includes 'Available commands:'
     end
   end