bugsnag 6.12.0 → 6.14.0

data/features/fixtures/sidekiq/app/Gemfile

@@ -3,4 +3,5 @@ source 'https://rubygems.org'
 gem 'bugsnag', path: '/bugsnag'
 gem 'sidekiq', ENV['SIDEKIQ_VERSION']
 gem 'timers', '~> 4.1.1'
-gem 'redis', '~> 3.3.5'
+gem 'redis', '~> 3.3.5'
+gem 'rake', '~> 12.3.0'

data/features/fixtures/sidekiq/app/Rakefile.rb

@@ -0,0 +1,14 @@
+namespace :sidekiq_tests do
+  task :handled_error do
+    run_sidekiq_test('./initializers/HandledError.rb')
+  end
+
+  task :unhandled_error do
+    run_sidekiq_test('./initializers/UnhandledError.rb')
+  end
+end
+
+def run_sidekiq_test(command)
+  system("ruby #{command}")
+  system("sidekiq -r ./app.rb")
+end

data/features/fixtures/sinatra1/Dockerfile

@@ -1,5 +1,5 @@
-ARG RUBY_VERSION
-FROM ruby:$RUBY_VERSION
+ARG RUBY_TEST_VERSION
+FROM ruby:$RUBY_TEST_VERSION
 
 WORKDIR /bugsnag
 COPY temp-bugsnag-lib ./

data/features/fixtures/sinatra2/Dockerfile

@@ -1,5 +1,5 @@
-ARG RUBY_VERSION
-FROM ruby:$RUBY_VERSION
+ARG RUBY_TEST_VERSION
+FROM ruby:$RUBY_TEST_VERSION
 
 WORKDIR /bugsnag
 COPY temp-bugsnag-lib ./

data/features/plain_features/add_tab.feature

@@ -1,58 +1,26 @@
 Feature: Plain add tab to metadata
 
-Background:
-  Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And I configure the bugsnag endpoint
-
 Scenario Outline: Metadata can be added to a report using add_tab
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I set environment variable "CALLBACK_INITIATOR" to "<initiator>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby report_modification/add_tab.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  Given I set environment variable "CALLBACK_INITIATOR" to "<initiator>"
+  When I run the service "plain-ruby" with the command "bundle exec ruby report_modification/add_tab.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the event "metaData.additional_metadata.foo" equals "foo"
   And the event "metaData.additional_metadata.bar.0" equals "b"
   And the event "metaData.additional_metadata.bar.1" equals "a"
   And the event "metaData.additional_metadata.bar.2" equals "r"
 
   Examples:
-  | ruby version | initiator               |
-  | 1.9.3        | handled_before_notify   |
-  | 1.9.3        | handled_block           |
-  | 1.9.3        | unhandled_before_notify |
-  | 2.0          | handled_before_notify   |
-  | 2.0          | handled_block           |
-  | 2.0          | unhandled_before_notify |
-  | 2.1          | handled_before_notify   |
-  | 2.1          | handled_block           |
-  | 2.1          | unhandled_before_notify |
-  | 2.2          | handled_before_notify   |
-  | 2.2          | handled_block           |
-  | 2.2          | unhandled_before_notify |
-  | 2.3          | handled_before_notify   |
-  | 2.3          | handled_block           |
-  | 2.3          | unhandled_before_notify |
-  | 2.4          | handled_before_notify   |
-  | 2.4          | handled_block           |
-  | 2.4          | unhandled_before_notify |
-  | 2.5          | handled_before_notify   |
-  | 2.5          | handled_block           |
-  | 2.5          | unhandled_before_notify |
+  | initiator               |
+  | handled_before_notify   |
+  | handled_block           |
+  | unhandled_before_notify |
 
 Scenario Outline: Metadata can be added to an existing tab using add_tab
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I set environment variable "CALLBACK_INITIATOR" to "<initiator>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby report_modification/add_tab_existing.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  Given I set environment variable "CALLBACK_INITIATOR" to "<initiator>"
+  When I run the service "plain-ruby" with the command "bundle exec ruby report_modification/add_tab_existing.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the event "metaData.additional_metadata.foo" equals "foo"
   And the event "metaData.additional_metadata.bar.0" equals "b"
   And the event "metaData.additional_metadata.bar.1" equals "a"
@@ -61,62 +29,21 @@ Scenario Outline: Metadata can be added to an existing tab using add_tab
   And the event "metaData.additional_metadata.foobar.then" equals "bar"
 
   Examples:
-  | ruby version | initiator               |
-  | 1.9.3        | handled_before_notify   |
-  | 1.9.3        | handled_block           |
-  | 1.9.3        | unhandled_before_notify |
-  | 2.0          | handled_before_notify   |
-  | 2.0          | handled_block           |
-  | 2.0          | unhandled_before_notify |
-  | 2.1          | handled_before_notify   |
-  | 2.1          | handled_block           |
-  | 2.1          | unhandled_before_notify |
-  | 2.2          | handled_before_notify   |
-  | 2.2          | handled_block           |
-  | 2.2          | unhandled_before_notify |
-  | 2.3          | handled_before_notify   |
-  | 2.3          | handled_block           |
-  | 2.3          | unhandled_before_notify |
-  | 2.4          | handled_before_notify   |
-  | 2.4          | handled_block           |
-  | 2.4          | unhandled_before_notify |
-  | 2.5          | handled_before_notify   |
-  | 2.5          | handled_block           |
-  | 2.5          | unhandled_before_notify |
+  | initiator               |
+  | handled_before_notify   |
+  | handled_block           |
+  | unhandled_before_notify |
 
 Scenario Outline: Metadata can be overwritten using add_tab
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I set environment variable "CALLBACK_INITIATOR" to "<initiator>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby report_modification/add_tab_override.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  Given I set environment variable "CALLBACK_INITIATOR" to "<initiator>"
+  When I run the service "plain-ruby" with the command "bundle exec ruby report_modification/add_tab_override.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the event "metaData.additional_metadata.foo" equals "foo"
   And the event "metaData.additional_metadata.bar" equals "bar"
 
   Examples:
-  | ruby version | initiator               |
-  | 1.9.3        | handled_before_notify   |
-  | 1.9.3        | handled_block           |
-  | 1.9.3        | unhandled_before_notify |
-  | 2.0          | handled_before_notify   |
-  | 2.0          | handled_block           |
-  | 2.0          | unhandled_before_notify |
-  | 2.1          | handled_before_notify   |
-  | 2.1          | handled_block           |
-  | 2.1          | unhandled_before_notify |
-  | 2.2          | handled_before_notify   |
-  | 2.2          | handled_block           |
-  | 2.2          | unhandled_before_notify |
-  | 2.3          | handled_before_notify   |
-  | 2.3          | handled_block           |
-  | 2.3          | unhandled_before_notify |
-  | 2.4          | handled_before_notify   |
-  | 2.4          | handled_block           |
-  | 2.4          | unhandled_before_notify |
-  | 2.5          | handled_before_notify   |
-  | 2.5          | handled_block           |
-  | 2.5          | unhandled_before_notify |
+  | initiator               |
+  | handled_before_notify   |
+  | handled_block           |
+  | unhandled_before_notify |

data/features/plain_features/app_type.feature

@@ -1,27 +1,8 @@
 Feature: App type configuration option
 
-Background:
-  Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And I configure the bugsnag endpoint
-
-Scenario Outline: The App type configuration option can be set
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I set environment variable "BUGSNAG_APP_TYPE" to "test_app"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby configuration/send_handled.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And the event "app.type" equals "test_app"
-
-  Examples:
-  | ruby version |
-  | 1.9.3        |
-  | 2.0          |
-  | 2.1          |
-  | 2.2          |
-  | 2.3          |
-  | 2.4          |
-  | 2.5          |
+Scenario: The App type configuration option can be set
+  Given I set environment variable "BUGSNAG_APP_TYPE" to "test_app"
+  When I run the service "plain-ruby" with the command "bundle exec ruby configuration/send_handled.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
+  And the event "app.type" equals "test_app"

data/features/plain_features/app_version.feature

@@ -1,27 +1,8 @@
 Feature: App version configuration option
 
-Background:
-  Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And I configure the bugsnag endpoint
-
-Scenario Outline: The App version configuration option can be set
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I set environment variable "BUGSNAG_APP_VERSION" to "9.9.8"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby configuration/send_handled.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And the event "app.version" equals "9.9.8"
-
-  Examples:
-  | ruby version |
-  | 1.9.3        |
-  | 2.0          |
-  | 2.1          |
-  | 2.2          |
-  | 2.3          |
-  | 2.4          |
-  | 2.5          |
+Scenario: The App version configuration option can be set
+  Given I set environment variable "BUGSNAG_APP_VERSION" to "9.9.8"
+  When I run the service "plain-ruby" with the command "bundle exec ruby configuration/send_handled.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
+  And the event "app.version" equals "9.9.8"

data/features/plain_features/auto_notify.feature

@@ -1,23 +1,7 @@
 Feature: Auto notify configuration option
 
-Background:
-  Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And I configure the bugsnag endpoint
-
-Scenario Outline: When Auto-notify is false notifications are not sent
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I set environment variable "BUGSNAG_AUTO_NOTIFY" to "false"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby configuration/send_unhandled.rb"
+Scenario: When Auto-notify is false notifications are not sent
+  Given I set environment variable "BUGSNAG_AUTO_NOTIFY" to "false"
+  When I run the service "plain-ruby" with the command "bundle exec ruby configuration/send_unhandled.rb"
   And I wait for 1 second
-  Then I should receive 0 requests
-
-  Examples:
-  | ruby version |
-  | 1.9.3        |
-  | 2.0          |
-  | 2.1          |
-  | 2.2          |
-  | 2.3          |
-  | 2.4          |
-  | 2.5          |
+  Then I should receive no requests

data/features/plain_features/delivery.feature

@@ -1,68 +1,20 @@
 Feature: delivery_method configuration option
 
-Background:
-  Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And I configure the bugsnag endpoint
-
-Scenario Outline: When the delivery_method is set to :synchronous
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby delivery/synchronous.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And the exception "errorClass" equals "RuntimeError"
+Scenario: When the delivery_method is set to :synchronous
+  When I run the service "plain-ruby" with the command "bundle exec ruby delivery/synchronous.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the event "metaData.config" matches the JSON fixture in "features/fixtures/plain/json/delivery_synchronous.json"
 
-  Examples:
-  | ruby version |
-  | 1.9.3        |
-  | 2.0          |
-  | 2.1          |
-  | 2.2          |
-  | 2.3          |
-  | 2.4          |
-  | 2.5          |
-
-Scenario Outline: When the delivery_method is set to :thread_queue
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby delivery/threadpool.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And the exception "errorClass" equals "RuntimeError"
+Scenario: When the delivery_method is set to :thread_queue
+  When I run the service "plain-ruby" with the command "bundle exec ruby delivery/threadpool.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the event "metaData.config" matches the JSON fixture in "features/fixtures/plain/json/delivery_threadpool.json"
 
-  Examples:
-  | ruby version |
-  | 1.9.3        |
-  | 2.0          |
-  | 2.1          |
-  | 2.2          |
-  | 2.3          |
-  | 2.4          |
-  | 2.5          |
-
-Scenario Outline: When the delivery_method is set to :thread_queue in a fork
-  Given I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby delivery/fork_threadpool.rb"
-  And I wait for 1 second
-  Then I should receive 2 requests
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+Scenario: When the delivery_method is set to :thread_queue in a fork
+  When I run the service "plain-ruby" with the command "bundle exec ruby delivery/fork_threadpool.rb"
+  And I wait to receive 2 requests
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the exception "errorClass" equals "RuntimeError"
   And the event "metaData.config" matches the JSON fixture in "features/fixtures/plain/json/delivery_fork.json"
-
-  Examples:
-  | ruby version |
-  | 1.9.3        |
-  | 2.0          |
-  | 2.1          |
-  | 2.2          |
-  | 2.3          |
-  | 2.4          |
-  | 2.5          |

data/features/plain_features/exception_data.feature

@@ -1,120 +1,50 @@
 Feature: Plain exception data
 
-Background:
-  Given I set environment variable "BUGSNAG_API_KEY" to "a35a2a72bd230ac0aa0f52715bbdc6aa"
-  And I configure the bugsnag endpoint
-
 Scenario Outline: An error has built in meta-data
-  And I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_meta_data.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  When I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_meta_data.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the exception "errorClass" equals "CustomError"
   And the event "metaData.exception.exception_type" equals "FATAL"
   And the event "metaData.exception.exception_base" equals "RuntimeError"
 
   Examples:
-  | ruby version | state     |
-  | 1.9.3        | unhandled |
-  | 1.9.3        | handled   |
-  | 2.0          | unhandled |
-  | 2.0          | handled   |
-  | 2.1          | unhandled |
-  | 2.1          | handled   |
-  | 2.2          | unhandled |
-  | 2.2          | handled   |
-  | 2.3          | unhandled |
-  | 2.3          | handled   |
-  | 2.4          | unhandled |
-  | 2.4          | handled   |
-  | 2.5          | unhandled |
-  | 2.5          | handled   |
+  | state     |
+  | unhandled |
+  | handled   |
 
 Scenario Outline: An error has built in context
-  And I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_context.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  When I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_context.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the exception "errorClass" equals "CustomError"
   And the event "context" equals "IntegrationTests"
 
   Examples:
-  | ruby version | state     |
-  | 1.9.3        | unhandled |
-  | 1.9.3        | handled   |
-  | 2.0          | unhandled |
-  | 2.0          | handled   |
-  | 2.1          | unhandled |
-  | 2.1          | handled   |
-  | 2.2          | unhandled |
-  | 2.2          | handled   |
-  | 2.3          | unhandled |
-  | 2.3          | handled   |
-  | 2.4          | unhandled |
-  | 2.4          | handled   |
-  | 2.5          | unhandled |
-  | 2.5          | handled   |
+  | state     |
+  | unhandled |
+  | handled   |
 
 Scenario Outline: An error has built in grouping hash
-  And I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_hash.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  When I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_hash.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the exception "errorClass" equals "CustomError"
   And the event "groupingHash" equals "ABCDE12345"
 
   Examples:
-  | ruby version | state     |
-  | 1.9.3        | unhandled |
-  | 1.9.3        | handled   |
-  | 2.0          | unhandled |
-  | 2.0          | handled   |
-  | 2.1          | unhandled |
-  | 2.1          | handled   |
-  | 2.2          | unhandled |
-  | 2.2          | handled   |
-  | 2.3          | unhandled |
-  | 2.3          | handled   |
-  | 2.4          | unhandled |
-  | 2.4          | handled   |
-  | 2.5          | unhandled |
-  | 2.5          | handled   |
+  | state     |
+  | unhandled |
+  | handled   |
 
 Scenario Outline: An error has built in user id
-  And I set environment variable "RUBY_VERSION" to "<ruby version>"
-  And I have built the service "plain-ruby"
-  And I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_user_id.rb"
-  And I wait for 1 second
-  Then I should receive a request
-  And the request used the "Ruby Bugsnag Notifier" notifier
-  And the request used payload v4 headers
-  And the request contained the api key "a35a2a72bd230ac0aa0f52715bbdc6aa"
+  When I run the service "plain-ruby" with the command "bundle exec ruby exception_data/<state>_user_id.rb"
+  And I wait to receive a request
+  Then the request is valid for the error reporting API version "4.0" for the "Ruby Bugsnag Notifier"
   And the exception "errorClass" equals "CustomError"
   And the event "user.id" equals "000001"
 
   Examples:
-  | ruby version | state     |
-  | 1.9.3        | unhandled |
-  | 1.9.3        | handled   |
-  | 2.0          | unhandled |
-  | 2.0          | handled   |
-  | 2.1          | unhandled |
-  | 2.1          | handled   |
-  | 2.2          | unhandled |
-  | 2.2          | handled   |
-  | 2.3          | unhandled |
-  | 2.3          | handled   |
-  | 2.4          | unhandled |
-  | 2.4          | handled   |
-  | 2.5          | unhandled |
-  | 2.5          | handled   |
+  | state     |
+  | unhandled |
+  | handled   |