bugsnag 6.12.0 → 6.14.0

data/spec/spec_helper.rb

@@ -10,6 +10,7 @@ end
 
 require 'bugsnag'
 
+require 'tmpdir'
 require 'webmock/rspec'
 require 'rspec/expectations'
 require 'rspec/mocks'
@@ -43,12 +44,16 @@ end
 
 RSpec.configure do |config|
   config.order = "random"
+  config.example_status_persistence_file_path = "#{Dir.tmpdir}/rspec_status"
 
   config.before(:each) do
     WebMock.stub_request(:post, "https://notify.bugsnag.com/")
     WebMock.stub_request(:post, "https://sessions.bugsnag.com/")
 
     Bugsnag.instance_variable_set(:@configuration, Bugsnag::Configuration.new)
+    Bugsnag.instance_variable_set(:@session_tracker, Bugsnag::SessionTracker.new)
+    Bugsnag.instance_variable_set(:@cleaner, Bugsnag::Cleaner.new(Bugsnag.configuration))
+
     Bugsnag.configure do |bugsnag|
       bugsnag.api_key = "c9d60ae4c7e70c4b6c4ebd3e8056d2b8"
       bugsnag.release_stage = "production"
@@ -83,4 +88,4 @@ def have_sent_notification(&matcher)
       raise "no matcher provided to have_sent_notification (did you use { })"
     end
   end
-end
+end

data/spec/stacktrace_spec.rb

@@ -1,90 +1,197 @@
 require 'spec_helper'
 
 describe Bugsnag::Stacktrace do
-  it "includes code in the stack trace" do
-    begin
-      _a = 1
-      _b = 2
-      _c = 3
-      "Test".prepnd "T"
-      _d = 4
-      _e = 5
-      _f = 6
-    rescue Exception => e
-      Bugsnag.notify(e)
+  context "sending code" do
+    it "includes code in the stack trace" do
+      begin
+        _a = 1
+        _b = 2
+        _c = 3
+        "Test".prepnd "T"
+        _d = 4
+        _e = 5
+        _f = 6
+      rescue Exception => e
+        Bugsnag.notify(e)
+      end
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+        starting_line = __LINE__ - 13
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          (starting_line + 0).to_s => '        _a = 1',
+          (starting_line + 1).to_s => '        _b = 2',
+          (starting_line + 2).to_s => '        _c = 3',
+          (starting_line + 3).to_s => '        "Test".prepnd "T"',
+          (starting_line + 4).to_s => '        _d = 4',
+          (starting_line + 5).to_s => '        _e = 5',
+          (starting_line + 6).to_s => '        _f = 6'
+          })
+      }
+    end
+
+    it "allows you to disable sending code" do
+      Bugsnag.configuration.send_code = false
+
+      notify_test_exception
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+        expect(exception["stacktrace"][1]["code"]).to eq(nil)
+      }
     end
 
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-      starting_line = __LINE__ - 13
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        (starting_line + 0).to_s => '      _a = 1',
-        (starting_line + 1).to_s => '      _b = 2',
-        (starting_line + 2).to_s => '      _c = 3',
-        (starting_line + 3).to_s => '      "Test".prepnd "T"',
-        (starting_line + 4).to_s => '      _d = 4',
-        (starting_line + 5).to_s => '      _e = 5',
-        (starting_line + 6).to_s => '      _f = 6'
+    it 'should send the first 7 lines of the file for exceptions near the top' do
+      load 'spec/fixtures/crashes/start_of_file.rb' rescue Bugsnag.notify $!
+
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          "1" => "#",
+          "2" => "raise 'hell'",
+          "3" => "#",
+          "4" => "#",
+          "5" => "#",
+          "6" => "#",
+          "7" => "#"
         })
-    }
-  end
+      }
+    end
 
-  it "allows you to disable sending code" do
-    Bugsnag.configuration.send_code = false
+    it 'should send the last 7 lines of the file for exceptions near the bottom' do
+      load 'spec/fixtures/crashes/end_of_file.rb' rescue Bugsnag.notify $!
 
-    notify_test_exception
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
 
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-      expect(exception["stacktrace"][1]["code"]).to eq(nil)
-    }
-  end
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          "3" => "#",
+          "4" => "#",
+          "5" => "#",
+          "6" => "#",
+          "7" => "#",
+          "8" => "raise 'hell'",
+          "9" => "#"
+        })
+      }
+    end
+
+    it 'should send the last 7 lines of the file for exceptions near the bottom' do
+      load 'spec/fixtures/crashes/short_file.rb' rescue Bugsnag.notify $!
 
-  it 'should send the first 7 lines of the file for exceptions near the top' do
-    load 'spec/fixtures/crashes/start_of_file.rb' rescue Bugsnag.notify $!
-
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        "1" => "#",
-        "2" => "raise 'hell'",
-        "3" => "#",
-        "4" => "#",
-        "5" => "#",
-        "6" => "#",
-        "7" => "#"
-      })
-    }
+      expect(Bugsnag).to have_sent_notification{ |payload, headers|
+        exception = get_exception_from_payload(payload)
+
+        expect(exception["stacktrace"][0]["code"]).to eq({
+          "1" => "raise 'hell'"
+        })
+      }
+    end
   end
 
-  it 'should send the last 7 lines of the file for exceptions near the bottom' do
-    load 'spec/fixtures/crashes/end_of_file.rb' rescue Bugsnag.notify $!
-
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
-
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        "3" => "#",
-        "4" => "#",
-        "5" => "#",
-        "6" => "#",
-        "7" => "#",
-        "8" => "raise 'hell'",
-        "9" => "#"
-      })
-    }
+  context "file paths" do
+    it "leaves absolute paths alone" do
+      configuration = Bugsnag::Configuration.new
+      configuration.send_code = false
+
+      backtrace = [
+        "/foo/bar/app/models/user.rb:1:in `something'",
+        "/foo/bar/other_vendor/lib/dont.rb:2:in `to_s'",
+        "/foo/bar/vendor/lib/ignore_me.rb:3:in `to_s'",
+        "/foo/bar/.bundle/lib/ignore_me.rb:4:in `to_s'",
+      ]
+
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration).to_a
+
+      expect(stacktrace).to eq([
+        { file: "/foo/bar/app/models/user.rb", lineNumber: 1, method: "something" },
+        { file: "/foo/bar/other_vendor/lib/dont.rb", lineNumber: 2, method: "to_s" },
+        { file: "/foo/bar/vendor/lib/ignore_me.rb", lineNumber: 3, method: "to_s" },
+        { file: "/foo/bar/.bundle/lib/ignore_me.rb", lineNumber: 4, method: "to_s" },
+      ])
+    end
+
+    it "does not modify relative paths if they can't be resolved" do
+      configuration = Bugsnag::Configuration.new
+
+      backtrace = [
+        "./foo/bar/baz.rb:1:in `something'",
+        "../foo.rb:1:in `to_s'",
+        "../xyz.rb:1:in `to_s'",
+        "abc.rb:1:in `defg'",
+      ]
+
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration).to_a
+
+      expect(stacktrace).to eq([
+        { code: nil, file: "./foo/bar/baz.rb", lineNumber: 1, method: "something" },
+        { code: nil, file: "../foo.rb", lineNumber: 1, method: "to_s" },
+        { code: nil, file: "../xyz.rb", lineNumber: 1, method: "to_s" },
+        { code: nil, file: "abc.rb", lineNumber: 1, method: "defg" },
+      ])
+    end
+
+    it "resolves relative paths when the files exist" do
+      configuration = Bugsnag::Configuration.new
+      configuration.send_code = false
+
+      dir = File.dirname(__FILE__)
+
+      backtrace = [
+        "./spec/spec_helper.rb:1:in `something'",
+        "./lib/bugsnag/breadcrumbs/../configuration.rb:100:in `to_s'",
+        "lib/bugsnag.rb:20:in `notify'",
+        "#{dir}/../spec/stacktrace_spec.rb:5:in `something_else'",
+      ]
+
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration).to_a
+
+      expect(stacktrace).to eq([
+        { file: "#{dir}/spec_helper.rb", lineNumber: 1, method: "something" },
+        { file: "#{File.dirname(dir)}/lib/bugsnag/configuration.rb", lineNumber: 100, method: "to_s" },
+        { file: "#{File.dirname(dir)}/lib/bugsnag.rb", lineNumber: 20, method: "notify" },
+        { file: "#{dir}/stacktrace_spec.rb", lineNumber: 5, method: "something_else" },
+      ])
+    end
   end
 
-  it 'should send the last 7 lines of the file for exceptions near the bottom' do
-    load 'spec/fixtures/crashes/short_file.rb' rescue Bugsnag.notify $!
+  context "with configurable vendor_path" do
+    let(:configuration) do
+      configuration = Bugsnag::Configuration.new
+      configuration.project_root = "/foo/bar"
+      configuration
+    end
+
+    let(:backtrace) do
+      [
+        "/foo/bar/app/models/user.rb:1:in `something'",
+        "/foo/bar/other_vendor/lib/dont.rb:1:in `to_s'",
+        "/foo/bar/vendor/lib/ignore_me.rb:1:in `to_s'",
+        "/foo/bar/.bundle/lib/ignore_me.rb:1:in `to_s'",
+      ]
+    end
+
+    def out_project_trace(stacktrace)
+      stacktrace.to_a.map do |trace_line|
+        trace_line[:file] if !trace_line[:inProject]
+      end.compact
+    end
+
+    it "marks vendor/ and .bundle/ as out-project by default" do
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration)
 
-    expect(Bugsnag).to have_sent_notification{ |payload, headers|
-      exception = get_exception_from_payload(payload)
+      expect(out_project_trace(stacktrace)).to eq([
+        "vendor/lib/ignore_me.rb",
+        ".bundle/lib/ignore_me.rb",
+      ])
+    end
 
-      expect(exception["stacktrace"][0]["code"]).to eq({
-        "1" => "raise 'hell'"
-      })
-    }
+    it "allows vendor_path to be configured and filters out backtrace file paths" do
+      configuration.vendor_path = /other_vendor\//
+      stacktrace = Bugsnag::Stacktrace.new(backtrace, configuration)
+
+      expect(out_project_trace(stacktrace)).to eq(["other_vendor/lib/dont.rb"])
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 6.12.0
+  version: 6.14.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-29 00:00:00.000000000 Z
+date: 2020-07-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: concurrent-ruby
@@ -33,22 +33,27 @@ extra_rdoc_files:
 - README.md
 - CHANGELOG.md
 files:
+- ".buildkite/pipeline.yml"
 - ".github/PULL_REQUEST_TEMPLATE.md"
 - ".gitignore"
 - ".rdoc_options"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
+- TESTING.md
 - UPGRADING.md
 - VERSION
 - bugsnag.gemspec
+- docker-compose.yml
+- dockerfiles/Dockerfile.jruby-unit-tests
+- dockerfiles/Dockerfile.ruby-maze-runner
+- dockerfiles/Dockerfile.ruby-unit-tests
 - features/.gitignore
 - features/delayed_job.feature
 - features/fixtures/delayed_job/Dockerfile
@@ -127,6 +132,14 @@ files:
 - features/fixtures/delayed_job/app/test/test_helper.rb
 - features/fixtures/delayed_job/app/tmp/.keep
 - features/fixtures/docker-compose.yml
+- features/fixtures/expected_breadcrumbs/active_job.json
+- features/fixtures/expected_breadcrumbs/mongo_failed.json
+- features/fixtures/expected_breadcrumbs/mongo_filtered_request.json
+- features/fixtures/expected_breadcrumbs/mongo_filtered_result.json
+- features/fixtures/expected_breadcrumbs/mongo_success.json
+- features/fixtures/expected_breadcrumbs/request.json
+- features/fixtures/expected_breadcrumbs/sql_with_bindings.json
+- features/fixtures/expected_breadcrumbs/sql_without_bindings.json
 - features/fixtures/plain/.dockerignore
 - features/fixtures/plain/Dockerfile
 - features/fixtures/plain/app/Gemfile
@@ -173,9 +186,9 @@ files:
 - features/fixtures/plain/app/stack_frame_modification/initiators/unhandled_before_notify.rb
 - features/fixtures/plain/app/stack_frame_modification/mark_frames_in_project.rb
 - features/fixtures/plain/app/stack_frame_modification/remove_stack_frame.rb
-- features/fixtures/plain/app/unhandled/Interrupt.rb
 - features/fixtures/plain/app/unhandled/bad_syntax.rb
 - features/fixtures/plain/app/unhandled/custom_error.rb
+- features/fixtures/plain/app/unhandled/interrupt.rb
 - features/fixtures/plain/app/unhandled/load_error.rb
 - features/fixtures/plain/app/unhandled/local_jump_error.rb
 - features/fixtures/plain/app/unhandled/name_error.rb
@@ -450,6 +463,7 @@ files:
 - features/fixtures/rails6/app/app/controllers/handled_controller.rb
 - features/fixtures/rails6/app/app/controllers/ignore_classes_controller.rb
 - features/fixtures/rails6/app/app/controllers/metadata_filters_controller.rb
+- features/fixtures/rails6/app/app/controllers/mongo_controller.rb
 - features/fixtures/rails6/app/app/controllers/project_root_controller.rb
 - features/fixtures/rails6/app/app/controllers/release_stage_controller.rb
 - features/fixtures/rails6/app/app/controllers/send_code_controller.rb
@@ -465,6 +479,7 @@ files:
 - features/fixtures/rails6/app/app/mailers/application_mailer.rb
 - features/fixtures/rails6/app/app/models/application_record.rb
 - features/fixtures/rails6/app/app/models/concerns/.keep
+- features/fixtures/rails6/app/app/models/mongo_model.rb
 - features/fixtures/rails6/app/app/models/user.rb
 - features/fixtures/rails6/app/app/views/layouts/application.html.erb
 - features/fixtures/rails6/app/app/views/layouts/mailer.html.erb
@@ -492,6 +507,7 @@ files:
 - features/fixtures/rails6/app/config/initializers/mime_types.rb
 - features/fixtures/rails6/app/config/initializers/wrap_parameters.rb
 - features/fixtures/rails6/app/config/locales/en.yml
+- features/fixtures/rails6/app/config/mongoid.yml
 - features/fixtures/rails6/app/config/puma.rb
 - features/fixtures/rails6/app/config/routes.rb
 - features/fixtures/rails6/app/config/secrets.yml
@@ -540,6 +556,7 @@ files:
 - features/fixtures/sidekiq/.dockerignore
 - features/fixtures/sidekiq/Dockerfile
 - features/fixtures/sidekiq/app/Gemfile
+- features/fixtures/sidekiq/app/Rakefile.rb
 - features/fixtures/sidekiq/app/app.rb
 - features/fixtures/sidekiq/app/initializers/HandledError.rb
 - features/fixtures/sidekiq/app/initializers/UnhandledError.rb
@@ -556,7 +573,6 @@ files:
 - features/fixtures/sinatra2/Gemfile
 - features/fixtures/sinatra2/app.rb
 - features/plain_features/add_tab.feature
-- features/plain_features/api_key.feature
 - features/plain_features/app_type.feature
 - features/plain_features/app_version.feature
 - features/plain_features/auto_notify.feature
@@ -623,6 +639,7 @@ files:
 - lib/bugsnag/middleware/classify_error.rb
 - lib/bugsnag/middleware/clearance_user.rb
 - lib/bugsnag/middleware/delayed_job.rb
+- lib/bugsnag/middleware/discard_error_class.rb
 - lib/bugsnag/middleware/exception_meta_data.rb
 - lib/bugsnag/middleware/ignore_error_class.rb
 - lib/bugsnag/middleware/mailman.rb
@@ -706,8 +723,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6.2
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com

data/.travis.yml

@@ -1,117 +0,0 @@
-sudo: false
-language: ruby
-
-before_install:
-- gem update --system 2.6.14
-- gem --version
-- gem install bundler -v $BUNDLE_VERSION
-- bundle _${BUNDLE_VERSION}_ --version
-
-install:
-- bundle _${BUNDLE_VERSION}_ install --with "$GEMSETS" --binstubs
-
-script:
-- bundle exec ./bin/rake spec
-
-jobs:
-  include:
-  - stage: test
-    env:
-    - BUNDLE_VERSION=1.16.1
-    - GEMSETS=test
-    rvm: jruby-19mode
-  - stage: test
-    rvm: 1.9.3
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS=test
-  - stage: test
-    rvm: 2.0
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS=test
-  - stage: test
-    rvm: 2.1
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS=test
-  - stage: test
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS="test sidekiq"
-    rvm: 2.2
-  - stage: test
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS="test sidekiq"
-    rvm: 2.3
-  - stage: test
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS="test sidekiq"
-    rvm: 2.4
-  - stage: test
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS="test sidekiq coverage"
-    rvm: 2.5
-  - stage: test
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS="test rubocop"
-    rvm: 2.5
-    script: bundle exec ./bin/rubocop lib/
-  # - stage: test
-  #   addons:
-  #     apt:
-  #       packages:
-  #       - docker-ce
-  #   sudo: required
-  #   sevices:
-  #   - docker
-  #   env:
-  #   - BUNDLE_VERSION=1.12.0
-  #   - GEMSETS="test maze"
-  #   rmv: 2.4.1
-  #   script: bundle exec bugsnag-maze-runner -c features/plain_features
-  # - stage: test
-  #   addons:
-  #     apt:
-  #       packages:
-  #       - docker-ce
-  #   sudo: required
-  #   sevices:
-  #   - docker
-  #   env:
-  #   - BUNDLE_VERSION=1.12.0
-  #   - GEMSETS="test maze"
-  #   rmv: 2.4.1
-  #   script: bundle exec bugsnag-maze-runner -c features/sidekiq.feature
-  # - stage: test
-  #   addons:
-  #     apt:
-  #       packages:
-  #       - docker-ce
-  #   sudo: required
-  #   sevices:
-  #   - docker
-  #   env:
-  #   - BUNDLE_VERSION=1.12.0
-  #   - GEMSETS="test maze"
-  #   - MAX_MAZE_CONNECT_ATTEMPTS=20
-  #   rmv: 2.4.1
-  #   script: bundle exec bugsnag-maze-runner -c features/rails_features
-  - stage: deploy
-    env:
-    - BUNDLE_VERSION=1.12.0
-    - GEMSETS="test doc"
-    rvm: 2.4.1
-    script: bundle exec rake rdoc
-    if: tag =~ ^v[1-9]
-    deploy:
-      provider: pages
-      local_dir: rdoc # only include the contents of the generated docs dir
-      skip_cleanup: true
-      github_token: $GITHUB_TOKEN # set in travis-ci dashboard
-      on:
-        tags: true # only deploy when tag is applied to commit