brut 0.8.0 → 0.9.1

data/brut-js/src/ConfirmSubmit.js

@@ -2,14 +2,21 @@ import BaseCustomElement from "./BaseCustomElement"
 import RichString from "./RichString"
 import ConfirmationDialog from "./ConfirmationDialog"
 
-/** Confirms form submissions with the user before allowing the form to be submitted. This can be applied per submit
- * button and only affects the behavior of `button` or `input type=submit`, and *only* if no other click handler
- * has been put onto those buttons.  Note that this does not affect links (`a` elements).
+/** Confirms form submissions with the user before allowing the form to be submitted. This is applied
+ * to buttons, not forms, to allow for finer control over the behavior.
  *
- * This can ask for confirmation with {@link external:Window#confirm} or a
- * `brut-confirmation-dialog`. What it will use depends on several factors, all of which
- * are geared toward doing the right thing. Note that setting `show-warnings` will elucidate the reasons
- * this component does what it does.
+ * * This only works for `button` or `input type=submit`
+ * * The elements must have a form, either by being inside a form or having
+ *   a `form` attribute.
+ * * If the form is not valid, it will not show the confirmation dialog.
+ *
+ *
+ * By default, this will use {@link external:Window#confirm}.  if "OK" is pressed,
+ * the button click goes through and the form would be submitted. If "Cancel" is pressed,
+ * the event is prevented.
+ *
+ * If there is a `brut-confirmation-dialog` on the page, this component can use that, possibly
+ * with help from the `dialog` attribute as followed:
  *
  * * If `dialog` is set:
  *   - If that id is on a `<brut-confirmation-dialog>` that is used.
@@ -18,6 +25,9 @@ import ConfirmationDialog from "./ConfirmationDialog"
  *   - If there is exactly one `<brut-confirmation-dialog>` on the page, this is used.
  *   - If there is more than one, or no `<brut-confirmation-dialog>`s, `window.confirm` is used.
  *
+ * If the wrong dialog or notification method is happening, set `show-warnings` on the element, and it will
+ * print out why it's doing what it's doing.
+ *
  * @see ConfirmationDialog
  *
  * @property {string} message - the message to show that asks for confirmation. It should be written such that
@@ -60,6 +70,17 @@ class ConfirmSubmit extends BaseCustomElement {
         this.logger.warn("No message provided, so cannot confirm")
         return
       }
+      const form = event.currentTarget.form
+
+      if (!form) {
+        this.logger.warn("Element was not part of a form, so cannot confirm submission")
+        return
+      }
+
+      if (!form.checkValidity()) {
+        return
+      }
+
       const dialog = this.#findDialog()
       if (dialog) {
         event.preventDefault()

data/brut.gemspec

@@ -1,5 +1,7 @@
 lib = File.expand_path("../lib", __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
+if !$LOAD_PATH.include?(lib)
+  $LOAD_PATH.unshift(lib)
+end
 require "brut/version"
 
 Gem::Specification.new do |spec|
@@ -10,7 +12,7 @@ Gem::Specification.new do |spec|
 
   spec.summary       = %q{Web Framework Built around Ruby, Web Standards, Simplicity, and Object-Orientation}
   spec.description   = %q{An opinionated web framework build on web standards}
-  spec.homepage      = "https://naildrivin5.com"
+  spec.homepage      = "https://brutrb.com"
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
@@ -18,8 +20,10 @@ Gem::Specification.new do |spec|
     spec.metadata["allowed_push_host"] = "https://rubygems.org"
 
     spec.metadata["homepage_uri"] = spec.homepage
-    spec.metadata["source_code_uri"] = "https://naildrivin5.com"
-    spec.metadata["changelog_uri"] = "https://naildrivin5.com"
+    spec.metadata["source_code_uri"] = "https://github.com/thirdtank/brut"
+    spec.metadata["changelog_uri"] = "https://github.com/thirdtank/brut/blob/main/CHANGELOG.md"
+    spec.metadata["documentation_uri"] = "https://brutrb.com/"
+    spec.metadata["rubygems_mfa_required"] = "true"
   else
     raise "RubyGems 2.0 or newer is required to protect against " \
       "public gem pushes."
@@ -34,32 +38,34 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "irb"
-  spec.add_runtime_dependency "ostruct" # squelch some warning - this is not used
-  spec.add_runtime_dependency "concurrent-ruby"
-  spec.add_runtime_dependency "i18n"
-  spec.add_runtime_dependency "nokogiri"
-  spec.add_runtime_dependency "phlex"
-  spec.add_runtime_dependency "prism"
-  spec.add_runtime_dependency "rack-protection"
-  spec.add_runtime_dependency "rackup"
-  spec.add_runtime_dependency "semantic_logger"
-  spec.add_runtime_dependency "sequel"
-  spec.add_runtime_dependency "sinatra"
-  spec.add_runtime_dependency "tzinfo"
-  spec.add_runtime_dependency "tzinfo-data"
-  spec.add_runtime_dependency "zeitwerk"
-  spec.add_runtime_dependency "opentelemetry-sdk"
-  spec.add_runtime_dependency "opentelemetry-exporter-otlp"
+  spec.add_dependency "irb"
+  spec.add_dependency "ostruct" # squelch some warning - this is not used
+  spec.add_dependency "concurrent-ruby"
+  spec.add_dependency "i18n"
+  spec.add_dependency "nokogiri"
+  spec.add_dependency "phlex"
+  spec.add_dependency "prism"
+  spec.add_dependency "rack-protection"
+  spec.add_dependency "rackup"
+  spec.add_dependency "semantic_logger"
+  spec.add_dependency "sequel"
+  spec.add_dependency "sinatra"
+  spec.add_dependency "tzinfo"
+  spec.add_dependency "tzinfo-data"
+  spec.add_dependency "zeitwerk"
+  spec.add_dependency "opentelemetry-sdk"
+  spec.add_dependency "opentelemetry-exporter-otlp"
 
   spec.add_development_dependency "activesupport"
-  spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "yard"
-  spec.add_development_dependency "rdiscount"
-  spec.add_development_dependency "rdoc"
   spec.add_development_dependency "dotenv"
   spec.add_development_dependency "factory_bot"
   spec.add_development_dependency "faker"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "rdiscount"
+  spec.add_development_dependency "rdoc"
+  spec.add_development_dependency "rubocop"
+  spec.add_development_dependency "rubocop-disable_syntax"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "yard"
 end

data/brutrb.com/.vitepress/config.mjs

@@ -6,6 +6,9 @@ import jsdocLinker from './plugins/jsdocLinker'
 export default defineConfig({
   title: "Brut RB",
   description: "Documentation for the Brut.RB web framework.",
+  ignoreDeadLinks: [
+    /^https?:\/\/localhost/,
+  ],
   head: [
     ["link", { rel: "icon", href: "/favicon.ico" }],
     [

data/brutrb.com/database-schema.md

@@ -142,7 +142,7 @@ unique keys is trivial, so Brut provides a way to do that.
 > A **key** simply uniquely identifies a row or is a unique constraint on a table.
 > Tables have only one primary key, but potentially many keys. Brut uses
 > *synthetic* (sometimes called *surrogate*) keys as primary keys.  This means
-> they have no business meaning and can be safely used for foreighn keys
+> they have no business meaning and can be safely used for foreign keys
 > and other cases without conflating them with domain concepts.
 
 

data/brutrb.com/recipes/migrations.md

@@ -66,7 +66,7 @@ bin/db migrate
 > [!IMPORTANT]
 > This only applied migrations to the dev database.  `bin/ci` and `bin/test e2e`
 > will apply them to the test database, but you may need to do it yourself via
-> `bin/db migration -e test`
+> `bin/db migrate -e test`
 
 > [!NOTE]
 > There is no down migration. If you need to change and re-apply this before