browse-everything 1.0.0.rc1 → 1.1.0

data/spec/javascripts/karma_spec.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+require 'open3'
+
+# Run karma and parse the output for failures.
+# The spec will fail if any karma test fails.
+describe 'Karma' do
+  let(:runner)  { Open3.capture3('karma', 'start') }
+  let(:output)  { runner[0] + runner[1] }
+  let(:status)  { runner[2].exitstatus }
+
+  it 'expects all karma tests to pass' do
+    $stderr.puts output unless status == 0
+    expect(status).to eq(0)
+  end
+end

data/spec/lib/browse_everything/browser_spec.rb

@@ -4,7 +4,7 @@ include BrowserConfigHelper
 
 describe BrowseEverything::Browser do
   let(:file_config) do
-    "file_system:\n  home: '/file/config/home'\ndropbox:\n  client_id: 'DropboxId'\n  client_secret: 'DropboxClientSecret'"
+    "file_system:\n  home: '/file/config/home'\ndropbox:\n  client_id: 'DropboxId'\n  client_secret: 'DropboxClientSecret'\n  download_directory: 'tmp/'"
   end
 
   let(:global_config) do
@@ -14,7 +14,8 @@ describe BrowseEverything::Browser do
       },
       dropbox: {
         client_id: 'DropboxId',
-        client_secret: 'DropboxClientSecret'
+        client_secret: 'DropboxClientSecret',
+        download_directory: 'tmp/'
       }
     }
   end
@@ -26,7 +27,8 @@ describe BrowseEverything::Browser do
       },
       dropbox: {
         client_id: 'DropboxId',
-        client_secret: 'DropboxClientSecret'
+        client_secret: 'DropboxClientSecret',
+        download_directory: 'tmp/'
       },
       url_options: url_options
     }

data/spec/lib/browse_everything/driver/dropbox_spec.rb

@@ -8,7 +8,8 @@ describe BrowseEverything::Driver::Dropbox do
   let(:provider_yml) do
     {
       client_id: 'client-id',
-      client_secret: 'client-secret'
+      client_secret: 'client-secret',
+      download_directory: 'spec/fixtures/'
     }
   end
   let(:oauth_response_body) do
@@ -63,6 +64,10 @@ describe BrowseEverything::Driver::Dropbox do
 
     before { driver.connect({ code: 'code' }, {}, connector_response_url_options) }
 
+    it 'accesses the download directory' do
+      expect(driver.config).to include('download_directory' => 'spec/fixtures/')
+    end
+
     describe '#auth_link' do
       subject { driver.auth_link(connector_response_url_options) }
 
@@ -133,6 +138,20 @@ describe BrowseEverything::Driver::Dropbox do
           expect(downloaded_file.read).not_to be_empty
         end
       end
+
+      context 'when the configuration does not specify a download directory' do
+        let(:provider_yml) do
+          {
+            client_id: 'client-id',
+            client_secret: 'client-secret'
+          }
+        end
+        let(:downloaded_file_path) { link_args.first }
+
+        it 'uses the "tmp" directory as the default path' do
+          expect(downloaded_file_path).to include '/tmp/Getting Started.pdf'
+        end
+      end
     end
   end
 end

data/spec/lib/browse_everything_spec.rb

@@ -72,6 +72,13 @@ describe BrowseEverything do
 
       it_behaves_like 'a configured BrowseEverything module'
     end
+
+    context 'without a YAML file' do
+      let(:config) { '' }
+      it 'raises a configuration error' do
+        expect { described_class.configure(:config).to raise_error(BrowseEverything::ConfigurationError, 'Missing browse_everything_providers.yml configuration file') }
+      end
+    end
   end
 
   context 'with an unsupported or invalid configuration' do

data/spec/spec_helper.rb

@@ -4,7 +4,7 @@ ENV['RAILS_ENV'] ||= 'test'
 require 'bundler/setup'
 
 def coverage_needed?
-  ENV['COVERAGE'] || ENV['TRAVIS']
+  ENV['COVERAGE'] || ENV['CI']
 end
 
 if coverage_needed?
@@ -36,6 +36,7 @@ require 'capybara/rspec'
 require 'rspec'
 require 'rspec/rails'
 require 'rspec/its'
+require 'webdrivers'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
@@ -45,6 +46,12 @@ require 'webmock/rspec'
 WebMock.disable_net_connect!(allow_localhost: true)
 
 RSpec.configure do |config|
+  config.before(:each, type: :feature) { WebMock.disable! }
+  config.after(:each, type: :feature) do
+    WebMock.enable!
+    WebMock.disable_net_connect!(allow_localhost: true)
+  end
+
   config.expect_with :rspec do |c|
     c.syntax = %i[should expect]
   end

data/spec/support/capybara.rb

@@ -4,11 +4,6 @@ require 'selenium-webdriver'
 
 # Temporary pin until chromedriver-helper patched to deal with change in chromedriver versioning
 # See https://github.com/flavorjones/chromedriver-helper/pull/63
-# @note In January 2018, TravisCI disabled Chrome sandboxing in its Linux
-#       container build environments to mitigate Meltdown/Spectre
-#       vulnerabilities, at which point Hyrax could no longer use the
-#       Capybara-provided :selenium_chrome_headless driver (which does not
-#       include the `--no-sandbox` argument).
 Capybara.register_driver :selenium_chrome_headless_sandboxless do |app|
   browser_options = ::Selenium::WebDriver::Chrome::Options.new
   browser_options.args << '--headless'

data/spec/test_app_templates/Gemfile.extra

@@ -1,2 +1,9 @@
 gem 'jquery-rails'
 gem 'puma-rails'
+
+if ENV['TEST_BOOTSTRAP'] == "3"
+  gem "bootstrap-sass"
+else
+  # bootstrap 4
+  gem "bootstrap"
+end

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -17,7 +17,13 @@ class TestAppGenerator < Rails::Generators::Base
     copy_file File.expand_path('app/assets/stylesheets/application.css', ENV['RAILS_ROOT']), 'app/assets/stylesheets/application.css.scss'
     remove_file 'app/assets/stylesheets/application.css'
     insert_into_file 'app/assets/stylesheets/application.css.scss', after: '*/' do
-      %(\n\n@import "browse_everything")
+      if ENV['TEST_BOOTSTRAP'] == "3"
+        # bootstrap 3 from bootstrap-sass gem
+        %(\n\n@import "bootstrap-sprockets";\n@import "bootstrap";\n@import "browse_everything/browse_everything_bootstrap3";)
+      else
+        # bootstrap4 from bootstrap gem
+        %(\n\n@import "bootstrap";\n@import "browse_everything/browse_everything_bootstrap4";)
+      end
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.1.0
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-06 00:00:00.000000000 Z
+date: 2020-10-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -43,20 +43,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bootstrap-sass
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.2'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.2'
 - !ruby/object:Gem::Dependency
   name: dropbox_api
   requirement: !ruby/object:Gem::Requirement
@@ -71,20 +57,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.1.10
-- !ruby/object:Gem::Dependency
-  name: font-awesome-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: google-api-client
   requirement: !ruby/object:Gem::Requirement
@@ -103,30 +75,42 @@ dependencies:
   name: google_drive
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '2.1'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: googleauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.6
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 0.6.6
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
@@ -134,6 +118,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.2'
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -141,22 +128,11 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '4.2'
-- !ruby/object:Gem::Dependency
-  name: ruby-box
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
-  name: sass-rails
+  name: ruby-box
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -184,19 +160,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0.8'
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: sprockets
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '3.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '3.7'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement
@@ -229,14 +205,14 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.3'
 - !ruby/object:Gem::Dependency
@@ -253,20 +229,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: chromedriver-helper
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -407,6 +369,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -463,6 +439,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: webdrivers
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -489,12 +479,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".engine_cart.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
-- ".travis.yml"
 - CODE_OF_CONDUCT.md
 - CONTRIBUTING.md
 - Gemfile
@@ -504,13 +494,14 @@ files:
 - Rakefile
 - SUPPORT.md
 - app/assets/javascripts/browse_everything.js
-- app/assets/javascripts/browse_everything/behavior.js.coffee
+- app/assets/javascripts/browse_everything/behavior.js
 - app/assets/stylesheets/browse_everything.scss
 - app/assets/stylesheets/browse_everything/_browse_everything.scss
+- app/assets/stylesheets/browse_everything/_browse_everything_bootstrap3.scss
+- app/assets/stylesheets/browse_everything/_browse_everything_bootstrap4.scss
 - app/assets/stylesheets/jquery.treetable.theme.browse.css
 - app/controllers/browse_everything_controller.rb
 - app/helpers/browse_everything_helper.rb
-- app/helpers/font_awesome_version_helper.rb
 - app/services/browse_everything_session.rb
 - app/services/browse_everything_session/provider_session.rb
 - app/services/browser_factory.rb
@@ -524,6 +515,7 @@ files:
 - browse-everything.gemspec
 - config/locales/en_browse_everything.yml
 - config/routes.rb
+- karma.conf.js
 - lib/browse-everything.rb
 - lib/browse_everything.rb
 - lib/browse_everything/auth/google/credentials.rb
@@ -540,10 +532,8 @@ files:
 - lib/browse_everything/file_entry.rb
 - lib/browse_everything/retriever.rb
 - lib/browse_everything/version.rb
-- lib/generators/browse_everything/assets_generator.rb
 - lib/generators/browse_everything/config_generator.rb
 - lib/generators/browse_everything/install_generator.rb
-- lib/generators/browse_everything/templates/browse_everything.scss
 - lib/generators/browse_everything/templates/browse_everything_providers.yml.example
 - spec/controllers/browse_everything_controller_spec.rb
 - spec/features/select_files_spec.rb
@@ -557,9 +547,8 @@ files:
 - spec/helper/browse_everything_controller_helper_spec.rb
 - spec/javascripts/behavior_spec.js
 - spec/javascripts/helpers/jasmine-jquery.js
-- spec/javascripts/jasmine_spec.rb
-- spec/javascripts/support/jasmine.yml
-- spec/javascripts/support/jasmine_helper.rb
+- spec/javascripts/helpers/jquery.js
+- spec/javascripts/karma_spec.rb
 - spec/lib/browse_everything/auth/google/credentials_spec.rb
 - spec/lib/browse_everything/browse_everything_helper_spec.rb
 - spec/lib/browse_everything/browser_spec.rb
@@ -604,12 +593,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14.1
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: AJAX/Rails engine file browser for cloud storage services
@@ -626,9 +614,8 @@ test_files:
 - spec/helper/browse_everything_controller_helper_spec.rb
 - spec/javascripts/behavior_spec.js
 - spec/javascripts/helpers/jasmine-jquery.js
-- spec/javascripts/jasmine_spec.rb
-- spec/javascripts/support/jasmine.yml
-- spec/javascripts/support/jasmine_helper.rb
+- spec/javascripts/helpers/jquery.js
+- spec/javascripts/karma_spec.rb
 - spec/lib/browse_everything/auth/google/credentials_spec.rb
 - spec/lib/browse_everything/browse_everything_helper_spec.rb
 - spec/lib/browse_everything/browser_spec.rb