browse-everything 1.0.0.rc1 → 1.1.0

data/app/assets/stylesheets/browse_everything/_browse_everything.scss

@@ -1,116 +1,2 @@
-@import "jquery.treetable";
-@import "jquery.treetable.theme.browse";
-
-@mixin ev-link {
-  cursor: pointer;
-  a {
-    color: inherit;
-    background-color: inherit;
-    text-decoration: none;
-  }
-}
-
-#browse-everything {
-  overflow-y: hidden;
-  position: fixed !important;
-  margin: 0 0 0 -37.5%;
-  left: 50%;
-  top: 10%;
-  background-color: initial;
-  width: 75%;
-
-  div {
-    background-color: white;
-  }
-
-  .modal-header {
-    padding: 8px;
-  }
-
-  .modal-body {
-    overflow: hidden;
-  }
-
-  .modal-footer {
-    margin: 0px;
-  }
-
-  .row {
-    margin: inherit;
-  }
-
-  .ev-files {
-    position: relative;
-    overflow-x: auto;
-    overflow-y: auto;
-
-    li {
-      overflow: hidden;
-      text-overflow: ellipsis;
-      .ev-file-name {
-        white-space: nowrap;
-      }
-      border-top: none;
-    }
-
-    &.detail {
-    }
-
-    &.list ul {
-      @include content-columns(3);
-    }
-  }
-
-  .ev-container li {
-    cursor: pointer;
-  }
-
-  .ev-body {
-    padding: 0;
-  }
-
-  .ev-providers {
-    padding: 4px;
-  }
-
-  .ev-files {
-    table {
-      width: 100%;
-      max-width: 100%;
-      tr {
-        width: 100%;
-        max-width: 100%;
-        td {
-          white-space: nowrap;
-          overflow: hidden;
-          text-overflow: ellipsis;
-        }
-      }
-    }
-  }
-
-  .ev-files {
-    height: 50vh;
-    li { @include ev-link; }
-  }
-
-  .ev-providers {
-    select { width: 30% }
-  }
-
-  .loading {
-    pointer-events: none;
-    opacity: 0.2;
-  }
-
-  .loading-progress {
-    position: absolute;
-    top: 8em;
-    left: 4em;
-  }
-
-  // Massively large text instead of something more artistic
-  .loading-text {
-    font-size: 4em;
-  }
-}
+@warn "`@import browse_everything/browse_everything` is deprecated, please `@import browse_everything_bootstrap3` instead";
+@import "browse_everything_bootstrap3";

data/app/assets/stylesheets/browse_everything/_browse_everything_bootstrap3.scss

@@ -0,0 +1,123 @@
+// It is important this file starts with underscore, so sprockets-sass won't try to compile
+// it independently, even though nothing explicit is directing it to.
+//
+// CSS for bootstrap 3, intended to be sass @import'ed into a context that has access to
+// bootstrap 3 mixins and variables.
+
+@import "jquery.treetable";
+@import "jquery.treetable.theme.browse";
+
+@mixin ev-link {
+  cursor: pointer;
+  a {
+    color: inherit;
+    background-color: inherit;
+    text-decoration: none;
+  }
+}
+
+#browse-everything {
+  overflow-y: hidden;
+  position: fixed !important;
+  margin: 0 0 0 -37.5%;
+  left: 50%;
+  top: 10%;
+  background-color: initial;
+  width: 75%;
+
+  div {
+    background-color: white;
+  }
+
+  .modal-header {
+    padding: 8px;
+  }
+
+  .modal-body {
+    overflow: hidden;
+  }
+
+  .modal-footer {
+    margin: 0px;
+  }
+
+  .row {
+    margin: inherit;
+  }
+
+  .ev-files {
+    position: relative;
+    overflow-x: auto;
+    overflow-y: auto;
+
+    li {
+      overflow: hidden;
+      text-overflow: ellipsis;
+      .ev-file-name {
+        white-space: nowrap;
+      }
+      border-top: none;
+    }
+
+    &.list ul {
+      @include content-columns(3);
+    }
+  }
+
+  .ev-container li {
+    cursor: pointer;
+  }
+
+  .ev-body {
+    padding: 0;
+  }
+
+  .ev-providers {
+    padding: 4px;
+  }
+
+  .ev-files {
+    table {
+      width: 100%;
+      max-width: 100%;
+      tr {
+        width: 100%;
+        max-width: 100%;
+        td {
+          white-space: nowrap;
+          overflow: hidden;
+          text-overflow: ellipsis;
+        }
+      }
+    }
+  }
+
+  .ev-files {
+    height: 50vh;
+    li {
+      @include ev-link;
+    }
+  }
+
+  .ev-providers {
+    select {
+      width: 30%
+    }
+  }
+
+  .loading {
+    pointer-events: none;
+    opacity: 0.2;
+  }
+
+  .loading-progress {
+    position: absolute;
+    top: 8em;
+    left: 4em;
+  }
+
+  // Massively large text instead of something more artistic
+  .loading-text {
+    font-size: 4em;
+  }
+}

data/app/assets/stylesheets/browse_everything/_browse_everything_bootstrap4.scss

@@ -0,0 +1,117 @@
+// It is important this file starts with underscore, so sprockets-sass won't try to compile
+// it independently, even though nothing explicit is directing it to.
+//
+// CSS for bootstrap 3, intended to be sass @import'ed into a context that has access to
+// bootstrap 3 mixins and variables.
+//
+// This updates the original bootstrap3 SCSS to work with bootstrap 4, but also improves/fixes
+// some display while we're at it.
+
+@import "jquery.treetable";
+@import "jquery.treetable.theme.browse";
+
+@mixin ev-link {
+  cursor: pointer;
+  a {
+    color: inherit;
+    background-color: inherit;
+    text-decoration: none;
+  }
+}
+
+#browse-everything {
+  div {
+    background-color: white;
+  }
+
+  .modal-dialog {
+    // possibly this is fixing a bootstrap bug?
+    border-radius: $modal-content-border-radius;
+  }
+
+  .modal-header {
+    padding: 8px;
+  }
+
+  .modal-footer {
+    justify-content: space-between;
+  }
+
+  .ev-files {
+    position: relative;
+    overflow-x: auto;
+    overflow-y: auto;
+
+    li {
+      overflow: hidden;
+      text-overflow: ellipsis;
+      .ev-file-name {
+        white-space: nowrap;
+      }
+      border-top: none;
+    }
+  }
+
+  .ev-container li {
+    cursor: pointer;
+  }
+
+  .ev-body {
+    padding: 0;
+  }
+
+  .row {
+    margin: inherit;
+  }
+
+  .ev-providers {
+    label {
+      font-size: $h5-font-size;
+      font-weight: $headings-font-weight;
+      line-height: $headings-line-height;
+      margin-bottom: 0;
+      @extend .mr-2;
+    }
+  }
+
+  .ev-files {
+    height: calc(90vh - 150px);
+    padding: 0;
+
+    li { @include ev-link; }
+
+    table {
+      margin: 0;
+      tr {
+        th {
+          padding-top: 0.5em;
+          padding-bottom: 0.5em;
+        }
+        td {
+          white-space: nowrap;
+          overflow: hidden;
+          text-overflow: ellipsis;
+        }
+      }
+    }
+  }
+
+  .loading {
+    pointer-events: none;
+    opacity: 0.2;
+  }
+
+  .loading-progress {
+    position: absolute;
+    top: 8em;
+    left: 4em;
+    &.hidden {
+      display: none;
+    }
+  }
+
+  // Massively large text instead of something more artistic
+  .loading-text {
+    font-size: 4em;
+  }
+}

data/app/views/browse_everything/_files.html.erb

@@ -9,6 +9,7 @@
       </tr>
     </thead>
     <% provider_contents.each_with_index do |file, index| %>
+      <% next if file.nil? %>
       <% path = browse_everything_engine.contents_path(provider_name, file.id) %>
       <% parent = params[:parent] %>
       <% if file.container? || provider.config[:max_upload_file_size].blank? %>

data/app/views/browse_everything/_providers.html.erb

@@ -1,6 +1,7 @@
 <form class="form-inline">
   <label target="provider-select">Source:</label>
-  <select class="form-control" id="provider-select">
+  <%# form-control class for bootstrap3, custom-select class for bootstrap4 %>
+  <select class="form-control custom-select" id="provider-select">
     <% browser.providers.each_pair do |key, provider| %>
       <option value="<%=browse_everything_engine.contents_path(key)%>">
         <%= provider.name %>

data/app/views/browse_everything/index.html.erb

@@ -1,4 +1,4 @@
-<div class="modal-dialog">
+<div class="modal-dialog modal-lg">
   <div class="modal-content">
     <div class="modal-header">
       <h4 class="sr-only" id="beModalLabel">Select a provider in the list to browse your files.</h4>
@@ -11,7 +11,8 @@
         <span class="loading-text">Loading...</span>
       </div>
       <div class="ev-browser row" aria-live="polite">
-        <div class="<%=fa3or4('fa3','fa4')%> col-xs-12 ev-files list">
+        <%# col-xs-12 is bootstrap3, col-12 is bootstrap4 %>
+        <div class="col-xs-12 col-12 ev-files list">
           <% if provider.present? %>
             <% if provider.authorized? %>
               <%= render :partial => 'files' %>

data/browse-everything.gemspec

@@ -21,23 +21,19 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'addressable', '~> 2.5'
   spec.add_dependency 'aws-sdk-s3'
-  spec.add_dependency 'bootstrap-sass', '~> 3.2'
   spec.add_dependency 'dropbox_api', '>= 0.1.10'
-  spec.add_dependency 'font-awesome-rails'
   spec.add_dependency 'google-api-client', '~> 0.23'
-  spec.add_dependency 'google_drive', '~> 2.1'
-  spec.add_dependency 'googleauth', '0.6.6'
-  spec.add_dependency 'rails', '>= 4.2'
+  spec.add_dependency 'google_drive', '>= 2.1', "< 4"
+  spec.add_dependency 'googleauth', '>= 0.6.6', '< 1.0'
+  spec.add_dependency 'rails', '>= 4.2', '< 6.0'
   spec.add_dependency 'ruby-box'
-  spec.add_dependency 'sass-rails'
   spec.add_dependency 'signet', '~> 0.8'
-  spec.add_dependency 'thor', '~> 0.19'
+  spec.add_dependency 'sprockets', '~> 3.7'
   spec.add_dependency 'typhoeus'
 
   spec.add_development_dependency 'bixby', '>= 1.0'
-  spec.add_development_dependency 'bundler', '~> 1.3'
+  spec.add_development_dependency 'bundler', '>= 1.3'
   spec.add_development_dependency 'capybara'
-  spec.add_development_dependency 'chromedriver-helper', '1.2.0'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'engine_cart', '~> 2.0'
   spec.add_development_dependency 'factory_bot_rails'
@@ -48,9 +44,11 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-its'
   spec.add_development_dependency 'rspec-rails'
+  spec.add_development_dependency 'rspec_junit_formatter'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'sqlite3'
+  spec.add_development_dependency 'webdrivers'
   spec.add_development_dependency 'webmock'
 end

data/karma.conf.js

@@ -0,0 +1,71 @@
+// Karma configuration
+// Generated on Mon Nov 19 2018 13:01:16 GMT-0600 (Central Standard Time)
+
+module.exports = function(config) {
+  config.set({
+
+    // base path that will be used to resolve all patterns (eg. files, exclude)
+    basePath: '',
+
+
+    // frameworks to use
+    // available frameworks: https://npmjs.org/browse/keyword/karma-adapter
+    frameworks: ['jasmine'],
+
+
+    // list of files / patterns to load in the browser
+    files: [
+      'spec/javascripts/helpers/jquery.js',
+      'app/assets/javascripts/**/*.js',
+      'spec/javascripts/behavior_spec.js'
+    ],
+
+
+    // list of files / patterns to exclude
+    exclude: [
+    ],
+
+
+    // preprocess matching files before serving them to the browser
+    // available preprocessors: https://npmjs.org/browse/keyword/karma-preprocessor
+    preprocessors: {
+    },
+
+
+    // test results reporter to use
+    // possible values: 'dots', 'progress'
+    // available reporters: https://npmjs.org/browse/keyword/karma-reporter
+    reporters: ['progress'],
+
+
+    // web server port
+    port: 9876,
+
+
+    // enable / disable colors in the output (reporters and logs)
+    colors: true,
+
+
+    // level of logging
+    // possible values: config.LOG_DISABLE || config.LOG_ERROR || config.LOG_WARN || config.LOG_INFO || config.LOG_DEBUG
+    logLevel: config.LOG_INFO,
+
+
+    // enable / disable watching file and executing tests whenever any file changes
+    autoWatch: true,
+
+
+    // start these browsers
+    // available browser launchers: https://npmjs.org/browse/keyword/karma-launcher
+    browsers: ['ChromeHeadless'],
+
+
+    // Continuous Integration mode
+    // if true, Karma captures browsers, runs the tests and exits
+    singleRun: true,
+
+    // Concurrency level
+    // how many browser should be started simultaneous
+    concurrency: Infinity
+  })
+}