brightbox-cli 3.3.0 → 4.1.0

data/spec/cassettes/brightbox_sql_snapshots/show/when_resource_exists/does_not_output_to_stderr.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: get
-    uri: http://api.brightbox.dev/1.0/database_snapshots/dbi-12345?account_id=acc-12345
+    uri: http://api.brightbox.localhost/1.0/database_snapshots/dbi-12345?account_id=acc-12345
     body:
       encoding: US-ASCII
       string: ''
@@ -46,7 +46,7 @@ http_interactions:
   recorded_at: Fri, 17 Jan 2014 10:45:59 GMT
 - request:
     method: post
-    uri: http://api.brightbox.dev/token
+    uri: http://api.brightbox.localhost/token
     body:
       encoding: UTF-8
       string: "{\"grant_type\":\"client_credentials\"}"

data/spec/commands/accounts/default_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox accounts" do
-
   describe "default" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(accounts default) }
+      let(:argv) { %w[accounts default] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/accounts/list_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox accounts" do
-
   describe "list" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "", vcr: true do
-      let(:argv) { %w(accounts list) }
+      let(:argv) { %w[accounts list] }
 
       it "does not error" do
         expect { output }.to_not raise_error
@@ -18,7 +17,7 @@ describe "brightbox accounts" do
     context "(when no tokens)", vcr: true do
       let(:password) { default_test_password }
 
-      let(:argv) { %w(accounts list) }
+      let(:argv) { %w[accounts list] }
 
       before do
         config_from_contents(USER_APP_CONFIG_CONTENTS)
@@ -37,7 +36,7 @@ describe "brightbox accounts" do
     context "(when no tokens and password incorrect)", vcr: true do
       let(:password) { "wrong" }
 
-      let(:argv) { %w(accounts list) }
+      let(:argv) { %w[accounts list] }
 
       before do
         config_from_contents(USER_APP_CONFIG_CONTENTS)
@@ -56,11 +55,11 @@ describe "brightbox accounts" do
     context "(when access token expired)", vcr: true do
       let(:password) { default_test_password }
 
-      let(:argv) { %w(accounts list) }
+      let(:argv) { %w[accounts list] }
 
       before do
         config = config_from_contents(USER_APP_CONFIG_CONTENTS)
-        #mock_password_entry(password)
+        # mock_password_entry(password)
 
         # Setup in the VCR recordings as the access token is expired
         cache_access_token(config, "08f204123bb2fc400521577445df9d1d212da42e")
@@ -75,7 +74,7 @@ describe "brightbox accounts" do
     context "(when both tokens expired)", vcr: true do
       let(:password) { default_test_password }
 
-      let(:argv) { %w(accounts list) }
+      let(:argv) { %w[accounts list] }
 
       before do
         config = config_from_contents(USER_APP_CONFIG_CONTENTS)
@@ -94,7 +93,7 @@ describe "brightbox accounts" do
     context "(when invalid tokens)", vcr: true do
       let(:password) { default_test_password }
 
-      let(:argv) { %w(accounts list) }
+      let(:argv) { %w[accounts list] }
 
       before do
         config = config_from_contents(USER_APP_CONFIG_CONTENTS)

data/spec/commands/accounts/reset_ftp_password_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox accounts" do
-
   describe "reset_ftp_password" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(accounts reset_ftp_password) }
+      let(:argv) { %w[accounts reset_ftp_password] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/accounts/show_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox accounts" do
-
   describe "show" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(accounts show) }
+      let(:argv) { %w[accounts show] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/cloudips/create_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "create" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(cloudips create) }
+      let(:argv) { %w[cloudips create] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/cloudips/destroy_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "destroy" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(cloudips destroy) }
+      let(:argv) { %w[cloudips destroy] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/cloudips/list_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "list" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(cloudips list) }
+      let(:argv) { %w[cloudips list] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/cloudips/map_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "map" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -15,7 +14,7 @@ describe "brightbox cloudips" do
     end
 
     context "when destination is a server ID", vcr: true do
-      let(:argv) { %w(cloudips map cip-12345 srv-12345) }
+      let(:argv) { %w[cloudips map cip-12345 srv-12345] }
       let(:target) { "int-12345" }
 
       it "passes the interface identifier to the API" do
@@ -26,7 +25,7 @@ describe "brightbox cloudips" do
 
     context "when destination is another value", vcr: true do
       let(:target) { "res-12345" }
-      let(:argv) { %w(cloudips map cip-12345 res-12345) }
+      let(:argv) { %w[cloudips map cip-12345 res-12345] }
 
       it "passes the identifier to the API" do
         expect_any_instance_of(Brightbox::CloudIP).to receive(:map).with(target)

data/spec/commands/cloudips/show_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "show" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(cloudips show) }
+      let(:argv) { %w[cloudips show] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/cloudips/unmap_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "unmap" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(cloudips unmap) }
+      let(:argv) { %w[cloudips unmap] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/cloudips/update_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe "brightbox cloudips" do
-
   describe "update" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -10,12 +9,12 @@ describe "brightbox cloudips" do
     before do
       config_from_contents(USER_APP_CONFIG_CONTENTS)
 
-      stub_request(:post, "http://api.brightbox.dev/token").
-        to_return(status: 200, body: JSON.dump(access_token: "ACCESS-TOKEN", refresh_token: "REFRESH-TOKEN"))
+      stub_request(:post, "http://api.brightbox.localhost/token")
+        .to_return(status: 200, body: JSON.dump(access_token: "ACCESS-TOKEN", refresh_token: "REFRESH-TOKEN"))
     end
 
     context "" do
-      let(:argv) { %w(cloudips update) }
+      let(:argv) { %w[cloudips update] }
 
       it "does not error" do
         expect { output }.to_not raise_error
@@ -39,12 +38,12 @@ describe "brightbox cloudips" do
         let(:expected_args) { ["cip-12345", { :name => new_name }] }
 
         before do
-          stub_request(:put, "http://api.brightbox.dev/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
             .with(:headers => { "Content-Type" => "application/json" },
                   :body => hash_including("name" => "New name"))
             .and_return(:status => 200, :body => json_response)
 
-          stub_request(:get, "http://api.brightbox.dev/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
             .with(:headers => { "Content-Type" => "application/json" })
             .and_return(:status => 200, :body => json_response)
         end
@@ -62,12 +61,12 @@ describe "brightbox cloudips" do
         let(:expected_args) { ["cip-12345", { :name => "" }] }
 
         before do
-          stub_request(:put, "http://api.brightbox.dev/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          stub_request(:put, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
             .with(:headers => { "Content-Type" => "application/json" },
                   :body => hash_including("name" => ""))
             .and_return(:status => 200, :body => json_response)
 
-          stub_request(:get, "http://api.brightbox.dev/1.0/cloud_ips/cip-12345?account_id=acc-12345")
+          stub_request(:get, "http://api.brightbox.localhost/1.0/cloud_ips/cip-12345?account_id=acc-12345")
             .with(:headers => { "Content-Type" => "application/json" })
             .and_return(:status => 200, :body => json_response)
         end

data/spec/commands/config/client_add_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe "brightbox config" do
-
   describe "client_add" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -9,12 +8,12 @@ describe "brightbox config" do
 
     let(:client_id) { "cli-12345" }
     let(:secret) { "qy6xxnvy4o0tgv5" }
-    let(:api_url) { "http://api.brightbox.dev" }
+    let(:api_url) { "http://api.brightbox.localhost" }
 
     let(:default_account) { "acc-12345" }
 
     context "" do
-      let(:argv) { %w(config client_add) }
+      let(:argv) { %w[config client_add] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/config/client_default_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox config" do
-
   describe "client_default" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(config client_default) }
+      let(:argv) { %w[config client_default] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/config/client_list_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox config" do
-
   describe "client_list" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(config client_list) }
+      let(:argv) { %w[config client_list] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/config/client_remove_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox config" do
-
   describe "client_remove" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(config client_remove) }
+      let(:argv) { %w[config client_remove] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/config/user_add_spec.rb

@@ -5,7 +5,6 @@ require "spec_helper"
 # send invalid credentials to the real API and be rejected.
 #
 describe "brightbox config" do
-
   describe "user_add" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
@@ -15,13 +14,13 @@ describe "brightbox config" do
     let(:client_id) { "app-12345" }
     let(:secret) { "mocbuipbiaa6k6c" }
     let(:password) { "N:B3e%7Cmh" }
-    let(:api_url) { "http://api.brightbox.dev" }
+    let(:api_url) { "http://api.brightbox.localhost" }
 
     let(:default_account) { "acc-12345" }
     let(:client_alias) { email }
 
     context "" do
-      let(:argv) { %w(config user_add) }
+      let(:argv) { %w[config user_add] }
 
       it "does not error" do
         expect { output }.to_not raise_error
@@ -32,7 +31,7 @@ describe "brightbox config" do
       let(:argv) { ["config", "user_add", email, client_id, secret] }
 
       before do
-        config_file = File.join(ENV["HOME"], ".brightbox", "config")
+        config_file = File.join(ENV.fetch("HOME", nil), ".brightbox", "config")
         FileUtils.rm_rf(config_file)
         expect(File.exist?(config_file)).to be false
         mock_password_entry(password)

data/spec/commands/firewall_policies/update_spec.rb

@@ -11,7 +11,7 @@ describe "Firewall policies" do
     let(:stderr) { output.stderr }
 
     context "when no identifier is given", vcr: true do
-      let(:argv) { %w(firewall-policies update) }
+      let(:argv) { %w[firewall-policies update] }
 
       it "prints error to STDERR" do
         expect(stderr).to include("ERROR: You must specify the firewall-policy-id to update")
@@ -19,7 +19,7 @@ describe "Firewall policies" do
     end
 
     context "when the policy does not exist", vcr: true do
-      let(:argv) { %w(firewall-policies update -n missing fwp-12345) }
+      let(:argv) { %w[firewall-policies update -n missing fwp-12345] }
 
       it "prints error to STDERR" do
         expect(stderr).to include("ERROR: Resource not found using supplied identifier")
@@ -33,7 +33,7 @@ describe "Firewall policies" do
 
       after do
         # FIXME: All specs are pending, why is this trying to run against nil?
-        @policy.destroy if @policy
+        @policy&.destroy
       end
 
       context "when new name is given", vcr: true do

data/spec/commands/groups/add_server_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "add_server" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups add_server) }
+      let(:argv) { %w[groups add_server] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/create_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "create" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups create) }
+      let(:argv) { %w[groups create] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/destroy_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "destroy" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups destroy) }
+      let(:argv) { %w[groups destroy] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/list_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "list" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups list) }
+      let(:argv) { %w[groups list] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/move_servers_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "move_servers" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups move_servers) }
+      let(:argv) { %w[groups move_servers] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/remove_servers_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "remove_servers" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups remove_servers) }
+      let(:argv) { %w[groups remove_servers] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/show_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "show" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups show) }
+      let(:argv) { %w[groups show] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/groups/update_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox groups" do
-
   describe "update" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(groups update) }
+      let(:argv) { %w[groups update] }
 
       it "does not error" do
         expect { output }.to_not raise_error

data/spec/commands/images/destroy_spec.rb

@@ -1,14 +1,13 @@
 require "spec_helper"
 
 describe "brightbox images" do
-
   describe "destroy" do
     let(:output) { FauxIO.new { Brightbox.run(argv) } }
     let(:stdout) { output.stdout }
     let(:stderr) { output.stderr }
 
     context "" do
-      let(:argv) { %w(images destroy) }
+      let(:argv) { %w[images destroy] }
 
       it "does not error" do
         expect { output }.to_not raise_error