brightbox-cli 3.3.0 → 4.1.0

data/lib/brightbox-cli/api.rb

@@ -4,12 +4,13 @@ module Brightbox
 
   class Api
     attr_reader :id
-    class ApiError < StandardError ; end
-    class NotFound < ApiError ; end
-    class Conflict < ApiError ; end
-    class InvalidRecord < ApiError ; end
-    class Forbidden < ApiError ; end
-    class InvalidArguments < ApiError ; end
+
+    class ApiError < StandardError; end
+    class NotFound < ApiError; end
+    class Conflict < ApiError; end
+    class InvalidRecord < ApiError; end
+    class Forbidden < ApiError; end
+    class InvalidArguments < ApiError; end
 
     @@connection_manager = nil
 
@@ -19,12 +20,8 @@ module Brightbox
     # @return [Fog::Brightbox::Compute::Real]
     #
     def self.conn
-      if @@connection_manager
-        @@connection_manager.fetch_connection(require_account?)
-      else
-        @@connection_manager = Brightbox::ConnectionManager.new(Brightbox.config.to_fog)
-        @@connection_manager.fetch_connection(require_account?)
-      end
+      @@connection_manager ||= Brightbox::ConnectionManager.new(Brightbox.config.to_fog)
+      @@connection_manager.fetch_connection(require_account?)
     end
 
     # Returns +true+ if instances of this class require account details to be
@@ -43,14 +40,14 @@ module Brightbox
       name.split("::").last
     end
 
-    def initialize(m = nil)
-      if m.is_a? String
-        @id = m
-      elsif m.respond_to?(:attributes) && m.respond_to?(:id)
-        @fog_model = m
-        @id = m.id
+    def initialize(model = nil)
+      if model.is_a? String
+        @id = model
+      elsif model.respond_to?(:attributes) && model.respond_to?(:id)
+        @fog_model = model
+        @id = model.id
       else
-        raise InvalidArguments, "Can't initialize #{self.class} with #{m.inspect}"
+        raise InvalidArguments, "Can't initialize #{self.class} with #{model.inspect}"
       end
       Brightbox.config.cache_id(@id) if Brightbox.config.respond_to?(:cache_id)
     end
@@ -99,6 +96,7 @@ module Brightbox
     def self.find(args = :all, options = {})
       raise InvalidArguments, "find(nil)" if args.nil?
       raise InvalidArguments, "find([])" if args.respond_to?(:empty?) && args.empty?
+
       options = { :order => :created_at }.merge(options)
 
       objects = nil
@@ -113,6 +111,7 @@ module Brightbox
         objects = args.map do |arg|
           o = cached_get(arg.to_s)
           raise NotFound, "Couldn't find '#{arg}'" if o.nil?
+
           o
         end
       else
@@ -141,21 +140,23 @@ module Brightbox
     def self.find_or_call(ids, &_block)
       objects = []
       ids.each do |id|
-        begin
-          objects << find(id)
-        rescue Api::NotFound
-          yield id
-        end
+        objects << find(id)
+      rescue Api::NotFound
+        yield id
       end
       objects
     end
 
-    def method_missing(m, *args)
-      if fog_model
-        fog_model.send(m, *args)
-      else
-        raise NoMethodError
-      end
+    def method_missing(method_name, *args)
+      raise NoMethodError unless fog_model
+
+      fog_model.send(method_name, *args)
+    end
+
+    def respond_to_missing?(method_name, _)
+      return false unless fog_model
+
+      fog_model.respond_to?(method_name)
     end
 
     def self.cached_get(id)
@@ -169,9 +170,10 @@ module Brightbox
       end
     end
 
-    def self.find_by_handle(h)
-      object = find(:all).find { |o| o.handle == h }
-      raise Api::NotFound, "Invalid #{klass_name} #{h}" if object.nil?
+    def self.find_by_handle(handle)
+      object = find(:all).find { |obj| obj.handle == handle }
+      raise Api::NotFound, "Invalid #{klass_name} #{handle}" if object.nil?
+
       object
     end
 
@@ -186,9 +188,9 @@ module Brightbox
     # Displays creation date in ISO 8601 Complete date format
     #
     def created_on
-      if fog_model.created_at
-        fog_model.created_at.strftime("%Y-%m-%d")
-      end
+      return unless fog_model.created_at
+
+      fog_model.created_at.strftime("%Y-%m-%d")
     end
   end
 end

data/lib/brightbox-cli/cloud_ips.rb

@@ -27,6 +27,7 @@ module Brightbox
       translators.split(",").map do |t|
         incoming, outgoing, protocol = t.split(":")
         raise "translator #{t} is invalid" if incoming.nil? || outgoing.nil? || protocol.nil?
+
         { :incoming => incoming, :outgoing => outgoing, :protocol => protocol }
       end
     end
@@ -44,21 +45,20 @@ module Brightbox
     end
 
     def mapped?
-      status == 'mapped'
+      status == "mapped"
     end
 
     def translators(raw_attributes)
-      if translators = (raw_attributes[:port_translators] || raw_attributes['port_translators'])
-        translators.map do |t|
-          [t['incoming'], t['outgoing'], t['protocol']].join(":")
-        end
-      else
-        nil
+      translators = (raw_attributes[:port_translators] || raw_attributes["port_translators"])
+      return unless translators
+
+      translators.map do |t|
+        [t["incoming"], t["outgoing"], t["protocol"]].join(":")
       end
     end
 
     def self.default_field_order
-      [:id, :status, :public_ip, :destination, :reverse_dns, :name]
+      %i[id status public_ip destination reverse_dns name]
     end
 
     def <=>(other)

data/lib/brightbox-cli/collaborating_account.rb

@@ -45,9 +45,10 @@ module Brightbox
       @id = fog_model.id
       # Rather than merging, we have store the collaboration as a secondary item
       @collaboration = collaboration
-      if @collaboration.nil? && @fog_model.attributes["resource_type"] == "collaboration"
-        @collaboration = @fog_model
-      end
+
+      return unless @collaboration.nil? && @fog_model.attributes["resource_type"] == "collaboration"
+
+      @collaboration = @fog_model
     end
 
     # Is this record based on an account?
@@ -64,7 +65,6 @@ module Brightbox
       attributes[:resource_type] || attributes["resource_type"]
     end
 
-    #
     def id
       if collaboration?
         account_id
@@ -133,7 +133,7 @@ module Brightbox
     end
 
     def self.default_field_order
-      [:id, :cloud_ips_limit, :lb_limit, :ram_limit, :ram_used, :ram_free, :role, :name]
+      %i[id cloud_ips_limit lb_limit ram_limit ram_used ram_free role name]
     end
 
     private

data/lib/brightbox-cli/collaboration.rb

@@ -22,7 +22,7 @@ module Brightbox
     end
 
     def self.default_field_order
-      [:id, :status, :role, :email, :name]
+      %i[id status role email name]
     end
 
     def to_s

data/lib/brightbox-cli/commands/accounts/{accept-invite.rb → accept_invite.rb}

@@ -1,7 +1,6 @@
 module Brightbox
   desc I18n.t("accounts.desc")
   command [:accounts] do |cmd|
-
     cmd.desc I18n.t("accounts.accept_invite.desc")
     cmd.arg_name "account_id"
     cmd.command [:accept_invite] do |c|
@@ -10,12 +9,9 @@ module Brightbox
 
         # Find the collaboration for that account
         collaboration = UserCollaboration.get_for_account(account_id)
-        if collaboration
-          collaboration.accept
-        else
-          raise "Couldn't find an invite for account #{account_id}"
-        end
+        raise "Couldn't find an invite for account #{account_id}" unless collaboration
 
+        collaboration.accept
         render_table([collaboration], global_options)
       end
     end

data/lib/brightbox-cli/commands/accounts/default.rb

@@ -1,14 +1,13 @@
 module Brightbox
   command [:accounts] do |cmd|
-
     cmd.desc I18n.t("accounts.default.desc")
     cmd.arg_name "account-id"
     cmd.command [:default] do |c|
-
       c.action do |_global_options, _options, args|
         if args.empty?
           raise "You must specify the account-id to set as default."
         end
+
         account_id = args.shift
         account = Account.find(account_id)
 

data/lib/brightbox-cli/commands/accounts/list.rb

@@ -1,19 +1,17 @@
 module Brightbox
   command [:accounts] do |cmd|
-
     cmd.default_command :list
 
     cmd.desc I18n.t("accounts.list.desc")
     cmd.arg_name "[account-id...]"
     cmd.command [:list] do |c|
-
       c.action do |global_options, _options, _args|
-        if Brightbox.config.using_application?
-          # Collaborating Accounts are combined from owned and collaborations
-          accounts = CollaboratingAccount.all
-        else
-          accounts = Account.find(:all)
-        end
+        accounts = if Brightbox.config.using_application?
+                     # Collaborating Accounts are combined from owned and collaborations
+                     CollaboratingAccount.all
+                   else
+                     Account.find(:all)
+                   end
 
         render_table(accounts, global_options)
       end

data/lib/brightbox-cli/commands/accounts/remove.rb

@@ -1,6 +1,5 @@
 module Brightbox
   command [:accounts] do |cmd|
-
     cmd.desc I18n.t("accounts.remove.desc")
     cmd.arg_name "account_id"
     cmd.command [:remove] do |c|
@@ -9,12 +8,9 @@ module Brightbox
 
         # Find the collaboration for that account
         collaboration = UserCollaboration.get_for_account(account_id)
-        if collaboration
-          collaboration.remove
-        else
-          raise "Couldn't find an invite for account #{account_id}"
-        end
+        raise "Couldn't find an invite for account #{account_id}" unless collaboration
 
+        collaboration.remove
         render_table([collaboration], global_options)
       end
     end

data/lib/brightbox-cli/commands/accounts/{reset-ftp-password.rb → reset_ftp_password.rb}

@@ -1,12 +1,9 @@
 module Brightbox
   command [:accounts] do |cmd|
-
     cmd.desc I18n.t("accounts.reset_ftp_password.desc")
     cmd.arg_name "account-id..."
     cmd.command [:reset_ftp_password] do |c|
-
       c.action do |global_options, _options, args|
-
         if args.empty?
           raise "You must specify the accounts to reset ftp passwords for"
         end
@@ -27,12 +24,12 @@ module Brightbox
 
         table_opts = global_options.merge(
           :vertical => true,
-          :fields => [
-            :id,
-            :name,
-            :library_ftp_host,
-            :library_ftp_user,
-            :library_ftp_password
+          :fields => %i[
+            id
+            name
+            library_ftp_host
+            library_ftp_user
+            library_ftp_password
           ]
         )
 

data/lib/brightbox-cli/commands/accounts/show.rb

@@ -1,12 +1,9 @@
 module Brightbox
   command [:accounts] do |cmd|
-
     cmd.desc I18n.t("accounts.show.desc")
     cmd.arg_name "account-id..."
     cmd.command [:show] do |c|
-
       c.action do |global_options, _options, args|
-
         if args.empty?
           raise "You must specify the accounts to show"
         end
@@ -17,16 +14,16 @@ module Brightbox
 
         table_opts = global_options.merge(
           :vertical => true,
-          :fields => [
-            :id,
-            :name,
-            :cloud_ip_limit,
-            :ram_limit,
-            :ram_used,
-            :lb_limit,
-            :ram_free,
-            :library_ftp_host,
-            :library_ftp_user
+          :fields => %i[
+            id
+            name
+            cloud_ip_limit
+            ram_limit
+            ram_used
+            lb_limit
+            ram_free
+            library_ftp_host
+            library_ftp_user
           ]
         )
 

data/lib/brightbox-cli/commands/cloudips/create.rb

@@ -1,22 +1,19 @@
 module Brightbox
   desc I18n.t("cloudips.desc")
   command [:cloudips] do |cmd|
-
     cmd.desc I18n.t("cloudips.create.desc")
     cmd.command [:create] do |c|
-
       c.desc "Number of Cloud IPs to create"
       c.default_value 1
       c.flag [:i, "count"]
 
       c.desc I18n.t("options.name.desc")
-      c.flag [:n, :name]
+      c.flag %i[n name]
 
       c.desc I18n.t("cloudips.options.port_translators.desc")
-      c.flag [:t, :"port-translators"]
+      c.flag %i[t port-translators]
 
       c.action do |global_options, options, _args|
-
         if options[:i].to_s !~ /^[0-9]+$/
           raise "count must be a number"
         end

data/lib/brightbox-cli/commands/cloudips/destroy.rb

@@ -1,15 +1,12 @@
 module Brightbox
   command [:cloudips] do |cmd|
-
     cmd.desc I18n.t("cloudips.destroy.desc")
     cmd.arg_name "[cloudip-id...]"
     cmd.command [:destroy] do |c|
-
       c.desc "Unmap mapped IPs before destroying them"
       c.switch [:u, "unmap"], :negatable => false
 
       c.action do |_global_options, options, args|
-
         if args.empty?
           raise "You must specify the Cloud IPs you want to destroy"
         end
@@ -19,20 +16,19 @@ module Brightbox
         end
 
         ips.each do |ip|
-
           if ip.mapped?
-            if options[:u]
-              info "Unmapping Cloud IP #{ip}"
-              ip.unmap
-              3.times do
-                break unless ip.mapped?
-                sleep 1
-                ip.reload
-              end
-            else
-              raise "Cannot destroy mapped Cloud IP #{ip}"
+            raise "Cannot destroy mapped Cloud IP #{ip}" unless options[:u]
+
+            info "Unmapping Cloud IP #{ip}"
+            ip.unmap
+            3.times do
+              break unless ip.mapped?
+
+              sleep 1
+              ip.reload
             end
           end
+
           info "Destroying Cloud IP #{ip}"
           ip.destroy
         end

data/lib/brightbox-cli/commands/cloudips/list.rb

@@ -1,12 +1,10 @@
 module Brightbox
   command [:cloudips] do |cmd|
-
     cmd.default_command :list
 
     cmd.desc I18n.t("cloudips.list.desc")
     cmd.arg_name "[cloudip-id...]"
     cmd.command [:list] do |c|
-
       c.action do |global_options, _options, args|
         ips = CloudIP.find_all_or_warn(args)
         render_table(ips.sort, global_options)

data/lib/brightbox-cli/commands/cloudips/map.rb

@@ -1,15 +1,12 @@
 module Brightbox
   command [:cloudips] do |cmd|
-
     cmd.desc I18n.t("cloudips.map.desc")
     cmd.arg_name "cloudip-id destination"
     cmd.command [:map] do |c|
-
       c.desc "Unmap mapped IPs before remapping them"
       c.switch [:u, "unmap"], :negatable => false
 
       c.action do |global_options, options, args|
-
         if args.size > 2
           raise "Too many arguments"
         end
@@ -24,7 +21,7 @@ module Brightbox
 
         destination_id = args.last
         case destination_id
-        when /^srv\-/
+        when /^srv-/
           server = Server.find destination_id
           destination_id = server.interfaces.first["id"]
           info "Mapping #{ip} to interface #{destination_id} on #{server}"
@@ -33,15 +30,14 @@ module Brightbox
         end
 
         if ip.mapped?
-          if options[:u]
-            ip.unmap
-            3.times do
-              break unless ip.mapped?
-              sleep 1
-              ip.reload
-            end
-          else
-            raise "Refusing to map already mapped IP #{ip}"
+          raise "Refusing to map already mapped IP #{ip}" unless options[:u]
+
+          ip.unmap
+          3.times do
+            break unless ip.mapped?
+
+            sleep 1
+            ip.reload
           end
         end
 
@@ -51,6 +47,7 @@ module Brightbox
         3.times do
           ip.reload
           break if ip.mapped?
+
           sleep 1
         end
 

data/lib/brightbox-cli/commands/cloudips/show.rb

@@ -1,12 +1,9 @@
 module Brightbox
   command [:cloudips] do |cmd|
-
     cmd.desc I18n.t("cloudips.show.desc")
     cmd.arg_name "cloudip-id..."
     cmd.command [:show] do |c|
-
       c.action do |global_options, _options, args|
-
         if args.empty?
           raise "You must specify the cloud ips you want to show"
         end
@@ -15,17 +12,17 @@ module Brightbox
           warn "Couldn't find Cloud IP #{id}"
         end
 
-        fields = [
-          :id,
-          :name,
-          :status,
-          :public_ipv4,
-          :public_ipv6,
-          :fqdn,
-          :reverse_dns,
-          :destination,
-          :interface_id,
-          :port_translators
+        fields = %i[
+          id
+          name
+          status
+          public_ipv4
+          public_ipv6
+          fqdn
+          reverse_dns
+          destination
+          interface_id
+          port_translators
         ]
 
         render_table(ips.compact, global_options.merge(:vertical => true, :fields => fields))

data/lib/brightbox-cli/commands/cloudips/unmap.rb

@@ -1,12 +1,9 @@
 module Brightbox
   command [:cloudips] do |cmd|
-
     cmd.desc I18n.t("cloudips.map.desc")
     cmd.arg_name "cloudip-id..."
     cmd.command [:unmap] do |c|
-
       c.action do |global_options, _options, args|
-
         if args.empty?
           raise "You must specify the Cloud IPs you want to unmap"
         end
@@ -27,7 +24,8 @@ module Brightbox
 
         # Wait up to 3 seconds for unmapping to complete
         3.times do
-          break unless ips.find { |ip| ip.mapped? }
+          break unless ips.find(&:mapped?)
+
           sleep 1
           ips.each { |ip| ip.reload if ip.mapped? }
         end

data/lib/brightbox-cli/commands/cloudips/update.rb

@@ -1,10 +1,8 @@
 module Brightbox
   command [:cloudips] do |cmd|
-
     cmd.desc I18n.t("cloudips.update.desc")
     cmd.arg_name "cloudip-id"
     cmd.command [:update] do |c|
-
       c.desc "Set reverse DNS for this Cloud IP"
       c.flag [:r, "reverse-dns"]
 
@@ -12,10 +10,10 @@ module Brightbox
       c.switch ["delete-reverse-dns"], :negatable => false
 
       c.desc I18n.t("options.name.desc")
-      c.flag [:n, :name]
+      c.flag %i[n name]
 
       c.desc I18n.t("cloudips.options.port_translators.desc")
-      c.flag [:t, :"port-translators"]
+      c.flag %i[t port-translators]
 
       c.action do |global_options, options, args|
         cip_id = args.shift

data/lib/brightbox-cli/commands/collaborations.rb

@@ -1,7 +1,6 @@
 module Brightbox
   desc "Lists collaborations scoped to an account"
   command [:collaborators] do |cmd|
-
     cmd.default_command :list
 
     cmd.desc "List an accounts collaborations"
@@ -36,7 +35,7 @@ module Brightbox
         collaborations = Collaboration.find_or_call(args) do |id|
           warn "Couldn't find collaboration #{id}"
         end
-        collaborations.each { |col| col.resend }
+        collaborations.each(&:resend)
         render_table(collaborations, global_options)
       end
     end
@@ -59,7 +58,7 @@ module Brightbox
         collaborations = Collaboration.find_or_call(args) do |id|
           warn "Couldn't find collaboration #{id}"
         end
-        collaborations.each { |col| col.destroy }
+        collaborations.each(&:destroy)
         render_table(collaborations, global_options)
       end
     end

data/lib/brightbox-cli/commands/config/{client-add.rb → client_add.rb}

@@ -1,11 +1,9 @@
 module Brightbox
   desc I18n.t("config.desc")
   command [:config] do |cmd|
-
     cmd.desc I18n.t("config.client_add.desc")
     cmd.arg_name "client-id secret [api_url, auth_url]"
     cmd.command [:client_add] do |c|
-
       c.desc "client alias (local reference)"
       c.flag [:a, "alias"]
 
@@ -13,7 +11,6 @@ module Brightbox
       c.flag [:t, "auth-url"]
 
       c.action do |_global_options, options, args|
-
         info "Using config file #{Brightbox.config.config_filename}"
 
         client_id = args.shift

data/lib/brightbox-cli/commands/config/client_default.rb

@@ -0,0 +1,18 @@
+module Brightbox
+  command [:config] do |cmd|
+    cmd.desc I18n.t("config.client_default.desc")
+    cmd.arg_name "alias"
+    cmd.command [:client_default] do |c|
+      c.action do |_global_options, _options, args|
+        info "Using config file #{Brightbox.config.config_filename}"
+        calias = args.shift
+
+        raise "You must specify the api alias you want to set as the default" if calias.nil?
+        raise "An api client with the alias #{calias} does not exist in the config" unless Brightbox.config.client_named?(calias)
+
+        info "Setting #{calias} as default api client"
+        Brightbox.config.set_default_client(calias)
+      end
+    end
+  end
+end