brightbox-cli 3.1.0 → 4.0.0.rc2

data/spec/unit/brightbox/config/user_application/valid_spec.rb

@@ -12,7 +12,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         username = user@example.com
         EOS
       end
@@ -26,7 +26,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{random_token}
         username = user@example.com
@@ -58,7 +58,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{random_token}
         EOS

data/spec/unit/brightbox/connection_manager/fetch_connection_spec.rb

@@ -52,7 +52,7 @@ describe Brightbox::ConnectionManager, "#fetch_connection" do
 
     it "selects configured account" do
       skip "Fails out of sequence, mocked config incorrect"
-      Brightbox.config.stubs(:selected_config).returns('default_account' => "acc-12345")
+      Brightbox.config.stubs(:selected_config).returns("default_account" => "acc-12345")
       connection = connection_manager.fetch_connection(true)
       expect(connection).not_to be_nil
       expect(connection.scoped_account).to eq("acc-12345")

data/spec/unit/brightbox/database_server/clean_arguments_spec.rb

@@ -2,7 +2,6 @@ require "spec_helper"
 require "fog/brightbox/models/compute/database_server"
 
 describe Brightbox::DatabaseServer do
-
   describe ".clean_arguments" do
     let(:parameters) { Brightbox::DatabaseServer.clean_arguments(arguments) }
 
@@ -21,7 +20,7 @@ describe Brightbox::DatabaseServer do
     context "when --allow-access=10.0.0.0,11.0.0.0" do
       let(:arguments) { { "allow-access" => "10.0.0.0,11.0.0.0" } }
 
-      it { expect(parameters[:allow_access]).to eql(%w(10.0.0.0 11.0.0.0)) }
+      it { expect(parameters[:allow_access]).to eql(%w[10.0.0.0 11.0.0.0]) }
     end
 
     context "when --maintenance-weekday=4" do

data/spec/unit/brightbox/database_server/maintenance_window_spec.rb

@@ -2,7 +2,6 @@ require "spec_helper"
 require "fog/brightbox/models/compute/database_server"
 
 describe Brightbox::DatabaseServer do
-
   describe "#maintenance_window" do
     let(:fog_model) { Fog::Brightbox::Compute::DatabaseServer.new(fog_settings) }
     let(:dbs) { Brightbox::DatabaseServer.new(fog_model) }

data/spec/unit/brightbox/error_parser/pretty_print_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::ErrorParser do
-
   describe "#pretty_print" do
     let(:parser) { Brightbox::ErrorParser.new(error_to_parse) }
 

data/spec/unit/brightbox/firewall_policy/apply_to_spec.rb

@@ -6,7 +6,6 @@ describe Brightbox::FirewallPolicy do
   end
 
   describe "#apply_to", vcr: true do
-
     it "should apply firewall policy" do
       expect do
         params = { :name => "rspec_tests_apply" }

data/spec/unit/brightbox/firewall_policy/create_spec.rb

@@ -6,7 +6,6 @@ describe Brightbox::FirewallPolicy do
   end
 
   describe "#create", vcr: true do
-
     it "should create firewall policy" do
       params = { :name => "rspec_tests" }
       @group = Brightbox::ServerGroup.create(params)

data/spec/unit/brightbox/firewall_policy/find_or_call_spec.rb

@@ -6,7 +6,6 @@ describe Brightbox::FirewallPolicy do
   end
 
   describe "#find_or_call" do
-
     context "when a policy exists" do
       before do
         options = {

data/spec/unit/brightbox/firewall_policy/find_spec.rb

@@ -6,7 +6,6 @@ describe Brightbox::FirewallPolicy do
   end
 
   describe "#find(:all)", vcr: true do
-
     context "when a policy exists" do
       before do
         options = {}

data/spec/unit/brightbox/firewall_rule/find_spec.rb

@@ -26,15 +26,15 @@ describe Brightbox::FirewallRule do
         end.to_not raise_error
 
         display_options = {
-          :fields => [
-            :id,
-            :protocol,
-            :source,
-            :sport,
-            :destination,
-            :dport,
-            :icmp_type,
-            :firewall_policy
+          :fields => %i[
+            id
+            protocol
+            source
+            sport
+            destination
+            dport
+            icmp_type
+            firewall_policy
           ],
           :vertical => true
         }

data/spec/unit/brightbox/firewall_rule/from_policy_spec.rb

@@ -17,10 +17,10 @@ describe Brightbox::FirewallRule do
           :firewall_policy_id => @policy.id
         }
         rule_1_options = rule_options.merge(:destination_port => "1080")
-        @rule_1 = Brightbox::FirewallRule.create rule_1_options
+        @rule_one = Brightbox::FirewallRule.create rule_1_options
 
         rule_2_options = rule_options.merge(:destination_port => "1081")
-        @rule_2 = Brightbox::FirewallRule.create rule_2_options
+        @rule_two = Brightbox::FirewallRule.create rule_2_options
       end
 
       it "lists all rules" do
@@ -32,10 +32,10 @@ describe Brightbox::FirewallRule do
         output = FauxIO.new do
           Brightbox.render_table(@policy_rules, :vertical => true)
         end
-        expect(output.stdout).to include("id: #{@rule_1.id}")
+        expect(output.stdout).to include("id: #{@rule_one.id}")
         expect(output.stdout).to include("dport: 1080")
 
-        expect(output.stdout).to include("id: #{@rule_2.id}")
+        expect(output.stdout).to include("id: #{@rule_two.id}")
         expect(output.stdout).to include("dport: 1081")
       end
 

data/spec/unit/brightbox/legacy/args_adjuster_spec.rb

@@ -2,61 +2,60 @@ require "spec_helper"
 require "brightbox-cli/legacy/args_adjuster"
 
 describe Brightbox::Legacy::ArgsAdjuster do
-
   describe "#for_command" do
     let(:adjuster) { Brightbox::Legacy::ArgsAdjuster.new(args) }
 
     context "when account global switch is used" do
-      let(:args) { %w(--account acc-12345 show srv-12345) }
+      let(:args) { %w[--account acc-12345 show srv-12345] }
 
       it "inserts after global args" do
-        expected = %w(--account acc-12345 command show srv-12345)
-        expect(adjuster.for_command "command").to eql(expected)
+        expected = %w[--account acc-12345 command show srv-12345]
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
     context "when client global switch is used" do
-      let(:args) { %w(-c staging show srv-12345) }
+      let(:args) { %w[-c staging show srv-12345] }
 
       it "inserts after global args" do
-        expected = %w(-c staging command show srv-12345)
-        expect(adjuster.for_command "command").to eql(expected)
+        expected = %w[-c staging command show srv-12345]
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
     context "when simple global flag is used" do
-      let(:args) { %w(--simple show srv-12345) }
+      let(:args) { %w[--simple show srv-12345] }
 
       it "inserts after global args" do
-        expected = %w(-s command show srv-12345)
-        expect(adjuster.for_command "command").to eql(expected)
+        expected = %w[-s command show srv-12345]
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
     context "when insecure global switch is used" do
-      let(:args) { %w(-k show srv-12345) }
+      let(:args) { %w[-k show srv-12345] }
 
       it "inserts after global args" do
-        expected = %w(-k command show srv-12345)
-        expect(adjuster.for_command "command").to eql(expected)
+        expected = %w[-k command show srv-12345]
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
     context "when many args are passed" do
-      let(:args) { %w(-k --simple -c prod subcommand srv-12345) }
+      let(:args) { %w[-k --simple -c prod subcommand srv-12345] }
 
       it "inserts after global args" do
-        expected = %w(-k -s -c prod command subcommand srv-12345)
-        expect(adjuster.for_command "command").to eql(expected)
+        expected = %w[-k -s -c prod command subcommand srv-12345]
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
     context "when no global args are used" do
-      let(:args) { %w(show srv-12345) }
+      let(:args) { %w[show srv-12345] }
 
       it "inserts at the front" do
-        expected = %w(command show srv-12345)
-        expect(adjuster.for_command "command").to eql(expected)
+        expected = %w[command show srv-12345]
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
@@ -65,7 +64,7 @@ describe Brightbox::Legacy::ArgsAdjuster do
 
       it "inserts at the front" do
         expected = ["command"]
-        expect(adjuster.for_command "command").to eql(expected)
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
 
@@ -74,7 +73,7 @@ describe Brightbox::Legacy::ArgsAdjuster do
 
       it "doesn't raise an error" do
         expected = ["-k", "command", "create", "-n", "Disk test", "img-12345"]
-        expect(adjuster.for_command "command").to eql(expected)
+        expect(adjuster.for_command("command")).to eql(expected)
       end
     end
   end

data/spec/unit/brightbox/server/create_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::Server do
-
   describe "#create" do
     context "when account limit reached" do
       it "should print error if account limit reached" do
@@ -16,7 +15,7 @@ describe Brightbox::Server do
         error = nil
         begin
           Brightbox::Server.create(options)
-        rescue => e
+        rescue StandardError => e
           error = Brightbox::ErrorParser.new(e)
         end
         output = FauxIO.new { error.pretty_print }

data/spec/unit/brightbox/server/start_spec.rb

@@ -15,12 +15,12 @@ describe Brightbox::Server do
 
       server.fog_model.wait_for { ready? }
 
-      expect {
+      expect do
         server.stop
         server.fog_model.wait_for { !ready? }
 
         server.start
-      }.not_to raise_error
+      end.not_to raise_error
     end
   end
 end

data/spec/unit/brightbox/server/update_spec.rb

@@ -31,5 +31,4 @@ describe Brightbox::Server do
       end
     end
   end
-
 end

data/spec/unit/brightbox/user_collaboration/remove_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::UserCollaboration do
-
   describe "#remove" do
     context "when collaboration is pending" do
       it "tells model to reject collaboration" do

data/spec/unit/nilable_hash_spec.rb

@@ -3,23 +3,23 @@ require "spec_helper"
 describe NilableHash, "#nilify_blanks" do
   before do
     @blank_hash = NilableHash[
-      :present => 'value', :b1 => '', 'nilval' => nil, 'b2' => '', 'another' => 'another value'
+      :present => "value", :b1 => "", "nilval" => nil, "b2" => "", "another" => "another value"
     ]
   end
 
   it "should nilify all blank values" do
     @blank_hash.nilify_blanks
     expect(@blank_hash[:b1]).to be_nil
-    expect(@blank_hash['b2']).to be_nil
+    expect(@blank_hash["b2"]).to be_nil
   end
 
   it "should leave nils as nil" do
-    expect(@blank_hash['nilval']).to be_nil
+    expect(@blank_hash["nilval"]).to be_nil
   end
 
   it "should not nilify non blank values" do
-    expect(@blank_hash[:present]).to eq('value')
-    expect(@blank_hash['another']).to eq('another value')
+    expect(@blank_hash[:present]).to eq("value")
+    expect(@blank_hash["another"]).to eq("another value")
   end
 
   it "should respond true when sent #is_a?(Hash)" do

data/spec/unit/ruby_core_ext_spec.rb

@@ -3,17 +3,16 @@ require "spec_helper"
 require "time"
 
 describe Time do
-
-  describe "#clipped_iso_8601" do
+  describe "#clipped_iso8601" do
     it "returns a shortened version of the ISO8601 datetime" do
-      expect(Time.now.clipped_iso_8601).to match(/\A\d{4}-\d{2}-\d{2}T\d{2}:\d{2}\z/)
+      expect(Time.now.clipped_iso8601).to match(/\A\d{4}-\d{2}-\d{2}T\d{2}:\d{2}\z/)
     end
   end
 
   describe "#to_s" do
     it "returns the clipped ISO 8601 time" do
       the_time = Time.now
-      expect(the_time.to_s).to eql(the_time.clipped_iso_8601)
+      expect(the_time.to_s).to eql(the_time.clipped_iso8601)
     end
   end
 end

data/spec/unit/temporary_home_spec.rb

@@ -2,6 +2,6 @@ require "spec_helper"
 
 describe "As a developer my config should be safe" do
   it "uses a tmp directory as the home for the spec" do
-    expect(ENV["HOME"]).to_not eql(TEST_RUNNER_HOME)
+    expect(ENV.fetch("HOME", nil)).to_not eql(TEST_RUNNER_HOME)
   end
 end

data/spec/unit/tmp_config_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe TmpConfig do
-
   describe "#new(contents)" do
     it "creates a config file" do
       file_contents = "contents\ncontents"