brightbox-cli 3.1.0 → 4.0.0.rc2

data/spec/unit/brightbox/bb_config/add_login_spec.rb

@@ -5,21 +5,21 @@ describe Brightbox::BBConfig, "#add_login" do
 
   let(:email) { "jason.null@brightbox.com" }
   let(:password) { "N:B3e%7Cmh" }
-  let(:api_url) { ENV["BRIGHTBOX_API_URL"] || "http://api.brightbox.dev" }
+  let(:api_url) { Brightbox::DEFAULT_API_ENDPOINT }
 
   context "when no config exists", vcr: true do
     let(:expected_config) do
-      <<EOS
-[core]
-default_client = #{email}
+      <<~EOS
+        [core]
+        default_client = #{email}
 
-[#{email}]
-username = #{email}
-api_url = #{api_url}
-auth_url = #{api_url}
-default_account = acc-12345
+        [#{email}]
+        username = #{email}
+        api_url = #{api_url}
+        auth_url = #{api_url}
+        default_account = acc-12345
 
-EOS
+      EOS
     end
 
     before do
@@ -52,9 +52,9 @@ EOS
 
     it "does not alter the configuration" do
       FauxIO.new do
-        expect {
+        expect do
           config.add_login(email, password)
-        }.not_to change { config_file_contents }.from(original_config)
+        end.not_to change { config_file_contents }.from(original_config)
       end
     end
 
@@ -78,7 +78,7 @@ EOS
   context "when configured with custom options", vcr: true do
     let(:original_config) { config_file_contents }
 
-    let(:custom_url) { ENV["BRIGHTBOX_API_URL"] || "http://api.brightbox.dev" }
+    let(:custom_url) { Brightbox::DEFAULT_API_ENDPOINT }
     let(:custom_app_id) { "app-23456" }
     let(:custom_app_secret) { "ho04hondtzjjdf4" }
     let(:custom_default_account) { "acc-23456" }
@@ -99,9 +99,9 @@ EOS
 
     it "does not alter the configuration" do
       FauxIO.new do
-        expect {
+        expect do
           config.add_login(email, password)
-        }.not_to change { config_file_contents }.from(original_config)
+        end.not_to change { config_file_contents }.from(original_config)
       end
 
       expect(config_file_contents).to match("[#{email}]")
@@ -132,7 +132,7 @@ EOS
   context "when altering a custom option", vcr: true do
     let(:original_config) { config_file_contents }
 
-    let(:custom_url) { ENV["BRIGHTBOX_API_URL"] || "http://api.brightbox.dev" }
+    let(:custom_url) { Brightbox::DEFAULT_API_ENDPOINT }
     let(:custom_app_id) { "app-23456" }
     let(:custom_app_secret) { "ho04hondtzjjdf4" }
     let(:custom_default_account) { "acc-23456" }
@@ -153,9 +153,9 @@ EOS
 
     it "does not alter the configuration" do
       FauxIO.new do
-        expect {
+        expect do
           config.add_login(email, password)
-        }.not_to change { config_file_contents }.from(original_config)
+        end.not_to change { config_file_contents }.from(original_config)
       end
 
       expect(config_file_contents).to match("[#{email}]")
@@ -185,17 +185,17 @@ EOS
   context "when using an email and suffix", vcr: true do
     let(:client_name) { "#{email}/dev" }
     let(:expected_config) do
-      <<EOS
-[core]
-default_client = #{client_name}
+      <<~EOS
+        [core]
+        default_client = #{client_name}
 
-[#{client_name}]
-username = #{email}
-api_url = #{api_url}
-auth_url = #{api_url}
-default_account = acc-12345
+        [#{client_name}]
+        username = #{email}
+        api_url = #{api_url}
+        auth_url = #{api_url}
+        default_account = acc-12345
 
-EOS
+      EOS
     end
 
     before do
@@ -218,5 +218,4 @@ EOS
       expect(cached_refresh_token(config)).to eq(config.refresh_token)
     end
   end
-
 end

data/spec/unit/brightbox/bb_config/add_section_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#add_section" do
     context "when first and only client", vcr: true do
       let(:config) { Brightbox::BBConfig.new }
@@ -12,7 +11,7 @@ describe Brightbox::BBConfig do
       let(:options) do
         {
           :username => "jason.null@brightbox.com",
-          :api_url => "http://api.brightbox.dev"
+          :api_url => "http://api.brightbox.localhost"
         }
       end
       let(:saved_config) { config_file_contents }

data/spec/unit/brightbox/bb_config/clear_default_client_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#clear_default_client" do
     context "when default client is set" do
       let(:contents) do

data/spec/unit/brightbox/bb_config/client_id_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#client_id" do
     context "when client has old 'alias' key" do
       let(:contents) do

data/spec/unit/brightbox/bb_config/client_name_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#client_name" do
     context "when passed as an option" do
       before do

data/spec/unit/brightbox/bb_config/config_directory_exists_spec.rb

@@ -2,7 +2,6 @@ require "spec_helper"
 require "tmpdir"
 
 describe Brightbox::BBConfig do
-
   describe "#config_directory_exists?" do
     let(:config) { Brightbox::BBConfig.new(:directory => @dir) }
 

data/spec/unit/brightbox/bb_config/config_directory_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#config_directory" do
     context "when default location is used" do
       it "returns a String of the users `.brightbox` directory" do

data/spec/unit/brightbox/bb_config/config_spec.rb

@@ -3,7 +3,6 @@ require "tmpdir"
 require "tempfile"
 
 describe Brightbox::BBConfig do
-
   describe "#config" do
     context "when config directory is missing" do
       around do |example|
@@ -68,9 +67,9 @@ describe Brightbox::BBConfig do
             f.puts "not:ini"
           end
 
-          expect {
+          expect do
             @config = Brightbox::BBConfig.new :directory => target_dir
-          }.to raise_error(Brightbox::BBConfigError)
+          end.to raise_error(Brightbox::BBConfigError)
         end
       end
     end

data/spec/unit/brightbox/bb_config/default_account_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#default_account" do
     context "when no config file is available" do
       before do

data/spec/unit/brightbox/bb_config/default_client_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#default_client" do
     context "when config file is empty" do
       before do

data/spec/unit/brightbox/bb_config/delete_section_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#delete_section" do
     let(:client_name) { "removable" }
 

data/spec/unit/brightbox/bb_config/find_or_set_default_account_spec.rb

@@ -20,7 +20,7 @@ describe Brightbox::BBConfig do
       let(:contents) do
         <<-EOS
         [cli-default]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = cli-default
         secret = qy6xxnvy4o0tgv5
         default_account = acc-default
@@ -38,7 +38,7 @@ describe Brightbox::BBConfig do
       let(:contents) do
         <<-EOS
         [cli-12345]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = cli-12345
         secret = wrong_password
         EOS
@@ -64,7 +64,7 @@ describe Brightbox::BBConfig do
         [core]
         default_client = cli-12345
         [cli-12345]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = cli-12345
         secret = qy6xxnvy4o0tgv5
         EOS
@@ -81,7 +81,7 @@ describe Brightbox::BBConfig do
       let(:contents) do
         <<-EOS
         [app-12345]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = app-12345
         secret = mocbuipbiaa6k6c
         EOS

data/spec/unit/brightbox/bb_config/refresh_token_filename_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#refresh_token_filename" do
     context "when using a custom directory" do
       before do

data/spec/unit/brightbox/bb_config/renew_tokens_spec.rb

@@ -1,7 +1,7 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-  let(:api_endpoint) { "http://api.brightbox.dev" }
+  let(:api_endpoint) { Brightbox::DEFAULT_API_ENDPOINT }
 
   # These are fake values that dev servers may choose to allow
   let(:username) { "jason.null@brightbox.com" }
@@ -43,7 +43,6 @@ describe Brightbox::BBConfig do
         # Refresh token
         expect(cached_refresh_token(@config)).to eql(@new_refresh_token)
       end
-
     end
 
     context "when using a user app with a cached refresh token", vcr: true do
@@ -67,7 +66,7 @@ describe Brightbox::BBConfig do
         # Access token
         expect(File.exist?(@config.access_token_filename)).to be true
 
-        # NOTE The cached to disk version is filtered by VCR when testing
+        # NOTE: The cached to disk version is filtered by VCR when testing
         expect(cached_access_token(@config)).to eql(@new_access_token)
 
         # Refresh token
@@ -95,7 +94,7 @@ describe Brightbox::BBConfig do
         # Access token
         expect(File.exist?(@config.access_token_filename)).to be true
 
-        # NOTE The cached to disk version is filtered by VCR when testing
+        # NOTE: The cached to disk version is filtered by VCR when testing
         expect(cached_access_token(@config)).to eql(@new_access_token)
 
         # Refresh token

data/spec/unit/brightbox/bb_config/save_default_account_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   describe "#save_default_account" do
     context "when setting has not changed" do
       let(:account_id) { "acc-12345" }

data/spec/unit/brightbox/bb_config/save_spec.rb

@@ -1,7 +1,6 @@
 require "spec_helper"
 
 describe Brightbox::BBConfig do
-
   context "when config is clean" do
     let(:config) { Brightbox::BBConfig.new }
 

data/spec/unit/brightbox/bb_config/section_names_spec.rb

@@ -41,6 +41,6 @@ describe Brightbox::BBConfig, "#section_names" do
       setting = value
       EOS
     end
-    it { expect(config.section_names).to eq(%w(cli-12345 app-12345)) }
+    it { expect(config.section_names).to eq(%w[cli-12345 app-12345]) }
   end
 end

data/spec/unit/brightbox/bb_config/to_fog_spec.rb

@@ -43,7 +43,7 @@ describe Brightbox::BBConfig do
 
       it "returns correct fog options" do
         expect(fog_config[:provider]).to eql("Brightbox")
-        expect(fog_config[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(fog_config[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
         expect(fog_config[:brightbox_client_id]).to eql("cli-12345")
         expect(fog_config[:brightbox_secret]).to eql("qy6xxnvy4o0tgv5")
       end
@@ -54,7 +54,7 @@ describe Brightbox::BBConfig do
 
       it "returns correct fog options" do
         expect(fog_config[:provider]).to eql("Brightbox")
-        expect(fog_config[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(fog_config[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
         expect(fog_config[:brightbox_client_id]).to eql("app-12345")
         expect(fog_config[:brightbox_secret]).to eql("mocbuipbiaa6k6c")
       end

data/spec/unit/brightbox/collaborating_account/to_row_spec.rb

@@ -10,9 +10,9 @@ describe Brightbox::CollaboratingAccount do
     context "when initialised with an account" do
       let(:initial_model) { owned_account }
 
-      [:cloud_ips_limit, :lb_limit, :ram_limit, :ram_used, :ram_free].each do |key|
+      %i[cloud_ips_limit lb_limit ram_limit ram_used ram_free].each do |key|
         it "returns the number for #{key}" do
-          expect(row_data[key]).to be_kind_of(Fixnum)
+          expect(row_data[key]).to be_kind_of(Integer)
         end
       end
     end
@@ -20,7 +20,7 @@ describe Brightbox::CollaboratingAccount do
     context "when initialised with a collaboration" do
       let(:initial_model) { active_collaboration }
 
-      [:cloud_ips_limit, :lb_limit, :ram_limit, :ram_used, :ram_free].each do |key|
+      %i[cloud_ips_limit lb_limit ram_limit ram_used ram_free].each do |key|
         it "returns empty string for #{key}" do
           expect(row_data[key]).to eql("")
         end

data/spec/unit/brightbox/config/api_client/to_fog_spec.rb

@@ -15,7 +15,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{secret}
         EOS
@@ -26,11 +26,11 @@ describe Brightbox::Config::ApiClient do
       end
 
       it "sets API endpoint correctly" do
-        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "copies API endpoint for auth endpoint correctly" do
-        expect(for_fog[:brightbox_auth_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_auth_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "sets client_id correctly" do
@@ -50,7 +50,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         auth_url = http://auth.dev.brightbox.com
         client_id = #{client_name}
         secret = #{secret}
@@ -58,7 +58,7 @@ describe Brightbox::Config::ApiClient do
       end
 
       it "sets API endpoint correctly" do
-        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "copies API endpoint for auth endpoint correctly" do
@@ -70,7 +70,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{secret}
         persistent = false
@@ -100,7 +100,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         secret = #{random_token}
         EOS
       end
@@ -114,7 +114,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         EOS
       end

data/spec/unit/brightbox/config/api_client/valid_spec.rb

@@ -12,7 +12,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{random_token}
         EOS
@@ -27,7 +27,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{random_token}
         theme = blue
@@ -57,7 +57,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         secret = #{random_token}
         EOS
       end
@@ -71,7 +71,7 @@ describe Brightbox::Config::ApiClient do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         EOS
       end

data/spec/unit/brightbox/config/discover_two_factor_pin_spec.rb

@@ -0,0 +1,87 @@
+require "spec_helper"
+
+RSpec.describe Brightbox::Config, "#discover_two_factor_pin" do
+  subject(:config) { config_from_contents(contents) }
+
+  let(:api_url) { "http://api.brightbox.localhost" }
+  let(:client_alias) { email }
+  let(:default_account) { "acc-12345" }
+  let(:email) { "jason.null@brightbox.com" }
+
+  context "when 2FA is enabled" do
+    context "with password helper" do
+      let(:cmd) { "fnord" }
+      let(:contents) do
+        <<-EOS
+        [core]
+        default_client = #{client_alias}
+
+        [#{client_alias}]
+        username = #{email}
+        two_factor = true
+        two_factor_helper_command = #{cmd}
+        EOS
+      end
+
+      it "returns helper's response" do
+        expect(IO).to receive(:popen).with([cmd], "r").and_return("111111")
+
+        expect(config.discover_two_factor_pin).to eq("111111")
+      end
+    end
+
+    context "with invalid password helper" do
+      let(:contents) do
+        <<-EOS
+        [core]
+        default_client = #{client_alias}
+
+        [#{client_alias}]
+        username = #{email}
+        two_factor = true
+        two_factor_helper_command = #{cmd}
+        EOS
+      end
+
+      context "when setting is empty" do
+        let(:cmd) { nil }
+
+        it "prompts for OTP" do
+          mock_otp_entry("123456")
+
+          expect(config.discover_two_factor_pin).to eq("123456")
+        end
+      end
+
+      context "when command doesn't exist" do
+        let(:cmd) { "fnord" }
+
+        it "prompts for OTP" do
+          expect(IO).to receive(:popen).with([cmd], "r").and_raise(Errno::ENOENT)
+          mock_otp_entry("123456")
+
+          expect(config.discover_two_factor_pin).to eq("123456")
+        end
+      end
+    end
+
+    context "without password helper" do
+      let(:contents) do
+        <<-EOS
+        [core]
+        default_client = #{client_alias}
+
+        [#{client_alias}]
+        username = #{email}
+        two_factor = true
+        EOS
+      end
+
+      it "prompts for OTP" do
+        mock_otp_entry("123456")
+
+        expect(config.discover_two_factor_pin).to eq("123456")
+      end
+    end
+  end
+end

data/spec/unit/brightbox/config/section_name_deduplicator_spec.rb

@@ -33,7 +33,7 @@ describe Brightbox::Config::SectionNameDeduplicator do
 
     context "when name has been deduped before" do
       let(:name) { "dev" }
-      let(:in_use) { %w(dev dev_1 dev_2) }
+      let(:in_use) { %w[dev dev_1 dev_2] }
 
       it "returns a deduplicated name" do
         expect(deduper.next).to eql("dev_3")

data/spec/unit/brightbox/config/user_application/to_fog_spec.rb

@@ -15,7 +15,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         username = user@example.com
         EOS
       end
@@ -25,11 +25,11 @@ describe Brightbox::Config::UserApplication do
       end
 
       it "sets API endpoint correctly" do
-        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "copies API endpoint for auth endpoint correctly" do
-        expect(for_fog[:brightbox_auth_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_auth_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "sets client_id correctly" do
@@ -49,7 +49,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{secret}
         username = user@example.com
@@ -61,11 +61,11 @@ describe Brightbox::Config::UserApplication do
       end
 
       it "sets API endpoint correctly" do
-        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "copies API endpoint for auth endpoint correctly" do
-        expect(for_fog[:brightbox_auth_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_auth_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "sets client_id correctly" do
@@ -85,7 +85,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         auth_url = http://auth.dev.brightbox.com
         client_id = #{client_name}
         secret = #{secret}
@@ -94,7 +94,7 @@ describe Brightbox::Config::UserApplication do
       end
 
       it "sets API endpoint correctly" do
-        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.dev")
+        expect(for_fog[:brightbox_api_url]).to eql("http://api.brightbox.localhost")
       end
 
       it "copies API endpoint for auth endpoint correctly" do
@@ -106,7 +106,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{secret}
         username = user@example.com
@@ -138,7 +138,7 @@ describe Brightbox::Config::UserApplication do
       let(:contents) do
         <<-EOS
         [#{client_name}]
-        api_url = http://api.brightbox.dev
+        api_url = http://api.brightbox.localhost
         client_id = #{client_name}
         secret = #{secret}
         EOS