brewery_db 0.0.1 → 0.1.0

data/spec/brewery_db/{response_spec.rb → mash_spec.rb}

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe BreweryDB::Response do
+describe BreweryDB::Mash do
   it { should be_a(Hashie::Mash) }
 
   context '#convert_key' do

data/spec/brewery_db/middleware/error_handler_spec.rb

@@ -0,0 +1,49 @@
+require 'spec_helper'
+
+describe BreweryDB::Middleware::ErrorHandler do
+  subject(:handler) { described_class.new }
+
+  describe '#on_complete' do
+    let(:error_body) { stub(error_message: error_message, status: 'failure') }
+    let(:error_message) { 'error' }
+    let(:over_ratelimit) { { 'x-ratelimit-remaining' => '0' } }
+
+    it 'does not raise an error when the status is 200' do
+      expect { handler.on_complete(status: 200) }.to_not raise_error
+    end
+
+    it 'raises a bad request error when the status is 400' do
+      expect {
+        handler.on_complete(status: 400, body: error_body)
+      }.to raise_error(BreweryDB::BadRequest, 'Status => 400. Error message => error')
+    end
+
+    it 'raises an rate limit exceeded error when the status is 401 and x-ratelimit-remaining is 0' do
+      expect {
+        handler.on_complete(status: 401, body: error_body, response_headers: over_ratelimit)
+      }.to raise_error(BreweryDB::RateLimitExceeded, 'Status => 401. Error message => error')
+    end
+
+    it 'raises an unauthorized error when the status is 401 and not over rate limit' do
+      expect {
+        handler.on_complete(status: 401, body: error_body, response_headers: {})
+      }.to raise_error(BreweryDB::Unauthorized, 'Status => 401. Error message => error')
+    end
+
+    it 'raises a not found error when the status is 404' do
+      expect {
+        handler.on_complete(status: 404, body: error_body)
+      }.to raise_error(BreweryDB::NotFound, 'Status => 404. Error message => error')
+    end
+
+    context 'the status is unknown' do
+      let(:error_message) { 'SQLSTATE[40001]: Serialization failure: 1213 Deadlock found when trying to get lock; try restarting transaction' }
+
+      it 'raises an error with the status and error message' do
+        expect {
+          handler.on_complete(status: 500, body: error_body)
+        }.to raise_error(BreweryDB::Error, "Status => 500. Error message => #{error_message}")
+      end
+    end
+  end
+end

data/spec/brewery_db/resource_spec.rb

@@ -1,33 +1,46 @@
-require 'spec_helper'
-
-describe BreweryDB::Resource do
-  let(:client) { BreweryDB::Client.new }
+# encoding: UTF-8
 
-  context '.new' do
-    it 'accepts a client' do
-      described_class.new(client).should be_a(described_class)
-    end
+require 'spec_helper'
 
-    it 'raises an exception without a client' do
-      expect { described_class.new }.to raise_error
+describe BreweryDB::Resource, :resource do
+  context '#get', :vcr do
+    let(:resource) do
+      Class.new(BreweryDB::Resource) {
+        def ok
+          get('breweries', name: 'Rogue Ales').data
+        end
+
+        def list
+          get('breweries', established: 2006).collection
+        end
+
+        def not_found
+          get('brewery/NOT_FOUND').data
+        end
+      }.new(config)
     end
-  end
-
-  context '#connection' do
-    let(:endpoint) { URI.parse(BreweryDB::Config::ENDPOINT) }
 
-    subject { described_class.new(client).connection }
+    context 'an OK request' do
+      subject { resource.ok.first }
 
-    it { should be_a(Faraday::Connection) }
+      its(:name) { should == 'Rogue Ales' }
+    end
 
-    its(:'builder.handlers') { should include(FaradayMiddleware::ParseJson) }
+    context 'a list of resources' do
+      it 'can be enumerated' do
+        resource.list.inject(0) { |tally, r| tally + 1 }.should eq 55
+      end
+    end
 
-    its(:scheme) { should == endpoint.scheme }
-    its(:host) { should == endpoint.host }
-    its(:path_prefix) { should == endpoint.path }
+    context 'a not found request' do
+      it 'raises an exception' do
+        expect { resource.not_found }.to raise_error(BreweryDB::NotFound)
+      end
 
-    its(:headers) do
-      should == { 'User-Agent' => BreweryDB::Config::USER_AGENT }
+      it 'sets the exception message to the error message in the response' do
+        exception = resource.not_found rescue $!
+        exception.message.should match /not\s+found/
+      end
     end
   end
 end

data/spec/brewery_db/resources/beers_spec.rb

@@ -2,92 +2,20 @@
 
 require 'spec_helper'
 
-describe BreweryDB::Resources::Beers do
-  it_behaves_like 'a resource' do
-    context '#all' do
-      let(:response) { described_class.new(client).all(abv: '5.5') }
+describe BreweryDB::Resources::Beers, :resource do
+  context '#all', :vcr do
+    let(:response) { described_class.new(config).all(abv: '5.5') }
 
-      subject { response }
-
-      its(:current_page) { should == 1 }
-      its(:number_of_pages) { should == 8 }
-      its(:status) { should == 'success' }
-      its(:data) { should be_a(Array) }
-      its(:data) { should have(50).results }
-
-      context 'result' do
-        subject { response.data.first }
-
-        it { should have(14).keys }
-
-        its(:id) { should == 'VjQIQW' }
-        its(:name) { should == '2011 Christmas Ale' }
-        its(:description) { should == "Every year since 1975 the brewers at Anchor have brewed a distinctive and unique Christmas Ale, which is available from early November to mid-January. The Ale's recipe is different every year—as is the tree on the label—but the intent with which we offer it remains the same: joy and celebration of the newness of life." }
-        its(:abv) { should == '5.5' }
-        its(:glassware_id) { should == 5 }
-        its(:available_id) { should == 4 }
-        its(:is_organic) { should == 'N' }
-        its(:status) { should == 'verified' }
-        its(:status_display) { should == 'Verified' }
-        its(:'glass.id') { should == 5 }
-        its(:'glass.name') { should == 'Pint' }
-        its(:'glass.create_date') { should == '2012-03-26 04:00:04' }
-        its(:'available.name') { should == 'Seasonal' }
-        its(:'available.description') { should == 'Available at the same time of year, every year.' }
-        its(:style_id) { should == 98 }
-        its(:'style.id') { should == 98 }
-        its(:'style.category.id') { should == 23 }
-        its(:'style.category.name') { should == 'Specialty Beer' }
-        its(:'style.category.bjcp_category') { should == '23' }
-        its(:'style.category.create_date') { should == '2012-03-26 04:00:04' }
-        its(:'style.category_id') { should == 23 }
-        its(:'style.name') { should == 'Specialty Beer' }
-        its(:'style.simple_url') { should == 'specialty-beer' }
-        its(:'style.create_date') { should == '2012-03-26 04:00:04' }
-        its(:create_date) { should == '2012-03-26 04:00:59' }
-        its(:update_date) { should be_nil }
-      end
+    it 'fetches all of the beers at once' do
+      response.count.should eq 495
     end
+  end
 
-    context '#find' do
-      let(:response) { described_class.new(client).find('vYlBZQ') }
-
-      subject { response }
-
-      its(:status) { should == 'success' }
-
-      context 'data' do
-        subject { response.data }
-
-        it { should have(16).keys }
+  context '#find', :vcr do
+    let(:response) { described_class.new(config).find('99Uj1n') }
 
-        its(:id) { should == 'vYlBZQ' }
-        its(:name) { should == 'Peacemaker' }
-        its(:description) { should == 'Peace is a dangerous thing.  Peacemaker is a west coast style American Pale Ale that uses several hop varieties to produces a unique and bountiful hop aroma with well balanced bitterness.  A special blend of American and European malts make this a very well rounded, characterful beer.' }
-        its(:abv) { should == '5.7' }
-        its(:glassware_id) { should == 5 }
-        its(:available_id) { should == 1 }
-        its(:is_organic) { should == 'N' }
-        its(:status) { should == 'verified' }
-        its(:status_display) { should == 'Verified' }
-        its(:'glass.id') { should == 5 }
-        its(:'glass.name') { should == 'Pint' }
-        its(:'glass.create_date') { should == '2012-03-26 04:00:04' }
-        its(:'available.name') { should == 'Year Round' }
-        its(:'available.description') { should == 'Available year round as a staple beer.' }
-        its(:style_id) { should == 33 }
-        its(:'style.id') { should == 33 }
-        its(:'style.category.id') { should == 10 }
-        its(:'style.category.name') { should == 'American Ale' }
-        its(:'style.category.bjcp_category') { should == '10' }
-        its(:'style.category.create_date') { should == '2012-03-26 04:00:04' }
-        its(:'style.category_id') { should == 10 }
-        its(:'style.name') { should == 'American Pale Ale' }
-        its(:'style.simple_url') { should == 'american-pale-ale' }
-        its(:'style.create_date') { should == '2012-03-26 04:00:04' }
-        its(:create_date) { should == '2012-03-26 04:02:10' }
-        its(:update_date) { should == '2012-03-26 04:38:49' }
-      end
+    it 'fetches only the beer asked for' do
+      response.id.should == '99Uj1n'
     end
   end
 end

data/spec/brewery_db/resources/breweries_spec.rb

@@ -2,64 +2,20 @@
 
 require 'spec_helper'
 
-describe BreweryDB::Resources::Breweries do
-  it_behaves_like 'a resource' do
-    context '#all' do
-      let(:response) { described_class.new(client).all(established: 2006) }
+describe BreweryDB::Resources::Breweries, :resource do
+  context '#all', :vcr do
+    let(:response) { described_class.new(config).all(established: 2006) }
 
-      subject { response }
-
-      its(:current_page) { should == 1 }
-      its(:number_of_pages) { should == 1 }
-      its(:status) { should == 'success' }
-      its(:data) { should be_a(Array) }
-      its(:data) { should have(38).results }
-
-      context 'result' do
-        subject { response.data.first }
-
-        it { should have(9).keys }
-
-        its(:id) { should == 'Qt4daP' }
-        its(:name) { should == '612 Brew LLC' }
-        its(:description) { should == "At 612Brew, the newest beer company in the 612, we want to make your newest favorite beer you’ve never had.\n\nWith our operation moving to a larger location in Uptown, we have the opportunity to make and test out much larger batches of hand crafted beer and present them for you to try. You never know what we may brew next, a Porter, a Pilsner, a Bock or a Belgian. We are excited for each new beer that we make and hope you get excited to try them." }
-        its(:website) { should == 'http://612brew.com/' }
-        its(:established) { should == '2006' }
-        its(:is_organic) { should == 'N' }
-        its(:images) { should be_nil }
-        its(:status) { should == 'verified' }
-        its(:status_display) { should == 'Verified' }
-        its(:create_date) { should == '2012-03-25 04:00:17' }
-        its(:update_date) { should be_nil }
-      end
+    it 'fetches all of the breweries at once' do
+      response.count.should eq 55
     end
+  end
 
-    context '#find' do
-      let(:response) { described_class.new(client).find('d1zSa7') }
-
-      subject { response }
-
-      its(:status) { should == 'success' }
-
-      context 'data' do
-        subject { response.data }
-
-        it { should have(11).keys }
+  context '#find', :vcr do
+    let(:response) { described_class.new(config).find('Idm5Y5') }
 
-        its(:id) { should == 'd1zSa7' }
-        its(:name) { should == 'Lonerider Brewing Company' }
-        its(:description) { should == "We opened our doors on January 23rd, 2009 and since then we have been impressed with the enthusiasm of craft beer aficionados we meet daily. The craft brewing industry is booming and you can find a tremendous variety out there. North Carolina has undoubtedly become the Southern State for beer with Asheville reigning supreme and Raleigh/Durham/CH not far behind. We hope you continue to support the variety and encourage new brewers to experiment with and craft new styles for everybody’s pleasure.\n\n\"Effect change; don't be an audience. Walk your own path, and instead of thinking outside the box, imagine if there was no box.\"" }
-        its(:website) { should == 'http://www.loneriderbeer.com/' }
-        its(:established) { should == '2009' }
-        its(:is_organic) { should == 'N' }
-        its(:'images.icon') { should == 'http://s3.amazonaws.com/brewerydbapi/brewery/d1zSa7/upload_kwaFB7-icon.png' }
-        its(:'images.medium') { should == 'http://s3.amazonaws.com/brewerydbapi/brewery/d1zSa7/upload_kwaFB7-medium.png' }
-        its(:'images.large') { should == 'http://s3.amazonaws.com/brewerydbapi/brewery/d1zSa7/upload_kwaFB7-large.png' }
-        its(:status) { should == 'verified' }
-        its(:status_display) { should == 'Verified' }
-        its(:create_date) { should == '2012-03-25 04:00:30' }
-        its(:update_date) { should == '2012-03-25 04:40:10' }
-      end
+    it 'fetches only the brewery asked for' do
+      response.id.should == 'Idm5Y5'
     end
   end
 end

data/spec/brewery_db/resources/brewery_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper'
+
+describe BreweryDB::Resources::Brewery do
+  context '#beers' do
+    let(:config) { stub }
+    let(:id) { 'KlSsWY' }
+    let(:response) { stub(data: nil) }
+
+    subject { described_class.new(config, id: id) }
+
+    context 'without params' do
+      it 'returns the beers for a brewery' do
+        subject.should_receive(:get).with('brewery/KlSsWY/beers', {}) { response }
+        subject.beers
+      end
+    end
+
+    context 'with params' do
+      let(:params) { stub }
+
+      it 'returns the beers for a brewery with params' do
+        subject.should_receive(:get).with('brewery/KlSsWY/beers', params) { response }
+        subject.beers(params)
+      end
+    end
+  end
+end

data/spec/brewery_db/resources/categories_spec.rb

@@ -2,48 +2,20 @@
 
 require 'spec_helper'
 
-describe BreweryDB::Resources::Categories do
-  it_behaves_like 'a resource' do
-    context '#all' do
-      let(:response) { described_class.new(client).all }
+describe BreweryDB::Resources::Categories, :resource do
+  context '#all', :vcr do
+    let(:response) { described_class.new(config).all }
 
-      subject { response }
-
-      its(:current_page) { should be_nil }
-      its(:number_of_pages) { should be_nil }
-      its(:status) { should == 'success' }
-      its(:data) { should be_a(Array) }
-      its(:data) { should have(28).results }
-
-      context 'result' do
-        subject { response.data.first }
-
-        it { should have(4).keys }
-
-        its(:id) { should == 1 }
-        its(:name) { should == 'Light Lager' }
-        its(:bjcp_category) { should == '1' }
-        its(:create_date) { should == '2012-04-05 04:00:04' }
-      end
+    it 'fetches all of the cagtegories at once' do
+      response.length.should eq 12
     end
+  end
 
-    context '#find' do
-      let(:response) { described_class.new(client).find(1) }
-
-      subject { response }
-
-      its(:status) { should == 'success' }
-
-      context 'data' do
-        subject { response.data }
-
-        it { should have(4).keys }
+  context '#find', :vcr do
+    let(:response) { described_class.new(config).find(1) }
 
-        its(:id) { should == 1 }
-        its(:name) { should == 'Light Lager' }
-        its(:bjcp_category) { should == '1' }
-        its(:create_date) { should == '2012-04-05 04:00:04' }
-      end
+    it 'fetches only the category asked for' do
+      response.id.should == 1
     end
   end
 end

data/spec/brewery_db/resources/glassware_spec.rb

@@ -2,46 +2,20 @@
 
 require 'spec_helper'
 
-describe BreweryDB::Resources::Glassware do
-  it_behaves_like 'a resource' do
-    context '#all' do
-      let(:response) { described_class.new(client).all }
+describe BreweryDB::Resources::Glassware, :resource do
+  context '#all', :vcr do
+    let(:response) { described_class.new(config).all }
 
-      subject { response }
-
-      its(:current_page) { should be_nil }
-      its(:number_of_pages) { should be_nil }
-      its(:status) { should == 'success' }
-      its(:data) { should be_a(Array) }
-      its(:data) { should have(15).results }
-
-      context 'result' do
-        subject { response.data.first }
-
-        it { should have(3).keys }
-
-        its(:id) { should == 1 }
-        its(:name) { should == 'Flute' }
-        its(:create_date) { should == '2012-01-03 02:41:33' }
-      end
+    it 'fetches all of the glassware at once' do
+      response.length.should eq 12
     end
+  end
 
-    context '#find' do
-      let(:response) { described_class.new(client).find(1) }
-
-      subject { response }
-
-      its(:status) { should == 'success' }
-
-      context 'data' do
-        subject { response.data }
-
-        it { should have(3).keys }
+  context '#find', :vcr do
+    let(:response) { described_class.new(config).find(1) }
 
-        its(:id) { should == 1 }
-        its(:name) { should == 'Flute' }
-        its(:create_date) { should == '2012-01-03 02:41:33' }
-      end
+    it 'fetches only the glassware asked for' do
+      response.id.should eq 1
     end
   end
 end