brainzlab 0.1.34 → 0.1.35

data/lib/brainzlab/instrumentation/active_storage.rb

@@ -145,7 +145,7 @@ module BrainzLab
 
           key = payload[:key]
           service = payload[:service]
-          checksum = payload[:checksum]
+          payload[:checksum]
 
           # Record breadcrumb
           if BrainzLab.configuration.reflex_effectively_enabled?
@@ -294,7 +294,7 @@ module BrainzLab
           # Log to Recall - bulk deletes are significant
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.info(
-              "Storage bulk delete by prefix",
+              'Storage bulk delete by prefix',
               prefix: truncate_key(prefix),
               service: service,
               duration_ms: duration
@@ -357,7 +357,7 @@ module BrainzLab
           # Log slow URL generations
           if duration >= 50 && BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Slow storage URL generation",
+              'Slow storage URL generation',
               key: truncate_key(key),
               service: service,
               duration_ms: duration
@@ -411,7 +411,7 @@ module BrainzLab
           key = payload[:key]
           service = payload[:service]
           content_type = payload[:content_type]
-          disposition = payload[:disposition]
+          payload[:disposition]
 
           # Record breadcrumb
           if BrainzLab.configuration.reflex_effectively_enabled?

data/lib/brainzlab/instrumentation/active_support_cache.rb

@@ -109,7 +109,7 @@ module BrainzLab
                 hit_count: hit_count,
                 miss_count: key_count - hit_count,
                 duration_ms: duration,
-                hit_rate: key_count > 0 ? (hit_count.to_f / key_count * 100).round(1) : 0
+                hit_rate: key_count.positive? ? (hit_count.to_f / key_count * 100).round(1) : 0
               }
             )
           end
@@ -476,7 +476,7 @@ module BrainzLab
           # Log pattern deletes
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.info(
-              "Cache pattern delete",
+              'Cache pattern delete',
               pattern: truncate_key(key),
               duration_ms: duration
             )
@@ -502,7 +502,6 @@ module BrainzLab
           duration = event.duration.round(2)
 
           size = payload[:size]
-          key = payload[:key]
 
           # Record breadcrumb
           if BrainzLab.configuration.reflex_effectively_enabled?
@@ -539,7 +538,6 @@ module BrainzLab
           payload = event.payload
           duration = event.duration.round(2)
 
-          key = payload[:key]
           from = payload[:from]
           to = payload[:to]
 
@@ -563,7 +561,7 @@ module BrainzLab
           # Log prune operations
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.info(
-              "Cache pruned",
+              'Cache pruned',
               from: from,
               to: to,
               duration_ms: duration
@@ -593,8 +591,8 @@ module BrainzLab
 
           serializer = payload[:serializer]
           fallback = payload[:fallback]
-          serialized = payload[:serialized]
-          deserialized = payload[:deserialized]
+          payload[:serialized]
+          payload[:deserialized]
 
           # Record breadcrumb - this is a warning as it indicates a format mismatch
           if BrainzLab.configuration.reflex_effectively_enabled?
@@ -613,7 +611,7 @@ module BrainzLab
           # Log to Recall - this is significant for debugging serialization issues
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Message serializer fallback used",
+              'Message serializer fallback used',
               serializer: serializer.to_s,
               fallback: fallback.to_s,
               duration_ms: duration

data/lib/brainzlab/instrumentation/aws.rb

@@ -15,13 +15,16 @@ module BrainzLab
         private
 
         def install_plugin!
-          # AWS SDK v3 uses plugins
-          if defined?(::Aws::Plugins)
-            ::Aws.config[:plugins] ||= []
-            ::Aws.config[:plugins] << BrainzLabPlugin unless ::Aws.config[:plugins].include?(BrainzLabPlugin)
-          end
-
-          # Also hook into Seahorse for lower-level tracking
+          # Registered through Seahorse only. Every AWS client inherits from
+          # Seahorse::Client::Base, so this one hook covers S3, SQS and the rest,
+          # on every version of the SDK.
+          #
+          # There used to be a second registration through Aws.config[:plugins].
+          # That option only exists on newer aws-sdk-core; on older ones it does
+          # not degrade, it makes *every* client fail to construct with
+          # "invalid configuration option :plugins" — so an app pinned to an
+          # older SDK could not talk to S3 at all. It bought nothing either way,
+          # since the handler below is the same handler.
           return unless defined?(::Seahorse::Client::Base)
 
           install_seahorse_handler!

data/lib/brainzlab/instrumentation/grape.rb

@@ -203,7 +203,9 @@ module BrainzLab
         end
 
         def safe_dig(routing_args, key)
-          routing_args.respond_to?(:dig) ? routing_args.dig(key) : nil
+          return nil unless routing_args.respond_to?(:dig)
+
+          routing_args[key]
         rescue StandardError
           nil
         end

data/lib/brainzlab/instrumentation/rails_deprecation.rb

@@ -60,7 +60,7 @@ module BrainzLab
           # Log to Recall for tracking
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Rails deprecation warning",
+              'Rails deprecation warning',
               message: truncate_message(message, 500),
               gem_name: gem_name,
               deprecation_horizon: deprecation_horizon,

data/lib/brainzlab/instrumentation/railties.rb

@@ -4,8 +4,8 @@ module BrainzLab
   module Instrumentation
     class Railties
       # Thresholds for slow initializers (in milliseconds)
-      SLOW_INITIALIZER_THRESHOLD = 100   # 100ms
-      VERY_SLOW_INITIALIZER_THRESHOLD = 500  # 500ms
+      SLOW_INITIALIZER_THRESHOLD = 100 # 100ms
+      VERY_SLOW_INITIALIZER_THRESHOLD = 500 # 500ms
 
       class << self
         def install!

data/lib/brainzlab/nerve/client.rb

@@ -212,9 +212,9 @@ module BrainzLab
         BrainzLab.debug_log("[Nerve::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Nerve', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(structured_error, { service: 'Nerve', operation: operation })
       end
 
       def handle_response_error(response, operation)
@@ -224,9 +224,7 @@ module BrainzLab
         BrainzLab.debug_log("[Nerve::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Nerve', operation: operation })
-        end
+        @config.on_error&.call(structured_error, { service: 'Nerve', operation: operation })
 
         structured_error
       end

data/lib/brainzlab/pulse/client.rb

@@ -207,7 +207,7 @@ module BrainzLab
       end
 
       def handle_error(error, context: {})
-        log_error("#{error.message}")
+        log_error(error.message.to_s)
 
         # Call on_error callback if configured
         return unless @config.on_error

data/lib/brainzlab/pulse.rb

@@ -119,7 +119,11 @@ module BrainzLab
 
         # Parse timestamp or use current time
         started_at = if timestamp
-                       Time.parse(timestamp) rescue Time.now.utc
+                       begin
+                         Time.parse(timestamp)
+                       rescue StandardError
+                         Time.now.utc
+                       end
                      else
                        Time.now.utc
                      end

data/lib/brainzlab/rails/railtie.rb

@@ -33,9 +33,7 @@ module BrainzLab
         # Add request context middleware. Gated on `enabled` so the kill switch
         # (BRAINZLAB_SDK_ENABLED=false) fully removes it — it previously loaded
         # unconditionally, so disabling didn't stop its session interference.
-        if BrainzLab.configuration.enabled
-          app.middleware.insert_after ActionDispatch::RequestId, BrainzLab::Rails::Middleware
-        end
+        app.middleware.insert_after ActionDispatch::RequestId, BrainzLab::Rails::Middleware if BrainzLab.configuration.enabled
 
         # Add DevTools middlewares if enabled
         if BrainzLab.configuration.devtools_enabled

data/lib/brainzlab/reflex/client.rb

@@ -125,7 +125,7 @@ module BrainzLab
       end
 
       def handle_error(error, context: {})
-        log_error("#{error.message}")
+        log_error(error.message.to_s)
 
         # Call on_error callback if configured
         return unless @config.on_error

data/lib/brainzlab/sentinel/client.rb

@@ -213,9 +213,9 @@ module BrainzLab
         BrainzLab.debug_log("[Sentinel::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Sentinel', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(structured_error, { service: 'Sentinel', operation: operation })
       end
 
       def handle_response_error(response, operation)
@@ -225,9 +225,7 @@ module BrainzLab
         BrainzLab.debug_log("[Sentinel::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Sentinel', operation: operation })
-        end
+        @config.on_error&.call(structured_error, { service: 'Sentinel', operation: operation })
 
         structured_error
       end

data/lib/brainzlab/synapse/client.rb

@@ -285,9 +285,9 @@ module BrainzLab
         BrainzLab.debug_log("[Synapse::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Synapse', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(structured_error, { service: 'Synapse', operation: operation })
       end
 
       def handle_response_error(response, operation)
@@ -297,9 +297,7 @@ module BrainzLab
         BrainzLab.debug_log("[Synapse::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Synapse', operation: operation })
-        end
+        @config.on_error&.call(structured_error, { service: 'Synapse', operation: operation })
 
         structured_error
       end

data/lib/brainzlab/testing/event_store.rb

@@ -187,9 +187,9 @@ module BrainzLab
       def error_captured?(error_class = nil, message: nil, context: nil)
         @mutex.synchronize do
           @errors.any? do |error|
-            if error_class
-              next false unless error[:error_class] == error_class.to_s ||
-                                (error_class.is_a?(Class) && error[:exception].is_a?(error_class))
+            if error_class && !(error[:error_class] == error_class.to_s ||
+                                (error_class.is_a?(Class) && error[:exception].is_a?(error_class)))
+              next false
             end
 
             if message

data/lib/brainzlab/testing/matchers.rb

@@ -112,10 +112,10 @@ module BrainzLab
             "expected event '#{@event_name}' to have been tracked, but no such event was found.\n" \
               "Tracked events: #{BrainzLab::Testing.event_store.events.map { |e| e[:name] }.inspect}"
           else
-            "expected event '#{@event_name}' to have been tracked with properties:\n" \
-              "  #{@expected_properties.inspect}\n" \
-              "but was tracked with:\n" \
-              "  #{actual_events.map { |e| e[:properties] }.inspect}"
+            "expected event '#{@event_name}' to have been tracked with properties:\n  " \
+              "#{@expected_properties.inspect}\n" \
+              "but was tracked with:\n  " \
+              "#{actual_events.map { |e| e[:properties] }.inspect}"
           end
         end
 

data/lib/brainzlab/testing.rb

@@ -198,16 +198,18 @@ module BrainzLab
         end
 
         # Stub distributed tracing methods
-        BrainzLab::Pulse.define_singleton_method(:inject) do |headers, **opts|
+        BrainzLab::Pulse.define_singleton_method(:inject) do |headers, **_opts|
           headers['traceparent'] = '00-test-trace-id-12345-test-span-id-67890-01'
           headers
         end
 
         BrainzLab::Pulse.define_singleton_method(:extract) do |headers|
+          return unless headers['traceparent']
+
           BrainzLab::Pulse::Propagation::Context.new(
             trace_id: 'test-trace-id-12345',
             span_id: 'test-span-id-67890'
-          ) if headers['traceparent']
+          )
         end
 
         BrainzLab::Pulse.define_singleton_method(:extract!) do |headers|
@@ -304,7 +306,7 @@ module BrainzLab
         BrainzLab::Cortex.define_singleton_method(:read) { |*| nil }
         BrainzLab::Cortex.define_singleton_method(:write) { |*| true }
         BrainzLab::Cortex.define_singleton_method(:delete) { |*| true }
-        BrainzLab::Cortex.define_singleton_method(:fetch) { |key, **opts, &block| block&.call }
+        BrainzLab::Cortex.define_singleton_method(:fetch) { |_key, **_opts, &block| block&.call }
       end
 
       def stub_vault!

data/lib/brainzlab/vault/client.rb

@@ -193,9 +193,9 @@ module BrainzLab
         BrainzLab.debug_log("[Vault::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Vault', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(structured_error, { service: 'Vault', operation: operation })
       end
 
       def handle_response_error(response, operation)
@@ -205,9 +205,7 @@ module BrainzLab
         BrainzLab.debug_log("[Vault::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Vault', operation: operation })
-        end
+        @config.on_error&.call(structured_error, { service: 'Vault', operation: operation })
 
         structured_error
       end

data/lib/brainzlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrainzLab
-  VERSION = '0.1.34'
+  VERSION = '0.1.35'
 end

data/lib/brainzlab/vision/client.rb

@@ -154,9 +154,9 @@ module BrainzLab
         BrainzLab.debug_log("[Vision::Client] #{operation} failed: #{error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(error, { service: 'Vision', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(error, { service: 'Vision', operation: operation })
       end
 
       def auth_key

data/lib/fluyenta-ruby.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require_relative 'brainzlab'
+require_relative 'brainzlab'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainzlab
 version: !ruby/object:Gem::Version
-  version: 0.1.34
+  version: 0.1.35
 platform: ruby
 authors:
 - BrainzLab