brainzlab 0.1.34 → 0.1.35

data/lib/brainzlab/cortex/client.rb

@@ -184,9 +184,9 @@ module BrainzLab
         BrainzLab.debug_log("[Cortex::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Cortex', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(structured_error, { service: 'Cortex', operation: operation })
       end
 
       def handle_response_error(response, operation)
@@ -196,9 +196,7 @@ module BrainzLab
         BrainzLab.debug_log("[Cortex::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Cortex', operation: operation })
-        end
+        @config.on_error&.call(structured_error, { service: 'Cortex', operation: operation })
 
         structured_error
       end

data/lib/brainzlab/debug.rb

@@ -172,7 +172,7 @@ module BrainzLab
 
       def format_message(message, level:, **data)
         timestamp = format_timestamp
-        prefix = colorize("[BrainzLab]", :bold, :blue)
+        prefix = colorize('[BrainzLab]', :bold, :blue)
         level_badge = format_level(level)
         data_str = data.empty? ? '' : " #{format_data(data)}"
 
@@ -181,8 +181,8 @@ module BrainzLab
 
       def format_arrow_message(direction, service, message, level: :info)
         timestamp = format_timestamp
-        prefix = colorize("[BrainzLab]", :bold, :blue)
-        arrow = direction == :out ? colorize("->", :cyan) : colorize("<-", :green)
+        prefix = colorize('[BrainzLab]', :bold, :blue)
+        arrow = direction == :out ? colorize('->', :cyan) : colorize('<-', :green)
         service_name = colorize(service.to_s.capitalize, :magenta)
 
         "#{prefix} #{timestamp} #{arrow} #{service_name} #{message}"
@@ -242,7 +242,7 @@ module BrainzLab
         other_keys = data.keys.reject { |k| %i[message timestamp level].include?(k.to_sym) }
         if other_keys.any?
           key_summary = other_keys.take(3).map { |k| "#{k}: #{format_value(data[k])}" }.join(', ')
-          key_summary += ", ..." if other_keys.length > 3
+          key_summary += ', ...' if other_keys.length > 3
           summary_parts << "(#{key_summary})"
         end
 
@@ -253,7 +253,7 @@ module BrainzLab
         return '' unless str
 
         str = str.to_s
-        str.length > length ? "#{str[0..length - 4]}..." : str
+        str.length > length ? "#{str[0..(length - 4)]}..." : str
       end
 
       def status_message(status)
@@ -293,7 +293,7 @@ module BrainzLab
           else config.logger.info(strip_colors(output))
           end
         else
-          $stderr.puts output
+          warn output
         end
       end
 

data/lib/brainzlab/dendrite/client.rb

@@ -227,9 +227,9 @@ module BrainzLab
         BrainzLab.debug_log("[Dendrite::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Dendrite', operation: operation })
-        end
+        return unless @config.on_error
+
+        @config.on_error.call(structured_error, { service: 'Dendrite', operation: operation })
       end
 
       def handle_response_error(response, operation)
@@ -239,9 +239,7 @@ module BrainzLab
         BrainzLab.debug_log("[Dendrite::Client] #{operation} failed: #{structured_error.message}")
 
         # Call on_error callback if configured
-        if @config.on_error
-          @config.on_error.call(structured_error, { service: 'Dendrite', operation: operation })
-        end
+        @config.on_error&.call(structured_error, { service: 'Dendrite', operation: operation })
 
         structured_error
       end

data/lib/brainzlab/development/logger.rb

@@ -82,8 +82,8 @@ module BrainzLab
         when 'log'
           level = payload[:level]&.to_sym
           level_color = COLORS[level] || COLORS[:info]
-          msg = "#{colorize("[#{level&.upcase}]", level_color)} #{payload[:message]}"
-          msg
+          "#{colorize("[#{level&.upcase}]", level_color)} #{payload[:message]}"
+
         when 'error'
           "#{payload[:error_class]}: #{payload[:message]}"
         when 'trace'

data/lib/brainzlab/development/store.rb

@@ -89,10 +89,8 @@ module BrainzLab
       private
 
       def db
-        @db ||= begin
-          SQLite3::Database.new(@db_path).tap do |database|
-            database.results_as_hash = false
-          end
+        @db ||= SQLite3::Database.new(@db_path).tap do |database|
+          database.results_as_hash = false
         end
       end
 

data/lib/brainzlab/devtools/middleware/error_page.rb

@@ -93,7 +93,7 @@ module BrainzLab
              .gsub(' ', ' ')
         end
 
-        def collect_debug_data_from_info(env, info, status = 500)
+        def collect_debug_data_from_info(env, info, _status = 500)
           context = defined?(BrainzLab::Context) ? BrainzLab::Context.current : nil
           collector_data = Data::Collector.get_request_data
 

data/lib/brainzlab/errors.rb

@@ -53,13 +53,6 @@ module BrainzLab
       super(message)
     end
 
-    # Format the error as a detailed string with hints and documentation links.
-    #
-    # @return [String] Formatted error message
-    def to_s
-      super
-    end
-
     # Return a detailed formatted version of the error with hints and documentation links.
     # Use this method when you want the full structured output.
     #
@@ -70,12 +63,12 @@ module BrainzLab
 
       parts = ["#{self.class.name}: #{base_msg}"]
 
-      parts << "" << "Hint: #{hint}" if hint
+      parts << '' << "Hint: #{hint}" if hint
       parts << "Docs: #{docs_url}" if docs_url
       parts << "Code: #{code}" if code
 
       if context && !context.empty?
-        parts << "" << "Context:"
+        parts << '' << 'Context:'
         context.each do |key, value|
           parts << "  #{key}: #{value}"
         end
@@ -124,7 +117,7 @@ module BrainzLab
     def initialize(message = nil, hint: nil, docs_url: nil, code: nil, context: nil)
       docs_url ||= "#{DOCS_BASE_URL}/sdk/ruby/configuration"
       code ||= 'configuration_error'
-      super(message, hint: hint, docs_url: docs_url, code: code, context: context)
+      super
     end
   end
 
@@ -141,7 +134,7 @@ module BrainzLab
     def initialize(message = nil, hint: nil, docs_url: nil, code: nil, context: nil)
       docs_url ||= "#{DOCS_BASE_URL}/sdk/ruby/authentication"
       code ||= 'authentication_error'
-      super(message, hint: hint, docs_url: docs_url, code: code, context: context)
+      super
     end
   end
 
@@ -158,7 +151,7 @@ module BrainzLab
     def initialize(message = nil, hint: nil, docs_url: nil, code: nil, context: nil)
       docs_url ||= "#{DOCS_BASE_URL}/sdk/ruby/troubleshooting#connection-issues"
       code ||= 'connection_error'
-      super(message, hint: hint, docs_url: docs_url, code: code, context: context)
+      super
     end
   end
 

data/lib/brainzlab/instrumentation/action_cable.rb

@@ -91,7 +91,7 @@ module BrainzLab
           duration = event.duration.round(2)
 
           channel_class = payload[:channel_class]
-          data = payload[:data]
+          payload[:data]
           via = payload[:via]
 
           # Record breadcrumb
@@ -187,7 +187,7 @@ module BrainzLab
           # Log rejection to Recall
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "ActionCable subscription rejected",
+              'ActionCable subscription rejected',
               channel: channel_class
             )
           end
@@ -210,7 +210,7 @@ module BrainzLab
           duration = event.duration.round(2)
 
           broadcasting = payload[:broadcasting]
-          message = payload[:message]
+          payload[:message]
           coder = payload[:coder]
 
           # Record breadcrumb
@@ -236,7 +236,7 @@ module BrainzLab
         # ============================================
         # Span Recording Helpers
         # ============================================
-        def record_action_span(event, channel_class, action, duration, data)
+        def record_action_span(event, channel_class, action, duration, _data)
           return unless BrainzLab.configuration.pulse_effectively_enabled?
 
           tracer = BrainzLab::Pulse.tracer

data/lib/brainzlab/instrumentation/action_controller.rb

@@ -58,7 +58,7 @@ module BrainzLab
           method = payload[:method]
           path = payload[:path]
           format = payload[:format]
-          params = payload[:params]
+          payload[:params]
 
           # Skip health check endpoints
           return if excluded_path?(path)
@@ -99,12 +99,12 @@ module BrainzLab
           payload = event.payload
           duration = event.duration.round(2)
 
-          controller = payload[:controller]
-          action = payload[:action]
+          payload[:controller]
+          payload[:action]
           status = payload[:status]
-          method = payload[:method]
+          payload[:method]
           path = payload[:path]
-          format = payload[:format]
+          payload[:format]
 
           # Skip health check endpoints
           return if excluded_path?(path)
@@ -157,7 +157,7 @@ module BrainzLab
           )
         end
 
-        def record_request_trace(event, payload, duration)
+        def record_request_trace(event, payload, _duration)
           # Only record if Pulse is enabled and no trace is already active
           # (middleware should handle this, but this is a fallback)
           return unless BrainzLab.configuration.pulse_effectively_enabled?
@@ -265,7 +265,7 @@ module BrainzLab
           # Also log to Recall - halted callbacks can indicate auth issues
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.info(
-              "Request halted by before_action filter",
+              'Request halted by before_action filter',
               filter: filter.to_s
             )
           end
@@ -307,7 +307,7 @@ module BrainzLab
           # Log to Recall - this is a security-relevant event
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Unpermitted parameters rejected",
+              'Unpermitted parameters rejected',
               unpermitted_keys: keys,
               controller: context[:controller],
               action: context[:action]
@@ -362,7 +362,7 @@ module BrainzLab
           filename = payload[:filename]
 
           BrainzLab::Reflex.add_breadcrumb(
-            "Sending data#{filename ? ": #{filename}" : ''}",
+            "Sending data#{": #{filename}" if filename}",
             category: 'http.data',
             level: :info,
             data: {
@@ -391,7 +391,7 @@ module BrainzLab
           type = payload[:type]
 
           BrainzLab::Reflex.add_breadcrumb(
-            "Streaming#{filename ? ": #{filename}" : ''}",
+            "Streaming#{": #{filename}" if filename}",
             category: 'http.stream',
             level: :info,
             data: {
@@ -597,7 +597,7 @@ module BrainzLab
           # Add breadcrumb
           if BrainzLab.configuration.reflex_effectively_enabled?
             BrainzLab::Reflex.add_breadcrumb(
-              "Rate limit triggered",
+              'Rate limit triggered',
               category: 'security.rate_limit',
               level: :warning,
               data: {
@@ -609,7 +609,7 @@ module BrainzLab
           # Log to Recall - rate limiting is security-relevant
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Rate limit triggered",
+              'Rate limit triggered',
               path: payload[:request]&.path,
               ip: payload[:request]&.remote_ip
             )

data/lib/brainzlab/instrumentation/action_dispatch.rb

@@ -100,7 +100,7 @@ module BrainzLab
 
           status = payload[:status]
           location = payload[:location]
-          request = payload[:request]
+          payload[:request]
 
           # Record breadcrumb
           if BrainzLab.configuration.reflex_effectively_enabled?

data/lib/brainzlab/instrumentation/action_mailbox.rb

@@ -4,8 +4,8 @@ module BrainzLab
   module Instrumentation
     class ActionMailbox
       # Thresholds for slow processing (in milliseconds)
-      SLOW_PROCESSING_THRESHOLD = 1000    # 1 second
-      VERY_SLOW_PROCESSING_THRESHOLD = 5000  # 5 seconds
+      SLOW_PROCESSING_THRESHOLD = 1000 # 1 second
+      VERY_SLOW_PROCESSING_THRESHOLD = 5000 # 5 seconds
 
       class << self
         def install!
@@ -102,7 +102,7 @@ module BrainzLab
             started_at: event.time,
             ended_at: event.end,
             duration_ms: duration,
-            error: status == 'bounced' || status == 'failed',
+            error: %w[bounced failed].include?(status),
             data: {
               'mailbox.class' => mailbox_class,
               'mailbox.email_id' => email_id,
@@ -123,7 +123,7 @@ module BrainzLab
           return unless BrainzLab.configuration.recall_effectively_enabled?
 
           # Determine log level based on status and duration
-          if status == 'bounced' || status == 'failed'
+          if %w[bounced failed].include?(status)
             BrainzLab::Recall.error(
               "Mailbox processing failed: #{mailbox_class}",
               mailbox: mailbox_class,
@@ -154,9 +154,7 @@ module BrainzLab
         def extract_from(inbound_email)
           return nil unless inbound_email
 
-          if inbound_email.respond_to?(:mail) && inbound_email.mail.respond_to?(:from)
-            Array(inbound_email.mail.from).first
-          end
+          Array(inbound_email.mail.from).first if inbound_email.respond_to?(:mail) && inbound_email.mail.respond_to?(:from)
         rescue StandardError
           nil
         end
@@ -164,9 +162,7 @@ module BrainzLab
         def extract_to(inbound_email)
           return nil unless inbound_email
 
-          if inbound_email.respond_to?(:mail) && inbound_email.mail.respond_to?(:to)
-            Array(inbound_email.mail.to).first
-          end
+          Array(inbound_email.mail.to).first if inbound_email.respond_to?(:mail) && inbound_email.mail.respond_to?(:to)
         rescue StandardError
           nil
         end
@@ -174,9 +170,7 @@ module BrainzLab
         def extract_subject(inbound_email)
           return nil unless inbound_email
 
-          if inbound_email.respond_to?(:mail) && inbound_email.mail.respond_to?(:subject)
-            inbound_email.mail.subject
-          end
+          inbound_email.mail.subject if inbound_email.respond_to?(:mail) && inbound_email.mail.respond_to?(:subject)
         rescue StandardError
           nil
         end

data/lib/brainzlab/instrumentation/action_view.rb

@@ -115,17 +115,13 @@ module BrainzLab
           template_name = extract_template_name(identifier)
 
           # Add breadcrumb for significant collections
-          if count >= COLLECTION_TRACKING_THRESHOLD || duration >= BrainzLab.configuration.slow_render_threshold
-            record_collection_breadcrumb(template_name, duration, count, cache_hits)
-          end
+          record_collection_breadcrumb(template_name, duration, count, cache_hits) if count >= COLLECTION_TRACKING_THRESHOLD || duration >= BrainzLab.configuration.slow_render_threshold
 
           # Add span to Pulse
           record_collection_span(event, template_name, duration, count, cache_hits)
 
           # Log slow collection renders to Recall
-          if duration >= BrainzLab.configuration.slow_render_threshold
-            log_slow_collection_render(template_name, duration, count, cache_hits)
-          end
+          log_slow_collection_render(template_name, duration, count, cache_hits) if duration >= BrainzLab.configuration.slow_render_threshold
 
           # Track potential N+1 view pattern (many partials rendered)
           track_collection_performance(template_name, count, duration) if count >= 50
@@ -244,7 +240,7 @@ module BrainzLab
                   else :error
                   end
 
-          cache_info = cache_hits > 0 ? " (#{cache_hits}/#{count} cached)" : ""
+          cache_info = cache_hits.positive? ? " (#{cache_hits}/#{count} cached)" : ''
 
           BrainzLab::Reflex.add_breadcrumb(
             "Render collection: #{template_name} x#{count}#{cache_info} (#{duration}ms)",
@@ -255,7 +251,7 @@ module BrainzLab
               count: count,
               cache_hits: cache_hits,
               duration_ms: duration,
-              avg_per_item_ms: count > 0 ? (duration / count).round(2) : nil
+              avg_per_item_ms: count.positive? ? (duration / count).round(2) : nil
             }.compact
           )
         end
@@ -279,7 +275,7 @@ module BrainzLab
               'view.template' => template_name,
               'view.count' => count,
               'view.cache_hits' => cache_hits,
-              'view.avg_per_item_ms' => count > 0 ? (duration / count).round(2) : nil
+              'view.avg_per_item_ms' => count.positive? ? (duration / count).round(2) : nil
             }.compact
           }
 
@@ -317,41 +313,41 @@ module BrainzLab
             count: count,
             cache_hits: cache_hits,
             duration_ms: duration,
-            avg_per_item_ms: count > 0 ? (duration / count).round(2) : nil,
+            avg_per_item_ms: count.positive? ? (duration / count).round(2) : nil,
             threshold_exceeded: duration >= BrainzLab.configuration.very_slow_render_threshold ? 'critical' : 'warning'
           )
         end
 
         def track_collection_performance(template_name, count, duration)
-          avg_per_item = count > 0 ? (duration / count).round(2) : 0
+          avg_per_item = count.positive? ? (duration / count).round(2) : 0
 
           # If average time per item is high, this might indicate N+1 in the partial
-          if avg_per_item > 5 # More than 5ms per item is suspicious
-            if BrainzLab.configuration.reflex_effectively_enabled?
-              BrainzLab::Reflex.add_breadcrumb(
-                "Slow collection items: #{template_name} (#{avg_per_item}ms/item)",
-                category: 'view.performance',
-                level: :warning,
-                data: {
-                  template: template_name,
-                  count: count,
-                  duration_ms: duration,
-                  avg_per_item_ms: avg_per_item,
-                  suggestion: 'Consider caching, eager loading, or optimizing the partial'
-                }
-              )
-            end
-
-            if BrainzLab.configuration.recall_effectively_enabled?
-              BrainzLab::Recall.warn(
-                "Collection partial may have N+1 or performance issue",
+          return unless avg_per_item > 5 # More than 5ms per item is suspicious
+
+          if BrainzLab.configuration.reflex_effectively_enabled?
+            BrainzLab::Reflex.add_breadcrumb(
+              "Slow collection items: #{template_name} (#{avg_per_item}ms/item)",
+              category: 'view.performance',
+              level: :warning,
+              data: {
                 template: template_name,
                 count: count,
                 duration_ms: duration,
-                avg_per_item_ms: avg_per_item
-              )
-            end
+                avg_per_item_ms: avg_per_item,
+                suggestion: 'Consider caching, eager loading, or optimizing the partial'
+              }
+            )
           end
+
+          return unless BrainzLab.configuration.recall_effectively_enabled?
+
+          BrainzLab::Recall.warn(
+            'Collection partial may have N+1 or performance issue',
+            template: template_name,
+            count: count,
+            duration_ms: duration,
+            avg_per_item_ms: avg_per_item
+          )
         end
 
         # ============================================

data/lib/brainzlab/instrumentation/active_job.rb

@@ -4,8 +4,8 @@ module BrainzLab
   module Instrumentation
     class ActiveJob
       # Thresholds for slow job detection (in milliseconds)
-      SLOW_JOB_THRESHOLD = 5000    # 5 seconds
-      VERY_SLOW_JOB_THRESHOLD = 30_000  # 30 seconds
+      SLOW_JOB_THRESHOLD = 5000 # 5 seconds
+      VERY_SLOW_JOB_THRESHOLD = 30_000 # 30 seconds
 
       class << self
         def install!
@@ -95,7 +95,7 @@ module BrainzLab
             scheduled_in = scheduled_at ? ((scheduled_at - Time.now) / 60).round(1) : nil
 
             BrainzLab::Reflex.add_breadcrumb(
-              "Job scheduled: #{job_class}#{scheduled_in ? " (in #{scheduled_in}min)" : ''}",
+              "Job scheduled: #{job_class}#{" (in #{scheduled_in}min)" if scheduled_in}",
               category: 'job.schedule',
               level: :info,
               data: {
@@ -242,14 +242,12 @@ module BrainzLab
 
           # Calculate queue wait time if enqueued_at is available
           queue_wait_ms = nil
-          if job.enqueued_at
-            queue_wait_ms = ((event.time - job.enqueued_at) * 1000).round(2)
-          end
+          queue_wait_ms = ((event.time - job.enqueued_at) * 1000).round(2) if job.enqueued_at
 
           # Record breadcrumb
           if BrainzLab.configuration.reflex_effectively_enabled?
             BrainzLab::Reflex.add_breadcrumb(
-              "Job started: #{job_class}#{executions > 1 ? " (attempt #{executions})" : ''}",
+              "Job started: #{job_class}#{" (attempt #{executions})" if executions > 1}",
               category: 'job.start',
               level: :info,
               data: {
@@ -293,9 +291,7 @@ module BrainzLab
           job_starts = Thread.current[:brainzlab_job_starts] || {}
           start_info = job_starts.delete(job_id) || {}
           queue_wait_ms = nil
-          if start_info[:enqueued_at]
-            queue_wait_ms = ((start_info[:started_at] - start_info[:enqueued_at]) * 1000).round(2)
-          end
+          queue_wait_ms = ((start_info[:started_at] - start_info[:enqueued_at]) * 1000).round(2) if start_info[:enqueued_at]
 
           # Determine level based on outcome and duration
           level = if exception

data/lib/brainzlab/instrumentation/active_record.rb

@@ -80,7 +80,6 @@ module BrainzLab
         end
 
         def handle_sql_event(event)
-          payload = event.payload
           duration = event.duration.round(2)
 
           # Record breadcrumb for Reflex (enhanced)
@@ -218,14 +217,12 @@ module BrainzLab
           tracker[:count] += 1
 
           # Store sample queries (limited)
-          if tracker[:queries].size < 3
-            tracker[:queries] << truncate_sql(sql, 200)
-          end
+          tracker[:queries] << truncate_sql(sql, 200) if tracker[:queries].size < 3
 
           # Detect N+1 pattern
-          if tracker[:count] == BrainzLab.configuration.n_plus_one_threshold
-            report_n_plus_one(table, tracker)
-          end
+          return unless tracker[:count] == BrainzLab.configuration.n_plus_one_threshold
+
+          report_n_plus_one(table, tracker)
         end
 
         def report_n_plus_one(table, tracker)
@@ -240,14 +237,14 @@ module BrainzLab
             }
           )
 
-          if BrainzLab.configuration.recall_effectively_enabled?
-            BrainzLab::Recall.warn(
-              "Potential N+1 query detected",
-              table: table,
-              query_count: tracker[:count],
-              sample_queries: tracker[:queries]
-            )
-          end
+          return unless BrainzLab.configuration.recall_effectively_enabled?
+
+          BrainzLab::Recall.warn(
+            'Potential N+1 query detected',
+            table: table,
+            query_count: tracker[:count],
+            sample_queries: tracker[:queries]
+          )
         end
 
         def clear_n_plus_one_tracker!
@@ -332,8 +329,8 @@ module BrainzLab
           transaction = event.payload[:transaction]
           return unless transaction
 
-          Thread.current[:brainzlab_transaction_starts] ||= {}
-          Thread.current[:brainzlab_transaction_starts][transaction.object_id] = event.time
+          Thread.current[:brainzlab_transaction_starts] ||= {}.compare_by_identity
+          Thread.current[:brainzlab_transaction_starts][transaction] = event.time
         rescue StandardError => e
           BrainzLab.debug_log("ActiveRecord transaction start instrumentation failed: #{e.message}")
         end
@@ -344,8 +341,8 @@ module BrainzLab
           outcome = payload[:outcome] # :commit, :rollback, :restart, :incomplete
 
           # Calculate duration from stored start time
-          starts = Thread.current[:brainzlab_transaction_starts] || {}
-          start_time = starts.delete(transaction&.object_id) || event.time
+          starts = Thread.current[:brainzlab_transaction_starts] || {}.compare_by_identity
+          start_time = starts.delete(transaction) || event.time
           duration = ((event.end - start_time) * 1000).round(2)
 
           connection_name = extract_connection_name(payload[:connection])
@@ -440,7 +437,7 @@ module BrainzLab
           # Log to Recall
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Strict loading violation detected",
+              'Strict loading violation detected',
               owner_class: owner_class,
               association: association_name.to_s,
               message: "Attempted to lazily load #{association_name} on #{owner_class} with strict_loading enabled"
@@ -485,7 +482,7 @@ module BrainzLab
           # Log to Recall
           if BrainzLab.configuration.recall_effectively_enabled?
             BrainzLab::Recall.warn(
-              "Deprecated association accessed",
+              'Deprecated association accessed',
               owner_class: owner_class,
               association: association_name.to_s,
               message: message
@@ -521,9 +518,9 @@ module BrainzLab
           # Handles: SELECT ... FROM table_name, SELECT ... FROM "table_name", etc.
           return nil unless sql =~ /\ASELECT/i
 
-          if sql =~ /FROM\s+["'`]?(\w+)["'`]?/i
-            ::Regexp.last_match(1)
-          end
+          return unless sql =~ /FROM\s+["'`]?(\w+)["'`]?/i
+
+          ::Regexp.last_match(1)
         end
 
         def skip_query?(payload)