brainzlab 0.1.2 → 0.1.3

data/lib/brainzlab/instrumentation/graphql.rb

@@ -13,14 +13,14 @@ module BrainzLab
           # For GraphQL Ruby 2.0+
           if ::GraphQL::Schema.respond_to?(:trace_with)
             # Will be installed per-schema via BrainzLab::GraphQL::Tracer
-            BrainzLab.debug_log("GraphQL tracer available - add `trace_with BrainzLab::Instrumentation::GraphQLInstrumentation::Tracer` to your schema")
+            BrainzLab.debug_log('GraphQL tracer available - add `trace_with BrainzLab::Instrumentation::GraphQLInstrumentation::Tracer` to your schema')
           end
 
           # Subscribe to ActiveSupport notifications if available
           install_notifications!
 
           @installed = true
-          BrainzLab.debug_log("GraphQL instrumentation installed")
+          BrainzLab.debug_log('GraphQL instrumentation installed')
         end
 
         def installed?
@@ -35,17 +35,17 @@ module BrainzLab
 
         def install_notifications!
           # GraphQL-ruby emits ActiveSupport notifications
-          ActiveSupport::Notifications.subscribe("execute.graphql") do |*args|
+          ActiveSupport::Notifications.subscribe('execute.graphql') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             record_execution(event)
           end
 
-          ActiveSupport::Notifications.subscribe("analyze.graphql") do |*args|
+          ActiveSupport::Notifications.subscribe('analyze.graphql') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             record_analyze(event)
           end
 
-          ActiveSupport::Notifications.subscribe("validate.graphql") do |*args|
+          ActiveSupport::Notifications.subscribe('validate.graphql') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             record_validate(event)
           end
@@ -56,15 +56,15 @@ module BrainzLab
         def record_execution(event)
           payload = event.payload
           query = payload[:query]
-          operation_name = query&.operation_name || "anonymous"
-          operation_type = query&.selected_operation&.operation_type || "query"
+          operation_name = query&.operation_name || 'anonymous'
+          operation_type = query&.selected_operation&.operation_type || 'query'
           duration_ms = event.duration.round(2)
 
           # Add breadcrumb
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "GraphQL #{operation_type} #{operation_name}",
-              category: "graphql.execute",
+              category: 'graphql.execute',
               level: payload[:errors]&.any? ? :error : :info,
               data: {
                 operation_name: operation_name,
@@ -78,7 +78,7 @@ module BrainzLab
           # Record span
           record_span(
             name: "GraphQL #{operation_type} #{operation_name}",
-            kind: "graphql",
+            kind: 'graphql',
             duration_ms: duration_ms,
             started_at: event.time,
             ended_at: event.end,
@@ -97,12 +97,12 @@ module BrainzLab
 
         def record_analyze(event)
           record_span(
-            name: "GraphQL analyze",
-            kind: "graphql",
+            name: 'GraphQL analyze',
+            kind: 'graphql',
             duration_ms: event.duration.round(2),
             started_at: event.time,
             ended_at: event.end,
-            data: { phase: "analyze" }
+            data: { phase: 'analyze' }
           )
         rescue StandardError => e
           BrainzLab.debug_log("GraphQL analyze recording failed: #{e.message}")
@@ -110,12 +110,12 @@ module BrainzLab
 
         def record_validate(event)
           record_span(
-            name: "GraphQL validate",
-            kind: "graphql",
+            name: 'GraphQL validate',
+            kind: 'graphql',
             duration_ms: event.duration.round(2),
             started_at: event.time,
             ended_at: event.end,
-            data: { phase: "validate" }
+            data: { phase: 'validate' }
           )
         rescue StandardError => e
           BrainzLab.debug_log("GraphQL validate recording failed: #{e.message}")
@@ -139,6 +139,7 @@ module BrainzLab
 
         def truncate_query(query)
           return nil unless query
+
           query.to_s[0, 2000]
         end
 
@@ -148,7 +149,7 @@ module BrainzLab
           scrub_fields = BrainzLab.configuration.scrub_fields
           variables.transform_values do |value|
             if scrub_fields.any? { |f| value.to_s.downcase.include?(f.to_s) }
-              "[FILTERED]"
+              '[FILTERED]'
             else
               value
             end
@@ -163,19 +164,19 @@ module BrainzLab
       module Tracer
         def execute_query(query:)
           started_at = Time.now.utc
-          operation_name = query.operation_name || "anonymous"
-          operation_type = query.selected_operation&.operation_type || "query"
+          operation_name = query.operation_name || 'anonymous'
+          operation_type = query.selected_operation&.operation_type || 'query'
 
           result = super
 
           duration_ms = ((Time.now.utc - started_at) * 1000).round(2)
-          has_errors = result.to_h["errors"]&.any?
+          has_errors = result.to_h['errors']&.any?
 
           # Add breadcrumb
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "GraphQL #{operation_type} #{operation_name}",
-              category: "graphql.execute",
+              category: 'graphql.execute',
               level: has_errors ? :error : :info,
               data: {
                 operation_name: operation_name,
@@ -191,7 +192,7 @@ module BrainzLab
             spans << {
               span_id: SecureRandom.uuid,
               name: "GraphQL #{operation_type} #{operation_name}",
-              kind: "graphql",
+              kind: 'graphql',
               started_at: started_at,
               ended_at: Time.now.utc,
               duration_ms: duration_ms,
@@ -209,7 +210,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "GraphQL #{operation_type} #{operation_name} failed",
-              category: "graphql.error",
+              category: 'graphql.error',
               level: :error,
               data: { error: e.class.name }
             )
@@ -231,7 +232,7 @@ module BrainzLab
               spans << {
                 span_id: SecureRandom.uuid,
                 name: "GraphQL field #{field.owner.graphql_name}.#{field.graphql_name}",
-                kind: "graphql.field",
+                kind: 'graphql.field',
                 started_at: started_at,
                 ended_at: Time.now.utc,
                 duration_ms: duration_ms,

data/lib/brainzlab/instrumentation/httparty.rb

@@ -13,7 +13,7 @@ module BrainzLab
           ::HTTParty.singleton_class.prepend(Patch)
 
           @installed = true
-          BrainzLab.debug_log("HTTParty instrumentation installed")
+          BrainzLab.debug_log('HTTParty instrumentation installed')
         end
 
         def installed?
@@ -26,14 +26,13 @@ module BrainzLab
       end
 
       module Patch
-        def perform_request(http_method, path, options = {}, &block)
+        def perform_request(http_method, path, options = {}, &)
           return super unless should_track?(path, options)
 
           # Inject distributed tracing headers
           options = inject_trace_context(options)
 
           started_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-          error_info = nil
 
           begin
             response = super
@@ -79,7 +78,7 @@ module BrainzLab
           method = extract_method_name(http_method)
           uri = parse_uri(path, options)
           url = uri ? sanitize_url(uri) : path.to_s
-          host = uri&.host || "unknown"
+          host = uri&.host || 'unknown'
           request_path = uri&.path || path.to_s
           level = error || (status && status >= 400) ? :error : :info
 
@@ -87,7 +86,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "#{method} #{url}",
-              category: "http.httparty",
+              category: 'http.httparty',
               level: level,
               data: {
                 method: method,
@@ -127,7 +126,7 @@ module BrainzLab
           span = {
             span_id: SecureRandom.uuid,
             name: "HTTP #{method} #{host}",
-            kind: "http",
+            kind: 'http',
             started_at: Time.now.utc - (duration_ms / 1000.0),
             ended_at: Time.now.utc,
             duration_ms: duration_ms,
@@ -149,14 +148,14 @@ module BrainzLab
 
         def extract_method_name(http_method)
           case http_method.name
-          when /Get$/ then "GET"
-          when /Post$/ then "POST"
-          when /Put$/ then "PUT"
-          when /Patch$/ then "PATCH"
-          when /Delete$/ then "DELETE"
-          when /Head$/ then "HEAD"
-          when /Options$/ then "OPTIONS"
-          else http_method.name.split("::").last.upcase
+          when /Get$/ then 'GET'
+          when /Post$/ then 'POST'
+          when /Put$/ then 'PUT'
+          when /Patch$/ then 'PATCH'
+          when /Delete$/ then 'DELETE'
+          when /Head$/ then 'HEAD'
+          when /Options$/ then 'OPTIONS'
+          else http_method.name.split('::').last.upcase
           end
         end
 

data/lib/brainzlab/instrumentation/mongodb.rb

@@ -26,7 +26,7 @@ module BrainzLab
           return unless installed_any
 
           @installed = true
-          BrainzLab.debug_log("MongoDB instrumentation installed")
+          BrainzLab.debug_log('MongoDB instrumentation installed')
         end
 
         def installed?
@@ -51,9 +51,9 @@ module BrainzLab
 
         def install_mongoid!
           # For Mongoid 7+, use the APM module
-          if ::Mongoid.respond_to?(:subscribe)
-            ::Mongoid.subscribe(CommandSubscriber.new)
-          end
+          return unless ::Mongoid.respond_to?(:subscribe)
+
+          ::Mongoid.subscribe(CommandSubscriber.new)
         end
       end
 
@@ -96,7 +96,7 @@ module BrainzLab
         def extract_collection(event)
           # Try to extract collection name from command
           cmd = event.command
-          cmd["collection"] || cmd[event.command_name] || cmd.keys.first
+          cmd['collection'] || cmd[event.command_name] || cmd.keys.first
         rescue StandardError
           nil
         end
@@ -116,7 +116,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "MongoDB #{command_name}",
-              category: "mongodb",
+              category: 'mongodb',
               level: level,
               data: {
                 command: command_name,
@@ -163,7 +163,7 @@ module BrainzLab
           span = {
             span_id: SecureRandom.uuid,
             name: "MongoDB #{command_name} #{collection}".strip,
-            kind: "mongodb",
+            kind: 'mongodb',
             started_at: started_at,
             ended_at: Time.now.utc,
             duration_ms: duration_ms.round(2),

data/lib/brainzlab/instrumentation/net_http.rb

@@ -24,7 +24,7 @@ module BrainzLab
       end
 
       module Patch
-        def request(req, body = nil, &block)
+        def request(req, body = nil, &)
           return super unless should_track?
 
           # Inject distributed tracing context into outgoing request headers
@@ -38,7 +38,7 @@ module BrainzLab
             response = super
             track_request(method, url, response.code.to_i, started_at)
             response
-          rescue => e
+          rescue StandardError => e
             track_request(method, url, nil, started_at, e.class.name)
             raise
           end
@@ -69,9 +69,9 @@ module BrainzLab
         end
 
         def build_url(req)
-          scheme = use_ssl? ? "https" : "http"
+          scheme = use_ssl? ? 'https' : 'http'
           port_str = if (use_ssl? && port == 443) || (!use_ssl? && port == 80)
-                       ""
+                       ''
                      else
                        ":#{port}"
                      end
@@ -86,7 +86,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "#{method} #{url}",
-              category: "http",
+              category: 'http',
               level: level,
               data: { method: method, url: url, status_code: status, duration_ms: duration_ms, error: error }.compact
             )
@@ -99,7 +99,7 @@ module BrainzLab
               method: method, url: url, status_code: status, duration_ms: duration_ms, error: error
             )
           end
-        rescue => e
+        rescue StandardError => e
           # Don't let instrumentation errors crash the app
           BrainzLab.configuration.logger&.error("[BrainzLab] HTTP instrumentation error: #{e.message}")
         end

data/lib/brainzlab/instrumentation/redis.rb

@@ -18,7 +18,7 @@ module BrainzLab
           end
 
           @installed = true
-          BrainzLab.debug_log("Redis instrumentation installed")
+          BrainzLab.debug_log('Redis instrumentation installed')
         end
 
         def installed?
@@ -32,7 +32,7 @@ module BrainzLab
         private
 
         def redis_5_or_newer?
-          defined?(::Redis::VERSION) && Gem::Version.new(::Redis::VERSION) >= Gem::Version.new("5.0")
+          defined?(::Redis::VERSION) && Gem::Version.new(::Redis::VERSION) >= Gem::Version.new('5.0')
         end
 
         def install_middleware!
@@ -50,10 +50,6 @@ module BrainzLab
 
       # Middleware for Redis 5+ (RedisClient)
       module Middleware
-        def connect(redis_config)
-          super
-        end
-
         def call(command, redis_config)
           return super unless should_track?
 
@@ -78,10 +74,10 @@ module BrainzLab
           ignore.map(&:downcase).include?(cmd_name)
         end
 
-        def track_command(command, &block)
+        def track_command(command)
           return yield if should_skip_command?(command)
+
           started_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-          error_info = nil
 
           begin
             result = yield
@@ -94,9 +90,8 @@ module BrainzLab
           end
         end
 
-        def track_pipeline(commands, &block)
+        def track_pipeline(commands)
           started_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-          error_info = nil
 
           begin
             result = yield
@@ -119,7 +114,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "Redis #{cmd_name}",
-              category: "redis",
+              category: 'redis',
               level: level,
               data: {
                 command: cmd_name,
@@ -138,14 +133,14 @@ module BrainzLab
 
         def record_pipeline(commands, started_at, error = nil)
           duration_ms = ((Process.clock_gettime(Process::CLOCK_MONOTONIC) - started_at) * 1000).round(2)
-          cmd_names = commands.map { |c| c.first.to_s.upcase }.uniq.join(", ")
+          cmd_names = commands.map { |c| c.first.to_s.upcase }.uniq.join(', ')
           level = error ? :error : :info
 
           # Add breadcrumb for Reflex
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "Redis PIPELINE (#{commands.size} commands)",
-              category: "redis",
+              category: 'redis',
               level: level,
               data: {
                 commands: cmd_names,
@@ -157,7 +152,7 @@ module BrainzLab
           end
 
           # Record span for Pulse APM
-          record_pulse_span("PIPELINE", nil, duration_ms, error, commands.size)
+          record_pulse_span('PIPELINE', nil, duration_ms, error, commands.size)
         rescue StandardError => e
           BrainzLab.debug_log("Redis instrumentation error: #{e.message}")
         end
@@ -169,7 +164,7 @@ module BrainzLab
           span = {
             span_id: SecureRandom.uuid,
             name: "Redis #{command}",
-            kind: "redis",
+            kind: 'redis',
             started_at: Time.now.utc - (duration_ms / 1000.0),
             ended_at: Time.now.utc,
             duration_ms: duration_ms,
@@ -210,7 +205,6 @@ module BrainzLab
           return super if should_skip_command?(command)
 
           started_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-          error_info = nil
 
           begin
             result = super
@@ -227,7 +221,6 @@ module BrainzLab
           return super unless should_track?
 
           started_at = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-          error_info = nil
           commands = pipeline.commands
 
           begin
@@ -262,7 +255,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "Redis #{cmd_name}",
-              category: "redis",
+              category: 'redis',
               level: level,
               data: {
                 command: cmd_name,
@@ -285,7 +278,7 @@ module BrainzLab
           if BrainzLab.configuration.reflex_enabled
             BrainzLab::Reflex.add_breadcrumb(
               "Redis PIPELINE (#{commands.size} commands)",
-              category: "redis",
+              category: 'redis',
               level: level,
               data: {
                 count: commands.size,
@@ -295,7 +288,7 @@ module BrainzLab
             )
           end
 
-          record_pulse_span("PIPELINE", nil, duration_ms, error, commands.size)
+          record_pulse_span('PIPELINE', nil, duration_ms, error, commands.size)
         rescue StandardError => e
           BrainzLab.debug_log("Redis instrumentation error: #{e.message}")
         end
@@ -307,7 +300,7 @@ module BrainzLab
           span = {
             span_id: SecureRandom.uuid,
             name: "Redis #{command}",
-            kind: "redis",
+            kind: 'redis',
             started_at: Time.now.utc - (duration_ms / 1000.0),
             ended_at: Time.now.utc,
             duration_ms: duration_ms,

data/lib/brainzlab/instrumentation/resque.rb

@@ -10,13 +10,13 @@ module BrainzLab
           install_hooks!
           install_failure_backend!
 
-          BrainzLab.debug_log("[Instrumentation] Resque instrumentation installed")
+          BrainzLab.debug_log('[Instrumentation] Resque instrumentation installed')
         end
 
         private
 
         def install_hooks!
-          ::Resque.before_fork do |job|
+          ::Resque.before_fork do |_job|
             # Clear any stale connections before forking
             BrainzLab::Recall.reset! if defined?(BrainzLab::Recall)
             BrainzLab::Pulse.reset! if defined?(BrainzLab::Pulse)
@@ -38,31 +38,30 @@ module BrainzLab
             end
 
             def save
-              job_class = @payload["class"] || "Unknown"
+              job_class = @payload['class'] || 'Unknown'
 
               if BrainzLab.configuration.reflex_effectively_enabled?
                 BrainzLab::Reflex.capture(@exception,
-                  tags: { job_class: job_class, queue: @queue, source: "resque" },
-                  extra: {
-                    worker: @worker.to_s,
-                    args: @payload["args"]
-                  }
-                )
+                                          tags: { job_class: job_class, queue: @queue, source: 'resque' },
+                                          extra: {
+                                            worker: @worker.to_s,
+                                            args: @payload['args']
+                                          })
               end
 
-              if BrainzLab.configuration.flux_effectively_enabled?
-                BrainzLab::Flux.increment("resque.job.failed", tags: { job_class: job_class, queue: @queue })
-              end
+              return unless BrainzLab.configuration.flux_effectively_enabled?
+
+              BrainzLab::Flux.increment('resque.job.failed', tags: { job_class: job_class, queue: @queue })
             end
           end
 
           # Add our failure backend to the chain
-          if defined?(::Resque::Failure)
-            ::Resque::Failure.backend = ::Resque::Failure::Multiple.new(
-              ::Resque::Failure.backend,
-              failure_backend
-            )
-          end
+          return unless defined?(::Resque::Failure)
+
+          ::Resque::Failure.backend = ::Resque::Failure::Multiple.new(
+            ::Resque::Failure.backend,
+            failure_backend
+          )
         end
       end
 
@@ -73,9 +72,9 @@ module BrainzLab
         end
 
         module ClassMethods
-          def around_perform_brainzlab(*args)
-            job_class = self.name
-            queue = Resque.queue_from_class(self) || "default"
+          def around_perform_brainzlab(*_args)
+            job_class = name
+            queue = Resque.queue_from_class(self) || 'default'
             started_at = Time.now
 
             BrainzLab::Context.current.set_context(
@@ -91,7 +90,7 @@ module BrainzLab
               if BrainzLab.configuration.pulse_effectively_enabled?
                 BrainzLab::Pulse.record_trace(
                   "job.#{job_class}",
-                  kind: "job",
+                  kind: 'job',
                   started_at: started_at,
                   ended_at: Time.now,
                   job_class: job_class,
@@ -101,8 +100,8 @@ module BrainzLab
 
               if BrainzLab.configuration.flux_effectively_enabled?
                 tags = { job_class: job_class, queue: queue }
-                BrainzLab::Flux.distribution("resque.job.duration_ms", duration_ms, tags: tags)
-                BrainzLab::Flux.increment("resque.job.processed", tags: tags)
+                BrainzLab::Flux.distribution('resque.job.duration_ms', duration_ms, tags: tags)
+                BrainzLab::Flux.increment('resque.job.processed', tags: tags)
               end
 
               BrainzLab.clear_context!