brainzlab 0.1.2 → 0.1.3

data/lib/brainzlab/pulse/instrumentation.rb

@@ -22,14 +22,14 @@ module BrainzLab
         def install_active_record!
           return unless defined?(ActiveRecord)
 
-          ActiveSupport::Notifications.subscribe("sql.active_record") do |*args|
+          ActiveSupport::Notifications.subscribe('sql.active_record') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             next if skip_query?(event.payload)
 
             sql = event.payload[:sql]
             record_span(
-              name: event.payload[:name] || "SQL",
-              kind: "db",
+              name: event.payload[:name] || 'SQL',
+              kind: 'db',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -48,12 +48,12 @@ module BrainzLab
         def install_action_view!
           return unless defined?(ActionView)
 
-          ActiveSupport::Notifications.subscribe("render_template.action_view") do |*args|
+          ActiveSupport::Notifications.subscribe('render_template.action_view') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
 
             record_span(
               name: short_path(event.payload[:identifier]),
-              kind: "render",
+              kind: 'render',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -64,12 +64,12 @@ module BrainzLab
             )
           end
 
-          ActiveSupport::Notifications.subscribe("render_partial.action_view") do |*args|
+          ActiveSupport::Notifications.subscribe('render_partial.action_view') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
 
             record_span(
               name: short_path(event.payload[:identifier]),
-              kind: "render",
+              kind: 'render',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -80,12 +80,12 @@ module BrainzLab
             )
           end
 
-          ActiveSupport::Notifications.subscribe("render_collection.action_view") do |*args|
+          ActiveSupport::Notifications.subscribe('render_collection.action_view') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
 
             record_span(
               name: short_path(event.payload[:identifier]),
-              kind: "render",
+              kind: 'render',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -103,11 +103,11 @@ module BrainzLab
           %w[cache_read.active_support cache_write.active_support cache_delete.active_support].each do |event_name|
             ActiveSupport::Notifications.subscribe(event_name) do |*args|
               event = ActiveSupport::Notifications::Event.new(*args)
-              operation = event_name.split(".").first.sub("cache_", "")
+              operation = event_name.split('.').first.sub('cache_', '')
 
               record_span(
                 name: "Cache #{operation}",
-                kind: "cache",
+                kind: 'cache',
                 started_at: event.time,
                 ended_at: event.end,
                 duration_ms: event.duration,
@@ -125,7 +125,7 @@ module BrainzLab
         def install_action_controller!
           return unless defined?(ActionController)
 
-          ActiveSupport::Notifications.subscribe("process_action.action_controller") do |*args|
+          ActiveSupport::Notifications.subscribe('process_action.action_controller') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             payload = event.payload
 
@@ -141,12 +141,12 @@ module BrainzLab
         def install_http_clients!
           # Net::HTTP instrumentation
           if defined?(Net::HTTP)
-            ActiveSupport::Notifications.subscribe("request.net_http") do |*args|
+            ActiveSupport::Notifications.subscribe('request.net_http') do |*args|
               event = ActiveSupport::Notifications::Event.new(*args)
 
               record_span(
                 name: "HTTP #{event.payload[:method]} #{event.payload[:host]}",
-                kind: "http",
+                kind: 'http',
                 started_at: event.time,
                 ended_at: event.end,
                 duration_ms: event.duration,
@@ -161,26 +161,26 @@ module BrainzLab
           end
 
           # Faraday instrumentation
-          if defined?(Faraday)
-            ActiveSupport::Notifications.subscribe("request.faraday") do |*args|
-              event = ActiveSupport::Notifications::Event.new(*args)
-              env = event.payload[:env]
-              next unless env
+          return unless defined?(Faraday)
 
-              record_span(
-                name: "HTTP #{env.method.to_s.upcase} #{env.url.host}",
-                kind: "http",
-                started_at: event.time,
-                ended_at: event.end,
-                duration_ms: event.duration,
-                data: {
-                  method: env.method.to_s.upcase,
-                  host: env.url.host,
-                  path: env.url.path,
-                  status: env.status
-                }
-              )
-            end
+          ActiveSupport::Notifications.subscribe('request.faraday') do |*args|
+            event = ActiveSupport::Notifications::Event.new(*args)
+            env = event.payload[:env]
+            next unless env
+
+            record_span(
+              name: "HTTP #{env.method.to_s.upcase} #{env.url.host}",
+              kind: 'http',
+              started_at: event.time,
+              ended_at: event.end,
+              duration_ms: event.duration,
+              data: {
+                method: env.method.to_s.upcase,
+                host: env.url.host,
+                path: env.url.path,
+                status: env.status
+              }
+            )
           end
         end
 
@@ -189,13 +189,13 @@ module BrainzLab
           return unless defined?(ActiveJob)
 
           # Track job enqueuing
-          ActiveSupport::Notifications.subscribe("enqueue.active_job") do |*args|
+          ActiveSupport::Notifications.subscribe('enqueue.active_job') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             job = event.payload[:job]
 
             record_span(
               name: "Enqueue #{job.class.name}",
-              kind: "job",
+              kind: 'job',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -208,14 +208,14 @@ module BrainzLab
           end
 
           # Track job retry
-          ActiveSupport::Notifications.subscribe("retry_stopped.active_job") do |*args|
+          ActiveSupport::Notifications.subscribe('retry_stopped.active_job') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             job = event.payload[:job]
             error = event.payload[:error]
 
             record_span(
               name: "Retry stopped #{job.class.name}",
-              kind: "job",
+              kind: 'job',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -232,14 +232,14 @@ module BrainzLab
           end
 
           # Track job discard
-          ActiveSupport::Notifications.subscribe("discard.active_job") do |*args|
+          ActiveSupport::Notifications.subscribe('discard.active_job') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
             job = event.payload[:job]
             error = event.payload[:error]
 
             record_span(
               name: "Discarded #{job.class.name}",
-              kind: "job",
+              kind: 'job',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -260,12 +260,12 @@ module BrainzLab
         def install_action_cable!
           return unless defined?(ActionCable)
 
-          ActiveSupport::Notifications.subscribe("perform_action.action_cable") do |*args|
+          ActiveSupport::Notifications.subscribe('perform_action.action_cable') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
 
             record_span(
               name: "Cable #{event.payload[:channel_class]}##{event.payload[:action]}",
-              kind: "cable",
+              kind: 'cable',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -276,12 +276,12 @@ module BrainzLab
             )
           end
 
-          ActiveSupport::Notifications.subscribe("transmit.action_cable") do |*args|
+          ActiveSupport::Notifications.subscribe('transmit.action_cable') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
 
             record_span(
               name: "Cable transmit #{event.payload[:channel_class]}",
-              kind: "cable",
+              kind: 'cable',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -292,12 +292,12 @@ module BrainzLab
             )
           end
 
-          ActiveSupport::Notifications.subscribe("broadcast.action_cable") do |*args|
+          ActiveSupport::Notifications.subscribe('broadcast.action_cable') do |*args|
             event = ActiveSupport::Notifications::Event.new(*args)
 
             record_span(
               name: "Cable broadcast #{event.payload[:broadcasting]}",
-              kind: "cable",
+              kind: 'cable',
               started_at: event.time,
               ended_at: event.end,
               duration_ms: event.duration,
@@ -309,7 +309,8 @@ module BrainzLab
           end
         end
 
-        def record_span(name:, kind:, started_at:, ended_at:, duration_ms:, error: false, error_class: nil, error_message: nil, data: {})
+        def record_span(name:, kind:, started_at:, ended_at:, duration_ms:, error: false, error_class: nil,
+                        error_message: nil, data: {})
           spans = Thread.current[:brainzlab_pulse_spans]
           return unless spans
 
@@ -334,10 +335,10 @@ module BrainzLab
 
         def skip_query?(payload)
           # Skip SCHEMA queries and internal Rails queries
-          return true if payload[:name] == "SCHEMA"
-          return true if payload[:name]&.start_with?("EXPLAIN")
-          return true if payload[:sql]&.include?("pg_")
-          return true if payload[:sql]&.include?("information_schema")
+          return true if payload[:name] == 'SCHEMA'
+          return true if payload[:name]&.start_with?('EXPLAIN')
+          return true if payload[:sql]&.include?('pg_')
+          return true if payload[:sql]&.include?('information_schema')
           return true if payload[:cached] && !include_cached_queries?
 
           false
@@ -349,17 +350,20 @@ module BrainzLab
 
         def truncate_sql(sql)
           return nil unless sql
+
           sql.to_s[0, 1000]
         end
 
         def truncate_key(key)
           return nil unless key
+
           key.to_s[0, 200]
         end
 
         def short_path(path)
           return nil unless path
-          path.to_s.split("/").last(2).join("/")
+
+          path.to_s.split('/').last(2).join('/')
         end
 
         def extract_table(sql)
@@ -383,12 +387,12 @@ module BrainzLab
           return nil unless sql
 
           case sql.to_s.strip.upcase
-          when /\ASELECT/i then "SELECT"
-          when /\AINSERT/i then "INSERT"
-          when /\AUPDATE/i then "UPDATE"
-          when /\ADELETE/i then "DELETE"
-          when /\ABEGIN/i, /\ACOMMIT/i, /\AROLLBACK/i then "TRANSACTION"
-          else "QUERY"
+          when /\ASELECT/i then 'SELECT'
+          when /\AINSERT/i then 'INSERT'
+          when /\AUPDATE/i then 'UPDATE'
+          when /\ADELETE/i then 'DELETE'
+          when /\ABEGIN/i, /\ACOMMIT/i, /\AROLLBACK/i then 'TRANSACTION'
+          else 'QUERY'
           end
         end
       end

data/lib/brainzlab/pulse/propagation.rb

@@ -6,18 +6,18 @@ module BrainzLab
     # https://www.w3.org/TR/trace-context/
     module Propagation
       # W3C Trace Context header names
-      TRACEPARENT_HEADER = "traceparent"
-      TRACESTATE_HEADER = "tracestate"
+      TRACEPARENT_HEADER = 'traceparent'
+      TRACESTATE_HEADER = 'tracestate'
 
       # HTTP header versions (with HTTP_ prefix for Rack env)
-      HTTP_TRACEPARENT = "HTTP_TRACEPARENT"
-      HTTP_TRACESTATE = "HTTP_TRACESTATE"
+      HTTP_TRACEPARENT = 'HTTP_TRACEPARENT'
+      HTTP_TRACESTATE = 'HTTP_TRACESTATE'
 
       # Also support B3 format for compatibility
-      B3_TRACE_ID = "X-B3-TraceId"
-      B3_SPAN_ID = "X-B3-SpanId"
-      B3_SAMPLED = "X-B3-Sampled"
-      B3_PARENT_SPAN_ID = "X-B3-ParentSpanId"
+      B3_TRACE_ID = 'X-B3-TraceId'
+      B3_SPAN_ID = 'X-B3-SpanId'
+      B3_SAMPLED = 'X-B3-Sampled'
+      B3_PARENT_SPAN_ID = 'X-B3-ParentSpanId'
 
       class Context
         attr_accessor :trace_id, :span_id, :parent_span_id, :sampled, :tracestate
@@ -137,8 +137,8 @@ module BrainzLab
         # traceparent: version-traceid-spanid-flags
         # Example: 00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01
         def inject_w3c(headers, ctx)
-          version = "00"
-          flags = ctx.sampled ? "01" : "00"
+          version = '00'
+          flags = ctx.sampled ? '01' : '00'
           trace_id = normalize_trace_id(ctx.trace_id, 32)
           span_id = normalize_trace_id(ctx.span_id, 16)
 
@@ -152,31 +152,31 @@ module BrainzLab
         def extract_w3c(headers)
           traceparent = headers[TRACEPARENT_HEADER] ||
                         headers[HTTP_TRACEPARENT] ||
-                        headers["Traceparent"]
+                        headers['Traceparent']
           return nil unless traceparent
 
           # Parse: version-traceid-spanid-flags
-          parts = traceparent.to_s.split("-")
+          parts = traceparent.to_s.split('-')
           return nil if parts.length < 4
 
           version, trace_id, span_id, flags = parts
 
           # Validate version
-          return nil unless version == "00"
+          return nil unless version == '00'
 
           # Validate trace_id (32 hex chars, not all zeros)
           return nil unless trace_id&.match?(/\A[a-f0-9]{32}\z/i)
-          return nil if trace_id == "0" * 32
+          return nil if trace_id == '0' * 32
 
           # Validate span_id (16 hex chars, not all zeros)
           return nil unless span_id&.match?(/\A[a-f0-9]{16}\z/i)
-          return nil if span_id == "0" * 16
+          return nil if span_id == '0' * 16
 
           sampled = flags.to_i(16) & 0x01 == 1
 
           tracestate = headers[TRACESTATE_HEADER] ||
                        headers[HTTP_TRACESTATE] ||
-                       headers["Tracestate"]
+                       headers['Tracestate']
 
           Context.new(
             trace_id: trace_id,
@@ -192,7 +192,7 @@ module BrainzLab
         def inject_b3(headers, ctx)
           headers[B3_TRACE_ID] = normalize_trace_id(ctx.trace_id, 32)
           headers[B3_SPAN_ID] = normalize_trace_id(ctx.span_id, 16)
-          headers[B3_SAMPLED] = ctx.sampled ? "1" : "0"
+          headers[B3_SAMPLED] = ctx.sampled ? '1' : '0'
           headers[B3_PARENT_SPAN_ID] = ctx.parent_span_id if ctx.parent_span_id
 
           headers
@@ -201,23 +201,23 @@ module BrainzLab
         # B3 format extraction
         def extract_b3(headers)
           trace_id = headers[B3_TRACE_ID] ||
-                     headers["HTTP_X_B3_TRACEID"] ||
-                     headers["x-b3-traceid"]
+                     headers['HTTP_X_B3_TRACEID'] ||
+                     headers['x-b3-traceid']
           return nil unless trace_id
 
           span_id = headers[B3_SPAN_ID] ||
-                    headers["HTTP_X_B3_SPANID"] ||
-                    headers["x-b3-spanid"]
+                    headers['HTTP_X_B3_SPANID'] ||
+                    headers['x-b3-spanid']
           return nil unless span_id
 
           sampled_header = headers[B3_SAMPLED] ||
-                           headers["HTTP_X_B3_SAMPLED"] ||
-                           headers["x-b3-sampled"]
-          sampled = sampled_header != "0"
+                           headers['HTTP_X_B3_SAMPLED'] ||
+                           headers['x-b3-sampled']
+          sampled = sampled_header != '0'
 
           parent_span_id = headers[B3_PARENT_SPAN_ID] ||
-                           headers["HTTP_X_B3_PARENTSPANID"] ||
-                           headers["x-b3-parentspanid"]
+                           headers['HTTP_X_B3_PARENTSPANID'] ||
+                           headers['x-b3-parentspanid']
 
           Context.new(
             trace_id: trace_id,
@@ -232,8 +232,8 @@ module BrainzLab
         def normalize_trace_id(id, length)
           return nil unless id
 
-          hex = id.to_s.gsub("-", "").downcase
-          hex.rjust(length, "0").slice(0, length)
+          hex = id.to_s.gsub('-', '').downcase
+          hex.rjust(length, '0').slice(0, length)
         end
       end
     end

data/lib/brainzlab/pulse/provisioner.rb

@@ -1,14 +1,14 @@
 # frozen_string_literal: true
 
-require "net/http"
-require "uri"
-require "json"
-require "fileutils"
+require 'net/http'
+require 'uri'
+require 'json'
+require 'fileutils'
 
 module BrainzLab
   module Pulse
     class Provisioner
-      CACHE_DIR = ENV.fetch("BRAINZLAB_CACHE_DIR") { File.join(Dir.home, ".brainzlab") }
+      CACHE_DIR = ENV.fetch('BRAINZLAB_CACHE_DIR') { File.join(Dir.home, '.brainzlab') }
 
       def initialize(config)
         @config = config
@@ -38,10 +38,10 @@ module BrainzLab
 
       def should_provision?
         return false unless @config.pulse_auto_provision
-        return false unless @config.app_name.to_s.strip.length > 0
+        return false unless @config.app_name.to_s.strip.length.positive?
         # Only skip if pulse_api_key is already set
-        return false if @config.pulse_api_key.to_s.strip.length > 0
-        return false unless @config.pulse_master_key.to_s.strip.length > 0
+        return false if @config.pulse_api_key.to_s.strip.length.positive?
+        return false unless @config.pulse_master_key.to_s.strip.length.positive?
 
         true
       end
@@ -49,9 +49,9 @@ module BrainzLab
       def provision_project
         uri = URI.parse("#{@config.pulse_url}/api/v1/projects/provision")
         request = Net::HTTP::Post.new(uri)
-        request["Content-Type"] = "application/json"
-        request["X-Master-Key"] = @config.pulse_master_key
-        request["User-Agent"] = "brainzlab-sdk-ruby/#{BrainzLab::VERSION}"
+        request['Content-Type'] = 'application/json'
+        request['X-Master-Key'] = @config.pulse_master_key
+        request['User-Agent'] = "brainzlab-sdk-ruby/#{BrainzLab::VERSION}"
         request.body = JSON.generate({ name: @config.app_name })
 
         response = execute(uri, request)
@@ -98,7 +98,7 @@ module BrainzLab
 
       def execute(uri, request)
         http = Net::HTTP.new(uri.host, uri.port)
-        http.use_ssl = uri.scheme == "https"
+        http.use_ssl = uri.scheme == 'https'
         http.open_timeout = 5
         http.read_timeout = 10
         http.request(request)

data/lib/brainzlab/pulse/tracer.rb

@@ -16,7 +16,7 @@ module BrainzLab
         Thread.current[:brainzlab_pulse_spans] ||= []
       end
 
-      def start_trace(name, kind: "custom", **attributes)
+      def start_trace(name, kind: 'custom', **attributes)
         trace = {
           trace_id: SecureRandom.uuid,
           name: name,
@@ -64,7 +64,7 @@ module BrainzLab
         payload
       end
 
-      def span(name, kind: "custom", **data)
+      def span(name, kind: 'custom', **data)
         span_data = {
           span_id: SecureRandom.uuid,
           name: name,
@@ -91,7 +91,7 @@ module BrainzLab
 
       private
 
-      def format_span(span, trace_started_at)
+      def format_span(span, _trace_started_at)
         {
           span_id: span[:span_id],
           parent_span_id: span[:parent_span_id],

data/lib/brainzlab/pulse.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
-require_relative "pulse/client"
-require_relative "pulse/provisioner"
-require_relative "pulse/tracer"
-require_relative "pulse/instrumentation"
-require_relative "pulse/propagation"
+require_relative 'pulse/client'
+require_relative 'pulse/provisioner'
+require_relative 'pulse/tracer'
+require_relative 'pulse/instrumentation'
+require_relative 'pulse/propagation'
 
 module BrainzLab
   module Pulse
@@ -13,7 +13,7 @@ module BrainzLab
       # @param name [String] the trace name
       # @param kind [String] trace kind (request, job, custom)
       # @param parent_context [Propagation::Context] optional parent context for distributed tracing
-      def start_trace(name, kind: "custom", parent_context: nil, **attributes)
+      def start_trace(name, kind: 'custom', parent_context: nil, **attributes)
         return nil unless enabled?
 
         ensure_provisioned!
@@ -36,15 +36,15 @@ module BrainzLab
       end
 
       # Add a span to the current trace
-      def span(name, kind: "custom", **data)
+      def span(name, kind: 'custom', **data, &)
         return yield unless enabled?
         return yield unless tracer.current_trace
 
-        tracer.span(name, kind: kind, **data) { yield }
+        tracer.span(name, kind: kind, **data, &)
       end
 
       # Record a complete trace (for when you have all data upfront)
-      def record_trace(name, kind: "request", started_at:, ended_at:, **attributes)
+      def record_trace(name, started_at:, ended_at:, kind: 'request', **attributes)
         return unless enabled?
 
         ensure_provisioned!
@@ -55,7 +55,7 @@ module BrainzLab
       end
 
       # Record a custom metric
-      def record_metric(name, value:, kind: "gauge", tags: {})
+      def record_metric(name, value:, kind: 'gauge', tags: {})
         return unless enabled?
 
         ensure_provisioned!
@@ -74,15 +74,15 @@ module BrainzLab
 
       # Convenience methods for metrics
       def gauge(name, value, tags: {})
-        record_metric(name, value: value, kind: "gauge", tags: tags)
+        record_metric(name, value: value, kind: 'gauge', tags: tags)
       end
 
       def counter(name, value = 1, tags: {})
-        record_metric(name, value: value, kind: "counter", tags: tags)
+        record_metric(name, value: value, kind: 'counter', tags: tags)
       end
 
       def histogram(name, value, tags: {})
-        record_metric(name, value: value, kind: "histogram", tags: tags)
+        record_metric(name, value: value, kind: 'histogram', tags: tags)
       end
 
       def ensure_provisioned!