braintree 4.17.0 → 4.19.0

data/spec/integration/braintree/transaction_spec.rb

@@ -2098,7 +2098,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a params nonce with PayPal account params" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2132,8 +2131,9 @@ describe Braintree::Transaction do
         meta_checkout_card_details.cardholder_name.should == "Meta Checkout Card Cardholder"
         meta_checkout_card_details.container_id.should == "container123"
         meta_checkout_card_details.customer_location.should == "US"
-        meta_checkout_card_details.expiration_date.should == "12/2024"
-        meta_checkout_card_details.expiration_year.should == "2024"
+        next_year = Date.today().next_year().year.to_s
+        meta_checkout_card_details.expiration_date.should == "12/".concat(next_year)
+        meta_checkout_card_details.expiration_year.should == next_year
         meta_checkout_card_details.expiration_month.should == "12"
         meta_checkout_card_details.image_url.should == "https://assets.braintreegateway.com/payment_method_logo/visa.png?environment=development"
         meta_checkout_card_details.is_network_tokenized.should == false
@@ -2161,8 +2161,9 @@ describe Braintree::Transaction do
         meta_checkout_token_details.cryptogram.should == "AlhlvxmN2ZKuAAESNFZ4GoABFA=="
         meta_checkout_token_details.customer_location.should == "US"
         meta_checkout_token_details.ecommerce_indicator.should == "07"
-        meta_checkout_token_details.expiration_date.should == "12/2024"
-        meta_checkout_token_details.expiration_year.should == "2024"
+        next_year = Date.today().next_year().year.to_s
+        meta_checkout_token_details.expiration_date.should == "12/".concat(next_year)
+        meta_checkout_token_details.expiration_year.should == next_year
         meta_checkout_token_details.expiration_month.should == "12"
         meta_checkout_token_details.image_url.should == "https://assets.braintreegateway.com/payment_method_logo/visa.png?environment=development"
         meta_checkout_token_details.is_network_tokenized.should == true
@@ -2172,7 +2173,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a fake apple pay nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2201,7 +2201,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a vaulted transaction with a fake apple pay nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2223,7 +2222,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a fake google pay proxy card nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2255,7 +2253,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a vaulted transaction with a fake google pay proxy card nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2280,7 +2277,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a fake google pay network token nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2333,7 +2329,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with an unknown nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2362,7 +2357,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee id" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2386,7 +2380,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee id in the options params" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2411,7 +2404,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee id in options.paypal" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2437,7 +2429,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee email" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2461,7 +2452,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee email in the options params" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2486,7 +2476,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee email in options.paypal" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2512,7 +2501,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a paypal custom field" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2538,7 +2526,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a paypal description" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2564,7 +2551,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with STC supplementary data" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2748,7 +2734,7 @@ describe Braintree::Transaction do
             },
             :three_d_secure_authentication_id => three_d_secure_authentication_id,
             :three_d_secure_pass_thru => {
-              :eci_flag => "02",
+              :eci_flag => "05",
               :cavv => "some_cavv",
               :xid => "some_xid",
               :three_d_secure_version => "1.0.2",
@@ -2835,7 +2821,7 @@ describe Braintree::Transaction do
             :expiration_date => "12/12",
           },
           :three_d_secure_pass_thru => {
-            :eci_flag => "02",
+            :eci_flag => "05",
             :cavv => "some_cavv",
             :xid => "some_xid",
             :three_d_secure_version => "1.0.2",
@@ -2860,7 +2846,7 @@ describe Braintree::Transaction do
             :expiration_date => "12/12",
           },
           :three_d_secure_pass_thru => {
-            :eci_flag => "02",
+            :eci_flag => "05",
             :cavv => "some_cavv",
             :xid => "some_xid",
             :three_d_secure_version => "1.0.2",
@@ -2947,7 +2933,7 @@ describe Braintree::Transaction do
             :expiration_date => "12/12",
           },
           :three_d_secure_pass_thru => {
-            :eci_flag => "02",
+            :eci_flag => "05",
             :cavv => "some_cavv",
             :xid => "some_xid",
             :three_d_secure_version => "invalid",
@@ -2971,7 +2957,7 @@ describe Braintree::Transaction do
             :expiration_date => "12/12",
           },
           :three_d_secure_pass_thru => {
-            :eci_flag => "02",
+            :eci_flag => "05",
             :cavv => "some_cavv",
             :xid => "some_xid",
             :three_d_secure_version => "1.0.2",
@@ -2995,7 +2981,7 @@ describe Braintree::Transaction do
             :expiration_date => "12/12",
           },
           :three_d_secure_pass_thru => {
-            :eci_flag => "02",
+            :eci_flag => "05",
             :cavv => "some_cavv",
             :xid => "some_xid",
             :three_d_secure_version => "1.0.2",
@@ -3019,7 +3005,7 @@ describe Braintree::Transaction do
             :expiration_date => "12/12",
           },
           :three_d_secure_pass_thru => {
-            :eci_flag => "02",
+            :eci_flag => "05",
             :cavv => "some_cavv",
             :xid => "some_xid",
             :three_d_secure_version => "1.0.2",
@@ -3298,7 +3284,7 @@ describe Braintree::Transaction do
             )
 
             config = Braintree::Configuration.instantiate
-            response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+            config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
             transaction = Braintree::Transaction.find(transaction.id)
 
             result = Braintree::Transaction.refund(
@@ -3388,7 +3374,7 @@ describe Braintree::Transaction do
             },
           )
           config = Braintree::Configuration.instantiate
-          response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+          config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
           result = Braintree::Transaction.refund(transaction.id, :amount => "2046.00")
           expect(result.success?).to eq(false)
           expect(result.transaction.id).to match(/^\w{6,}$/)
@@ -3409,7 +3395,7 @@ describe Braintree::Transaction do
             },
           )
           config = Braintree::Configuration.instantiate
-          response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+          config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
           result = Braintree::Transaction.refund(transaction.id, :amount => "2009.00")
           expect(result.success?).to eq(false)
           expect(result.transaction.id).to match(/^\w{6,}$/)
@@ -4605,6 +4591,84 @@ describe Braintree::Transaction do
         expect(result.success?).to eq(false)
         expect(result.errors.for(:transaction).on(:line_items)[0].code).to eq(Braintree::ErrorCodes::Transaction::TooManyLineItems)
       end
+
+      context "UPC code and type" do
+        let(:line_item) do
+          {
+            :quantity => "1",
+            :name => "Name #1",
+            :description => "Description #1",
+            :kind => "debit",
+            :unit_amount => "45.12",
+            :unit_tax_amount => "1.23",
+            :unit_of_measure => "gallon",
+            :discount_amount => "1.02",
+            :tax_amount => "4.50",
+            :total_amount => "45.15",
+            :product_code => "23434",
+            :commodity_code => "9SAASSD8724",
+            :url => "https://example.com/products/23434",
+            :upc_code => "042100005264",
+            :upc_type => "UPC-A",
+            :image_url => "https://google.com/image.png",
+          }
+        end
+
+        it "accepts valid values" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => "45.15",
+            :payment_method_nonce => Braintree::Test::Nonce::Transactable,
+            :line_items => [line_item],
+          )
+          expect(result.success?).to eq(true)
+          expect(result.transaction.line_items.length).to eq(1)
+          line_item = result.transaction.line_items[0]
+          expect(line_item.upc_code).to eq("042100005264")
+          expect(line_item.upc_type).to eq("UPC-A")
+        end
+
+        it "returns validation errors for invalid UPC code and type too long" do
+          line_item[:upc_code] = "THISCODELONGERTHAN17CHARS"
+          line_item[:upc_type] = "USB-C"
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => "45.15",
+            :payment_method_nonce => Braintree::Test::Nonce::Transactable,
+            :line_items => [line_item],
+          )
+
+          expect(result.success?).to eq(false)
+          expect(result.errors.for(:transaction).for(:line_items).for(:index_0).on(:upc_code)[0].code).to eq(Braintree::ErrorCodes::TransactionLineItem::UPCCodeIsTooLong)
+          expect(result.errors.for(:transaction).for(:line_items).for(:index_0).on(:upc_type)[0].code).to eq(Braintree::ErrorCodes::TransactionLineItem::UPCTypeIsInvalid)
+        end
+
+        it "returns UPC code missing error when code is not present" do
+          line_item.delete(:upc_code)
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => "45.15",
+            :payment_method_nonce => Braintree::Test::Nonce::Transactable,
+            :line_items => [line_item],
+          )
+
+          expect(result.success?).to eq(false)
+          expect(result.errors.for(:transaction).for(:line_items).for(:index_0).on(:upc_code)[0].code).to eq(Braintree::ErrorCodes::TransactionLineItem::UPCCodeIsMissing)
+        end
+
+        it "returns UPC type missing error when type is not present" do
+          line_item.delete(:upc_type)
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => "45.15",
+            :payment_method_nonce => Braintree::Test::Nonce::Transactable,
+            :line_items => [line_item],
+          )
+
+          expect(result.success?).to eq(false)
+          expect(result.errors.for(:transaction).for(:line_items).for(:index_0).on(:upc_type)[0].code).to eq(Braintree::ErrorCodes::TransactionLineItem::UPCTypeIsMissing)
+        end
+      end
     end
 
     context "level 3 summary data" do
@@ -5820,7 +5884,7 @@ describe Braintree::Transaction do
     end
 
     context "Pinless debit transaction" do
-      xit "succesfully submits for settlement" do
+      it "succesfully submits for settlement" do
         result = Braintree::Transaction.sale(
           :amount => Braintree::Test::TransactionAmounts::Authorize,
           :merchant_account_id => SpecHelper::PinlessDebitMerchantAccountId,
@@ -5831,10 +5895,28 @@ describe Braintree::Transaction do
           },
         )
         expect(result.success?).to be_truthy
-        expect(result.transaction.status).to eq(Braintree::Transaction::Status::SubmittedForSettlement)
         expect(result.transaction.debit_network).not_to be_nil
       end
     end
+
+    context "Process debit as credit" do
+      it "succesfully completed pinless eligible transaction in signature" do
+        result = Braintree::Transaction.sale(
+          :amount => Braintree::Test::TransactionAmounts::Authorize,
+          :merchant_account_id => SpecHelper::PinlessDebitMerchantAccountId,
+          :currency_iso_code => "USD",
+          :payment_method_nonce => Braintree::Test::Nonce::TransactablePinlessDebitVisa,
+          :options => {
+            :submit_for_settlement => true,
+            :credit_card => {
+              :process_debit_as_credit => true
+            }
+          },
+        )
+        expect(result.success?).to be_truthy
+        expect(result.transaction.debit_network).to be_nil
+      end
+    end
   end
 
   describe "self.sale!" do
@@ -7158,7 +7240,7 @@ describe Braintree::Transaction do
     )
 
     config = Braintree::Configuration.instantiate
-    response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+    config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
     Braintree::Transaction.find(transaction.id)
   end
 
@@ -7189,8 +7271,8 @@ describe Braintree::Transaction do
     )
 
     config = Braintree::Configuration.instantiate
-    response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
-    response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/escrow")
+    config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+    config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/escrow")
     Braintree::Transaction.find(transaction.id)
   end
 
@@ -7739,20 +7821,6 @@ describe Braintree::Transaction do
         expect(adjustment_transaction.errors.for(:authorization_adjustment).on(:base).first.code).to eq(Braintree::ErrorCodes::Transaction::NoNetAmountToPerformAuthAdjustment)
       end
 
-      it "returns failure, when transaction status is not authorized" do
-        additional_params = {:options => {:submit_for_settlement => true}}
-        initial_transaction = Braintree::Transaction.sale(first_data_master_transaction_params.merge(additional_params))
-        expect(initial_transaction.success?).to eq(true)
-
-        adjustment_transaction = Braintree::Transaction.adjust_authorization(
-          initial_transaction.transaction.id, "85.50"
-        )
-
-        expect(adjustment_transaction.success?).to eq(false)
-        expect(adjustment_transaction.transaction.amount).to eq(BigDecimal("75.50"))
-        expect(adjustment_transaction.errors.for(:transaction).on(:base).first.code).to eq(Braintree::ErrorCodes::Transaction::TransactionMustBeInStateAuthorized)
-      end
-
       it "returns failure, when transaction authorization type final or undefined" do
         additional_params = {:transaction_source => "recurring"}
         initial_transaction = Braintree::Transaction.sale(first_data_master_transaction_params.merge(additional_params))

data/spec/unit/braintree/client_token_spec.rb

@@ -14,7 +14,7 @@ module Braintree
 
       it "can't overwrite public_key, or created_at" do
         expect {
-          client_token = Braintree::ClientToken.generate(
+          Braintree::ClientToken.generate(
             :public_key => "bad_key",
             :created_at => "bad_time",
           )

data/spec/unit/braintree/digest_spec.rb

@@ -3,7 +3,6 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Digest do
   describe "self.hexdigest" do
     it "returns the sha1 hmac of the input string (test case 6 from RFC 2202)" do
-      original_key = Braintree::Configuration.private_key
       private_key = "\xaa" * 80
       data = "Test Using Larger Than Block-Size Key - Hash Key First"
       expect(Braintree::Digest.hexdigest(private_key, data)).to eq("aa4ae5e15272d00e95705637ce8a3b55ed402112")

data/spec/unit/braintree/error_result_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::ErrorResult do
     it "ignores data other than params, errors, and message" do
       # so that we can add more data into the response in the future without breaking the client lib
       expect do
-        result = Braintree::ErrorResult.new(
+        Braintree::ErrorResult.new(
           :gateway,
           :params => "params",
           :errors => {:errors => []},

data/spec/unit/braintree/package_tracking_spec.rb

@@ -0,0 +1,74 @@
+require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
+
+describe "Package Tracking Unit Tests" do
+    describe "creates and validates requests" do
+        let(:gateway) do
+            config = Braintree::Configuration.new(
+              :merchant_id => "merchant_id",
+              :public_key => "public_key",
+              :private_key => "private_key",
+            )
+            Braintree::Gateway.new(config)
+        end
+
+          it "creates transaction gateway package tracking request signature" do
+            expect(Braintree::TransactionGateway._package_tracking_request_signature).to match(
+              [
+                :carrier,
+                {:line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url]},
+                :notify_payer, :tracking_number,
+              ],
+            )
+          end
+
+          it "raises an ArgumentError if transaction_id is an invalid format" do
+            expect do
+              Braintree::Transaction.package_tracking("invalid-transaction-id", {})
+            end.to raise_error(ArgumentError, "transaction_id is invalid")
+          end
+
+          it "raises an exception if attributes contain an invalid key" do
+            expect do
+                Braintree::Transaction.package_tracking("txn123", {:invalid_key => "random", :carrier => "UPS", :tracking_number => "123123"})
+            end.to raise_error(ArgumentError, "invalid keys: invalid_key")
+          end
+    end
+
+    describe "handles response" do
+        it "parses the packages response correctly" do
+          transaction = Braintree::Transaction._new(
+            :gateway,
+            :shipments => [
+              {:id => "id1", :carrier => "UPS", :tracking_number => "tracking_number_1", :paypal_tracking_id => "pp_tracking_number_1"},
+              {:id => "id2", :carrier => "FEDEX", :tracking_number => "tracking_number_2", :paypal_tracking_id => "pp_tracking_number_2"}
+            ],
+          )
+          expect(transaction.packages.size).to eq(2)
+          expect(transaction.packages[0].id).to eq("id1")
+          expect(transaction.packages[0].carrier).to eq("UPS")
+          expect(transaction.packages[0].tracking_number).to eq("tracking_number_1")
+          expect(transaction.packages[0].paypal_tracking_id).to eq("pp_tracking_number_1")
+
+          expect(transaction.packages[1].id).to eq("id2")
+          expect(transaction.packages[1].carrier).to eq("FEDEX")
+          expect(transaction.packages[1].tracking_number).to eq("tracking_number_2")
+          expect(transaction.packages[1].paypal_tracking_id).to eq("pp_tracking_number_2")
+        end
+
+        it "doesn't blow up if no shipments are present in the transaction response" do
+            transaction = Braintree::Transaction._new(
+                :gateway,
+                :shipments => [],
+              )
+              expect(transaction.packages.size).to eq(0)
+        end
+
+        it "doesn't blow up if shipments tag is not present in the transaction response" do
+            transaction = Braintree::Transaction._new(
+                :gateway,
+                {},
+              )
+              expect(transaction.packages.size).to eq(0)
+        end
+    end
+end

data/spec/unit/braintree/paypal_account_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::PayPalAccount do
   describe "self.create" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        result = Braintree::PayPalAccount.create(
+        Braintree::PayPalAccount.create(
           :invalid_key => "bad stuff",
           :options => {
             :invalid_option => "bad option",

data/spec/unit/braintree/transaction_gateway_spec.rb

@@ -41,7 +41,7 @@ describe Braintree::TransactionGateway do
         :ships_from_postal_code, :tax_amount, :tax_exempt, :three_d_secure_authentication_id,:three_d_secure_token, #Deprecated
         :transaction_source, :type, :venmo_sdk_payment_method_code, #Deprecated
         :sca_exemption, :currency_iso_code, :exchange_rate_quote_id,
-        {:line_items => [:quantity, :name, :description, :kind, :unit_amount, :unit_tax_amount, :total_amount, :discount_amount, :tax_amount, :unit_of_measure, :product_code, :commodity_code, :url]},
+        {:line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url]},
         {:risk_data => [:customer_browser, :customer_device_id, :customer_ip, :customer_location_zip, :customer_tenure]},
         {:credit_card => [:token, :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year, :number, {:payment_reader_card_details => [:encrypted_card_data, :key_serial_number]}, {:network_tokenization_attributes => [:cryptogram, :ecommerce_indicator, :token_requestor_id]}]},
         {:customer => [:id, :company, :email, :fax, :first_name, :last_name, :phone, :website]},
@@ -81,7 +81,7 @@ describe Braintree::TransactionGateway do
           {:three_d_secure => [:required]},
           {:amex_rewards => [:request_id, :points, :currency_amount, :currency_iso_code]},
           {:venmo => [:profile_id]},
-          {:credit_card => [:account_type]},
+          {:credit_card => [:account_type, :process_debit_as_credit]},
         ]
         },
         {:external_vault => [
@@ -137,7 +137,7 @@ describe Braintree::TransactionGateway do
         :discount_amount,
         :shipping_amount,
         :ships_from_postal_code,
-        :line_items => [:commodity_code, :description, :discount_amount, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :url, :tax_amount],
+        :line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url],
       ])
     end
   end

data/spec/unit/braintree/transaction_spec.rb

@@ -200,8 +200,8 @@ describe Braintree::Transaction do
         },
       )
 
-      expect(transaction.three_d_secure_info.enrolled).to eq("Y")
       expect(transaction.three_d_secure_info.status).to eq("authenticate_successful")
+      expect(transaction.three_d_secure_info.enrolled).to eq("Y")
       expect(transaction.three_d_secure_info.liability_shifted).to eq(true)
       expect(transaction.three_d_secure_info.liability_shift_possible).to eq(true)
     end
@@ -258,7 +258,7 @@ describe Braintree::Transaction do
     end
 
     it "handles receiving custom as an empty string" do
-      transaction = Braintree::Transaction._new(
+      Braintree::Transaction._new(
         :gateway,
         :custom => "\n    ",
       )

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -168,6 +168,22 @@ describe Braintree::WebhookNotification do
           expect(dispute.kind).to eq(Braintree::Dispute::Kind::Chargeback)
         end
 
+        it "builds a sample notification for a dispute under_review webhook" do
+          sample_notification = Braintree::WebhookTesting.sample_notification(
+            Braintree::WebhookNotification::Kind::DisputeUnderReview,
+            dispute_id,
+          )
+
+          notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+
+          expect(notification.kind).to eq(Braintree::WebhookNotification::Kind::DisputeUnderReview)
+
+          dispute = notification.dispute
+          expect(dispute.status).to eq(Braintree::Dispute::Status::UnderReview)
+          expect(dispute.id).to eq(dispute_id)
+          expect(dispute.kind).to eq(Braintree::Dispute::Kind::Chargeback)
+        end
+
         it "builds a sample notification for a dispute won webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeWon,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 4.17.0
+  version: 4.19.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-12-19 00:00:00.000000000 Z
+date: 2024-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -181,6 +181,7 @@ files:
 - lib/braintree/transaction/local_payment_details.rb
 - lib/braintree/transaction/meta_checkout_card_details.rb
 - lib/braintree/transaction/meta_checkout_token_details.rb
+- lib/braintree/transaction/package_details.rb
 - lib/braintree/transaction/payment_receipt.rb
 - lib/braintree/transaction/payment_receipt/card_present_data.rb
 - lib/braintree/transaction/payment_receipt/merchant_address.rb
@@ -250,6 +251,7 @@ files:
 - spec/integration/braintree/merchant_account_spec.rb
 - spec/integration/braintree/merchant_spec.rb
 - spec/integration/braintree/oauth_spec.rb
+- spec/integration/braintree/package_tracking_spec.rb
 - spec/integration/braintree/payment_method_nonce_spec.rb
 - spec/integration/braintree/payment_method_spec.rb
 - spec/integration/braintree/payment_method_us_bank_account_spec.rb
@@ -311,6 +313,7 @@ files:
 - spec/unit/braintree/meta_checkout_token_details_spec.rb
 - spec/unit/braintree/meta_checkout_token_spec.rb
 - spec/unit/braintree/modification_spec.rb
+- spec/unit/braintree/package_tracking_spec.rb
 - spec/unit/braintree/payment_method_customer_data_updated_metadata_spec.rb
 - spec/unit/braintree/payment_method_nonce_details_payer_info_spec.rb
 - spec/unit/braintree/payment_method_nonce_details_spec.rb