braintree 4.17.0 → 4.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 02bb65b55ac949e73761f1a9ded2f1cf844bc81b7bbfc48d39e080387166e4d2
-  data.tar.gz: b3975e3c6a0d415544cc643aaa2471f3efe532537a0ad1a8175dcf42767b2684
+  metadata.gz: f43df747b2db22253268db6e5f01b79ea162b6c0911125b056b7bab73684dd3f
+  data.tar.gz: 6fad0280817f00e0c0e3e8c6ef3761a5bd20d3e3a777a9f91182e556fad59aba
 SHA512:
-  metadata.gz: 6eb74dc8f70c828d8112b177bd9c424816626064fbfba2615d7246f9bae54513c5637b43be0c70a36e4dff5ac0b00aefbf208f66549829e64d37e30a37f0920a
-  data.tar.gz: d6af576d6a66816007de302db284e2bb456c1a37347eadac4df3ba483d5ab728e2a04dc26f2d98be91082c1a4b30790417e2d102bfd8b054b524c4b6d40174d5
+  metadata.gz: 7e6aa6b5b10734d82c66f9f7f315c5759700412ddda2642e2424f71c8be71aca06d35aa77b69936514c8e3d0ddc2e5dd24d479e8c4359ff9d67e43222ebe0256
+  data.tar.gz: f762c62cadc6476aebfc9f0f2aee72bd254b32b93c1c069c22c67661482ac433b2598ff1f86f2f1cad943dcf28878bac4f3293025d7b45e26cb34aec3c6fbc81

data/lib/braintree/advanced_search.rb

@@ -80,8 +80,7 @@ module Braintree
       operators :is
 
       def between(min, max)
-        self >= min
-        self <= max
+        self >= min && self <= max
       end
 
       def >=(min)

data/lib/braintree/configuration.rb

@@ -72,7 +72,7 @@ module Braintree
     end
 
     def self.instantiate
-      config = new(
+      new(
         :custom_user_agent => @custom_user_agent,
         :endpoint => @endpoint,
         :environment => environment,

data/lib/braintree/disbursement.rb

@@ -29,7 +29,7 @@ module Braintree
     end
 
     def transactions
-      transactions = @gateway.transaction.search do |search|
+      @gateway.transaction.search do |search|
         search.ids.in transaction_ids
       end
     end

data/lib/braintree/dispute.rb

@@ -43,6 +43,7 @@ module Braintree
       Expired = "expired"
       Open = "open"
       Lost = "lost"
+      UnderReview = "under_review"
       Won = "won"
 
       All = constants.map { |c| const_get(c) }

data/lib/braintree/error_codes.rb

@@ -561,6 +561,10 @@ module Braintree
       UnitTaxAmountCannotBeNegative = "95826"
       UnitTaxAmountFormatIsInvalid = "95824"
       UnitTaxAmountIsTooLarge = "95825"
+      UPCCodeIsMissing = "95830"
+      UPCCodeIsTooLong = "95831"
+      UPCTypeIsMissing = "95832"
+      UPCTypeIsInvalid = "95833"
     end
 
     module Merchant

data/lib/braintree/http.rb

@@ -8,7 +8,6 @@ module Braintree
     end
 
     def delete(path, query_params = {})
-      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Delete, path
       if response.code.to_i == 200 || response.code.to_i == 204
         true
@@ -20,7 +19,6 @@ module Braintree
     end
 
     def get(path, query_params = {})
-      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Get, path
       if response.code.to_i == 200 || response.code.to_i == 422
         Xml.hash_from_xml(_body(response))
@@ -69,7 +67,7 @@ module Braintree
 
     def _setup_connection(server = @config.server, port = @config.port)
       if @config.proxy_address
-        connection = Net::HTTP.new(
+        Net::HTTP.new(
           server,
           port,
           @config.proxy_address,
@@ -78,7 +76,7 @@ module Braintree
           @config.proxy_pass,
         )
       else
-        connection = Net::HTTP.new(server, port)
+        Net::HTTP.new(server, port)
       end
     end
 

data/lib/braintree/transaction/package_details.rb

@@ -0,0 +1,16 @@
+module Braintree
+    class Transaction
+        class PackageDetails
+            include BaseModule
+
+            attr_reader :carrier
+            attr_reader :id
+            attr_reader :paypal_tracking_id
+            attr_reader :tracking_number
+
+            def initialize(attributes)
+                set_instance_variables_from_hash attributes unless attributes.nil?
+            end
+        end
+    end
+end

data/lib/braintree/transaction.rb

@@ -138,6 +138,7 @@ module Braintree
     attr_reader :network_token_details
     attr_reader :network_transaction_id
     attr_reader :order_id
+    attr_reader :packages
     attr_reader :partial_settlement_transaction_ids
     attr_reader :payment_instrument_type
     attr_reader :payment_receipt
@@ -284,6 +285,14 @@ module Braintree
       return_object_or_raise(:transaction) { update_details(*args) }
     end
 
+    def self.package_tracking(*args)
+      Configuration.gateway.transaction.package_tracking(*args)
+    end
+
+    def self.package_tracking!(*args)
+      Configuration.gateway.transaction.package_tracking!(*args)
+    end
+
     def self.submit_for_partial_settlement(*args)
       Configuration.gateway.transaction.submit_for_partial_settlement(*args)
     end
@@ -325,6 +334,7 @@ module Braintree
       @sca_exemption_requested = attributes[:sca_exemption_requested]
       @sepa_direct_debit_account_details = SepaDirectDebitAccountDetails.new(@sepa_debit_account_detail)
       @service_fee_amount = Util.to_big_decimal(service_fee_amount)
+      @packages = attributes[:shipments] ? attributes[:shipments].map { |pd| PackageDetails.new(pd) } : []
       @shipping_details = AddressDetails.new(@shipping)
       @status_history = attributes[:status_history] ? attributes[:status_history].map { |s| StatusDetails.new(s) } : []
       @subscription_details = SubscriptionDetails.new(@subscription)

data/lib/braintree/transaction_gateway.rb

@@ -112,6 +112,16 @@ module Braintree
       return_object_or_raise(:transaction) { sale(*args) }
     end
 
+    def package_tracking(transaction_id, package_tracking_request)
+      raise ArgumentError, "transaction_id is invalid" unless transaction_id =~ /\A[0-9a-z]+\z/
+      Util.verify_keys(TransactionGateway._package_tracking_request_signature, package_tracking_request)
+      _do_create "/transactions/#{transaction_id}/shipments", :shipment => package_tracking_request
+    end
+
+    def package_tracking!(*args)
+      return_object_or_raise(:transaction) { package_tracking(*args) }
+    end
+
     def search(&block)
       search = TransactionSearch.new
       block.call(search) if block
@@ -187,6 +197,14 @@ module Braintree
       return_object_or_raise(:transaction) { void(*args) }
     end
 
+    def self._package_tracking_request_signature
+      [
+        :carrier,
+        {:line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url]},
+        :notify_payer, :tracking_number,
+      ]
+    end
+
     def self._clone_signature
       [:amount, :channel, {:options => [:submit_for_settlement]}]
     end
@@ -204,7 +222,7 @@ module Braintree
         :ships_from_postal_code, :tax_amount, :tax_exempt, :three_d_secure_authentication_id,:three_d_secure_token, #Deprecated
         :transaction_source, :type, :venmo_sdk_payment_method_code, # Deprecated
         :sca_exemption, :currency_iso_code, :exchange_rate_quote_id,
-        {:line_items => [:quantity, :name, :description, :kind, :unit_amount, :unit_tax_amount, :total_amount, :discount_amount, :tax_amount, :unit_of_measure, :product_code, :commodity_code, :url]},
+        {:line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url]},
         {:risk_data => [:customer_browser, :customer_device_id, :customer_ip, :customer_location_zip, :customer_tenure]},
         {:credit_card => [:token, :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year, :number, {:payment_reader_card_details => [:encrypted_card_data, :key_serial_number]}, {:network_tokenization_attributes => [:cryptogram, :ecommerce_indicator, :token_requestor_id]}]},
         {:customer => [:id, :company, :email, :fax, :first_name, :last_name, :phone, :website]},
@@ -244,7 +262,7 @@ module Braintree
           {:three_d_secure => [:required]},
           {:amex_rewards => [:request_id, :points, :currency_amount, :currency_iso_code]},
           {:venmo => [:profile_id]},
-          {:credit_card => [:account_type]},
+          {:credit_card => [:account_type, :process_debit_as_credit]},
         ]
         },
         {:external_vault => [
@@ -300,7 +318,7 @@ module Braintree
         :discount_amount,
         :shipping_amount,
         :ships_from_postal_code,
-        :line_items => [:commodity_code, :description, :discount_amount, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :url, :tax_amount],
+        :line_items => [:commodity_code, :description, :discount_amount, :image_url, :kind, :name, :product_code, :quantity, :tax_amount, :total_amount, :unit_amount, :unit_of_measure, :unit_tax_amount, :upc_code, :upc_type, :url],
       ]
     end
 

data/lib/braintree/transaction_line_item.rb

@@ -1,18 +1,21 @@
 module Braintree
   class TransactionLineItem
     include BaseModule
-    attr_reader :quantity
-    attr_reader :name
+    attr_reader :commodity_code
     attr_reader :description
-    attr_reader :kind
-    attr_reader :unit_amount
-    attr_reader :unit_tax_amount
-    attr_reader :unit_of_measure
     attr_reader :discount_amount
+    attr_reader :image_url
+    attr_reader :kind
+    attr_reader :name
+    attr_reader :product_code
+    attr_reader :quantity
     attr_reader :tax_amount
     attr_reader :total_amount
-    attr_reader :product_code
-    attr_reader :commodity_code
+    attr_reader :unit_amount
+    attr_reader :unit_of_measure
+    attr_reader :unit_tax_amount
+    attr_reader :upc_code
+    attr_reader :upc_type
     attr_reader :url
 
     def initialize(gateway, attributes)

data/lib/braintree/util.rb

@@ -191,7 +191,7 @@ module Braintree
     def self._get_invalid_keys(valid_keys, hash)
       flattened_valid_keys = _flatten_valid_keys(valid_keys)
       keys = _flatten_hash_keys(hash) - flattened_valid_keys
-      keys = _remove_wildcard_keys(flattened_valid_keys, keys)
+      _remove_wildcard_keys(flattened_valid_keys, keys)
     end
 
     module IdEquality

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 4
-    Minor = 17
+    Minor = 19
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/webhook_notification.rb

@@ -15,13 +15,14 @@ module Braintree
       Disbursement = "disbursement"
       DisbursementException = "disbursement_exception"
 
-      DisputeOpened = "dispute_opened"
-      DisputeLost = "dispute_lost"
-      DisputeWon = "dispute_won"
       DisputeAccepted = "dispute_accepted"
       DisputeAutoAccepted = "dispute_auto_accepted"
       DisputeDisputed = "dispute_disputed"
       DisputeExpired = "dispute_expired"
+      DisputeLost = "dispute_lost"
+      DisputeOpened = "dispute_opened"
+      DisputeUnderReview = "dispute_under_review"
+      DisputeWon = "dispute_won"
 
       GrantedPaymentInstrumentRevoked = "granted_payment_instrument_revoked"
 

data/lib/braintree/webhook_testing_gateway.rb

@@ -34,12 +34,6 @@ module Braintree
       case kind
       when Braintree::WebhookNotification::Kind::Check
         _check
-      when Braintree::WebhookNotification::Kind::DisputeOpened
-        _dispute_opened_sample_xml(id)
-      when Braintree::WebhookNotification::Kind::DisputeLost
-        _dispute_lost_sample_xml(id)
-      when Braintree::WebhookNotification::Kind::DisputeWon
-        _dispute_won_sample_xml(id)
       when Braintree::WebhookNotification::Kind::DisputeAccepted
         _dispute_accepted_sample_xml(id)
       when Braintree::WebhookNotification::Kind::DisputeAutoAccepted
@@ -48,6 +42,14 @@ module Braintree
         _dispute_disputed_sample_xml(id)
       when Braintree::WebhookNotification::Kind::DisputeExpired
         _dispute_expired_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeLost
+        _dispute_lost_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeOpened
+        _dispute_opened_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeUnderReview
+        _dispute_under_review_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeWon
+        _dispute_won_sample_xml(id)
       when Braintree::WebhookNotification::Kind::PartnerMerchantConnected
         _partner_merchant_connected_sample_xml(id)
       when Braintree::WebhookNotification::Kind::PartnerMerchantDisconnected
@@ -324,6 +326,14 @@ module Braintree
       XML
     end
 
+    def _dispute_under_review_sample_xml(id)
+      if id == "legacy_dispute_id"
+        _old_dispute_under_review_sample_xml(id)
+      else
+        _new_dispute_under_review_sample_xml(id)
+      end
+    end
+
     def _dispute_opened_sample_xml(id)
       if id == "legacy_dispute_id"
         _old_dispute_opened_sample_xml(id)
@@ -380,6 +390,26 @@ module Braintree
       end
     end
 
+    def _old_dispute_under_review_sample_xml(id)
+      <<-XML
+        <dispute>
+          <amount>100.00</amount>
+          <currency-iso-code>USD</currency-iso-code>
+          <received-date type="date">2014-03-01</received-date>
+          <reply-by-date type="date">2014-03-21</reply-by-date>
+          <kind>chargeback</kind>
+          <status>under_review</status>
+          <reason>fraud</reason>
+          <id>#{id}</id>
+          <transaction>
+            <id>#{id}</id>
+            <amount>100.00</amount>
+          </transaction>
+          <date-opened type=\"date\">2014-03-21</date-opened>
+        </dispute>
+      XML
+    end
+
     def _old_dispute_opened_sample_xml(id)
       <<-XML
         <dispute>
@@ -521,6 +551,48 @@ module Braintree
       XML
     end
 
+    def _new_dispute_under_review_sample_xml(id)
+      <<-XML
+        <dispute>
+          <id>#{id}</id>
+          <amount>100.00</amount>
+          <amount-disputed>100.00</amount-disputed>
+          <amount-won>95.00</amount-won>
+          <case-number>CASE-12345</case-number>
+          <created-at type="datetime">2017-06-16T20:44:41Z</created-at>
+          <currency-iso-code>USD</currency-iso-code>
+          <forwarded-comments nil="true"/>
+          <kind>chargeback</kind>
+          <merchant-account-id>ytnlulaloidoqwvzxjrdqputg</merchant-account-id>
+          <reason>fraud</reason>
+          <reason-code nil="true"/>
+          <reason-description nil="true"/>
+          <received-date type="date">2016-02-15</received-date>
+          <reference-number>REF-9876</reference-number>
+          <reply-by-date type="date">2016-02-22</reply-by-date>
+          <status>under_review</status>
+          <updated-at type="datetime">2017-06-16T20:44:41Z</updated-at>
+          <original-dispute-id>9qde5qgp</original-dispute-id>
+          <status-history type="array">
+            <status-history>
+              <status>under_review</status>
+              <timestamp type="datetime">2017-06-16T20:44:41Z</timestamp>
+            </status-history>
+          </status-history>
+          <evidence type="array"/>
+          <transaction>
+            <id>#{id}</id>
+            <amount>100.00</amount>
+            <created-at>2017-06-21T20:44:41Z</created-at>
+            <order-id nil="true"/>
+            <purchase-order-number nil="true"/>
+            <payment-instrument-subtype>Visa</payment-instrument-subtype>
+          </transaction>
+          <date-opened type=\"date\">2014-03-21</date-opened>
+        </dispute>
+      XML
+    end
+
     def _new_dispute_opened_sample_xml(id)
       <<-XML
         <dispute>

data/lib/braintree/xml/parser.rb

@@ -32,7 +32,7 @@ module Braintree
         case value.class.to_s
           when "Hash"
             if value["type"] == "array"
-              child_key, entries = value.detect { |k,_v| k != "type" }   # child_key is throwaway
+              _child_key, entries = value.detect { |k,_v| k != "type" }   # child_key is throwaway
               if entries.nil? || ((c = value[CONTENT_ROOT]) && c.strip.empty?)
                 []
               else
@@ -47,7 +47,7 @@ module Braintree
               end
             elsif value.has_key?(CONTENT_ROOT)
               content = value[CONTENT_ROOT]
-              if (parser = XML_PARSING[value["type"]])
+              if (XML_PARSING[value["type"]])
                 XML_PARSING[value["type"]].call(content)
               else
                 content

data/lib/braintree.rb

@@ -156,6 +156,7 @@ require "braintree/transaction/payment_receipt/card_present_data.rb"
 require "braintree/transaction/payment_receipt/merchant_address.rb"
 require "braintree/transaction/meta_checkout_card_details"
 require "braintree/transaction/meta_checkout_token_details"
+require "braintree/transaction/package_details"
 require "braintree/transaction/paypal_details"
 require "braintree/transaction/paypal_here_details"
 require "braintree/transaction/samsung_pay_card_details"

data/spec/integration/braintree/address_spec.rb

@@ -203,7 +203,7 @@ describe Braintree::Address do
 
     it "raises a NotFoundError if it cannot be found because of address id" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
-      address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
+      Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       expect do
         Braintree::Address.find(customer, "invalid")
       end.to raise_error(
@@ -215,7 +215,7 @@ describe Braintree::Address do
   describe "self.update" do
     it "raises NotFoundError if the address can't be found" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
-      address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
+      Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       expect do
         Braintree::Address.update(customer.id, "bad-id", {})
       end.to raise_error(Braintree::NotFoundError)
@@ -293,7 +293,7 @@ describe Braintree::Address do
   describe "self.update!" do
     it "raises NotFoundError if the address can't be found" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
-      address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
+      Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       expect do
         Braintree::Address.update!(customer.id, "bad-id", {})
       end.to raise_error(Braintree::NotFoundError)

data/spec/integration/braintree/advanced_search_spec.rb

@@ -263,19 +263,19 @@ describe Braintree::AdvancedSearch do
   context "multiple_value_or_text_field" do
     describe "in" do
       it "works for the in operator" do
-        subscription1 = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
           :price => "17",
         ).subscription
 
-        subscription2 = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
           :price => "17",
         ).subscription
 
-        subscription3 = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::AddOnDiscountPlan[:id],
           :price => "17",

data/spec/integration/braintree/client_api/client_token_spec.rb

@@ -28,14 +28,12 @@ describe Braintree::ClientToken do
 
     describe "version" do
       it "allows a client token version to be specified" do
-        config = Braintree::Configuration.instantiate
         client_token_string = Braintree::ClientToken.generate(:version => 1)
         client_token = JSON.parse(client_token_string)
         expect(client_token["version"]).to eq(1)
       end
 
       it "defaults to 2" do
-        config = Braintree::Configuration.instantiate
         client_token_string = Braintree::ClientToken.generate
         client_token = decode_client_token(client_token_string)
         expect(client_token["version"]).to eq(2)

data/spec/integration/braintree/client_api/spec_helper.rb

@@ -144,7 +144,7 @@ def generate_invalid_us_bank_account_nonce
   nonce_characters = "bcdfghjkmnpqrstvwxyz23456789".chars.to_a
   nonce = "tokenusbankacct_"
   nonce += 4.times.map { sample(nonce_characters) }.join("_")
-  nonce += "_xxx"
+  nonce + "_xxx"
 end
 
 def _cosmos_post(token, url, payload)

data/spec/integration/braintree/credit_card_spec.rb

@@ -276,7 +276,7 @@ describe Braintree::CreditCard do
         :customer_id => customer.id,
         :payment_method_nonce => Braintree::Test::Nonce::Transactable,
         :three_d_secure_pass_thru => {
-          :eci_flag => "02",
+          :eci_flag => "05",
           :cavv => "some_cavv",
           :xid => "some_xid",
           :authentication_response => "Y",
@@ -298,7 +298,7 @@ describe Braintree::CreditCard do
         :customer_id => customer.id,
         :payment_method_nonce => Braintree::Test::Nonce::Transactable,
         :three_d_secure_pass_thru => {
-          :eci_flag => "02",
+          :eci_flag => "05",
           :cavv => "some_cavv",
           :xid => "some_xid",
           :three_d_secure_version => "1.0.2",
@@ -310,7 +310,6 @@ describe Braintree::CreditCard do
         :options => {:verify_card => true},
       )
       expect(result.success?).to eq(true)
-
     end
 
     it "returns 3DS info on cc verification" do
@@ -323,16 +322,15 @@ describe Braintree::CreditCard do
       expect(result.success?).to eq(true)
 
       three_d_secure_info = result.credit_card.verification.three_d_secure_info
-      expect(three_d_secure_info.enrolled).to eq("Y")
+      expect(three_d_secure_info.status).to eq("authenticate_successful")
       expect(three_d_secure_info).to be_liability_shifted
       expect(three_d_secure_info).to be_liability_shift_possible
-      expect(three_d_secure_info.status).to eq("authenticate_successful")
-      expect(three_d_secure_info.cavv).to eq("cavv_value")
-      expect(three_d_secure_info.xid).to eq("xid_value")
-      expect(three_d_secure_info.eci_flag).to eq("05")
-      expect(three_d_secure_info.three_d_secure_version).to eq("1.0.2")
-      expect(three_d_secure_info.ds_transaction_id).to eq(nil)
-      expect(three_d_secure_info.three_d_secure_authentication_id).not_to be_nil
+      expect(three_d_secure_info.enrolled).to be_a(String)
+      expect(three_d_secure_info.cavv).to be_a(String)
+      expect(three_d_secure_info.xid).to be_a(String)
+      expect(three_d_secure_info.eci_flag).to be_a(String)
+      expect(three_d_secure_info.three_d_secure_version).to be_a(String)
+      expect(three_d_secure_info.three_d_secure_authentication_id).to be_a(String)
     end
 
     it "adds credit card with billing address to customer" do
@@ -650,7 +648,6 @@ describe Braintree::CreditCard do
       end
 
       it "errors with invalid account_type" do
-        customer = Braintree::Customer.create!
         result = Braintree::CreditCard.create(
           :number => Braintree::Test::CreditCardNumbers::Hiper,
           :expiration_month => "11",
@@ -667,7 +664,6 @@ describe Braintree::CreditCard do
       end
 
       it "errors when account_type not supported by merchant" do
-        customer = Braintree::Customer.create!
         result = Braintree::CreditCard.create(
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_month => "11",
@@ -793,7 +789,7 @@ describe Braintree::CreditCard do
       result = Braintree::CreditCard.update(credit_card.token,
         :payment_method_nonce => Braintree::Test::Nonce::Transactable,
         :three_d_secure_pass_thru => {
-          :eci_flag => "02",
+          :eci_flag => "05",
           :cavv => "some_cavv",
           :xid => "some_xid",
           :authentication_response => "Y",
@@ -821,7 +817,7 @@ describe Braintree::CreditCard do
       result = Braintree::CreditCard.update(credit_card.token,
         :payment_method_nonce => Braintree::Test::Nonce::Transactable,
         :three_d_secure_pass_thru => {
-          :eci_flag => "02",
+          :eci_flag => "05",
           :cavv => "some_cavv",
           :three_d_secure_version=> "2.1.0",
           :xid => "some_xid",

data/spec/integration/braintree/credit_card_verification_spec.rb

@@ -283,7 +283,7 @@ describe Braintree::CreditCardVerification, "search" do
       it "returns prepaid on a prepaid card" do
         cardholder_name = "Tom #{rand(1_000_000)} Smith"
 
-        result = Braintree::Customer.create(
+        Braintree::Customer.create(
           :credit_card => {
           :cardholder_name => cardholder_name,
           :expiration_date => "05/2012",
@@ -405,7 +405,7 @@ describe Braintree::CreditCardVerification, "search" do
           :amount => "10.00",
         },
         :three_d_secure_pass_thru => {
-          :eci_flag => "02",
+          :eci_flag => "05",
           :cavv => "some_cavv",
           :xid => "some_xid",
           :three_d_secure_version => "1.0.2",