braintree 3.2.0 → 4.2.0

data/spec/unit/braintree/paypal_account_spec.rb

@@ -8,7 +8,7 @@ describe Braintree::PayPalAccount do
           :invalid_key => "bad stuff",
           :options => {
             :invalid_option => "bad option",
-          }
+          },
         )
       end.to raise_error(ArgumentError, "invalid keys: invalid_key, options[invalid_option]")
     end
@@ -17,7 +17,7 @@ describe Braintree::PayPalAccount do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::PayPalAccount.update("some_token", :invalid_key => 'val')
+        Braintree::PayPalAccount.update("some_token", :invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end

data/spec/unit/braintree/resource_collection_spec.rb

@@ -5,7 +5,7 @@ describe "Braintree::ResourceCollection" do
     it "iterates over the elements, yielding to the block in pages" do
       values = %w(a b c d e)
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
-        ids.map {|id| values[id] }
+        ids.map { |id| values[id] }
       end
 
       count = 0
@@ -19,30 +19,30 @@ describe "Braintree::ResourceCollection" do
   end
 
   describe "#first" do
-    it 'returns nil with no results' do
+    it "returns nil with no results" do
       values = %w(a b c d e)
       collection = Braintree::ResourceCollection.new(:search_results => {:ids => [], :page_size => 2}) do |ids|
-        ids.map {|id| values[id] }
+        ids.map { |id| values[id] }
       end
 
       collection.first.should == nil
     end
 
-    context 'with results' do
+    context "with results" do
       let(:collection) do
         values = %w(a b c d e)
 
         Braintree::ResourceCollection.new(:search_results => {:ids => [0,1,2,3,4], :page_size => 2}) do |ids|
-          ids.map {|id| values[id] }
+          ids.map { |id| values[id] }
         end
       end
 
-      it 'returns the first occourence' do
-        collection.first.should == 'a'
+      it "returns the first occourence" do
+        collection.first.should == "a"
       end
 
-      it 'returns the first N occourences' do
-        collection.first(4).should == ['a','b','c','d']
+      it "returns the first N occourences" do
+        collection.first(4).should == ["a","b","c","d"]
       end
     end
   end

data/spec/unit/braintree/risk_data_spec.rb

@@ -2,12 +2,14 @@ require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
 
 describe Braintree::RiskData do
   describe "#initialize" do
-    it "sets id, decision and device_data_captured" do
-      risk_data = Braintree::RiskData.new(:id => "123", :decision => "YOU WON $1000 DOLLARS", :device_data_captured => true, :fraud_service_provider => "kount")
+    it "sets id, decision, device_data_captured, decision_reasons and transaction_risk_score" do
+      risk_data = Braintree::RiskData.new(:id => "123", :decision => "YOU WON $1000 DOLLARS", :device_data_captured => true, :fraud_service_provider => "fraud_protection", :decision_reasons => ["reason"], :transaction_risk_score => "12")
       risk_data.id.should == "123"
       risk_data.decision.should == "YOU WON $1000 DOLLARS"
       risk_data.device_data_captured.should be_truthy
-      risk_data.fraud_service_provider.should == "kount"
+      risk_data.fraud_service_provider.should == "fraud_protection"
+      risk_data.decision_reasons.should == ["reason"]
+      risk_data.transaction_risk_score.should == "12"
     end
   end
 
@@ -16,10 +18,12 @@ describe Braintree::RiskData do
       details = Braintree::RiskData.new(
         :id => "123",
         :decision => "YOU WON $1000 DOLLARS",
+        :decision_reasons => ["reason"],
         :device_data_captured => true,
-        :fraud_service_provider => "kount",
+        :fraud_service_provider => "fraud_protection",
+        :transaction_risk_score => "12",
       )
-      details.inspect.should == %(#<RiskData id: "123", decision: "YOU WON $1000 DOLLARS", device_data_captured: true, fraud_service_provider: "kount">)
+      details.inspect.should == %(#<RiskData id: "123", decision: "YOU WON $1000 DOLLARS", decision_reasons: ["reason"], device_data_captured: true, fraud_service_provider: "fraud_protection", transaction_risk_score: "12">)
     end
   end
 end

data/spec/unit/braintree/subscription_search_spec.rb

@@ -11,7 +11,7 @@ module Braintree
             Subscription::Status::Active,
             Subscription::Status::Canceled,
             Subscription::Status::Expired,
-            Subscription::Status::PastDue
+            Subscription::Status::PastDue,
           )
         end.should_not raise_error
       end

data/spec/unit/braintree/successful_result_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::SuccessfulResult do
     it "sets instance variables from the values in the hash" do
       result = Braintree::SuccessfulResult.new(
         :transaction => "transaction_value",
-        :credit_card => "credit_card_value"
+        :credit_card => "credit_card_value",
       )
       result.success?.should == true
       result.transaction.should == "transaction_value"

data/spec/unit/braintree/three_d_secure_info_spec.rb

@@ -3,37 +3,55 @@ require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
 describe Braintree::ThreeDSecureInfo do
   let(:three_d_secure_info) {
     Braintree::ThreeDSecureInfo.new(
+      :acs_transaction_id => "acs_id",
+      :cavv => "cavvvalue",
+      :ds_transaction_id => "dstrxid",
+      :eci_flag => "06",
       :enrolled => "Y",
-      :liability_shifted => true,
       :liability_shift_possible => true,
-      :cavv => "cavvvalue",
-      :xid => "xidvalue",
+      :liability_shifted => true,
+      :pares_status => "Y",
       :status => "authenticate_successful",
-      :eci_flag => "06",
-      :three_d_secure_version => "1.0.2",
-      :ds_transaction_id => "dstrxid",
       :three_d_secure_authentication_id => "auth_id",
+      :three_d_secure_transaction_id => "trans_id",
+      :three_d_secure_version => "1.0.2",
+      :xid => "xidvalue",
+      :authentication => {
+        :trans_status => "authstatus",
+        :trans_status_reason => "authstatusreason"
+      },
+      :lookup => {
+        :trans_status => "lookupstatus",
+        :trans_status_reason => "lookupstatusreason"
+      },
     )
   }
 
   describe "#initialize" do
     it "sets attributes" do
-      three_d_secure_info.enrolled.should == "Y"
-      three_d_secure_info.status.should == "authenticate_successful"
-      three_d_secure_info.liability_shifted.should == true
-      three_d_secure_info.liability_shift_possible.should == true
+      three_d_secure_info.acs_transaction_id.should == "acs_id"
       three_d_secure_info.cavv.should == "cavvvalue"
-      three_d_secure_info.xid.should == "xidvalue"
-      three_d_secure_info.eci_flag.should == "06"
-      three_d_secure_info.three_d_secure_version.should == "1.0.2"
       three_d_secure_info.ds_transaction_id.should == "dstrxid"
+      three_d_secure_info.eci_flag.should == "06"
+      three_d_secure_info.enrolled.should == "Y"
+      three_d_secure_info.liability_shift_possible.should == true
+      three_d_secure_info.liability_shifted.should == true
+      three_d_secure_info.pares_status.should == "Y"
+      three_d_secure_info.status.should == "authenticate_successful"
       three_d_secure_info.three_d_secure_authentication_id.should == "auth_id"
+      three_d_secure_info.three_d_secure_transaction_id.should == "trans_id"
+      three_d_secure_info.three_d_secure_version.should == "1.0.2"
+      three_d_secure_info.xid.should == "xidvalue"
+      three_d_secure_info.lookup[:trans_status].should == "lookupstatus"
+      three_d_secure_info.lookup[:trans_status_reason].should == "lookupstatusreason"
+      three_d_secure_info.authentication[:trans_status].should == "authstatus"
+      three_d_secure_info.authentication[:trans_status_reason].should == "authstatusreason"
     end
   end
 
   describe "inspect" do
     it "prints the attributes" do
-      three_d_secure_info.inspect.should == %(#<ThreeDSecureInfo enrolled: "Y", liability_shifted: true, liability_shift_possible: true, status: "authenticate_successful", cavv: "cavvvalue", xid: "xidvalue", eci_flag: "06", three_d_secure_version: "1.0.2", ds_transaction_id: "dstrxid", three_d_secure_authentication_id: "auth_id">)
+      three_d_secure_info.inspect.should == %(#<ThreeDSecureInfo acs_transaction_id: "acs_id", authentication: {:trans_status=>"authstatus", :trans_status_reason=>"authstatusreason"}, cavv: "cavvvalue", ds_transaction_id: "dstrxid", eci_flag: "06", enrolled: "Y", liability_shift_possible: true, liability_shifted: true, lookup: {:trans_status=>"lookupstatus", :trans_status_reason=>"lookupstatusreason"}, pares_status: "Y", status: "authenticate_successful", three_d_secure_authentication_id: "auth_id", three_d_secure_transaction_id: "trans_id", three_d_secure_version: "1.0.2", xid: "xidvalue">)
     end
   end
 

data/spec/unit/braintree/transaction/credit_card_details_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::Transaction::CreditCardDetails do
     it "concats expiration_month and expiration_year" do
       details = Braintree::Transaction::CreditCardDetails.new(
         :expiration_month => "08",
-        :expiration_year => "2009"
+        :expiration_year => "2009",
       )
       details.expiration_date.should == "08/2009"
     end
@@ -32,7 +32,7 @@ describe Braintree::Transaction::CreditCardDetails do
         :country_of_issuance => "Lilliput",
         :issuing_bank => "Gulliver Bank",
         :image_url => "example.com/visa.png",
-        :unique_number_identifier => "abc123"
+        :unique_number_identifier => "abc123",
       )
       details.inspect.should == %(#<token: "token", bin: "123456", last_4: "6789", card_type: "Visa", expiration_date: "05/2012", cardholder_name: "The Cardholder", customer_location: "US", prepaid: "Yes", healthcare: "No", durbin_regulated: "No", debit: "Yes", commercial: "Unknown", payroll: "Unknown", product_id: "Unknown", country_of_issuance: "Lilliput", issuing_bank: "Gulliver Bank", image_url: "example.com/visa.png", unique_number_identifier: "abc123">)
     end
@@ -41,7 +41,7 @@ describe Braintree::Transaction::CreditCardDetails do
   describe "masked_number" do
     it "concatenates the bin, some *'s, and the last_4" do
       details = Braintree::Transaction::CreditCardDetails.new(
-        :bin => "510510", :last_4 => "5100"
+        :bin => "510510", :last_4 => "5100",
       )
       details.masked_number.should == "510510******5100"
     end

data/spec/unit/braintree/transaction/customer_details_spec.rb

@@ -11,7 +11,7 @@ describe Braintree::Transaction::CustomerDetails do
         :company => "Smith Co.",
         :website => "http://www.example.com",
         :phone => "6145551234",
-        :fax => "3125551234"
+        :fax => "3125551234",
       )
       details.inspect.should == %(#<id: "id", first_name: "Amy", last_name: "Smith", email: "amy.smith@example.com", company: "Smith Co.", website: "http://www.example.com", phone: "6145551234", fax: "3125551234">)
     end

data/spec/unit/braintree/transaction/deposit_details_spec.rb

@@ -4,13 +4,13 @@ describe Braintree::Transaction::DisbursementDetails do
   describe "valid?" do
     it "returns true if disbursement details are initialized" do
       details = Braintree::Transaction::DisbursementDetails.new(
-        :disbursement_date => Date.new(2013, 4, 1)
+        :disbursement_date => Date.new(2013, 4, 1),
       )
       details.valid?.should == true
     end
     it "returns true if disbursement details are initialized" do
       details = Braintree::Transaction::DisbursementDetails.new(
-        :disbursement_date => nil
+        :disbursement_date => nil,
       )
       details.valid?.should == false
     end

data/spec/unit/braintree/transaction/paypal_details_spec.rb

@@ -27,7 +27,7 @@ describe Braintree::Transaction::PayPalDetails do
         :seller_protection_status => "seller-protection-status",
         :token => "token",
         :transaction_fee_amount => "2.00",
-        :transaction_fee_currency_iso_code => "123"
+        :transaction_fee_currency_iso_code => "123",
       )
 
       expect(details.authorization_id).to eq("id")

data/spec/unit/braintree/transaction_search_spec.rb

@@ -1,19 +1,19 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
 describe Braintree::TransactionSearch do
-	it "overrides previous 'is' with new 'is' for the same field" do
-		search = Braintree::TransactionSearch.new
-		search.billing_company.is "one"
-		search.billing_company.is "two"
-		search.to_hash.should == {:billing_company => {:is => "two"}}
-	end
+  it "overrides previous 'is' with new 'is' for the same field" do
+    search = Braintree::TransactionSearch.new
+    search.billing_company.is "one"
+    search.billing_company.is "two"
+    search.to_hash.should == {:billing_company => {:is => "two"}}
+  end
 
-	it "overrides previous 'in' with new 'in' for the same field" do
-		search = Braintree::TransactionSearch.new
-		search.status.in Braintree::Transaction::Status::Authorized
-		search.status.in Braintree::Transaction::Status::SubmittedForSettlement
-		search.to_hash.should == {:status => [Braintree::Transaction::Status::SubmittedForSettlement]}
-	end
+  it "overrides previous 'in' with new 'in' for the same field" do
+    search = Braintree::TransactionSearch.new
+    search.status.in Braintree::Transaction::Status::Authorized
+    search.status.in Braintree::Transaction::Status::SubmittedForSettlement
+    search.to_hash.should == {:status => [Braintree::Transaction::Status::SubmittedForSettlement]}
+  end
 
   it "raises if the operator 'is' is left off" do
     search = Braintree::TransactionSearch.new

data/spec/unit/braintree/transaction_spec.rb

@@ -45,6 +45,14 @@ describe Braintree::Transaction do
     end
   end
 
+  describe "self.adjust_authorization" do
+    it "raises an ArgumentError if transaction_id is an invalid format" do
+      expect do
+        Braintree::Transaction.adjust_authorization("invalid-transaction-id", "10.00")
+      end.to raise_error(ArgumentError, "transaction_id is invalid")
+    end
+  end
+
   describe "self.update_details" do
     it "raises an ArgumentError if transaction_id is an invalid format" do
       expect do
@@ -66,7 +74,7 @@ describe Braintree::Transaction do
           :website => "lednerllc.com",
           :phone => "1-999-652-4189 x56883",
           :fax => "012-161-8055"
-        }
+        },
       )
       transaction.customer_details.id.should == "123"
       transaction.customer_details.first_name.should == "Adam"
@@ -88,7 +96,7 @@ describe Braintree::Transaction do
           :settlement_currency_exchange_rate => "1",
           :funds_held => false,
           :success => true
-        }
+        },
       )
       disbursement = transaction.disbursement_details
       disbursement.disbursement_date.should == Date.parse("2013-04-03")
@@ -119,7 +127,7 @@ describe Braintree::Transaction do
           :product_id => "Unknown",
           :country_of_issuance => "Narnia",
           :issuing_bank => "Mr Tumnus"
-        }
+        },
       )
       transaction.credit_card_details.token.should == "mzg2"
       transaction.credit_card_details.bin.should == "411111"
@@ -147,7 +155,7 @@ describe Braintree::Transaction do
           :liability_shifted => true,
           :liability_shift_possible => true,
           :status => "authenticate_successful",
-        }
+        },
       )
 
       transaction.three_d_secure_info.enrolled.should == "Y"
@@ -161,9 +169,9 @@ describe Braintree::Transaction do
       transaction = Braintree::Transaction._new(
         :gateway,
         :status_history => [
-          { :timestamp => time, :amount => "12.00", :transaction_source => "API",
-            :user => "larry", :status => Braintree::Transaction::Status::Authorized },
-          { :timestamp => Time.utc(2010,1,15), :amount => "12.00", :transaction_source => "API",
+          {:timestamp => time, :amount => "12.00", :transaction_source => "API",
+            :user => "larry", :status => Braintree::Transaction::Status::Authorized},
+          {:timestamp => Time.utc(2010,1,15), :amount => "12.00", :transaction_source => "API",
             :user => "curly", :status => "scheduled_for_settlement"}
         ])
       transaction.status_history.size.should == 2
@@ -180,8 +188,8 @@ describe Braintree::Transaction do
       transaction = Braintree::Transaction._new(
         :gateway,
         :authorization_adjustments => [
-          { :timestamp => timestamp, :processor_response_code => "1000", :processor_response_text => "Approved", :amount => "12.00", :success => true },
-          { :timestamp => timestamp, :processor_response_code => "3000", :processor_response_text => "Processor Network Unavailable - Try Again", :amount => "12.34", :success => false },
+          {:timestamp => timestamp, :processor_response_code => "1000", :processor_response_text => "Approved", :amount => "12.00", :success => true},
+          {:timestamp => timestamp, :processor_response_code => "3000", :processor_response_text => "Processor Network Unavailable - Try Again", :amount => "12.34", :success => false},
         ])
       transaction.authorization_adjustments.size.should == 2
       transaction.authorization_adjustments[0].amount.should == "12.00"
@@ -199,7 +207,7 @@ describe Braintree::Transaction do
     it "handles receiving custom as an empty string" do
       transaction = Braintree::Transaction._new(
         :gateway,
-        :custom => "\n    "
+        :custom => "\n    ",
       )
     end
 
@@ -217,7 +225,7 @@ describe Braintree::Transaction do
     it "handles nil risk_data" do
       transaction = Braintree::Transaction._new(
         :gateway,
-        :risk_data => nil
+        :risk_data => nil,
       )
       transaction.risk_data.should be_nil
     end
@@ -225,7 +233,7 @@ describe Braintree::Transaction do
     it "accepts network_transaction_id" do
       transaction = Braintree::Transaction._new(
         :gateway,
-        :network_transaction_id => "123456789012345"
+        :network_transaction_id => "123456789012345",
       )
       transaction.network_transaction_id.should == "123456789012345"
     end
@@ -307,8 +315,8 @@ describe Braintree::Transaction do
   end
 
   describe "sale" do
-    let(:mock_response) { {:transaction => {}}}
-    let(:http_stub) { double('http_stub').as_null_object }
+    let(:mock_response) { {:transaction => {}} }
+    let(:http_stub) { double("http_stub").as_null_object }
 
     RSpec::Matchers.define :skip_advanced_fraud_check_value_is do |value|
         match { |params| params[:transaction][:options][:skip_advanced_fraud_checking] == value }
@@ -326,7 +334,7 @@ describe Braintree::Transaction do
         },
         :options => {
           :skip_advanced_fraud_checking => true
-        }
+        },
       )
     end
 
@@ -342,7 +350,7 @@ describe Braintree::Transaction do
         },
         :options => {
           :skip_advanced_fraud_checking => false
-        }
+        },
       )
     end
 
@@ -358,7 +366,7 @@ describe Braintree::Transaction do
         },
         :options => {
           :submit_for_settlement => false
-        }
+        },
       )
     end
   end

data/spec/unit/braintree/util_spec.rb

@@ -11,12 +11,12 @@ describe Braintree::Util do
     end
 
     it "symbolizes nested keys" do
-      hash = {"a" => {"b" => {"c" => "d" }}}
+      hash = {"a" => {"b" => {"c" => "d"}}}
       Braintree::Util.symbolize_keys(hash).should == {:a => {:b => {:c => "d"}}}
     end
 
     it "symbolizes nested keys in arrays" do
-      hash = {"a" => ["b" => {"c" => "d" }]}
+      hash = {"a" => ["b" => {"c" => "d"}]}
       Braintree::Util.symbolize_keys(hash).should == {:a => [:b => {:c => "d"}]}
     end
   end
@@ -44,7 +44,7 @@ describe Braintree::Util do
             :nested_allowed => "ok",
             :nested_allowed2 => "also ok",
             :nested_invalid => "bad"
-          }
+          },
         )
       end.to raise_error(ArgumentError, "invalid keys: nested[nested_invalid], top_level_invalid")
     end
@@ -57,7 +57,7 @@ describe Braintree::Util do
           :custom_fields => {
             :custom_allowed => "ok",
             :custom_allowed2 => "also ok",
-          }
+          },
         )
       end.to_not raise_error
     end
@@ -70,7 +70,7 @@ describe Braintree::Util do
             :custom_fields => {
               :bad_nesting => "very bad"
             }
-          }
+          },
         )
       end.to raise_error(ArgumentError, "invalid keys: allowed[custom_fields][bad_nesting]")
     end
@@ -89,7 +89,7 @@ describe Braintree::Util do
               :super_deep_allowed => "yep",
               :real_deep_invalid => "nope"
             }
-          }
+          },
         )
       end.to raise_error(ArgumentError, "invalid keys: nested[deeply_allowed][real_deep_invalid], nested[nested_invalid], top_level_invalid")
     end
@@ -101,7 +101,7 @@ describe Braintree::Util do
           :add_ons => {
             :update => [{:amount => 10}],
             :add => [{:amount => 5}]
-          }
+          },
         )
       end.to_not raise_error
     end
@@ -113,7 +113,7 @@ describe Braintree::Util do
           :add_ons => {
             :update => [{:foo => 10}],
             :add => [{:bar => 5}]
-          }
+          },
         )
       end.to raise_error(ArgumentError, /invalid keys: add_ons\[add\]\[bar\], add_ons\[update\]\[foo\]/)
     end
@@ -127,7 +127,7 @@ describe Braintree::Util do
         :custom_fields => {
           :custom_allowed => "ok",
           :custom_allowed2 => "also ok",
-        }
+        },
       )
       expect(response).to eq(true)
     end
@@ -147,7 +147,7 @@ describe Braintree::Util do
         :add_ons => {
           :update => [{:foo => 10}],
           :add => [{:bar => 5}]
-        }
+        },
       )
       expect(response).to eq(false)
     end
@@ -165,7 +165,7 @@ describe Braintree::Util do
             :super_deep_allowed => "yep",
             :real_deep_invalid => "nope"
           }
-        }
+        },
       )
       expect(response).to eq(false)
     end
@@ -200,13 +200,13 @@ describe Braintree::Util do
   describe "self._flatten_valid_keys" do
     it "flattens hash keys" do
       Braintree::Util._flatten_valid_keys(
-        [:top_level, {:nested => [:nested_allowed, :nested_allowed2]}]
+        [:top_level, {:nested => [:nested_allowed, :nested_allowed2]}],
       ).should == ["nested[nested_allowed2]", "nested[nested_allowed]", "top_level"]
     end
 
     it "allows wildcards with the :_any_key_ symbol" do
       Braintree::Util._flatten_valid_keys(
-        [:top_level, {:nested => :_any_key_}]
+        [:top_level, {:nested => :_any_key_}],
       ).should == ["nested[_any_key_]", "top_level"]
     end
   end
@@ -236,11 +236,11 @@ describe Braintree::Util do
       result.should == []
     end
 
-		it "raises an UnexpectedError if nil data is provided" do
-			expect do
-				Braintree::Util.extract_attribute_as_array(nil, :abc)
-			end.to raise_error(Braintree::UnexpectedError, /Unprocessable entity due to an invalid request/)
-		end
+    it "raises an UnexpectedError if nil data is provided" do
+      expect do
+        Braintree::Util.extract_attribute_as_array(nil, :abc)
+      end.to raise_error(Braintree::UnexpectedError, /Unprocessable entity due to an invalid request/)
+    end
   end
 
   describe "self.hash_to_query_string" do