braintree 3.2.0 → 4.2.0

data/spec/spec_helper.rb

@@ -3,6 +3,7 @@ unless defined?(SPEC_HELPER_LOADED)
   project_root = File.expand_path(File.dirname(__FILE__) + "/..")
   require "rubygems"
   require "bundler/setup"
+  require "libxml"
   require "rspec"
   require "pry"
 
@@ -40,6 +41,8 @@ unless defined?(SPEC_HELPER_LOADED)
     AdyenMerchantAccountId = "adyen_ma"
     HiperBRLMerchantAccountId = "hiper_brl"
     CardProcessorBRLMerchantAccountId = "card_processor_brl"
+    FakeFirstDataMerchantAccountId = "fake_first_data_merchant_account"
+    AibSwedenMaMerchantAccountId = "aib_swe_ma"
 
     TrialPlan = {
       :description => "Plan for integration tests -- with trial",
@@ -88,13 +91,13 @@ unless defined?(SPEC_HELPER_LOADED)
                                                       :environment => Braintree::Configuration.environment,
                                                       :merchant_id => "test_merchant_id",
                                                       :public_key => "test_public_key",
-                                                      :private_key => "test_private_key"
+                                                      :private_key => "test_private_key",
                                                       )
 
     def self.make_past_due(subscription, number_of_days_past_due = 1)
       config = Braintree::Configuration.instantiate
       config.http.put(
-        "#{config.base_merchant_path}/subscriptions/#{subscription.id}/make_past_due?days_past_due=#{number_of_days_past_due}"
+        "#{config.base_merchant_path}/subscriptions/#{subscription.id}/make_past_due?days_past_due=#{number_of_days_past_due}",
       )
     end
 
@@ -113,7 +116,7 @@ unless defined?(SPEC_HELPER_LOADED)
       gateway = Braintree::Gateway.new(
         :client_id => "client_id$#{Braintree::Configuration.environment}$integration_client_id",
         :client_secret => "client_secret$#{Braintree::Configuration.environment}$integration_client_secret",
-        :logger => Logger.new("/dev/null")
+        :logger => Logger.new("/dev/null"),
       )
 
       gateway.merchant.create({

data/spec/unit/braintree/address_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Address do
   describe "==" do
     it "returns true if given an address with the same id and customer_id" do
-      first = Braintree::Address._new(:gateway, :customer_id => "c1", :id => 'a1')
+      first = Braintree::Address._new(:gateway, :customer_id => "c1", :id => "a1")
       second = Braintree::Address._new(:gateway, :customer_id => "c1", :id => "a1")
 
       first.should == second

data/spec/unit/braintree/apple_pay_card_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::ApplePayCard do
   describe "bin" do
     it "returns Apple pay card bin" do
-      Braintree::ApplePayCard._new(:gateway, bin: '411111').bin.should == '411111'
+      Braintree::ApplePayCard._new(:gateway, bin: "411111").bin.should == "411111"
     end
   end
 

data/spec/unit/braintree/client_token_spec.rb

@@ -16,7 +16,7 @@ module Braintree
         expect {
           client_token = Braintree::ClientToken.generate(
             :public_key => "bad_key",
-            :created_at => "bad_time"
+            :created_at => "bad_time",
           )
         }.to raise_error(ArgumentError, /created_at, public_key/)
       end
@@ -27,7 +27,7 @@ module Braintree
         it "raises an ArgumentError if #{option_name} is present" do
           expect do
             Braintree::ClientToken.generate(
-              option_name.to_sym => true
+              option_name.to_sym => true,
             )
           end.to raise_error(ArgumentError, /#{option_name}/)
         end

data/spec/unit/braintree/configuration_spec.rb

@@ -1,4 +1,4 @@
-require 'stringio'
+require "stringio"
 
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 
@@ -22,26 +22,26 @@ describe Braintree::Configuration do
   describe "initialize" do
     it "accepts merchant credentials" do
       config = Braintree::Configuration.new(
-        :merchant_id => 'merchant_id',
-        :public_key => 'public_key',
-        :private_key => 'private_key'
+        :merchant_id => "merchant_id",
+        :public_key => "public_key",
+        :private_key => "private_key",
       )
 
-      config.merchant_id.should == 'merchant_id'
-      config.public_key.should == 'public_key'
-      config.private_key.should == 'private_key'
+      config.merchant_id.should == "merchant_id"
+      config.public_key.should == "public_key"
+      config.private_key.should == "private_key"
     end
 
     it "accepts partner credentials" do
       config = Braintree::Configuration.new(
-        :partner_id => 'partner_id',
-        :public_key => 'public_key',
-        :private_key => 'private_key'
+        :partner_id => "partner_id",
+        :public_key => "public_key",
+        :private_key => "private_key",
       )
 
-      config.merchant_id.should == 'partner_id'
-      config.public_key.should == 'public_key'
-      config.private_key.should == 'private_key'
+      config.merchant_id.should == "partner_id"
+      config.public_key.should == "public_key"
+      config.private_key.should == "private_key"
     end
 
     it "raises if combining client_id/secret with access_token" do
@@ -49,7 +49,7 @@ describe Braintree::Configuration do
         Braintree::Configuration.new(
           :client_id => "client_id$development$integration_client_id",
           :client_secret => "client_secret$development$integration_client_secret",
-          :access_token => "access_token$development$integration_merchant_id$fb27c79dd"
+          :access_token => "access_token$development$integration_merchant_id$fb27c79dd",
         )
       end.to raise_error(Braintree::ConfigurationError, /mixed credential types/)
     end
@@ -62,7 +62,7 @@ describe Braintree::Configuration do
           :merchant_id => "merchant_id",
           :public_key => "public_key",
           :private_key => "private_key",
-          :environment => "development"
+          :environment => "development",
         )
       end.to raise_error(Braintree::ConfigurationError, /mixed credential types/)
     end
@@ -96,21 +96,21 @@ describe Braintree::Configuration do
 
     it "accepts proxy params" do
       config = Braintree::Configuration.new(
-        :proxy_address => 'localhost',
+        :proxy_address => "localhost",
         :proxy_port => 8080,
-        :proxy_user => 'user',
-        :proxy_pass => 'test'
+        :proxy_user => "user",
+        :proxy_pass => "test",
       )
 
-      config.proxy_address.should == 'localhost'
+      config.proxy_address.should == "localhost"
       config.proxy_port.should == 8080
-      config.proxy_user.should == 'user'
-      config.proxy_pass.should == 'test'
+      config.proxy_user.should == "user"
+      config.proxy_pass.should == "test"
     end
 
     it "accepts ssl version" do
       config = Braintree::Configuration.new(
-        :ssl_version => :TLSv1_2
+        :ssl_version => :TLSv1_2,
       )
 
       config.ssl_version.should == :TLSv1_2
@@ -146,14 +146,14 @@ describe Braintree::Configuration do
       Braintree::Configuration.environment = :sandbox
       ca_file = Braintree::Configuration.instantiate.ca_file
       ca_file.should match(/api_braintreegateway_com\.ca\.crt$/)
-      File.exists?(ca_file).should == true
+      File.exist?(ca_file).should == true
     end
 
     it "production" do
       Braintree::Configuration.environment = :production
       ca_file = Braintree::Configuration.instantiate.ca_file
       ca_file.should match(/api_braintreegateway_com\.ca\.crt$/)
-      File.exists?(ca_file).should == true
+      File.exist?(ca_file).should == true
     end
   end
 
@@ -238,12 +238,12 @@ describe Braintree::Configuration do
 
     it "allows the environment to be set with a string value" do
       expect do
-        Braintree::Configuration.environment = 'sandbox'
+        Braintree::Configuration.environment = "sandbox"
       end.not_to raise_error
     end
 
     it "sets the environment as a symbol" do
-      Braintree::Configuration.environment = 'sandbox'
+      Braintree::Configuration.environment = "sandbox"
       expect(Braintree::Configuration.environment).to eq :sandbox
     end
   end
@@ -326,15 +326,15 @@ describe Braintree::Configuration do
 
     it "is 3000 or GATEWAY_PORT environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_port = ENV['GATEWAY_PORT']
+      old_gateway_port = ENV["GATEWAY_PORT"]
       begin
-        ENV['GATEWAY_PORT'] = nil
+        ENV["GATEWAY_PORT"] = nil
         Braintree::Configuration.instantiate.port.should == 3000
 
-        ENV['GATEWAY_PORT'] = '1234'
-        Braintree::Configuration.instantiate.port.should == '1234'
+        ENV["GATEWAY_PORT"] = "1234"
+        Braintree::Configuration.instantiate.port.should == "1234"
       ensure
-        ENV['GATEWAY_PORT'] = old_gateway_port
+        ENV["GATEWAY_PORT"] = old_gateway_port
       end
     end
   end
@@ -359,15 +359,15 @@ describe Braintree::Configuration do
   describe "graphql_server" do
     it "is localhost or GRAPHQL_HOST environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_url = ENV['GRAPHQL_HOST']
+      old_gateway_url = ENV["GRAPHQL_HOST"]
       begin
-        ENV['GRAPHQL_HOST'] = nil
+        ENV["GRAPHQL_HOST"] = nil
         Braintree::Configuration.instantiate.graphql_server.should == "graphql.bt.local"
 
-        ENV['GRAPHQL_HOST'] = 'gateway'
-        Braintree::Configuration.instantiate.graphql_server.should == 'gateway'
+        ENV["GRAPHQL_HOST"] = "gateway"
+        Braintree::Configuration.instantiate.graphql_server.should == "gateway"
       ensure
-        ENV['GRAPHQL_HOST'] = old_gateway_url
+        ENV["GRAPHQL_HOST"] = old_gateway_url
       end
     end
   end
@@ -375,15 +375,15 @@ describe Braintree::Configuration do
   describe "server" do
     it "is localhost or GATEWAY_HOST environment variable for development" do
       Braintree::Configuration.environment = :development
-      old_gateway_url = ENV['GATEWAY_HOST']
+      old_gateway_url = ENV["GATEWAY_HOST"]
       begin
-        ENV['GATEWAY_HOST'] = nil
+        ENV["GATEWAY_HOST"] = nil
         Braintree::Configuration.instantiate.server.should == "localhost"
 
-        ENV['GATEWAY_HOST'] = 'gateway'
-        Braintree::Configuration.instantiate.server.should == 'gateway'
+        ENV["GATEWAY_HOST"] = "gateway"
+        Braintree::Configuration.instantiate.server.should == "gateway"
       ensure
-        ENV['GATEWAY_HOST'] = old_gateway_url
+        ENV["GATEWAY_HOST"] = old_gateway_url
       end
     end
 
@@ -468,7 +468,7 @@ describe Braintree::Configuration do
     it "masks the private_key" do
       config = Braintree::Configuration.new(:private_key => "secret_key")
       config.inspect.should include('@private_key="[FILTERED]"')
-      config.inspect.should_not include('secret_key')
+      config.inspect.should_not include("secret_key")
     end
   end
 

data/spec/unit/braintree/credit_card_spec.rb

@@ -4,14 +4,14 @@ describe Braintree::CreditCard do
   describe "self.create" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard.create(:invalid_key => 'val')
+        Braintree::CreditCard.create(:invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
 
   describe "self.create_signature" do
     it "should be what we expect" do
-      Braintree::CreditCardGateway._create_signature.should == [
+      expect(Braintree::CreditCardGateway._create_signature).to match([
         :billing_address_id,
         :cardholder_name,
         :cvv,
@@ -24,7 +24,7 @@ describe Braintree::CreditCard do
         :device_data,
         :payment_method_nonce,
         {:external_vault=>[:network_transaction_id]},
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
+        {:options => match_array([:make_default, :skip_advanced_fraud_checking, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code])},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -51,13 +51,13 @@ describe Braintree::CreditCard do
           :ds_transaction_id,
         ]},
         :customer_id,
-      ]
+      ])
     end
   end
 
   describe "self.update_signature" do
     it "should be what we expect" do
-      Braintree::CreditCardGateway._update_signature.should == [
+      expect(Braintree::CreditCardGateway._update_signature).to match([
         :billing_address_id,
         :cardholder_name,
         :cvv,
@@ -70,7 +70,7 @@ describe Braintree::CreditCard do
         :device_data,
         :payment_method_nonce,
         {:external_vault=>[:network_transaction_id]},
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
+        {:options => match_array([:make_default, :skip_advanced_fraud_checking, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code])},
         {:billing_address => [
           :company,
           :country_code_alpha2,
@@ -97,7 +97,7 @@ describe Braintree::CreditCard do
           :cavv_algorithm,
           :ds_transaction_id,
         ]},
-      ]
+      ])
     end
   end
 
@@ -203,7 +203,7 @@ describe Braintree::CreditCard do
       credit_card = Braintree::CreditCard._new(
         :gateway,
         :bin => "510510",
-        :last_4 => "5100"
+        :last_4 => "5100",
       )
       credit_card.masked_number.should == "510510******5100"
     end
@@ -215,7 +215,7 @@ describe Braintree::CreditCard do
         :gateway,
         :bin => "510510",
         :last_4 => "5100",
-        :is_network_tokenized => true
+        :is_network_tokenized => true,
       )
       credit_card.is_network_tokenized?.should == true
     end
@@ -225,7 +225,7 @@ describe Braintree::CreditCard do
         :gateway,
         :bin => "510510",
         :last_4 => "5100",
-        :is_network_tokenized => false
+        :is_network_tokenized => false,
       )
       credit_card.is_network_tokenized?.should == false
     end
@@ -234,7 +234,7 @@ describe Braintree::CreditCard do
   describe "self.update" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        Braintree::CreditCard.update(:gateway, :invalid_key => 'val')
+        Braintree::CreditCard.update(:gateway, :invalid_key => "val")
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end
@@ -250,8 +250,8 @@ describe Braintree::CreditCard do
   describe "self._new" do
     describe "initializing verification" do
       it "picks the youngest verification" do
-        verification1 = { :created_at => Time.now, :id => 123 }
-        verification2 = { :created_at => Time.now - 3600, :id => 456 }
+        verification1 = {:created_at => Time.now, :id => 123}
+        verification2 = {:created_at => Time.now - 3600, :id => 456}
         credit_card = Braintree::CreditCard._new(Braintree::Configuration.gateway, {:verifications => [verification1, verification2]})
         credit_card.verification.id.should == 123
       end

data/spec/unit/braintree/credit_card_verification_search_spec.rb

@@ -9,7 +9,7 @@ module Braintree
 
         lambda do
           search.credit_card_card_type.in(
-            *Braintree::CreditCard::CardType::All
+            *Braintree::CreditCard::CardType::All,
           )
         end.should_not raise_error
       end

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -30,7 +30,7 @@ describe Braintree::CreditCardVerification do
         :cvv_response_code => "I",
         :processor_response_code => "2000",
         :processor_response_text => "Do Not Honor",
-        :merchant_account_id => "some_id"
+        :merchant_account_id => "some_id",
       )
 
       verification.status.should == Braintree::CreditCardVerification::Status::Verified
@@ -44,7 +44,7 @@ describe Braintree::CreditCardVerification do
 
   it "accepts network_transaction_id" do
     verification = Braintree::CreditCardVerification._new(
-      :network_transaction_id => "123456789012345"
+      :network_transaction_id => "123456789012345",
     )
     expect(verification.network_transaction_id).to eq "123456789012345"
   end
@@ -117,14 +117,18 @@ describe Braintree::CreditCardVerification do
       verification = Braintree::CreditCardVerification._new(:risk_data => {
         :id => "123",
         :decision => "WOO YOU WON $1000 dollars",
+        :decision_reasons => ["reason"],
         :device_data_captured => true,
-        :fraud_service_provider => "kount"
+        :fraud_service_provider => "paypal_fraud_protection",
+        :transaction_risk_score => "12",
       })
 
       verification.risk_data.id.should == "123"
       verification.risk_data.decision.should == "WOO YOU WON $1000 dollars"
+      verification.risk_data.decision_reasons.should == ["reason"]
       verification.risk_data.device_data_captured.should == true
-      verification.risk_data.fraud_service_provider.should == "kount"
+      verification.risk_data.fraud_service_provider.should == "paypal_fraud_protection"
+      verification.risk_data.transaction_risk_score.should == "12"
     end
 
     it "handles a nil risk_data" do

data/spec/unit/braintree/customer_spec.rb

@@ -3,7 +3,7 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Customer do
   describe "inspect" do
     it "includes the id first" do
-      output = Braintree::Customer._new(:gateway, {:first_name => 'Dan', :id => '1234'}).inspect
+      output = Braintree::Customer._new(:gateway, {:first_name => "Dan", :id => "1234"}).inspect
       output.should include("#<Braintree::Customer id: \"1234\",")
     end
 
@@ -18,7 +18,7 @@ describe Braintree::Customer do
         :phone => "802-483-5932",
         :website => "patrick.smith.com",
         :created_at => Time.now,
-        :updated_at => Time.now
+        :updated_at => Time.now,
       )
       output = customer.inspect
       output.should include(%q(company: "Company"))
@@ -31,6 +31,7 @@ describe Braintree::Customer do
       output.should include(%q(addresses: []))
       output.should include(%q(credit_cards: []))
       output.should include(%q(paypal_accounts: []))
+      output.should include(%q(tax_identifiers: []))
       output.should include(%Q(created_at: #{customer.created_at.inspect}))
       output.should include(%Q(updated_at: #{customer.updated_at.inspect}))
     end
@@ -75,7 +76,7 @@ describe Braintree::Customer do
 
   describe "self.create_signature" do
     it "should be what we expect" do
-      Braintree::CustomerGateway._create_signature.should == [
+      expect(Braintree::CustomerGateway._create_signature).to match([
         :company,
         :email,
         :fax,
@@ -100,7 +101,7 @@ describe Braintree::Customer do
           :device_data,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
-          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code]},
+          {:options => match_array([:make_default, :skip_advanced_fraud_checking, :verification_merchant_account_id, :verify_card, :verification_amount, :venmo_sdk_session, :fail_on_duplicate_payment_method, :verification_account_type, :verification_currency_iso_code])},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -133,6 +134,10 @@ describe Braintree::Customer do
           :billing_agreement_id,
           {:options => [:make_default]},
         ]},
+        {:tax_identifiers => [
+          :country_code,
+          :identifier
+        ]},
         {:options =>
           [:paypal => [
             :payee_email,
@@ -158,13 +163,13 @@ describe Braintree::Customer do
           ]]
         },
         {:custom_fields => :_any_key_}
-      ]
+      ])
     end
   end
 
   describe "self.update_signature" do
     it "should be what we expect" do
-      Braintree::CustomerGateway._update_signature.should == [
+      expect(Braintree::CustomerGateway._update_signature).to match([
         :company,
         :email,
         :fax,
@@ -189,8 +194,9 @@ describe Braintree::Customer do
           :device_data,
           :payment_method_nonce,
           {:external_vault=>[:network_transaction_id]},
-          {:options => [
+          {:options => match_array([
             :make_default,
+            :skip_advanced_fraud_checking,
             :verification_merchant_account_id,
             :verify_card,
             :verification_amount,
@@ -199,7 +205,7 @@ describe Braintree::Customer do
             :verification_account_type,
             :verification_currency_iso_code,
             :update_existing_token
-          ]},
+          ])},
           {:billing_address => [
             :company,
             :country_code_alpha2,
@@ -227,6 +233,10 @@ describe Braintree::Customer do
             :ds_transaction_id,
           ]},
         ]},
+        {:tax_identifiers => [
+          :country_code,
+          :identifier
+        ]},
         {:options =>
           [:paypal => [
             :payee_email,
@@ -252,7 +262,7 @@ describe Braintree::Customer do
           ]]
         },
         {:custom_fields => :_any_key_}
-      ]
+      ])
     end
   end
 
@@ -290,7 +300,7 @@ describe Braintree::Customer do
         :paypal_accounts => [
           {:token => "paypal_1"},
           {:token => "paypal_2"}
-        ]
+        ],
       )
 
       customer.credit_cards.size.should == 2