bolt 0.16.0 → 0.16.1

data/vendored/puppet/lib/puppet/pops/parser/locator.rb

@@ -43,11 +43,7 @@ class Locator
   def char_offset(byte_offset)
   end
 
-  # Returns the length measured in number of characters from the given start and end reported offset
-  def char_length(offset, end_offset)
-  end
-
-  # Returns the length measured in number of characters from the given start and end byte offseta
+  # Returns the length measured in number of characters from the given start and end byte offset
   def char_length(offset, end_offset)
   end
 
@@ -326,7 +322,7 @@ class Locator
       string.byteslice(0, byte_offset).length
     end
 
-    # Returns the length measured in number of characters from the given start and end byte offseta
+    # Returns the length measured in number of characters from the given start and end byte offset
     def char_length(offset, end_offset)
       string.byteslice(offset, end_offset - offset).length
     end

data/vendored/puppet/lib/puppet/pops/resource/param.rb

@@ -15,7 +15,7 @@
 module Puppet::Pops
 module Resource
 class Param
-  # This make this class instantiateable from Puppet
+  # This make this class instantiable from Puppet
   include Puppet::Pops::Types::PuppetObject
 
   def self.register_ptype(loader, ir)

data/vendored/puppet/lib/puppet/pops/resource/resource_type_impl.rb

@@ -11,7 +11,7 @@ def self.register_ptypes(loader, ir)
 end
 
 class ResourceTypeImpl
-  # Make instances of this class directly createable from the Puppet Language
+  # Make instances of this class directly creatable from the Puppet Language
   # as object.
   #
   include Puppet::Pops::Types::PuppetObject

data/vendored/puppet/lib/puppet/pops/types/iterable.rb

@@ -33,7 +33,7 @@ module Puppet::Pops::Types
       iter
     end
 
-    # Produces an `Iterable` for one of the following types with the following characterstics:
+    # Produces an `Iterable` for one of the following types with the following characteristics:
     #
     # `String`       - yields each character in the string
     # `Array`        - yields each element in the array

data/vendored/puppet/lib/puppet/pops/types/tree_iterators.rb

@@ -67,7 +67,7 @@ class TreeIterator
     false
   end
 
-  def to_array
+  def to_a
     result = []
     loop do
       result << self.next
@@ -75,6 +75,10 @@ class TreeIterator
     result
   end
 
+  def to_array
+    to_a
+  end
+
   def reverse_each(&block)
     r = Iterator.new(PAnyType::DEFAULT, to_array.reverse_each)
     block_given? ? r.each(&block) : r

data/vendored/puppet/lib/puppet/pops/types/type_acceptor.rb

@@ -10,7 +10,7 @@ module Types
 #
 module TypeAcceptor
   # @param type [PAnyType] the type that we accept a visit from
-  # @param quard [RecursionGuard] the guard against self recursion
+  # @param guard [RecursionGuard] the guard against self recursion
   def visit(type, guard)
   end
 end

data/vendored/puppet/lib/puppet/pops/types/type_calculator.rb

@@ -108,7 +108,7 @@ class TypeCalculator
   # Answers, does the given callable accept the arguments given in args (an array or a tuple)
   # @param callable [PCallableType] - the callable
   # @param args [PArrayType, PTupleType] args optionally including a lambda callable at the end
-  # @return [Boolan] true if the callable accepts the arguments
+  # @return [Boolean] true if the callable accepts the arguments
   #
   # @api public
   def self.callable?(callable, args)

data/vendored/puppet/lib/puppet/pops/types/type_with_members.rb

@@ -1,7 +1,7 @@
 module Puppet::Pops
 module Types
 
-# Interface implemented by a type that has IvocableMembers
+# Interface implemented by a type that has InvocableMembers
 module TypeWithMembers
   # @return [InvocableMember,nil] An invocable member if it exists, or `nil`
   def [](member_name)

data/vendored/puppet/lib/puppet/pops/types/types.rb

@@ -346,7 +346,7 @@ class PAnyType < TypedModelObject
   # Answers the question if instances of this type can represent themselves as a string that
   # can then be passed to the create method
   #
-  # @return [Boolean] wether or not the instance has a canonical string representation
+  # @return [Boolean] whether or not the instance has a canonical string representation
   def roundtrip_with_string?
     false
   end

data/vendored/puppet/lib/puppet/provider/package/yum.rb

@@ -145,7 +145,7 @@ Puppet::Type.type(:package).provide :yum, :parent => :rpm, :source => :rpm do
     # Quote the DNF docs:
     # "Yum does this if its obsoletes config option is enabled but
     # the behavior is not properly documented and can be harmful."
-    # So we'll stick with the safter option
+    # So we'll stick with the safer option
     # If a user wants to remove obsoletes, they can use { :install_options => '--obsoletes' }
     # More detail here: https://bugzilla.redhat.com/show_bug.cgi?id=1096506
     'update'

data/vendored/puppet/lib/puppet/provider/service/redhat.rb

@@ -33,8 +33,9 @@ Puppet::Type.type(:service).provide :redhat, :parent => :init, :source => :init
     end
 
     # For Suse OS family, chkconfig returns 0 even if the service is disabled or non-existent
-    # Therefore, check the output for '<name>  on' to see if it is enabled
-    return :false unless Facter.value(:osfamily) != 'Suse' || output =~ /^#{name}\s+on$/
+    # Therefore, check the output for '<name>  on' (or '<name>  B for boot services)
+    # to see if it is enabled
+    return :false unless Facter.value(:osfamily) != 'Suse' || output =~ /^#{name}\s+(on|B)$/
 
     :true
   end

data/vendored/puppet/lib/puppet/provider/service/systemd.rb

@@ -179,7 +179,7 @@ Puppet::Type.type(:service).provide :systemd, :parent => :base do
   def prepare_error_message(name, action, exception)
     error_return = "Systemd #{action} for #{name} failed!\n"
     journalctl_command = "journalctl -n 50 --since '5 minutes ago' -u #{name} --no-pager"
-    Puppet.debug("Runing journalctl command to get logs for systemd #{action} failure: #{journalctl_command}")
+    Puppet.debug("Running journalctl command to get logs for systemd #{action} failure: #{journalctl_command}")
     journalctl_output = execute(journalctl_command)
     error_return << "journalctl log for #{name}:\n#{journalctl_output}"
   end

data/vendored/puppet/lib/puppet/provider/ssh_authorized_key/parsed.rb

@@ -58,7 +58,7 @@ Puppet::Type.type(:ssh_authorized_key).provide(
 
     Puppet::Util::SUIDManager.asuser(@resource.should(:user)) do
         unless Puppet::FileSystem.exist?(dir = File.dirname(target))
-          Puppet.debug "Creating #{dir}"
+          Puppet.debug "Creating #{dir} as #{@resource.should(:user)}"
           Dir.mkdir(dir, dir_perm)
         end
 

data/vendored/puppet/lib/puppet/resource/type.rb

@@ -43,7 +43,7 @@ class Puppet::Resource::Type
   #   :capability  - the type name of the capres produced/consumed
   #   :mappings    - a hash of attribute_name => Expression
   # These two attributes are populated in
-  # PopsBridge::instantiate_CapabilityMaping
+  # PopsBridge::instantiate_CapabilityMapping
 
   # Map from argument (aka parameter) names to Puppet Type
   # @return [Hash<Symbol, Puppet::Pops::Types::PAnyType] map from name to type

data/vendored/puppet/lib/puppet/settings/base_setting.rb

@@ -98,7 +98,7 @@ class Puppet::Settings::BaseSetting
     @iscreated
   end
 
-  # short name for the celement
+  # short name for the element
   def short=(value)
     raise ArgumentError, _("Short names can only be one character.") if value.to_s.length != 1
     @short = value.to_s

data/vendored/puppet/lib/puppet/settings/ini_file.rb

@@ -12,7 +12,7 @@ class Puppet::Settings::IniFile
   def self.parse(config_fh)
     config = new([DefaultSection.new])
     config_fh.each_line do |line|
-      case line
+      case line.chomp
       when /^(\s*)\[([[:word:]]+)\](\s*)$/
         config.append(SectionLine.new($1, $2, $3))
       when /^(\s*)([[:word:]]+)(\s*=\s*)(.*?)(\s*)$/
@@ -34,6 +34,15 @@ class Puppet::Settings::IniFile
     @lines << line
   end
 
+  def delete(section, name)
+    delete_offset = @lines.index(setting(section, name))
+    next_offset = delete_offset + 1
+    if next_offset < @lines.length
+      @lines[next_offset].previous = @lines[delete_offset].previous
+    end
+    @lines.delete_at(delete_offset)
+  end
+
   def insert_after(line, new_line)
     new_line.previous = line
 
@@ -122,6 +131,14 @@ class Puppet::Settings::IniFile
       end
     end
 
+    def delete(section_name, name)
+      setting = @config.setting(section_name, name)
+      if setting
+        @config.delete(section_name, name)
+        setting.to_s.chomp
+      end
+    end
+
     private
 
     def add_setting(section_name, name, value)
@@ -154,20 +171,24 @@ class Puppet::Settings::IniFile
   Line = Struct.new(:text) do
     include LineNumber
 
+    def to_s
+      text
+    end
+
     def write(fh)
-      fh.puts(text)
+      fh.puts(to_s)
     end
   end
 
   SettingLine = Struct.new(:prefix, :name, :infix, :value, :suffix) do
     include LineNumber
 
+    def to_s
+      "#{prefix}#{name}#{infix}#{value}#{suffix}"
+    end
+
     def write(fh)
-      fh.write(prefix)
-      fh.write(name)
-      fh.write(infix)
-      fh.write(value)
-      fh.puts(suffix)
+      fh.puts(to_s)
     end
 
     def ==(other)
@@ -178,12 +199,12 @@ class Puppet::Settings::IniFile
   SectionLine = Struct.new(:prefix, :name, :suffix) do
     include LineNumber
 
+    def to_s
+      "#{prefix}[#{name}]#{suffix}"
+    end
+
     def write(fh)
-      fh.write(prefix)
-      fh.write("[")
-      fh.write(name)
-      fh.write("]")
-      fh.puts(suffix)
+      fh.puts(to_s)
     end
   end
 

data/vendored/puppet/lib/puppet/ssl/certificate_request.rb

@@ -109,7 +109,7 @@ DOC
 
   def ext_value_to_ruby_value(asn1_arr)
     # A list of ASN1 types than can't be directly converted to a Ruby type
-    @non_convertable ||= [OpenSSL::ASN1::EndOfContent,
+    @non_convertible ||= [OpenSSL::ASN1::EndOfContent,
                           OpenSSL::ASN1::BitString,
                           OpenSSL::ASN1::Null,
                           OpenSSL::ASN1::Enumerated,
@@ -130,7 +130,7 @@ DOC
     # type, use the original ASN1 value. This is needed to work around a bug
     # in Ruby's OpenSSL library which doesn't convert the value of unknown
     # extension OIDs properly. See PUP-3560
-    if @non_convertable.include?(asn1_val.class) then
+    if @non_convertible.include?(asn1_val.class) then
       # Allows OpenSSL to take the ASN1 value and turn it into something Ruby understands
       OpenSSL::X509::Extension.new(asn1_arr.first.value, asn1_val.to_der).value
     else

data/vendored/puppet/lib/puppet/transaction.rb

@@ -28,7 +28,7 @@ class Puppet::Transaction
   # Handles most of the actual interacting with resources
   attr_reader :resource_harness
 
-  attr_reader :prefetched_providers
+  attr_reader :prefetched_providers, :prefetch_failed_providers
 
   # @!attribute [r] persistence
   #   @return [Puppet::Transaction::Persistence] persistence object for cross
@@ -54,6 +54,8 @@ class Puppet::Transaction
     @resource_harness = Puppet::Transaction::ResourceHarness.new(self)
 
     @prefetched_providers = Hash.new { |h,k| h[k] = {} }
+
+    @prefetch_failed_providers = Hash.new { |h,k| h[k] = {} }
   end
 
   # Invoke the pre_run_check hook in every resource in the catalog.
@@ -175,9 +177,9 @@ class Puppet::Transaction
       if resource.is_a?(Puppet::Type::Component)
         Puppet.warning _("Somehow left a component in the relationship graph")
       else
-        resource.info _("Starting to evaluate the resource") if Puppet[:evaltrace] and @catalog.host_config?
+        resource.info _("Starting to evaluate the resource") if Puppet[:evaltrace] && @catalog.host_config?
         seconds = thinmark { block.call(resource) }
-        resource.info _("Evaluated in %{seconds} seconds") % { seconds: "%0.2f" % seconds } if Puppet[:evaltrace] and @catalog.host_config?
+        resource.info _("Evaluated in %{seconds} seconds") % { seconds: "%0.2f" % seconds } if Puppet[:evaltrace] && @catalog.host_config?
       end
     end
 
@@ -231,7 +233,11 @@ class Puppet::Transaction
 
   def prefetch_if_necessary(resource)
     provider_class = resource.provider.class
-    return unless provider_class.respond_to?(:prefetch) and !prefetched_providers[resource.type][provider_class.name]
+    if !provider_class.respond_to?(:prefetch) or
+        prefetched_providers[resource.type][provider_class.name] or
+        prefetch_failed_providers[resource.type][provider_class.name]
+      return
+    end
 
     resources = resources_by_provider(resource.type, provider_class.name)
 
@@ -302,14 +308,20 @@ class Puppet::Transaction
   # up-front at failure time because the graph may be mutated as we
   # walk it.
   def propagate_failure(resource)
+
+    provider_class = resource.provider.class
+    s = resource_status(resource)
+    if prefetch_failed_providers[resource.type][provider_class.name] && !s.nil?
+      message = _("Prefetch failed for %{type_name} provider '%{name}'") % { type_name: resource.type, name: provider_class.name }
+      s.fail_with_event(message)
+    end
+
     failed = Set.new
     relationship_graph.direct_dependencies_of(resource).each do |dep|
-      if (s = resource_status(dep))
-        failed.merge(s.failed_dependencies) if s.dependency_failed?
-        if s.failed? || s.failed_to_restart?
-          failed.add(dep)
-        end
-      end
+      s = resource_status(dep)
+      next if s.nil?
+      failed.merge(s.failed_dependencies) if s.dependency_failed?
+      failed.add(dep) if s.failed? || s.failed_to_restart?
     end
     resource_status(resource).failed_dependencies = failed.to_a
   end
@@ -338,13 +350,20 @@ class Puppet::Transaction
   # types, just providers.
   def prefetch(provider_class, resources)
     type_name = provider_class.resource_type.name
-    return if @prefetched_providers[type_name][provider_class.name]
+    return if @prefetched_providers[type_name][provider_class.name] ||
+      @prefetch_failed_providers[type_name][provider_class.name]
     Puppet.debug "Prefetching #{provider_class.name} resources for #{type_name}"
     begin
       provider_class.prefetch(resources)
-    rescue LoadError, Puppet::MissingCommand => detail
+    rescue Exception => detail
+      if !detail.is_a?(LoadError) && !detail.is_a?(Puppet::MissingCommand)
+        raise unless Puppet.settings[:future_features]
+        
+        @prefetch_failed_providers[type_name][provider_class.name] = true
+      end
       #TRANSLATORS `prefetch` is a function name and should not be translated
-      Puppet.log_exception(detail, _("Could not prefetch %{type_name} provider '%{name}': %{detail}") % { type_name: type_name, name: provider_class.name, detail: detail })
+      message = _("Could not prefetch %{type_name} provider '%{name}': %{detail}") % { type_name: type_name, name: provider_class.name, detail: detail }
+      Puppet.log_exception(detail, message)
     end
     @prefetched_providers[type_name][provider_class.name] = true
   end
@@ -355,7 +374,7 @@ class Puppet::Transaction
 
   # Is the resource currently scheduled?
   def scheduled?(resource)
-    self.ignoreschedules or resource_harness.scheduled?(resource)
+    self.ignoreschedules || resource_harness.scheduled?(resource)
   end
 
   # Should this resource be skipped?
@@ -374,6 +393,10 @@ class Puppet::Transaction
       unless resource.class == Puppet::Type.type(:whit) then
         resource.warning _("Skipping because of failed dependencies")
       end
+    elsif resource_status(resource).failed? &&
+        @prefetch_failed_providers[resource.type][resource.provider.class.name]
+      #Do not try to evaluate a resource with a known failed provider
+      resource.warning _("Skipping because provider prefetch failed")
     elsif resource.virtual?
       resource.debug "Skipping because virtual"
     elsif !host_and_device_resource?(resource) && resource.appliable_to_host? && for_network_device

data/vendored/puppet/lib/puppet/type/cron.rb

@@ -12,7 +12,7 @@ Puppet::Type.newtype(:cron) do
     by Puppet with cron resources.
 
     If an existing crontab entry happens to match the scheduling and command of a
-    cron resource that has never been synched, Puppet will defer to the existing
+    cron resource that has never been synced, Puppet will defer to the existing
     crontab entry and will not create a new entry tagged with the `# Puppet Name: `
     comment.
 

data/vendored/puppet/lib/puppet/type/file/checksum.rb

@@ -15,6 +15,12 @@ Puppet::Type.type(:file).newparam(:checksum) do
     Puppet[:digest_algorithm].to_sym
   end
 
+  validate do |value|
+    if Puppet::Util::Platform.fips_enabled? && (value == :md5 || value == :md5lite)
+      raise ArgumentError, _("MD5 is not supported in FIPS mode")
+    end
+  end
+
   def sum(content)
     content = content.is_a?(Puppet::Pops::Types::PBinaryType::Binary) ? content.binary_buffer : content
     type = digest_algorithm()

data/vendored/puppet/lib/puppet/type/mount.rb

@@ -16,9 +16,6 @@ module Puppet
       that is, other mount points higher up in the filesystem --- the child
       mount will autorequire them.
 
-      **Autorequires:** If Puppet is managing a `File` resource for the mount
-      point of a mount resource, the mount will autorequire it.
-
       **Autobefores:**  If Puppet is managing any child file paths of a mount
       point, the mount resource will autobefore them."
 
@@ -303,12 +300,6 @@ module Puppet
       dependencies[0..-2]
     end
 
-    # Ensure that the mountpoint is created first
-    autorequire(:file) do
-      dependencies = []
-      dependencies.unshift @parameters[:name].value
-    end
-
     # Autobefore the mount point's child file paths
     autobefore(:file) do
       dependencies = []

data/vendored/puppet/lib/puppet/util/character_encoding.rb

@@ -22,7 +22,7 @@ module Puppet::Util::CharacterEncoding
             Puppet.debug(_("%{value} is already labeled as UTF-8 but this encoding is invalid. It cannot be transcoded by Puppet.") %
               { value: string.dump })
           end
-          # String is aleady valid UTF-8 - noop
+          # String is already valid UTF-8 - noop
           return string_copy
         else
           # If the string comes to us as BINARY encoded, we don't know what it
@@ -47,7 +47,7 @@ module Puppet::Util::CharacterEncoding
     end
 
     # Given a string, tests if that string's bytes represent valid UTF-8, and if
-    # so return a copy of the string with external enocding set to UTF-8. Does
+    # so return a copy of the string with external encoding set to UTF-8. Does
     # not modify the byte representation of the string. If the string does not
     # represent valid UTF-8, does not set the external encoding.
     #