bolt 0.16.0 → 0.16.1

data/vendored/puppet/lib/puppet/face/module/generate.rb

@@ -129,6 +129,8 @@ Puppet::Face.define(:module, '1.0.0') do
       puts _("Finished; module generated in %{path}.") % { path: path }
       result.join("\n")
     end
+
+    deprecate
   end
 end
 
@@ -136,6 +138,9 @@ module Puppet::ModuleTool::Generate
   module_function
 
   def generate(metadata, skip_interview = false)
+    #TRANSLATORS 'puppet module generate' is the name of the puppet command and 'Puppet Development Kit' is the name of the software package replacing this action and should not be translated. 
+    Puppet.deprecation_warning _("`puppet module generate` is deprecated and will be removed in a future release. This action has been replaced by Puppet Development Kit. For more information visit https://puppet.com/docs/pdk/latest/pdk.html.")
+
     interview(metadata) unless skip_interview
     destination = duplicate_skeleton(metadata)
     all_files = destination.basename + '**/*'

data/vendored/puppet/lib/puppet/functions/annotate.rb

@@ -37,7 +37,7 @@
 # ~~~
 #
 # With three arguments, an `Annotation` type, an object, and an the string `clear`, the function will
-# clear the annotatation of the given type in the given object. The old annotation is returned if
+# clear the annotation of the given type in the given object. The old annotation is returned if
 # it existed.
 #
 # @example Using `annotate` with three arguments where third argument is the string 'clear'

data/vendored/puppet/lib/puppet/functions/any.rb

@@ -27,7 +27,7 @@
 #
 # Would notice `true` if the looked up hash had a value that is neither `false` nor `undef` for at least
 # one of the keys. That is, it is equivalent to the expression
-# `$lookued_up[routers] || $looked_up[servers] || $looked_up[workstations]`.
+# `$looked_up[routers] || $looked_up[servers] || $looked_up[workstations]`.
 #
 # When the first argument is a `Hash`, Puppet passes each key and value pair to the lambda
 # as an array in the form `[key, value]`.

data/vendored/puppet/lib/puppet/generate/type.rb

@@ -5,7 +5,7 @@ require 'puppet/generate/models/type/type'
 
 module Puppet
   module Generate
-    # Reponsible for generating type definitions in Puppet
+    # Responsible for generating type definitions in Puppet
     class Type
       # Represents an input to the type generator
       class Input

data/vendored/puppet/lib/puppet/gettext/config.rb

@@ -191,7 +191,7 @@ module Puppet::GettextConfig
   end
 
   # @api private
-  # Attempt to load tranlstions for the given project.
+  # Attempt to load translations for the given project.
   # @param [String] project_name the project whose translations we want to load
   # @param [String] locale_dir the path to the directory containing translations
   # @param [Symbol] file_format translation file format to use, either :po or :mo
@@ -218,7 +218,7 @@ module Puppet::GettextConfig
   # chain for the currently selected text domain, if needed.
   # @param [String] project_name the name of the project for which to load translations
   # @param [String] locale_dir the path to the directory containing translations
-  # @param [Symbol] file_format the fomat of the translations files, :po or :mo
+  # @param [Symbol] file_format the format of the translations files, :po or :mo
   def self.add_repository_to_domain(project_name, locale_dir, file_format, text_domain = FastGettext.text_domain)
     return if @gettext_disabled || !gettext_loaded?
 

data/vendored/puppet/lib/puppet/gettext/stubs.rb

@@ -1,4 +1,4 @@
-# These stub the translation methods noramlly brought in
+# These stub the translation methods normally brought in
 # by FastGettext. Used when Gettext could not be properly
 # initialized.
 def _(msg)

data/vendored/puppet/lib/puppet/interface/action.rb

@@ -149,6 +149,17 @@ class Puppet::Interface::Action
     @render_as = value.to_sym
   end
 
+  # @api private
+  # @return [void]
+  def deprecate
+    @deprecated = true
+  end
+
+  # @api private
+  # @return [Boolean]
+  def deprecated?
+    @deprecated
+  end
 
   ########################################################################
   # Initially, this was defined to allow the @action.invoke pattern, which is

data/vendored/puppet/lib/puppet/interface/action_builder.rb

@@ -17,6 +17,14 @@ class Puppet::Interface::ActionBuilder
     new(face, name, &block).action
   end
 
+  # Deprecates the action
+  # @return [void]
+  # @api private
+  # @dsl Faces
+  def deprecate
+    @action.deprecate
+  end
+
   # Ideally the method we're defining here would be added to the action, and a
   # method on the face would defer to it, but we can't get scope correct, so
   # we stick with this. --daniel 2011-03-24

data/vendored/puppet/lib/puppet/network/authstore.rb

@@ -16,7 +16,7 @@ module Puppet
     # is provided, then the authstore is considered local and defaults to "true".
     def allowed?(name, ip)
       if name or ip
-        # This is probably unnecessary, and can cause some weirdnesses in
+        # This is probably unnecessary, and can cause some weirdness in
         # cases where we're operating over localhost but don't have a real
         # IP defined.
         raise Puppet::DevError, _("Name and IP must be passed to 'allowed?'") unless name and ip

data/vendored/puppet/lib/puppet/network/http/connection.rb

@@ -209,7 +209,7 @@ module Puppet::Network::HTTP
     # it by sleeping for the indicated number of seconds. The response is
     # returned unmodified if no Retry-After header is present.
     #
-    # @param response [Net::HTTPResponse] A response recieved from the
+    # @param response [Net::HTTPResponse] A response received from the
     #   HTTP client.
     #
     # @return [nil] Sleeps and returns nil if the response contained a

data/vendored/puppet/lib/puppet/parameter/boolean.rb

@@ -1,7 +1,7 @@
 require 'puppet/coercion'
 
 # This specialized {Puppet::Parameter} handles Boolean options, accepting lots
-# of strings and symbols for both truthiness and falsehood.
+# of strings and symbols for both truth and falsehood.
 #
 class Puppet::Parameter::Boolean < Puppet::Parameter
   def unsafe_munge(value)

data/vendored/puppet/lib/puppet/parser/ast/branch.rb

@@ -1,7 +1,7 @@
 # The parent class of all AST objects that contain other AST objects.
 # Everything but the really simple objects descend from this.  It is
 # important to note that Branch objects contain other AST objects only --
-# if you want to contain values, use a descendent of the AST::Leaf class.
+# if you want to contain values, use a descendant of the AST::Leaf class.
 #
 # @api private
 class Puppet::Parser::AST::Branch < Puppet::Parser::AST

data/vendored/puppet/lib/puppet/parser/functions/new.rb

@@ -178,7 +178,7 @@ function Timespan.new(
 )
 ```
 
-#### Timespan from days, hours, mintues, seconds, and fractions of a second
+#### Timespan from days, hours, minutes, seconds, and fractions of a second
 
 The arguments can be passed separately in which case the first four, days, hours, minutes, and seconds are mandatory and the rest are optional.
 All values may overflow and/or be negative. The internal 128-bit nano-second integer is calculated as:

data/vendored/puppet/lib/puppet/parser/functions/reverse_each.rb

@@ -40,7 +40,7 @@ $reverse_data = reverse_each($data)
 When no second argument is present, Puppet returns an `Iterable` that represents the reverse
 order of its first argument. This allows methods on `Iterable` to be chained.
 
-When a lamdba is given as the second argument, Puppet iterates the first argument in reverse
+When a lambda is given as the second argument, Puppet iterates the first argument in reverse
 order and passes each value in turn to the lambda, then returns `undef`.
 
 **Example:** Using the `reverse_each` function with an array and a one-parameter lambda

data/vendored/puppet/lib/puppet/pops/evaluator/compare_operator.rb

@@ -133,7 +133,7 @@ class CompareOperator
   def include_String(a, b, scope)
     case b
     when String
-      # subsstring search downcased
+      # substring search downcased
       a.downcase.include?(b.downcase)
     when Regexp
       matched = a.match(b)           # nil, or MatchData

data/vendored/puppet/lib/puppet/pops/evaluator/evaluator_impl.rb

@@ -342,7 +342,7 @@ class EvaluatorImpl
       candidate
     when Hash
       candidate.to_a
-    when Puppet::Pops::Types::Iterator
+    when Puppet::Pops::Types::Iterable
       candidate.to_a
     else
       # turns anything else into an array (so result can be unfolded)
@@ -703,7 +703,7 @@ class EvaluatorImpl
   end
 
   # Evaluates a CollectExpression by creating a collector transformer. The transformer
-  # will evaulate the collection, create the appropriate collector, and hand it off
+  # will evaluate the collection, create the appropriate collector, and hand it off
   # to the compiler to collect the resources specified by the query.
   #
   def eval_CollectExpression o, scope
@@ -1194,7 +1194,7 @@ class EvaluatorImpl
         # Hash[a,1,b,2] => {a => 1, b => 2}
         # Hash[[a,1], [b,2]] => {[a,1] => [b,2]}
         # Hash[[[a,1], [b,2]]] => {a => 1, b => 2}
-        # Use type calcultor to determine if array is Array[Array[?]], and if so use second form
+        # Use type calculator to determine if array is Array[Array[?]], and if so use second form
         # of call
         t = @@type_calculator.infer(y)
         if t.element_type.is_a? Types::PArrayType

data/vendored/puppet/lib/puppet/pops/evaluator/literal_evaluator.rb

@@ -9,7 +9,7 @@ module Evaluator
 # Hash
 # QualifiedName
 # Default (produced :default)
-# Regular Expression (produces ruby reqular expression)
+# Regular Expression (produces ruby regular expression)
 #
 # Not considered literal
 # QualifiedReference  # i.e. File, FooBar

data/vendored/puppet/lib/puppet/pops/evaluator/runtime3_converter.rb

@@ -166,7 +166,7 @@ end
 class Runtime3FunctionArgumentConverter < Runtime3Converter
 
   def convert_Regexp(o, scope, undef_value)
-    # Puppet 3x cannot handle parameter values that are reqular expressions. Turn into regexp string in
+    # Puppet 3x cannot handle parameter values that are regular expressions. Turn into regexp string in
     # source form
     o.inspect
   end

data/vendored/puppet/lib/puppet/pops/evaluator/runtime3_support.rb

@@ -374,7 +374,7 @@ module Runtime3Support
     evaluated_parameters = evaluated_parameters.flatten
     evaluated_resources.each do |r|
       unless r.is_a?(Types::PResourceType) && r.type_name != 'class'
-        fail(Issues::ILLEGAL_OVERRIDEN_TYPE, o, {:actual => r} )
+        fail(Issues::ILLEGAL_OVERRIDDEN_TYPE, o, {:actual => r} )
       end
       t = Runtime3ResourceSupport.find_resource_type(scope, r.type_name)
       resource = Puppet::Parser::Resource.new(

data/vendored/puppet/lib/puppet/pops/issues.rb

@@ -617,7 +617,7 @@ module Issues
     _("Node inheritance is not supported in Puppet >= 4.0.0. See http://links.puppet.com/puppet-node-inheritance-deprecation")
   end
 
-  ILLEGAL_OVERRIDEN_TYPE = issue :ILLEGAL_OVERRIDEN_TYPE, :actual do
+  ILLEGAL_OVERRIDDEN_TYPE = issue :ILLEGAL_OVERRIDDEN_TYPE, :actual do
     _("Resource Override can only operate on resources, got: %{actual}") % { actual: label.label(actual) }
   end
 

data/vendored/puppet/lib/puppet/pops/loader/loader.rb

@@ -90,7 +90,7 @@ class Loader
   # of the given type/name.
   #
   # @param typed_name [TypedName] - the type, name combination to lookup
-  # @param check_dependencies [Boolean] - if dependencies should be checked in additiona to here and parent
+  # @param check_dependencies [Boolean] - if dependencies should be checked in addition to here and parent
   # @return [NamedEntry, nil] the entry containing the loaded value, or nil if not found
   # @api public
   #

data/vendored/puppet/lib/puppet/pops/loader/loader_paths.rb

@@ -305,7 +305,7 @@ module LoaderPaths
     #
     def effective_path(typed_name, start_index_in_name)
       # Resource type to name does not skip the name-space
-      # i.e. <module>/mymodule/resource_types/foo.pp is the reource type foo
+      # i.e. <module>/mymodule/resource_types/foo.pp is the resource type foo
       "#{File.join(generic_path, typed_name.name_parts)}.pp"
     end
   end

data/vendored/puppet/lib/puppet/pops/loader/module_loaders.rb

@@ -14,9 +14,7 @@ module Loader
 # modules" to determine which module loader to use for each individual module. (There could be differences in
 # internal layout etc.)
 #
-# A module loader is also not aware of the mapping of name to relative paths - this is performed by the
-# included module PathBasedInstantatorConfig which knows about the map from type/name to
-# relative path, and the logic that can instantiate what is expected to be found in the content of that path.
+# A module loader is also not aware of the mapping of name to relative paths.
 #
 # @api private
 #
@@ -144,8 +142,8 @@ module ModuleLoaders
                 err = Puppet::DataTypes::Error.new(
                   Issues::LOADER_FAILURE.format(:type => type),
                   'PUPPET_LOADER_FAILURE',
-                  Issues::LOADER_FAILURE.issue_code, nil,
-                  { 'original_error' => e.message })
+                  { 'original_error' => e.message },
+                  Issues::LOADER_FAILURE.issue_code)
                 error_collector << err unless error_collector.include?(err)
               end
             end

data/vendored/puppet/lib/puppet/pops/loader/puppet_resource_type_impl_instantiator.rb

@@ -8,7 +8,7 @@ class PuppetResourceTypeImplInstantiator
   # given puppet source does not produce such an instance when evaluated.
   #
   # @param loader [Loader] The loader the function is associated with
-  # @param typed_name [TypedName] the type / name of the resoure type impl to load
+  # @param typed_name [TypedName] the type / name of the resource type impl to load
   # @param source_ref [URI, String] a reference to the source / origin of the puppet code to evaluate
   # @param pp_code_string [String] puppet code in a string
   #

data/vendored/puppet/lib/puppet/pops/loader/runtime3_type_loader.rb

@@ -88,7 +88,7 @@ class Runtime3TypeLoader < BaseLoader
   end
   private :find_impl
 
-  # Allows shadowing since this loader is populalted with all loaded resource types at time
+  # Allows shadowing since this loader is populated with all loaded resource types at time
   # of loading. This loading will, for built in types override the aliases configured in the static
   # loader.
   #

data/vendored/puppet/lib/puppet/pops/loaders.rb

@@ -453,6 +453,18 @@ class Loaders
     def resolved?
       !@private_loader.nil?
     end
+
+    def restrict_to_dependencies?
+      @puppet_module.has_metadata?
+    end
+
+    def unmet_dependencies?
+      @puppet_module.unmet_dependencies.any?
+    end
+
+    def dependency_names
+      @puppet_module.dependencies_as_modules.collect(&:name)
+    end
   end
 
   # Resolves module loaders - resolution of model dependencies is done by Puppet::Module
@@ -481,15 +493,42 @@ class Loaders
       if module_data.resolved?
         nil
       else
-        module_data.private_loader = create_loader_with_all_modules_visible(module_data)
+        module_data.private_loader =
+          if module_data.restrict_to_dependencies? && !Puppet[:tasks]
+            create_loader_with_only_dependencies_visible(module_data)
+          else
+            create_loader_with_all_modules_visible(module_data)
+          end
       end
     end
 
     private
 
     def create_loader_with_all_modules_visible(from_module_data)
+      Puppet.debug{"ModuleLoader: module '#{from_module_data.name}' has unknown dependencies - it will have all other modules visible"}
+
       @loaders.add_loader_by_name(Loader::DependencyLoader.new(from_module_data.public_loader, "#{from_module_data.name} private", all_module_loaders()))
     end
+
+    def create_loader_with_only_dependencies_visible(from_module_data)
+      if from_module_data.unmet_dependencies?
+        if Puppet[:strict] != :off
+          msg = "ModuleLoader: module '#{from_module_data.name}' has unresolved dependencies" \
+              " - it will only see those that are resolved." \
+              " Use 'puppet module list --tree' to see information about modules"
+          case Puppet[:strict]
+          when :error
+              raise LoaderError.new(msg)
+          when :warning
+            Puppet.warn_once(:unresolved_module_dependencies,
+                             "unresolved_dependencies_for_module_#{from_module_data.name}",
+                             msg)
+          end
+        end
+      end
+      dependency_loaders = from_module_data.dependency_names.collect { |name| @index[name].public_loader }
+      @loaders.add_loader_by_name(Loader::DependencyLoader.new(from_module_data.public_loader, "#{from_module_data.name} private", dependency_loaders))
+    end
   end
 end
 end

data/vendored/puppet/lib/puppet/pops/lookup/interpolation.rb

@@ -125,7 +125,7 @@ module Interpolation
     interpolate_method
   end
 
-  # Because the semanitcs of Puppet::Parser::Scope#include? differs from Hash#include?
+  # Because the semantics of Puppet::Parser::Scope#include? differs from Hash#include?
   def nil_in_scope?(scope, key)
     if scope.is_a?(Hash)
       scope.include?(key)

data/vendored/puppet/lib/puppet/pops/model/tree_dumper.rb

@@ -24,7 +24,7 @@ class Puppet::Pops::Model::TreeDumper
     parts = format_r(x)
     parts.each_index do |i|
       if i > 0
-        # separate with space unless previous ends with whitepsace or (
+        # separate with space unless previous ends with whitespace or (
         result << ' ' if parts[i] != ")" && parts[i-1] !~ /.*(?:\s+|\()$/ && parts[i] !~ /^\s+/
       end
       result << parts[i].to_s

data/vendored/puppet/lib/puppet/pops/parser/epp_support.rb

@@ -123,7 +123,7 @@ module EppSupport
   # The scanner supports
   # * scanning text until <%, <%-, <%=
   # * while scanning text:
-  #   * tokens <%% and %%> are translated to <% and %> respetively and is returned as text.
+  #   * tokens <%% and %%> are translated to <% and %>, respectively, and is returned as text.
   #   * tokens <%# and %> (or ending with -%>) and the enclosed text is a comment and is not included in the returned text
   #   * text following a comment that ends with -%> gets trailing whitespace (up to and including a line break) trimmed
   #     and this whitespace is not included in the returned text.

data/vendored/puppet/lib/puppet/pops/parser/interpolation_support.rb

@@ -10,7 +10,7 @@ module Puppet::Pops::Parser::InterpolationSupport
 
   # This is the starting point for a double quoted string with possible interpolation
   # The structure mimics that of the grammar.
-  # The logic is explicit (where the former implementation used parameters/strucures) given to a
+  # The logic is explicit (where the former implementation used parameters/structures) given to a
   # generic handler.
   # (This is both easier to understand and faster).
   #

data/vendored/puppet/lib/puppet/pops/parser/lexer2.rb

@@ -1,4 +1,4 @@
-# The Lexer is responsbile for turning source text into tokens.
+# The Lexer is responsible for turning source text into tokens.
 # This version is a performance enhanced lexer (in comparison to the 3.x and earlier "future parser" lexer.
 #
 # Old returns tokens [:KEY, value, { locator = }

data/vendored/puppet/lib/puppet/pops/parser/lexer_support.rb

@@ -135,7 +135,7 @@ module LexerSupport
     end
 
     def to_s
-      # This format is very compact and is intended for debugging output from racc parsser in
+      # This format is very compact and is intended for debugging output from racc parser in
       # debug mode. If this is made more elaborate the output from a debug run becomes very hard to read.
       #
       "'#{self[:value]} #{@token_array[0]}'"
@@ -204,7 +204,7 @@ module LexerSupport
 
   def get_bom(content)
     # get 5 bytes as efficiently as possible (none of the string methods works since a bom consists of
-    # illegal characters on most platforms, and there is no get_bytes(n). xplicit calls are faster than
+    # illegal characters on most platforms, and there is no get_bytes(n). Explicit calls are faster than
     # looping with a lambda. The get_byte returns nil if there are too few characters, and they
     # are changed to spaces
     MM.new(

data/vendored/puppet/lib/puppet/pops/parser/locatable.rb

@@ -1,4 +1,4 @@
-# Interface for something that is "locateable" (holds offset and length).
+# Interface for something that is "locatable" (holds offset and length).
 class Puppet::Pops::Parser::Locatable
 
   # The offset in the locator's content