blacklight 7.41.0 → 8.0.0.beta1

data/app/helpers/blacklight/render_constraints_helper_behavior.rb

@@ -1,188 +0,0 @@
-# frozen_string_literal: true
-# All methods in here are 'api' that may be over-ridden by plugins and local
-# code, so method signatures and semantics should not be changed casually.
-# implementations can be of course.
-#
-# Includes methods for rendering contraints graphically on the
-# search results page (render_constraints(_*))
-module Blacklight::RenderConstraintsHelperBehavior
-  extend Deprecation
-  self.deprecation_horizon = 'blacklight 8.0'
-
-  ##
-  # Check if the query has any constraints defined (a query, facet, etc)
-  #
-  # @deprecated
-  # @param [Blacklight::SearchState,Hash] params_or_search_state query parameters
-  # @return [Boolean]
-  def query_has_constraints?(params_or_search_state = search_state)
-    search_state = convert_to_search_state(params_or_search_state)
-    search_state.has_constraints?
-  end
-  deprecation_deprecate query_has_constraints?: 'use search_state#has_constraints?'
-
-  ##
-  # Render the actual constraints, not including header or footer
-  # info.
-  #
-  # @param [Hash] localized_params query parameters
-  # @return [String]
-  def render_constraints(localized_params = params, local_search_state = search_state)
-    params_or_search_state = if localized_params != params
-                               localized_params
-                             else
-                               local_search_state
-                             end
-
-    Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) do
-      render_constraints_query(params_or_search_state) + render_constraints_clauses(params_or_search_state) + render_constraints_filters(params_or_search_state)
-    end
-  end
-
-  ##
-  # Render the query constraints
-  #
-  # @deprecated
-  # @param [Blacklight::SearchState,ActionController::Parameters] params_or_search_state query parameters
-  # @return [String]
-  def render_constraints_query(params_or_search_state = search_state)
-    Deprecation.warn(Blacklight::RenderConstraintsHelperBehavior, 'render_constraints_query is deprecated')
-    search_state = convert_to_search_state(params_or_search_state)
-
-    # So simple don't need a view template, we can just do it here.
-    return "".html_safe if search_state.query_param.blank?
-
-    Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) do
-      render_constraint_element(constraint_query_label(search_state.params),
-                                search_state.query_param,
-                                classes: ["query"],
-                                remove: remove_constraint_url(search_state))
-    end
-  end
-
-  ##
-  # Render the query constraints
-  #
-  # @deprecated
-  # @param [Blacklight::SearchState,ActionController::Parameters] params_or_search_state query parameters
-  # @return [String]
-  def render_constraints_clauses(params_or_search_state = search_state)
-    search_state = convert_to_search_state(params_or_search_state)
-
-    clause_presenters = search_state.clause_params.map do |key, clause|
-      field_config = blacklight_config.search_fields[clause[:field]]
-      Blacklight::ClausePresenter.new(key, clause, field_config, self, search_state)
-    end
-
-    render(Blacklight::ConstraintComponent.with_collection(clause_presenters))
-  end
-  deprecation_deprecate :render_constraints_clauses
-
-  ##
-  # Provide a url for removing a particular constraint. This can be overriden
-  # in the case that you want parameters other than the defaults to be removed
-  # (e.g. :search_field)
-  #
-  # @deprecated
-  # @param [Blacklight::SearchState,ActionController::Parameters] params_or_search_state query parameters
-  # @return [String]
-  def remove_constraint_url(params_or_search_state = search_state)
-    Deprecation.warn(Blacklight::RenderConstraintsHelperBehavior, 'remove_constraint_url is deprecated')
-    search_state = convert_to_search_state(params_or_search_state)
-
-    search_action_path(search_state.remove_query_params)
-  end
-
-  ##
-  # Render the facet constraints
-  # @deprecated
-  # @param [Blacklight::SearchState,Hash] params_or_search_state query parameters
-  # @return [String]
-  def render_constraints_filters(params_or_search_state = search_state)
-    Deprecation.warn(Blacklight::RenderConstraintsHelperBehavior, 'render_constraints_filters is deprecated')
-    search_state = convert_to_search_state(params_or_search_state)
-
-    return "".html_safe unless search_state.filters.any?
-
-    Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) do
-      safe_join(search_state.filters.map do |field|
-        render_filter_element(field.key, field.values, search_state)
-      end, "\n")
-    end
-  end
-
-  ##
-  # Render a single facet's constraint
-  # @deprecated
-  # @param [String] facet field
-  # @param [Array<String>] values selected facet values
-  # @param [Blacklight::SearchState] search_state path query parameters
-  # @return [String]
-  def render_filter_element(facet, values, search_state)
-    Deprecation.warn(Blacklight::RenderConstraintsHelperBehavior, 'render_filter_element is deprecated')
-    facet_config = facet_configuration_for_field(facet)
-
-    safe_join(Array(values).map do |val|
-      next if val.blank? # skip empty string
-
-      Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) do
-        presenter = if val.is_a? Array
-                      inclusive_facet_item_presenter(facet_config, val, facet)
-                    else
-                      facet_item_presenter(facet_config, val, facet)
-                    end
-
-        render_constraint_element(presenter.field_label,
-                                  presenter.label,
-                                  remove: presenter.remove_href(search_state),
-                                  classes: ["filter", "filter-" + facet.parameterize])
-      end
-    end, "\n")
-  end
-
-  def inclusive_facet_item_presenter(facet_config, facet_item, facet_field)
-    Blacklight::InclusiveFacetItemPresenter.new(facet_item, facet_config, self, facet_field)
-  end
-
-  # Render a label/value constraint on the screen. Can be called
-  # by plugins and such to get application-defined rendering.
-  #
-  # Can be over-ridden locally to render differently if desired,
-  # although in most cases you can just change CSS instead.
-  #
-  # Can pass in nil label if desired.
-  #
-  # @deprecated
-  # @param [String] label to display
-  # @param [String] value to display
-  # @param [Hash] options
-  # @option options [String] :remove url to execute for a 'remove' action
-  # @option options [Array<String>] :classes an array of classes to add to container span for constraint.
-  # @return [String]
-  def render_constraint_element(label, value, options = {})
-    Deprecation.warn(Blacklight::RenderConstraintsHelperBehavior, 'render_constraints_element is deprecated')
-    render(partial: "catalog/constraints_element", locals: { label: label, value: value, options: options })
-  end
-
-  # @private
-  def constraints_helpers_and_partials_from_blacklight?
-    method(:render_constraints).owner == Blacklight::RenderConstraintsHelperBehavior &&
-      method(:render_constraints_query).owner == Blacklight::RenderConstraintsHelperBehavior &&
-      method(:remove_constraint_url).owner == Blacklight::RenderConstraintsHelperBehavior &&
-      method(:render_constraints_filters).owner == Blacklight::RenderConstraintsHelperBehavior &&
-      method(:render_filter_element).owner == Blacklight::RenderConstraintsHelperBehavior &&
-      method(:render_constraint_element).owner == Blacklight::RenderConstraintsHelperBehavior &&
-      partial_from_blacklight?('catalog/constraints_element')
-  end
-
-  private
-
-  def convert_to_search_state(params_or_search_state)
-    if params_or_search_state.is_a? Blacklight::SearchState
-      params_or_search_state
-    else
-      # deprecated
-      controller.search_state_class.new(params_or_search_state, blacklight_config, controller)
-    end
-  end
-end

data/app/helpers/blacklight/search_history_constraints_helper_behavior.rb

@@ -1,97 +0,0 @@
-# frozen_string_literal: true
-# All methods in here are 'api' that may be over-ridden by plugins and local
-# code, so method signatures and semantics should not be changed casually.
-# implementations can be of course.
-#
-# Includes methods for rendering more textually on Search History page
-# (render_search_to_s(_*))
-module Blacklight::SearchHistoryConstraintsHelperBehavior
-  extend Deprecation
-  self.deprecation_horizon = '8.0'
-
-  # Simpler textual version of constraints, used on Search History page.
-  # Theoretically can may be DRY'd up with results page render_constraints,
-  # maybe even using the very same HTML with different CSS?
-  # But too tricky for now, too many changes to existing CSS. TODO.
-  def render_search_to_s(params)
-    return render(Blacklight::ConstraintsComponent.for_search_history(search_state: convert_to_search_state(params))) unless overridden_search_history_constraints_helper_methods?
-
-    Deprecation.warn(Blacklight::SearchHistoryConstraintsHelperBehavior, 'Calling out to potentially overridden helpers for backwards compatibility.')
-
-    Deprecation.silence(Blacklight::SearchHistoryConstraintsHelperBehavior) do
-      render_search_to_s_q(params) +
-      render_search_to_s_filters(params)
-    end
-  end
-  deprecation_deprecate render_search_to_s: 'Use Blacklight::ConstraintsComponent.for_search_history instead'
-
-  ##
-  # Render the search query constraint
-  def render_search_to_s_q(params)
-    Deprecation.warn(Blacklight::SearchHistoryConstraintsHelperBehavior, '#render_search_to_s_q is deprecated without replacement')
-    return "".html_safe if params['q'].blank?
-
-    label = label_for_search_field(params[:search_field]) unless default_search_field?(params[:search_field])
-
-    render_search_to_s_element(label, render_filter_value(params['q']))
-  end
-
-  ##
-  # Render the search facet constraints
-  def render_search_to_s_filters(params)
-    Deprecation.warn(Blacklight::SearchHistoryConstraintsHelperBehavior, '#render_search_to_s_filters is deprecated without replacement')
-    return "".html_safe unless params[:f]
-
-    safe_join(params[:f].collect do |facet_field, value_list|
-      render_search_to_s_element(facet_field_label(facet_field),
-                                 safe_join(value_list.collect do |value|
-                                   render_filter_value(value, facet_field)
-                                 end,
-                                           tag.span(" #{t('blacklight.and')} ", class: 'filter-separator')))
-    end, " \n ")
-  end
-
-  # value can be Array, in which case elements are joined with
-  # 'and'.   Pass in option :escape_value => false to pass in pre-rendered
-  # html for value. key with escape_key if needed.
-  def render_search_to_s_element(key, value, _options = {})
-    Deprecation.warn(Blacklight::SearchHistoryConstraintsHelperBehavior, '#render_search_to_s_element is deprecated without replacement')
-    tag.span(render_filter_name(key) + tag.span(value, class: 'filter-values'),
-             class: 'constraint')
-  end
-
-  ##
-  # Render the name of the facet
-  def render_filter_name name
-    Deprecation.warn(Blacklight::SearchHistoryConstraintsHelperBehavior, '#render_filter_name is deprecated without replacement')
-    return "".html_safe if name.blank?
-
-    tag.span(t('blacklight.search.filters.label', label: name),
-             class: 'filter-name')
-  end
-
-  ##
-  # Render the value of the facet
-  def render_filter_value value, key = nil
-    Deprecation.warn(Blacklight::SearchHistoryConstraintsHelperBehavior, '#render_filter_value is deprecated without replacement')
-    display_value = value
-    Deprecation.silence(Blacklight::FacetsHelperBehavior) do
-      display_value = facet_display_value(key, value) if key
-    end
-    tag.span(h(display_value),
-             class: 'filter-value')
-  end
-
-  private
-
-  # Check if the downstream application has overridden these methods
-  # @deprecated
-  # @private
-  def overridden_search_history_constraints_helper_methods?
-    method(:render_search_to_s_q).owner != Blacklight::FacetsHelperBehavior ||
-      method(:render_search_to_s_filters).owner != Blacklight::FacetsHelperBehavior ||
-      method(:render_search_to_s_element).owner != Blacklight::FacetsHelperBehavior ||
-      method(:render_filter_name).owner != Blacklight::FacetsHelperBehavior ||
-      method(:render_filter_value).owner != Blacklight::FacetsHelperBehavior
-  end
-end

data/app/helpers/blacklight/suggest_helper_behavior.rb

@@ -1,13 +0,0 @@
-# frozen_string_literal: true
-module Blacklight
-  module SuggestHelperBehavior
-    ##
-    # @deprecated
-    # @return [Boolean] should autocomplete be enabled in the UI
-    def autocomplete_enabled?
-      blacklight_config.autocomplete_enabled.present? &&
-        blacklight_config.autocomplete_path.present?
-    end
-    deprecation_deprecate autocomplete_enabled?: "use SearchBarPresenter#autocomplete_enabled?"
-  end
-end

data/app/javascript/blacklight/autocomplete.js

@@ -1,36 +0,0 @@
-/*global Bloodhound */
-import Bloodhound from 'typeahead.js/dist/bloodhound.js'
-
-Blacklight.onLoad(function() {
-  'use strict';
-
-  $('[data-autocomplete-enabled="true"]').each(function() {
-    var $el = $(this);
-    if($el.hasClass('tt-hint')) {
-      return;
-    }
-    var suggestUrl = $el.data().autocompletePath;
-
-    var terms = new Bloodhound({
-      datumTokenizer: Bloodhound.tokenizers.obj.whitespace('value'),
-      queryTokenizer: Bloodhound.tokenizers.whitespace,
-      remote: {
-        url: suggestUrl + '?q=%QUERY',
-        wildcard: '%QUERY'
-      }
-    });
-
-    terms.initialize();
-
-    $el.typeahead({
-      hint: true,
-      highlight: true,
-      minLength: 2
-    },
-    {
-      name: 'terms',
-      displayKey: 'term',
-      source: terms.ttAdapter()
-    });
-  });
-});

data/app/javascript/blacklight/facet_load.js

@@ -1,22 +0,0 @@
-/*global Blacklight */
-
-'use strict';
-
-Blacklight.doResizeFacetLabelsAndCounts = function() {
-  // adjust width of facet columns to fit their contents
-  function longer (a,b) { return b.textContent.length - a.textContent.length }
-
-  document.querySelectorAll('.facet-values, .pivot-facet').forEach(function(elem){
-    const nodes = elem.querySelectorAll('.facet-count')
-    // TODO: when we drop ie11 support, this can become the spread operator:
-    const longest = Array.from(nodes).sort(longer)[0]
-    if (longest && longest.textContent) {
-      const width = longest.textContent.length + 1 + 'ch'
-      elem.querySelector('.facet-count').style.width = width
-    }
-  })
-}
-
-Blacklight.onLoad(function() {
-  Blacklight.doResizeFacetLabelsAndCounts()
-})

data/app/presenters/blacklight/search_bar_presenter.rb

@@ -1,47 +0,0 @@
-# frozen_string_literal: true
-
-module Blacklight
-  class SearchBarPresenter
-    extend Deprecation
-    attr_reader :configuration, :view_context, :controller
-
-    # Set the partial this presenter draws
-    class_attribute :partial
-    self.partial = 'catalog/search_form'
-
-    def initialize(controller, configuration = view_context.blacklight_config)
-      @controller = controller
-      @view_context = controller.view_context
-      @configuration = configuration
-    end
-
-    def render
-      view_context.render partial, presenter: self
-    end
-    deprecation_deprecate render: "The SearchBarPresenter has been deprecated. Call `render Blacklight::SearchBarComponent.new' instead"
-
-    ##
-    # @return [Boolean] should autocomplete be enabled in the UI
-    def autocomplete_enabled?
-      configuration.autocomplete_enabled.present? &&
-        configuration.autocomplete_path.present?
-    end
-
-    ##
-    # If no search parameters have been given, we should
-    # auto-focus the user's cursor into the searchbox
-    #
-    # @return [Boolean]
-    def autofocus?
-      configuration.enable_search_bar_autofocus.present? &&
-        configuration.enable_search_bar_autofocus &&
-        controller.is_a?(Blacklight::Catalog) &&
-        controller.action_name == "index" &&
-        !controller.has_search_parameters?
-    end
-
-    def advanced_search_enabled?
-      configuration.advanced_search.enabled
-    end
-  end
-end

data/app/views/catalog/_constraints_element.html.erb

@@ -1,14 +0,0 @@
-<%  # local params:
-    # label
-    # value
-    # options =>
-    #   :remove => url for a remove constraint link
-    #   :classes => array of classes to add to container span
-    options ||= {}
-%>
-
-<%= render(Blacklight::ConstraintLayoutComponent.new(
-      classes: options[:classes],
-      label: label,
-      value: value,
-      remove_path: options[:remove])) %>

data/app/views/catalog/_document_action.html.erb

@@ -1,5 +0,0 @@
-<%= link_to document_action_label(document_action_config.key, document_action_config),
-            document_action_path(document_action_config, (local_assigns.has_key?(:url_opts) ? url_opts : {}).merge(({id: document} if document) || {})),
-            id: document_action_config.fetch(:id, "#{document_action_config.key}Link"),
-            class: 'nav-link',
-            data: {}.merge(({ blacklight_modal: "trigger" } if document_action_config.modal != false) || {}) %>

data/app/views/catalog/_facet_group.html.erb

@@ -1,5 +0,0 @@
-<%= render (blacklight_config&.view_config(document_index_view_type)&.facet_group_component || Blacklight::Response::FacetGroupComponent).new(
-  response: @response,
-  id: groupname,
-  fields: facet_field_names(groupname),
-  title: groupname.present? ? t("blacklight.search.facets-#{groupname}.title") : t('blacklight.search.facets.title')) %>

data/app/views/catalog/_facet_limit.html.erb

@@ -1,3 +0,0 @@
-<%= render(Blacklight::FacetFieldListComponent.new(
-      facet_field: facet_field_presenter(facet_field, display_facet),
-      layout: false)) %>

data/app/views/catalog/_index.html.erb

@@ -1 +0,0 @@
-<%= render(Blacklight::DocumentMetadataComponent.new(fields: document_presenter(document).field_presenters)) %>

data/app/views/catalog/_index_header.html.erb

@@ -1,22 +0,0 @@
-<%# header bar for doc items in index view -%>
-<header class="documentHeader row">
-  <%# main title container for doc partial view
-      How many bootstrap columns need to be reserved
-      for bookmarks control depends on size.
-  -%>
-  <% document_actions = capture do %>
-    <% # bookmark functions for items/docs -%>
-    <%= render_index_doc_actions document, wrapping_class: "index-document-functions col-sm-3 col-lg-2" %>
-  <% end %>
-
-  <h3 class="index_title document-title-heading <%= document_actions.present? ? "col-sm-9 col-lg-10" : "col-md-12" %>">
-    <% if counter = document_counter_with_offset(document_counter) %>
-      <span class="document-counter">
-        <%= t('blacklight.search.documents.counter', counter: counter) %>
-      </span>
-    <% end %>
-    <%= link_to_document document, counter: counter %>
-  </h3>
-
-  <%= document_actions %>
-</header>

data/app/views/catalog/_previous_next_doc.html.erb

@@ -1,2 +0,0 @@
-<% Deprecation.warn(self, 'The partial _previous_next_doc.html.erb will be removed in 8.0. Render Blacklight::SearchContext::ServerItemPaginationComponent instead.') %>
-<%= render(Blacklight::SearchContextComponent.new(search_context: @search_context, search_session: search_session)) %>

data/app/views/catalog/_show.html.erb

@@ -1,6 +0,0 @@
-<%= render(
-  Blacklight::DocumentMetadataComponent.new(
-    fields: document_presenter(document).field_presenters,
-    show: true
-  )
-) %>

data/app/views/catalog/_show_header.html.erb

@@ -1,2 +0,0 @@
-<% # bookmark/folder functions -%>
-<%= Deprecation.silence(Blacklight::BlacklightHelperBehavior) { render_document_heading(document, :tag => :h1) } %>

data/app/views/catalog/_thumbnail.html.erb

@@ -1 +0,0 @@
-<%= render Blacklight::Document::ThumbnailComponent.new(presenter: document_presenter(document), counter: document_counter_with_offset(document_counter)) -%>

data/lib/blacklight/deprecations/engine_configuration.rb

@@ -1,66 +0,0 @@
-# frozen_string_literal: true
-
-module Blacklight
-  module Deprecations
-    module EngineConfiguration
-      # rubocop:disable Style/RedundantSelf, Style/HashSyntax
-      # @deprecated
-      def bookmarks_http_method
-        self.blacklight.bookmarks_http_method
-      end
-      deprecation_deprecate bookmarks_http_method: 'Moved to `blacklight.bookmarks_http_method`'
-
-      # @deprecated
-      def bookmarks_http_method=(val)
-        self.blacklight.bookmarks_http_method = val
-      end
-      deprecation_deprecate :'bookmarks_http_method=' => 'Moved to `blacklight.bookmarks_http_method=`'
-
-      # @deprecated
-      def email_regexp
-        self.blacklight.email_regexp
-      end
-      deprecation_deprecate email_regexp: 'Moved to `blacklight.email_regexp`'
-
-      # @deprecated
-      def email_regexp=(val)
-        self.blacklight.email_regexp = val
-      end
-      deprecation_deprecate :'email_regexp=' => 'Moved to `blacklight.email_regexp=`'
-
-      # @deprecated
-      def facet_missing_param
-        self.blacklight.facet_missing_param
-      end
-      deprecation_deprecate facet_missing_param: 'Moved to `blacklight.facet_missing_param`'
-
-      # @deprecated
-      def facet_missing_param=(val)
-        self.blacklight.facet_missing_param = val
-      end
-      deprecation_deprecate :'facet_missing_param=' => 'Moved to `blacklight.facet_missing_param=`'
-
-      # @deprecated
-      def sms_mappings
-        self.blacklight.sms_mappings
-      end
-      deprecation_deprecate sms_mappings: 'Moved to `blacklight.sms_mappings`'
-
-      # @deprecated
-      def sms_mappings=(val)
-        self.blacklight.sms_mappings = val
-      end
-      deprecation_deprecate :'sms_mappings=' => 'Moved to `blacklight.sms_mappings=`'
-      # rubocop:enable Style/RedundantSelf, Style/HashSyntax
-
-      def self.deprecate_in(object)
-        class << object
-          extend Deprecation
-          self.deprecation_horizon = 'blacklight 8.0'
-
-          include Blacklight::Deprecations::EngineConfiguration
-        end
-      end
-    end
-  end
-end

data/lib/blacklight/deprecations/search_state_normalization.rb

@@ -1,52 +0,0 @@
-# frozen_string_literal: true
-
-module Blacklight
-  module Deprecations
-    module SearchStateNormalization
-      extend ActiveSupport::Concern
-
-      class_methods do
-        def facet_params_need_normalization(facet_params)
-          Deprecation.warn(self, 'Calling `facet_params_need_normalization` on the Blacklight::SearchState ' \
-          'class is deprecated and will be removed in Blacklight 8. Delegate to #needs_normalization?(value_params) on the ' \
-          'filter fields of the search state object.')
-
-          facet_params.is_a?(Hash) && facet_params.values.any? { |x| x.is_a?(Hash) }
-        end
-
-        def normalize_facet_params(facet_params)
-          Deprecation.warn(self, 'Calling `normalize_facet_params` on the Blacklight::SearchState ' \
-          'class is deprecated and will be removed in Blacklight 8. Delegate to #normalize(value_params) on the ' \
-          'filter fields of the search state object.')
-
-          facet_params.transform_values { |value| value.is_a?(Hash) ? value.values : value }
-        end
-
-        def normalize_params(untrusted_params = {})
-          Deprecation.warn(self, 'Calling `normalize_params` on the Blacklight::SearchState ' \
-          'class is deprecated and will be removed in Blacklight 8. Call #normalize_params on the ' \
-          'search state object.')
-          params = untrusted_params
-
-          if params.respond_to?(:to_unsafe_h)
-            # This is the typical (not-ActionView::TestCase) code path.
-            params = params.to_unsafe_h
-            # In Rails 5 to_unsafe_h returns a HashWithIndifferentAccess, in Rails 4 it returns Hash
-            params = params.with_indifferent_access if params.instance_of? Hash
-          elsif params.is_a? Hash
-            # This is an ActionView::TestCase workaround for Rails 4.2.
-            params = params.dup.with_indifferent_access
-          else
-            params = params.dup.to_h.with_indifferent_access
-          end
-
-          # Normalize facet parameters mangled by facebook
-          params[:f] = normalize_facet_params(params[:f]) if facet_params_need_normalization(params[:f])
-          params[:f_inclusive] = normalize_facet_params(params[:f_inclusive]) if facet_params_need_normalization(params[:f_inclusive])
-
-          params
-        end
-      end
-    end
-  end
-end

data/spec/components/blacklight/header_component_spec.rb

@@ -1,20 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.describe Blacklight::HeaderComponent, type: :component do
-  before do
-    with_controller_class(CatalogController) do
-      allow(controller).to receive(:current_user).and_return(nil)
-      allow(controller).to receive(:search_action_url).and_return('/search')
-      render
-    end
-  end
-
-  context 'with no slots' do
-    let(:render) { render_inline(described_class.new(blacklight_config: CatalogController.blacklight_config)) }
-
-    it 'draws the topbar' do
-      expect(page).to have_css 'nav.topbar'
-      expect(page).to have_link 'Blacklight', href: '/'
-    end
-  end
-end

data/spec/components/blacklight/icons/icon_component_spec.rb

@@ -1,42 +0,0 @@
-# frozen_string_literal: true
-
-require 'spec_helper'
-
-RSpec.describe Blacklight::Icons::IconComponent, type: :component do
-  subject(:component) { sub_component.new }
-
-  let(:sub_component) do
-    Class.new(described_class) do
-      def self.name
-        'TestIconComponent'
-      end
-    end
-  end
-
-  context 'when no classes are passed in' do
-    subject(:component) { sub_component.new }
-
-    it "renders component" do
-      render_inline(component)
-      expect(page).to have_css "span[class='blacklight-icons blacklight-icons-test_icon']"
-    end
-  end
-
-  context 'when classes are passed in' do
-    subject(:component) { sub_component.new(classes: 'my-icon') }
-
-    it "renders component" do
-      render_inline(component)
-      expect(page).to have_css "span[class='my-icon blacklight-icons blacklight-icons-test_icon']"
-    end
-  end
-
-  context 'when name is passed in' do
-    subject(:component) { sub_component.new(name: 'my-icon') }
-
-    it "renders component" do
-      render_inline(component)
-      expect(page).to have_css "span[class='blacklight-icons blacklight-icons-my-icon']"
-    end
-  end
-end