blacklight 7.41.0 → 8.0.0.beta1

data/.rubocop_todo.yml

@@ -1,169 +1,35 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-09-23 14:38:22 UTC using RuboCop version 1.66.1.
+# on 2022-06-27 19:52:51 UTC using RuboCop version 1.31.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-Capybara/CurrentPathExpectation:
-  Exclude:
-    - 'spec/features/alternate_controller_spec.rb'
-
-# Offense count: 20
-Capybara/VisibilityMatcher:
-  Exclude:
-    - 'spec/features/facets_spec.rb'
-    - 'spec/features/search_filters_spec.rb'
-    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
-    - 'spec/helpers/blacklight_helper_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyleAlignWith, Severity.
-# SupportedStylesAlignWith: start_of_line, begin
-Layout/BeginEndAlignment:
-  Exclude:
-    - 'app/models/record_mailer.rb'
-    - 'spec/features/search_results_spec.rb'
-
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Layout/CaseIndentation:
-  Exclude:
-    - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/presenters/blacklight/index_presenter.rb'
-    - 'lib/blacklight/configuration/fields.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/ClosingParenthesisIndentation:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-
-# Offense count: 114
-# This cop supports safe autocorrection (--autocorrect).
-Layout/EmptyLineAfterMagicComment:
-  Enabled: false
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Exclude:
-    - 'app/presenters/blacklight/field_presenter.rb'
-
-# Offense count: 8
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'app/models/concerns/blacklight/document/dublin_core.rb'
-    - 'app/models/record_mailer.rb'
-    - 'app/views/catalog/index.atom.builder'
-    - 'config/routes.rb'
-    - 'spec/models/blacklight/configurable_spec.rb'
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'app/models/blacklight/facet_paginator.rb'
-    - 'app/models/concerns/blacklight/configurable.rb'
-    - 'app/models/concerns/blacklight/document/export.rb'
-    - 'app/views/catalog/_document.atom.builder'
-    - 'lib/blacklight/solr/response/pagination_methods.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Layout/MultilineBlockLayout:
-  Exclude:
-    - 'lib/generators/blacklight/test_support_generator.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineMethodCallBraceLayout:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented, indented_relative_to_receiver
-Layout/MultilineMethodCallIndentation:
-  Exclude:
-    - 'lib/blacklight/search_builder.rb'
-
-# Offense count: 9
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented
-Layout/MultilineOperationIndentation:
-  Exclude:
-    - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
-    - 'lib/blacklight/configuration/context.rb'
-    - 'lib/blacklight/search_state.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/RescueEnsureAlignment:
-  Exclude:
-    - 'app/models/record_mailer.rb'
-    - 'spec/features/search_results_spec.rb'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Layout/SpaceAfterComma:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-    - 'app/views/catalog/opensearch.xml.builder'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowForAlignment.
-Layout/SpaceBeforeFirstArg:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-    - 'spec/models/blacklight/configurable_spec.rb'
-
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, compact, no_space
-Layout/SpaceInsideParens:
+# Offense count: 5
+# Configuration parameters: AutoCorrect.
+Layout/LineContinuationLeadingSpace:
   Exclude:
-    - 'app/views/catalog/_document.rss.builder'
-    - 'app/views/catalog/index.atom.builder'
+    - 'lib/generators/blacklight/controller_generator.rb'
+    - 'lib/generators/blacklight/user_generator.rb'
 
 # Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowedMethods, AllowedPatterns.
+# Configuration parameters: IgnoredMethods.
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 9
+# Offense count: 5
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperator:
   Exclude:
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/models/blacklight/facet_paginator_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 55
+# Offense count: 44
 # This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousRegexpLiteral:
   Exclude:
@@ -175,7 +41,6 @@ Lint/AmbiguousRegexpLiteral:
     - 'spec/views/catalog/_document.html.erb_spec.rb'
     - 'spec/views/catalog/_search_header.erb_spec.rb'
     - 'spec/views/catalog/_sort_and_per_page.html.erb_spec.rb'
-    - 'spec/views/catalog/_thumbnail.html.erb_spec.rb'
     - 'spec/views/catalog/index.html.erb_spec.rb'
     - 'spec/views/catalog/show.html.erb_spec.rb'
 
@@ -184,13 +49,11 @@ Lint/BinaryOperatorWithIdenticalOperands:
   Exclude:
     - 'spec/models/blacklight/document/active_model_shim_spec.rb'
 
-# Offense count: 16
+# Offense count: 14
 # Configuration parameters: AllowedMethods.
 # AllowedMethods: enums
 Lint/ConstantDefinitionInBlock:
   Exclude:
-    - 'lib/blacklight/engine.rb'
-    - 'spec/controllers/blacklight/search_fields_spec.rb'
     - 'spec/controllers/bookmarks_controller_spec.rb'
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/models/blacklight/configurable_spec.rb'
@@ -199,18 +62,24 @@ Lint/ConstantDefinitionInBlock:
     - 'spec/models/blacklight/solr/document_spec.rb'
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
 
+# Offense count: 2
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/bookmarks.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+
 # Offense count: 1
 # Configuration parameters: AllowComments.
 Lint/EmptyFile:
   Exclude:
     - 'spec/components/blacklight/document_metadata_component_spec.rb'
 
-# Offense count: 46
-# Configuration parameters: AllowedParentClasses.
+# Offense count: 38
 Lint/MissingSuper:
   Enabled: false
 
-# Offense count: 30
+# Offense count: 29
 # This cop supports safe autocorrection (--autocorrect).
 Lint/ParenthesesAsGroupedExpression:
   Exclude:
@@ -218,73 +87,66 @@ Lint/ParenthesesAsGroupedExpression:
     - 'spec/features/search_filters_spec.rb'
     - 'spec/features/search_pagination_spec.rb'
     - 'spec/features/search_spec.rb'
-    - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/solr/repository_spec.rb'
 
-# Offense count: 2
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowedMethods.
-# AllowedMethods: instance_of?, kind_of?, is_a?, eql?, respond_to?, equal?, presence, present?
-Lint/RedundantSafeNavigation:
-  Exclude:
-    - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
-    - 'lib/blacklight/solr/response/params.rb'
-
 # Offense count: 2
 Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'spec/models/blacklight/configuration_spec.rb'
 
-# Offense count: 87
-# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
+# Offense count: 74
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
   Max: 46
 
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns, inherit_mode.
-# AllowedMethods: refine
+# Offense count: 1
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods, inherit_mode.
+# IgnoredMethods: refine
 Metrics/BlockLength:
-  Max: 29
+  Max: 26
+
+# Offense count: 1
+# Configuration parameters: CountBlocks.
+Metrics/BlockNesting:
+  Max: 4
 
-# Offense count: 47
-# Configuration parameters: AllowedMethods, AllowedPatterns.
+# Offense count: 43
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 17
+  Max: 14
 
-# Offense count: 94
-# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+# Offense count: 69
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 29
 
-# Offense count: 9
+# Offense count: 3
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 203
+  Max: 126
 
 # Offense count: 8
 # Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 40
-# Configuration parameters: AllowedMethods, AllowedPatterns.
+# Offense count: 36
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 18
+  Max: 14
 
-# Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
+# Offense count: 3
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
   Exclude:
-    - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document/semantic_fields.rb'
     - 'lib/blacklight/solr/response.rb'
 
-# Offense count: 10
+# Offense count: 9
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: as, at, by, cc, db, id, if, in, io, ip, of, on, os, pp, to
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
   Exclude:
     - 'app/models/concerns/blacklight/document.rb'
@@ -293,105 +155,86 @@ Naming/MethodParameterName:
     - 'lib/blacklight/solr/document.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 25
+# Offense count: 9
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
-# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
 Naming/VariableNumber:
   Exclude:
     - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
-    - 'spec/views/catalog/_facet_group.html.erb_spec.rb'
-    - 'spec/views/catalog/_index.html.erb_spec.rb'
-    - 'spec/views/catalog/_show.html.erb_spec.rb'
-
-# Offense count: 55
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Enabled: false
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be, be_nil
-RSpec/BeNil:
-  Exclude:
-    - 'spec/models/blacklight/icon_spec.rb'
-    - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 9
+# Offense count: 7
 RSpec/BeforeAfterAll:
   Exclude:
-    - 'spec/controllers/blacklight/search_fields_spec.rb'
     - 'spec/controllers/search_history_controller_spec.rb'
-    - 'spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb'
     - 'spec/models/blacklight/configurable_spec.rb'
     - 'spec/models/blacklight/document/dublin_core_spec.rb'
     - 'spec/models/blacklight/document/email_spec.rb'
     - 'spec/models/blacklight/document/sms_spec.rb'
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 50
+# Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: be_a, be_kind_of
-RSpec/ClassCheck:
-  Enabled: false
+RSpec/Capybara/CurrentPathExpectation:
+  Exclude:
+    - 'spec/features/alternate_controller_spec.rb'
+
+# Offense count: 13
+RSpec/Capybara/VisibilityMatcher:
+  Exclude:
+    - 'spec/features/facets_spec.rb'
+    - 'spec/features/search_filters_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
 
-# Offense count: 110
-# Configuration parameters: Prefixes, AllowedPatterns.
+# Offense count: 98
+# Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
 # Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AutoCorrect.
 RSpec/EmptyExampleGroup:
   Exclude:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
-# Offense count: 152
+# Offense count: 128
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 33
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: CustomTransform, IgnoredWords, DisallowedExamples.
-# DisallowedExamples: works
-RSpec/ExampleWording:
-  Exclude:
-    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
-    - 'spec/presenters/blacklight/facet_item_presenter_spec.rb'
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/ExcessiveDocstringSpacing:
-  Exclude:
-    - 'spec/helpers/blacklight_helper_spec.rb'
-    - 'spec/models/blacklight/icon_spec.rb'
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-
-# Offense count: 11
+# Offense count: 8
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
-    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
 
-# Offense count: 9
-# Configuration parameters: Max, AllowedIdentifiers, AllowedPatterns.
-RSpec/IndexedLet:
+# Offense count: 5
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
+RSpec/FilePath:
   Exclude:
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/models/blacklight/facet_paginator_spec.rb'
+    - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
+    - 'spec/features/sitelinks_search_box.rb'
+    - 'spec/models/blacklight/solr/search_builder_spec.rb'
+    - 'spec/presenters/pipeline_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 188
+# Offense count: 128
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
-  Enabled: false
+  Exclude:
+    - 'spec/controllers/bookmarks_controller_spec.rb'
+    - 'spec/controllers/search_history_controller_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/lib/blacklight/open_struct_with_hash_access_spec.rb'
+    - 'spec/lib/tasks/blacklight_task_spec.rb'
+    - 'spec/models/blacklight/configuration_spec.rb'
+    - 'spec/models/blacklight/document/dublin_core_spec.rb'
+    - 'spec/models/blacklight/solr/document_spec.rb'
+    - 'spec/models/record_mailer_spec.rb'
+    - 'spec/models/search_spec.rb'
+    - 'spec/services/blacklight/search_service_spec.rb'
+    - 'spec/views/catalog/index.atom.builder_spec.rb'
 
 # Offense count: 4
 RSpec/IteratedExpectation:
@@ -400,10 +243,9 @@ RSpec/IteratedExpectation:
     - 'spec/models/blacklight/solr/response/group_spec.rb'
     - 'spec/models/blacklight/solr/response_spec.rb'
 
-# Offense count: 17
+# Offense count: 16
 RSpec/LeakyConstantDeclaration:
   Exclude:
-    - 'spec/controllers/blacklight/search_fields_spec.rb'
     - 'spec/controllers/bookmarks_controller_spec.rb'
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/models/blacklight/configurable_spec.rb'
@@ -412,18 +254,6 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/models/blacklight/solr/document_spec.rb'
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
 
-# Offense count: 14
-# This cop supports safe autocorrection (--autocorrect).
-RSpec/MatchArray:
-  Exclude:
-    - 'spec/controllers/catalog_controller_spec.rb'
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/lib/blacklight/open_struct_with_hash_access_spec.rb'
-    - 'spec/models/blacklight/configuration_spec.rb'
-    - 'spec/models/blacklight/search_builder_spec.rb'
-    - 'spec/models/blacklight/solr/request_spec.rb'
-    - 'spec/views/catalog/index.json.jbuilder_spec.rb'
-
 # Offense count: 9
 RSpec/MessageChain:
   Exclude:
@@ -431,80 +261,43 @@ RSpec/MessageChain:
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 57
+# Offense count: 30
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/helpers/catalog_helper_spec.rb'
-    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
     - 'spec/models/blacklight/suggest_search_spec.rb'
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 63
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: hash, symbol
-RSpec/MetadataStyle:
-  Enabled: false
-
-# Offense count: 437
+# Offense count: 364
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 272
+# Offense count: 258
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 14
 
-# Offense count: 417
-# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
-# SupportedStyles: always, named_only
+# Offense count: 388
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Enabled: false
 
-# Offense count: 57
-# Configuration parameters: AllowedGroups.
+# Offense count: 55
 RSpec/NestedGroups:
   Max: 5
 
-# Offense count: 5
-# Configuration parameters: AllowedPatterns.
-# AllowedPatterns: ^expect_, ^assert_
-RSpec/NoExpectationExample:
-  Exclude:
-    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_partials_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight_helper_spec.rb'
-    - 'spec/lib/tasks/blacklight_task_spec.rb'
-    - 'spec/views/catalog/facet.html.erb_spec.rb'
-
-# Offense count: 3
-RSpec/PendingWithoutReason:
-  Exclude:
-    - 'spec/components/blacklight/facet_item_pivot_component_spec.rb'
-    - 'spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb'
-    - 'spec/i18n_spec.rb'
-
-# Offense count: 84
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/ReceiveMessages:
-  Enabled: false
-
-# Offense count: 11
+# Offense count: 6
 RSpec/RepeatedDescription:
   Exclude:
     - 'spec/features/search_results_spec.rb'
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
     - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
@@ -513,39 +306,23 @@ RSpec/RepeatedExample:
   Exclude:
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 4
+# Offense count: 2
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 4
+# Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect.
 RSpec/ScatteredLet:
   Exclude:
-    - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 5
-# Configuration parameters: Include, CustomTransform, IgnoreMethods, IgnoreMetadata.
-# Include: **/*_spec.rb
-RSpec/SpecFilePathFormat:
-  Exclude:
-    - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
-    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-    - 'spec/presenters/pipeline_spec.rb'
-    - 'spec/presenters/thumbnail_presenter_spec.rb'
-
-# Offense count: 24
+# Offense count: 22
 RSpec/StubbedMock:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/helpers/catalog_helper_spec.rb'
@@ -558,28 +335,22 @@ RSpec/SubjectDeclaration:
   Exclude:
     - 'spec/models/blacklight/document/cache_key_spec.rb'
 
-# Offense count: 12
+# Offense count: 15
 RSpec/SubjectStub:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/document/cache_key_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
     - 'spec/presenters/blacklight/document_presenter_spec.rb'
-    - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 132
+# Offense count: 77
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
 
-# Offense count: 1
-RSpec/VoidExpect:
-  Exclude:
-    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
-
 # Offense count: 4
-# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle, AllowToTime.
 # SupportedStyles: strict, flexible
 Rails/Date:
@@ -587,14 +358,13 @@ Rails/Date:
     - 'spec/models/search_spec.rb'
 
 # Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: slashes, arguments
 Rails/FilePath:
   Exclude:
-    - 'lib/blacklight/component.rb'
+    - 'lib/railties/blacklight.rake'
 
-# Offense count: 31
+# Offense count: 20
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
@@ -602,21 +372,21 @@ Rails/HelperInstanceVariable:
     - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/helpers/blacklight/component_helper_behavior.rb'
-    - 'app/helpers/blacklight/facets_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
 
 # Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: numeric, symbolic
-Rails/HttpStatus:
+# Configuration parameters: Include.
+# Include: spec/**/*.rb, test/**/*.rb
+Rails/I18nLocaleAssignment:
   Exclude:
-    - 'app/controllers/concerns/blacklight/bookmarks.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
 
-# Offense count: 2
+# Offense count: 10
 Rails/OutputSafety:
   Exclude:
-    - 'app/helpers/blacklight/icon_helper_behavior.rb'
+    - 'app/components/blacklight/search_context_component.rb'
+    - 'app/helpers/blacklight/catalog_helper_behavior.rb'
+    - 'app/helpers/blacklight/configuration_helper_behavior.rb'
     - 'app/presenters/blacklight/rendering/join.rb'
 
 # Offense count: 14
@@ -624,14 +394,6 @@ Security/Eval:
   Exclude:
     - 'spec/models/blacklight/solr/response_spec.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: separated, grouped
-Style/AccessorGrouping:
-  Exclude:
-    - 'lib/blacklight/search_state.rb'
-
 # Offense count: 9
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -647,17 +409,17 @@ Style/Alias:
 
 # Offense count: 3
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
 # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
 # FunctionalMethods: let, let!, subject, watch
-# AllowedMethods: lambda, proc, it
+# IgnoredMethods: lambda, proc, it
 Style/BlockDelimiters:
   Exclude:
     - 'app/views/catalog/index.rss.builder'
     - 'app/views/catalog/opensearch.xml.builder'
 
-# Offense count: 56
+# Offense count: 52
 # This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
@@ -679,7 +441,13 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 127
+# Offense count: 2
+Style/DocumentDynamicEvalDefinition:
+  Exclude:
+    - 'app/builders/blacklight/action_builder.rb'
+    - 'lib/blacklight/configuration/fields.rb'
+
+# Offense count: 105
 # Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
@@ -699,22 +467,14 @@ Style/ExpandPathArguments:
     - 'lib/generators/blacklight/test_support_generator.rb'
     - 'lib/generators/blacklight/user_generator.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/ExplicitBlockArgument:
-  Exclude:
-    - 'tasks/blacklight.rake'
-
-# Offense count: 17
+# Offense count: 16
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
-# AllowedMethods: redirect
 Style/FormatStringToken:
   EnforcedStyle: template
 
-# Offense count: 7
-# This cop supports safe autocorrection (--autocorrect).
+# Offense count: 6
 # Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
   Exclude:
@@ -724,38 +484,11 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: braces, no_braces
-Style/HashAsLastArrayItem:
-  Exclude:
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-
-# Offense count: 8
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowedReceivers.
-# AllowedReceivers: Thread.current
-Style/HashEachMethods:
-  Exclude:
-    - 'app/components/blacklight/advanced_search_form_component.rb'
-    - 'spec/controllers/catalog_controller_spec.rb'
-    - 'spec/models/blacklight/solr/response_spec.rb'
-    - 'spec/services/blacklight/search_service_spec.rb'
-
-# Offense count: 38
+# Offense count: 30
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Enabled: false
 
-# Offense count: 4
-# This cop supports safe autocorrection (--autocorrect).
-Style/KeywordParametersOrder:
-  Exclude:
-    - 'app/components/blacklight/document/thumbnail_component.rb'
-    - 'app/components/blacklight/response/view_type_component.rb'
-    - 'app/components/blacklight/system/flash_message_component.rb'
-
 # Offense count: 6
 # This cop supports safe autocorrection (--autocorrect).
 Style/MultilineIfModifier:
@@ -766,7 +499,7 @@ Style/MultilineIfModifier:
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowMethodComparison, ComparisonsThreshold.
+# Configuration parameters: AllowMethodComparison.
 Style/MultipleComparison:
   Exclude:
     - 'lib/blacklight/configuration/context.rb'
@@ -781,7 +514,7 @@ Style/MutableConstant:
 
 # Offense count: 9
 # This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle, AllowedMethods, AllowedPatterns.
+# Configuration parameters: EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
@@ -793,7 +526,18 @@ Style/NumericPredicate:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 3
+# Offense count: 15
+Style/OpenStructUse:
+  Exclude:
+    - 'lib/blacklight/configuration.rb'
+    - 'lib/blacklight/open_struct_with_hash_access.rb'
+    - 'lib/blacklight/solr/response/facets.rb'
+    - 'spec/components/blacklight/facet_item_pivot_component_spec.rb'
+    - 'spec/lib/blacklight/search_state/filter_field_spec.rb'
+    - 'spec/models/blacklight/configuration_spec.rb'
+    - 'spec/models/blacklight/solr/response_spec.rb'
+
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
@@ -808,27 +552,6 @@ Style/PercentLiteralDelimiters:
     - 'lib/blacklight/engine.rb'
     - 'lib/blacklight/solr/request.rb'
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantBegin:
-  Exclude:
-    - 'lib/blacklight.rb'
-    - 'lib/blacklight/configuration.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Style/RedundantParentheses:
-  Exclude:
-    - 'app/views/catalog/_document.atom.builder'
-
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowMultipleReturnValues.
-Style/RedundantReturn:
-  Exclude:
-    - 'app/models/concerns/blacklight/document/email.rb'
-    - 'app/models/concerns/blacklight/document/sms.rb'
-
 # Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
@@ -869,22 +592,7 @@ Style/SoleNestedConditional:
   Exclude:
     - 'app/controllers/concerns/blacklight/controller.rb'
 
-# Offense count: 12
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: Mode.
-Style/StringConcatenation:
-  Exclude:
-    - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
-    - 'app/helpers/blacklight/render_constraints_helper_behavior.rb'
-    - 'lib/blacklight/configuration/fields.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-    - 'lib/railties/blacklight.rake'
-    - 'spec/features/search_results_spec.rb'
-    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
-    - 'spec/models/blacklight/solr/response_spec.rb'
-    - 'spec/routing/catalog_routing_spec.rb'
-
-# Offense count: 42
+# Offense count: 34
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets