blacklight 7.33.0 → 8.0.0

data/app/components/blacklight/constraints_component.rb

@@ -2,8 +2,6 @@
 
 module Blacklight
   class ConstraintsComponent < Blacklight::Component
-    include Blacklight::ContentAreasShim
-
     renders_many :query_constraints_area
     renders_many :facet_constraints_area
     renders_many :additional_constraints
@@ -42,60 +40,52 @@ module Blacklight
     # rubocop:enable Metrics/ParameterLists
 
     def query_constraints
-      Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) do
-        if @search_state.query_param.present?
-          helpers.render(
-            @query_constraint_component.new(
-              search_state: @search_state,
-              value: @search_state.query_param,
-              label: label,
-              remove_path: helpers.remove_constraint_url(@search_state),
-              classes: 'query',
-              **@query_constraint_component_options
-            )
+      if @search_state.query_param.present?
+        helpers.render(
+          @query_constraint_component.new(
+            search_state: @search_state,
+            value: @search_state.query_param,
+            label: label,
+            remove_path: remove_path,
+            classes: 'query',
+            **@query_constraint_component_options
           )
-        else
-          ''.html_safe
-        end
+        )
+      else
+        ''.html_safe
       end + helpers.render(@facet_constraint_component.with_collection(clause_presenters.to_a, **@facet_constraint_component_options))
     end
 
+    def remove_path
+      helpers.search_action_path(@search_state.remove_query_params)
+    end
+
     def facet_constraints
       helpers.render(@facet_constraint_component.with_collection(facet_item_presenters.to_a, **@facet_constraint_component_options))
     end
 
     def render?
-      Deprecation.silence(Blacklight::RenderConstraintsHelperBehavior) { helpers.query_has_constraints?(@search_state.params) }
+      @search_state.has_constraints?
     end
 
     private
 
-    # @deprecated
-    def start_over_path
-      Deprecation.silence(Blacklight::UrlHelperBehavior) do
-        helpers.start_over_path
-      end
-    end
-
     def label
-      Deprecation.silence(Blacklight::ConfigurationHelperBehavior) do
-        helpers.constraint_query_label(@search_state.params)
-      end
+      search_field = @search_state.params[:search_field]
+      helpers.label_for_search_field(search_field) unless helpers.default_search_field?(search_field)
     end
 
     def facet_item_presenters
       return to_enum(:facet_item_presenters) unless block_given?
 
-      Deprecation.silence(Blacklight::SearchState) do
-        @search_state.filters.map do |facet|
-          facet.values.map do |val|
-            next if val.blank?
+      @search_state.filters.map do |facet|
+        facet.each_value do |val|
+          next if val.blank?
 
-            if val.is_a?(Array)
-              yield inclusive_facet_item_presenter(facet.config, val, facet.key) if val.any?(&:present?)
-            else
-              yield facet_item_presenter(facet.config, val, facet.key)
-            end
+          if val.is_a?(Array)
+            yield inclusive_facet_item_presenter(facet.config, val, facet.key) if val.any?(&:present?)
+          else
+            yield facet_item_presenter(facet.config, val, facet.key)
           end
         end
       end
@@ -111,7 +101,7 @@ module Blacklight
     end
 
     def facet_item_presenter(facet_config, facet_item, facet_field)
-      (facet_config.item_presenter || Blacklight::FacetItemPresenter).new(facet_item, facet_config, helpers, facet_field)
+      facet_config.item_presenter.new(facet_item, facet_config, helpers, facet_field)
     end
 
     def inclusive_facet_item_presenter(facet_config, facet_item, facet_field)

data/app/components/blacklight/document/action_component.html.erb

@@ -1,9 +1,2 @@
-<% if using_default_document_action? %>
-  <%= link_to label,
-              url,
-              id: @id,
-              class: @link_classes,
-              data: {}.merge(({ blacklight_modal: "trigger", turbo: false } if @action.modal != false) || {}) %>
-<% else %>
-  <%= helpers.render(partial: @action.partial || @action.name.to_s, locals: { document: @document, document_action_config: @action }.merge(@options)) %>
-<% end %>
+<%# We keep this template around so that downstream applications can override the template if desired %>
+<%= render_control %>

data/app/components/blacklight/document/action_component.rb

@@ -16,17 +16,30 @@ module Blacklight
         @link_classes = link_classes
       end
 
+      def render_control
+        return link_to_modal_control if using_default_document_action?
+
+        render_partial
+      end
+
       def using_default_document_action?
-        return true if @action.component
-        return false unless @action.partial == 'document_action'
+        @action.component || @action.partial == 'document_action'
+      end
 
-        helpers.partial_from_blacklight?(@action.partial)
+      def link_to_modal_control
+        link_to label,
+                url,
+                id: @id,
+                class: @link_classes,
+                data: {}.merge(({ blacklight_modal: "trigger", turbo: false } if @action.modal != false) || {})
+      end
+
+      def render_partial
+        helpers.render(partial: @action.partial || @action.name.to_s, locals: { document: @document, document_action_config: @action }.merge(@options))
       end
 
       def label
-        Deprecation.silence(Blacklight::ComponentHelperBehavior) do
-          helpers.document_action_label(@action.name, @action)
-        end
+        t("blacklight.tools.#{@action.name}", default: @action.label || @action.name.to_s.humanize)
       end
 
       # Action buttons get their URLs in one of three ways:
@@ -37,8 +50,13 @@ module Blacklight
       #     default Rails routing behavior)
       # - calling out to an implicit helper method with a conventional name (unlikely)
       def url
-        Deprecation.silence(Blacklight::ComponentHelperBehavior) do
-          helpers.document_action_path(@action, @url_opts.merge(({ id: @document } if @document) || {}))
+        url_opts = @url_opts.merge(({ id: @document } if @document) || {})
+        if @action.path
+          helpers.public_send(@action.path, url_opts)
+        elsif url_opts[:id].class.respond_to?(:model_name)
+          helpers.url_for([@action.key.to_sym, url_opts[:id]])
+        else
+          helpers.public_send("#{@action.key}_#{helpers.controller_name}_path", url_opts)
         end
       end
 

data/app/components/blacklight/document/actions_component.rb

@@ -2,7 +2,7 @@
 
 module Blacklight
   module Document
-    # Render a bookmark widget to bookmark / unbookmark a document
+    # Render a the set of actions for a document. One of the default actions is the bookmark control.
     class ActionsComponent < Blacklight::Component
       renders_many :actions, (lambda do |action:, component: nil, **kwargs|
         component ||= action.component || Blacklight::Document::ActionComponent
@@ -28,7 +28,7 @@ module Blacklight
         return if actions.present?
 
         @actions.each do |a|
-          action(component: a.component, action: a)
+          with_action(component: a.component, action: a)
         end
       end
 

data/app/components/blacklight/document/bookmark_component.html.erb

@@ -1,7 +1,9 @@
 <%-
 # the data-doc-id attribute is used by our JS that converts to a checkbox/label.
+# we don't use the per-form csrf token
 -%>
 <%= form_tag(bookmark_path,
+             authenticity_token: false,
              method:  bookmarked? ? :delete : :put,
              class: "bookmark-toggle",
              data: {
@@ -10,6 +12,13 @@
                absent: t('blacklight.search.bookmarks.absent'),
                inprogress: t('blacklight.search.bookmarks.inprogress')
             }) do %>
+  <div class="checkbox toggle-bookmark">
+    <label class="toggle-bookmark" data-checkboxsubmit-target="label">
+      <input type="checkbox" class="toggle-bookmark" data-checkboxsubmit-target="checkbox" <%= 'checked="checked"' if bookmarked? %>>
+      <span data-checkboxsubmit-target="span"><%= bookmarked? ? t('blacklight.search.bookmarks.present') : t('blacklight.search.bookmarks.absent') %></span>
+    </label>
+  </div>
+
   <%= submit_tag(t(bookmarked? ? 'remove.button' : 'add.button', scope: 'blacklight.bookmarks'),
                  id: "bookmark_toggle_#{@document.id.to_s.parameterize}",
                  class: "bookmark-#{bookmarked? ? 'remove' : 'add'} btn btn-outline-secondary") %>

data/app/components/blacklight/document/bookmark_component.rb

@@ -3,14 +3,16 @@
 module Blacklight
   module Document
     # Render a bookmark widget to bookmark / unbookmark a document
-    class BookmarkComponent < Blacklight::Component
+    class BookmarkComponent < Blacklight::Document::ActionComponent
       # @param [Blacklight::Document] document
+      # @param [Blacklight::Configuration::ToolConfig] action
       # @param [Boolean] checked
       # @param [Object] bookmark_path the rails route to use for bookmarks
-      def initialize(document:, checked: nil, bookmark_path: nil)
+      def initialize(document:, action: nil, checked: nil, bookmark_path: nil, **kwargs)
         @document = document
         @checked = checked
         @bookmark_path = bookmark_path
+        super(document: document, action: action, **kwargs)
       end
 
       def bookmarked?

data/app/components/blacklight/document/citation_component.rb

@@ -22,9 +22,11 @@ module Blacklight
 
       # @return [String]
       def title
-        Deprecation.silence(Blacklight::BlacklightHelperBehavior) do
-          helpers.document_heading(@document)
-        end
+        presenter.heading
+      end
+
+      def presenter
+        helpers.document_presenter(@document)
       end
     end
   end

data/app/components/blacklight/document/group_component.rb

@@ -17,10 +17,14 @@ module Blacklight
         helpers.render_document_index @group.docs
       end
 
+      # Get path to a search within a grouped result set
+      #
+      # @param [Blacklight::Solr::Response::Group] group
+      # @return [Hash]
       def add_group_facet_params_and_redirect(group)
-        Deprecation.silence(Blacklight::UrlHelperBehavior) do
-          helpers.search_action_path(helpers.add_group_facet_params_and_redirect(group))
-        end
+        helpers.search_action_path(
+          helpers.search_state.add_facet_params_and_redirect(group.field, group.key)
+        )
       end
     end
   end

data/app/components/blacklight/document/show_tools_component.html.erb

@@ -0,0 +1,12 @@
+<div class="card show-tools">
+  <div class="card-header">
+    <h2 class="mb-0 h6"><%= t('blacklight.tools.title') %></h2>
+  </div>
+  <%= render Blacklight::Document::ActionsComponent.new(document: document,
+                                                        tag: 'ul',
+                                                        classes: 'list-group list-group-flush',
+                                                        wrapping_tag: 'li',
+                                                        wrapping_classes: 'list-group-item list-group-item-action',
+                                                        actions: actions,
+                                                        url_opts: Blacklight::Parameters.sanitize(params.to_unsafe_h)) %>
+</div>

data/app/components/blacklight/document/show_tools_component.rb

@@ -0,0 +1,23 @@
+# frozen_string_literal: true
+
+module Blacklight
+  module Document
+    # Render the tools that display on the sidebar of the show page
+    class ShowToolsComponent < Blacklight::Component
+      # @param [Blacklight::Document] document
+      def initialize(document:)
+        @document = document
+      end
+
+      attr_reader :document
+
+      def render?
+        helpers.show_doc_actions?
+      end
+
+      def actions
+        helpers.document_actions(document)
+      end
+    end
+  end
+end

data/app/components/blacklight/document/sidebar_component.html.erb

@@ -0,0 +1,2 @@
+<%= render 'show_tools', document: document %>
+<%= render(Blacklight::Document::MoreLikeThisComponent.new(document: document)) %>

data/app/components/blacklight/document/sidebar_component.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+module Blacklight
+  module Document
+    # Render the sidebar on the show view
+    class SidebarComponent < Blacklight::Component
+      # @param [Blacklight::DocumentPresenter] presenter
+      def initialize(presenter:)
+        @presenter = presenter
+        @document = presenter.document
+      end
+
+      attr_reader :document
+    end
+  end
+end

data/app/components/blacklight/document/thumbnail_component.html.erb

@@ -1,12 +1,7 @@
-<% value = use_thumbnail_tag_behavior? ? presenter.thumbnail.thumbnail_tag(@image_options, 'aria-hidden': true, tabindex: -1, counter: @counter) : presenter.thumbnail.render(@image_options) %>
+<% value = presenter.thumbnail.render(@image_options) %>
 
 <% if value %>
   <div class="document-thumbnail">
-    <% if use_thumbnail_tag_behavior? %>
-      <% warn_about_deprecated_behavior %>
-      <%= value %>
-    <% else %>
-      <%= helpers.link_to_document(presenter.document, value, 'aria-hidden': true, tabindex: -1, counter: @counter) %>
-    <% end %>
+    <%= helpers.link_to_document(presenter.document, value, 'aria-hidden': true, tabindex: -1, counter: @counter) %>
   </div>
 <% end %>

data/app/components/blacklight/document/thumbnail_component.rb

@@ -9,7 +9,7 @@ module Blacklight
       # @param [Blacklight::DocumentPresenter] presenter
       # @param [Integer] counter
       # @param [Hash] image_options options for the thumbnail presenter's image tag
-      def initialize(presenter: nil, document: nil, counter:, image_options: {})
+      def initialize(counter:, presenter: nil, document: nil, image_options: {})
         @presenter = presenter
         @document = presenter&.document || document
         @counter = counter
@@ -20,14 +20,6 @@ module Blacklight
         presenter.thumbnail.exists?
       end
 
-      def use_thumbnail_tag_behavior?
-        !presenter.thumbnail.instance_of?(Blacklight::ThumbnailPresenter)
-      end
-
-      def warn_about_deprecated_behavior
-        Deprecation.warn(Blacklight::Document::ThumbnailComponent, 'Detected as custom thumbnail presenter; make sure it has a #render method that returns just the thumbnail image tag')
-      end
-
       def presenter
         @presenter ||= helpers.document_presenter(@document)
       end

data/app/components/blacklight/document_component.html.erb

@@ -19,6 +19,10 @@
       <% metadata_sections.each do |section| %>
         <%= section %>
       <% end %>
+
+      <% partials.each do |partial| %>
+        <%= partial %>
+      <% end %>
     </div>
 
     <%= thumbnail %>

data/app/components/blacklight/document_component.rb

@@ -1,8 +1,29 @@
 # frozen_string_literal: true
 
+require 'view_component/version'
+
 module Blacklight
+  ##
+  # A component for rendering a single document
+  #
+  # @note when subclassing this component, if you override the initializer,
+  #    you must explicitly specify the counter variable `document_counter` even if you don't use it.
+  #    Otherwise view_component will not provide the count value when calling the component.
+  #
+  # @see https://viewcomponent.org/guide/collections.html#collection-counter
+  #
+  # @example
+  #  class MyDocumentComponent < Blacklight::DocumentComponent
+  #    def initialize(document_counter: nil, **kwargs)
+  #      super
+  #      ... custom code ...
+  #    end
+  #  end
   class DocumentComponent < Blacklight::Component
-    include Blacklight::ContentAreasShim
+    with_collection_parameter :document
+
+    # ViewComponent 3 changes iteration counters to begin at 0 rather than 1
+    COLLECTION_INDEX_OFFSET = ViewComponent::VERSION::MAJOR < 3 ? 0 : 1
 
     # Content appearing before the document
     renders_one :header
@@ -16,16 +37,17 @@ module Blacklight
 
     # The document title with some reasonable default behavior
     renders_one :title, (lambda do |*args, component: nil, **kwargs|
-      component ||= Blacklight::DocumentTitleComponent
+      component ||= @presenter&.view_config&.title_component || Blacklight::DocumentTitleComponent
 
-      component.new(*args, counter: @counter, document: @document, presenter: @presenter, as: @title_component, link_to_document: !@show, document_component: self, **kwargs)
+      component.new(*args, counter: @counter, document: @document, presenter: @presenter, as: @title_component, actions: !@show, link_to_document: !@show, document_component: self, **kwargs)
     end)
 
     renders_one :embed, (lambda do |static_content = nil, *args, component: nil, **kwargs|
       next static_content if static_content.present?
-      next unless component
 
-      Deprecation.warn(Blacklight::DocumentComponent, 'Pass the presenter to the DocumentComponent') if @presenter.nil?
+      component ||= @presenter.view_config&.embed_component
+
+      next unless component
 
       component.new(*args, document: @document, presenter: @presenter, document_counter: @document_counter, **kwargs)
     end)
@@ -34,9 +56,7 @@ module Blacklight
     renders_one :metadata, (lambda do |static_content = nil, *args, component: nil, fields: nil, **kwargs|
       next static_content if static_content.present?
 
-      Deprecation.warn(Blacklight::DocumentComponent, 'Pass the presenter to the DocumentComponent') if !fields && @presenter.nil?
-
-      component ||= Blacklight::DocumentMetadataComponent
+      component ||= @presenter&.view_config&.metadata_component || Blacklight::DocumentMetadataComponent
 
       component.new(*args, fields: fields || @presenter&.field_presenters || [], **kwargs)
     end)
@@ -48,7 +68,6 @@ module Blacklight
       next image_options_or_static_content if image_options_or_static_content.is_a? String
 
       component ||= @presenter&.view_config&.thumbnail_component || Blacklight::Document::ThumbnailComponent
-      Deprecation.warn(Blacklight::DocumentComponent, 'Pass the presenter to the DocumentComponent') if !component && @presenter.nil?
 
       component.new(*args, document: @document, presenter: @presenter, counter: @counter, image_options: image_options_or_static_content, **kwargs)
     end)
@@ -60,50 +79,36 @@ module Blacklight
     # Backwards compatibility
     renders_one :actions
 
-    with_collection_parameter :document
-
     # rubocop:disable Metrics/ParameterLists
-    # @param document [Blacklight::Document]
-    # @param presenter [Blacklight::DocumentPresenter]
+    # @param document [Blacklight::DocumentPresenter]
+    # @param presenter [Blacklight::DocumentPresenter] alias for document
+    # @param partials [Array, nil] view partial names that should be used to provide content for the `partials` slot
     # @param id [String] HTML id for the root element
     # @param classes [Array, String] additional HTML classes for the root element
     # @param component [Symbol, String] HTML tag type to use for the root element
     # @param title_component [Symbol, String] HTML tag type to use for the title element
     # @param counter [Number, nil] a pre-computed counter for the position of this document in a search result set
-    # @param document_counter [Number, nil] alternatively, the document's position in a collection and,
-    # @param counter_offset [Number] with `document_counter`, the offset of the start of that collection counter to the overall result set
+    # @param document_counter [Number, nil] provided by ViewComponent collection iteration
+    # @param counter_offset [Number] the offset of the start of the collection counter parameter for the component to the overall result set
     # @param show [Boolean] are we showing only a single document (vs a list of search results); used for backwards-compatibility
-    def initialize(document: nil, presenter: nil,
+    def initialize(document: nil, presenter: nil, partials: nil,
                    id: nil, classes: [], component: :article, title_component: nil,
-                   metadata_component: nil,
-                   embed_component: nil,
-                   thumbnail_component: nil,
                    counter: nil, document_counter: nil, counter_offset: 0,
-                   show: false)
-      if presenter.nil? && document.nil?
-        raise ArgumentError, 'missing keyword: :document or :presenter'
-      end
+                   show: false, **args)
+      Blacklight.deprecation.warn('the `presenter` argument to DocumentComponent#initialize is deprecated; pass the `presenter` in as document instead') if presenter
 
-      @document = document || presenter&.document
-      @presenter = presenter
+      @presenter = presenter || document || args[self.class.collection_parameter]
+      @document = @presenter.document
+      @view_partials = partials || []
 
       @component = component
       @title_component = title_component
       @id = id || ('document' if show)
       @classes = classes
 
-      Deprecation.warn(Blacklight::DocumentComponent, 'Passing embed_component is deprecated') if @embed_component.present?
-      @embed_component = embed_component
-
-      Deprecation.warn(Blacklight::DocumentComponent, 'Passing metadata_component is deprecated') if @metadata_component.present?
-      @metadata_component = metadata_component || Blacklight::DocumentMetadataComponent
-
-      Deprecation.warn(Blacklight::DocumentComponent, 'Passing thumbnail_component is deprecated') if @thumbnail_component.present?
-      @thumbnail_component = thumbnail_component || Blacklight::Document::ThumbnailComponent
-
-      @document_counter = document_counter
       @counter = counter
-      @counter ||= document_counter + 1 + counter_offset if document_counter.present?
+      @document_counter = document_counter || args.fetch(self.class.collection_counter_parameter, nil)
+      @counter ||= @document_counter + COLLECTION_INDEX_OFFSET + counter_offset if @document_counter.present?
 
       @show = show
     end
@@ -121,16 +126,23 @@ module Blacklight
 
     def before_render
       set_slot(:title, nil) unless title
-      set_slot(:thumbnail, nil, component: @thumbnail_component || presenter.view_config&.thumbnail_component) unless thumbnail || show?
-      set_slot(:metadata, nil, component: @metadata_component, fields: presenter.field_presenters) unless metadata
-      set_slot(:embed, nil, component: @embed_component || presenter.view_config&.embed_component) unless embed
+      set_slot(:thumbnail, nil) unless thumbnail || show?
+      set_slot(:metadata, nil, fields: presenter.field_presenters) unless metadata
+      set_slot(:embed, nil) unless embed
+      if view_partials.present?
+        view_partials.each do |view_partial|
+          with_partial(view_partial) do
+            helpers.render_document_partial @document, view_partial, component: self, document_counter: @counter
+          end
+        end
+      else
+        set_slot(:partials, nil)
+      end
     end
 
     private
 
-    def presenter
-      @presenter ||= helpers.document_presenter(@document)
-    end
+    attr_reader :document_counter, :presenter, :view_partials
 
     def show?
       @show

data/app/components/blacklight/document_metadata_component.html.erb

@@ -1,5 +1,7 @@
-<dl class="document-metadata dl-invert row">
+<% content = capture do %>
   <% fields.each do |field| -%>
     <%= field %>
   <% end -%>
-</dl>
+<% end %>
+
+<%= @tag.nil? ? content : tag.public_send(@tag, content, class: @classes, **@component_args) %>

data/app/components/blacklight/document_metadata_component.rb

@@ -3,21 +3,28 @@
 module Blacklight
   class DocumentMetadataComponent < Blacklight::Component
     renders_many :fields, (lambda do |component: nil, **kwargs|
-      (component || Blacklight::MetadataFieldComponent).new(**kwargs)
+      component.new(**kwargs)
     end)
     with_collection_parameter :fields
 
     # @param fields [Enumerable<Blacklight::FieldPresenter>] Document field presenters
-    def initialize(fields: [], show: false)
+    # rubocop:disable Metrics/ParameterLists
+    def initialize(fields: [], tag: 'dl', classes: %w[document-metadata dl-invert row], show: false, view_type: nil, field_layout: nil, **component_args)
       @fields = fields
+      @tag = tag
+      @classes = classes
       @show = show
+      @view_type = view_type
+      @field_layout = field_layout
+      @component_args = component_args
     end
+    # rubocop:enable Metrics/ParameterLists
 
     def before_render
       return unless fields
 
       @fields.each do |field|
-        field(component: field_component(field), field: field, show: @show)
+        with_field(component: field.component, field: field, show: @show, view_type: @view_type, layout: @field_layout)
       end
     end
 
@@ -25,8 +32,6 @@ module Blacklight
       fields.present?
     end
 
-    def field_component(field)
-      field&.component || Blacklight::MetadataFieldComponent
-    end
+    attr_reader :view_type
   end
 end

data/app/components/blacklight/document_title_component.rb

@@ -7,7 +7,7 @@ module Blacklight
     renders_many :actions
 
     # rubocop:disable Metrics/ParameterLists
-    def initialize(title = nil, document: nil, presenter: nil, as: :h3, counter: nil, classes: 'index_title document-title-heading col', link_to_document: true, document_component: nil)
+    def initialize(title = nil, document: nil, presenter: nil, as: :h3, counter: nil, classes: 'index_title document-title-heading col', link_to_document: true, document_component: nil, actions: true)
       raise ArgumentError, 'missing keyword: :document or :presenter' if presenter.nil? && document.nil?
 
       @title = title
@@ -18,6 +18,7 @@ module Blacklight
       @classes = classes
       @link_to_document = link_to_document
       @document_component = document_component
+      @actions = actions
     end
     # rubocop:enable Metrics/ParameterLists
 
@@ -32,6 +33,8 @@ module Blacklight
 
     # Content for the document actions area
     def actions
+      return [] unless @actions
+
       if block_given?
         @has_actions_slot = true
         return super

data/app/components/blacklight/facet_component.rb

@@ -30,7 +30,7 @@ module Blacklight
         raise ArgumentError, 'You must provide one of display_facet or field_config' unless @field_config
       end
 
-      @component = component || (@field_config.component == true ? Blacklight::FacetFieldListComponent : @field_config.component)
+      @component = component || @field_config.component
       @component_args = component_args
     end
     # rubocop:enable Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity, Metrics/ParameterLists

data/app/components/blacklight/facet_field_checkboxes_component.html.erb

@@ -1,9 +1,9 @@
 <%= render(@layout.new(facet_field: @facet_field)) do |component| %>
-  <% component.label do %>
+  <% component.with_label do %>
     <%= @facet_field.label %>
   <% end %>
 
-  <% component.body do %>
+  <% component.with_body do %>
     <ul class="facet-values list-unstyled blacklight-facet-checkboxes">
       <% presenters.each_with_index do |presenter, idx| -%>
         <li>
@@ -11,7 +11,7 @@
             <%= check_box_tag "f_inclusive[#{@facet_field.key}][]", presenter.value, presenter.selected?, id: "f_inclusive_#{@facet_field.key}_#{idx}"%>
           </span>
 
-          <span class="label-and-count">
+          <span>
             <%= label_tag "f_inclusive_#{@facet_field.key}_#{idx}" do %>
               <span class="facet-label"><%= presenter.label %></span>
               <span class="facet-count"><%= t('blacklight.search.facets.count', number: number_with_delimiter(presenter.hits)) %></span>