blacklight 7.33.0 → 8.0.0

data/.rubocop_todo.yml

@@ -1,164 +1,36 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-09-24 02:12:21 UTC using RuboCop version 0.91.1.
+# on 2022-06-27 19:52:51 UTC using RuboCop version 1.31.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 4
-# Cop supports --auto-correct.
-Capybara/CurrentPathExpectation:
-  Exclude:
-    - 'spec/features/alternate_controller_spec.rb'
-
-# Offense count: 20
-Capybara/VisibilityMatcher:
-  Exclude:
-    - 'spec/features/facets_spec.rb'
-    - 'spec/features/search_filters_spec.rb'
-    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
-    - 'spec/helpers/blacklight_helper_spec.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentOneStep, IndentationWidth.
-# SupportedStyles: case, end
-Layout/CaseIndentation:
-  Exclude:
-    - 'app/helpers/blacklight/catalog_helper_behavior.rb'
-    - 'app/presenters/blacklight/index_presenter.rb'
-    - 'lib/blacklight/configuration/fields.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/ClosingParenthesisIndentation:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-
-# Offense count: 111
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterMagicComment:
-  Enabled: false
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAliasSyntax, AllowedMethods.
-# AllowedMethods: alias_method, public, protected, private
-Layout/EmptyLinesAroundAttributeAccessor:
-  Exclude:
-    - 'app/presenters/blacklight/field_presenter.rb'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment, AllowBeforeTrailingComments, ForceEqualSignAlignment.
-Layout/ExtraSpacing:
-  Exclude:
-    - 'app/models/concerns/blacklight/document/dublin_core.rb'
-    - 'app/models/record_mailer.rb'
-    - 'app/views/catalog/index.atom.builder'
-    - 'config/routes.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: special_inside_parentheses, consistent, align_braces
-Layout/FirstHashElementIndentation:
-  Exclude:
-    - 'lib/blacklight/configuration.rb'
-
-# Offense count: 6
-# Cop supports --auto-correct.
-# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
-Layout/LeadingCommentSpace:
-  Exclude:
-    - 'app/models/blacklight/facet_paginator.rb'
-    - 'app/models/concerns/blacklight/configurable.rb'
-    - 'app/models/concerns/blacklight/document/export.rb'
-    - 'app/views/catalog/_document.atom.builder'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Layout/MultilineBlockLayout:
-  Exclude:
-    - 'lib/generators/blacklight/test_support_generator.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineMethodCallBraceLayout:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented, indented_relative_to_receiver
-Layout/MultilineMethodCallIndentation:
-  Exclude:
-    - 'lib/blacklight/search_builder.rb'
-
-# Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: aligned, indented
-Layout/MultilineOperationIndentation:
-  Exclude:
-    - 'app/helpers/blacklight/search_history_constraints_helper_behavior.rb'
-    - 'lib/blacklight/configuration/context.rb'
-    - 'lib/blacklight/search_state.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Layout/SpaceAfterComma:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-    - 'app/views/catalog/opensearch.xml.builder'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowForAlignment.
-Layout/SpaceBeforeFirstArg:
-  Exclude:
-    - 'app/views/catalog/index.atom.builder'
-
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceInsideParens:
-  Exclude:
-    - 'app/views/catalog/_document.rss.builder'
-    - 'app/views/catalog/index.atom.builder'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
+# Offense count: 5
+# Configuration parameters: AutoCorrect.
+Layout/LineContinuationLeadingSpace:
   Exclude:
-    - 'lib/blacklight/configuration.rb'
+    - 'lib/generators/blacklight/controller_generator.rb'
+    - 'lib/generators/blacklight/user_generator.rb'
 
 # Offense count: 1
+# Configuration parameters: IgnoredMethods.
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 8
-# Cop supports --auto-correct.
+# Offense count: 5
+# This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousOperator:
   Exclude:
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/models/blacklight/facet_paginator_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 55
-# Cop supports --auto-correct.
+# Offense count: 44
+# This cop supports safe autocorrection (--autocorrect).
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
@@ -169,19 +41,52 @@ Lint/AmbiguousRegexpLiteral:
     - 'spec/views/catalog/_document.html.erb_spec.rb'
     - 'spec/views/catalog/_search_header.erb_spec.rb'
     - 'spec/views/catalog/_sort_and_per_page.html.erb_spec.rb'
-    - 'spec/views/catalog/_thumbnail.html.erb_spec.rb'
     - 'spec/views/catalog/index.html.erb_spec.rb'
     - 'spec/views/catalog/show.html.erb_spec.rb'
 
+# Offense count: 1
+Lint/BinaryOperatorWithIdenticalOperands:
+  Exclude:
+    - 'spec/models/blacklight/document/active_model_shim_spec.rb'
+
+# Offense count: 14
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
+  Exclude:
+    - 'spec/controllers/bookmarks_controller_spec.rb'
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/models/blacklight/configurable_spec.rb'
+    - 'spec/models/blacklight/document/active_model_shim_spec.rb'
+    - 'spec/models/blacklight/document_spec.rb'
+    - 'spec/models/blacklight/solr/document_spec.rb'
+    - 'spec/presenters/blacklight/show_presenter_spec.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/bookmarks.rb'
+    - 'lib/blacklight/solr/search_builder_behavior.rb'
+
+# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/EmptyFile:
+  Exclude:
+    - 'spec/components/blacklight/document_metadata_component_spec.rb'
+
+# Offense count: 38
+Lint/MissingSuper:
+  Enabled: false
+
 # Offense count: 29
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Lint/ParenthesesAsGroupedExpression:
   Exclude:
     - 'spec/features/did_you_mean_spec.rb'
     - 'spec/features/search_filters_spec.rb'
     - 'spec/features/search_pagination_spec.rb'
     - 'spec/features/search_spec.rb'
-    - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/solr/repository_spec.rb'
 
 # Offense count: 2
@@ -189,63 +94,57 @@ Lint/ShadowingOuterLocalVariable:
   Exclude:
     - 'spec/models/blacklight/configuration_spec.rb'
 
-# Offense count: 57
-# Configuration parameters: IgnoredMethods.
+# Offense count: 74
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 59
+  Max: 46
 
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
-# ExcludedMethods: refine
+# Offense count: 1
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods, inherit_mode.
+# IgnoredMethods: refine
 Metrics/BlockLength:
-  Max: 30
+  Max: 26
 
 # Offense count: 1
 # Configuration parameters: CountBlocks.
 Metrics/BlockNesting:
   Max: 4
 
-# Offense count: 2
-# Configuration parameters: CountComments, CountAsOne.
-Metrics/ClassLength:
-  Max: 169
-
-# Offense count: 26
+# Offense count: 43
 # Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
   Max: 14
 
-# Offense count: 61
-# Configuration parameters: CountComments, CountAsOne, ExcludedMethods.
+# Offense count: 69
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
-  Max: 30
+  Max: 29
 
-# Offense count: 8
+# Offense count: 3
 # Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
-  Max: 213
+  Max: 126
 
-# Offense count: 3
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 8
+# Configuration parameters: CountKeywordArgs, MaxOptionalParameters.
 Metrics/ParameterLists:
   Max: 6
 
-# Offense count: 22
+# Offense count: 36
 # Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 16
+  Max: 14
 
-# Offense count: 4
+# Offense count: 3
 # Configuration parameters: EnforcedStyleForLeadingUnderscores.
 # SupportedStylesForLeadingUnderscores: disallowed, required, optional
 Naming/MemoizedInstanceVariableName:
   Exclude:
-    - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
     - 'app/models/concerns/blacklight/document/semantic_fields.rb'
     - 'lib/blacklight/solr/response.rb'
 
-# Offense count: 13
+# Offense count: 9
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
 # AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
 Naming/MethodParameterName:
@@ -253,80 +152,89 @@ Naming/MethodParameterName:
     - 'app/models/concerns/blacklight/document.rb'
     - 'app/presenters/blacklight/rendering/link_to_facet.rb'
     - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
-    - 'lib/blacklight/search_state.rb'
     - 'lib/blacklight/solr/document.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
-    - 'spec/features/search_context_spec.rb'
-    - 'spec/features/search_results_spec.rb'
 
-# Offense count: 14
-# Configuration parameters: EnforcedStyle.
+# Offense count: 9
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
 Naming/VariableNumber:
   Exclude:
-    - 'spec/views/catalog/_index.html.erb_spec.rb'
-    - 'spec/views/catalog/_show.html.erb_spec.rb'
+    - 'spec/lib/blacklight/search_state_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
 
-# Offense count: 9
+# Offense count: 7
 RSpec/BeforeAfterAll:
   Exclude:
-    - 'spec/spec_helper.rb'
-    - 'spec/rails_helper.rb'
-    - 'spec/support/**/*.rb'
-    - 'spec/controllers/blacklight/search_fields_spec.rb'
     - 'spec/controllers/search_history_controller_spec.rb'
-    - 'spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb'
     - 'spec/models/blacklight/configurable_spec.rb'
     - 'spec/models/blacklight/document/dublin_core_spec.rb'
     - 'spec/models/blacklight/document/email_spec.rb'
     - 'spec/models/blacklight/document/sms_spec.rb'
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 81
+# Offense count: 4
+# This cop supports safe autocorrection (--autocorrect).
+RSpec/Capybara/CurrentPathExpectation:
+  Exclude:
+    - 'spec/features/alternate_controller_spec.rb'
+
+# Offense count: 13
+RSpec/Capybara/VisibilityMatcher:
+  Exclude:
+    - 'spec/features/facets_spec.rb'
+    - 'spec/features/search_filters_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+
+# Offense count: 98
 # Configuration parameters: Prefixes.
 # Prefixes: when, with, without
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 42
-RSpec/DescribeClass:
-  Enabled: false
-
-# Offense count: 2
-# Configuration parameters: CustomIncludeMethods.
+# Offense count: 1
 RSpec/EmptyExampleGroup:
   Exclude:
-    - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
-# Offense count: 134
-# Configuration parameters: Max.
+# Offense count: 128
+# Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
-  Enabled: false
+  Max: 33
 
-# Offense count: 15
+# Offense count: 8
 RSpec/ExpectInHook:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
-    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
-    - 'spec/helpers/catalog_helper_spec.rb'
 
 # Offense count: 5
-# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Configuration parameters: Include, CustomTransform, IgnoreMethods, SpecSuffixOnly.
+# Include: **/*_spec*rb*, **/spec/**/*
 RSpec/FilePath:
   Exclude:
     - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
-    - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
+    - 'spec/features/sitelinks_search_box.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/presenters/pipeline_spec.rb'
     - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 191
+# Offense count: 128
 # Configuration parameters: AssignmentOnly.
 RSpec/InstanceVariable:
-  Enabled: false
+  Exclude:
+    - 'spec/controllers/bookmarks_controller_spec.rb'
+    - 'spec/controllers/search_history_controller_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/lib/blacklight/open_struct_with_hash_access_spec.rb'
+    - 'spec/lib/tasks/blacklight_task_spec.rb'
+    - 'spec/models/blacklight/configuration_spec.rb'
+    - 'spec/models/blacklight/document/dublin_core_spec.rb'
+    - 'spec/models/blacklight/solr/document_spec.rb'
+    - 'spec/models/record_mailer_spec.rb'
+    - 'spec/models/search_spec.rb'
+    - 'spec/services/blacklight/search_service_spec.rb'
+    - 'spec/views/catalog/index.atom.builder_spec.rb'
 
 # Offense count: 4
 RSpec/IteratedExpectation:
@@ -335,10 +243,9 @@ RSpec/IteratedExpectation:
     - 'spec/models/blacklight/solr/response/group_spec.rb'
     - 'spec/models/blacklight/solr/response_spec.rb'
 
-# Offense count: 17
+# Offense count: 16
 RSpec/LeakyConstantDeclaration:
   Exclude:
-    - 'spec/controllers/blacklight/search_fields_spec.rb'
     - 'spec/controllers/bookmarks_controller_spec.rb'
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/models/blacklight/configurable_spec.rb'
@@ -347,55 +254,50 @@ RSpec/LeakyConstantDeclaration:
     - 'spec/models/blacklight/solr/document_spec.rb'
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
 
-# Offense count: 8
+# Offense count: 9
 RSpec/MessageChain:
   Exclude:
     - 'spec/controllers/bookmarks_controller_spec.rb'
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 61
+# Offense count: 30
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
-    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
     - 'spec/helpers/catalog_helper_spec.rb'
-    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
     - 'spec/models/blacklight/suggest_search_spec.rb'
     - 'spec/presenters/blacklight/field_presenter_spec.rb'
     - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 363
+# Offense count: 364
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 160
+# Offense count: 258
 # Configuration parameters: AllowSubject.
 RSpec/MultipleMemoizedHelpers:
   Max: 14
 
-# Offense count: 337
+# Offense count: 388
 # Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Enabled: false
 
-# Offense count: 40
+# Offense count: 55
 RSpec/NestedGroups:
   Max: 5
 
-# Offense count: 11
+# Offense count: 6
 RSpec/RepeatedDescription:
   Exclude:
     - 'spec/features/search_results_spec.rb'
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
     - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
@@ -404,80 +306,98 @@ RSpec/RepeatedExample:
   Exclude:
     - 'spec/models/blacklight/solr/document_spec.rb'
 
-# Offense count: 4
+# Offense count: 2
 RSpec/RepeatedExampleGroupDescription:
   Exclude:
-    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
 RSpec/ScatteredLet:
   Exclude:
-    - 'spec/helpers/catalog_helper_spec.rb'
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 13
+# Offense count: 22
+RSpec/StubbedMock:
+  Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/models/blacklight/suggest_search_spec.rb'
+    - 'spec/presenters/blacklight/field_presenter_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
+
+# Offense count: 1
+RSpec/SubjectDeclaration:
+  Exclude:
+    - 'spec/models/blacklight/document/cache_key_spec.rb'
+
+# Offense count: 15
 RSpec/SubjectStub:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/models/blacklight/document/cache_key_spec.rb'
     - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/presenters/blacklight/document_presenter_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 121
+# Offense count: 77
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
 
-# Offense count: 1
-RSpec/VoidExpect:
-  Exclude:
-    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
-
-# Offense count: 8
-# Cop supports --auto-correct.
-Rails/ContentTag:
-  Exclude:
-    - 'app/components/blacklight/document_component.rb'
-    - 'app/components/blacklight/facet_item_pivot_component.rb'
-
 # Offense count: 4
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, AllowToTime.
 # SupportedStyles: strict, flexible
 Rails/Date:
   Exclude:
     - 'spec/models/search_spec.rb'
 
-# Offense count: 31
+# Offense count: 1
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: slashes, arguments
+Rails/FilePath:
+  Exclude:
+    - 'lib/railties/blacklight.rake'
+
+# Offense count: 20
 # Configuration parameters: Include.
 # Include: app/helpers/**/*.rb
 Rails/HelperInstanceVariable:
   Exclude:
     - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
+    - 'app/helpers/blacklight/document_helper_behavior.rb'
     - 'app/helpers/blacklight/component_helper_behavior.rb'
-    - 'app/helpers/blacklight/facets_helper_behavior.rb'
+    - 'app/helpers/blacklight/layout_helper_behavior.rb'
     - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
 
-# Offense count: 11
+# Offense count: 2
+# Configuration parameters: Include.
+# Include: spec/**/*.rb, test/**/*.rb
+Rails/I18nLocaleAssignment:
+  Exclude:
+    - 'spec/helpers/blacklight_helper_spec.rb'
+
+# Offense count: 10
 Rails/OutputSafety:
   Exclude:
+    - 'app/components/blacklight/search_context/server_item_pagination_component.rb'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/helpers/blacklight/configuration_helper_behavior.rb'
-    - 'app/helpers/blacklight/icon_helper_behavior.rb'
-    - 'app/helpers/blacklight/url_helper_behavior.rb'
     - 'app/presenters/blacklight/rendering/join.rb'
 
-# Offense count: 13
+# Offense count: 14
 Security/Eval:
   Exclude:
     - 'spec/models/blacklight/solr/response_spec.rb'
 
 # Offense count: 9
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: prefer_alias, prefer_alias_method
 Style/Alias:
@@ -490,7 +410,7 @@ Style/Alias:
     - 'lib/blacklight/solr/response/group_response.rb'
 
 # Offense count: 3
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
 # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
@@ -501,33 +421,41 @@ Style/BlockDelimiters:
     - 'app/views/catalog/index.rss.builder'
     - 'app/views/catalog/opensearch.xml.builder'
 
-# Offense count: 51
-# Cop supports --auto-correct.
+# Offense count: 52
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
 # Offense count: 6
+# This cop supports unsafe autocorrection (--autocorrect-all).
 Style/CommentedKeyword:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
 # SupportedStyles: assign_to_condition, assign_inside_condition
 Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
+# Offense count: 2
+Style/DocumentDynamicEvalDefinition:
+  Exclude:
+    - 'app/builders/blacklight/action_builder.rb'
+    - 'lib/blacklight/configuration/fields.rb'
+
 # Offense count: 105
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Enabled: false
 
 # Offense count: 10
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 Style/ExpandPathArguments:
   Exclude:
     - 'Gemfile'
@@ -542,14 +470,14 @@ Style/ExpandPathArguments:
     - 'lib/generators/blacklight/user_generator.rb'
 
 # Offense count: 16
-# Configuration parameters: EnforcedStyle.
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, IgnoredMethods.
 # SupportedStyles: annotated, template, unannotated
 Style/FormatStringToken:
-  Exclude:
-    - 'app/helpers/blacklight/render_partials_helper_behavior.rb'
+  EnforcedStyle: template
 
-# Offense count: 8
-# Configuration parameters: MinBodyLength.
+# Offense count: 6
+# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
   Exclude:
     - 'app/controllers/concerns/blacklight/bookmarks.rb'
@@ -558,13 +486,13 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 39
-# Cop supports --auto-correct.
+# Offense count: 30
+# This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Enabled: false
 
-# Offense count: 5
-# Cop supports --auto-correct.
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
 Style/MultilineIfModifier:
   Exclude:
     - 'app/views/catalog/index.atom.builder'
@@ -572,12 +500,14 @@ Style/MultilineIfModifier:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
 # Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMethodComparison.
 Style/MultipleComparison:
   Exclude:
     - 'lib/blacklight/configuration/context.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
@@ -585,12 +515,11 @@ Style/MutableConstant:
     - 'lib/blacklight/solr/request.rb'
 
 # Offense count: 9
-# Cop supports --auto-correct.
+# This cop supports unsafe autocorrection (--autocorrect-all).
 # Configuration parameters: EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Exclude:
-    - 'spec/**/*'
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'app/services/blacklight/search_service.rb'
     - 'lib/blacklight/search_builder.rb'
@@ -599,15 +528,26 @@ Style/NumericPredicate:
     - 'lib/blacklight/solr/search_builder_behavior.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 3
-# Cop supports --auto-correct.
+# Offense count: 15
+Style/OpenStructUse:
+  Exclude:
+    - 'lib/blacklight/configuration.rb'
+    - 'lib/blacklight/open_struct_with_hash_access.rb'
+    - 'lib/blacklight/solr/response/facets.rb'
+    - 'spec/components/blacklight/facet_item_pivot_component_spec.rb'
+    - 'spec/lib/blacklight/search_state/filter_field_spec.rb'
+    - 'spec/models/blacklight/configuration_spec.rb'
+    - 'spec/models/blacklight/solr/response_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
   Exclude:
     - 'app/views/catalog/_document.atom.builder'
 
 # Offense count: 3
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
@@ -615,7 +555,7 @@ Style/PercentLiteralDelimiters:
     - 'lib/blacklight/solr/request.rb'
 
 # Offense count: 7
-# Cop supports --auto-correct.
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: implicit, explicit
 Style/RescueStandardError:
@@ -625,9 +565,9 @@ Style/RescueStandardError:
     - 'lib/blacklight/configuration/fields.rb'
     - 'lib/railties/blacklight.rake'
 
-# Offense count: 12
-# Cop supports --auto-correct.
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods.
+# Offense count: 11
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
 # AllowedMethods: present?, blank?, presence, try, try!
 Style/SafeNavigation:
   Exclude:
@@ -637,19 +577,25 @@ Style/SafeNavigation:
     - 'lib/blacklight.rb'
     - 'lib/blacklight/configuration/facet_field.rb'
     - 'lib/blacklight/configuration/search_field.rb'
-    - 'lib/blacklight/search_state.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowAsExpressionSeparator.
 Style/Semicolon:
   Exclude:
     - 'spec/models/blacklight/solr/repository_spec.rb'
     - 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
 
-# Offense count: 31
-# Cop supports --auto-correct.
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowModifier.
+Style/SoleNestedConditional:
+  Exclude:
+    - 'app/controllers/concerns/blacklight/controller.rb'
+
+# Offense count: 34
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets
 Style/SymbolArray: