blacklight 6.2.0 → 6.3.0

data/spec/helpers/facets_helper_spec.rb

@@ -11,7 +11,7 @@ describe FacetsHelper do
   end
 
   describe "has_facet_values?" do
-    it "should be true if there are any facets to display" do
+    it "is true if there are any facets to display" do
 
       a = double(:items => [1,2], :name => 'a')
       b = double(:items => ['b','c'], :name => 'b')
@@ -21,7 +21,7 @@ describe FacetsHelper do
       expect(helper.has_facet_values?(fields)).to be true
     end
 
-    it "should be false if all facets are empty" do
+    it "is false if all facets are empty" do
 
       empty = double(:items => [])
 
@@ -29,7 +29,7 @@ describe FacetsHelper do
       expect(helper.has_facet_values?(fields)).to be false
     end
 
-    it "should be false if no facets are displayable" do
+    it "is false if no facets are displayable" do
       @config = Blacklight::Configuration.new do |config|
         config.add_facet_field 'basic_field', :if => false
       end
@@ -57,34 +57,34 @@ describe FacetsHelper do
       allow(helper).to receive_messages(:blacklight_config => @config)
     end
 
-    it "should render facets with items" do
+    it "renders facets with items" do
       a = double(:items => [1,2], :name=>'basic_field')
       expect(helper.should_render_facet?(a)).to be true
     end
-    it "should not render facets without items" do
+    it "does not render facets without items" do
       empty = double(:items => [], :name=>'basic_field')
       expect(helper.should_render_facet?(empty)).to be false
     end
 
-    it "should not render facets where show is set to false" do
+    it "does not render facets where show is set to false" do
       a = double(:items => [1,2], :name=>'no_show')
       expect(helper.should_render_facet?(a)).to be false
     end
 
-    it "should call a helper to determine if it should render a field" do
+    it "calls a helper to determine if it should render a field" do
       allow(controller).to receive_messages(:my_custom_check => true)
       a = double(:items => [1,2], :name=>'helper_show')
       expect(helper.should_render_facet?(a)).to be true
     end
 
-    it "should call a helper to determine if it should render a field" do
+    it "calls a helper to determine if it should render a field" do
       a = double(:items => [1,2], :name=>'helper_with_an_arg_show')
       allow(controller).to receive(:my_custom_check_with_an_arg).with(@config.facet_fields['helper_with_an_arg_show'], a).and_return(true)
       expect(helper.should_render_facet?(a)).to be true
     end
 
 
-    it "should evaluate a Proc to determine if it should render a field" do
+    it "evaluates a Proc to determine if it should render a field" do
       a = double(:items => [1,2], :name=>'lambda_show')
       expect(helper.should_render_facet?(a)).to be true
 
@@ -103,15 +103,15 @@ describe FacetsHelper do
       allow(helper).to receive_messages(blacklight_config: @config)
     end
 
-    it "should be collapsed by default" do
+    it "is collapsed by default" do
       expect(helper.should_collapse_facet?(@config.facet_fields['basic_field'])).to be true
     end
 
-    it "should not be collapsed if the configuration says so" do
+    it "does not be collapsed if the configuration says so" do
       expect(helper.should_collapse_facet?(@config.facet_fields['no_collapse'])).to be false
     end
 
-    it "should not be collapsed if it is in the params" do
+    it "does not be collapsed if it is in the params" do
       params[:f] = ActiveSupport::HashWithIndifferentAccess.new(basic_field: [1], no_collapse: [2])
       expect(helper.should_collapse_facet?(@config.facet_fields['basic_field'])).to be false
       expect(helper.should_collapse_facet?(@config.facet_fields['no_collapse'])).to be false
@@ -120,7 +120,7 @@ describe FacetsHelper do
   end
 
   describe "facet_by_field_name" do
-    it "should retrieve the facet from the response given a string" do
+    it "retrieves the facet from the response given a string" do
       facet_config = double(:query => nil, field: 'a', key: 'a')
       facet_field = double()
       allow(helper).to receive(:facet_configuration_for_field).with(anything()).and_return(facet_config)
@@ -134,7 +134,7 @@ describe FacetsHelper do
 
 
   describe "render_facet_partials" do
-    it "should try to render all provided facets " do
+    it "tries to render all provided facets" do
       a = double(:items => [1,2])
       b = double(:items => ['b','c'])
       empty = double(:items => [])
@@ -148,7 +148,7 @@ describe FacetsHelper do
       helper.render_facet_partials fields
     end
 
-    it "should default to the configured facets" do
+    it "defaults to the configured facets" do
       a = double(:items => [1,2])
       b = double(:items => ['b','c'])
       allow(helper).to receive(:facet_field_names) { [a,b] }
@@ -175,7 +175,7 @@ describe FacetsHelper do
       @response = double()
     end
 
-    it "should set basic local variables" do
+    it "sets basic local variables" do
       @mock_facet = double(:name => 'basic_field', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:partial => 'facet_limit', 
                                                          :locals => { 
@@ -187,37 +187,37 @@ describe FacetsHelper do
       helper.render_facet_limit(@mock_facet)
     end
 
-    it "should render a facet _not_ declared in the configuration" do
+    it "renders a facet _not_ declared in the configuration" do
       @mock_facet = double(:name => 'asdf', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:partial => 'facet_limit'))
       helper.render_facet_limit(@mock_facet)
     end
 
-    it "should get the partial name from the configuration" do
+    it "gets the partial name from the configuration" do
       @mock_facet = double(:name => 'my_facet_field_with_custom_partial', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:partial => 'custom_facet_partial'))
       helper.render_facet_limit(@mock_facet)
     end 
 
-    it "should use a partial layout for rendering the facet frame" do
+    it "uses a partial layout for rendering the facet frame" do
       @mock_facet = double(:name => 'my_facet_field_with_custom_partial', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:layout => 'facet_layout'))
       helper.render_facet_limit(@mock_facet)
     end
 
-    it "should allow the caller to opt-out of facet layouts" do
+    it "allows the caller to opt-out of facet layouts" do
       @mock_facet = double(:name => 'my_facet_field_with_custom_partial', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:layout => nil))
       helper.render_facet_limit(@mock_facet, :layout => nil)
     end
 
-    it "should render the facet_pivot partial for pivot facets" do
+    it "renders the facet_pivot partial for pivot facets" do
       @mock_facet = double(:name => 'pivot_facet_field', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:partial => 'facet_pivot'))
       helper.render_facet_limit(@mock_facet)
     end 
 
-    it "should let you override the rendered partial for pivot facets" do
+    it "lets you override the rendered partial for pivot facets" do
       @mock_facet = double(:name => 'my_pivot_facet_field_with_custom_partial', :items => [1,2,3])
       allow(helper).to receive(:render).with(hash_including(:partial => 'custom_facet_partial'))
       helper.render_facet_limit(@mock_facet)
@@ -234,7 +234,7 @@ describe FacetsHelper do
         search_catalog_path *args
       end
     end
-    it "should draw a list of elements" do
+    it "draws a list of elements" do
       expect(subject).to have_selector 'li', count: 2
       expect(subject).to have_selector 'li:first-child a.facet_select', text: 'Book' 
       expect(subject).to have_selector 'li:nth-child(2) a.facet_select', text: 'Musical Score' 
@@ -245,7 +245,7 @@ describe FacetsHelper do
       
       before { allow(helper).to receive(:render_facet_item).and_return("<a class=\"facet_select\">Book</a>".html_safe, nil) }
 
-      it "should draw a list of elements" do
+      it "draws a list of elements" do
         expect(subject).to have_selector 'li', count: 1
         expect(subject).to have_selector 'li:first-child a.facet_select', text: 'Book' 
       end
@@ -254,7 +254,7 @@ describe FacetsHelper do
   end
 
   describe "facet_field_in_params?" do
-    it "should check if the facet field is selected in the user params" do
+    it "checks if the facet field is selected in the user params" do
       allow(helper).to receive_messages(:params => { :f => { "some-field" => ["x"]}})
       expect(helper.facet_field_in_params?("some-field")).to be_truthy
       expect(helper.facet_field_in_params?("other-field")).to_not be true
@@ -262,12 +262,12 @@ describe FacetsHelper do
   end
 
   describe "facet_params" do
-    it "should extract the facet parameters for a field" do
+    it "extracts the facet parameters for a field" do
       allow(helper).to receive_messages(params: { f: { "some-field" => ["x"] }})
       expect(helper.facet_params("some-field")).to match_array ["x"]
     end
 
-    it "should use the blacklight key to extract the right fields" do
+    it "uses the blacklight key to extract the right fields" do
       blacklight_config.add_facet_field "some-key", field: "some-field"
       allow(helper).to receive_messages(params: { f: { "some-key" => ["x"] }})
       expect(helper.facet_params("some-key")).to match_array ["x"]
@@ -276,25 +276,25 @@ describe FacetsHelper do
   end
 
   describe "facet_field_in_params?" do
-    it "should check if any value is selected for a given facet" do
+    it "checks if any value is selected for a given facet" do
       allow(helper).to receive_messages(facet_params: ["x"])
       expect(helper.facet_field_in_params?("some-facet")).to eq true
     end
 
-    it "should be false if no value for facet is selected" do
+    it "is false if no value for facet is selected" do
       allow(helper).to receive_messages(facet_params: nil)
       expect(helper.facet_field_in_params?("some-facet")).to eq false
     end
   end
 
   describe "facet_in_params?" do
-    it "should check if a particular value is set in the facet params" do
+    it "checks if a particular value is set in the facet params" do
       allow(helper).to receive_messages(facet_params: ["x"])
       expect(helper.facet_in_params?("some-facet", "x")).to eq true
       expect(helper.facet_in_params?("some-facet", "y")).to eq false
     end
 
-    it "should be false if no value for facet is selected" do
+    it "is false if no value for facet is selected" do
       allow(helper).to receive_messages(facet_params: nil)
       expect(helper.facet_in_params?("some-facet", "x")).to eq false
     end
@@ -322,7 +322,7 @@ describe FacetsHelper do
 
     describe "when :url_method is set" do
       let(:expected_html) { "<span class=\"facet-label\"><a class=\"facet_select\" href=\"/blabla\">Z</a></span><span class=\"facet-count\">10</span>" }
-      it "should use that method" do
+      it "uses that method" do
         allow(helper).to receive(:facet_configuration_for_field).with('simple_field').and_return(double(:query => nil, :date => nil, :helper_method => nil, :single => false, :url_method => :test_method))
         allow(helper).to receive(:test_method).with('simple_field', item).and_return('/blabla')
         result = helper.render_facet_value('simple_field', item)
@@ -332,7 +332,7 @@ describe FacetsHelper do
 
     describe "when :suppress_link is set" do
       let(:expected_html) { "<span class=\"facet-label\">Z</span><span class=\"facet-count\">10</span>" }
-      it "should suppress the link" do
+      it "suppresses the link" do
         result = helper.render_facet_value('simple_field', item, :suppress_link => true)
         expect(result).to be_equivalent_to(expected_html).respecting_element_order
       end
@@ -340,12 +340,12 @@ describe FacetsHelper do
   end
  
   describe "#facet_display_value" do
-    it "should just be the facet value for an ordinary facet" do
+    it "justs be the facet value for an ordinary facet" do
       allow(helper).to receive(:facet_configuration_for_field).with('simple_field').and_return(double(:query => nil, :date => nil, :helper_method => nil, :url_method => nil))
       expect(helper.facet_display_value('simple_field', 'asdf')).to eq 'asdf'
     end
 
-    it "should allow you to pass in a :helper_method argument to the configuration" do
+    it "allows you to pass in a :helper_method argument to the configuration" do
       allow(helper).to receive(:facet_configuration_for_field).with('helper_field').and_return(double(:query => nil, :date => nil, :url_method => nil, :helper_method => :my_facet_value_renderer))
     
       allow(helper).to receive(:my_facet_value_renderer).with('qwerty').and_return('abc')
@@ -353,24 +353,24 @@ describe FacetsHelper do
       expect(helper.facet_display_value('helper_field', 'qwerty')).to eq 'abc'
     end
 
-    it "should extract the configuration label for a query facet" do
+    it "extracts the configuration label for a query facet" do
       allow(helper).to receive(:facet_configuration_for_field).with('query_facet').and_return(double(:query => { 'query_key' => { :label => 'XYZ'}}, :date => nil, :helper_method => nil, :url_method => nil))
       expect(helper.facet_display_value('query_facet', 'query_key')).to eq 'XYZ'
     end
 
-    it "should localize the label for date-type facets" do
+    it "localizes the label for date-type facets" do
       allow(helper).to receive(:facet_configuration_for_field).with('date_facet').and_return(double('date' => true, :query => nil, :helper_method => nil, :url_method => nil))
       expect(helper.facet_display_value('date_facet', '2012-01-01')).to eq 'Sun, 01 Jan 2012 00:00:00 +0000'
     end
 
-    it "should localize the label for date-type facets with the supplied localization options" do
+    it "localizes the label for date-type facets with the supplied localization options" do
       allow(helper).to receive(:facet_configuration_for_field).with('date_facet').and_return(double('date' => { :format => :short }, :query => nil, :helper_method => nil, :url_method => nil))
       expect(helper.facet_display_value('date_facet', '2012-01-01')).to eq '01 Jan 00:00'
     end
   end
 
   describe "#facet_field_id" do
-    it "should be the parameterized version of the facet field" do
+    it "is the parameterized version of the facet field" do
       expect(helper.facet_field_id double(key: 'some field')).to eq "facet-some-field"
     end
   end

data/spec/helpers/hash_as_hidden_fields_spec.rb

@@ -7,7 +7,7 @@ describe HashAsHiddenFieldsHelper do
     @hash = {:q => "query", :search_field => "search_field", :per_page=>10, :page=>5, :extra_arbitrary_key=>"arbitrary_value", :f=> {:field1 => ["a", "b"], :field2=> ["z"]}}
   end
 
-  it "should convert a hash with nested complex data to Rails-style hidden form fields" do
+  it "converts a hash with nested complex data to Rails-style hidden form fields" do
 
     generated = render_hash_as_hidden_fields(@hash)
 

data/spec/helpers/render_constraints_helper_spec.rb

@@ -58,7 +58,7 @@ describe RenderConstraintsHelper do
     end
     subject { helper.render_constraints_filters(params) }
 
-    it "should render nothing for empty facet limit param" do
+    it "renders nothing for empty facet limit param" do
       expect(subject).to be_blank
     end
   end

data/spec/helpers/search_history_constraints_helper_spec.rb

@@ -22,7 +22,7 @@ describe SearchHistoryConstraintsHelper do
 
   describe "render_search_to_s_*" do
     describe "render_search_to_s_element" do
-      it "should render basic element" do
+      it "renders basic element" do
         response = helper.render_search_to_s_element("key", "value")
         expect(response).to have_selector("span.constraint")  do |span|
           expect(span).to have_selector("span.filterName", :content => "key:")
@@ -30,7 +30,7 @@ describe SearchHistoryConstraintsHelper do
         end
         expect(response).to be_html_safe
       end
-      it "should escape them that need escaping" do
+      it "escapes them that need escaping" do
         response = helper.render_search_to_s_element("key>", "value>")
         expect(response).to have_selector("span.constraint") do |span|          
           expect(span).to have_selector("span.filterName") do |s2|
@@ -45,7 +45,7 @@ describe SearchHistoryConstraintsHelper do
         end
         expect(response).to be_html_safe
       end
-      it "should not escape with options set thus" do
+      it "does not escape with options set thus" do
         response = helper.render_search_to_s_element("key>", "value>", :escape_key => false, :escape_value => false)
         expect(response).to have_selector("span.constraint") do |span|
           expect(span).to have_selector("span.filterName", :content => "key>:")
@@ -59,7 +59,7 @@ describe SearchHistoryConstraintsHelper do
       before do
         @params = {:q => "history", :f => {"some_facet" => ["value1", "value1"],  "other_facet" => ["other1"]}}        
       end
-      it "should call lesser methods" do
+      it "calls lesser methods" do
         allow(helper).to receive(:blacklight_config).and_return(@config)
         allow(helper).to receive(:default_search_field).and_return(Blacklight::Configuration::SearchField.new(:key => 'default_search_field', :display_label => 'Default'))
         allow(helper).to receive(:label_for_search_field).with(nil).and_return('')
@@ -73,12 +73,12 @@ describe SearchHistoryConstraintsHelper do
     end
     
     describe "render_search_to_s_filters" do
-      it "should render a constraint for a selected facet in the config" do
+      it "renders a constraint for a selected facet in the config" do
         response = helper.render_search_to_s_filters(:f => {"some_facet" => ["value1", "value2"]})
         expect(response).to eq("<span class=\"constraint\"><span class=\"filterName\">Some:</span><span class=\"filterValues\"><span class=\"filterValue\">value1</span><span class=\"filterSeparator\"> and </span><span class=\"filterValue\">value2</span></span></span>")
       end
 
-      it "should render a constraint for a selected facet not in the config" do
+      it "renders a constraint for a selected facet not in the config" do
         response = helper.render_search_to_s_filters(:f => {"undefined_facet" => ["value1", "value2"]})
         expect(response).to eq("<span class=\"constraint\"><span class=\"filterName\">#{'undefined_facet'.humanize}:</span><span class=\"filterValues\"><span class=\"filterValue\">value1</span><span class=\"filterSeparator\"> and </span><span class=\"filterValue\">value2</span></span></span>")
       end
@@ -92,7 +92,7 @@ describe SearchHistoryConstraintsHelper do
           I18n.locale = @orig_locale
         end
 
-        it 'should render the correct I18n label for a selected facet with I18n translations' do
+        it 'renders the correct I18n label for a selected facet with I18n translations' do
           {en: 'English facet label', de: 'German facet label'}.each do |locale, label|
             I18n.locale = locale
             response = helper.render_search_to_s_filters(f: {'i18n_facet' => ['value1', 'value2']})

data/spec/helpers/url_helper_spec.rb

@@ -32,11 +32,11 @@ describe BlacklightUrlHelper do
       allow(helper).to receive_messages(params: parameter_class.new)
     end
 
-    it "should be a polymorphic routing-ready object" do
+    it "is a polymorphic routing-ready object" do
       expect(helper.url_for_document(doc)).to eq doc
     end
 
-    it "should allow for custom show routes" do
+    it "allows for custom show routes" do
       helper.blacklight_config.show.route = { controller: 'catalog' }
       expect(helper.url_for_document(doc)).to eq({controller: 'catalog', action: :show, id: doc})
     end
@@ -44,7 +44,7 @@ describe BlacklightUrlHelper do
     context "within bookmarks" do
       let(:controller_class) { ::BookmarksController.new }
 
-      it "should use polymorphic routing" do
+      it "uses polymorphic routing" do
         expect(helper.url_for_document(doc)).to eq doc
       end
     end
@@ -57,12 +57,12 @@ describe BlacklightUrlHelper do
         allow(helper).to receive(:params).and_return(parameter_class.new controller: 'alternate')
       end
 
-      it "should support the :current controller configuration" do
+      it "supports the :current controller configuration" do
         expect(helper.url_for_document(doc)).to eq(controller: 'alternate', action: :show, id: doc)
       end
     end
 
-    it "should be a polymorphic route if the solr document responds to #to_model with a non-SolrDocument" do
+    it "is a polymorphic route if the solr document responds to #to_model with a non-SolrDocument" do
       some_model = double
       doc = SolrDocument.new
       allow(doc).to receive_messages(to_model: some_model)
@@ -74,7 +74,7 @@ describe BlacklightUrlHelper do
     let(:query_params)  {{:q => "query", :f => "facets", :controller=>'catalog'}}
     let(:bookmarks_query_params) {{ :controller=>'bookmarks'}}
 
-    it "should build a link tag to catalog using session[:search] for query params" do
+    it "builds a link tag to catalog using session[:search] for query params" do
       allow(helper).to receive(:current_search_session).and_return double(:query_params => query_params)
       tag = helper.link_back_to_catalog
       expect(tag).to match /q=query/
@@ -83,7 +83,7 @@ describe BlacklightUrlHelper do
       expect(tag).to_not match /per_page=/
     end
 
-    it "should build a link tag to bookmarks using session[:search] for query params" do
+    it "builds a link tag to bookmarks using session[:search] for query params" do
       allow(helper).to receive(:current_search_session).and_return double(:query_params => bookmarks_query_params)
       tag = helper.link_back_to_catalog
       expect(tag).to match /Back to Bookmarks/
@@ -92,7 +92,7 @@ describe BlacklightUrlHelper do
 
     context "with a search context" do
 
-      it "should use the current search session counter and per page information to construct the appropriate pagination context" do
+      it "uses the current search session counter and per page information to construct the appropriate pagination context" do
         allow(helper).to receive_messages(current_search_session: double(query_params: query_params))
         allow(helper).to receive_messages(search_session: { 'per_page' => 15, 'counter' => 31 })
         tag = helper.link_back_to_catalog
@@ -100,7 +100,7 @@ describe BlacklightUrlHelper do
         expect(tag).to match /per_page=15/
       end
 
-      it "should omit per_page if the value is the same as the default" do
+      it "omits per_page if the value is the same as the default" do
         allow(helper).to receive_messages(current_search_session: double(query_params: query_params))
         allow(helper).to receive_messages(search_session: { 'per_page' => 10, 'counter' => 31 })
         tag = helper.link_back_to_catalog
@@ -121,7 +121,7 @@ describe BlacklightUrlHelper do
 
       subject { helper.link_back_to_catalog }
 
-      it "should link to the catalog" do
+      it "links to the catalog" do
         expect(subject).to eq '<a href="/catalog">Back to Search</a>'
       end
     end
@@ -129,7 +129,7 @@ describe BlacklightUrlHelper do
     context "when an alternate scope is passed in" do
       let(:my_engine) { double("Engine") }
 
-      it "should call url_for on the engine scope" do
+      it "calls url_for on the engine scope" do
         allow(helper).to receive(:current_search_session).and_return double(:query_params => query_params)
         expect(my_engine).to receive(:url_for).and_return(url_for(query_params))
         tag = helper.link_back_to_catalog(route_set: my_engine)
@@ -181,13 +181,13 @@ describe BlacklightUrlHelper do
   end
 
   describe "start_over_path" do
-    it 'should be the catalog path with the current view type' do
+    it 'is the catalog path with the current view type' do
       allow(blacklight_config).to receive(:view) { { list: nil, abc: nil} }
       allow(helper).to receive_messages(:blacklight_config => blacklight_config)
       expect(helper.start_over_path(:view => 'abc')).to eq search_catalog_url(:view => 'abc')
     end
 
-    it 'should not include the current view type if it is the default' do
+    it 'does not include the current view type if it is the default' do
       allow(blacklight_config).to receive(:view) { { list: nil, asdf: nil} }
       allow(helper).to receive_messages(:blacklight_config => blacklight_config)
       expect(helper.start_over_path(:view => 'list')).to eq search_catalog_url
@@ -199,6 +199,9 @@ describe BlacklightUrlHelper do
     let(:id) { '123456' }
     let(:data) { { 'id' => id, 'title_display' => [title_display] } }
     let(:document) { SolrDocument.new(data) }
+    before do
+      allow(controller).to receive(:action_name).and_return('index')
+    end
 
     it "consists of the document title wrapped in a <a>" do
       expect(helper.link_to_document(document, :title_display)).to have_selector("a", :text => '654321', :count => 1)
@@ -264,14 +267,14 @@ describe BlacklightUrlHelper do
 
   describe "link_to_previous_search" do
     let(:params) { {} }
-    it "should link to the given search parameters" do
+    it "links to the given search parameters" do
       allow(helper).to receive(:render_search_to_s).with(params).and_return "link text"
       expect(helper.link_to_previous_search({})).to eq helper.link_to("link text", helper.search_action_path)
     end
   end
 
   describe "#bookmarks_export_url" do
-    it "should be the bookmark url with an encrypted user token" do
+    it "is the bookmark url with an encrypted user token" do
       allow(helper).to receive_messages(encrypt_user_id: 'xyz', current_or_guest_user: double(id: 123))
       url = helper.bookmarks_export_url(:html)
       expect(url).to eq helper.bookmarks_url(format: :html, encrypted_user_id: 'xyz')
@@ -280,12 +283,12 @@ describe BlacklightUrlHelper do
 
   describe "#session_tracking_path" do
     let(:document) { SolrDocument.new(id: 1) }
-    it "should determine the correct route for the document class" do
+    it "determines the correct route for the document class" do
       allow(helper).to receive(:track_test_path).with(id: 1).and_return('x')
       expect(helper.session_tracking_path(document)).to eq 'x'
     end
 
-    it "should pass through tracking parameters" do
+    it "passes through tracking parameters" do
       allow(helper).to receive(:track_test_path).with(id: 1, x: 1).and_return('x')
       expect(helper.session_tracking_path(document, x: 1)).to eq 'x'
     end