blacklight 6.2.0 → 6.3.0

data/spec/features/search_formats_spec.rb

@@ -8,14 +8,14 @@ describe "Search Formats" do
     CatalogController.blacklight_config.default_solr_params[:fl] = '*'
   end
 
-  it "should have an RSS XML response" do
+  it "has an RSS XML response" do
     visit "/catalog.rss?q="
     expect(page).to have_content "Blacklight Search Results"
     doc = Nokogiri::XML(page.body)
     expect(doc.xpath("//item")).to have(10).items
   end
 
-  it "should have an ATOM XML response" do
+  it "has an ATOM XML response" do
     visit "/catalog.atom?q="
     expect(page).to have_content "Blacklight Search Results"
     doc = Nokogiri::XML(page.body)

data/spec/features/search_history_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 
 describe "Search History Page" do
   describe "navigating from the homepage" do
-    it "should have a link to the history page" do
+    it "has a link to the history page" do
       visit root_path
       click_link 'History'
       expect(page).to have_content 'Search History'
@@ -18,7 +18,7 @@ describe "Search History Page" do
       click_button 'search'
       click_link 'History'
     end
-    it "should show searches" do
+    it "shows searches" do
       expect(page).to have_content 'Your recent searches'
       expect(page).to have_content 'book'
       expect(page).to_not have_content 'dang'
@@ -40,7 +40,7 @@ describe "Search History Page" do
       click_button 'search'
       click_link 'History'
     end
-    it "should be able to clear the history" do
+    it "is able to clear the history" do
       click_link "Clear Search History"
       expect(page).to have_content 'Cleared your search history.'
       expect(page).to have_content 'You have no search history'
@@ -57,7 +57,7 @@ describe "Search History Page" do
       click_link 'History'
     end
 
-    it "should save and forget the search" do
+    it "saves and forget the search" do
       click_button 'save'
       expect(page).to have_content 'Successfully saved your search.'
       click_button 'forget'
@@ -65,7 +65,7 @@ describe "Search History Page" do
       expect(page).to have_button 'save'
     end
 
-    it "should not show results after logging out" do
+    it "does not show results after logging out" do
       click_button 'save'
       expect(page).to have_content 'Successfully saved your search.'
       click_link 'Log Out'

data/spec/features/search_pagination_spec.rb

@@ -2,7 +2,7 @@
 require 'spec_helper'
 
 describe "Search Pagination" do
-  it "should have results with pagination" do
+  it "has results with pagination" do
     visit root_path
     fill_in "q", with: ''
     click_button 'search'
@@ -28,7 +28,7 @@ describe "Search Pagination" do
     end
   end
 
-  it "should be able to change the number of items per page" do
+  it "is able to change the number of items per page" do
     visit root_path
     fill_in "q", with: ''
     click_button 'search'
@@ -55,7 +55,7 @@ describe "Search Pagination" do
       CatalogController.blacklight_config[:per_page] = original_per_page
       CatalogController.blacklight_config[:default_solr_params][:rows] = original_rows
     end
-    it "should use the configured values" do
+    it "uses the configured values" do
       visit root_path
       fill_in "q", with: ''
       click_button 'search'
@@ -75,7 +75,7 @@ describe "Search Pagination" do
     end
   end
 
-  it "should reset the page offset to 1 when changing per page" do
+  it "resets the page offset to 1 when changing per page" do
     visit root_path
     fill_in "q", with: ''
     click_button 'search'

data/spec/features/search_results_spec.rb

@@ -2,7 +2,7 @@
 require 'spec_helper'
 
 describe "Search Results" do
-  it "should have for an empty query" do
+  it "has for an empty query" do
     search_for ''
     expect(number_of_results_from_page(page)).to eq 30
     expect(page).to have_xpath("//a[contains(@href, #{2007020969})]")
@@ -10,7 +10,7 @@ describe "Search Results" do
     expect(number_of_results_from_page(page)).to eq 4
   end
 
-  it "should find same result set with or without diacritcs" do
+  it "finds same result set with or without diacritcs" do
     search_for 'inmul'
     expect(number_of_results_from_page(page)).to eq 1
     expect(page).to have_xpath("//a[contains(@href, #{77826928})]")
@@ -18,7 +18,7 @@ describe "Search Results" do
     search_for 'inmül'
     expect(number_of_results_from_page(page)).to eq 1
   end
-  it "should find same result set for a case-insensitive query " do
+  it "finds same result set for a case-insensitive query" do
     search_for 'inmul'
     expect(number_of_results_from_page(page)).to eq 1
     expect(page).to have_xpath("//a[contains(@href, #{77826928})]")
@@ -27,14 +27,14 @@ describe "Search Results" do
     expect(number_of_results_from_page(page)).to eq 1
   end
 
-  it "should order by relevancy" do
+  it "orders by relevancy" do
     search_for "Korea"
     expect(position_in_result_page(page, '77826928')).to eq 1
     expect(position_in_result_page(page, '94120425')).to eq 2
     
   end
 
-  it "should have an opensearch description document" do
+  it "has an opensearch description document" do
     visit root_path
     tmp_value = Capybara.ignore_hidden_elements
     Capybara.ignore_hidden_elements = false
@@ -43,12 +43,12 @@ describe "Search Results" do
     Capybara.ignore_hidden_elements = tmp_value
   end
 
-  it "should provide search hints if there are no results" do
+  it "provides search hints if there are no results" do
     search_for 'asdfghj'
     expect(page).to have_content "No results found for your search"
   end
 
-  it "should provide search hints if there are no results" do
+  it "provides search hints if there are no results" do
     visit root_path
     fill_in "q", with: "inmul"
     select "Author", from: "search_field"

data/spec/features/search_sort_spec.rb

@@ -2,7 +2,7 @@
 require 'spec_helper'
 
 describe "Search Sort" do
-  it "should sort on facet results with no search terms" do
+  it "sorts on facet results with no search terms" do
     visit root_path
     within "#facet-language_facet" do
       click_link 'English'
@@ -12,7 +12,7 @@ describe "Search Sort" do
     expect(page).to have_content 'Sort by title'
   end
 
-  it "should sort on search" do
+  it "sorts on search" do
     visit root_path
     fill_in "q", with: 'bod'
     click_button 'search'

data/spec/features/search_spec.rb

@@ -2,7 +2,7 @@
 require 'spec_helper'
 
 describe "Search Page" do
-  it "should show welcome" do
+  it "shows welcome" do
     visit root_path
     expect(page).to have_selector("input#q")
     within ("select#search_field") do
@@ -21,7 +21,7 @@ describe "Search Page" do
     Capybara.ignore_hidden_elements = tmp_value
   end
 
-  it "should do searches across all fields" do
+  it "does searches across all fields" do
     visit root_path
     fill_in "q", with: 'history'
     select 'All Fields', from: 'search_field'
@@ -62,7 +62,7 @@ describe "Search Page" do
     end
   end
 
-  it "should do searches constrained to a single field" do
+  it "does searches constrained to a single field" do
     visit root_path
     fill_in "q", with: 'inmul'
     select 'Title', from: 'search_field'
@@ -84,7 +84,7 @@ describe "Search Page" do
     end
   end
 
-  it "should show vernacular (Linked 880) and call number" do
+  it "shows vernacular (Linked 880) and call number" do
     visit root_path
     fill_in "q", with: 'history'
     click_button 'search'
@@ -94,7 +94,7 @@ describe "Search Page" do
     end
   end
 
-  it "should allow you to clear the search" do
+  it "allows you to clear the search" do
     visit root_path
     fill_in "q", with: 'history'
     click_button 'search'
@@ -111,7 +111,7 @@ describe "Search Page" do
     expect(page).to_not have_selector "#q[value='history']"
   end
 
-  it "should gracefully handle searches with invalid facet parameters" do
+  it "handles searches with invalid facet parameters" do
     visit root_path f: { missing_s: [1]}
     expect(page).to have_content "No results found for your search"
   end

data/spec/helpers/blacklight_helper_spec.rb

@@ -4,7 +4,6 @@ require 'spec_helper'
 describe BlacklightHelper do
   include ERB::Util
   include BlacklightHelper
-  include Devise::TestHelpers
   def blacklight_config
     @config ||= Blacklight::Configuration.new.configure do |config|
       config.index.title_field = 'title_display'
@@ -13,6 +12,7 @@ describe BlacklightHelper do
   end
 
   before(:each) do
+    allow(helper).to receive(:current_or_guest_user).and_return(User.new)
     allow(helper).to receive(:search_action_path) do |*args|
       search_catalog_url *args
     end
@@ -23,27 +23,27 @@ describe BlacklightHelper do
   end
 
   describe "#application_name", :test => true do
-    it "should use the Rails application config application_name if available" do
+    it "uses the Rails application config application_name if available" do
       allow(Rails.application).to receive(:config).and_return(double(application_name: "asdf"))
       expect(application_name).to eq "asdf"
     end
-    it "should default to 'Blacklight'" do
+    it "defaults to 'Blacklight'" do
       expect(application_name).to eq "Blacklight"
     end
   end
 
   describe "#render_page_title" do
-    it "should look in content_for(:page_title)" do
+    it "looks in content_for(:page_title)" do
       helper.content_for(:page_title) { "xyz" }
       expect(helper.render_page_title).to eq "xyz"
     end
 
-    it "should look in the @page_title ivar" do
+    it "looks in the @page_title ivar" do
       assign(:page_title, "xyz")
       expect(helper.render_page_title).to eq "xyz"
     end
 
-    it "should default to the application name" do
+    it "defaults to the application name" do
       expect(helper.render_page_title).to eq helper.application_name
     end
   end
@@ -94,18 +94,18 @@ describe BlacklightHelper do
     end
 
     describe "render_index_doc_actions" do
-      it "should render partials" do
+      it "renders partials" do
         allow(controller).to receive(:render_bookmarks_control?).and_return(true)
         response = helper.render_index_doc_actions(document)
         expect(response).to have_selector(".bookmark_toggle")
       end
 
-      it "should be nil if no partials are renderable" do
+      it "is nil if no partials are renderable" do
         allow(controller).to receive(:render_bookmarks_control?).and_return(false)
         expect(helper.render_index_doc_actions(document)).to be_blank
       end
 
-      it "should render view type specific actions" do
+      it "renders view type specific actions" do
         allow(helper).to receive(:document_index_view_type).and_return(:custom)
         config.view.custom.document_actions = []
         expect(helper.render_index_doc_actions(document)).to be_blank
@@ -113,7 +113,7 @@ describe BlacklightHelper do
     end
 
     describe "render_show_doc_actions" do
-      it "should render partials" do
+      it "renders partials" do
         response = helper.render_show_doc_actions(document)
         expect(response).to have_selector(".bookmark_toggle")
       end
@@ -125,17 +125,17 @@ describe BlacklightHelper do
       allow(helper).to receive_messages(should_render_field?: true, document_has_value?: true)
     end
 
-    it "should be true" do
+    it "is true" do
       expect(helper.should_render_index_field?(double, double)).to be true
     end
     
-    it "should be false if the document doesn't have a value for the field" do
+    it "is false if the document doesn't have a value for the field" do
       allow(helper).to receive_messages(document_has_value?: false)
       expect(helper.should_render_index_field?(double, double)).to be false
       
     end
     
-    it "should be false if the configuration has the field disabled" do
+    it "is false if the configuration has the field disabled" do
       allow(helper).to receive_messages(should_render_field?: false)
       expect(helper.should_render_index_field?(double, double)).to be false
     end
@@ -146,17 +146,17 @@ describe BlacklightHelper do
       allow(helper).to receive_messages(should_render_field?: true, document_has_value?: true)
     end
     
-    it "should be true" do
+    it "is true" do
       expect(helper.should_render_show_field?(double, double)).to be true
     end
     
-    it "should be false if the document doesn't have a value for the field" do
+    it "is false if the document doesn't have a value for the field" do
       allow(helper).to receive_messages(document_has_value?: false)
       expect(helper.should_render_show_field?(double, double)).to be false
       
     end
     
-    it "should be false if the configuration has the field disabled" do
+    it "is false if the configuration has the field disabled" do
       allow(helper).to receive_messages(should_render_field?: false)
       expect(helper.should_render_show_field?(double, double)).to be false
     end
@@ -171,18 +171,18 @@ describe BlacklightHelper do
     let(:doc) { double }
     let(:field) { "some_field" }
 
-    it "should pass the document and field through to the presenter" do
-      expect(presenter).to receive(:render_index_field_value).with(field, {})
+    it "passes the document and field through to the presenter" do
+      expect(presenter).to receive(:field_value).with(field, {})
       helper.render_index_field_value(doc, field)
     end
 
-    it "should allow the document and field to be passed as hash arguments" do
-      expect(presenter).to receive(:render_index_field_value).with(field, {})
+    it "allows the document and field to be passed as hash arguments" do
+      expect(presenter).to receive(:field_value).with(field, {})
       helper.render_index_field_value(document: doc, field: field)
     end
 
-    it "should allow additional options to be passed to the presenter" do
-      expect(presenter).to receive(:render_index_field_value).with(field, x: 1)
+    it "allows additional options to be passed to the presenter" do
+      expect(presenter).to receive(:field_value).with(field, x: 1)
       helper.render_index_field_value(document: doc, field: field, x: 1)
     end
   end
@@ -196,31 +196,31 @@ describe BlacklightHelper do
     let(:doc) { double }
     let(:field) { "some_field" }
 
-    it "should pass the document and field through to the presenter" do
-      expect(presenter).to receive(:render_document_show_field_value).with(field, {})
+    it "passes the document and field through to the presenter" do
+      expect(presenter).to receive(:field_value).with(field, {})
       helper.render_document_show_field_value(doc, field)
     end
 
-    it "should allow the document and field to be passed as hash arguments" do
-      expect(presenter).to receive(:render_document_show_field_value).with(field, {})
+    it "allows the document and field to be passed as hash arguments" do
+      expect(presenter).to receive(:field_value).with(field, {})
       helper.render_document_show_field_value(document: doc, field: field)
     end
 
-    it "should allow additional options to be passed to the presenter" do
-      expect(presenter).to receive(:render_document_show_field_value).with(field, x: 1)
+    it "allows additional options to be passed to the presenter" do
+      expect(presenter).to receive(:field_value).with(field, x: 1)
       helper.render_document_show_field_value(document: doc, field: field, x: 1)
     end
   end
   
   describe "#document_has_value?" do
-    it "should if the document has the field value" do
+    it "ifs the document has the field value" do
       doc = double()
       allow(doc).to receive(:has?).with('asdf').and_return(true)
       field_config = double(:field => 'asdf')
       expect(helper.document_has_value?(doc, field_config)).to eq true
     end
 
-    it "should if the document has a highlight field value" do
+    it "ifs the document has a highlight field value" do
       doc = double()
       allow(doc).to receive(:has?).with('asdf').and_return(false)
       allow(doc).to receive(:has_highlight_field?).with('asdf').and_return(true)
@@ -228,7 +228,7 @@ describe BlacklightHelper do
       expect(helper.document_has_value?(doc, field_config)).to eq true
     end
 
-    it "should if the field has a model accessor" do
+    it "ifs the field has a model accessor" do
       doc = double()
       allow(doc).to receive(:has?).with('asdf').and_return(false)
       allow(doc).to receive(:has_highlight_field?).with('asdf').and_return(false)
@@ -238,13 +238,13 @@ describe BlacklightHelper do
   end
 
   describe "render_grouped_response?" do
-    it "should check if the response ivar contains grouped data" do
+    it "checks if the response ivar contains grouped data" do
       assign(:response, double("Solr::Response", :grouped? => true))
       expect(helper.render_grouped_response?).to be true
     end
 
 
-    it "should check if the response param contains grouped data" do
+    it "checks if the response param contains grouped data" do
       response = double("Solr::Response", :grouped? => true)
       expect(helper.render_grouped_response?(response)).to be true
     end
@@ -258,17 +258,17 @@ describe BlacklightHelper do
     before :each do
       allow(helper).to receive_messages spell_check_max: 5
     end
-    it "should not show suggestions if there are enough results" do
+    it "does not show suggestions if there are enough results" do
       response = double(total: 10)
       expect(helper.should_show_spellcheck_suggestions? response).to be false
     end
 
-    it "should only show suggestions if there are very few results" do
+    it "onlies show suggestions if there are very few results" do
       response = double(total: 4, spelling: double(words: [1]))
       expect(helper.should_show_spellcheck_suggestions? response).to be true
     end
 
-    it "should show suggestions only if there are spelling suggestions available" do
+    it "shows suggestions only if there are spelling suggestions available" do
       response = double(total: 4, spelling: double(words: []))
       expect(helper.should_show_spellcheck_suggestions? response).to be false
     end
@@ -281,7 +281,7 @@ describe BlacklightHelper do
       allow(helper).to receive_messages(document_index_view_type: 'index_header')
     end
     
-    it "should get the document format from document_partial_name" do
+    it "gets the document format from document_partial_name" do
       allow(helper).to receive(:document_partial_name).with(doc, :xyz)
       helper.render_document_partial(doc, :xyz)    
     end
@@ -296,7 +296,7 @@ describe BlacklightHelper do
 
     context "with a solr document with empty fields" do
       let(:document) { SolrDocument.new }
-      it "should be the default value" do
+      it "is the default value" do
         expect(helper.document_partial_name(document)).to eq 'default'
       end
     end
@@ -308,11 +308,11 @@ describe BlacklightHelper do
         blacklight_config.show.display_type_field = 'my_field'
       end
 
-      it "should use the value in the configured display type field" do
+      it "uses the value in the configured display type field" do
         expect(helper.document_partial_name(document)).to eq 'xyz'
       end
 
-      it "should use the value in the configured display type field if the action-specific field is empty" do
+      it "uses the value in the configured display type field if the action-specific field is empty" do
         expect(helper.document_partial_name(document, :some_action)).to eq 'xyz'
       end
     end
@@ -326,7 +326,7 @@ describe BlacklightHelper do
         blacklight_config.show.metadata_display_type_field = 'other_field'
       end
 
-      it "should use the value in the action-specific fields" do
+      it "uses the value in the action-specific fields" do
         expect(helper.document_partial_name(document, :media)).to eq 'xyz'
         expect(helper.document_partial_name(document, :metadata)).to eq 'abc'
       end
@@ -356,25 +356,25 @@ describe BlacklightHelper do
   describe "#opensearch_description_tag" do
     subject { helper.opensearch_description_tag 'title', 'href' }
     
-    it "should have a search rel" do
+    it "has a search rel" do
       expect(subject).to have_selector "link[rel='search']", visible: false
     end
     
-    it "should have the correct mime type" do
+    it "has the correct mime type" do
       expect(subject).to have_selector "link[type='application/opensearchdescription+xml']", visible: false
     end
     
-    it "should have a title attribute" do
+    it "has a title attribute" do
       expect(subject).to have_selector "link[title='title']", visible: false
     end
     
-    it "should have an href attribute" do
+    it "has an href attribute" do
       expect(subject).to have_selector "link[href='href']", visible: false
     end
   end
   
   describe "#render_document_index" do
-    it "should render the document index with the current view type" do
+    it "renders the document index with the current view type" do
       allow(helper).to receive_messages(document_index_view_type: :current_view)
       allow(helper).to receive(:render_document_index_with_view).with(:current_view, [], a: 1, b: 2)
       helper.render_document_index [], a: 1, b: 2
@@ -391,25 +391,25 @@ describe BlacklightHelper do
       allow(helper).to receive(:render_index_doc_actions).and_return('<div/>')
     end
 
-    it "should ignore missing templates" do
+    it "ignores missing templates" do
       response = helper.render_document_index_with_view :view_type, [obj1, obj1]
       expect(response).to have_selector "div#documents"
     end
   end
 
   describe "#document_index_view_type" do
-    it "should default to the default view" do
+    it "defaults to the default view" do
       allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2)
       allow(helper).to receive(:default_document_index_view_type).and_return(:xyz)
       expect(helper.document_index_view_type).to eq :xyz
     end
 
-    it "should use the query parameter" do
+    it "uses the query parameter" do
       allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2)
       expect(helper.document_index_view_type(view: :a)).to eq :a
     end
 
-    it "should use the default view if the requested view is not available" do
+    it "uses the default view if the requested view is not available" do
       allow(helper).to receive(:default_document_index_view_type).and_return(:xyz)
       allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2)
       expect(helper.document_index_view_type(view: :c)).to eq :xyz
@@ -421,19 +421,19 @@ describe BlacklightHelper do
       end
 
       context "and no view is specified" do
-        it "should use the saved preference" do
+        it "uses the saved preference" do
           allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2, c: 3)
           expect(helper.document_index_view_type).to eq :b
         end
 
-        it "should use the default view if the preference is not available" do
+        it "uses the default view if the preference is not available" do
           allow(helper).to receive(:document_index_views).and_return(a: 1)
           expect(helper.document_index_view_type).to eq :a
         end
       end
 
       context "and a view is specified" do
-        it "should use the query parameter" do
+        it "uses the query parameter" do
           allow(helper).to receive(:document_index_views).and_return(a: 1, b: 2, c: 3)
           expect(helper.document_index_view_type(view: :c)).to eq :c
         end
@@ -446,6 +446,23 @@ describe BlacklightHelper do
       allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
     end
 
+    it "uses the value defined in the blacklight configuration" do
+      expect(Deprecation).to receive(:warn).exactly(4).times
+      blacklight_config.document_presenter_class = presenter_class
+      expect(helper.presenter_class).to eq presenter_class
+    end
+
+    it "defaults to Blacklight::DocumentPresenter" do
+      expect(Deprecation).to receive(:warn)
+      expect(helper.presenter_class).to eq Blacklight::DocumentPresenter
+    end
+  end
+
+  describe "#index_presenter_class" do
+    before do
+      allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
+    end
+
     let :blacklight_config do
       Blacklight::Configuration.new
     end
@@ -454,38 +471,61 @@ describe BlacklightHelper do
       double
     end
 
-    it "should use the value defined in the blacklight configuration" do
-      blacklight_config.document_presenter_class = presenter_class
-      expect(helper.presenter_class).to eq presenter_class
+    it "uses the value defined in the blacklight configuration" do
+      blacklight_config.index.document_presenter_class = presenter_class
+      expect(helper.index_presenter_class(nil)).to eq presenter_class
     end
 
-    it "should default to Blacklight::DocumentPresenter" do
-      expect(helper.presenter_class).to eq Blacklight::DocumentPresenter
+    it "defaults to Blacklight::IndexPresenter" do
+      expect(helper.index_presenter_class(nil)).to eq Blacklight::IndexPresenter
+    end
+  end
+
+  describe "#show_presenter_class" do
+    before do
+      allow(helper).to receive(:blacklight_config).and_return(blacklight_config)
+    end
+
+    let :blacklight_config do
+      Blacklight::Configuration.new
+    end
+
+    let :presenter_class do
+      double
+    end
+
+    it "uses the value defined in the blacklight configuration" do
+      blacklight_config.show.document_presenter_class = presenter_class
+      expect(helper.show_presenter_class(nil)).to eq presenter_class
+    end
+
+    it "defaults to Blacklight::DocumentPresenter" do
+      expect(helper.show_presenter_class(nil)).to eq Blacklight::ShowPresenter
     end
   end
 
   describe "#render_document_heading" do
     before do
-      allow(helper).to receive(:presenter).and_return(double(document_heading: "Heading"))
+      allow(helper).to receive(:presenter).and_return(double(heading: "Heading"))
     end
 
     let(:document) { double }
 
-    it "should accept no arguments and render the document heading" do
+    it "accepts no arguments and render the document heading" do
       expect(helper.render_document_heading).to have_selector "h4", text: "Heading"
     end
 
-    it "should accept the tag name as an option" do
+    it "accepts the tag name as an option" do
       expect(helper.render_document_heading tag: "h1").to have_selector "h1", text: "Heading"
     end
 
-    it "should accept an explicit document argument" do
-      allow(helper).to receive(:presenter).with(document).and_return(double(document_heading: "Document Heading"))
+    it "accepts an explicit document argument" do
+      allow(helper).to receive(:presenter).with(document).and_return(double(heading: "Document Heading"))
       expect(helper.render_document_heading(document)).to have_selector "h4", text: "Document Heading"
     end
     
-    it "should accept the document with a tag option" do
-      allow(helper).to receive(:presenter).with(document).and_return(double(document_heading: "Document Heading"))
+    it "accepts the document with a tag option" do
+      allow(helper).to receive(:presenter).with(document).and_return(double(heading: "Document Heading"))
       expect(helper.render_document_heading(document, tag: "h3")).to have_selector "h3", text: "Document Heading"
     end
   end