blacklight-spotlight 3.0.0.rc2 → 3.0.0

data/spec/controllers/spotlight/bulk_actions_controller_spec.rb

@@ -0,0 +1,124 @@
+# frozen_string_literal: true
+
+describe Spotlight::BulkActionsController, type: :controller do
+  routes { Spotlight::Engine.routes }
+  let(:exhibit) { FactoryBot.create(:skinny_exhibit) }
+
+  # rubocop:disable RSpec/BeforeAfterAll
+  before(:all) do
+    ActiveJob::Base.queue_adapter = :test
+  end
+
+  after(:all) do
+    ActiveJob::Base.queue_adapter = :inline
+  end
+  # rubocop:enable RSpec/BeforeAfterAll
+
+  describe 'when the user is not authorized' do
+    before do
+      sign_in FactoryBot.create(:exhibit_visitor)
+    end
+
+    describe 'POST change_visibility' do
+      it 'denies access' do
+        post :change_visibility, params: { exhibit_id: exhibit }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+
+    describe 'POST add_tags' do
+      it 'denies access' do
+        post :add_tags, params: { exhibit_id: exhibit }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+
+    describe 'POST remove_tags' do
+      it 'denies access' do
+        post :remove_tags, params: { exhibit_id: exhibit }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+  end
+
+  describe 'when the user is a curator' do
+    before do
+      sign_in FactoryBot.create(:exhibit_curator, exhibit: exhibit)
+    end
+
+    let(:search) { FactoryBot.create(:search, exhibit: exhibit) }
+    let(:search_session) { instance_double('Blacklight::Search', query_params: { q: 'map' }) }
+
+    describe 'POST change_visibility' do
+      it 'redirects and sets a notice' do
+        allow(controller).to receive(:current_search_session).and_return(search_session)
+        request.env['HTTP_REFERER'] = '/referring_url'
+        post :change_visibility, params: { 'visibility' => 'private', 'q' => 'map', exhibit_id: exhibit }
+        expect(response).to redirect_to '/referring_url'
+        expect(flash[:notice]).to eq 'Visibility of 55 items is being updated.'
+      end
+
+      # rubocop:disable Style/MultilineBlockChain
+      it 'enqueues the job' do
+        allow(controller).to receive(:current_search_session).and_return(search_session)
+        expect do
+          post :change_visibility, params: { 'visibility' => 'private', 'q' => 'map', exhibit_id: exhibit }
+        end.to have_enqueued_job(Spotlight::ChangeVisibilityJob).with do |solr_params, exhb, visibility|
+          expect(solr_params).to.not be_nil
+          expect(exhb).to eq exhibit
+          expect(visibility).to eq 'private'
+        end
+      end
+      # rubocop:enable Style/MultilineBlockChain
+    end
+
+    describe 'POST add_tags' do
+      it 'redirects and sets a notice' do
+        allow(controller).to receive(:current_search_session).and_return(search_session)
+        request.env['HTTP_REFERER'] = '/referring_url'
+        post :add_tags, params: { 'tags' => 'howdy,planet', 'q' => 'map', exhibit_id: exhibit }
+        expect(response).to redirect_to '/referring_url'
+        expect(flash[:notice]).to eq 'Tags are being added for 55 items.'
+      end
+
+      # rubocop:disable Style/MultilineBlockChain
+      it 'enqueues the job' do
+        allow(controller).to receive(:current_search_session).and_return(search_session)
+        expect do
+          post :add_tags, params: { 'tags' => 'howdy,planet', 'q' => 'map', exhibit_id: exhibit }
+        end.to have_enqueued_job(Spotlight::AddTagsJob).with do |solr_params, exhb, tags|
+          expect(solr_params).to.not be_nil
+          expect(exhb).to eq exhibit
+          expect(tags).to eq %w[howdy planet]
+        end
+      end
+      # rubocop:enable Style/MultilineBlockChain
+    end
+
+    describe 'POST remove_tags' do
+      it 'redirects and sets a notice' do
+        allow(controller).to receive(:current_search_session).and_return(search_session)
+        request.env['HTTP_REFERER'] = '/referring_url'
+        post :remove_tags, params: { 'tags' => 'hello,world', 'q' => 'map', exhibit_id: exhibit }
+        expect(response).to redirect_to '/referring_url'
+        expect(flash[:notice]).to eq 'Tags are being removed for 55 items.'
+      end
+
+      # rubocop:disable Style/MultilineBlockChain
+      it 'enqueues the job' do
+        allow(controller).to receive(:current_search_session).and_return(search_session)
+        expect do
+          post :remove_tags, params: { 'tags' => 'howdy,planet', 'q' => 'map', exhibit_id: exhibit }
+        end.to have_enqueued_job(Spotlight::RemoveTagsJob).with do |solr_params, exhb, tags|
+          expect(solr_params).to.not be_nil
+          expect(exhb).to eq exhibit
+          expect(tags).to eq %w[howdy planet]
+        end
+      end
+      # rubocop:enable Style/MultilineBlockChain
+    end
+  end
+end

data/spec/controllers/spotlight/bulk_updates_controller_spec.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+describe Spotlight::BulkUpdatesController, type: :controller do
+  routes { Spotlight::Engine.routes }
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+
+  describe 'when the user is not authorized' do
+    before do
+      sign_in FactoryBot.create(:exhibit_visitor)
+    end
+
+    describe 'GET edit' do
+      it 'denies access' do
+        get :edit, params: { exhibit_id: exhibit }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+
+    describe 'POST download_template' do
+      it 'denies access' do
+        post :download_template, params: { exhibit_id: exhibit }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+  end
+
+  describe 'when the user is a curator' do
+    before do
+      sign_in FactoryBot.create(:exhibit_curator, exhibit: exhibit)
+    end
+
+    describe 'GET edit' do
+      it 'is allowed' do
+        get :edit, params: { exhibit_id: exhibit }
+        expect(response).to be_successful
+      end
+    end
+
+    describe 'POST download_template' do
+      it 'downloads a CSV template' do
+        post :download_template, params: {
+          exhibit_id: exhibit,
+          reference_fields: { item_id: 1, item_title: 1 },
+          updatable_fields: { tags: 0, visibility: 1 }
+        }
+
+        content = CSV.parse(response.body)
+        expect(content.length).to eq 56
+        expect(content[0]).to eq ['Item ID', 'Item Title', 'Visibility']
+      end
+    end
+
+    describe 'PATCH download_template' do
+      before { ActiveJob::Base.queue_adapter = :test }
+
+      after { ActiveJob::Base.queue_adapter = :inline }
+
+      it 'uploads the given CSV template and passes it to a job' do
+        expect do
+          patch :update, params: {
+            exhibit_id: exhibit,
+            file: fixture_file_upload('spec/fixtures/bulk-update-template.csv', 'text/csv')
+          }
+        end.to(have_enqueued_job(Spotlight::ProcessBulkUpdatesCsvJob).with do |job_exhibit, uploader|
+          expect(job_exhibit).to eq exhibit
+          expect(uploader).to be_a Spotlight::BulkUpdate
+          expect(uploader.file_identifier).to eq 'bulk-update-template.csv'
+        end)
+
+        expect(flash[:notice]).to eq 'The CSV file was uploaded successfully.'
+        expect(response).to redirect_to(spotlight.edit_exhibit_bulk_updates_path(exhibit))
+      end
+    end
+  end
+end

data/spec/controllers/spotlight/catalog_controller_spec.rb

@@ -29,7 +29,7 @@ describe Spotlight::CatalogController, type: :controller do
       let(:search) { FactoryBot.create(:search, exhibit: exhibit) }
 
       it 'shows the item' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit, q: ''))
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with('L'AMERIQUE', exhibit_solr_document_path(exhibit, document))
         get :show, params: { exhibit_id: exhibit, id: 'dq287tq6352' }
         expect(response).to be_successful
@@ -38,7 +38,7 @@ describe Spotlight::CatalogController, type: :controller do
       it 'shows the item with breadcrumbs to the browse page' do
         allow(controller).to receive_messages(current_browse_category: search)
 
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit, q: ''))
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with('Browse', exhibit_browse_index_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with(search.title, exhibit_browse_path(exhibit, search))
         expect(controller).to receive(:add_breadcrumb).with('L'AMERIQUE', exhibit_solr_document_path(exhibit, document))
@@ -50,7 +50,7 @@ describe Spotlight::CatalogController, type: :controller do
         feature_page = FactoryBot.create(:feature_page, exhibit: exhibit)
         allow(controller).to receive_messages(current_page_context: feature_page)
 
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit, q: ''))
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with(feature_page.title, [exhibit, feature_page])
         expect(controller).to receive(:add_breadcrumb).with('L'AMERIQUE', exhibit_solr_document_path(exhibit, document))
         get :show, params: { exhibit_id: exhibit, id: 'dq287tq6352' }
@@ -61,7 +61,7 @@ describe Spotlight::CatalogController, type: :controller do
         home_page = FactoryBot.create(:home_page)
         allow(controller).to receive_messages(current_page_context: home_page)
 
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit, q: ''))
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
         expect(controller).to receive(:add_breadcrumb).with('L'AMERIQUE', exhibit_solr_document_path(exhibit, document))
         get :show, params: { exhibit_id: exhibit, id: 'dq287tq6352' }
         expect(response).to be_successful
@@ -80,8 +80,8 @@ describe Spotlight::CatalogController, type: :controller do
 
     describe 'GET index' do
       it 'shows the index when there are parameters' do
-        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit, q: ''))
-        expect(controller).to receive(:add_breadcrumb).with('Search results', search_exhibit_catalog_path(exhibit, q: 'map'))
+        expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
+        expect(controller).to receive(:add_breadcrumb).with('Search results', search_exhibit_catalog_path(exhibit, q: 'map'), current: true)
         get :index, params: { exhibit_id: exhibit, q: 'map' }
         expect(response).to be_successful
       end
@@ -120,8 +120,9 @@ describe Spotlight::CatalogController, type: :controller do
 
     describe 'GET manifest' do
       context 'document is an uploaded resource' do
+        let(:uploaded_resource) { FactoryBot.create(:uploaded_resource) }
+
         it 'returns the json manifest produced by Spotlight::IiifManifestPresenter, based on the retrieved document and the controller' do
-          uploaded_resource = FactoryBot.create(:uploaded_resource)
           compound_id = uploaded_resource.compound_id
           slug = uploaded_resource.exhibit.slug
 
@@ -146,6 +147,7 @@ describe Spotlight::CatalogController, type: :controller do
           expect(image['resource']['@id']).to eq compound_id
           expect(image['resource']['format']).to eq 'image/jpeg'
 
+        ensure
           # clean up solr document created by save_and_index above
           Blacklight.default_index.connection.delete_by_id uploaded_resource.compound_id
           Blacklight.default_index.connection.commit
@@ -214,7 +216,7 @@ describe Spotlight::CatalogController, type: :controller do
     before { sign_in FactoryBot.create(:exhibit_curator, exhibit: exhibit) }
 
     it 'shows all the items' do
-      expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit, q: ''))
+      expect(controller).to receive(:add_breadcrumb).with('Home', exhibit_path(exhibit))
       expect(controller).to receive(:add_breadcrumb).with('Curation', exhibit_dashboard_path(exhibit))
       expect(controller).to receive(:add_breadcrumb).with('Items', admin_exhibit_catalog_path(exhibit))
       get :admin, params: { exhibit_id: exhibit }
@@ -297,7 +299,7 @@ describe Spotlight::CatalogController, type: :controller do
   end
 
   describe 'when the user is a site admin' do
-    before { sign_in FactoryBot.create(:site_admin, exhibit: exhibit) }
+    before { sign_in FactoryBot.create(:site_admin) }
 
     describe 'GET show' do
       it 'has a solr_json serialization' do
@@ -497,22 +499,22 @@ describe Spotlight::CatalogController, type: :controller do
 
     before { allow(controller).to receive_messages(current_exhibit: current_exhibit) }
 
-    describe 'render_save_this_search?' do
+    describe 'render_curator_actions?' do
       it 'returns false if we are on the items admin screen' do
         allow(controller).to receive(:can?).with(:curate, current_exhibit).and_return(true)
         allow(controller).to receive(:params).and_return(controller: 'spotlight/catalog', action: 'admin')
-        expect(controller).not_to be_render_save_this_search
+        expect(controller).not_to be_render_curator_actions
       end
 
       it 'returns true if we are not on the items admin screen' do
         allow(controller).to receive(:can?).with(:curate, current_exhibit).and_return(true)
         allow(controller).to receive(:params).and_return(controller: 'spotlight/catalog', action: 'index')
-        expect(controller).to be_render_save_this_search
+        expect(controller).to be_render_curator_actions
       end
 
       it 'returns false if a user cannot curate the object' do
         allow(controller).to receive(:can?).with(:curate, current_exhibit).and_return(false)
-        expect(controller).not_to be_render_save_this_search
+        expect(controller).not_to be_render_curator_actions
       end
     end
   end

data/spec/controllers/spotlight/feature_pages_controller_spec.rb

@@ -92,6 +92,17 @@ describe Spotlight::FeaturePagesController, type: :controller, versioning: true
           expect(response).to redirect_to(exhibit_feature_page_path(exhibit, page_es))
         end
       end
+
+      context 'when the sidebar is set to not display' do
+        let(:page) { FactoryBot.create(:feature_page, exhibit: exhibit, published: true) }
+
+        before { page.update(display_sidebar: false) }
+
+        it 'injects custom classes into the gallery view' do
+          get :show, params: { exhibit_id: exhibit.id, id: page.id }
+          expect(assigns(:exhibit).blacklight_config.view.gallery.classes).to eq 'row-cols-2 row-cols-md-4'
+        end
+      end
     end
 
     describe 'GET new' do

data/spec/controllers/spotlight/featured_images_controller_spec.rb

@@ -40,7 +40,7 @@ describe Spotlight::FeaturedImagesController, type: :controller do
         end.to change { Spotlight::FeaturedImage.count }.by(1)
 
         expect(response).to be_successful
-        expect(response.body).to match %r{\{"tilesource":"http://test\.host/images/\d+/info\.json","id":\d+\}}
+        expect(response.body).to match %r{\{"tilesource":"http://test\.host/images/\d+-.+/info\.json","id":\d+\}}
       end
     end
 
@@ -55,7 +55,7 @@ describe Spotlight::FeaturedImagesController, type: :controller do
         end.to change { Spotlight::FeaturedImage.count }.by(1)
 
         expect(response).to be_successful
-        expect(response.body).to match %r{\{"tilesource":"http://test\.host/images/\d+/info\.json","id":\d+\}}
+        expect(response.body).to match %r{\{"tilesource":"http://test\.host/images/\d+-.+/info\.json","id":\d+\}}
       end
     end
 
@@ -70,7 +70,7 @@ describe Spotlight::FeaturedImagesController, type: :controller do
         end.to change { Spotlight::FeaturedImage.count }.by(1)
 
         expect(response).to be_successful
-        expect(response.body).to match %r{\{"tilesource":"http://test\.host/images/\d+/info\.json","id":\d+\}}
+        expect(response.body).to match %r{\{"tilesource":"http://test\.host/images/\d+-.+/info\.json","id":\d+\}}
       end
     end
   end

data/spec/controllers/spotlight/groups_controller_spec.rb

@@ -0,0 +1,103 @@
+# frozen_string_literal: true
+
+describe Spotlight::GroupsController, type: :controller do
+  routes { Spotlight::Engine.routes }
+  let(:exhibit) { FactoryBot.create(:exhibit) }
+  let!(:group) { FactoryBot.create(:group, exhibit: exhibit) }
+
+  describe 'when the user is not authorized' do
+    before do
+      sign_in FactoryBot.create(:exhibit_visitor)
+    end
+
+    describe 'GET index' do
+      it 'returns authorized groups (none)' do
+        get :index, params: { exhibit_id: exhibit }, format: :json
+        expect(response).to be_successful
+        expect(JSON.parse(response.body).length).to eq 0
+      end
+    end
+
+    describe 'POST create' do
+      it 'denies access' do
+        post :create, params: { exhibit_id: exhibit, group: { title: 'Hello' } }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+
+    describe 'PUT update' do
+      it 'denies access' do
+        patch :update, params: { exhibit_id: exhibit, id: group.id }
+        expect(response).to redirect_to main_app.root_path
+        expect(flash[:alert]).to be_present
+      end
+    end
+  end
+
+  describe 'when the user is a curator' do
+    before do
+      sign_in FactoryBot.create(:exhibit_curator, exhibit: exhibit)
+    end
+
+    describe 'GET index' do
+      it 'returns json response of groups' do
+        get :index, params: { exhibit_id: exhibit }, format: :json
+        expect(JSON.parse(response.body).length).to eq 1
+      end
+    end
+
+    describe 'POST create' do
+      it 'creates a saved search' do
+        post :create, params: { exhibit_id: exhibit, group: { title: 'Hello' } }
+        expect(response).to redirect_to spotlight.exhibit_searches_path(exhibit, anchor: 'browse-groups')
+        expect(flash[:notice]).to eq 'The browse group was created.'
+      end
+    end
+
+    describe 'PATCH update' do
+      it 'shows edit page' do
+        patch :update, params: {
+          id: group.id,
+          exhibit_id: group.exhibit,
+          group: {
+            title: 'Hello world'
+          }
+        }
+
+        expect(group.reload.title).to eq 'Hello world'
+        expect(response).to redirect_to exhibit_searches_path(exhibit, anchor: 'browse-groups')
+      end
+    end
+
+    describe 'PATCH update_all' do
+      let!(:group2) { FactoryBot.create(:group, exhibit: exhibit, published: true) }
+      let!(:group3) { FactoryBot.create(:group, exhibit: exhibit, published: true) }
+
+      it 'shows edit page' do
+        patch :update_all, params: {
+          exhibit_id: group.exhibit,
+          exhibit: {
+            groups_attributes: [
+              { id: group.id, published: true, weight: '1' },
+              { id: group2.id, published: false, weight: '0' }
+            ]
+          }
+        }
+
+        expect(group.reload.weight).to eq 1
+        expect(group2.reload.published).to be false
+        expect(response).to redirect_to exhibit_searches_path(exhibit, anchor: 'browse-groups')
+      end
+    end
+
+    describe 'DELETE delete' do
+      it 'removes the group' do
+        group
+        expect do
+          delete :destroy, params: { id: group.id, exhibit_id: group.exhibit }
+        end.to change { Spotlight::Group.count }.by(-1)
+      end
+    end
+  end
+end