blackbeard 0.0.3.1 → 0.0.4.0

data/spec/group_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe Blackbeard::Group do
-  let(:group){ Blackbeard::Group.new('example') }
+  let(:group){ Blackbeard::Group.find_or_create('example') }
   let(:context){ double(:controller => double, :user => double) }
   describe "segment" do
     context "with no code defined" do

data/spec/metric_data/total_spec.rb

@@ -5,7 +5,7 @@ module Blackbeard
 
     describe Total do
 
-      let(:metric) { Blackbeard::Metric.new(:total, "page views") }
+      let(:metric) { Blackbeard::Metric.create(:total, "page views") }
       let(:metric_data) { metric.metric_data }
       let(:uid) { "unique identifier" }
       let(:ouid) { "other unique identifier" }

data/spec/metric_data/unique_spec.rb

@@ -4,7 +4,7 @@ module Blackbeard
   module MetricData
     describe Unique do
 
-      let(:metric) { Blackbeard::Metric.new(:unique, "join") }
+      let(:metric) { Blackbeard::Metric.create(:unique, "join") }
       let(:metric_data) { metric.metric_data }
       let(:uid) { "unique identifier" }
       let(:ouid) { "other unique identifier" }

data/spec/metric_spec.rb

@@ -2,16 +2,16 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 module Blackbeard
   describe Metric do
-    let(:metric) { Metric.new(:total, "one-total") }
-    let(:group) { Group.new(:example) }
+    let(:metric) { Metric.create(:total, "one-total") }
+    let(:group) { Group.create(:example) }
     let(:metric_data) { metric.metric_data }
     let(:group_metric_data) { metric.metric_data(group) }
 
     describe "self.all" do
       before :each do
-        Metric.new(:total, "one-total")
-        Metric.new(:total, "two-total")
-        Metric.new(:unique, "one-unique")
+        Metric.create(:total, "one-total")
+        Metric.create(:total, "two-total")
+        Metric.create(:unique, "one-unique")
       end
       it "should return a Metric Object for each Metric created" do
         Metric.all.should have(3).metrics

data/spec/pirate_spec.rb

@@ -7,15 +7,19 @@ describe Blackbeard::Pirate do
     let(:name){ "bond" }
 
     it "should get metrics once" do
-      Blackbeard::Metric.should_receive(:new).with(:total, name).once.and_return(double)
+      Blackbeard::Metric.should_receive(:find_or_create).with(:total, name).once.and_return(double)
       4.times{ pirate.metric(:total, name) }
     end
 
     it "should get test once" do
-      Blackbeard::Test.should_receive(:new).with(name).once.and_return(double)
+      Blackbeard::Test.should_receive(:find_or_create).with(name).once.and_return(double)
       4.times{ pirate.test(name) }
     end
 
+    it "should get features once" do
+      Blackbeard::Feature.should_receive(:find_or_create).with(name).once.and_return(double)
+      4.times{ pirate.feature(name) }
+    end
 
   end
 
@@ -29,20 +33,20 @@ describe Blackbeard::Pirate do
 
   describe "set context delegations" do
     context "with no set context" do
-      it "add_unique should raise Blackbeard::MissingContextError" do
+      it "add_unique should not raise error" do
         expect{ pirate.add_unique(:example) }.to_not raise_error
       end
 
-      it "add_total should raise Blackbeard::MissingContextError" do
+      it "add_total should not raise error" do
         expect{ pirate.add_total(:example, 1) }.to_not raise_error
       end
 
-      it "ab_test should raise Blackbeard::MissingContextError" do
+      it "ab_test should not raise error" do
         expect{ pirate.ab_test(:example, :on => 1, :off => 2) }.to_not raise_error
       end
 
-      it "active? should raise Blackbeard::MissingContextError" do
-        expect{ pirate.active?(:example) }.to_not raise_error
+      it "active? should not raise error" do
+        expect{ pirate.feature_active?(:example) }.to_not raise_error
       end
 
     end
@@ -61,13 +65,13 @@ describe Blackbeard::Pirate do
       end
 
       it "should delegate #ab_test" do
-        set_context.should_receive(:ab_test).with(:example_metric, :on => 1, :off => 2).and_return(set_context)
-        pirate.ab_test(:example_metric, :on => 1, :off => 2)
+        set_context.should_receive(:ab_test).with(:example_test, :on => 1, :off => 2).and_return(set_context)
+        pirate.ab_test(:example_test, :on => 1, :off => 2)
       end
 
-      it "should delegate #active?" do
-        set_context.should_receive(:active?).with(:example_metric).and_return(false)
-        pirate.active?(:example_metric)
+      it "should delegate #feature_active?" do
+        set_context.should_receive(:feature_active?).with(:example_feature).and_return(false)
+        pirate.feature_active?(:example_feature)
       end
     end
   end

data/spec/redis_store_spec.rb

@@ -51,6 +51,12 @@ module Blackbeard
         db.hash_increment_by_float('a_hash', 'field', 2.5)
         db.hash_get('a_hash', 'field').should == "3.5"
       end
+
+      it "should determine if key exists" do
+        expect{
+          db.hash_set('a_hash', 'field', 'exists')
+        }.to change{db.hash_field_exists('a_hash', 'field')}.from(false).to(true)
+      end
     end
 
     describe "sets" do

data/spec/spec_helper.rb

@@ -6,8 +6,10 @@ CodeClimate::TestReporter.start
 
 RSpec.configure do |config|
   config.before do
+    Blackbeard.configure! do |c|
+      c.namespace = "BlackbeardTests"
+    end
     redis = Blackbeard.config.db
-    namespace = "BlackbeardTests"
     keys = redis.keys
     redis.del(keys) if keys.any?
   end

data/spec/storable_attributes_spec.rb

@@ -2,31 +2,79 @@ require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe Blackbeard::Storable do
   class ExampleStorableAttrBase < Blackbeard::Storable
+    integer_attributes :number
     string_attributes :name
+    json_attributes :list
   end
 
   class ExampleStorableAttr < ExampleStorableAttrBase
     set_master_key :example
   end
 
+  let(:example){ ExampleStorableAttr.create("id") }
+
+  describe "json_attributes" do
+    it "should not blow up when nil" do
+        example.list.should be_nil
+    end
+
+    it "should read and write" do
+      example.list = ["hello", "world"]
+      example.list.should == ["hello", "world"]
+    end
+
+    it "should not persist if not saved" do
+      example.list = ["hello", "world"]
+      example.reload.list.should_not == ["hello", "world"]
+    end
+
+    it "should persist if saved" do
+      example.list = ["hello", "world"]
+      example.save
+      example.reload.list.should == ["hello", "world"]
+    end
+  end
+
+  describe "integer_attributes" do
+    it "should be read and write" do
+      example.number = 3
+      example.number.should == 3
+    end
+
+    it "should not persist if not saved" do
+      example.number = 4
+      example.reload.number.should_not == 4
+    end
+
+    it "should persist when saved" do
+      example.number = 5
+      example.save
+
+      example.reload.number.should == 5
+    end
+  end
+
   describe "string_attributes" do
     it "should be read and write" do
-      example = ExampleStorableAttr.new("id")
       example.name = "Some name"
       example.name.should == "Some name"
     end
 
-    it "should persist" do
-      example = ExampleStorableAttr.new("id")
+    it "should not persist if not saved" do
       example.name = "Some name"
+      example.reload.name.should_not == "Some name"
+    end
 
-      example_reloaded = ExampleStorableAttr.new("id")
-      example_reloaded.name.should == "Some name"
+    it "should persist when saved" do
+      example.name = "Some name"
+      example.save
+
+      example.reload.name.should == "Some name"
     end
   end
 
   describe "update_attributes" do
-    let(:storable){ ExampleStorableAttr.new("id") }
+    let(:storable){ ExampleStorableAttr.create("id") }
     it "should not raise raise_error with non-attributes" do
       expect{
         storable.update_attributes(:name => 'hello')
@@ -43,5 +91,9 @@ describe Blackbeard::Storable do
         storable.update_attributes("name" => 'hello')
       }.to change{ storable.name }.from(nil).to('hello')
     end
+    it "should persist the changes" do
+      storable.update_attributes("name" => 'hello')
+      storable.reload.name.should == 'hello'
+    end
   end
 end

data/spec/storable_has_many_spec.rb

@@ -12,8 +12,8 @@ module Blackbeard
   end
 
   describe StorableHasMany do
-    let(:example){ HasManyExample.new(:example) }
-    let(:thing){ Thing.new(:foo) }
+    let(:example){ HasManyExample.create(:example) }
+    let(:thing){ Thing.create(:foo) }
 
     it "should add and remove things" do
       example.add_thing(thing)

data/spec/storable_has_set_spec.rb

@@ -8,7 +8,7 @@ module Blackbeard
   end
 
   describe StorableHasMany do
-    let(:example){ HasSetExample.new(:example) }
+    let(:example){ HasSetExample.create(:example) }
     let(:thing) { "foo" }
 
     it "should add and remove things" do

data/spec/storable_spec.rb

@@ -1,33 +1,129 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
-describe Blackbeard::Storable do
-  class ExampleStorable < Blackbeard::Storable
-    set_master_key :example
-  end
+module Blackbeard
+  describe Storable do
+    class ExampleStorable < Storable
+      set_master_key :example
+      string_attributes :name
+    end
 
-  class AnotherStorable < Blackbeard::Storable
-    set_master_key :another
-  end
+    class AnotherStorable < Storable
+      set_master_key :another
+    end
 
-  it "should be able to instantiate" do
-    expect{
-      ExampleStorable.new(:some_id)
-    }.to_not raise_error
-  end
+    describe "initialize" do
+      it "should be able to instantiate" do
+        expect{
+          ExampleStorable.new(:some_id)
+        }.to_not raise_error
+      end
 
-  describe "master_key" do
-    it "should be by class" do
-      ExampleStorable.master_key.should == 'example'
-      AnotherStorable.master_key.should == 'another'
+      it "should not save" do
+        expect{
+          ExampleStorable.new(:some_id)
+        }.to_not change{ ExampleStorable.count }
+      end
     end
-  end
 
-  describe "==" do
-    it "should match class and id" do
-      (ExampleStorable.new("thing") == ExampleStorable.new("thing")).should be_true
-      (ExampleStorable.new("thing") == ExampleStorable.new("thing2")).should be_false
-      (ExampleStorable.new("thing") == AnotherStorable.new("thing")).should be_false
+    describe "self.find" do
+      it "should find an existing record" do
+        example = ExampleStorable.create(:some_id)
+        ExampleStorable.find(:some_id)
+      end
+      it "should return nil if the key does not exist" do
+        ExampleStorable.find(:some_id).should be_nil
+      end
+    end
+
+    describe "self.create" do
+      it "should raise DuplicateKey if there is an existing record" do
+        example = ExampleStorable.create(:some_id)
+        expect{
+          ExampleStorable.create(:some_id)
+        }.to raise_error(StorableDuplicateKey)
+      end
+
+      it "should create a new record" do
+        expect{ ExampleStorable.create(:this_id) }.to change{ExampleStorable.count}.by(1)
+      end
+
+      it "should update attributes" do
+        storable = ExampleStorable.create(:some_id, {:name => 'hello world'})
+        storable.reload.name.should == 'hello world'
+      end
+    end
+
+    describe "self.find_or_create" do
+      it "should create a new record if one doesn't exist" do
+        expect{ ExampleStorable.find_or_create(:this_id) }.to change{ExampleStorable.count}.by(1)
+      end
+
+      it "should find an existing record if one exists" do
+        example = ExampleStorable.create(:this_id)
+        ExampleStorable.find_or_create(:this_id)
+      end
     end
-  end
 
+    describe "self.all" do
+      before :each do
+        @this = ExampleStorable.create(:this)
+        @not_this = AnotherStorable.create(:not_this)
+        @that = ExampleStorable.create(:that)
+      end
+
+      it "should return all the record" do
+        ExampleStorable.all.should include(@this, @that)
+        ExampleStorable.all.should_not include(@not_this)
+      end
+
+      it "should mark them as not new records" do
+        ExampleStorable.all.each do |r|
+          r.should_not be_new_record
+        end
+      end
+    end
+
+    describe "self.count" do
+      before :each do
+        ExampleStorable.create(:this)
+        AnotherStorable.create(:this)
+        ExampleStorable.create(:that)
+      end
+
+      it "should return the number of committed storables" do
+        ExampleStorable.count.should == 2
+        AnotherStorable.count.should == 1
+      end
+    end
+
+    describe "save" do
+      let(:new_record) { ExampleStorable.new(:an_id) }
+      it "should commit to db" do
+        expect{
+          new_record.save
+        }.to change{ ExampleStorable.count }.by(1)
+      end
+      it "should set @new_record = false" do
+          expect{
+            new_record.save
+          }.to change{ new_record.new_record }.from(true).to(false)
+      end
+    end
+
+    describe "master_key" do
+      it "should be by class" do
+        ExampleStorable.master_key.should == 'example'
+        AnotherStorable.master_key.should == 'another'
+      end
+    end
+
+    describe "==" do
+      it "should match class and id" do
+        (ExampleStorable.new("thing") == ExampleStorable.new("thing")).should be_true
+        (ExampleStorable.new("thing") == ExampleStorable.new("thing2")).should be_false
+        (ExampleStorable.new("thing") == AnotherStorable.new("thing")).should be_false
+      end
+    end
+
+  end
 end

data/spec/test_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
 
 describe Blackbeard::Test do
-  let(:test){ Blackbeard::Test.new('example') }
+  let(:test){ Blackbeard::Test.create('example') }
 
   describe "#select_variation" do
     # '*' - experimenting

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blackbeard
 version: !ruby/object:Gem::Version
-  version: 0.0.3.1
+  version: 0.0.4.0
 platform: ruby
 authors:
 - Robert Graff
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-24 00:00:00.000000000 Z
+date: 2014-03-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -222,10 +222,13 @@ files:
 - dashboard/public/stylesheets/bootstrap-theme.css
 - dashboard/public/stylesheets/bootstrap.css
 - dashboard/routes/base.rb
+- dashboard/routes/features.rb
 - dashboard/routes/groups.rb
 - dashboard/routes/home.rb
 - dashboard/routes/metrics.rb
 - dashboard/routes/tests.rb
+- dashboard/views/features/index.erb
+- dashboard/views/features/show.erb
 - dashboard/views/groups/index.erb
 - dashboard/views/groups/show.erb
 - dashboard/views/index.erb
@@ -242,6 +245,8 @@ files:
 - lib/blackbeard/dashboard.rb
 - lib/blackbeard/dashboard_helpers.rb
 - lib/blackbeard/errors.rb
+- lib/blackbeard/feature.rb
+- lib/blackbeard/feature_rollout.rb
 - lib/blackbeard/group.rb
 - lib/blackbeard/metric.rb
 - lib/blackbeard/metric_data/base.rb
@@ -261,10 +266,13 @@ files:
 - spec/blackbeard_spec.rb
 - spec/configuration_spec.rb
 - spec/context_spec.rb
+- spec/dashboard/features_spec.rb
 - spec/dashboard/groups_spec.rb
 - spec/dashboard/home_spec.rb
 - spec/dashboard/metrics_spec.rb
 - spec/dashboard/tests_spec.rb
+- spec/feature_rollout_spec.rb
+- spec/feature_spec.rb
 - spec/group_spec.rb
 - spec/metric_data/base_spec.rb
 - spec/metric_data/total_spec.rb
@@ -306,10 +314,13 @@ test_files:
 - spec/blackbeard_spec.rb
 - spec/configuration_spec.rb
 - spec/context_spec.rb
+- spec/dashboard/features_spec.rb
 - spec/dashboard/groups_spec.rb
 - spec/dashboard/home_spec.rb
 - spec/dashboard/metrics_spec.rb
 - spec/dashboard/tests_spec.rb
+- spec/feature_rollout_spec.rb
+- spec/feature_spec.rb
 - spec/group_spec.rb
 - spec/metric_data/base_spec.rb
 - spec/metric_data/total_spec.rb