blackbeard 0.0.3.1 → 0.0.4.0

data/lib/blackbeard/storable_has_many.rb

@@ -49,6 +49,7 @@ module Blackbeard
             end
 
             def #{plural}_set_key
+              raise StorableNotSaved if new_record?
               key+"::#{plural}"
             end
         END_OF_RUBY

data/lib/blackbeard/storable_has_set.rb

@@ -47,6 +47,7 @@ module Blackbeard
             end
 
             def #{plural}_key
+              raise StorableNotSaved if new_record?
               key+"::#{plural}"
             end
 

data/lib/blackbeard/version.rb

@@ -1,3 +1,3 @@
 module Blackbeard
-  VERSION = "0.0.3.1"
+  VERSION = "0.0.4.0"
 end

data/spec/blackbeard_spec.rb

@@ -4,4 +4,17 @@ describe Blackbeard do
   it "should not sink" do
     Blackbeard.should_not be_nil
   end
+
+  describe "pirate" do
+    it "can configure" do
+      p = Blackbeard.pirate do |config|
+        config.timezone = 'America/Somewhere'
+      end
+      Blackbeard.config.timezone.should == 'America/Somewhere'
+    end
+    it "returns a pirate" do
+        Blackbeard.pirate.should be_a(Blackbeard::Pirate)
+    end
+  end
+
 end

data/spec/configuration_spec.rb

@@ -10,6 +10,12 @@ module Blackbeard
         end
         config.group_definitions[:hello].call.should == 'world'
       end
+      it "should add segments if any" do
+        config.define_group(:hello, ["world"]) do |user,controller|
+          "world"
+        end
+        Group.find(:hello).segments.should include("world")
+      end
     end
   end
 end

data/spec/context_spec.rb

@@ -6,9 +6,9 @@ module Blackbeard
     let(:user) { double(:id => 1) }
     let(:context) { Context.new(pirate, user) }
     let(:uid) { context.unique_identifier }
-    let(:total_metric) { Metric.new(:total, :things) }
-    let(:unique_metric) { Metric.new(:unique, :things) }
-    let(:test) { Test.new(:example_test) }
+    let(:total_metric) { Metric.create(:total, :things) }
+    let(:unique_metric) { Metric.create(:unique, :things) }
+    let(:test) { Test.create(:example_test) }
 
     describe "#add_total" do
       it "should call add on the total metric" do
@@ -76,23 +76,23 @@ module Blackbeard
       end
     end
 
-    describe "#active?" do
-      let(:inactive_test) { Blackbeard::Test.new(:inactive_test) }
-      let(:active_test) { Blackbeard::Test.new(:active_test) }
+    describe "#feature_active?" do
+      let(:inactive_feature) { Blackbeard::Feature.create(:inactive_feature) }
+      let(:active_feature) { Blackbeard::Feature.create(:active_feature) }
 
       before :each do
-        pirate.stub(:test).with(active_test.id).and_return(active_test)
-        pirate.stub(:test).with(inactive_test.id).and_return(inactive_test)
+        pirate.stub(:feature).with(active_feature.id).and_return(active_feature)
+        pirate.stub(:feature).with(inactive_feature.id).and_return(inactive_feature)
       end
 
       it "should return true when active" do
-        active_test.should_receive(:select_variation).and_return('active')
-        context.active?(:active_test).should be_true
+        active_feature.should_receive(:active_for?).with(context).and_return(true)
+        context.feature_active?(:active_feature).should be_true
       end
 
       it "should return true when active" do
-        inactive_test.should_receive(:select_variation).and_return('inactive')
-        context.active?(:inactive_test).should be_false
+        inactive_feature.should_receive(:active_for?).with(context).and_return(false)
+        context.feature_active?(:inactive_feature).should be_false
       end
 
     end

data/spec/dashboard/features_spec.rb

@@ -0,0 +1,52 @@
+require File.expand_path(File.dirname(__FILE__) + './../spec_helper')
+
+require 'rack/test'
+require 'blackbeard/dashboard'
+
+module Blackbeard
+  describe Dashboard do
+    include Rack::Test::Methods
+
+    let(:app) { Dashboard }
+
+    describe "get /features" do
+      it "should list all the features" do
+        Feature.create("jostling")
+        get "/features"
+
+        last_response.should be_ok
+        last_response.body.should include('jostling')
+      end
+    end
+
+    describe "get /features/:id" do
+      it "should show a feature" do
+        feature = Feature.create("jostling")
+        get "/features/#{feature.id}"
+
+        last_response.should be_ok
+        last_response.body.should include("jostling")
+      end
+    end
+
+    describe "post /features/:id" do
+      it "should update the feature" do
+        feature = Feature.create("jostling")
+        post "/features/#{feature.id}", :name => 'hello'
+
+        last_response.should be_ok
+        feature.reload.name.should == 'hello'
+      end
+    end
+
+    describe "post /features/:id/groups/:group_id" do
+      it "should update the features segments" do
+        feature = Feature.create("jostling")
+        post "/features/#{feature.id}/groups/hello", :segments => ["world","goodbye"]
+
+        last_response.should be_ok
+        feature.reload.segments_for(:hello).should include("world", "goodbye")
+      end
+    end
+  end
+end

data/spec/dashboard/groups_spec.rb

@@ -18,7 +18,7 @@ module Blackbeard
 
     describe "get /groups" do
       it "should list all the groups" do
-        Group.new("jostling")
+        Group.create("jostling")
         get "/groups"
 
         last_response.should be_ok
@@ -28,7 +28,7 @@ module Blackbeard
 
     describe "get /groups/:id" do
       it "should show a metric" do
-        group = Group.new("jostling")
+        group = Group.create("jostling")
         get "/groups/#{group.id}"
 
         last_response.should be_ok
@@ -38,11 +38,11 @@ module Blackbeard
 
     describe "post /groups/:id" do
       it "should update the group" do
-        group = Group.new("jostling")
+        group = Group.create("jostling")
         post "/groups/#{group.id}", :name => 'hello'
 
         last_response.should be_ok
-        Group.new("jostling").name.should == 'hello'
+        Group.find("jostling").name.should == 'hello'
       end
     end
 

data/spec/dashboard/metrics_spec.rb

@@ -11,7 +11,7 @@ module Blackbeard
 
     describe "get /metrics" do
       it "should list all the metrics" do
-        Metric.new("total", "jostling")
+        Metric.create("total", "jostling")
         get "/metrics"
 
         last_response.should be_ok
@@ -21,7 +21,7 @@ module Blackbeard
 
     describe "get /metrics/:type/:type_id" do
       it "should show a metric" do
-        metric = Metric.new("total", "jostling")
+        metric = Metric.create("total", "jostling")
         get "/metrics/#{metric.type}/#{metric.type_id}"
 
         last_response.should be_ok
@@ -31,18 +31,18 @@ module Blackbeard
 
     describe "post /metrics/:type/:type_id" do
       it "should update the metric" do
-        metric = Metric.new("total", "jostling")
+        metric = Metric.create("total", "jostling")
         post "/metrics/#{metric.type}/#{metric.type_id}", :name => 'hello'
 
         last_response.should be_ok
-        Metric.new(:total, "jostling").name.should == 'hello'
+        Metric.find(:total, "jostling").name.should == 'hello'
       end
     end
 
     describe "post /metrics/:type/:type_id/groups" do
       it "should add a group to the metric" do
-        metric = Metric.new("total", "jostling")
-        group = Group.new("admin")
+        metric = Metric.create("total", "jostling")
+        group = Group.create("admin")
         post "/metrics/#{metric.type}/#{metric.type_id}/groups", :group_id => group.id
 
         last_response.should be_redirect

data/spec/dashboard/tests_spec.rb

@@ -11,7 +11,7 @@ module Blackbeard
 
     describe "get /tests" do
       it "should list all the test" do
-        Test.new("jostling")
+        Test.create("jostling")
         get "/tests"
 
         last_response.should be_ok
@@ -21,7 +21,7 @@ module Blackbeard
 
     describe "get /tests/:id" do
       it "should show a test" do
-        test = Test.new("jostling")
+        test = Test.create("jostling")
         get "/tests/#{test.id}"
 
         last_response.should be_ok
@@ -31,11 +31,11 @@ module Blackbeard
 
     describe "post /tests/:id" do
       it "should update the test" do
-        test = Test.new("jostling")
+        test = Test.create("jostling")
         post "/tests/#{test.id}", :name => 'hello'
 
         last_response.should be_ok
-        Test.new("jostling").name.should == 'hello'
+        test.reload.name.should == 'hello'
       end
     end
 

data/spec/feature_rollout_spec.rb

@@ -0,0 +1,147 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+module Blackbeard
+  describe FeatureRollout do
+    let(:feature){ Blackbeard::Feature.create('example') }
+    let(:context) { double }
+    describe "rollout?" do
+      it "should be true if active_visitor?" do
+        feature.should_receive(:active_visitor?).with(context).and_return(true)
+        feature.stub(:active_user?).with(context).and_return(false)
+        feature.stub(:active_segment?).with(context).and_return(false)
+        feature.rollout?(context).should be_true
+      end
+
+      it "should be true if active_user?" do
+        feature.should_receive(:active_user?).with(context).and_return(true)
+        feature.stub(:active_visitor?).with(context).and_return(false)
+        feature.stub(:active_segment?).with(context).and_return(false)
+        feature.rollout?(context).should be_true
+      end
+
+      it "should be true if active_segment?" do
+        feature.should_receive(:active_segment?).with(context).and_return(true)
+        feature.stub(:active_visitor?).with(context).and_return(false)
+        feature.stub(:active_user?).with(context).and_return(false)
+        feature.rollout?(context).should be_true
+      end
+    end
+
+    describe "active_user?" do
+      context "with no logged in user" do
+        it "should be true if users_rate is 100" do
+          feature.users_rate = 100
+          context.stub(:user).and_return(nil)
+          feature.active_user?(context).should be_false
+        end
+      end
+
+      context "with logged in user" do
+        it "should be false if users_rate is 0" do
+          feature.users_rate = 0
+          context.stub(:user).and_return(double :id => 0)
+          feature.active_user?(context).should be_false
+        end
+
+        it "should be true if users_rate is 100" do
+          feature.users_rate = 100
+          context.stub(:user).and_return(double :id => 0)
+          feature.active_user?(context).should be_true
+        end
+
+        describe "by user_id modulus" do
+          [212,201,1,113,1008].each do |i|
+            it "should be true" do
+              feature.users_rate = 13
+              context.stub(:user).and_return(double :id => i)
+              context.stub(:user_id).and_return(i)
+              feature.active_user?(context).should be_true
+            end
+          end
+
+          [200,231,17,199,1018].each do |i|
+            it "should be true" do
+              feature.users_rate = 13
+              context.stub(:user).and_return(double :id => i)
+              context.stub(:user_id).and_return(i)
+              feature.active_user?(context).should be_false
+            end
+          end
+        end
+      end
+    end
+
+    describe "active_visitor?" do
+      it "should be false if rate is 0" do
+        feature.visitors_rate = 0
+        feature.active_visitor?(context).should be_false
+      end
+      it "should be true if rate is 100" do
+        feature.visitors_rate = 100
+        feature.active_visitor?(context).should be_true
+      end
+
+      describe "by visitor_id modulus" do
+        [212,201,1,113,1008].each do |i|
+          it "should be true" do
+            feature.visitors_rate = 13
+            context.stub(:visitor_id).and_return(i)
+            feature.active_visitor?(context).should be_true
+          end
+        end
+
+        [200,231,17,199,1018].each do |i|
+          it "should be true" do
+            feature.visitors_rate = 13
+            context.stub(:visitor_id).and_return(i)
+            feature.active_visitor?(context).should be_false
+          end
+        end
+      end
+    end
+
+    describe "active_segment?" do
+      it "should be false if there are no group segments" do
+          feature.active_segment?(context).should be_false
+      end
+      context "with group segments" do
+        before :each do
+          @group_a = Group.create(:a)
+          @group_b = Group.create(:b)
+          feature.set_segments_for(:a, ["on"])
+          feature.set_segments_for(:b, ["monkey", "chimp"])
+          feature.save
+          Group.stub(:find).with("a").and_return(@group_a)
+          Group.stub(:find).with("b").and_return(@group_b)
+        end
+
+        it "should be false if user is in no group segments" do
+          @group_a.should_receive(:segment_for).with(context).and_return(nil)
+          @group_b.should_receive(:segment_for).with(context).and_return("babboon")
+          feature.active_segment?(context).should be_false
+        end
+
+        it "should be true if user is in any group segment" do
+          @group_a.stub(:segment_for).with(context).and_return(nil)
+          @group_b.stub(:segment_for).with(context).and_return("monkey")
+          feature.active_segment?(context).should be_true
+        end
+
+      end
+    end
+
+    describe "id_to_int" do
+      it "should return an integer given an integer" do
+        feature.id_to_int(20).should eq(20)
+      end
+      it "should return an integer given a string" do
+        feature.id_to_int("happy").should be_a(Integer)
+        feature.id_to_int("monday").should be_a(Integer)
+      end
+      it "should return a different int for each string (last 8 chars)" do
+        feature.id_to_int("happy").should_not == feature.id_to_int("monday")
+      end
+    end
+
+  end
+end

data/spec/feature_spec.rb

@@ -0,0 +1,58 @@
+require File.expand_path(File.dirname(__FILE__) + '/spec_helper')
+
+module Blackbeard
+  describe Feature do
+    let(:feature){ Blackbeard::Feature.create('example') }
+
+    describe "segments_for and set_segments_for" do
+      it "should return an empty list if no segments" do
+        feature.segments_for(:nothing).should == []
+      end
+
+      it "should return the segments for the group" do
+        feature.set_segments_for(:hello, ["world", "goodbye"])
+        feature.set_segments_for(:foo, "bar")
+        feature.segments_for(:hello).should include("world","goodbye")
+        feature.segments_for(:hello).should_not include("bar")
+        feature.segments_for(:foo).should == ["bar"]
+      end
+    end
+
+    describe "#active_for?" do
+      let(:context){ double }
+
+      context "when status is nil" do
+        it "should be false" do
+          feature.active_for?(context).should be_false
+        end
+      end
+
+      context "when status is inactive" do
+        it "should be false" do
+          feature.status = :inactive
+          feature.active_for?(context).should be_false
+        end
+      end
+
+      context "when status is active" do
+        it "should be true" do
+          feature.status = :active
+          feature.active_for?(context).should be_true
+        end
+      end
+
+      context "when status is 'rollout'" do
+        it "should defer to rollout?" do
+          rollout_result = double
+          feature.status = :rollout
+          feature.should_receive(:rollout?).with(context).and_return(rollout_result)
+          feature.active_for?(context).should be(rollout_result)
+        end
+      end
+
+
+    end
+
+
+  end
+end