bitex 0.3 → 0.4.0

data/spec/support/order_shared_examples.rb

@@ -1,39 +1,36 @@
 shared_examples_for 'Order' do |api_path|
   it 'lists all' do
-    stub_private(:get, "/private/orders", 'orders')
+    stub_private(:get, '/private/orders', 'orders')
     order, empty = subject.class.all
     order.should be_a subject.class
     empty.should be_nil
   end
-  
+
   it 'gets one' do
     stub_private(:get, "/private/#{api_path}/12345678", "#{api_path}_show")
-    order = subject.class.find(12345678)
+    order = subject.class.find(12_345_678)
     order.should be_a subject.class
-    order.id.should == 12345678
+    order.id.should == 12_345_678
   end
-  
-  it 'places for btc' do
-    stub_private(:post, "/private/#{api_path}", "#{api_path}_create",
-      {amount: 100.50, price: 1000.00, specie: 1})
-    order = subject.class.create!(:btc, 100.50, 1000.00)
+
+  it 'places for btc_usd' do
+    stub_private(:post, "/private/#{api_path}", "#{api_path}_create", { amount: 100.50, price: 1000.00, orderbook: 1 })
+    order = subject.class.create!(:btc_usd, 100.50, 1_000.00)
     order.should be_a subject.class
     order.status.should == :received
   end
 
-  it 'places for btc and waits until processed by our matching engine' do
-    stub_private(:post, "/private/#{api_path}", "#{api_path}_create",
-      {amount: 100.50, price: 1000.00, specie: 1})
+  it 'places for btc_usd and waits until processed by our matching engine' do
+    stub_private(:post, "/private/#{api_path}", "#{api_path}_create", { amount: 100.50, price: 1_000.00, orderbook: 1})
     stub_private(:get, "/private/#{api_path}/12345678", "#{api_path}_show")
-    order = subject.class.create!(:btc, 100.50, 1000.00, true)
+    order = subject.class.create!(:btc_usd, 100.50, 1_000.00, true)
     order.should be_a subject.class
     order.status.should == :executing
   end
-  
+
   it 'cancels one' do
-    stub_private(:post, "/private/#{api_path}", "#{api_path}_create",
-      {amount: 100.50, price: 1000.00, specie: 1})
-    order = subject.class.create!(:btc, 100.50, 1000.00)
+    stub_private(:post, "/private/#{api_path}", "#{api_path}_create", { amount: 100.50, price: 1_000.00, orderbook: 1})
+    order = subject.class.create!(:btc_usd, 100.50, 1_000.00)
     stub_private(:post, "/private/#{api_path}/#{order.id}/cancel", "#{api_path}_cancel")
     order.cancel!
     order.status.should == :cancelling

data/spec/support/request_stubs.rb

@@ -1,25 +1,31 @@
 require 'open-uri'
+
 module RequestStubs
   def stub_get(path, fixture)
     stub_api(:get, path, fixture, {})
   end
-  
+
   def stub_private(method, path, fixture, options = {})
     options[:api_key] = 'valid_api_key'
     stub_api(method, path, fixture, options)
   end
-  
+
   def stub_api(method, path, fixture, options)
-    fixture_path = File.expand_path("../../fixtures/#{fixture}.json", __FILE__)
-    with = if method == :get
-      {query: options}
-    elsif method == :put
-      {body: options.to_query }
-    else
-      {body: options.collect{|k,v| "#{k}=#{CGI.escape(v.to_s).gsub('+','%20')}"}* '&' }
-    end
+    params =
+      if method == :get
+        { query: options }
+      elsif method == :put
+        { body: options.to_query }
+      else
+        { body: options.map { |k, v| "#{k}=#{CGI.escape(v.to_s).gsub('+', '%20')}" } * '&' }
+      end
+
     stub_request(method, "https://bitex.la/api-v1/rest#{path}")
-      .with(with)
-      .to_return(status: 200, body: File.read(fixture_path))
+      .with(params)
+      .to_return(status: 200, body: File.read(fixture_path(fixture)))
+  end
+
+  def fixture_path(filename)
+    File.expand_path("../../fixtures/#{filename}.json", __FILE__)
   end
 end

data/spec/trade_spec.rb

@@ -1,13 +1,13 @@
 require 'spec_helper'
 
 describe Bitex::Trade do
-  before(:each) do
-    Bitex.api_key = 'valid_api_key'
-  end
-  
+  before(:each) { Bitex.api_key = 'valid_api_key' }
+
   it 'gets all trades' do
-    stub_private(:get, "/private/trades", 'trades')
+    stub_private(:get, '/private/trades', :trades)
+
     buy, sell, other = Bitex::Trade.all
+
     buy.should be_a Bitex::Buy
     sell.should be_a Bitex::Sell
     other.should be_nil

data/spec/transaction_spec.rb

@@ -1,19 +1,18 @@
 require 'spec_helper'
 
 describe Bitex::Transaction do
-  before(:each) do
-    Bitex.api_key = 'valid_api_key'
-  end
-  
+  before(:each) { Bitex.api_key = 'valid_api_key' }
+
   it 'gets account summary' do
-    stub_private(:get, "/private/account_summary", 'account_summary')
-    buy, sell, specie_deposit, specie_withdrawal, usd_deposit, usd_withdrawal =
-      Bitex::Transaction.all
-    buy.should be_a Bitex::Bid
-    sell.should be_a Bitex::Ask
-    specie_deposit.should be_a Bitex::SpecieDeposit
-    specie_withdrawal.should be_a Bitex::SpecieWithdrawal
-    usd_deposit.should be_a Bitex::UsdDeposit
-    usd_withdrawal.should be_a Bitex::UsdWithdrawal
+    stub_private(:get, '/private/account_summary', :account_summary)
+
+    buy, sell, specie_deposit, specie_withdrawal, usd_deposit, usd_withdrawal = Bitex::Transaction.all
+
+    buy.should be_an Bitex::Bid
+    sell.should be_an Bitex::Ask
+    specie_deposit.should be_an Bitex::SpecieDeposit
+    specie_withdrawal.should be_an Bitex::SpecieWithdrawal
+    usd_deposit.should be_an Bitex::UsdDeposit
+    usd_withdrawal.should be_an Bitex::UsdWithdrawal
   end
 end

data/spec/usd_deposit_spec.rb

@@ -1,124 +1,139 @@
 require 'spec_helper'
 
 describe Bitex::UsdDeposit do
-  before :each do 
-    Bitex.api_key = 'valid_api_key'
-  end
+  before(:each) { Bitex.api_key = 'valid_api_key' }
+
+  let(:api_class_id) { 7 }
+  let(:id) { 12_345_678 }
+  let(:created_at) { 946_685_400 }
+  let(:requested_amount) { 110.0 }
+  let(:amount) { 100.0 }
+  let(:deposit_method) { 1 }
+  let(:status) { 1 }
+  let(:reason) { 0 }
+  let(:country) { 'UY' }
+  let(:currency) { 'UYU' }
+  let(:kyc_profile_id) { 1 }
+  let(:request_details) { 'bank of new york mellon' }
+  let(:astropay_response_body) { { 'status' => 'OK', 'link' => 'https://astr.com' } }
+  let(:third_party_reference) { 'REFERENCE' }
 
   let(:as_json) do
-    [ 7,12345678,946685400,110.0000000, 100.00000000,1,1,0,
-      'UY', 'UYU', 1, 'bank of new york mellon',
-      {"status" => "OK","link" => "https://astr.com"}, 'ABABABABA']
+    [api_class_id, id, created_at, requested_amount, amount, deposit_method, status, reason, country,
+     currency, kyc_profile_id, request_details, astropay_response_body, third_party_reference]
   end
 
   it_behaves_like 'API class'
 
-  it "sets amount as BigDecimal" do
-    thing = Bitex::UsdDeposit.from_json(as_json).amount
-    thing.should be_a BigDecimal
-    thing.should == 100.0
-  end
+  context 'deserializing from json' do
+    let(:deposit) { Bitex::UsdDeposit.from_json(as_json) }
 
-  it "sets amount as BigDecimal" do
-    thing = Bitex::UsdDeposit.from_json(as_json).requested_amount
-    thing.should be_a BigDecimal
-    thing.should == 110.0
-  end
-  
-  it "sets country" do
-    Bitex::UsdDeposit.from_json(as_json).country.should == 'UY'
-  end
-  
-  it "sets currency" do
-    Bitex::UsdDeposit.from_json(as_json).currency.should == 'UYU'
-  end
-  
-  it "sets kyc profile" do
-    Bitex::UsdDeposit.from_json(as_json).kyc_profile_id.should == 1
-  end
-  
-  it "sets details" do
-    Bitex::UsdDeposit.from_json(as_json).request_details.should ==
-      'bank of new york mellon'
-  end
-  
-  it "sets the astropay_response_body" do
-    Bitex::UsdDeposit.from_json(as_json).astropay_response_body.should ==
-      {"status" => "OK","link" => "https://astr.com"}
-  end
+    it 'sets amount as BigDecimal' do
+      deposit.amount.should be_an BigDecimal
+      deposit.amount.should eq amount
+    end
 
-  it "sets the third party reference" do
-    Bitex::UsdDeposit.from_json(as_json).third_party_reference.should == 'ABABABABA'
-  end
+    it 'sets requested amount as BigDecimal' do
+      deposit.requested_amount.should be_an BigDecimal
+      deposit.requested_amount.should eq requested_amount
+    end
 
-  { 1 => :astropay,
-    2 => :other,
-  }.each do |code, symbol|
-    it "sets status #{code} to #{symbol}" do
-      as_json[5] = code
-      Bitex::UsdDeposit.from_json(as_json).deposit_method.should == symbol
+    it 'sets country' do
+      deposit.country.should be_an String
+      deposit.country.should eq country
     end
-  end
 
-  { 1 => :pending,
-    2 => :done,
-    3 => :cancelled,
-  }.each do |code, symbol|
-    it "sets status #{code} to #{symbol}" do
-      as_json[6] = code
-      Bitex::UsdDeposit.from_json(as_json).status.should == symbol
+    it 'sets currency' do
+      deposit.currency.should be_an String
+      deposit.currency.should eq currency
     end
-  end
 
-  { 0 => :not_cancelled,
-    1 => :did_not_credit,
-    2 => :sender_unknown,
-    3 => :other,
-    4 => :user_cancelled,
-  }.each do |code, symbol|
-    it "sets reason #{code} to #{symbol}" do
-      as_json[7] = code
-      Bitex::UsdDeposit.from_json(as_json).reason.should == symbol
+    it 'sets kyc profile' do
+      deposit.kyc_profile_id.should be_an Integer
+      deposit.kyc_profile_id.should be kyc_profile_id
+    end
+
+    it 'sets details' do
+      deposit.request_details.should be_an String
+      deposit.request_details.should eq request_details
+    end
+
+    it 'sets the astropay_response_body' do
+      deposit.astropay_response_body.should be_an Hash
+      deposit.astropay_response_body.keys.all? { |key| key.should be_an String }
+      deposit.astropay_response_body.values.all? { |value| value.should be_an String }
+      deposit.astropay_response_body.should eq astropay_response_body
+    end
+
+    it 'sets the third party reference' do
+      deposit.third_party_reference.should be_an String
+      deposit.third_party_reference.should eq third_party_reference
+    end
+
+    Bitex::UsdDeposit.deposit_methods.each do |code, deposit_method|
+      it "sets deposit_method #{code} to #{deposit_method}" do
+        as_json[5] = code
+        deposit.deposit_method.should be deposit_method
+      end
+    end
+
+    Bitex::UsdDeposit.statuses.each do |code, status|
+      it "sets status #{code} to #{status}" do
+        as_json[6] = code
+        deposit.status.should be status
+      end
+    end
+
+    Bitex::UsdDeposit.reasons.each do |code, reason|
+      it "sets reason #{code} to #{reason}" do
+        as_json[7] = code
+        deposit.reason.should be reason
+      end
+    end
+
+    it 'creates a new deposit' do
+      stub_private(
+        :post,
+        '/private/usd/deposits',
+        :usd_deposit,
+        country: country, amount: amount, currency: currency, deposit_method: deposit_method, request_details: request_details
+      )
+
+      deposit = Bitex::UsdDeposit.create!(country, amount, currency, deposit_method, request_details)
+
+      deposit.should be_an Bitex::UsdDeposit
+      deposit.astropay_response_body.should be_an Hash
+      deposit.status.should be :pending
+    end
+
+    it 'finds a single usd deposit' do
+      stub_private(:get, "/private/usd/deposits/#{id}", :usd_deposit)
+
+      deposit = Bitex::UsdDeposit.find(id)
+
+      deposit.should be_an Bitex::UsdDeposit
+      deposit.status.should be :pending
+    end
+
+    it 'cancels a deposit' do
+      stub_private(:get, "/private/usd/deposits/#{id}", :usd_deposit)
+      stub_private(:post, "/private/usd/deposits/#{id}/cancel", :cancelled_usd_deposit)
+
+      deposit = Bitex::UsdDeposit.find(id).cancel!
+
+      deposit.should be_an Bitex::UsdDeposit
+      deposit.status.should be :cancelled
+      deposit.reason.should be :user_cancelled
+    end
+
+    it 'lists all usd deposits' do
+      stub_private(:get, '/private/usd/deposits', :usd_deposits)
+
+      deposits = Bitex::UsdDeposit.all
+
+      deposits.should be_an Array
+      deposits.all? { |deposit| deposit.should be_an Bitex::UsdDeposit }
+      deposits.all? { |deposit| deposit.status.should be :pending }
     end
-  end
-  
-  it 'creates a new deposit' do
-    stub_private(:post, "/private/usd/deposits", 'usd_deposit', {
-      country: 'UY',
-      amount: 110,
-      currency: 'UYU',
-      deposit_method: 'astropay',
-      request_details: 'bank of new york mellon',
-    })
-    deposit = Bitex::UsdDeposit.create!('UY', 110, 'UYU', 'astropay',
-      'bank of new york mellon') 
-    deposit.should be_a Bitex::UsdDeposit
-    deposit.astropay_response_body.should be_a Hash
-    deposit.status.should == :pending
-  end
-  
-  it 'finds a single usd deposit' do
-    stub_private(:get, '/private/usd/deposits/1', 'usd_deposit')
-    deposit = Bitex::UsdDeposit.find(1)
-    deposit.should be_a Bitex::UsdDeposit
-    deposit.status.should == :pending
-  end
-  
-  it 'cancels a deposit' do
-    stub_private(:get, '/private/usd/deposits/12345678', 'usd_deposit')
-    stub_private(:post, '/private/usd/deposits/12345678/cancel', 'cancelled_usd_deposit')
-    deposit = Bitex::UsdDeposit.find(12345678)
-    deposit.cancel!
-    deposit.should be_a Bitex::UsdDeposit
-    deposit.status.should == :cancelled
-    deposit.reason.should == :user_cancelled
-  end
-  
-  it 'lists all usd deposits' do
-    stub_private(:get, '/private/usd/deposits', 'usd_deposits')
-    deposits = Bitex::UsdDeposit.all
-    deposits.should be_an Array
-    deposits.first.should be_an Bitex::UsdDeposit
-    deposits.first.status.should == :pending
   end
 end

data/spec/usd_withdrawal_spec.rb

@@ -1,101 +1,111 @@
 require 'spec_helper'
 
 describe Bitex::UsdWithdrawal do
-  before :each do 
-    Bitex.api_key = 'valid_api_key'
-  end
+  before(:each) { Bitex.api_key = 'valid_api_key' }
+
+  let(:api_class_id) { 8 }
+  let(:id) { 12_345_678 }
+  let(:created_at) { 946_685_400 }
+  let(:amount) { 100.0 }
+  let(:status) { 1 }
+  let(:reason) { 0 }
+  let(:country) { 'UY' }
+  let(:currency) { 'UYU' }
+  let(:payment_method) { 1 }
+  let(:label) { 'billy bob' }
+  let(:kyc_profile_id) { 1 }
+  let(:instructions) { 'instructions' }
 
   let(:as_json) do
-    [8,12345678,946685400,100.00000000,1,0,'UY','UYU', 'bb', 'billy bob', 1, 'las instrucciones']
+    [api_class_id, id, created_at, amount, status, reason, country, currency, payment_method, label, kyc_profile_id, instructions]
   end
 
   it_behaves_like 'API class'
 
-  it "sets amount as BigDecimal" do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).amount
-    thing.should be_a BigDecimal
-    thing.should == 100.0
-  end
+  context 'Deserializing from json' do
+    let(:withdrawal) { Bitex::UsdWithdrawal.from_json(as_json) }
 
-  it 'sets country' do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).country
-    thing.should == 'UY'
-  end
+    it 'sets amount as BigDecimal' do
+      withdrawal.amount.should be_an BigDecimal
+      withdrawal.amount.should eq amount
+    end
 
-  it 'sets currency' do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).currency
-    thing.should == 'UYU'
-  end
+    it 'sets country' do
+      withdrawal.country.should be_an String
+      withdrawal.country.should eq country
+    end
 
-  it 'sets payment method' do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).payment_method
-    thing.should == 'bb'
-  end
+    it 'sets currency' do
+      withdrawal.currency.should be_an String
+      withdrawal.currency.should eq currency
+    end
 
-  it 'sets label' do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).label
-    thing.should == 'billy bob'
-  end
+    it 'sets payment method' do
+      withdrawal.payment_method.should be_an Symbol
+      withdrawal.payment_method.should be Bitex::UsdWithdrawal.payment_methods[payment_method]
+    end
 
-  it 'sets kyc profile id' do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).kyc_profile_id
-    thing.should == 1
-  end
+    it 'sets label' do
+      withdrawal.label.should be_an String
+      withdrawal.label.should eq label
+    end
 
-  it 'sets instructions' do
-    thing = Bitex::UsdWithdrawal.from_json(as_json).instructions
-    thing.should == 'las instrucciones'
-  end
+    it 'sets kyc profile id' do
+      withdrawal.kyc_profile_id.should be_an Integer
+      withdrawal.kyc_profile_id.should be kyc_profile_id
+    end
 
-  { 1 => :received,
-    2 => :pending,
-    3 => :done,
-    4 => :cancelled,
-  }.each do |code, symbol|
-    it "sets status #{code} to #{symbol}" do
-      as_json[4] = code
-      Bitex::UsdWithdrawal.from_json(as_json).status.should == symbol
+    it 'sets instructions' do
+      withdrawal.instructions.should be_an String
+      withdrawal.instructions.should eq instructions
     end
-  end
 
-  { 0 => :not_cancelled,
-    1 => :insufficient_funds,
-    2 => :no_instructions,
-    3 => :recipient_unknown,
-  }.each do |code, symbol|
-    it "sets reason #{code} to #{symbol}" do
-      as_json[5] = code
-      Bitex::UsdWithdrawal.from_json(as_json).reason.should == symbol
+    Bitex::UsdWithdrawal.statuses.each do |code, status|
+      it "sets status #{code} to #{status}" do
+        as_json[4] = code
+        withdrawal.status.should be status
+      end
     end
-  end
 
-  it 'creates a new withdrawal' do
-    stub_private(:post, "/private/usd/withdrawals", 'usd_withdrawal', {
-      country: 'UY',
-      amount: 110,
-      currency: 'UYU',
-      payment_method: 'bb',
-      instructions: 'bank of new york mellon',
-      label: 'a label',
-    })
-    deposit = Bitex::UsdWithdrawal.create!('UY', 110, 'UYU', 'bb',
-      'bank of new york mellon', 'a label') 
-    deposit.should be_a Bitex::UsdWithdrawal
-    deposit.status.should == :received
-  end
-  
-  it 'finds a single usd deposit' do
-    stub_private(:get, '/private/usd/withdrawals/1', 'usd_withdrawal')
-    deposit = Bitex::UsdWithdrawal.find(1)
-    deposit.should be_a Bitex::UsdWithdrawal
-    deposit.status.should == :received
-  end
-  
-  it 'lists all usd deposits' do
-    stub_private(:get, '/private/usd/withdrawals', 'usd_withdrawals')
-    deposits = Bitex::UsdWithdrawal.all
-    deposits.should be_an Array
-    deposits.first.should be_an Bitex::UsdWithdrawal
-    deposits.first.status.should == :received
+    Bitex::UsdWithdrawal.reasons.each do |code, reason|
+      it "sets reason #{code} to #{reason}" do
+        as_json[5] = code
+        withdrawal.reason.should be reason
+      end
+    end
+
+    it 'creates a new withdrawal' do
+      stub_private(
+        :post,
+        '/private/usd/withdrawals',
+        :usd_withdrawal,
+        country: country, amount: amount, currency: currency, payment_method: payment_method, instructions: instructions,
+        label: label
+      )
+
+      withdrawal = Bitex::UsdWithdrawal.create!(country, amount, currency, payment_method, instructions, label)
+
+      withdrawal.should be_an Bitex::UsdWithdrawal
+      withdrawal.status.should == :received
+    end
+
+    it 'finds a single usd withdrawal' do
+      stub_private(:get, "/private/usd/withdrawals/#{id}", :usd_withdrawal)
+
+      withdrawal = Bitex::UsdWithdrawal.find(id)
+
+      withdrawal.should be_an Bitex::UsdWithdrawal
+      withdrawal.status.should == :received
+    end
+
+    it 'lists all usd withdrawals' do
+      stub_private(:get, '/private/usd/withdrawals', :usd_withdrawals)
+
+      withdrawals = Bitex::UsdWithdrawal.all
+
+      withdrawals.should be_an Array
+      withdrawals.all? { |withdrawal| withdrawal.should be_an Bitex::UsdWithdrawal }
+      withdrawals.all? { |withdrawal| withdrawal.status.should be :received }
+    end
   end
 end