bitex 0.3 → 0.4.0

data/spec/order_spec.rb

@@ -6,7 +6,7 @@ describe Bitex::Order do
   end
 
   it 'gets all orders' do
-    stub_private(:get, "/private/orders", 'orders')
+    stub_private(:get, '/private/orders', 'orders')
     bid, ask, empty = Bitex::Order.all
     bid.should be_a Bitex::Bid
     ask.should be_a Bitex::Ask

data/spec/payment_spec.rb

@@ -1,21 +1,19 @@
 require 'spec_helper'
 
 describe Bitex::Payment do
-  before :each do 
-    Bitex.api_key = 'valid_api_key'
-  end
+  before(:each) { Bitex.api_key = 'valid_api_key' }
 
   let(:params_for_create) do
     {
       currency_id: 3,
       amount: 1000,
-      callback_url: "https://example.com/ipn",
+      callback_url: 'https://example.com/ipn',
       keep: 25.0,
-      customer_reference: "An Alto latte, no sugar",
-      merchant_reference: "invoice#1234",
+      customer_reference: 'An Alto latte, no sugar',
+      merchant_reference: 'invoice#1234'
     }
   end
-  
+
   let(:as_json) do
     {
       id: 1,
@@ -29,21 +27,23 @@ describe Bitex::Payment do
       valid_until:  1430226201,
       quote_valid_until:  1430226201,
       last_quoted_on: 1430220201,
-      status: "pending",
-      address: { 
-        "id": 4,
-        "public_address": "1ABC...",
+      status: 'pending',
+      address: {
+        'id': 4,
+        'public_address': '1ABC...',
       },
       settlement_currency_id: 2,
       settlement_amount:  100,
       keep: 1.5,
-      merchant_reference: "Invoice#1234",
-      customer_reference: "Frappuchino",
+      merchant_reference: 'Invoice#1234',
+      customer_reference: 'Frappuchino',
     }
   end
-  
+
+  let(:as_malformed_json) { { bad_key: 'i should not be setted' } }
+
   let(:callback_params) do
-    { "api_key" => 'valid_api_key', "payment" => as_json}
+    { 'api_key' => 'valid_api_key', 'payment' => as_json }
   end
 
   {
@@ -56,64 +56,70 @@ describe Bitex::Payment do
     confirmed_quantity: 0.0,
     unconfirmed_quantity: 0.0,
     valid_until:  Time.at(1430226201),
-    quote_valid_until:  Time.at(1430226201),
-    last_quoted_on: Time.at(1430220201),
-    status: "pending",
-    address: { 
-      "id": 4,
-      "public_address": "1ABC...",
+    quote_valid_until:  Time.at(1_430_226_201),
+    last_quoted_on: Time.at(1_430_220_201),
+    status: 'pending',
+    address: {
+      'id': 4,
+      'public_address': '1ABC...',
     },
     settlement_currency_id: 2,
     settlement_amount:  100,
     keep: 1.5,
-    merchant_reference: "Invoice#1234",
-    customer_reference: "Frappuchino",
+    merchant_reference: 'Invoice#1234',
+    customer_reference: 'Frappuchino'
   }.each do |field, value|
-    it "sets #{field}" do
-      subject.class.from_json(as_json).send(field).should == value
+      it "sets #{field}" do
+        subject.class.from_json(as_json).send(field).should eq value
+      end
+
+      it "not sets #{field}" do
+        subject.class.from_json(as_malformed_json).send(field).should be_nil
+      end
     end
-  end
 
   it 'creates a new payment' do
-    stub_private(:post, "/private/payments", 'payment',
-      params_for_create)
-    Bitex::Payment.create!(params_for_create)
-      .should be_a Bitex::Payment
+    stub_private(:post, '/private/payments', 'payment', params_for_create)
+
+    Bitex::Payment.create!(params_for_create).should be_a Bitex::Payment
   end
-  
+
   it 'finds a single payment' do
     stub_private(:get, '/private/payments/1', 'payment')
+
     Bitex::Payment.find(1).should be_a Bitex::Payment
   end
-  
+
   it 'lists all payments' do
     stub_private(:get, '/private/payments', 'payments')
+
     payments = Bitex::Payment.all
+
     payments.should be_an Array
-    payments.first.should be_a Bitex::Payment
+    payments.all? { |payment| payment.should be_a Bitex::Payment }
   end
-  
+
   it 'accepts a callback' do
     Bitex::Payment
       .from_callback(callback_params)
       .should be_a Bitex::Payment
   end
-  
+
   it 'raises exception if invalid api key' do
     Bitex::Payment
-      .from_callback(callback_params.merge("api_key" => 'bogus'))
+      .from_callback(callback_params.merge('api_key' => 'bogus'))
       .should be_nil
   end
-  
+
   it 'configures store' do
-    pos_params = {  
-      "merchant_name" => "Tierra Buena",
-      "merchant_slug" => "tierrabuena",
-      "merchant_logo" => "https://t.co/logo.png",
-      "merchant_keep" => 0,
+    pos_params = {
+      'merchant_name' => 'Tierra Buena',
+      'merchant_slug' => 'tierrabuena',
+      'merchant_logo' => 'https://t.co/logo.png',
+      'merchant_keep' => 0
     }
-    stub_private(:post, "/private/payments/pos_setup", 'pos_setup', pos_params.dup)
-    Bitex::Payment.pos_setup!(pos_params)
-      .should == pos_params
+    stub_private(:post, '/private/payments/pos_setup', 'pos_setup', pos_params.dup)
+
+    Bitex::Payment.pos_setup!(pos_params).should == pos_params
   end
 end

data/spec/sell_spec.rb

@@ -2,14 +2,24 @@ require 'spec_helper'
 
 describe Bitex::Sell do
   let(:as_json) do
-    [3,12345678,946685400,1,100.50000000,201.0000000,0.05000000,2.00000000,123]
+    [
+      3,          #  0 - API class reference
+      12_345_678, #  1 - id
+      946685400,  #  2 - created_at
+      1,          #  3 - orderbook
+      100.5,      #  4 - quantity
+      201,        #  5 - amount
+      0.05,       #  6 - fee
+      2,          #  7 - price
+      123         #  8 - ask_id
+    ]
   end
-  
+
   it_behaves_like 'API class'
-  it_behaves_like 'API class with a specie'
+  it_behaves_like 'API class with a orderbook'
   it_behaves_like 'JSON deserializable match'
 
-  it "sets the ask id" do
+  it 'sets the ask id' do
     thing = subject.class.from_json(as_json).ask_id
     thing.should == 123
   end

data/spec/spec_helper.rb

@@ -2,27 +2,28 @@ require 'bundler/setup'
 Bundler.setup
 
 require 'bitex'
+require 'byebug'
 require 'webmock/rspec'
 require 'shoulda/matchers'
 require 'timecop'
 
-Dir[File.expand_path("../support/**/*.rb", __FILE__)].each {|f| require f}
+Dir[File.expand_path('support/**/*.rb', __dir__)].each { |f| require f }
 
 RSpec.configure do |config|
   config.include RequestStubs
 
   config.mock_with :rspec do |mocks|
     mocks.yield_receiver_to_any_instance_implementation_blocks = true
-    mocks.syntax = [:expect, :should]
+    mocks.syntax = %i[expect should]
   end
+
   config.expect_with :rspec do |c|
-    c.syntax = [:expect, :should]
+    c.syntax = %i[expect should]
   end
-  
+
   config.after(:each) do
     Timecop.return
   end
 
-  config.order = "random"
+  config.order = 'random'
 end
-

data/spec/specie_deposit_spec.rb

@@ -1,18 +1,24 @@
 require 'spec_helper'
 
 describe Bitex::SpecieDeposit do
-  before :each do 
+  before :each do
     Bitex.api_key = 'valid_api_key'
   end
 
   let(:as_json) do
-    [5,12345678,946685400,1,100.50000000]
+    [
+      5,          # 0 - API class reference
+      12_345_678, # 1 - id
+      9_466_854,  # 2 - created_at
+      1,          # 3 - specie { 0 => :btc }
+      100.5       # 4 - quantity
+    ]
   end
 
   it_behaves_like 'API class'
   it_behaves_like 'API class with a specie'
 
-  it "sets quantity as BigDecimal" do
+  it 'sets quantity as BigDecimal' do
     thing = Bitex::SpecieDeposit.from_json(as_json).quantity
     thing.should be_a BigDecimal
     thing.should == 100.5
@@ -24,7 +30,7 @@ describe Bitex::SpecieDeposit do
     deposit.should be_a Bitex::SpecieDeposit
     deposit.specie.should == :btc
   end
-  
+
   it 'lists all btc deposits' do
     stub_private(:get, '/private/btc/deposits', 'specie_deposits')
     deposits = Bitex::SpecieDeposit.all(:btc)

data/spec/specie_withdrawal_spec.rb

@@ -1,81 +1,82 @@
 require 'spec_helper'
 
 describe Bitex::SpecieWithdrawal do
-  before :each do 
+  before :each do
     Bitex.api_key = 'valid_api_key'
   end
 
   let(:as_json) do
-    [6,12345678,946685400,1,100.00000000,1,0, '1helloworld', 'label', 1, 'ABC1']
+    [
+      6,             #  0 - API class reference
+      12_345_678,    #  1 - id
+      946_685_400,   #  2 - created_at
+      1,             #  3 - specie { 0 => :btc }
+      100.0,         #  4 - quantity
+      1,             #  5 - status { 1 => :received, 2 => :pending, 3 => :done, 4 => :cancelled }
+      0,             #  6 - reason { 0 => :not_cancelled, 1 => :insufficient_funds, 2 => :destination_invalid }
+      '1helloworld', #  7 - to_address
+      'label',       #  8 - label
+      1,             #  9 - kyc_profile_id
+      'ABC1'         # 10 - transaction_id
+    ]
   end
 
   it_behaves_like 'API class'
   it_behaves_like 'API class with a specie'
 
-  it "sets quantity as BigDecimal" do
+  it 'sets quantity as BigDecimal' do
     thing = Bitex::SpecieWithdrawal.from_json(as_json).quantity
     thing.should be_a BigDecimal
     thing.should == 100.0
   end
 
-  { 1 => :received,
-    2 => :pending,
-    3 => :done,
-    4 => :cancelled,
-  }.each do |code, symbol|
+  Bitex::SpecieWithdrawal.statuses.each do |code, symbol|
     it "sets status #{code} to #{symbol}" do
       as_json[5] = code
       Bitex::SpecieWithdrawal.from_json(as_json).status.should == symbol
     end
   end
 
-  { 0 => :not_cancelled,
-    1 => :insufficient_funds,
-    2 => :destination_invalid,
-  }.each do |code, symbol|
+  Bitex::SpecieWithdrawal.reasons.each do |code, symbol|
     it "sets reason #{code} to #{symbol}" do
       as_json[6] = code
       Bitex::SpecieWithdrawal.from_json(as_json).reason.should == symbol
     end
   end
 
-  it "sets label" do
+  it 'sets label' do
     thing = Bitex::SpecieWithdrawal.from_json(as_json).label
     thing.should == 'label'
   end
 
-  it "sets to_address" do
+  it 'sets to_address' do
     thing = Bitex::SpecieWithdrawal.from_json(as_json).to_address
-    thing.should == "1helloworld"
+    thing.should == '1helloworld'
   end
 
-  it "sets transaction id" do
+  it 'sets transaction id' do
     thing = Bitex::SpecieWithdrawal.from_json(as_json).transaction_id
-    thing.should == "ABC1"
+    thing.should == 'ABC1'
   end
 
-  it "sets the kyc profile id" do
+  it 'sets the kyc profile id' do
     Bitex::SpecieWithdrawal.from_json(as_json).kyc_profile_id.should == 1
   end
 
   it 'creates a new withdrawal' do
-    stub_private(:post, "/private/btc/withdrawals", 'specie_withdrawal', {
-      address: '1ADDR',
-      amount: 110,
-      label: 'thelabel',
-    })
+    stub_private(:post, '/private/btc/withdrawals', 'specie_withdrawal', address: '1ADDR', amount: 110, label: 'thelabel')
     withdrawal = Bitex::SpecieWithdrawal.create!(:btc, '1ADDR', 110, 'thelabel')
     withdrawal.should be_a Bitex::SpecieWithdrawal
     withdrawal.status.should == :received
   end
-  
+
   it 'finds a single usd deposit' do
     stub_private(:get, '/private/btc/withdrawals/1', 'specie_withdrawal')
     deposit = Bitex::SpecieWithdrawal.find(:btc, 1)
     deposit.should be_a Bitex::SpecieWithdrawal
     deposit.status.should == :received
   end
-  
+
   it 'lists all usd deposits' do
     stub_private(:get, '/private/btc/withdrawals', 'specie_withdrawals')
     deposits = Bitex::SpecieWithdrawal.all(:btc)

data/spec/support/from_json_shared_examples.rb

@@ -1,7 +1,7 @@
 shared_examples_for 'API class' do
   it 'stores the unique id' do
-    as_json[1] = 12345678
-    subject.class.from_json(as_json).id.should == 12345678
+    as_json[1] = 12_345_678
+    subject.class.from_json(as_json).id.should == 12_345_678
   end
 
   it 'makes creation times into Time' do
@@ -9,16 +9,23 @@ shared_examples_for 'API class' do
   end
 end
 
+shared_examples_for 'API class with a orderbook' do
+  it 'makes orderbook 1 into btc_usd' do
+    as_json[3] = 1
+    subject.class.from_json(as_json).orderbook.should == :btc_usd
+  end
+
+  it 'makes specie 5 into btc_ars' do
+    as_json[3] = 5
+    subject.class.from_json(as_json).orderbook.should == :btc_ars
+  end
+end
+
 shared_examples_for 'API class with a specie' do
   it 'makes specie 1 into btc' do
     as_json[3] = 1
     subject.class.from_json(as_json).specie.should == :btc
   end
-
-  it 'makes specie 2 into ltc' do
-    as_json[3] = 2
-    subject.class.from_json(as_json).specie.should == :ltc
-  end
 end
 
 shared_examples_for 'JSON deserializable match' do
@@ -32,35 +39,26 @@ shared_examples_for 'JSON deserializable match' do
 end
 
 shared_examples_for 'JSON deserializable order' do
-  it "sets price as BigDecimal" do
+  it 'sets price as BigDecimal' do
     thing = subject.class.from_json(as_json).price
     thing.should be_a BigDecimal
-    thing.should == 1000.0
+    thing.should == 1_000.0
   end
-  
-  { 1 => :received,
-    2 => :executing,
-    3 => :cancelling,
-    4 => :cancelled,
-    5 => :completed,
-  }.each do |code, symbol|
+
+  { 1 => :received, 2 => :executing, 3 => :cancelling, 4 => :cancelled, 5 => :completed }.each do |code, symbol|
     it "sets status #{code} to #{symbol}" do
       as_json[7] = code
       subject.class.from_json(as_json).status.should == symbol
     end
   end
 
-  { 0 => :not_cancelled,
-    1 => :not_enough_funds,
-    2 => :user_cancelled,
-    3 => :system_cancelled,
-  }.each do |code, symbol|
+  { 0 => :not_cancelled, 1 => :not_enough_funds, 2 => :user_cancelled, 3 => :system_cancelled }.each do |code, symbol|
     it "sets reason #{code} to #{symbol}" do
       as_json[8] = code
       subject.class.from_json(as_json).reason.should == symbol
     end
   end
-  
+
   it 'sets the issuer' do
     as_json[10] = 'User#22'
     subject.class.from_json(as_json).issuer.should == 'User#22'