bitcoin-ruby 0.0.6 → 0.0.7

data/spec/bitcoin/ffi_openssl.rb

@@ -0,0 +1,45 @@
+# encoding: ascii-8bit
+
+require_relative 'spec_helper.rb'
+require 'bitcoin'
+
+
+describe 'Bitcoin FFI OpenSSL Helpers' do
+  it 'should convert high-S DER signatures to low-S equivalents' do
+    Bitcoin.network = 'testnet'
+
+    tx_in = Bitcoin::Protocol::Tx.new( fixtures_file('rawtx-testnet-6f0bbdd4e71a8af4305018d738184df32dbb6f27284fdebd5b56d16947f7c181.bin') )
+    tx_out = Bitcoin::Protocol::Tx.new( fixtures_file('rawtx-testnet-a7c9b06e275e8674cc19a5f7d3e557c72c6d93576e635b33212dbe08ab7cdb60.bin') )
+    original_hash = tx_out.hash
+    tx_out.verify_input_signature(0, tx_in).should == true
+    script_sig = Bitcoin::Script.new(tx_out.in[0].script_sig)
+    sig = script_sig.chunks[0]
+    pubkey = script_sig.chunks[1]
+    Bitcoin::Script::is_low_der_signature?(sig).should == false
+
+    sig = Bitcoin::OpenSSL_EC.signature_to_low_s(sig)
+    Bitcoin::Script::is_low_der_signature?(sig).should == true
+
+    tx_out.in[0].script_sig = Bitcoin::Script.to_signature_pubkey_script(sig, pubkey)
+    tx_out.verify_input_signature(0, tx_in).should == true
+
+    # Repack the transaction to force hash update
+    tx_out = Bitcoin::Protocol::Tx.new( tx_out.to_payload )
+    original_hash.should != tx_out.hash
+
+    Bitcoin.network = 'bitcoin'
+  end
+
+  it 'Bitcoin::OpenSSL_EC.repack_der_signature' do
+    s = "304402204e45e16932b8af514961a1d3a1a25fdf3f4f7732e9d624c6c61548ab5fb8cd410220181522ec8eca07de4860a4acdd12909d831cc56cbbac4622082221a8768d1d09"
+    ns = Bitcoin::OpenSSL_EC.repack_der_signature([s].pack("H*")).unpack("H*")[0]
+    ns.should == s
+
+    [
+      "304402204e45e16932b8af514961a1d3a1a25fdf3f4f7732e9d624c6c61548ab5fb8cd410220181522ec8eca07de4860",
+      "304402204e45e16932",
+      "304402204",
+      "3044",
+    ].all?{|s| Bitcoin::OpenSSL_EC.repack_der_signature([s].pack("H*")) == false }.should == true
+  end
+end

data/spec/bitcoin/fixtures/156e6e1b84c5c3bd3a0927b25e4119fadce6e6d5186f363317511d1d680fae9a.json

@@ -0,0 +1,24 @@
+{
+  "hash": "156e6e1b84c5c3bd3a0927b25e4119fadce6e6d5186f363317511d1d680fae9a",
+  "ver": 1,
+  "vin_sz": 1,
+  "vout_sz": 1,
+  "lock_time": 0,
+  "size": 209,
+  "in": [
+    {
+      "prev_out": {
+        "hash": "8d0b238a06b5a70be75d543902d02d7a514d68d3252a949a513865ac3538874c",
+        "n": 0
+      },
+      "scriptSig": "4b4f2a0ae06225be0790dc295d651360 3045022039b01bb4a34f2758bf542b4a372660c598e0ade4fac8dc0b4e5503aa09bcf7dd02210086d07d2ad014834fe57734ff5272e470687bb0f921b0b304307a3e726074bae801 0314d45f33e01a0feaf065cd7ef3050c941bc16e90534b0b5f50860da9930bee00"
+    }
+  ],
+  "out": [
+    {
+      "value": "0.00010000",
+      "scriptPubKey": "OP_DUP OP_HASH160 85eb47fe98f349065d6f044e27a4ac541af79ee2 OP_EQUALVERIFY OP_CHECKSIG"
+    }
+  ],
+  "nid": "42f84e00c7450f066085574529e3420b86cb79be98b84590fb56676dd579df5d"
+}

data/spec/bitcoin/fixtures/8d0b238a06b5a70be75d543902d02d7a514d68d3252a949a513865ac3538874c.json

@@ -0,0 +1,24 @@
+{
+  "hash": "8d0b238a06b5a70be75d543902d02d7a514d68d3252a949a513865ac3538874c",
+  "ver": 1,
+  "vin_sz": 1,
+  "vout_sz": 1,
+  "lock_time": 0,
+  "size": 327,
+  "in": [
+    {
+      "prev_out": {
+        "hash": "cd279a4bb51d61e7ad9482fed6e5dc042babf3b9ec754245b44d6ffa62f08c7c",
+        "n": 1
+      },
+      "scriptSig": "0 3045022100f45a6fd9c99594d66223af3ba8c93beffadd3a41369e56692893ae1fd36d57a302201584848a46c22f7ab1ac718286aa1492a3d77e4f3827e7256ffff99d6846bd2301 304502203e78dda25f19e38cf5fd03f4c2ef5fd743569563972ebad9d77979d35d96652b022100873d842c4d307999b2ece5069e9bc64117c100200773cf6fa048a67bd9a51ec101 2 2102e5bbbce26a2a35bbeee2adbb7237efabd2228809dc27815611c480b4c4037ac4210314d45f33e01a0feaf065cd7ef3050c941bc16e90534b0b5f50860da9930bee0052ae"
+    }
+  ],
+  "out": [
+    {
+      "value": "0.00010000",
+      "scriptPubKey": "OP_DUP OP_HASH160 b689ebc262f50297139e7d16c4f8909e14ed4322 OP_EQUALVERIFY OP_CHECKSIGVERIFY OP_HASH160 1b6246121883816fc0637e4aa280aca1df219b1a OP_EQUAL"
+    }
+  ],
+  "nid": "6db404bcf4a44b5982d74d07250c4a052598abadcd52d789ff20f9de01fe7f9d"
+}

data/spec/bitcoin/fixtures/coinbase-toshi.json

@@ -0,0 +1,33 @@
+{
+  "hash":"6d7e160109d3d6bdfadfeb7f2a041d57dd6c910e0798554b495f2963c1b0c787",
+  "version":1,
+  "lock_time":0,
+  "size":177,
+  "inputs":[
+    {
+      "previous_transaction_hash":"0000000000000000000000000000000000000000000000000000000000000000",
+      "output_index":4294967295,
+      "amount":2500000000,
+      "coinbase":"03c4ed04e4b883e5bda9e7a59ee4bb99e9b1bcfabe6d6da1f05b26289f973240ae74a5768b942e93b459a7af0e01f99c9868492e543ebb1000000000000000ea8f12dcc51201004d696e6564206279206368656e6775616e67667531"
+    }
+  ],
+  "outputs":[
+    {
+      "amount":2502773013,
+      "spent":false,
+      "script":"OP_DUP OP_HASH160 c825a1ecf2a6830c4401620c3a16f1995057c2ab OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a914c825a1ecf2a6830c4401620c3a16f1995057c2ab88ac",
+      "script_type":"hash160",
+      "addresses":[
+        "1KFHE7w8BhaENAswwryaoccDb6qcT6DbYY"
+      ]
+    }
+  ],
+  "amount":2502773013,
+  "fees":0,
+  "confirmations":19,
+  "block_height":323012,
+  "block_hash":"000000000000000019b16f4a6cd8717ab8f4836bbc9822894cc49785badfdaa7",
+  "block_time":"2014-09-29T04:24:35Z",
+  "block_branch":"main"
+}

data/spec/bitcoin/fixtures/coinbase.json

@@ -0,0 +1,24 @@
+{
+  "hash": "6d7e160109d3d6bdfadfeb7f2a041d57dd6c910e0798554b495f2963c1b0c787",
+  "ver": 1,
+  "vin_sz": 1,
+  "vout_sz": 1,
+  "lock_time": 0,
+  "size": 177,
+  "in": [
+    {
+      "prev_out": {
+        "hash": "0000000000000000000000000000000000000000000000000000000000000000",
+        "n": 4294967295
+      },
+      "coinbase": "03c4ed04e4b883e5bda9e7a59ee4bb99e9b1bcfabe6d6da1f05b26289f973240ae74a5768b942e93b459a7af0e01f99c9868492e543ebb1000000000000000ea8f12dcc51201004d696e6564206279206368656e6775616e67667531"
+    }
+  ],
+  "out": [
+    {
+      "value": "25.02773013",
+      "scriptPubKey": "OP_DUP OP_HASH160 c825a1ecf2a6830c4401620c3a16f1995057c2ab OP_EQUALVERIFY OP_CHECKSIG"
+    }
+  ],
+  "nid": "c1935bec4c6363aa7f727bfbeacbac4a87766ffe6f352a6b3f8c0c4600dde75f"
+}

data/spec/bitcoin/fixtures/rawtx-01-toshi.json

@@ -0,0 +1,46 @@
+{
+  "hash":"6e9dd16625b62cfcd4bf02edb89ca1f5a8c30c4b1601507090fb28e59f2d02b4",
+  "version":1,
+  "lock_time":0,
+  "size":258,
+  "inputs":[
+    {
+      "previous_transaction_hash":"c866fc2aea0e36ce632886f26a66487ba751762d0f085763d01efc438336f6b0",
+      "output_index":0,
+      "amount":29000000,
+      "script":"3045022100bde2e702380813d61069845a75e330779bbacc6a1330bd9dfd1fec1bd94f8f17022075c29d9b37957c80068436609755942be0f7f6fbd30983a557a6e0640edeeb1601 049de89dd4f0b3801c2d28a334f0fb8b0bfd7a9d67530e9dffa536bd7130e8dfd32a01e7bafcdd956fdeece0f341fa4f2727890bf09fe0dd1dea9169aad9c30242",
+      "addresses":[
+        "1PiiBch7CrLgYscAeTrUhHq1TvaCZxyhwo"
+      ]
+    }
+  ],
+  "outputs":[
+    {
+      "amount":24956381,
+      "spent":true,
+      "script":"OP_DUP OP_HASH160 b2e21c1db922e3bdc529de7b38b4c401399e9afd OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a914b2e21c1db922e3bdc529de7b38b4c401399e9afd88ac",
+      "script_type":"hash160",
+      "addresses":[
+        "1HJr9Xs4dGdLxCxmYpDnHb1WbkaNw3EezN"
+      ]
+    },
+    {
+      "amount":3993619,
+      "spent":true,
+      "script":"OP_DUP OP_HASH160 7766347a890638dc3cd8d4ef99b8e40c6519d11e OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a9147766347a890638dc3cd8d4ef99b8e40c6519d11e88ac",
+      "script_type":"hash160",
+      "addresses":[
+        "1BtKrA1bUBn9na7BQK8npBYbMXuMAfxszK"
+      ]
+    }
+  ],
+  "amount":28950000,
+  "fees":50000,
+  "confirmations":197382,
+  "block_height":125539,
+  "block_hash":"0000000000002f9e18114d2a56714e1a1fdb58525857fc0b5460e51da682ac2b",
+  "block_time":"2011-05-21T15:45:32Z",
+  "block_branch":"main"
+}

data/spec/bitcoin/fixtures/rawtx-02-toshi.json

@@ -0,0 +1,46 @@
+{
+  "hash":"e6d0a1bc0355e4208c606cb3ae1f047875c13f966c6c861a154e2fe61a4132a5",
+  "version":1,
+  "lock_time":0,
+  "size":258,
+  "inputs":[
+    {
+      "previous_transaction_hash":"0abe13b3a6e01b12ec7abc592328d5edd5e9029d7d9ee9cd1440382812953ee1",
+      "output_index":0,
+      "amount":12814000000,
+      "script":"304502207442f42bb0c64f948df0711ae61e8612a011d83e755507d73c8cf6b1ae71fcd5022100a61a91f426a20db8778e35d14792f64daa0e8edf2acd5a9329adc25e0074a2cf01 045833aa1677dc0f5bd773b835622d53b4d31bc194577290a48897fb157e6af925bec9ce0dad4fc9e613d9d4661d78c111b02f219ca446e0c101b730d1234c4978",
+      "addresses":[
+        "14nvWuw7VpLdwtDdv2HATBSH8vEgD1snd3"
+      ]
+    }
+  ],
+  "outputs":[
+    {
+      "amount":12781000000,
+      "spent":true,
+      "script":"OP_DUP OP_HASH160 7bc2e19b0afd1c78ec792bbad334d41db2da8845 OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a9147bc2e19b0afd1c78ec792bbad334d41db2da884588ac",
+      "script_type":"hash160",
+      "addresses":[
+        "1CHPaBddn5zyZy7Ac1HmqisGkBd6cDAsRy"
+      ]
+    },
+    {
+      "amount":33000000,
+      "spent":true,
+      "script":"OP_DUP OP_HASH160 ffad3e6ddcfdb412953d41887a21e9ff9805a93c OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a914ffad3e6ddcfdb412953d41887a21e9ff9805a93c88ac",
+      "script_type":"hash160",
+      "addresses":[
+        "1QJtr7TuNdPKW9t5Q2a4ByStS4Hk5n5obX"
+      ]
+    }
+  ],
+  "amount":12814000000,
+  "fees":0,
+  "confirmations":197378,
+  "block_height":125543,
+  "block_hash":"0000000000003949c5390a26b2c76b6c6d819dfd18afe1623fcd5b7ce2c4b99d",
+  "block_time":"2011-05-21T16:09:47Z",
+  "block_branch":"main"
+}

data/spec/bitcoin/fixtures/rawtx-03-toshi.json

@@ -0,0 +1,73 @@
+{
+  "hash":"56577828eace17d718e538d51f3122bc7193bf37879b8a9d6638c4c5101159bc",
+  "version":1,
+  "lock_time":0,
+  "size":798,
+  "inputs":[
+    {
+      "previous_transaction_hash":"1f130699a1eb657f4eb051865ef4399dcaf8a34d5bbff879107829e687acf865",
+      "output_index":0,
+      "amount":61000000,
+      "script":"3045022100fd9d06ec1b74060a6e85e2ff614d4cf01c41a30debd86ac669ee5370b038a29302204ce4595ea7658ba2a1487aa784ed7543d0b394b0393d732a3ea4f247ffd7f49301 04974deddf7b6dbfdbe6799f58b4460b0f80e609d52d5ab13c398b8456c8dd9ea29fc6702a69edfe76bd2b7e7361e0a81523cba342133ed0e270b2d38e51429a33",
+      "addresses":[
+        "1AQbAurg1xxWr7Devd6rLTpDUutd49XkU2"
+      ]
+    },
+    {
+      "previous_transaction_hash":"d9fe5ba4752e3b7dd1c0fceaaa3124c73eef34d8dc2a0bf8e6dc6e9413556f84",
+      "output_index":0,
+      "amount":9000000,
+      "script":"304502210096782e8d62ec98f14b51639a0aa04588f847ea124d9709d2e48ec649d562ed0602203d5a6fec66af2518960bdbaf556d10732882ad9563d8ec38c22a1668306a5acf01 04b65a4e775c8d55676ddd25f97236c6b452b5ab986e2ed7562db453ebce7c95badfb890e0da2653747a21b463c63eb8ba6ab9ff9ce268a3600c1b906d5e295695",
+      "addresses":[
+        "18qL22NhdTywF91oVX1SeNq933x9bngeT2"
+      ]
+    },
+    {
+      "previous_transaction_hash":"d634f4d77f0f407077e6b11168c33d7d17c18d8c962dcc14b5ca2fc4a4e1efcf",
+      "output_index":0,
+      "amount":15000000,
+      "script":"3044022025c899f50e42b79a258d10a941e61529d4ad1e1d5dfd891ee243a186fbbbf81f02201a4aaa633245f29fbeab365151c3f9cdfcdc374b5077aa5ee32249e3c60071a201 04b8778189c915eb353393f9fbb01c3b50a263fa69f64f5e30d786bba3b79396b6646683c1a52dd5be120d5a3b6bdb87875e8a9634d980b0d8b30b70913b403a58",
+      "addresses":[
+        "13XwYPMxKa7GykVfD9nxEBJGqVBxRfojdF"
+      ]
+    },
+    {
+      "previous_transaction_hash":"175dfd12170980b391b66822b5a699ed18d24d572b719429026d42168801024e",
+      "output_index":24,
+      "amount":117000000,
+      "script":"3046022100909ef47b3138490e129d932eedc3de6ddf67c58bd0a54d75e915b31b793c83080221008bfa4b84c932380be3561fd4d4dcd68dbf00b8b40aa605630702cbfee1a440c701 0483c5d3b9eb6a4b6f1812ede42f7d86726f9aa0bbb1a25d7604bbc632c093b0d47a23263252ffbbd2995ca1da2fbbb6c642eaaa75eae26310b20aec04493afa1a",
+      "addresses":[
+        "171wMNEqsWK9GCi9ATZCo9w2dBcyXDThpb"
+      ]
+    }
+  ],
+  "outputs":[
+    {
+      "amount":1000000,
+      "spent":true,
+      "script":"OP_DUP OP_HASH160 3129d7051d509424d23d533fa2d5258977e822e3 OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a9143129d7051d509424d23d533fa2d5258977e822e388ac",
+      "script_type":"hash160",
+      "addresses":[
+        "15UxEVL3rmBLctJY4r6rpATrpZ9STBM1dg"
+      ]
+    },
+    {
+      "amount":200000000,
+      "spent":true,
+      "script":"OP_DUP OP_HASH160 f3de26ff7d472d5365e3adafece9bbdcace915a0 OP_EQUALVERIFY OP_CHECKSIG",
+      "script_hex":"76a914f3de26ff7d472d5365e3adafece9bbdcace915a088ac",
+      "script_type":"hash160",
+      "addresses":[
+        "1PETL2itvQxneQguBjBLGBmjHhMprtQHNZ"
+      ]
+    }
+  ],
+  "amount":201000000,
+  "fees":1000000,
+  "confirmations":197381,
+  "block_height":125540,
+  "block_hash":"00000000000015ba72d71f8c7aebfcac65a689adce10d86c11e786e96edefd40",
+  "block_time":"2011-05-21T16:02:46Z",
+  "block_branch":"main"
+}

data/spec/bitcoin/protocol/block_spec.rb

@@ -116,28 +116,6 @@ describe 'Bitcoin::Protocol::Block' do
       Bitcoin.network = :bitcoin
     end
 
-    it "should work with freicoin blocks" do
-      Bitcoin.network = :freicoin # change to freicoin
-      freicoin_block = "freicoin-genesis-block-000000005b1e3d23ecfd2dd4a6e1a35238aa0392c0a8528c40df52376d7efe2c"
-      Block.from_json(fixtures_file(freicoin_block + '.json'))
-        .to_payload.should == fixtures_file(freicoin_block + '.bin')
-
-      json = Block.new(fixtures_file(freicoin_block + '.bin')).to_json
-      Block.from_json(json)
-        .to_payload.should == fixtures_file(freicoin_block + '.bin')
-      Block.from_json(json).hash == freicoin_block.split("-").last
-
-      freicoin_block = "freicoin-block-000000005d231b285e63af83edae2d8f5e50e70d396468643092b9239fd3be3c"
-      Block.from_json(fixtures_file(freicoin_block + '.json'))
-        .to_payload.should == fixtures_file(freicoin_block + '.bin')
-
-      json = Block.new(fixtures_file(freicoin_block + '.bin')).to_json
-      Block.from_json(json)
-        .to_payload.should == fixtures_file(freicoin_block + '.bin')
-      Block.from_json(json).hash == freicoin_block.split("-").last
-      Bitcoin.network = :bitcoin
-    end
-
     it 'should check block hash' do
       block = Block.from_json(fixtures_file('rawblock-0.json'))
       h = block.to_hash

data/spec/bitcoin/protocol/tx_spec.rb

@@ -52,7 +52,7 @@ describe 'Tx' do
   it '#normalized_hash' do
     tx = Tx.new( @payload[0] )
     tx.normalized_hash.size.should == 64
-    tx.normalized_hash.should == "402e30100b6937cc13828ca096377c93afc0ff227ad2f249245e5b1db9123a39"
+    tx.normalized_hash.should == "393a12b91d5b5e2449f2d27a22ffc0af937c3796a08c8213cc37690b10302e40"
 
     new_tx = JSON.parse(tx.to_json)
     script =  Bitcoin::Script.from_string(new_tx['in'][0]['scriptSig'])
@@ -63,7 +63,7 @@ describe 'Tx' do
 
     new_tx.hash.should != tx.hash
     new_tx.normalized_hash.size.should == 64
-    new_tx.normalized_hash.should == "402e30100b6937cc13828ca096377c93afc0ff227ad2f249245e5b1db9123a39"
+    new_tx.normalized_hash.should == "393a12b91d5b5e2449f2d27a22ffc0af937c3796a08c8213cc37690b10302e40"
   end
 
   it '#to_payload' do
@@ -124,12 +124,124 @@ describe 'Tx' do
     # coinbase tx with non-default sequence
     tx = Tx.from_json( json=fixtures_file('0961c660358478829505e16a1f028757e54b5bbf9758341a7546573738f31429.json'))
     Tx.new( tx.to_payload ).to_json.should == json
+
+    # toshi format
+    Tx.from_json(fixtures_file('rawtx-02-toshi.json')).to_payload.should == Tx.from_json(fixtures_file('rawtx-02.json')).to_payload
+    Tx.from_json(fixtures_file('rawtx-03-toshi.json')).to_payload.should == Tx.from_json(fixtures_file('rawtx-03.json')).to_payload
+    Tx.from_json(fixtures_file('coinbase-toshi.json')).to_payload.should == Tx.from_json(fixtures_file('coinbase.json')).to_payload
   end
 
   it 'Tx.binary_from_json' do
     Tx.binary_from_json( fixtures_file('rawtx-2f4a2717ec8c9f077a87dde6cbe0274d5238793a3f3f492b63c744837285e58a.json') ).should ==
       fixtures_file('rawtx-2f4a2717ec8c9f077a87dde6cbe0274d5238793a3f3f492b63c744837285e58a.bin')
   end
+  
+  it 'compares arrays of bytes' do
+    # This function is used in validating an ECDSA signature's S value
+    c1 = []
+    c2 = []
+    Bitcoin::Script::compare_big_endian(c1, c2).should == 0
+    
+    c1 = [0]
+    c2 = []
+    Bitcoin::Script::compare_big_endian(c1, c2).should == 0
+    
+    c1 = []
+    c2 = [0]
+    Bitcoin::Script::compare_big_endian(c1, c2).should == 0
+    
+    c1 = [5]
+    c2 = [5]
+    Bitcoin::Script::compare_big_endian(c1, c2).should == 0
+    
+    c1 = [04]
+    c2 = [5]
+    Bitcoin::Script::compare_big_endian(c1, c2).should == -1
+    
+    c1 = [4]
+    c2 = [05]
+    Bitcoin::Script::compare_big_endian(c1, c2).should == -1
+    
+    c1 = [5]
+    c2 = [4]
+    Bitcoin::Script::compare_big_endian(c1, c2).should == 1
+    
+    c1 = [05]
+    c2 = [004]
+    Bitcoin::Script::compare_big_endian(c1, c2).should == 1
+
+  end
+
+  it 'validates ECDSA signature format' do
+    # TX 3da75972766f0ad13319b0b461fd16823a731e44f6e9de4eb3c52d6a6fb6c8ae
+    sig_orig = ["304502210088984573e3e4f33db7df6aea313f1ce67a3ef3532ea89991494c7f018258371802206ceefc9291450dbd40d834f249658e0f64662d52a41cf14e20c9781144f2fe0701"].pack("H*")
+    Bitcoin::Script::is_der_signature?(sig_orig).should == true
+    Bitcoin::Script::is_defined_hashtype_signature?(sig_orig).should == true
+
+    # Trimmed to be too short
+    sig = sig_orig.slice(0, 8)
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Zero-padded to be too long
+    sig = String.new(sig_orig)
+    sig << 0x00
+    sig << 0x00
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Wrong first byte
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[0] = 0x20
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Length byte broken
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[1] = 0x20
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Incorrect R value type
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[2] = 0x03
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # R value length infeasibly long
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[3] = sig_orig.size - 4
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Negative R value
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[4] = 0x80 | sig_bytes[4]
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # R value excessively padded
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[5] = 0x00
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Incorrect S value type
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[37] = 0x03
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Zero S length
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[38] = 0x00
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+
+    # Negative S value
+    sig_bytes = sig_orig.unpack("C*")
+    sig_bytes[39] = 0x80 | sig_bytes[39]
+    sig = sig_bytes.pack("C*")
+    Bitcoin::Script::is_der_signature?(sig).should == false
+  end
 
   it '#verify_input_signature' do
     # transaction-2 of block-170
@@ -247,6 +359,37 @@ describe 'Tx' do
     tx.in.each.with_index{|i,idx|
       tx.verify_input_signature(idx, prev_txs[i.previous_output]).should == true
     }
+
+    # BIP62 rule #2 - spend transaction has operations in its signature
+    tx = Tx.new( fixtures_file('rawtx-testnet-3bc52ac063291ad92d95ddda5fd776a342083b95607ad32ed8bc6f8f7d30449e.bin') )
+    tx.hash.should == "3bc52ac063291ad92d95ddda5fd776a342083b95607ad32ed8bc6f8f7d30449e"
+    outpoint_tx = Tx.new( fixtures_file('rawtx-testnet-04fdc38d6722ab4b12d79113fc4b2896bdcc5169710690ee4e78541b98e467b4.bin') )
+    outpoint_tx.hash.should == "04fdc38d6722ab4b12d79113fc4b2896bdcc5169710690ee4e78541b98e467b4"
+    tx.verify_input_signature(0, outpoint_tx, Time.now.to_i).should == true
+    tx.verify_input_signature(0, outpoint_tx, Time.now.to_i, verify_sigpushonly: true).should == false
+
+    # BIP62 rule #6 - spend transaction has an unused "0" on the signature stack
+    tx = Tx.new( fixtures_file('rawtx-testnet-0b294c7d11dd21bcccb8393e6744fed7d4d1981a08c00e3e88838cc421f33c9f.bin') )
+    tx.hash.should == "0b294c7d11dd21bcccb8393e6744fed7d4d1981a08c00e3e88838cc421f33c9f"
+    outpoint_tx = Tx.new( fixtures_file('rawtx-testnet-f80acbd2f594d04ddb0e1cacba662132104909157dff526935a3c88abe9201a5.bin') )
+    outpoint_tx.hash.should == "f80acbd2f594d04ddb0e1cacba662132104909157dff526935a3c88abe9201a5"
+    tx.verify_input_signature(0, outpoint_tx, Time.now.to_i).should == true
+    tx.verify_input_signature(0, outpoint_tx, Time.now.to_i, verify_cleanstack: true).should == false
+
+    # Ensure BIP62 is applied to P2SH scripts
+    tx = Bitcoin::P::Tx.from_json(fixtures_file('7208e5edf525f04e705fb3390194e316205b8f995c8c9fcd8c6093abe04fa27d.json'))
+    tx.hash.should == "7208e5edf525f04e705fb3390194e316205b8f995c8c9fcd8c6093abe04fa27d"
+    outpoint_tx = Bitcoin::P::Tx.from_json(fixtures_file('3e58b7eed0fdb599019af08578effea25c8666bbe8e200845453cacce6314477.json'))
+    outpoint_tx.hash.should == "3e58b7eed0fdb599019af08578effea25c8666bbe8e200845453cacce6314477"
+    tx.verify_input_signature(0, outpoint_tx).should == true
+    tx.verify_input_signature(0, outpoint_tx, Time.now.to_i, verify_low_s: true).should == false
+
+    # testnet3 P2SH check
+    tx = Bitcoin::P::Tx.from_json(fixtures_file('156e6e1b84c5c3bd3a0927b25e4119fadce6e6d5186f363317511d1d680fae9a.json'))
+    tx.hash.should == "156e6e1b84c5c3bd3a0927b25e4119fadce6e6d5186f363317511d1d680fae9a"
+    outpoint_tx = Bitcoin::P::Tx.from_json(fixtures_file('8d0b238a06b5a70be75d543902d02d7a514d68d3252a949a513865ac3538874c.json'))
+    outpoint_tx.hash.should == "8d0b238a06b5a70be75d543902d02d7a514d68d3252a949a513865ac3538874c"
+    tx.verify_input_signature(0, outpoint_tx).should == true
   end
 
   it '#sign_input_signature' do