bing_ads_ruby_sdk 1.3.4 → 1.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 99e4be2d8abe1ee49225dcf73b1daa622c07baa7d40d55fe5e745ccb2bdcb071
-  data.tar.gz: f0712baebfd530c3d98f39a009e4679496fd64926c183c89e87ee93de8493cd0
+  metadata.gz: 0a6b39b428d7a606c0072d095766bff29b4d7c9e44dd2f825bdb2654915ad14a
+  data.tar.gz: 7d6c717dbec5df6bceeb13ec38a000bbf1252f83ce2030c1071a55fe3a8386ab
 SHA512:
-  metadata.gz: ef9561dfc43a108a31a926319cdfe8535e4703b58f367c827f0f0a88d20009a28f19d66fe7ab19e2f9dd9e42018be74ff69ebc1da42f5c9f1dbe1ad500450279
-  data.tar.gz: e1ba475d1b2352f007e71d94b0fa2d880356f6ab501cd93172ca162ccbd3209bd2a23b99b062cb82957c31180412ce78b12ed6920c179beca1ab108a8bb09973
+  metadata.gz: d6232334e3e2c510825d83b9d2476ca601eae477c744e7b9b30ac637d0afc3f965127043c5465d5797ec87dc67b4c80150c52dc54f680676c7be49da1f8d6c98
+  data.tar.gz: e3ff1cc382a5099754b37fb42b7858d79c0474dcfd22faef5e05c8498ce9c61a625df852adc638d94463682beb37cbf1d715358d4fa80b6daf022510011640bf

data/.circleci/config.yml

@@ -1,27 +1,15 @@
-# Ruby CircleCI 2.0 configuration file
-#
-# Check https://circleci.com/docs/2.0/language-ruby/ for more details
-#
-version: 2
-jobs:
-  build:
-    docker:
-      - image: circleci/ruby:2.4.1
-
-    working_directory: ~/repo
+version: 2.1
 
+commands:
+  build:
     steps:
       - checkout
-
-      # We can't use restore_cache because we don't include a Gemfile.lock
-      # in the Gem repo
-
+      # We can't use restore_cache because we don't include a Gemfile.lock in the Gem repo
       - run:
           name: install dependencies
           command: |
             bundle install --jobs=4 --retry=3 --path vendor/bundle
-
-      # run tests!
+      - run: bundle exec standardrb
       - run:
           name: run tests
           command: |
@@ -36,7 +24,6 @@ jobs:
               --out /tmp/test-results/rspec.xml \
               --format progress \
               $TEST_FILES
-
       # collect reports
       - store_test_results:
           path: /tmp/test-results
@@ -44,9 +31,24 @@ jobs:
           path: /tmp/test-results
           destination: test-results
 
+jobs:
+  build_2_x:
+    docker:
+      - image: ruby:2.7.6
+    working_directory: ~/repo
+    steps:
+      - build
+
+  build_3_x:
+    docker:
+      - image: ruby:3.1.2
+    working_directory: ~/repo
+    steps:
+      - build
 
 workflows:
   version: 2
   build:
     jobs:
-      - build
+      - build_2_x
+      - build_3_x

data/.github/renovate.json

@@ -0,0 +1,225 @@
+{
+  "extends": [
+    "config:base",
+    "schedule:weekly",
+    ":preserveSemverRanges"
+  ],
+  "kubernetes": {
+    "fileMatch": [
+      "\\.yaml$",
+       "\\.tpl$"
+    ]
+  },
+  "branchPrefix": "bot-",
+  "hostRules": [
+    {
+      "matchHost": "github.com",
+      "hostType": "rubygems",
+      "encrypted": {
+        "token": "wcFMA/xDdHCJBTolARAAjumTJ4PWx0T4aV3fSFZrLqZsnGUW+j+IKh1WPdzAiGdj+9zUQNcdJimlokWffqMzn3pNC8B8GMb+UjStyxQjZH+kzK6fEU4bn9hsg+g8LVHccvRXjzbIwaIyDcBZE0scr9yS7QRk/xI2vviDMAXTiyQEwMIRCfIAaPhcJBbg7L9kRmDmvnlDXPIVkzvenQYFA+3Smib0tL2glJ5NhS/ZgQUAIaz64d/Ibe+PM5atR2+cEf4o0PmBGSa6yGcGJX32kiR0AFMesNtIKWjh5UUjH4M5k0Uuz3bHU2Q85NjXrcmZD1Pqz//LZn+aFYSiDHM7sOHk+LXYnPtjs3+6KrI40tfo64kS4Xp72L/XhE0trhVPki2NmoQXU9ux8YgCCNZb4La3XcGlS0tWAAJU5Ebajx7qCVqweKpoEHHkim+sXl75s3Qu3WOQCgdAWtL3Vds3cu9D4ZEe0Hax6XxurZ/BuE5MS5i3Kd85JFlRgPD+C+/2EABKrCzTpDHNIK72tAY50rgFM1uvGIgaQVHEVsU0l1dm0DzxTwisWERpr90CNaz5dhGT5lYer+p8z5Gye00kn+SWyqWWTTZ0c+ZLh+eEQ6/TdWhFHjBi8524lvotbAT3Wq7lLDWeS3vAW/bj39v7LPbUGIXdvxIvF9EUwr1NRTviOASLXrEH7NNk99RheiLSdgFWqKKuKEGE2gq0t3vXA85GoT7wU0wB4RKCKqGrCK8AbL+PwvKxKZ+P63F+EfMyhIq89Qw9Szu6KbeNoYwsEQgYyXko/HDMWWqfQcTKEMF6rGf7KRmCFEIjrsSO4LJ+RcbmZBESr+L1T790c2nuFjwGI1qcA0Y"
+      }
+    }
+  ],
+  "vulnerabilityAlerts": {
+    "enabled": true,
+    "automerge": true,
+    "groupName": null,
+    "labels": [
+      "security"
+    ],
+    "schedule": [
+      "after 2am and before 6am every day"
+    ]
+  },
+  "packageRules": [
+    {
+      "matchPackagePatterns": ["*"],
+      "stabilityDays": 5
+    },
+    {
+      "matchDatasources": ["terraform-module","terraform-provider"],
+      "labels": ["terraform"],
+      "groupName": "terraform",
+      "automerge": false
+    },
+    {
+      "matchDepTypes": ["devDependencies"],
+      "matchPackagePatterns": ["lint", "prettier"],
+      "groupName": "linter-update",
+      "labels": ["linter-update"],
+      "automerge": true
+    },
+    {
+      "matchManagers": ["nodenv", "npm"],
+      "groupName": "js-update",
+      "labels": ["js-update"],
+      "automerge": true
+    },
+    {
+      "matchManagers": ["bundler", "ruby-version"],
+      "groupName": "ruby-update",
+      "automerge": true,
+      "labels": ["ruby-update"]
+    },
+    {
+      "matchManagers": ["pip-compile", "pip_requirements", "pip_setup", "pipenv", "pyenv", "setup-cfg"],
+      "groupName": "python-update",
+      "automerge": true,
+      "labels": ["python-update"]
+    },
+    {
+      "matchDepTypes": ["peerDependencies", "devDependencies", "dependencies"],
+      "matchUpdateTypes": ["minor","patch","pin","digest","rollback","bump"],
+      "groupName": "dep-update",
+      "labels": ["dependencies-update"],
+      "automerge": true
+    },
+    {
+      "matchCurrentVersion": "/^v?[~ -]?0/",
+      "matchUpdateTypes": [
+        "minor",
+        "patch",
+        "pin",
+        "digest",
+        "rollback",
+        "bump"
+      ],
+      "groupName": "betas can break",
+      "labels": ["betas-update"],
+      "description": "according semver spec, version <1 can introduce breaking changes on each rel",
+      "automerge": false
+    },
+    {
+      "matchManagers": ["gitlabci", "gitlabci-include", "circleci", "helm-requirements", "helm-values", "helmfile", "helmv3","docker-compose", "dockerfile","kubernetes"],
+      "automerge": true,
+      "groupName": "ci-update",
+      "labels": ["ci-update"]
+    },
+    {
+      "matchManagers": [
+        "gitlabci",
+        "gitlabci-include",
+        "circleci",
+        "helm-requirements",
+        "helm-values",
+        "helmfile",
+        "helmv3",
+        "docker-compose",
+        "dockerfile",
+        "kubernetes"
+      ],
+      "matchPackageNames": ["redis"],
+      "allowedVersions": "<6",
+      "automerge": true,
+      "groupName": "redis-update",
+      "description": "explicit max version to keep coherence with real infra on GCP"
+    },
+    {
+      "matchPackageNames": ["jdk","openjdk"],
+      "allowedVersions": "<18",
+      "automerge": true,
+      "groupName": "jdk-update",
+      "description": "explicit max version to keep LTS only"
+    },
+    {
+      "matchPackageNames": ["cimg/postgres","postgres","postgis","postgis/postgis"],
+      "allowedVersions": "<14",
+      "automerge": true,
+      "groupName": "postgres-update",
+      "labels": ["postgres"],
+      "description": "explicit max version to prevent issue like need to coordinate with real infra on GCP"
+    },
+    {
+      "matchPackageNames": ["ruby","circleci/ruby","cimg/ruby"],
+      "allowedVersions": "<4",
+      "groupName": "rubycore-update",
+      "description": "explicit max version to prevent issues",
+      "labels": ["rubycore-update"]
+    },
+    {
+      "matchPackageNames": ["node","circleci/node","cimg/node"],
+      "automerge": true,
+      "allowedVersions": "<17",
+      "groupName": "node-update",
+      "labels": ["node-update"],
+      "description": "explicit max LTS version to prevent issues : https://cloud.google.com/functions/docs/concepts/nodejs-runtime " 
+    },
+    {
+      "matchPackageNames": ["python"],
+      "automerge": true,
+      "groupName": "python-update",
+      "labels": ["python-update"]
+    },
+    {
+      "matchPackageNames": ["circleci/python","cimg/python"],
+      "automerge": true,
+      "allowedVersions": "<4",
+      "groupName": "pythoncore-update",
+      "labels": ["pythoncore-update"],
+      "description": "explicit max major version to prevent issues"
+    },
+    {
+      "matchPackageNames": ["xgboost"],
+      "automerge": true,
+      "allowedVersions": "<1.5",
+      "groupName": "xgboost-update",
+      "description": "limitation from the data model used in pricer"
+    },
+    {
+      "matchPackageNames": ["pandas"],
+      "allowedVersions": "<1.4",
+      "automerge": true,
+      "groupName": "pandas-update",
+      "description": "limitation from dataiku, don't merge upper than 1.3 for now"
+    },
+    {
+      "matchPackageNames": [
+        "gql"
+      ],
+      "automerge": true,
+      "allowedVersions": "<3",
+      "groupName": "gql-update",
+      "description": "limitation from dataiku"
+    },
+    {
+      "matchPackageNames": [
+        "envkey"
+      ],
+      "automerge": true,
+      "allowedVersions": "<2",
+      "groupName": "envkey-update",
+      "description": "no switch for now"
+    },
+    {
+      "matchPackageNames": [
+        "facebookbusiness"
+      ],
+      "groupName": "envkey-update",
+      "description": "Facebook API",
+      "labels": [
+        "apifacebook-update"
+      ]
+    },
+    {
+      "matchPackageNames": [
+        "google-ads-googleads"
+      ],
+      "groupName": "googleads-update",
+      "description": "Google Ads API",
+      "labels": [
+        "apigoogleads-update"
+      ]
+    }
+  ],
+  "lockFileMaintenance": {
+    "enabled": true,
+    "schedule": ["after 2am and before 6am every monday"],
+    "commitMessageAction": "Update lockfiles",
+    "groupName": "lockfile-update",
+    "labels": ["lockfile-update"],
+    "automerge": true
+  },
+  "dependencyDashboard": true,
+  "timezone": "Europe/Paris",
+  "prHourlyLimit": 6
+}

data/Gemfile

@@ -2,3 +2,5 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in bing_ads_ruby_sdk.gemspec
 gemspec
+
+gem "standard", "1.16.1"

data/Rakefile

@@ -1,7 +1,7 @@
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
-require './lib/bing_ads_ruby_sdk'
-import 'tasks/bing_ads_ruby_sdk.rake'
+require "bundler/gem_tasks"
+require "rspec/core/rake_task"
+require "./lib/bing_ads_ruby_sdk"
+import "tasks/bing_ads_ruby_sdk.rake"
 
 RSpec::Core::RakeTask.new(:spec)
 

data/bing_ads_ruby_sdk.gemspec

@@ -1,37 +1,35 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'bing_ads_ruby_sdk/version'
+require "bing_ads_ruby_sdk/version"
 
 Gem::Specification.new do |spec|
-  spec.name          = 'bing_ads_ruby_sdk'
-  spec.required_ruby_version = '>= 2.0'
+  spec.name = "bing_ads_ruby_sdk"
+  spec.required_ruby_version = ">= 2.3"
 
-  spec.version       = BingAdsRubySdk::VERSION
-  spec.authors       = %w[Effilab developers]
-  spec.email         = %w[developers@effilab-local.com]
+  spec.version = BingAdsRubySdk::VERSION
+  spec.authors = %w[Effilab developers]
+  spec.email = %w[dev@effilab.com]
 
-  spec.summary       = 'Bing Ads Ruby SDK'
-  spec.description   = 'Bing Ads Api Wrapper'
-  spec.homepage      = 'https://github.com/Effilab/bing_ads_ruby_sdk'
-  spec.license       = 'MIT'
+  spec.summary = "Bing Ads Ruby SDK"
+  spec.description = "Bing Ads Api Wrapper"
+  spec.homepage = "https://github.com/Effilab/bing_ads_ruby_sdk"
+  spec.license = "MIT"
 
-  spec.files         = `git ls-files`.split($/)
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(spec)/})
+  spec.files = `git ls-files`.split($/)
+  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency 'signet'
-  spec.add_runtime_dependency 'excon', '>= 0.62.0'
-  spec.add_runtime_dependency 'lolsoap', '>=0.9.0'
+  spec.add_runtime_dependency "signet"
+  spec.add_runtime_dependency "excon", ">= 0.62.0"
+  spec.add_runtime_dependency "lolsoap", ">=0.9.0"
 
-  spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'dotenv'
-  spec.add_development_dependency 'rake'
-  spec.add_development_dependency 'yard'
-  spec.add_development_dependency 'rspec'
-  spec.add_development_dependency 'simplecov'
-  spec.add_development_dependency 'byebug'
-  spec.add_development_dependency 'awesome_print'
-  spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
+  spec.add_development_dependency "bundler"
+  spec.add_development_dependency "dotenv"
+  spec.add_development_dependency "rake"
+  spec.add_development_dependency "yard"
+  spec.add_development_dependency "rspec"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "byebug"
+  spec.add_development_dependency "awesome_print"
+  spec.add_development_dependency "rspec_junit_formatter", "~> 0.4.1"
 end

data/changelog.md

@@ -1,3 +1,13 @@
+## V1.5.0 Release
+- Breaking: Now raises functional errors
+- Breaking: Now raises an error if not able to read the store in order to refresh the token
+
+## V1.4.0 Release
+
+- Breaking: change scope from `https://ads.microsoft.com/ads.manage` to `https://ads.microsoft.com/msads.manage` as requested by Bing (deadline March 22)
+
+- now reading store at the very last moment to get freshest token
+
 ## V1.3.4 Release
 
 - lift constraint on signet gem

data/lib/bing_ads_ruby_sdk/api.rb

@@ -23,12 +23,9 @@ module BingAdsRubySdk
     # @option environment [Symbol] :sandbox Use the sandbox WSDL configuration
     # @param developer_token
     # @param client_id
-    def initialize(version: DEFAULT_SDK_VERSION,
-                   environment: :production,
-                   developer_token:,
-                   client_id:,
-                   oauth_store:,
-                   client_secret: nil)
+    def initialize(developer_token:, client_id:, oauth_store:, version: DEFAULT_SDK_VERSION,
+      environment: :production,
+      client_secret: nil)
       @version = version
       @environment = environment
       @header = Header.new(

data/lib/bing_ads_ruby_sdk/augmented_parser.rb

@@ -2,7 +2,6 @@
 
 module BingAdsRubySdk
   class AugmentedParser
-
     def initialize(wsdl_file_path)
       @lolsoap_parser = LolSoap::WSDLParser.parse(File.read(wsdl_file_path))
       @concrete_abstract_mapping = {}

data/lib/bing_ads_ruby_sdk/configuration.rb

@@ -24,4 +24,4 @@ module BingAdsRubySdk
       end
     end
   end
-end
+end

data/lib/bing_ads_ruby_sdk/errors/error_handler.rb

@@ -36,7 +36,7 @@ module BingAdsRubySdk
       end
 
       def partial_errors
-        response.select {|key| partial_error_keys.include?(key)}
+        response.select { |key| partial_error_keys.include?(key) }
       end
 
       # Gets populated partial error keys from the response

data/lib/bing_ads_ruby_sdk/errors/errors.rb

@@ -9,11 +9,11 @@ module BingAdsRubySdk
       def initialize(response)
         @raw_response = response
 
-        code = response[:error_code] || 'Bing Ads API error'
+        code = response[:error_code] || "Bing Ads API error"
 
         message = response[:message] ||
-                    response[:faultstring] ||
-                      'See exception details for more information.'
+          response[:faultstring] ||
+          "See exception details for more information."
 
         @message = format_message(code, message)
       end
@@ -23,7 +23,7 @@ module BingAdsRubySdk
       # Format the message separated by hyphen if
       # there is a code and a message
       def format_message(code, message)
-        [code, message].compact.join(' - ')
+        [code, message].compact.join(" - ")
       end
     end
 
@@ -47,7 +47,7 @@ module BingAdsRubySdk
 
         first_message = first_error_message(error_list)
         if error_list.count > 1
-          "API raised #{ error_list.count } errors, including: #{first_message}"
+          "API raised #{error_list.count} errors, including: #{first_message}"
         else
           first_message
         end
@@ -81,7 +81,7 @@ module BingAdsRubySdk
       # The fault key that corresponds to the inherited class
       # @return [Symbol] the fault key
       def fault_key
-        class_name = self.class.name.split('::').last
+        class_name = self.class.name.split("::").last
         BingAdsRubySdk::StringUtils.snakize(class_name).to_sym
       end
 
@@ -100,9 +100,7 @@ module BingAdsRubySdk
       end
 
       class << self
-        def error_lists=(value)
-          @error_lists = value
-        end
+        attr_writer :error_lists
 
         def error_lists
           @error_lists ||= []
@@ -118,7 +116,6 @@ module BingAdsRubySdk
 
     # Base class for handling partial errors
     class PartialErrorBase < ApplicationFault
-
       private
 
       # The parent hash for this type of error is the root of the response
@@ -140,6 +137,7 @@ module BingAdsRubySdk
       define_error_lists :batch_error
 
       private
+
       def fault_key
         :partial_errors
       end
@@ -149,6 +147,7 @@ module BingAdsRubySdk
       define_error_lists :batch_error_collection
 
       private
+
       def fault_key
         :nested_partial_errors
       end

data/lib/bing_ads_ruby_sdk/header.rb

@@ -18,9 +18,9 @@ module BingAdsRubySdk
     def content
       {
         "AuthenticationToken" => auth_handler.fetch_or_refresh,
-        "DeveloperToken" =>      developer_token,
-        "CustomerId" =>          customer[:customer_id],
-        "CustomerAccountId" =>   customer[:account_id]
+        "DeveloperToken" => developer_token,
+        "CustomerId" => customer[:customer_id],
+        "CustomerAccountId" => customer[:account_id]
       }.tap do |hash|
         hash["ClientSecret"] = client_secret if client_secret
       end

data/lib/bing_ads_ruby_sdk/http_client.rb

@@ -10,7 +10,7 @@ module BingAdsRubySdk
     HTTP_READ_TIMEOUT = 20
     HTTP_RETRY_COUNT_ON_TIMEOUT = 2
     HTTP_INTERVAL_RETRY_COUNT_ON_TIMEOUT = 1
-    HTTP_ERRORS = [ Net::HTTPServerError, Net::HTTPClientError ]
+    HTTP_ERRORS = [Net::HTTPServerError, Net::HTTPClientError]
     CONNECTION_SETTINGS = {
       persistent: true,
       tcp_nodelay: true,
@@ -20,17 +20,17 @@ module BingAdsRubySdk
       connect_timeout: HTTP_OPEN_TIMEOUT,
       read_timeout: HTTP_READ_TIMEOUT,
       ssl_version: :TLSv1_2,
-      ciphers: "TLSv1.2:!aNULL:!eNULL",
+      ciphers: "TLSv1.2:!aNULL:!eNULL"
     }
 
     class << self
       def post(request)
         uri = URI(request.url)
-        conn = self.connection(request.url)
+        conn = connection(request.url)
         raw_response = conn.post(
           path: uri.path,
           body: request.content,
-          headers: request.headers,
+          headers: request.headers
         )
 
         if contains_error?(raw_response)
@@ -44,7 +44,7 @@ module BingAdsRubySdk
       end
 
       def close_http_connections
-        self.http_connections.values.each do |connection|
+        http_connections.values.each do |connection|
           connection.reset
         end
       end
@@ -65,7 +65,7 @@ module BingAdsRubySdk
       end
 
       def connection(host)
-        self.http_connections[host] ||= Excon.new(
+        http_connections[host] ||= Excon.new(
           host,
           connection_settings
         )

data/lib/bing_ads_ruby_sdk/log_message.rb

@@ -2,7 +2,6 @@
 
 module BingAdsRubySdk
   class LogMessage
-
     def initialize(message)
       @message = message
     end
@@ -43,7 +42,7 @@ module BingAdsRubySdk
     end
 
     def nokogiri_options
-      pretty_print ? { indent: 2 } : { save_with: Nokogiri::XML::Node::SaveOptions::AS_XML }
+      pretty_print ? {indent: 2} : {save_with: Nokogiri::XML::Node::SaveOptions::AS_XML}
     end
 
     def pretty_print
@@ -54,4 +53,4 @@ module BingAdsRubySdk
       BingAdsRubySdk.config.filters
     end
   end
-end
+end