bing_ads_ruby_sdk 1.3.4 → 1.5.0

data/spec/examples/4_with_conversion_goal/conversion_goals_spec.rb

@@ -1,20 +1,20 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'Conversion goals methods' do
-  include_context 'use api'
+RSpec.describe "Conversion goals methods" do
+  include_context "use api"
 
   let(:a_conversion_goal) do
     {
       conversion_window_in_minutes: a_kind_of(String),
       count_type: a_kind_of(String),
       id: a_kind_of(String),
-      name: a_string_starting_with('Acceptance Test Conversion goal'),
+      name: a_string_starting_with("Acceptance Test Conversion goal"),
       revenue: a_kind_of(Hash),
       scope: a_kind_of(String),
       status: a_kind_of(String),
       tag_id: Examples.uet_tag_id.to_s,
       tracking_status: a_kind_of(String),
-      type: 'Event',
+      type: "Event",
       action_expression: a_kind_of(String),
       action_operator: a_kind_of(String),
       category_expression: a_kind_of(String),
@@ -27,19 +27,19 @@ RSpec.describe 'Conversion goals methods' do
     }
   end
 
-  describe '#get_conversion_goals_by_ids' do
-    it 'returns a list of conversion goals' do
+  describe "#get_conversion_goals_by_ids" do
+    it "returns a list of conversion goals" do
       expect(api.campaign_management.get_conversion_goals_by_ids(
-        conversion_goal_types: 'Event',
-        conversion_goal_ids: [{ long: Examples.conversion_goal_id }]
-     )).to contain_exactly(a_conversion_goal)
+        conversion_goal_types: "Event",
+        conversion_goal_ids: [{long: Examples.conversion_goal_id}]
+      )).to contain_exactly(a_conversion_goal)
     end
   end
 
-  describe '#get_conversion_goals_by_tag_ids' do
-    it 'returns a list of conversion_goals' do
+  describe "#get_conversion_goals_by_tag_ids" do
+    it "returns a list of conversion_goals" do
       expect(api.campaign_management.call(:get_conversion_goals_by_tag_ids, {
-        conversion_goal_types: 'Event',
+        conversion_goal_types: "Event",
         tag_ids: [long: Examples.uet_tag_id]
       })).to include(
         conversion_goals: {
@@ -50,25 +50,26 @@ RSpec.describe 'Conversion goals methods' do
     end
   end
 
-  describe '#update_conversion_goals' do
-    it 'updates the conversion goals' do
+  describe "#update_conversion_goals" do
+    it "updates the conversion goals" do
       expect(
         api.campaign_management.update_conversion_goals(
           conversion_goals: {
             event_goal: {
               id: Examples.conversion_goal_id,
-              name: "Acceptance Test Conversion goal #{random}",
+              name: "Acceptance Test Conversion goal #{random}"
             }
-          })
-      ).to eq(partial_errors: '')
+          }
+        )
+      ).to eq(partial_errors: "")
 
       updated_conversion = api.campaign_management.get_conversion_goals_by_ids(
-        conversion_goal_types: 'Event',
-        conversion_goal_ids: [{ long: Examples.conversion_goal_id }]
-     ).first
+        conversion_goal_types: "Event",
+        conversion_goal_ids: [{long: Examples.conversion_goal_id}]
+      ).first
 
       expect(updated_conversion).to include(
-        name:"Acceptance Test Conversion goal #{random}"
+        name: "Acceptance Test Conversion goal #{random}"
       )
     end
   end

data/spec/examples/5_with_campaign/ad_extension_spec.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative '../examples'
+require_relative "../examples"
 
 RSpec.describe "AdExtension methods" do
   include_context "use api"
@@ -26,8 +26,8 @@ RSpec.describe "AdExtension methods" do
             description_1: "Description 1 - #{Examples.random}"[0..34],
             description_2: "Description 2 - #{Examples.random}"[0..34],
             display_text: "Display Text #{Examples.random}"[0..24],
-            final_mobile_urls: [ { string: "http://mobile.example.com" } ],
-            final_urls: [ { string: "http://www.example.com" } ],
+            final_mobile_urls: [{string: "http://mobile.example.com"}],
+            final_urls: [{string: "http://www.example.com"}],
             tracking_url_template: "{lpurl}"
           }
         }
@@ -61,26 +61,25 @@ RSpec.describe "AdExtension methods" do
       account_id: Examples.account_id,
       ad_extension_type: "CallAdExtension SitelinkAdExtension CalloutAdExtension",
       association_type: "Campaign",
-      entity_ids: [{ long: Examples.campaign_id }]
+      entity_ids: [{long: Examples.campaign_id}]
     )
   end
 
   context "with shared ad extensions" do
     before(:all) do
-      # we use a global var to create ad extensions once, its enough
-      $created_ad_extension_response = create_add_ad_extensions
-      set_ad_extensions_associations(ad_extension_ids($created_ad_extension_response))
+      @created_ad_extension_response = create_add_ad_extensions
+      set_ad_extensions_associations(ad_extension_ids(@created_ad_extension_response))
     end
 
     describe "#add_ad_extensions" do
       it "returns AdExtension ids" do
-        expect($created_ad_extension_response).to include(
+        expect(@created_ad_extension_response).to include(
           ad_extension_identities: {
             ad_extension_identity: [
-              { id: a_kind_of(String), version: "1" },
-              { id: a_kind_of(String), version: "1" },
-              { id: a_kind_of(String), version: "1" },
-            ],
+              {id: a_kind_of(String), version: "1"},
+              {id: a_kind_of(String), version: "1"},
+              {id: a_kind_of(String), version: "1"}
+            ]
           },
           nested_partial_errors: ""
         )
@@ -102,7 +101,7 @@ RSpec.describe "AdExtension methods" do
             is_call_only: "false",
             is_call_tracking_enabled: "false",
             phone_number: match(/[0-9]*/),
-            require_toll_free_tracking_number: nil,
+            require_toll_free_tracking_number: nil
           },
           association_type: "Campaign",
           editorial_status: a_kind_of(String),
@@ -160,7 +159,7 @@ RSpec.describe "AdExtension methods" do
       end
 
       def get_association(associations, type)
-        associations.select { |record| record[:ad_extension][:type] == type }.first
+        associations.find { |record| record[:ad_extension][:type] == type }
       end
 
       it "returns a list of Associations" do
@@ -182,9 +181,9 @@ RSpec.describe "AdExtension methods" do
       it "returns a list of IDs" do
         fetched_ad_extension_ids = api.campaign_management.get_ad_extension_ids_by_account_id(
           account_id: Examples.account_id,
-          ad_extension_type: 'SitelinkAdExtension CallAdExtension CalloutAdExtension'
+          ad_extension_type: "SitelinkAdExtension CallAdExtension CalloutAdExtension"
         )
-        ad_extension_ids($created_ad_extension_response).each do |id|
+        ad_extension_ids(@created_ad_extension_response).each do |id|
           expect(fetched_ad_extension_ids).to include id
         end
       end
@@ -194,8 +193,8 @@ RSpec.describe "AdExtension methods" do
       it "returns AdExtensions" do
         extensions = api.campaign_management.get_ad_extensions_by_ids(
           account_id: Examples.account_id,
-          ad_extension_ids: ad_extension_ids($created_ad_extension_response).map { |id| { long: id } },
-          ad_extension_type: 'SitelinkAdExtension CallAdExtension CalloutAdExtension'
+          ad_extension_ids: ad_extension_ids(@created_ad_extension_response).map { |id| {long: id} },
+          ad_extension_type: "SitelinkAdExtension CallAdExtension CalloutAdExtension"
         )
         expect(extensions).to be_an(Array)
       end
@@ -208,8 +207,7 @@ RSpec.describe "AdExtension methods" do
     it "returns no errors" do
       expect(api.campaign_management.call(:delete_ad_extensions,
         account_id: Examples.account_id,
-        ad_extension_ids: [ { long: ad_extension_ids(response).first }]
-      )).to eq(partial_errors: "")
+        ad_extension_ids: [{long: ad_extension_ids(response).first}])).to eq(partial_errors: "")
     end
   end
 
@@ -228,11 +226,10 @@ RSpec.describe "AdExtension methods" do
         ad_extension_id_to_entity_id_associations: [
           ad_extension_id_to_entity_id_association: {
             ad_extension_id: ad_extension_id,
-            entity_id: Examples.campaign_id,
+            entity_id: Examples.campaign_id
           }
         ],
-        association_type: "Campaign"
-      )).to eq(partial_errors: "")
+        association_type: "Campaign")).to eq(partial_errors: "")
     end
   end
 end

data/spec/examples/5_with_campaign/ad_group_spec.rb

@@ -1,32 +1,31 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'AdGroup methods' do
-  include_context 'use api'
+RSpec.describe "AdGroup methods" do
+  include_context "use api"
 
-  describe '#add_ad_groups' do
-    it 'returns created AdGroup ids' do
+  describe "#add_ad_groups" do
+    it "returns created AdGroup ids" do
       ad_groups = api.campaign_management.call(:add_ad_groups,
         campaign_id: Examples.campaign_id,
         ad_groups: {
           ad_group: {
             name: "AcceptanceTestAdGroup - #{random}",
-            language: 'French',
+            language: "French",
             start_date: {
-              day: '1',
-              month: '1',
-              year: '2049',
+              day: "1",
+              month: "1",
+              year: "2049"
             },
             end_date: {
-              day: '1',
-              month: '2',
-              year: '2049',
+              day: "1",
+              month: "2",
+              year: "2049"
             }
           }
-        }
-      )
+        })
       expect(ad_groups).to include(
         ad_group_ids: [a_kind_of(Integer)],
-        partial_errors: ''
+        partial_errors: ""
       )
 
       puts "Please fill in examples.rb with ad_group_id: #{ad_groups[:ad_group_ids].first}"

data/spec/examples/5_with_campaign/campaign_criterions_spec.rb

@@ -1,7 +1,7 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'CampaignCriterion methods' do
-  include_context 'use api'
+RSpec.describe "CampaignCriterion methods" do
+  include_context "use api"
 
   def add_campaign_criterions(location_id)
     api.campaign_management.call(:add_campaign_criterions,
@@ -15,59 +15,57 @@ RSpec.describe 'CampaignCriterion methods' do
           }
         }
       ],
-      criterion_type: 'Targets'
-    )
+      criterion_type: "Targets")
   end
 
-  describe '#add_campaign_criterions' do
-    it 'returns CampaignCriterion ids' do
+  describe "#add_campaign_criterions" do
+    it "returns CampaignCriterion ids" do
       expect(add_campaign_criterions(190)).to include(
         campaign_criterion_ids: [a_kind_of(Integer)],
-        nested_partial_errors: ''
+        nested_partial_errors: ""
       )
     end
   end
 
-  describe '#delete_campaign_criterions' do
-    it 'returns no errors' do
+  describe "#delete_campaign_criterions" do
+    it "returns no errors" do
       response = add_campaign_criterions(191)
 
       expect(api.campaign_management.call(:delete_campaign_criterions,
         campaign_criterion_ids: [
-          { long: response[:campaign_criterion_ids].first }
+          {long: response[:campaign_criterion_ids].first}
         ],
         campaign_id: Examples.campaign_id,
-        criterion_type: 'Targets'
-      )).to eq(
-        partial_errors: ''
-      )
+        criterion_type: "Targets")).to eq(
+          partial_errors: ""
+        )
     end
   end
 
-  describe '#get_campaign_criterions_by_ids' do
-    it 'returns CampaignCriterions' do
+  describe "#get_campaign_criterions_by_ids" do
+    it "returns CampaignCriterions" do
       response = add_campaign_criterions(193)
       criterion_id = response[:campaign_criterion_ids].first.to_s
 
       criterions = api.campaign_management.get_campaign_criterions_by_ids(
-        campaign_criterion_ids: [{ long: criterion_id }],
+        campaign_criterion_ids: [{long: criterion_id}],
         campaign_id: Examples.campaign_id,
-        criterion_type: 'Age DayTime Device Gender Location LocationIntent Radius'
+        criterion_type: "Age DayTime Device Gender Location LocationIntent Radius"
       )
 
       expect(criterions).to include(
         campaign_id: Examples.campaign_id.to_s,
         criterion: {
-          type: 'LocationCriterion',
+          type: "LocationCriterion",
           display_name: a_kind_of(String),
           enclosed_location_ids: nil,
-          location_id: '193',
-          location_type: a_kind_of(String),
+          location_id: "193",
+          location_type: a_kind_of(String)
         },
         forward_compatibility_map: nil,
         id: criterion_id,
         status: a_kind_of(String),
-        type: 'NegativeCampaignCriterion'
+        type: "NegativeCampaignCriterion"
       )
     end
   end

data/spec/examples/5_with_campaign/campaign_spec.rb

@@ -1,18 +1,18 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'CampaignManagement service' do
-  include_context 'use api'
+RSpec.describe "CampaignManagement service" do
+  include_context "use api"
 
-  describe 'Campaign methods' do
+  describe "Campaign methods" do
     let(:a_campaign_hash) do
       a_hash_including(
         audience_ads_bid_adjustment: a_kind_of(String),
         bidding_scheme: a_kind_of(Hash),
         budget_type: a_kind_of(String),
         daily_budget: a_kind_of(String),
-        forward_compatibility_map: '',
+        forward_compatibility_map: "",
         id: Examples.campaign_id.to_s,
-        name: a_string_starting_with('Acceptance Test Campaign'),
+        name: a_string_starting_with("Acceptance Test Campaign"),
         status: a_kind_of(String),
         time_zone: a_kind_of(String),
         tracking_url_template: nil,
@@ -23,28 +23,28 @@ RSpec.describe 'CampaignManagement service' do
         languages: nil,
         experiment_id: nil,
         final_url_suffix: nil,
-        sub_type: nil,
+        sub_type: nil
       )
     end
 
-    describe '#get_campaigns_by_account_id' do
-      it 'returns a list of campaigns' do
+    describe "#get_campaigns_by_account_id" do
+      it "returns a list of campaigns" do
         expect(api.campaign_management.get_campaigns_by_account_id(
           account_id: Examples.account_id
         )).to include(a_campaign_hash)
       end
     end
 
-    describe '#get_campaigns_by_ids' do
-      it 'returns a list of campaigns' do
+    describe "#get_campaigns_by_ids" do
+      it "returns a list of campaigns" do
         expect(api.campaign_management.get_campaigns_by_ids(
           account_id: Examples.account_id,
-          campaign_ids: [{ long: Examples.campaign_id }]
+          campaign_ids: [{long: Examples.campaign_id}]
         )).to include(a_campaign_hash)
       end
     end
 
-    describe '#update_campaigns' do
+    describe "#update_campaigns" do
       subject do
         api.campaign_management.call(:update_campaigns,
           account_id: Examples.account_id,
@@ -53,15 +53,14 @@ RSpec.describe 'CampaignManagement service' do
               id: Examples.campaign_id,
               name: "Acceptance Test Campaign - #{random}"
             ]
-          }
-        )
+          })
       end
 
-      it 'returns no errors' do
-        is_expected.to eq(partial_errors: '')
+      it "returns no errors" do
+        is_expected.to eq(partial_errors: "")
         updated_campaign = api.campaign_management.get_campaigns_by_ids(
           account_id: Examples.account_id,
-          campaign_ids: [{ long: Examples.campaign_id }]
+          campaign_ids: [{long: Examples.campaign_id}]
         ).first
 
         expect(updated_campaign).to include(name: "Acceptance Test Campaign - #{random}")

data/spec/examples/6_with_ad_group/ad_group_spec.rb

@@ -1,7 +1,7 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'AdGroup methods' do
-  include_context 'use api'
+RSpec.describe "AdGroup methods" do
+  include_context "use api"
 
   let(:ad_group_record) do
     a_hash_including(
@@ -14,40 +14,40 @@ RSpec.describe 'AdGroup methods' do
       network: a_kind_of(String),
       settings: nil,
       start_date: {
-        day: '1',
-        month: '1',
-        year: '2049',
+        day: "1",
+        month: "1",
+        year: "2049"
       },
       end_date: {
-        day: '1',
-        month: '2',
-        year: '2049',
+        day: "1",
+        month: "2",
+        year: "2049"
       },
       status: a_kind_of(String),
       tracking_url_template: nil,
-      url_custom_parameters: nil,
+      url_custom_parameters: nil
     )
   end
 
-  describe '#get_ad_groups_by_ids' do
-    it 'returns AdGroups' do
+  describe "#get_ad_groups_by_ids" do
+    it "returns AdGroups" do
       expect(api.campaign_management.get_ad_groups_by_ids(
         campaign_id: Examples.campaign_id,
-        ad_group_ids: [ { long: Examples.ad_group_id } ]
+        ad_group_ids: [{long: Examples.ad_group_id}]
       )).to include(ad_group_record)
     end
   end
 
-  describe '#get_ad_groups_by_campaign_id' do
-    it 'returns AdGroups' do
+  describe "#get_ad_groups_by_campaign_id" do
+    it "returns AdGroups" do
       expect(api.campaign_management.get_ad_groups_by_campaign_id(
         campaign_id: Examples.campaign_id
       )).to include(ad_group_record)
     end
   end
 
-  describe '#update_ad_groups' do
-    it 'updates the ad' do
+  describe "#update_ad_groups" do
+    it "updates the ad" do
       expect(api.campaign_management.call(:update_ad_groups,
         campaign_id: Examples.campaign_id,
         ad_groups: {
@@ -55,12 +55,11 @@ RSpec.describe 'AdGroup methods' do
             id: Examples.ad_group_id,
             name: "AcceptanceTestAdGroup - #{random}"
           }]
-        }
-      )).to eq(partial_errors: '', inherited_bid_strategy_types: nil)
+        })).to eq(partial_errors: "", inherited_bid_strategy_types: nil)
 
       ad_group = api.campaign_management.get_ad_groups_by_ids(
         campaign_id: Examples.campaign_id,
-        ad_group_ids: [ { long: Examples.ad_group_id } ]
+        ad_group_ids: [{long: Examples.ad_group_id}]
       ).first
 
       expect(ad_group).to include(

data/spec/examples/6_with_ad_group/ads_spec.rb

@@ -1,7 +1,7 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'Ad methods' do
-  include_context 'use api'
+RSpec.describe "Ad methods" do
+  include_context "use api"
 
   def add_ads
     api.campaign_management.call(:add_ads,
@@ -9,49 +9,48 @@ RSpec.describe 'Ad methods' do
       ads: [
         {
           expanded_text_ad: {
-            ad_format_preference: 'All',
-            domain: 'https://www.example.com/',
-            final_urls: [string: 'http://www.contoso.com/'],
-            path_1: 'subdirectory1',
-            path_2: 'su§bdirectory2',
-            text: 'Ad text goes here',
-            title_part_1: 'Title goes here',
-            title_part_2: 'Title 2 goes here',
-            status: 'Paused',
-            tracking_url_template: '{lpurl}',
-          },
-        },
-      ]
-    )
+            ad_format_preference: "All",
+            domain: "https://www.example.com/",
+            final_urls: [string: "http://www.contoso.com/"],
+            path_1: "subdirectory1",
+            path_2: "su§bdirectory2",
+            text: "Ad text goes here",
+            title_part_1: "Title goes here",
+            title_part_2: "Title 2 goes here",
+            status: "Paused",
+            tracking_url_template: "{lpurl}"
+          }
+        }
+      ])
   end
 
   def get_ads
     api.campaign_management.get_ads_by_ad_group_id(
       ad_group_id: Examples.ad_group_id,
       ad_types: [
-        { ad_type: 'Text' },
-        { ad_type: 'Image' },
-        { ad_type: 'Product' },
-        { ad_type: 'AppInstall' },
-        { ad_type: 'ExpandedText' },
-        { ad_type: 'DynamicSearch' },
+        {ad_type: "Text"},
+        {ad_type: "Image"},
+        {ad_type: "Product"},
+        {ad_type: "AppInstall"},
+        {ad_type: "ExpandedText"},
+        {ad_type: "DynamicSearch"}
       ]
     )
   end
 
-  describe '#add_ads' do
-    it 'returns created Ad ids' do
+  describe "#add_ads" do
+    it "returns created Ad ids" do
       expect(add_ads).to include(
         ad_ids: [a_kind_of(Integer)],
-        partial_errors: ''
+        partial_errors: ""
       )
     end
   end
 
-  describe '#get_ads_by_ad_group_id' do
+  describe "#get_ads_by_ad_group_id" do
     before { add_ads }
 
-    it 'returns a list of ads' do
+    it "returns a list of ads" do
       expect(get_ads).to include(
         {
           ad_format_preference: a_kind_of(String),
@@ -71,43 +70,41 @@ RSpec.describe 'Ad methods' do
           path1: a_kind_of(String),
           path2: a_kind_of(String),
           text: a_kind_of(String),
-          text_part2: '',
+          text_part2: "",
           title_part1: a_kind_of(String),
           title_part2: a_kind_of(String),
-          title_part3: ''
+          title_part3: ""
         }
       )
     end
   end
 
-  describe '#update_ads' do
+  describe "#update_ads" do
     before { add_ads }
 
-    it 'updates the Ad' do
+    it "updates the Ad" do
       expect(api.campaign_management.call(:update_ads,
         ad_group_id: Examples.ad_group_id,
         ads: {
           expanded_text_ad: [{
             id: get_ads.first[:id],
             text: "Ad text goes here - #{random}"
-          }],
-        }
-      )).to eq(partial_errors: '')
+          }]
+        })).to eq(partial_errors: "")
 
-      expect(get_ads.first).to include( text: "Ad text goes here - #{random}")
+      expect(get_ads.first).to include(text: "Ad text goes here - #{random}")
     end
   end
 
-  describe 'test_delete_ads' do
+  describe "test_delete_ads" do
     let(:ad_id) { add_ads[:ad_ids].first }
 
-    it 'returns no errors' do
+    it "returns no errors" do
       expect(api.campaign_management.call(:delete_ads,
         ad_group_id: Examples.ad_group_id,
-        ad_ids: [long: ad_id]
-      )).to eq(partial_errors: '')
+        ad_ids: [long: ad_id])).to eq(partial_errors: "")
 
-      expect(get_ads.map{|h| h[:id]}).not_to include ad_id.to_s
+      expect(get_ads.map { |h| h[:id] }).not_to include ad_id.to_s
     end
   end
 end