bing_ads_ruby_sdk 1.3.4 → 1.5.0

data/spec/examples/6_with_ad_group/keywords_spec.rb

@@ -1,9 +1,9 @@
-require_relative '../examples'
+require_relative "../examples"
 
-RSpec.describe 'Keyword methods' do
-  include_context 'use api'
+RSpec.describe "Keyword methods" do
+  include_context "use api"
 
-  describe 'Keyword methods' do
+  describe "Keyword methods" do
     let(:a_keyword) do
       {
         bid: a_kind_of(Hash),
@@ -23,7 +23,7 @@ RSpec.describe 'Keyword methods' do
         status: a_kind_of(String),
         text: a_kind_of(String),
         tracking_url_template: nil,
-        url_custom_parameters: nil,
+        url_custom_parameters: nil
       }
     end
 
@@ -31,77 +31,74 @@ RSpec.describe 'Keyword methods' do
     let(:add_keywords) do
       api.campaign_management.call(:add_keywords,
         ad_group_id: Examples.ad_group_id,
-        keywords: { keyword: {
-          bid: { amount: 0.05 },
-          match_type: 'Exact',
-          text: "AcceptanceTestKeyword - #{random}",
-        } }
-      )
+        keywords: {keyword: {
+          bid: {amount: 0.05},
+          match_type: "Exact",
+          text: "AcceptanceTestKeyword - #{random}"
+        }})
     end
 
-    describe '#add_keywords' do
-      it 'returns created Keyword ids' do
+    describe "#add_keywords" do
+      it "returns created Keyword ids" do
         expect(add_keywords).to include(
           keyword_ids: [a_kind_of(Integer)],
-          partial_errors: ''
+          partial_errors: ""
         )
       end
     end
 
-    describe '#get_keywords_by_ad_group_id' do
+    describe "#get_keywords_by_ad_group_id" do
       before { add_keywords }
 
-      it 'returns a list of keywords' do
+      it "returns a list of keywords" do
         expect(api.campaign_management.get_keywords_by_ad_group_id(
           ad_group_id: Examples.ad_group_id
         )).to include(a_keyword)
       end
     end
 
-    describe '#get_keywords_by_editorial_status' do
+    describe "#get_keywords_by_editorial_status" do
       before { add_keywords }
 
-      it 'returns a list of Keywords' do
+      it "returns a list of Keywords" do
         expect(api.campaign_management.get_keywords_by_editorial_status(
           ad_group_id: Examples.ad_group_id,
-          editorial_status: 'Active'
+          editorial_status: "Active"
         )).to include(a_keyword)
       end
     end
 
-    describe '#get_keywords_by_ids' do
+    describe "#get_keywords_by_ids" do
       before { add_keywords }
 
-      it 'returns a list of Keywords' do
+      it "returns a list of Keywords" do
         expect(api.campaign_management.get_keywords_by_ids(
           ad_group_id: Examples.ad_group_id,
-          keyword_ids: [{ long: keyword_id }]
+          keyword_ids: [{long: keyword_id}]
         )).to include(a_keyword)
       end
     end
 
-    describe '#update_keywords' do
+    describe "#update_keywords" do
       before { add_keywords }
 
-      it 'updates the keyword' do
+      it "updates the keyword" do
         expect(api.campaign_management.call(:update_keywords,
           ad_group_id: Examples.ad_group_id,
-          keywords: { keyword: [
+          keywords: {keyword: [
             id: keyword_id,
-            bid: { amount: 0.50 },
-          ] }
-        )).to include(partial_errors: '')
+            bid: {amount: 0.50}
+          ]})).to include(partial_errors: "")
       end
     end
 
-    describe '#delete_keywords' do
+    describe "#delete_keywords" do
       before { add_keywords }
 
-      it 'returns no errors' do
+      it "returns no errors" do
         expect(api.campaign_management.call(:delete_keywords,
           ad_group_id: Examples.ad_group_id,
-          keyword_ids: [{ long: keyword_id }]
-        )).to eq(partial_errors: '')
+          keyword_ids: [{long: keyword_id}])).to eq(partial_errors: "")
       end
     end
   end

data/spec/examples/examples.rb

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
 
-require 'securerandom'
+require "securerandom"
 
 module Examples
   class << self
-
     def random
       SecureRandom.hex
     end
@@ -65,12 +64,12 @@ module Examples
     end
 
     def store_filename
-      ENV.fetch('BING_STORE_FILENAME')
+      ENV.fetch("BING_STORE_FILENAME")
     end
   end
 end
 
-RSpec.shared_context 'use api' do
+RSpec.shared_context "use api" do
   let(:random) { Examples.random }
   let(:api) { Examples.build_api }
 end

data/spec/spec_helper.rb

@@ -1,16 +1,16 @@
-require 'simplecov'
-require 'dotenv/load'
-require 'byebug'
+require "simplecov"
+require "dotenv/load"
+require "byebug"
 
 SimpleCov.start do
-  add_filter '/spec/'
+  add_filter "/spec/"
 end
 
-require 'bing_ads_ruby_sdk'
+require "bing_ads_ruby_sdk"
 
-Dir[File.join(BingAdsRubySdk.root_path, "spec", "support", "**", "*.rb")].each { |f| require f }
-Dir[File.join(BingAdsRubySdk.root_path, "log", "*.log")].each do |log_file|
-  File.open(log_file, 'w') { |f| f.truncate(0) }
+Dir[File.join(BingAdsRubySdk.root_path, "spec", "support", "**", "*.rb")].sort.each { |f| require f }
+Dir[File.join(BingAdsRubySdk.root_path, "log", "*.log")].sort.each do |log_file|
+  File.open(log_file, "w") { |f| f.truncate(0) }
 end
 
 BingAdsRubySdk.configure do |conf|
@@ -22,7 +22,7 @@ end
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure
-  config.example_status_persistence_file_path = '.rspec_status'
+  config.example_status_persistence_file_path = ".rspec_status"
 
   # Disable RSpec exposing methods globally on `Module` and `main`
   config.disable_monkey_patching!
@@ -30,4 +30,4 @@ RSpec.configure do |config|
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
-end
+end

data/spec/support/spec_helpers.rb

@@ -11,17 +11,18 @@ module SpecHelpers
     OpenStruct.new(
       content: {
         "AuthenticationToken" => BingAdsRubySdk::LogMessage::FILTERED,
-        "DeveloperToken" =>      BingAdsRubySdk::LogMessage::FILTERED,
-        "CustomerId" =>          BingAdsRubySdk::LogMessage::FILTERED,
-        "CustomerAccountId" =>   BingAdsRubySdk::LogMessage::FILTERED
-    })
+        "DeveloperToken" => BingAdsRubySdk::LogMessage::FILTERED,
+        "CustomerId" => BingAdsRubySdk::LogMessage::FILTERED,
+        "CustomerAccountId" => BingAdsRubySdk::LogMessage::FILTERED
+      }
+    )
   end
 
   def self.soap_client(service, header = fake_header)
     BingAdsRubySdk::SoapClient.new(
       service_name: service,
       version: BingAdsRubySdk::DEFAULT_SDK_VERSION,
-      environment: 'test',
+      environment: "test",
       header: header
     )
   end
@@ -31,15 +32,15 @@ module SpecHelpers
   end
 
   def self.default_store
-    ::BingAdsRubySdk::OAuth2::FsStore.new(ENV['BING_STORE_FILENAME'])
+    ::BingAdsRubySdk::OAuth2::FsStore.new(ENV["BING_STORE_FILENAME"])
   end
 
   # default fixture for now is standard.xml but door is open to get more use cases
   def self.xml_path_for(service, action, filename, request = true)
     if request
-      File.join(BingAdsRubySdk.root_path, 'spec', 'fixtures', service.to_s, action, "#{filename}.xml")
+      File.join(BingAdsRubySdk.root_path, "spec", "fixtures", service.to_s, action, "#{filename}.xml")
     else
-      File.join(BingAdsRubySdk.root_path, 'spec', 'fixtures', service.to_s, action, "#{filename}_response.xml")
+      File.join(BingAdsRubySdk.root_path, "spec", "fixtures", service.to_s, action, "#{filename}_response.xml")
     end
   end
-end
+end

data/tasks/bing_ads_ruby_sdk.rake

@@ -1,13 +1,12 @@
-require 'dotenv/load'
+require "dotenv/load"
 
 namespace :bing_token do
   desc "Gets and stores Bing OAuth token in file"
   task :get, [:filename, :bing_developer_token, :bing_client_id, :bing_client_secret] do |task, args|
-
-    filename = args[:filename] || ENV.fetch('BING_STORE_FILENAME')
-    developer_token = args[:bing_developer_token] || ENV.fetch('BING_DEVELOPER_TOKEN')
-    bing_client_id = args[:bing_client_id] || ENV.fetch('BING_CLIENT_ID')
-    bing_client_secret = args[:bing_client_secret] || ENV.fetch('BING_CLIENT_SECRET', nil)
+    filename = args[:filename] || ENV.fetch("BING_STORE_FILENAME")
+    developer_token = args[:bing_developer_token] || ENV.fetch("BING_DEVELOPER_TOKEN")
+    bing_client_id = args[:bing_client_id] || ENV.fetch("BING_CLIENT_ID")
+    bing_client_secret = args[:bing_client_secret] || ENV.fetch("BING_CLIENT_SECRET", nil)
 
     store = ::BingAdsRubySdk::OAuth2::FsStore.new(filename)
     auth = BingAdsRubySdk::OAuth2::AuthorizationHandler.new(
@@ -17,9 +16,9 @@ namespace :bing_token do
       store: store
     )
     puts "Go to #{auth.code_url}",
-         "You will be redirected to a URL at the end. Paste it here in the console and press enter"
+      "You will be redirected to a URL at the end. Paste it here in the console and press enter"
 
-    full_url = STDIN.gets.chomp
+    full_url = $stdin.gets.chomp
     auth.fetch_from_url(full_url)
 
     puts "Written to store"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bing_ads_ruby_sdk
 version: !ruby/object:Gem::Version
-  version: 1.3.4
+  version: 1.5.0
 platform: ruby
 authors:
 - Effilab
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-08-25 00:00:00.000000000 Z
+date: 2022-11-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: signet
@@ -181,7 +181,7 @@ dependencies:
         version: 0.4.1
 description: Bing Ads Api Wrapper
 email:
-- developers@effilab-local.com
+- dev@effilab.com
 executables:
 - console
 - setup
@@ -189,8 +189,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
-- ".github/delete-merged-branch-config.yml"
-- ".github/stale.yml"
+- ".github/.keep"
+- ".github/renovate.json"
 - ".gitignore"
 - ".rspec"
 - Gemfile
@@ -335,91 +335,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.0'
+      version: '2.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.3
 signing_key: 
 specification_version: 4
 summary: Bing Ads Ruby SDK
-test_files:
-- spec/bing_ads_ruby_sdk/api_spec.rb
-- spec/bing_ads_ruby_sdk/errors/error_handler_spec.rb
-- spec/bing_ads_ruby_sdk/errors/errors_spec.rb
-- spec/bing_ads_ruby_sdk/header_spec.rb
-- spec/bing_ads_ruby_sdk/http_client_spec.rb
-- spec/bing_ads_ruby_sdk/oauth2/fs_store_spec.rb
-- spec/bing_ads_ruby_sdk/postprocessors/cast_long_arrays_spec.rb
-- spec/bing_ads_ruby_sdk/postprocessors/snakize_spec.rb
-- spec/bing_ads_ruby_sdk/preprocessors/camelize_spec.rb
-- spec/bing_ads_ruby_sdk/preprocessors/order_spec.rb
-- spec/bing_ads_ruby_sdk/services/bulk_spec.rb
-- spec/bing_ads_ruby_sdk/services/campaign_management_spec.rb
-- spec/bing_ads_ruby_sdk/services/customer_management_spec.rb
-- spec/bing_ads_ruby_sdk_spec.rb
-- spec/examples/1_customer_creation/customer_spec.rb
-- spec/examples/2_with_customer/budget_spec.rb
-- spec/examples/2_with_customer/campaigns_spec.rb
-- spec/examples/2_with_customer/customer_management_spec.rb
-- spec/examples/2_with_customer/uet_tags_spec.rb
-- spec/examples/3_with_uet_tag/conversion_goal_spec.rb
-- spec/examples/3_with_uet_tag/uet_tags_spec.rb
-- spec/examples/4_with_conversion_goal/conversion_goals_spec.rb
-- spec/examples/5_with_campaign/ad_extension_spec.rb
-- spec/examples/5_with_campaign/ad_group_spec.rb
-- spec/examples/5_with_campaign/campaign_criterions_spec.rb
-- spec/examples/5_with_campaign/campaign_spec.rb
-- spec/examples/6_with_ad_group/ad_group_spec.rb
-- spec/examples/6_with_ad_group/ads_spec.rb
-- spec/examples/6_with_ad_group/keywords_spec.rb
-- spec/examples/examples.rb
-- spec/fixtures/bulk/download_campaigns_by_account_ids/standard.xml
-- spec/fixtures/bulk/download_campaigns_by_account_ids/standard_response.xml
-- spec/fixtures/bulk/get_bulk_download_status/standard.xml
-- spec/fixtures/bulk/get_bulk_download_status/standard_response.xml
-- spec/fixtures/campaign_management/add_ad_extensions/standard.xml
-- spec/fixtures/campaign_management/add_ad_extensions/standard_response.xml
-- spec/fixtures/campaign_management/add_conversion_goals/standard.xml
-- spec/fixtures/campaign_management/add_conversion_goals/standard_response.xml
-- spec/fixtures/campaign_management/add_shared_entity/standard.xml
-- spec/fixtures/campaign_management/add_shared_entity/standard_response.xml
-- spec/fixtures/campaign_management/add_uet_tags/standard.xml
-- spec/fixtures/campaign_management/add_uet_tags/standard_response.xml
-- spec/fixtures/campaign_management/get_ad_extension_ids_by_account_id/standard.xml
-- spec/fixtures/campaign_management/get_ad_extension_ids_by_account_id/standard_response.xml
-- spec/fixtures/campaign_management/get_ad_extensions_associations/standard.xml
-- spec/fixtures/campaign_management/get_ad_extensions_associations/standard_response.xml
-- spec/fixtures/campaign_management/get_budgets_by_ids/standard.xml
-- spec/fixtures/campaign_management/get_budgets_by_ids/standard_response.xml
-- spec/fixtures/campaign_management/get_campaigns_by_account_id/standard.xml
-- spec/fixtures/campaign_management/get_campaigns_by_account_id/standard_response.xml
-- spec/fixtures/campaign_management/get_conversion_goals_by_ids/standard.xml
-- spec/fixtures/campaign_management/get_conversion_goals_by_ids/standard_response.xml
-- spec/fixtures/campaign_management/get_shared_entities_by_account_id/standard.xml
-- spec/fixtures/campaign_management/get_shared_entities_by_account_id/standard_response.xml
-- spec/fixtures/campaign_management/get_shared_entity_associations_by_entity_ids/standard.xml
-- spec/fixtures/campaign_management/get_shared_entity_associations_by_entity_ids/standard_response.xml
-- spec/fixtures/campaign_management/get_uet_tags_by_ids/standard.xml
-- spec/fixtures/campaign_management/get_uet_tags_by_ids/standard_response.xml
-- spec/fixtures/campaign_management/set_ad_extensions_associations/standard.xml
-- spec/fixtures/campaign_management/set_ad_extensions_associations/standard_response.xml
-- spec/fixtures/campaign_management/set_shared_entity_associations/standard.xml
-- spec/fixtures/campaign_management/set_shared_entity_associations/standard_response.xml
-- spec/fixtures/campaign_management/update_conversion_goals/standard.xml
-- spec/fixtures/campaign_management/update_conversion_goals/standard_response.xml
-- spec/fixtures/campaign_management/update_uet_tags/standard.xml
-- spec/fixtures/campaign_management/update_uet_tags/standard_response.xml
-- spec/fixtures/customer_management/find_accounts_or_customers_info/standard.xml
-- spec/fixtures/customer_management/find_accounts_or_customers_info/standard_response.xml
-- spec/fixtures/customer_management/get_account/standard.xml
-- spec/fixtures/customer_management/get_account/standard_response.xml
-- spec/fixtures/customer_management/signup_customer/standard.xml
-- spec/fixtures/customer_management/signup_customer/standard_response.xml
-- spec/fixtures/customer_management/update_account/standard.xml
-- spec/fixtures/customer_management/update_account/standard_response.xml
-- spec/spec_helper.rb
-- spec/support/spec_helpers.rb
+test_files: []

data/.github/delete-merged-branch-config.yml

@@ -1,6 +0,0 @@
-# https://github.com/SvanBoxel/delete-merged-branch
-exclude: 
-  - development
-  - production
-  - master
-#  - BranchNameToExclude*WildcardsSupported

data/.github/stale.yml

@@ -1,19 +0,0 @@
-# https://probot.github.io/apps/stale/
-
-# Number of days of inactivity before an issue becomes stale
-daysUntilStale: 30
-# Number of days of inactivity before a stale issue is closed
-daysUntilClose: 15
-# Issues with these labels will never be considered stale
-exemptLabels:
-  - keep
-# Label to use when marking an issue as stale
-staleLabel: autotag_Stale
-# Comment to post when marking an issue as stale. Set to `false` to disable
-markComment: >
-  This issue has been automatically marked as stale because it has not had
-  recent activity. It will be closed shortly if no further activity occurs. Thank you
-  for your contributions.
-# Comment to post when closing a stale issue. Set to `false` to disable
-closeComment: >
-  Closed automatically due to inactivity.