bigbluebutton_rails 1.4.0 → 2.0.0

data/spec/controllers/bigbluebutton/servers_controller_json_responses_spec.rb

@@ -35,6 +35,13 @@ describe Bigbluebutton::ServersController do
       let(:new_server) { FactoryGirl.build(:bigbluebutton_server) }
 
       context "on success" do
+        before {
+          api_mock = double(BigBlueButton::BigBlueButtonApi)
+          api_mock.stub(:version).and_return("0.9")
+          api_mock.stub(:get_default_config_xml)
+          api_mock.stub(:get_available_layouts)
+          BigBlueButton::BigBlueButtonApi.stub(:new).and_return(api_mock)
+        }
         before(:each) {
           post :create, :bigbluebutton_server => new_server.attributes, :format => 'json'
         }
@@ -63,6 +70,7 @@ describe Bigbluebutton::ServersController do
 
       context "on success" do
         before(:each) {
+          BigbluebuttonServer.any_instance.stub(:set_api_version_from_server)
           put :update, :id => @server.to_param, :bigbluebutton_server => new_server.attributes, :format => 'json'
         }
         it { should respond_with(:success) }

data/spec/controllers/bigbluebutton/servers_controller_spec.rb

@@ -2,21 +2,42 @@ require 'spec_helper'
 
 describe Bigbluebutton::ServersController do
   render_views
-  let(:server) { FactoryGirl.create(:bigbluebutton_server) }
+  let!(:server) { FactoryGirl.create(:bigbluebutton_server) }
 
   describe "#index" do
-    before { 3.times { FactoryGirl.create(:bigbluebutton_server) } }
-    before(:each) { get :index }
-    it { should respond_with(:success) }
-    it { should assign_to(:servers).with(BigbluebuttonServer.all) }
-    it { should render_template(:index) }
+    context "basic" do
+      before { 3.times { FactoryGirl.create(:bigbluebutton_server) } }
+      before(:each) { get :index }
+      it { should respond_with(:success) }
+      it { should assign_to(:servers).with(BigbluebuttonServer.all) }
+      it { should render_template(:index) }
+    end
+
+    context "doesn't override @servers" do
+      let!(:my_servers) { [ FactoryGirl.create(:bigbluebutton_server), FactoryGirl.create(:bigbluebutton_server) ] }
+      before {
+        3.times { FactoryGirl.create(:bigbluebutton_server) }
+        controller.instance_variable_set(:@servers, my_servers)
+      }
+      before(:each) { get :index }
+      it { should assign_to(:servers).with(my_servers) }
+    end
   end
 
   describe "#show" do
-    before(:each) { get :show, :id => server.to_param }
-    it { should respond_with(:success) }
-    it { should assign_to(:server).with(server) }
-    it { should render_template(:show) }
+    context "basic" do
+      before(:each) { get :show, :id => server.to_param }
+      it { should respond_with(:success) }
+      it { should assign_to(:server).with(server) }
+      it { should render_template(:show) }
+    end
+
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) { get :show, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#new" do
@@ -27,10 +48,19 @@ describe Bigbluebutton::ServersController do
   end
 
   describe "#edit" do
-    before(:each) { get :edit, :id => server.to_param }
-    it { should respond_with(:success) }
-    it { should assign_to(:server).with(server) }
-    it { should render_template(:edit) }
+    context "basic" do
+      before(:each) { get :edit, :id => server.to_param }
+      it { should respond_with(:success) }
+      it { should assign_to(:server).with(server) }
+      it { should render_template(:edit) }
+    end
+
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) { get :edit, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#create" do
@@ -58,7 +88,7 @@ describe Bigbluebutton::ServersController do
       let(:attrs) { FactoryGirl.attributes_for(:bigbluebutton_server) }
       let(:params) { { :bigbluebutton_server => attrs } }
       let(:allowed_params) {
-        [ :name, :url, :version, :salt, :param ]
+        [ :name, :url, :salt, :param ]
       }
 
       it {
@@ -102,6 +132,12 @@ describe Bigbluebutton::ServersController do
       end
     end
 
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) { post :create, :bigbluebutton_server => FactoryGirl.attributes_for(:bigbluebutton_server) }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#update" do
@@ -109,11 +145,14 @@ describe Bigbluebutton::ServersController do
     before { @server = server } # need this to trigger let(:server) and actually create the object
 
     context "on success" do
-      before :each do
+      let(:new_server) { FactoryGirl.build(:bigbluebutton_server, version: "") }
+
+      before {
+        BigBlueButton::BigBlueButtonApi.any_instance.should_receive(:get_api_version).and_return("0.9")
         expect {
-          put :update, :id => @server.to_param, :bigbluebutton_server => new_server.attributes
-        }.not_to change{ BigbluebuttonServer.count }
-      end
+          put :update, id: @server.to_param, bigbluebutton_server: new_server.attributes
+        }.not_to change { BigbluebuttonServer.count }
+      }
       it {
         saved = BigbluebuttonServer.find(@server)
         should respond_with(:redirect)
@@ -121,7 +160,8 @@ describe Bigbluebutton::ServersController do
       }
       it {
         saved = BigbluebuttonServer.find(@server)
-        saved.should have_same_attributes_as(new_server)
+        saved.should_not have_same_attributes_as(new_server)
+        saved.version.should == "0.9"
       }
       it { should set_the_flash.to(I18n.t('bigbluebutton_rails.servers.notice.update.success')) }
     end
@@ -139,7 +179,7 @@ describe Bigbluebutton::ServersController do
       let(:attrs) { FactoryGirl.attributes_for(:bigbluebutton_server) }
       let(:params) { { :bigbluebutton_server => attrs } }
       let(:allowed_params) {
-        [ :name, :url, :version, :salt, :param ]
+        [ :name, :url, :salt, :param ]
       }
 
       it {
@@ -166,6 +206,7 @@ describe Bigbluebutton::ServersController do
     context "with :redir_url" do
       context "on success" do
         before(:each) {
+          BigbluebuttonServer.any_instance.should_receive(:set_api_version_from_server).and_return(anything)
           put :update, :id => @server.to_param, :bigbluebutton_server => new_server.attributes, :redir_url => '/any'
         }
         it { should respond_with(:redirect) }
@@ -182,14 +223,22 @@ describe Bigbluebutton::ServersController do
       end
     end
 
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) {
+        BigbluebuttonServer.any_instance.should_receive(:set_api_version_from_server).and_return(anything)
+        put :update, :id => @server.to_param, :bigbluebutton_server => new_server.attributes
+      }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#destroy" do
     context "on success" do
     before(:each) {
-      @server = server
       expect {
-        delete :destroy, :id => @server.to_param
+        delete :destroy, :id => server.to_param
       }.to change{ BigbluebuttonServer.count }.by(-1)
     }
     it {
@@ -201,13 +250,19 @@ describe Bigbluebutton::ServersController do
     context "with :redir_url" do
       context "on success" do
         before(:each) {
-          @server = server
-          delete :destroy, :id => @server.to_param, :redir_url => '/any'
+          delete :destroy, :id => server.to_param, :redir_url => '/any'
         }
         it { should respond_with(:redirect) }
         it { should redirect_to "/any" }
       end
     end
+
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) { delete :destroy, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#activity" do
@@ -239,14 +294,13 @@ describe Bigbluebutton::ServersController do
       context "with params[:update_list]" do
         context "and :format nil" do
           before(:each) { get :activity, :id => server.to_param, :update_list => true }
-          it { should render_template(:activity_list) }
+          it { should render_template('bigbluebutton/servers/_activity_list') }
         end
         context "and :format = 'html'" do
           before(:each) { get :activity, :id => server.to_param, :update_list => true, :format => "html" }
-          it { should render_template(:activity_list) }
+          it { should render_template('bigbluebutton/servers/_activity_list') }
         end
       end
-
     end
 
     context "exception handling" do
@@ -270,18 +324,49 @@ describe Bigbluebutton::ServersController do
       end
     end
 
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before {
+        controller.instance_variable_set(:@server, other_server)
+        other_server.stub(:fetch_meetings)
+      }
+      before(:each) { get :activity, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
   end # #activity
 
   describe "#rooms" do
-    before do
-      @room1 = FactoryGirl.create(:bigbluebutton_room, :server => server)
-      @room2 = FactoryGirl.create(:bigbluebutton_room, :server => server)
-      FactoryGirl.create(:bigbluebutton_room)
+    context "basic" do
+      before do
+        @room1 = FactoryGirl.create(:bigbluebutton_room, :server => server)
+        @room2 = FactoryGirl.create(:bigbluebutton_room, :server => server)
+        FactoryGirl.create(:bigbluebutton_room)
+      end
+      before(:each) { get :rooms, :id => server.to_param }
+      it { should respond_with(:success) }
+      it { should render_template(:rooms) }
+      it { should assign_to(:rooms).with([@room1, @room2]) }
+    end
+
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) { get :rooms, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
+
+    context "doesn't override @rooms" do
+      let!(:my_rooms) {
+        [ FactoryGirl.create(:bigbluebutton_room, server: server),
+          FactoryGirl.create(:bigbluebutton_room, server: server) ]
+      }
+      before {
+        3.times { FactoryGirl.create(:bigbluebutton_room, server: server) }
+        controller.instance_variable_set(:@rooms, my_rooms)
+      }
+      before(:each) { get :rooms, :id => server.to_param }
+      it { should assign_to(:rooms).with(my_rooms) }
     end
-    before(:each) { get :rooms, :id => server.to_param }
-    it { should respond_with(:success) }
-    it { should render_template(:rooms) }
-    it { should assign_to(:rooms).with([@room1, @room2]) }
   end
 
   describe "#publish_recordings" do
@@ -333,6 +418,15 @@ describe Bigbluebutton::ServersController do
       end
     end
 
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before {
+        controller.instance_variable_set(:@server, other_server)
+        other_server.stub(:send_publish_recordings)
+      }
+      before(:each) { post :publish_recordings, :id => server.to_param, :recordings => recording_ids }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#unpublish_recordings" do
@@ -383,6 +477,15 @@ describe Bigbluebutton::ServersController do
       end
     end
 
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before {
+        controller.instance_variable_set(:@server, other_server)
+        other_server.stub(:send_publish_recordings)
+      }
+      before(:each) { post :unpublish_recordings, :id => server.to_param, :recordings => recording_ids }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#fetch_recordings" do
@@ -430,22 +533,54 @@ describe Bigbluebutton::ServersController do
         post :fetch_recordings, :id => server.to_param, :meta_first => "first-value", :meta_second => "second-value"
       }
     end
+
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before {
+        controller.instance_variable_set(:@server, other_server)
+        other_server.stub(:fetch_recordings)
+      }
+      before(:each) { post :fetch_recordings, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
   end
 
   describe "#recordings" do
-    before do
-      @recording1 = FactoryGirl.create(:bigbluebutton_recording, :server => server)
-      @recording2 = FactoryGirl.create(:bigbluebutton_recording, :server => server)
-      FactoryGirl.create(:bigbluebutton_recording)
+    context "basic" do
+      before do
+        @recording1 = FactoryGirl.create(:bigbluebutton_recording, :server => server)
+        @recording2 = FactoryGirl.create(:bigbluebutton_recording, :server => server)
+        FactoryGirl.create(:bigbluebutton_recording)
+
+        # one that belongs to another server but to a room that's in the target server
+        room = FactoryGirl.create(:bigbluebutton_room, :server => server)
+        FactoryGirl.create(:bigbluebutton_recording, :room => room)
+      end
+      before(:each) { get :recordings, :id => server.to_param }
+      it { should respond_with(:success) }
+      it { should render_template(:recordings) }
+      it { should assign_to(:recordings).with([@recording1, @recording2]) }
+    end
 
-      # one that belongs to another server but to a room that's in the target server
-      room = FactoryGirl.create(:bigbluebutton_room, :server => server)
-      FactoryGirl.create(:bigbluebutton_recording, :room => room)
+    context "doesn't override @server" do
+      let!(:other_server) { FactoryGirl.create(:bigbluebutton_server) }
+      before { controller.instance_variable_set(:@server, other_server) }
+      before(:each) { get :recordings, :id => server.to_param }
+      it { should assign_to(:server).with(other_server) }
+    end
+
+    context "doesn't override @recordings" do
+      let!(:my_recordings) {
+        [ FactoryGirl.create(:bigbluebutton_recording, server: server),
+          FactoryGirl.create(:bigbluebutton_recording, server: server) ]
+      }
+      before {
+        3.times { FactoryGirl.create(:bigbluebutton_recording, server: server) }
+        controller.instance_variable_set(:@recordings, my_recordings)
+      }
+      before(:each) { get :recordings, :id => server.to_param }
+      it { should assign_to(:recordings).with(my_recordings) }
     end
-    before(:each) { get :recordings, :id => server.to_param }
-    it { should respond_with(:success) }
-    it { should render_template(:recordings) }
-    it { should assign_to(:recordings).with([@recording1, @recording2]) }
   end
 
 end

data/spec/factories/bigbluebutton_meeting.rb

@@ -4,9 +4,9 @@ FactoryGirl.define do
     m.association :server, :factory => :bigbluebutton_server
     m.association :room, :factory => :bigbluebutton_room
     m.sequence(:name) { |n| "Name#{n}" }
-    m.record false
+    m.recorded false
     m.running false
-    m.start_time { Time.now - rand(5).hours }
+    m.start_time { Time.at(Time.now.to_i + rand(999999)) }
     # m.creator_id
     # m.creator_name
   end

data/spec/factories/bigbluebutton_playback_format.rb

@@ -1,7 +1,7 @@
 FactoryGirl.define do
-  factory  :bigbluebutton_playback_format do |r|
+  factory :bigbluebutton_playback_format do |r|
     r.association :recording, :factory => :bigbluebutton_recording
-    r.sequence(:format_type) { |n| "#{Forgery(:name).first_name.downcase}-#{n}" }
+    r.association :playback_type, :factory => :bigbluebutton_playback_type
     r.url { "http://" + Forgery(:internet).domain_name + "/playback" }
     r.length { Forgery(:basic).number }
   end

data/spec/factories/bigbluebutton_playback_type.rb

@@ -0,0 +1,7 @@
+FactoryGirl.define do
+  factory :bigbluebutton_playback_type do |pbt|
+    pbt.sequence(:identifier) { |n| "#{Forgery(:name).first_name.downcase}-#{n}" }
+    pbt.visible true
+    pbt.default false
+  end
+end

data/spec/factories/bigbluebutton_recording.rb

@@ -10,6 +10,14 @@ FactoryGirl.define do
     r.end_time { Time.now + rand(5).hours }
     # TODO: should contain the meeting's start_time at the end
     r.sequence(:recordid) { |n| "rec#{n}-#{SecureRandom.uuid}-#{DateTime.now.to_i}" }
+    r.size { rand((20*1024**2)..(500*1024**2)) } # size ranging from 20Mb to 500Mb
     r.available true
+
+    after(:create) do |r|
+      r.updated_at = r.updated_at.change(:usec => 0)
+      r.created_at = r.created_at.change(:usec => 0)
+      r.start_time = r.start_time.change(:usec => 0)
+      r.end_time = r.end_time.change(:usec => 0)
+    end
   end
 end

data/spec/factories/bigbluebutton_room.rb

@@ -5,17 +5,24 @@ FactoryGirl.define do
 
     r.association :server, :factory => :bigbluebutton_server
     r.sequence(:name) { |n| "Name#{n}" }
-    r.attendee_password { Forgery(:basic).password :at_least => 10, :at_most => 16 }
-    r.moderator_password { Forgery(:basic).password :at_least => 10, :at_most => 16 }
+    r.attendee_key { Forgery(:basic).password :at_least => 10, :at_most => 16 }
+    r.moderator_key { Forgery(:basic).password :at_least => 10, :at_most => 16 }
+    r.attendee_api_password { SecureRandom.uuid }
+    r.moderator_api_password { SecureRandom.uuid }
     r.welcome_msg { Forgery(:lorem_ipsum).sentences(2) }
     r.private false
     r.sequence(:param) { |n| "meeting-#{n}" }
     r.external false
-    r.record false
+    r.record_meeting false
     r.duration 0
     r.sequence(:voice_bridge) { |n| "7#{n.to_s.rjust(4, '0')}" }
     r.dial_number { SecureRandom.random_number(9999999).to_s }
     r.sequence(:logout_url) { |n| "http://bigbluebutton#{n}.test.com/logout" }
     r.sequence(:max_participants) { |n| n }
+
+    after(:create) do |r|
+      r.updated_at = r.updated_at.change(:usec => 0)
+      r.created_at = r.created_at.change(:usec => 0)
+    end
   end
 end