bigbluebutton_rails 1.4.0 → 2.0.0

data/spec/factories/bigbluebutton_server.rb

@@ -3,7 +3,12 @@ FactoryGirl.define do
     s.sequence(:name) { |n| "Server #{n}" }
     s.sequence(:url) { |n| "http://bigbluebutton#{n}.test.com/bigbluebutton/api" }
     s.salt { Forgery(:basic).password :at_least => 30, :at_most => 40 }
-    s.version '0.8'
+    s.version '0.9'
     s.sequence(:param) { |n| "server-#{n}" }
   end
+
+  after(:create) do |s|
+    s.updated_at = s.updated_at.change(:usec => 0)
+    s.created_at = s.created_at.change(:usec => 0)
+  end
 end

data/spec/factories/bigbluebutton_server_config.rb

@@ -0,0 +1,6 @@
+FactoryGirl.define do
+  factory :bigbluebutton_server_config do |c|
+    c.available_layouts ["Web Conference", "Video", "Chat"]
+    c.association :server, factory: :bigbluebutton_server
+  end
+end

data/spec/generators/install_generator_spec.rb

@@ -18,14 +18,12 @@ describe BigbluebuttonRails::Generators::InstallGenerator do
     it "all files are properly created" do
       assert_migration "db/migrate/create_bigbluebutton_rails.rb"
       assert_file "config/locales/bigbluebutton_rails.en.yml"
-      assert_file "config/schedule.rb"
     end
 
     it "all files are properly destroyed" do
       run_generator %w(), :behavior => :revoke
       assert_no_migration "db/migrate/create_bigbluebutton_rails.rb"
       assert_no_file "config/locales/bigbluebutton_rails.en.yml"
-      assert_no_file "config/schedule.rb"
     end
   end
 
@@ -38,20 +36,6 @@ describe BigbluebuttonRails::Generators::InstallGenerator do
     it "only the migration is created" do
       assert_migration "db/migrate/create_bigbluebutton_rails.rb"
       assert_no_file "config/locales/bigbluebutton_rails.en.yml"
-      assert_no_file "config/schedule.rb"
-    end
-  end
-
-  context "config/schedule.rb" do
-    before(:all) do
-      prepare_destination
-      run_generator
-    end
-
-    it "has the correct content" do
-      assert_file "config/schedule.rb"
-      content = File_.read(File_.expand_path("../../../config/schedule.rb", __FILE__))
-      File_.read("config/schedule.rb").should match(content)
     end
   end
 

data/spec/lib/bigbluebutton_rails/background_tasks_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe BigbluebuttonRails::BackgroundTasks do
+
+  describe ".finish_meetings" do
+
+    context "set meetings that ended as not running" do
+      let(:room) { FactoryGirl.create(:bigbluebutton_room) }
+      let!(:meeting) { FactoryGirl.create(:bigbluebutton_meeting, running: true, room: room) }
+      before {
+        BigBlueButton::BigBlueButtonApi.any_instance
+          .stub(:get_api_version).and_return("0.9")
+        BigBlueButton::BigBlueButtonApi.any_instance
+          .should_receive(:is_meeting_running?).once.with(room.meetingid).and_return(false)
+      }
+      before(:each) { BigbluebuttonRails::BackgroundTasks.finish_meetings }
+      it { meeting.reload.running.should be false }
+    end
+
+    context "doesn't change meetings that are still running" do
+      let(:room) { FactoryGirl.create(:bigbluebutton_room) }
+      let!(:meeting) { FactoryGirl.create(:bigbluebutton_meeting, running: true, room: room) }
+      before {
+        BigBlueButton::BigBlueButtonApi.any_instance
+          .stub(:get_api_version).and_return("0.9")
+        BigBlueButton::BigBlueButtonApi.any_instance
+          .should_receive(:is_meeting_running?).once.with(room.meetingid).and_return(true)
+      }
+      before(:each) { BigbluebuttonRails::BackgroundTasks.finish_meetings }
+      it { meeting.reload.running.should be true }
+    end
+
+    context "ignores meetings that are not running" do
+      let(:room) { FactoryGirl.create(:bigbluebutton_room) }
+      let!(:meeting) { FactoryGirl.create(:bigbluebutton_meeting, running: false, room: room) }
+      before {
+        BigBlueButton::BigBlueButtonApi.any_instance.should_not_receive(:is_meeting_running?)
+      }
+      before(:each) { BigbluebuttonRails::BackgroundTasks.finish_meetings }
+      it { meeting.reload.running.should be false }
+    end
+
+    it "works for multiple meetings"
+  end
+
+  describe ".update_recordings" do
+
+    context "fetches the meetings for all servers" do
+      let!(:server1) { FactoryGirl.create(:bigbluebutton_server) }
+      let!(:server2) { FactoryGirl.create(:bigbluebutton_server) }
+      before {
+        BigbluebuttonServer.stub(:find_each).and_yield(server1).and_yield(server2)
+        server1.should_receive(:fetch_recordings).once
+        server2.should_receive(:fetch_recordings).once
+      }
+      it { BigbluebuttonRails::BackgroundTasks.update_recordings }
+    end
+
+    it "doesn't break if exceptions are returned"
+  end
+end

data/spec/lib/bigbluebutton_rails/dial_number_spec.rb

@@ -0,0 +1,78 @@
+require 'spec_helper'
+
+describe BigbluebuttonRails::DialNumber do
+
+  describe '#randomize' do
+    context 'with no arguments informed' do
+      it { BigbluebuttonRails::DialNumber.randomize.should be_nil }
+    end
+
+    context 'pattern "6xxx-xx"' do
+      it { BigbluebuttonRails::DialNumber.randomize('6xxx-xx').should match(/^6\d\d\d-\d\d$/) }
+    end
+
+    context 'pattern "0AA-xAAA" and custom symbol "A"' do
+      it {
+        BigbluebuttonRails::DialNumber.randomize('0AA-xAAA', symbol: 'A').should match(/^\d\d\d-x\d\d\d$/)
+      }
+    end
+
+    context 'pattern only with variables: "(xx) xxxx-xxxx"' do
+      it {
+        BigbluebuttonRails::DialNumber.randomize('(xx) xxxx-xxxx').should match(/^\(\d\d\) \d\d\d\d-\d\d\d\d$/)
+      }
+    end
+
+    context 'pattern without variables: "(51) 1234"' do
+      it {
+        BigbluebuttonRails::DialNumber.randomize('(51) 1234').should eq("(51) 1234")
+      }
+    end
+  end
+
+  describe '#get_dial_number_from_ordinal' do
+    let(:pattern) { '98xxxx-xxx'}
+    let(:n1) { 34 }
+    let(:n2) { 142 }
+    let(:n3) { 2112 }
+
+    it { BigbluebuttonRails::DialNumber.get_dial_number_from_ordinal(n1, pattern).should eq('980000-034') }
+    it { BigbluebuttonRails::DialNumber.get_dial_number_from_ordinal(n2, pattern).should eq('980000-142') }
+    it { BigbluebuttonRails::DialNumber.get_dial_number_from_ordinal(n3, pattern).should eq('980002-112') }
+
+    context 'with pattern as nil' do
+      it { BigbluebuttonRails::DialNumber.get_dial_number_from_ordinal(n1, nil).should eq(nil) }
+      it { BigbluebuttonRails::DialNumber.get_dial_number_from_ordinal(n2, nil).should eq(nil) }
+      it { BigbluebuttonRails::DialNumber.get_dial_number_from_ordinal(n3, nil).should eq(nil) }
+    end
+  end
+
+  describe '#get_ordinal_from_dial_number' do
+    let(:pattern) { '67xxx-xxx'}
+    let(:n1) { '67000-001' }
+    let(:n2) { '67001-001' }
+    let(:n3) { '67123-321' }
+
+    it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n1, pattern).should eq(1) }
+    it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n2, pattern).should eq(1001) }
+    it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n3, pattern).should eq(123321) }
+
+    context 'with pattern as nil' do
+      let(:pattern) { nil }
+
+      it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n1, pattern).should eq(nil) }
+      it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n2, pattern).should eq(nil) }
+      it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n3, pattern).should eq(nil) }
+    end
+
+    context 'with a pattern that doesnt match the number' do
+      let(:pattern) { '88xxx-xxx' }
+
+      it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n1, pattern).should eq(nil) }
+      it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n2, pattern).should eq(nil) }
+      it { BigbluebuttonRails::DialNumber.get_ordinal_from_dial_number(n3, pattern).should eq(nil) }
+    end
+
+  end
+
+end

data/spec/lib/bigbluebutton_rails/utils_spec.rb

@@ -0,0 +1,56 @@
+require 'spec_helper'
+
+describe BigbluebuttonRails do
+
+  describe '.use_mobile_client?' do
+    before do
+      @browser = double
+      BigbluebuttonRails.stub(:browser).and_return(@browser)
+    end
+
+    context 'for a mobile device' do
+      before do
+        @browser.stub(:mobile?).and_return(true)
+        @browser.stub(:tablet?).and_return(false)
+      end
+      it { BigbluebuttonRails.use_mobile_client?(@browser).should be(true) }
+    end
+
+    context 'for a tablet' do
+      before do
+        @browser.stub(:mobile?).and_return(false)
+        @browser.stub(:tablet?).and_return(true)
+      end
+      it { BigbluebuttonRails.use_mobile_client?(@browser).should be(true) }
+    end
+
+    context 'not a mobile device nor tablet' do
+      before do
+        @browser.stub(:mobile?).and_return(false)
+        @browser.stub(:tablet?).and_return(false)
+      end
+      it { BigbluebuttonRails.use_mobile_client?(@browser).should be(false) }
+    end
+
+    # some user-agents where errors happened in the past
+    context 'user-agents' do
+      it {
+        browser = Browser.new(ua: 'Mozilla/5.0 (iPad; CPU OS 8_1_3 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12B466 Safari/600.1.4', accept_language: 'en-us')
+        BigbluebuttonRails.use_mobile_client?(browser).should be(true)
+      }
+    end
+  end
+
+  describe '.value_to_boolean' do
+    it { BigbluebuttonRails.value_to_boolean('true').should be(true) }
+    it { BigbluebuttonRails.value_to_boolean('1').should be(true) }
+    it { BigbluebuttonRails.value_to_boolean(1).should be(true) }
+    it { BigbluebuttonRails.value_to_boolean(true).should be(true) }
+    it { BigbluebuttonRails.value_to_boolean('t').should be(true) }
+    it { BigbluebuttonRails.value_to_boolean('false').should be(false) }
+    it { BigbluebuttonRails.value_to_boolean('0').should be(false) }
+    it { BigbluebuttonRails.value_to_boolean(0).should be(false) }
+    it { BigbluebuttonRails.value_to_boolean(false).should be(false) }
+    it { BigbluebuttonRails.value_to_boolean('f').should be(false) }
+  end
+end

data/spec/lib/tasks/meetings_rake_spec.rb

@@ -1,5 +1,18 @@
 require 'spec_helper'
 
 describe "bigbluebutton_rails:meetings:finish" do
-  it "mark as not running all meetings that were running but are not anymore"
+  include_context "rake"
+
+  before do
+    BigbluebuttonRails::BackgroundTasks.stub(:finish_meetings)
+  end
+
+  it "requires environment" do
+    subject.prerequisites.should include("environment")
+  end
+
+  it "calls the method that does the work" do
+    subject.invoke
+    BigbluebuttonRails::BackgroundTasks.should have_received(:finish_meetings)
+  end
 end

data/spec/lib/tasks/recordings_rake_spec.rb

@@ -1,5 +1,18 @@
 require 'spec_helper'
 
 describe "bigbluebutton_rails:recordings:update" do
-  it "fetches the recordings"
+  include_context "rake"
+
+  before do
+    BigbluebuttonRails::BackgroundTasks.stub(:update_recordings)
+  end
+
+  it "requires environment" do
+    subject.prerequisites.should include("environment")
+  end
+
+  it "calls the method that does the work" do
+    subject.invoke
+    BigbluebuttonRails::BackgroundTasks.should have_received(:update_recordings)
+  end
 end

data/spec/models/bigbluebutton_meeting_db_spec.rb

@@ -10,14 +10,14 @@ describe BigbluebuttonMeeting do
     it { should have_db_column(:name).of_type(:string) }
     it { should have_db_column(:start_time).of_type(:datetime) }
     it { should have_db_column(:running).of_type(:boolean) }
-    it { should have_db_column(:record).of_type(:boolean) }
+    it { should have_db_column(:recorded).of_type(:boolean) }
     it { should have_db_column(:creator_id).of_type(:integer) }
     it { should have_db_column(:creator_name).of_type(:string) }
     it { should have_db_index([:meetingid, :start_time]).unique(true) }
     it "default values" do
       room = BigbluebuttonRoom.new
-      room.running.should be_false
-      room.record.should be_false
+      room.running.should be_falsey
+      room.record_meeting.should be_falsey
     end
   end
 

data/spec/models/bigbluebutton_meeting_spec.rb

@@ -26,7 +26,7 @@ describe BigbluebuttonMeeting do
     let(:target) { FactoryGirl.create(:bigbluebutton_meeting) }
 
     context "if the user informed is nil" do
-      it { target.created_by?(nil).should be_false }
+      it { target.created_by?(nil).should be_falsey }
     end
 
     context "with a valid user informed" do
@@ -34,18 +34,18 @@ describe BigbluebuttonMeeting do
 
       context "if the meeting has no creator_id" do
         before { target.update_attributes(:creator_id => nil) }
-        it { target.created_by?(user).should be_false }
+        it { target.created_by?(user).should be_falsey }
       end
 
       context "if it wasn't the user that created the meeting" do
         let(:user2) { FactoryGirl.build(:user) }
         before { target.update_attributes(:creator_id => user2.id, :creator_name => user2.name) }
-        it { target.created_by?(user).should be_false }
+        it { target.created_by?(user).should be_falsey }
       end
 
       context "if it was the user that created the meeting" do
         before { target.update_attributes(:creator_id => user.id, :creator_name => user.name) }
-        it { target.created_by?(user).should be_true }
+        it { target.created_by?(user).should be_truthy }
       end
     end
   end

data/spec/models/bigbluebutton_playback_format_db_spec.rb

@@ -5,7 +5,6 @@ describe BigbluebuttonPlaybackFormat do
   # to ensure that the migration is correct
   context "db" do
     it { should have_db_column(:recording_id).of_type(:integer) }
-    it { should have_db_column(:format_type).of_type(:string) }
     it { should have_db_column(:url).of_type(:string) }
     it { should have_db_column(:length).of_type(:integer) }
     it { should have_db_column(:created_at).of_type(:datetime) }

data/spec/models/bigbluebutton_playback_format_spec.rb

@@ -6,13 +6,84 @@ describe BigbluebuttonPlaybackFormat do
     BigbluebuttonPlaybackFormat.new.should be_a_kind_of(ActiveRecord::Base)
   end
 
-  before { FactoryGirl.create(:bigbluebutton_playback_format) }
-
   it { should belong_to(:recording) }
-  it { should validate_presence_of(:recording_id) }
+  it { should belong_to(:playback_type) }
 
-  it { should validate_presence_of(:format_type) }
+  it { should validate_presence_of(:recording_id) }
 
+  it { should_not validate_presence_of(:playback_type_id) }
   it { should_not validate_presence_of(:url) }
   it { should_not validate_presence_of(:length) }
+
+  it { should delegate_method(:name).to(:playback_type) }
+  it { should delegate_method(:visible).to(:playback_type) }
+  it { should delegate_method(:visible?).to(:playback_type) }
+  it { should delegate_method(:identifier).to(:playback_type) }
+  it { should delegate_method(:default).to(:playback_type) }
+  it { should delegate_method(:default?).to(:playback_type) }
+  it { should delegate_method(:description).to(:playback_type) }
+
+  context "allows nil for delegates to playback_type" do
+    let(:target) { FactoryGirl.create(:bigbluebutton_playback_format, playback_type: nil) }
+    it { target.name.should be_nil }
+    it { target.identifier.should be_nil }
+    it { target.visible.should be_nil }
+    it { target.visible?.should be_nil }
+    it { target.default.should be_nil }
+    it { target.default?.should be_nil }
+    it { target.format_type.should be_nil }
+  end
+
+  it("alias :format_type to :identifier") {
+    target = FactoryGirl.create(:bigbluebutton_playback_format)
+    target.playback_type.identifier = "anything"
+    target.format_type.should eql("anything")
+  }
+
+  describe "#ordered" do
+    context "when there's a default set" do
+      let!(:type_default) { FactoryGirl.create(:bigbluebutton_playback_type, default: true) }
+      let!(:type1) { FactoryGirl.create(:bigbluebutton_playback_type, default: false) }
+      let!(:type2) { FactoryGirl.create(:bigbluebutton_playback_type, default: false) }
+      before {
+        @format1 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: type1)
+        @format2 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: type2)
+        @format3 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: type_default)
+        @format4 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: nil)
+      }
+      subject { BigbluebuttonPlaybackFormat.ordered }
+      it { subject[0].should eql(@format3) }
+      it { subject[1].should eql(@format1) }
+      it { subject[2].should eql(@format2) }
+      it { subject[3].should eql(@format4) }
+    end
+
+    context "when there's no default set" do
+      let!(:type1) { FactoryGirl.create(:bigbluebutton_playback_type, default: false) }
+      let!(:type2) { FactoryGirl.create(:bigbluebutton_playback_type, default: false) }
+      before {
+        @format1 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: type1)
+        @format2 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: type2)
+        @format3 = FactoryGirl.create(:bigbluebutton_playback_format, playback_type: nil)
+      }
+      subject { BigbluebuttonPlaybackFormat.ordered }
+      it { subject[0].should eql(@format1) }
+      it { subject[1].should eql(@format2) }
+      it { subject[2].should eql(@format3) }
+    end
+
+    context "when there are no formats" do
+      subject { BigbluebuttonPlaybackFormat.ordered }
+      it { subject.should eql([]) }
+    end
+  end
+
+  describe "#length_in_secs" do
+    it { FactoryGirl.create(:bigbluebutton_playback_format, length: nil).length_in_secs.should eql(0) }
+    it { FactoryGirl.create(:bigbluebutton_playback_format, length: "").length_in_secs.should eql(0) }
+    it { FactoryGirl.create(:bigbluebutton_playback_format, length: -1).length_in_secs.should eql(0) }
+    it { FactoryGirl.create(:bigbluebutton_playback_format, length: 0).length_in_secs.should eql(0) }
+    it { FactoryGirl.create(:bigbluebutton_playback_format, length: 5).length_in_secs.should eql(300) }
+    it { FactoryGirl.create(:bigbluebutton_playback_format, length: 99).length_in_secs.should eql(5940) }
+  end
 end

data/spec/models/bigbluebutton_playback_type_db_spec.rb

@@ -0,0 +1,14 @@
+require 'spec_helper'
+
+describe BigbluebuttonPlaybackType do
+
+  # to ensure that the migration is correct
+  context "db" do
+    it { should have_db_column(:identifier).of_type(:string) }
+    it { should have_db_column(:visible).of_type(:boolean) }
+    it { should have_db_column(:default).of_type(:boolean) }
+    it { should have_db_column(:created_at).of_type(:datetime) }
+    it { should have_db_column(:updated_at).of_type(:datetime) }
+  end
+
+end