be_valid_asset 1.1.1

data/spec/be_valid_asset/be_valid_xhtml_spec.rb

@@ -0,0 +1,290 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+unless defined?(SpecFailed)
+  SpecFailed = Spec::Expectations::ExpectationNotMetError
+end
+
+describe 'be_valid_xhtml' do
+
+  describe "without caching" do
+    it "should validate a valid string" do
+      html = get_file('valid.html')
+      html.should be_valid_xhtml
+    end
+
+    it "should validate a valid response" do
+      response = MockResponse.new(get_file('valid.html'))
+      response.should be_valid_xhtml
+    end
+
+    it "should validate if body is not a string but can be converted to valid string" do
+      response = MockResponse.new(stub("XHTML", :to_s => get_file('valid.html')))
+      response.should be_valid_xhtml
+    end
+
+    it "should validate a valid fragment" do
+      "<p>This is a Fragment</p>".should be_valid_xhtml_fragment
+    end
+
+    it "should not validate an invalid string" do
+      html = get_file('invalid.html')
+      lambda {
+        html.should be_valid_xhtml
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid markup: line 12: end tag for "b" omitted, but OMITTAG NO was specified/)
+        e.message.should match(/Invalid markup: line 12: end tag for element "b" which is not open/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: b line 12 and p/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: p line 12 and b/)
+      }
+    end
+
+    it "should not validate an invalid response" do
+      response = MockResponse.new(get_file('invalid.html'))
+      lambda {
+        response.should be_valid_xhtml
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid markup: line 12: end tag for "b" omitted, but OMITTAG NO was specified/)
+        e.message.should match(/Invalid markup: line 12: end tag for element "b" which is not open/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: b line 12 and p/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: p line 12 and b/)
+      }
+    end
+
+    it "should display invalid content when requested" do
+      BeValidAsset::Configuration.display_invalid_content = true
+      html = get_file('invalid.html')
+      lambda {
+        html.should be_valid_xhtml
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/<p><b>This is an example invalid html file<\/p><\/b>/)
+      }
+      BeValidAsset::Configuration.display_invalid_content = false
+    end
+
+    describe "displaying invalid lines" do
+      before :each do
+        BeValidAsset::Configuration.display_invalid_lines = true
+      end
+      after :each do
+        BeValidAsset::Configuration.display_invalid_lines = false
+        BeValidAsset::Configuration.display_invalid_lines_count = 5 # Restore the default value
+      end
+
+      it "should display invalid lines when requested" do
+        html = get_file('invalid.html')
+        lambda do
+          html.should be_valid_xhtml
+        end.should raise_error(SpecFailed) { |e|
+          e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+          e.message.should_not match(/0009  :/)
+          e.message.should match(/0010  :/)
+          e.message.should match(/0011  :/)
+          e.message.should match(/0012>>:/)
+          e.message.should match(/0013  :/)
+          e.message.should match(/0014  :/)
+          e.message.should_not match(/0015  :/)
+        }
+      end
+
+      it "should display specified invalid lines window when requested" do
+        BeValidAsset::Configuration.display_invalid_lines_count = 3
+        html = get_file('invalid.html')
+        lambda do
+          html.should be_valid_xhtml
+        end.should raise_error(SpecFailed) { |e|
+          e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+          e.message.should_not match(/0010  :/)
+          e.message.should match(/0011  :/)
+          e.message.should match(/0012>>:/)
+          e.message.should match(/0013  :/)
+          e.message.should_not match(/0014  :/)
+        }
+      end
+
+      it "should not underrun the beginning of the source" do
+        BeValidAsset::Configuration.display_invalid_lines_count = 7
+        html = get_file('invalid2.html')
+        lambda do
+          html.should be_valid_xhtml
+        end.should raise_error(SpecFailed) { |e|
+          e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+          e.message.should_not match(/0000  :/)
+          e.message.should match(/0001  :/)
+          e.message.should match(/0003>>:/)
+        }
+      end
+
+      it "should not overrun the end of the source" do
+        BeValidAsset::Configuration.display_invalid_lines_count = 11
+        html = get_file('invalid.html')
+        lambda do
+          html.should be_valid_xhtml
+        end.should raise_error(SpecFailed) { |e|
+          e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+          e.message.should match(/0012>>:/)
+          e.message.should match(/0015  :/)
+          e.message.should_not match(/0016  :/)
+        }
+      end
+    end
+
+    it "should fail when passed a response with a blank body" do
+      response = MockResponse.new('')
+      lambda {
+        response.should be_valid_xhtml
+      }.should raise_error(SpecFailed)
+    end
+
+    it "should fail unless resposne is HTTP OK" do
+      html = get_file('valid.html')
+
+      r = Net::HTTPServiceUnavailable.new('1.1', 503, 'Service Unavailable')
+      h = Net::HTTP.new(BeValidAsset::Configuration.markup_validator_host)
+      h.stub!(:post2).and_return(r)
+      Net::HTTP.stub!(:start).and_return(h)
+
+      lambda {
+        html.should be_valid_xhtml
+      }.should raise_error
+    end
+
+    it "should mark test as pending if network tests are disabled" do
+      ENV['NONET'] = 'true'
+
+      html = get_file('valid.html')
+      lambda {
+        html.should be_valid_xhtml
+      }.should raise_error(Spec::Example::ExamplePendingError)
+
+      ENV.delete('NONET')
+    end
+  end
+
+  describe "with caching" do
+    before(:each) do
+      BeValidAsset::Configuration.enable_caching = true
+      FileUtils.rm Dir.glob(BeValidAsset::Configuration.cache_path + '/*')
+    end
+    after(:each) do
+      BeValidAsset::Configuration.enable_caching = false
+    end
+
+    it "should validate a valid string and cache the response" do
+      html = get_file('valid.html')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+      html.should be_valid_xhtml
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count + 1)
+    end
+
+    it "should validate a valid string using the cached response" do
+      html = get_file('valid.html')
+      html.should be_valid_xhtml
+
+      Net::HTTP.should_not_receive(:start)
+      html.should be_valid_xhtml
+    end
+
+    it "should not validate an invalid response, but still cache the response" do
+      response = MockResponse.new(get_file('invalid.html'))
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+      lambda {
+        response.should be_valid_xhtml
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid markup: line 12: end tag for "b" omitted, but OMITTAG NO was specified/)
+        e.message.should match(/Invalid markup: line 12: end tag for element "b" which is not open/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: b line 12 and p/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: p line 12 and b/)
+      }
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count + 1)
+    end
+
+    it "should not validate an invalid response, but use the cached response" do
+      response = MockResponse.new(get_file('invalid.html'))
+      response.should_not be_valid_xhtml
+
+      Net::HTTP.should_not_receive(:start)
+      lambda {
+        response.should be_valid_xhtml
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected xhtml to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid markup: line 12: end tag for "b" omitted, but OMITTAG NO was specified/)
+        e.message.should match(/Invalid markup: line 12: end tag for element "b" which is not open/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: b line 12 and p/)
+        e.message.should match(/Invalid markup: line 12: XML Parsing Error:  Opening and ending tag mismatch: p line 12 and b/)
+      }
+    end
+
+    it "should not cache the result unless it is an HTTP OK response" do
+      html = get_file('valid.html')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+
+      r = Net::HTTPServiceUnavailable.new('1.1', 503, 'Service Unavailable')
+      h = Net::HTTP.new(BeValidAsset::Configuration.markup_validator_host)
+      h.stub!(:post2).and_return(r)
+      Net::HTTP.stub!(:start).and_return(h)
+
+      lambda {
+        html.should be_valid_xhtml
+      }.should raise_error
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count)
+    end
+
+    it "should use the cached result (if available) when network tests disabled" do
+      html = get_file('valid.html')
+      html.should be_valid_xhtml
+
+      ENV['NONET'] = 'true'
+
+      Net::HTTP.should_not_receive(:start)
+      html.should be_valid_xhtml
+
+      ENV.delete('NONET')
+    end
+
+    it "should mark test as pending if network tests are disabled, and no cached result is available" do
+      ENV['NONET'] = 'true'
+
+      html = get_file('valid.html')
+      lambda {
+        html.should be_valid_xhtml
+      }.should raise_error(Spec::Example::ExamplePendingError)
+
+      ENV.delete('NONET')
+    end
+  end
+
+  describe "Proxying" do
+    before :each do
+      r = Net::HTTPSuccess.new('1.1', 200, 'HTTPOK')
+      r['x-w3c-validator-status'] = 'Valid'
+      @http = mock('HTTP')
+      @http.stub!(:post2).and_return(r)
+
+      @html = MockResponse.new(get_file('valid.html'))
+    end
+
+    it "should use direct http without ENV['http_proxy']" do
+      ENV.delete('http_proxy')
+      Net::HTTP.should_receive(:start).with(BeValidAsset::Configuration.markup_validator_host).and_return(@http)
+      @html.should be_valid_xhtml
+    end
+
+    it "should use proxied http connection with ENV['http_proxy']" do
+      ENV['http_proxy'] = "http://user:pw@localhost:3128"
+      Net::HTTP.should_receive(:start).with(BeValidAsset::Configuration.markup_validator_host, nil, 'localhost', 3128, "user", "pw").and_return(@http)
+      @html.should be_valid_xhtml
+      ENV.delete('http_proxy')
+    end
+
+    it "should raise exception with invalid http_proxy" do
+      ENV['http_proxy'] = "http://invalid:uri"
+      lambda {
+        @html.should be_valid_xhtml
+      }.should raise_error(URI::InvalidURIError)
+      ENV.delete('http_proxy')
+    end
+  end
+end

data/spec/files/invalid.css

@@ -0,0 +1,43 @@
+html, body
+{
+	background:#007086;
+	font-family:Arial,Helvetica,sans-serif;
+	font-size:0.83em;
+	margin:0;
+	padding:0;
+    wibble:0;
+}
+
+* 
+{
+	margin:0;
+	padding:0;
+}
+ul, ul li
+{
+  list-style-type: none;
+}
+
+.hidden
+{
+	display: none;
+}
+a img
+{
+	border: none;
+}
+a
+{
+  text-decoration: none;
+}
+a:hover
+{
+  text-decoration: underline;
+}
+.clear-float
+{
+  clear: both;
+  font-size: 1px;
+  height: 0px;
+  line-height: 0px;
+}

data/spec/files/invalid.html

@@ -0,0 +1,15 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+  <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
+  <title>Test Invalid Page</title>
+</head>
+
+<body>
+
+<h1>Test#invalid</h1>
+<p><b>This is an example invalid html file</p></b>
+
+</body>
+</html>

data/spec/files/invalid2.html

@@ -0,0 +1,16 @@
+<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
+
+<p>This isn't valid here</p>
+<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en">
+<head>
+  <meta http-equiv="Content-Type" content="text/html; charset=utf-8"/>
+  <title>Test Invalid Page</title>
+</head>
+
+<body>
+
+<h1>Test#invalid</h1>
+<p><b>This is an example invalid html file</b></p>
+
+</body>
+</html>

data/spec/files/invalid_feed.xml

@@ -0,0 +1,37 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<rss version="2.0" xmlns:atom="http://www.w3.org/2005/Atom">
+  <channel>
+    <title>Interesting Stuff</title>
+    <link>http://site.example.com/</link>
+    <description>Description about interesting Stuff...</description>
+    <language>en-gb</language>
+    <atom:link type="application/rss+xml" href="http://site.example.com/index.rss" rel="self"/>
+    <item>
+      <title>Article 1 title</title>
+      <category>Category 1</category>
+			<author>Arthur Penderghast</author>
+      <description>&lt;p&gt;Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.&lt;/p&gt;&lt;br /&gt;&lt;img src="http://site.example.com/articles/article-1-title/images/1.jpg" alt="Some Alt Text" /&gt;</description>
+      <pubDate>Wed, 15 Jul 2009 17:03:36 +0100</pubDate>
+      <link>http://site.example.com/articles/article-1-title</link>
+      <guid>http://site.example.com/articles/article-1-title</guid>
+    </item>
+    <item>
+      <title>Article 2 title</title>
+      <category>Category 2</category>
+			<author>Arthur Penderghast</author>
+      <description>&lt;p&gt;Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.&lt;/p&gt;&lt;br /&gt;&lt;img src="http://site.example.com/articles/article-2-title/images/1.jpg" alt="Some Alt Text" /&gt;</description>
+      <pubDate>Wed, 15 Jul 2009 13:15:57 +0100</pubDate>
+      <link>http://site.example.com/articles/article-2-title</link>
+      <guid>http://site.example.com/articles/article-2-title</guid>
+    </item>
+    <item>
+      <title>Article 3 title</title>
+      <category>Category 1</category>
+			<author>Arthur Penderghast</author>
+      <description>&lt;p&gt;Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.&lt;/p&gt;&lt;br /&gt;&lt;img src="http://site.example.com/articles/article-3-title/images/1.jpg" alt="Some Alt Text" /&gt;</description>
+      <pubDate>Wed, 15 Jul 2009 13:11:56 +0100</pubDate>
+      <link>http://site.example.com/articles/article-3-title</link>
+      <guid>http://site.example.com/articles/article-3-title</guid>
+    </item>
+  </channel>
+</rss>

data/spec/files/valid-1.css

@@ -0,0 +1,31 @@
+html, body
+{
+	background:#007086;
+	font-family:Arial,Helvetica,sans-serif;
+	font-size:0.83em;
+	margin:0;
+	padding:0;
+}
+ul, ul li
+{
+  list-style-type: none;
+}
+.hidden
+{
+	display: none;
+}
+a img
+{
+	border: none;
+}
+a
+{
+  text-decoration: none;
+}
+.clear-float
+{
+  clear: both;
+  font-size: 1px;
+  height: 0px;
+  line-height: 0px;
+}

data/spec/files/valid-2.css

@@ -0,0 +1,42 @@
+html, body
+{
+	background:#007086;
+	font-family:Arial,Helvetica,sans-serif;
+	font-size:0.83em;
+	margin:0;
+	padding:0;
+}
+
+* 
+{
+	margin:0;
+	padding:0;
+}
+ul, ul li
+{
+  list-style-type: none;
+}
+
+.hidden
+{
+	display: none;
+}
+a img
+{
+	border: none;
+}
+a
+{
+  text-decoration: none;
+}
+a:hover
+{
+  text-decoration: underline;
+}
+.clear-float
+{
+  clear: both;
+  font-size: 1px;
+  height: 0px;
+  line-height: 0px;
+}