be_valid_asset 1.1.1

data/lib/be_valid_asset/be_valid_xhtml.rb

@@ -0,0 +1,75 @@
+require 'net/http'
+require 'fileutils'
+require 'cgi'
+require 'digest/md5'
+require 'rexml/document'
+
+module BeValidAsset
+  
+  Configuration.markup_validator_host = 'validator.w3.org'
+  Configuration.markup_validator_path = '/check'
+
+  class BeValidXhtml < BeValidBase
+  
+    def initialize(options = {})
+      @fragment = options[:fragment]
+    end
+  
+    # Assert that markup (html/xhtml) is valid according the W3C validator web service.
+  
+    def matches?(fragment)
+
+      if fragment.respond_to? :body
+        fragment = fragment.body.to_s
+      end
+          
+      if fragment.empty?
+        @message = "Response was blank (maybe a missing integrate_views)"
+        return false
+      end
+
+      query_params = { :fragment => fragment }
+      if @fragment
+        query_params[:prefill] = '1'
+        query_params[:prefill_doctype] = 'xhtml10'
+      end
+
+      return validate(query_params)
+    end
+  
+    def description
+      "be valid xhtml"
+    end
+  
+    def failure_message
+     " expected xhtml to be valid, but validation produced these errors:\n#{@message}"
+    end
+  
+    def negative_failure_message
+      " expected to not be valid, but was (missing validation?)"
+    end
+  
+    private
+
+      def validator_host
+        Configuration.markup_validator_host
+      end
+
+      def validator_path
+        Configuration.markup_validator_path
+      end
+
+      def error_line_prefix
+        'Invalid markup'
+      end
+
+  end
+
+  def be_valid_xhtml
+    BeValidXhtml.new
+  end
+  
+  def be_valid_xhtml_fragment()
+    BeValidXhtml.new(:fragment => true)
+  end
+end

data/spec/be_valid_asset/be_valid_css_spec.rb

@@ -0,0 +1,195 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+unless defined?(SpecFailed)
+  SpecFailed = Spec::Expectations::ExpectationNotMetError
+end
+
+describe 'be_valid_css' do
+  
+  describe "without caching" do
+    it "should validate a valid string" do
+      css = get_file('valid.css')
+      css.should be_valid_css
+    end
+    
+    it "should validate an empty string" do
+      ''.should be_valid_css
+    end
+
+    it "should validate a valid response" do
+      response = MockResponse.new(get_file('valid.css'))
+      response.should be_valid_css
+    end
+
+    it "should validate if body is not a string but can be converted to valid string" do
+      response = MockResponse.new(stub("CSS", :to_s => get_file('valid.css')))
+      response.should be_valid_css
+    end
+
+    it "should not validate an invalid string" do
+      css = get_file('invalid.css')
+      lambda {
+        css.should be_valid_css
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected css to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid css: line 8: Property wibble doesn't exist/)
+      }
+    end
+
+    it "should not validate an invalid response" do
+      response = MockResponse.new(get_file('invalid.css'))
+      lambda {
+        response.should be_valid_css
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected css to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid css: line 8: Property wibble doesn't exist/)
+      }
+    end
+
+    it "should display invalid content when requested" do
+      BeValidAsset::Configuration.display_invalid_content = true
+      css = get_file('invalid.css')
+      lambda {
+        css.should be_valid_css
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/wibble:0;/)
+      }
+      BeValidAsset::Configuration.display_invalid_content = false
+    end
+
+    it "should fail unless resposne is HTTP OK" do
+      css = get_file('valid.css')
+
+      r = Net::HTTPServiceUnavailable.new('1.1', 503, 'Service Unavailable')
+      h = Net::HTTP.new(BeValidAsset::Configuration.css_validator_host)
+      h.stub!(:post2).and_return(r)
+      Net::HTTP.stub!(:start).and_return(h)
+
+      lambda {
+        css.should be_valid_css
+      }.should raise_error
+    end
+
+    it "should mark test as pending if ENV['NONET'] is true" do
+      ENV['NONET'] = 'true'
+
+      css = get_file('valid.css')
+      lambda {
+        css.should be_valid_css
+      }.should raise_error(Spec::Example::ExamplePendingError)
+
+      ENV.delete('NONET')
+    end
+
+    describe "CSS version" do
+      (1..3).each do |version|
+        describe version.to_s do
+          before(:each) do
+            @css = get_file("valid-#{version.to_s}.css")
+          end
+          (1..3).each do |test_version|
+            if test_version < version
+              it "should not be valid css#{test_version.to_s}" do
+                lambda {
+                  @css.should send("be_valid_css#{test_version.to_s}".to_sym)
+                  }.should raise_error(SpecFailed)
+              end
+            else
+              it "should be valid css#{test_version.to_s}" do
+                @css.should send("be_valid_css#{test_version.to_s}".to_sym)
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+  
+  describe "with caching" do
+    before(:each) do
+      BeValidAsset::Configuration.enable_caching = true
+      FileUtils.rm Dir.glob(BeValidAsset::Configuration.cache_path + '/*')
+    end
+    after(:each) do
+      BeValidAsset::Configuration.enable_caching = false
+    end
+
+    it "should validate valid css and cache the response" do
+      css = get_file('valid.css')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+      css.should be_valid_css
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count + 1)
+    end
+
+    it "should validate valid css using the cached response" do
+      css = get_file('valid.css')
+      css.should be_valid_css
+
+      Net::HTTP.should_not_receive(:start)
+      css.should be_valid_css
+    end
+
+    it "should not validate invalid css, but still cache the response" do
+      css = get_file('invalid.css')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+      lambda {
+        css.should be_valid_css
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected css to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid css: line 8: Property wibble doesn't exist/)
+      }
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count + 1)
+    end
+
+    it "should not validate invalid css, but use the cached response" do
+      css = get_file('invalid.css')
+      css.should_not be_valid_css
+
+      Net::HTTP.should_not_receive(:start)
+      lambda {
+        css.should be_valid_css
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected css to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid css: line 8: Property wibble doesn't exist/)
+      }
+    end
+
+    it "should not cache the result unless it is an HTTP OK response" do
+      css = get_file('valid.css')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+
+      r = Net::HTTPServiceUnavailable.new('1.1', 503, 'Service Unavailable')
+      h = Net::HTTP.new(BeValidAsset::Configuration.css_validator_host)
+      h.stub!(:post2).and_return(r)
+      Net::HTTP.stub!(:start).and_return(h)
+
+      lambda {
+        css.should be_valid_css
+      }.should raise_error
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count)
+    end
+
+    it "should use the cached result (if available) when network tests disabled" do
+      css = get_file('valid.css')
+      css.should be_valid_css
+
+      ENV['NONET'] = 'true'
+
+      Net::HTTP.should_not_receive(:start)
+      css.should be_valid_css
+
+      ENV.delete('NONET')
+    end
+
+    it "should mark test as pending if network tests are disabled, and no cached result is available" do
+      ENV['NONET'] = 'true'
+
+      css = get_file('valid.css')
+      lambda {
+        css.should be_valid_css
+      }.should raise_error(Spec::Example::ExamplePendingError)
+
+      ENV.delete('NONET')
+    end
+  end
+end

data/spec/be_valid_asset/be_valid_feed_spec.rb

@@ -0,0 +1,178 @@
+require File.expand_path(File.dirname(__FILE__) + '/../spec_helper')
+
+unless defined?(SpecFailed)
+  SpecFailed = Spec::Expectations::ExpectationNotMetError
+end
+
+describe 'be_valid_feed' do
+
+  describe "without caching" do
+    it "should validate a valid string" do
+      feed = get_file('valid_feed.xml')
+      feed.should be_valid_feed
+    end
+
+    it "should work when called as be_valid_rss" do
+      feed = get_file('valid_feed.xml')
+      feed.should be_valid_rss
+    end
+
+    it "should work when called as be_valid_atom" do
+      feed = get_file('valid_feed.xml')
+      feed.should be_valid_atom
+    end
+
+    it "should validate a valid response" do
+      response = MockResponse.new(get_file('valid_feed.xml'))
+      response.should be_valid_feed
+    end
+
+    it "should validate if body is not a string but can be converted to valid string" do
+      response = MockResponse.new(stub("Feed", :to_s => get_file('valid_feed.xml')))
+      response.should be_valid_feed
+    end
+
+    it "should not validate an invalid string" do
+      feed = get_file('invalid_feed.xml')
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected feed to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid feed: line 12: Invalid email address/)
+      }
+    end
+
+    it "should not validate an invalid response" do
+      response = MockResponse.new(get_file('invalid_feed.xml'))
+      lambda {
+        response.should be_valid_feed
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected feed to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid feed: line 12: Invalid email address/)
+      }
+    end
+
+    it "should display invalid content when requested" do
+      BeValidAsset::Configuration.display_invalid_content = true
+      feed = get_file('invalid_feed.xml')
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(%r{<link>http://site.example.com/articles/article-1-title</link>})
+      }
+      BeValidAsset::Configuration.display_invalid_content = false
+    end
+
+    it "should fail unless resposne is HTTP OK" do
+      feed = get_file('valid_feed.xml')
+
+      r = Net::HTTPServiceUnavailable.new('1.1', 503, 'Service Unavailable')
+      h = Net::HTTP.new(BeValidAsset::Configuration.feed_validator_host)
+      h.stub!(:post).and_return(r)
+      Net::HTTP.stub!(:start).and_return(h)
+
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error
+    end
+
+    it "should mark test as pending if ENV['NONET'] is true" do
+      ENV['NONET'] = 'true'
+
+      feed = get_file('valid_feed.xml')
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error(Spec::Example::ExamplePendingError)
+
+      ENV.delete('NONET')
+    end
+  end
+
+  describe "with caching" do
+    before(:each) do
+      BeValidAsset::Configuration.enable_caching = true
+      FileUtils.rm Dir.glob(BeValidAsset::Configuration.cache_path + '/*')
+    end
+    after(:each) do
+      BeValidAsset::Configuration.enable_caching = false
+    end
+
+    it "should validate valid feed and cache the response" do
+      feed = get_file('valid_feed.xml')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+      feed.should be_valid_feed
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count + 1)
+    end
+
+    it "should validate valid feed using the cached response" do
+      feed = get_file('valid_feed.xml')
+      feed.should be_valid_feed
+
+      Net::HTTP.should_not_receive(:start)
+      feed.should be_valid_feed
+    end
+
+    it "should not validate invalid feed, but still cache the response" do
+      feed = get_file('invalid_feed.xml')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected feed to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid feed: line 12: Invalid email address/)
+      }
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count + 1)
+    end
+
+    it "should not validate invalid feed, but use the cached response" do
+      feed = get_file('invalid_feed.xml')
+      feed.should_not be_valid_feed
+
+      Net::HTTP.should_not_receive(:start)
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error(SpecFailed) { |e|
+        e.message.should match(/expected feed to be valid, but validation produced these errors/)
+        e.message.should match(/Invalid feed: line 12: Invalid email address/)
+      }
+    end
+
+    it "should not cache the result unless it is an HTTP OK response" do
+      feed = get_file('valid_feed.xml')
+      count = Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size
+
+      r = Net::HTTPServiceUnavailable.new('1.1', 503, 'Service Unavailable')
+      h = Net::HTTP.new(BeValidAsset::Configuration.feed_validator_host)
+      h.stub!(:post).and_return(r)
+      Net::HTTP.stub!(:start).and_return(h)
+
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error
+      Dir.glob(BeValidAsset::Configuration.cache_path + '/*').size.should eql(count)
+    end
+
+    it "should use the cached result (if available) when network tests disabled" do
+      feed = get_file('valid_feed.xml')
+      feed.should be_valid_feed
+
+      ENV['NONET'] = 'true'
+
+      Net::HTTP.should_not_receive(:start)
+      feed.should be_valid_feed
+
+      ENV.delete('NONET')
+    end
+
+    it "should mark test as pending if network tests are disabled, and no cached result is available" do
+      ENV['NONET'] = 'true'
+
+      feed = get_file('valid_feed.xml')
+      lambda {
+        feed.should be_valid_feed
+      }.should raise_error(Spec::Example::ExamplePendingError)
+
+      ENV.delete('NONET')
+    end
+  end
+end