axiom-optimizer 0.1.1 → 0.2.0

data/spec/integration/axiom/algebra/restriction/optimize_spec.rb

@@ -15,7 +15,7 @@ describe Algebra::Restriction, '#optimize' do
     it { should be(relation) }
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -32,7 +32,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -45,7 +45,7 @@ describe Algebra::Restriction, '#optimize' do
     it { should be(object) }
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -68,7 +68,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -92,7 +92,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -110,7 +110,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -128,7 +128,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -153,7 +153,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -175,18 +175,18 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'with an order operation' do
+  context 'with a sorted operation' do
     let(:operand)   { relation.sort_by { |r| r.id } }
     let(:predicate) { operand[:id].gte(1)           }
 
-    it 'cancels out the order' do
+    it 'cancels out the sorted' do
       should eql(relation.restrict { predicate })
     end
 
@@ -195,7 +195,7 @@ describe Algebra::Restriction, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 

data/spec/integration/axiom/algebra/summarization/optimize_spec.rb

@@ -23,7 +23,7 @@ describe Algebra::Summarization, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -40,7 +40,7 @@ describe Algebra::Summarization, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 

data/spec/integration/axiom/algebra/union/optimize_spec.rb

@@ -14,8 +14,8 @@ describe Algebra::Union, '#optimize' do
 
   before do
     # skip dup of the left and right body to avoid clearing the method stubs
-    left_body.stub(:frozen?).and_return(true)
-    right_body.stub(:frozen?).and_return(true)
+    allow(left_body).to receive(:frozen?).and_return(true)
+    allow(right_body).to receive(:frozen?).and_return(true)
   end
 
   context 'left is an empty relation' do
@@ -29,12 +29,12 @@ describe Algebra::Union, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -52,12 +52,12 @@ describe Algebra::Union, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -75,12 +75,12 @@ describe Algebra::Union, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -98,12 +98,12 @@ describe Algebra::Union, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -124,14 +124,14 @@ describe Algebra::Union, '#optimize' do
 
     it 'does not execute left_body#each' do
       pending 'TODO: should only compare left and right with #eql? if they are materialized' do
-        left_body.should_not_receive(:each)
+        expect(left_body).to_not receive(:each)
         subject
       end
     end
 
     it 'does not execute right_body#each' do
       pending 'TODO: should only compare left and right with #eql? if they are materialized' do
-        right_body.should_not_receive(:each)
+        expect(right_body).to_not receive(:each)
         subject
       end
     end
@@ -153,13 +153,13 @@ describe Algebra::Union, '#optimize' do
 
     it 'executes left_body#each' do
       pending 'only receive #each once'
-      left_body.should_receive(:each)
+      expect(left_body).to receive(:each)
       subject
     end
 
     it 'executes right_body#each' do
       pending 'only receive #each once'
-      right_body.should_receive(:each)
+      expect(right_body).to receive(:each)
       subject
     end
 
@@ -173,12 +173,12 @@ describe Algebra::Union, '#optimize' do
     it { should be(object) }
 
     it 'executes left_body#each' do
-      left_body.should_receive(:each)
+      expect(left_body).to receive(:each)
       subject
     end
 
     it 'executes right_body#each' do
-      right_body.should_receive(:each)
+      expect(right_body).to receive(:each)
       subject
     end
 

data/spec/integration/axiom/function/optimize_spec.rb

@@ -18,7 +18,7 @@ describe Function, '#optimize' do
   end
 
   it 'calls self.class.optimizer' do
-    described_class.should_receive(:optimizer).and_return(nil)
+    expect(described_class).to receive(:optimizer).and_return(nil)
     subject
   end
 

data/spec/integration/axiom/relation/operation/limit/optimize_spec.rb

@@ -8,8 +8,8 @@ describe Relation::Operation::Limit, '#optimize' do
   let(:body)       { LazyEnumerable.new([[1], [2], [3]])  }
   let(:relation)   { Relation.new([[:id, Integer]], body) }
   let(:directions) { [relation[:id]]                      }
-  let(:order)      { relation.sort_by { directions }      }
-  let(:operand)    { order                                }
+  let(:sorted)     { relation.sort_by { directions }      }
+  let(:operand)    { sorted                               }
   let(:limit)      { 1                                    }
   let(:object)     { described_class.new(operand, limit)  }
 
@@ -23,30 +23,30 @@ describe Relation::Operation::Limit, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'containing an order operation' do
+  context 'containing a sorted operation' do
     it { should be(object) }
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'containing an optimizable order operation' do
-    let(:operand) { order.rename({}) }
+  context 'containing an optimizable sorted operation' do
+    let(:operand) { sorted.rename({}) }
 
     it { should be_kind_of(described_class) }
 
-    its(:operand) { should be(order) }
+    its(:operand) { should be(sorted) }
 
     its(:limit) { should == 1 }
 
@@ -55,7 +55,7 @@ describe Relation::Operation::Limit, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -63,12 +63,12 @@ describe Relation::Operation::Limit, '#optimize' do
   end
 
   context 'containing a more restrictive object operation' do
-    let(:operand) { order.take(5) }
-    let(:limit)   { 10            }
+    let(:operand) { sorted.take(5) }
+    let(:limit)   { 10             }
 
     it { should be_kind_of(described_class) }
 
-    its(:operand) { should be(order) }
+    its(:operand) { should be(sorted) }
 
     it 'uses the more restrictive object' do
       expect(subject.limit).to be(5)
@@ -79,7 +79,7 @@ describe Relation::Operation::Limit, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -87,12 +87,12 @@ describe Relation::Operation::Limit, '#optimize' do
   end
 
   context 'containing a less restrictive object operation' do
-    let(:operand) { order.take(10) }
-    let(:limit)   { 5              }
+    let(:operand) { sorted.take(10) }
+    let(:limit)   { 5               }
 
     it { should be_kind_of(described_class) }
 
-    its(:operand) { should be(order) }
+    its(:operand) { should be(sorted) }
 
     it 'uses the more restrictive object' do
       expect(subject.limit).to be(5)
@@ -103,7 +103,7 @@ describe Relation::Operation::Limit, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -111,8 +111,8 @@ describe Relation::Operation::Limit, '#optimize' do
   end
 
   context 'containing a similar object operation' do
-    let(:operand) { order.take(10) }
-    let(:limit)   { 10             }
+    let(:operand) { sorted.take(10) }
+    let(:limit)   { 10              }
 
     it { should be(operand) }
 
@@ -121,7 +121,7 @@ describe Relation::Operation::Limit, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 

data/spec/integration/axiom/relation/operation/offset/optimize_spec.rb

@@ -8,45 +8,45 @@ describe Relation::Operation::Offset, '#optimize' do
   let(:body)       { LazyEnumerable.new([[1], [2], [3]])  }
   let(:relation)   { Relation.new([[:id, Integer]], body) }
   let(:directions) { [relation[:id]]                      }
-  let(:order)      { relation.sort_by { directions }      }
-  let(:operand)    { order                                }
+  let(:sorted)     { relation.sort_by { directions }      }
+  let(:operand)    { sorted                               }
   let(:offset)     { 1                                    }
   let(:object)     { described_class.new(operand, offset) }
 
   context 'with an object of 0' do
     let(:offset) { 0 }
 
-    it { should be(order) }
+    it { should be(sorted) }
 
     it 'returns an equivalent relation to the unoptimized operation' do
       should == object
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'containing an order operation' do
+  context 'containing a sorted operation' do
     it { should be(object) }
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'containing an optimizable order operation' do
-    let(:operand) { order.rename({}) }
+  context 'containing an optimizable sorted operation' do
+    let(:operand) { sorted.rename({}) }
 
     it { should be_kind_of(described_class) }
 
-    its(:operand) { should be(order) }
+    its(:operand) { should be(sorted) }
 
     its(:offset) { should == 1 }
 
@@ -55,7 +55,7 @@ describe Relation::Operation::Offset, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -63,12 +63,12 @@ describe Relation::Operation::Offset, '#optimize' do
   end
 
   context 'containing an object operation' do
-    let(:operand) { order.drop(5) }
-    let(:offset)  { 10            }
+    let(:operand) { sorted.drop(5) }
+    let(:offset)  { 10             }
 
     it { should be_kind_of(described_class) }
 
-    its(:operand) { should be(order) }
+    its(:operand) { should be(sorted) }
 
     it 'adds the object of the operations' do
       expect(subject.offset).to be(15)
@@ -79,7 +79,7 @@ describe Relation::Operation::Offset, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end