axiom-optimizer 0.1.1 → 0.2.0

data/spec/integration/axiom/algebra/product/optimize_spec.rb

@@ -21,7 +21,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -38,7 +38,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
@@ -55,7 +55,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -72,7 +72,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
@@ -89,7 +89,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -106,7 +106,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
@@ -123,7 +123,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 
@@ -140,7 +140,7 @@ describe Algebra::Product, '#optimize' do
     end
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
@@ -151,12 +151,12 @@ describe Algebra::Product, '#optimize' do
     it { should be(object) }
 
     it 'does not execute left_body#each' do
-      left_body.should_not_receive(:each)
+      expect(left_body).not_to receive(:each)
       subject
     end
 
     it 'does not execute right_body#each' do
-      right_body.should_not_receive(:each)
+      expect(right_body).not_to receive(:each)
       subject
     end
 

data/spec/integration/axiom/algebra/projection/optimize_spec.rb

@@ -13,7 +13,7 @@ describe Algebra::Projection, '#optimize' do
 
   before do
     # skip dup of the body to avoid clearing the method stubs
-    body.stub(:frozen?).and_return(true)
+    allow(body).to receive(:frozen?).and_return(true)
   end
 
   context 'when the attributes are equivalent to the relation headers, and in the same order' do
@@ -26,7 +26,7 @@ describe Algebra::Projection, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -41,7 +41,7 @@ describe Algebra::Projection, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -54,7 +54,7 @@ describe Algebra::Projection, '#optimize' do
     it { should be(object) }
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -85,7 +85,7 @@ describe Algebra::Projection, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -109,7 +109,7 @@ describe Algebra::Projection, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -133,7 +133,7 @@ describe Algebra::Projection, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -158,7 +158,7 @@ describe Algebra::Projection, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -175,8 +175,8 @@ describe Algebra::Projection, '#optimize' do
 
     before do
       # skip dup of the left and right body to avoid clearing the method stubs
-      left_body.stub(:frozen?).and_return(true)
-      right_body.stub(:frozen?).and_return(true)
+      allow(left_body).to receive(:frozen?).and_return(true)
+      allow(right_body).to receive(:frozen?).and_return(true)
     end
 
     it 'pushes the object to each relation, and combine the nested objects' do
@@ -189,14 +189,14 @@ describe Algebra::Projection, '#optimize' do
 
     it 'does not execute left_body#each' do
       pending 'TODO: should only compare left and right with #eql? if they are materialized' do
-        left_body.should_not_receive(:each)
+        expect(left_body).to_not receive(:each)
         subject
       end
     end
 
     it 'does not execute right_body#each' do
       pending 'TODO: should only compare left and right with #eql? if they are materialized' do
-        right_body.should_not_receive(:each)
+        expect(right_body).to_not receive(:each)
         subject
       end
     end
@@ -222,13 +222,13 @@ describe Algebra::Projection, '#optimize' do
 
     it 'executes left_body#each' do
       pending 'TODO: make sure this is only received once'
-      left_body.should_receive(:each)
+      expect(left_body).to receive(:each)
       subject
     end
 
     it 'executes right_body#each' do
       pending 'TODO: make sure this is only received once'
-      right_body.should_receive(:each)
+      expect(right_body).to receive(:each)
       subject
     end
 

data/spec/integration/axiom/algebra/rename/optimize_spec.rb

@@ -15,7 +15,7 @@ describe Algebra::Rename, '#optimize' do
     it { should be(object) }
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -32,7 +32,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -57,7 +57,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -87,7 +87,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -116,7 +116,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -134,7 +134,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -155,7 +155,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -175,7 +175,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -196,7 +196,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -216,7 +216,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -237,7 +237,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -259,7 +259,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -270,7 +270,7 @@ describe Algebra::Rename, '#optimize' do
     let(:limit)   { relation.sort_by { |r| [r.id, r.name] }.take(2) }
     let(:operand) { limit.reverse                                   }
 
-    it 'pushes the object under the order, limit and reverse' do
+    it 'pushes the object under the sorted, limit and reverse' do
       should eql(relation.rename(aliases).sort_by { |r| [r.other_id, r.name] }.take(2).reverse)
     end
 
@@ -279,7 +279,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -291,7 +291,7 @@ describe Algebra::Rename, '#optimize' do
     let(:operand) { limit.rename(id: :other_id).reverse             }
     let(:aliases) { { other_id: :id }                               }
 
-    it 'pushes the object under the order, limit and reverse, and then cancel it out' do
+    it 'pushes the object under the sorted, limit and reverse, and then cancel it out' do
       should eql(relation.sort_by { |r| [r.id, r.name] }.take(2).reverse)
     end
 
@@ -300,17 +300,17 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'containing an order operation' do
+  context 'containing a sorted operation' do
     let(:operand) { relation.sort_by { |r| [r.id, r.name] } }
 
-    it 'pushes the object under the order' do
+    it 'pushes the object under the sorted' do
       should eql(relation.rename(aliases).sort_by { |r| [r.other_id, r.name] })
     end
 
@@ -319,18 +319,18 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
     it_should_behave_like 'an optimize method'
   end
 
-  context 'containing an order operation, containing a object that cancels out' do
+  context 'containing a sorted operation, containing a object that cancels out' do
     let(:operand) { relation.rename(id: :other_id).sort_by { |r| [r.other_id, r.name] } }
     let(:aliases) { { other_id: :id }                                                   }
 
-    it 'pushes the object under the order, and then cancel it out' do
+    it 'pushes the object under the sorted, and then cancel it out' do
       should eql(relation.sort_by { |r| [r.id, r.name] })
     end
 
@@ -339,7 +339,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -347,10 +347,10 @@ describe Algebra::Rename, '#optimize' do
   end
 
   context 'containing a limit operation' do
-    let(:order)   { relation.sort_by { |r| [r.id, r.name] } }
-    let(:operand) { order.take(2)                           }
+    let(:sorted)  { relation.sort_by { |r| [r.id, r.name] } }
+    let(:operand) { sorted.take(2)                          }
 
-    it 'pushes the object under the limit and order' do
+    it 'pushes the object under the limit and sorted' do
       should eql(relation.rename(aliases).sort_by { |r| [r.other_id, r.name] }.take(2))
     end
 
@@ -359,7 +359,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -367,11 +367,11 @@ describe Algebra::Rename, '#optimize' do
   end
 
   context 'containing a limit operation, containing a object that cancels out' do
-    let(:order)   { relation.sort_by { |r| [r.id, r.name] } }
-    let(:operand) { order.rename(id: :other_id).take(2)     }
+    let(:sorted)  { relation.sort_by { |r| [r.id, r.name] } }
+    let(:operand) { sorted.rename(id: :other_id).take(2)    }
     let(:aliases) { { other_id: :id }                       }
 
-    it 'pushes the object under the limit and order, and then cancel it out' do
+    it 'pushes the object under the limit and sorted, and then cancel it out' do
       should eql(relation.sort_by { |r| [r.id, r.name] }.take(2))
     end
 
@@ -380,7 +380,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -388,10 +388,10 @@ describe Algebra::Rename, '#optimize' do
   end
 
   context 'containing an offset operation' do
-    let(:order)   { relation.sort_by { |r| [r.id, r.name] } }
-    let(:operand) { order.drop(1)                           }
+    let(:sorted)  { relation.sort_by { |r| [r.id, r.name] } }
+    let(:operand) { sorted.drop(1)                          }
 
-    it 'pushes the object under the offset and order' do
+    it 'pushes the object under the offset and sorted' do
       should eql(relation.rename(aliases).sort_by { |r| [r.other_id, r.name] }.drop(1))
     end
 
@@ -400,7 +400,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end
 
@@ -408,11 +408,11 @@ describe Algebra::Rename, '#optimize' do
   end
 
   context 'containing an offset operation, containing a object that cancels out' do
-    let(:order)   { relation.sort_by { |r| [r.id, r.name] } }
-    let(:operand) { order.rename(id: :other_id).drop(1)     }
+    let(:sorted)  { relation.sort_by { |r| [r.id, r.name] } }
+    let(:operand) { sorted.rename(id: :other_id).drop(1)    }
     let(:aliases) { { other_id: :id }                       }
 
-    it 'pushes the object under the offset and order, and then cancel it out' do
+    it 'pushes the object under the offset and sorted, and then cancel it out' do
       should eql(relation.sort_by { |r| [r.id, r.name] }.drop(1))
     end
 
@@ -421,7 +421,7 @@ describe Algebra::Rename, '#optimize' do
     end
 
     it 'does not execute body#each' do
-      body.should_not_receive(:each)
+      expect(body).not_to receive(:each)
       subject
     end